)]}'
{"pkg/document/bundle.go":[{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"a67c6e021654c326b1301f6ee0c95d6697a5783e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"\t\"fmt\""},{"line_number":5,"context_line":"\t\"io\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\t\"sigs.k8s.io/kustomize/v3/k8sdeps/kunstruct\""},{"line_number":8,"context_line":"\t\"sigs.k8s.io/kustomize/v3/k8sdeps/transformer\""},{"line_number":9,"context_line":"\t\"sigs.k8s.io/kustomize/v3/k8sdeps/validator\""},{"line_number":10,"context_line":"\t\"sigs.k8s.io/kustomize/v3/pkg/fs\""},{"line_number":11,"context_line":"\t\"sigs.k8s.io/kustomize/v3/pkg/gvk\""},{"line_number":12,"context_line":"\t\"sigs.k8s.io/kustomize/v3/pkg/loader\""},{"line_number":13,"context_line":"\t\"sigs.k8s.io/kustomize/v3/pkg/plugins\""},{"line_number":14,"context_line":"\t\"sigs.k8s.io/kustomize/v3/pkg/resmap\""},{"line_number":15,"context_line":"\t\"sigs.k8s.io/kustomize/v3/pkg/resource\""},{"line_number":16,"context_line":"\t\"sigs.k8s.io/kustomize/v3/pkg/target\""},{"line_number":17,"context_line":"\t\"sigs.k8s.io/kustomize/v3/pkg/types\""},{"line_number":18,"context_line":"\t\"sigs.k8s.io/yaml\""},{"line_number":19,"context_line":")"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-go","patch_set":8,"id":"3fa7e38b_068edd26","line":17,"range":{"start_line":7,"start_character":0,"end_line":17,"end_character":37},"updated":"2019-10-04 15:22:47.000000000","message":"Upstream kubernetes is using kustomize v2.0.3 right now. I think version 3 breaks dependencies to client-go, in particular, it references older version of client-go v11, which in turn depends on wrong apimachinery version. So if you try to import a controller-runtime, \t\"k8s.io/kubectl/pkg/cmd/apply\", or any other libraries built on top of client-go, import fails, because of wrong functions calls, of v11 client-go. \n\nMaybe there is a an easy fix to that, but so far, i have failed to find one. So i would suggest using 2.0.3 kustomize, as in kubernetes upstream, unless i am missing something, and there is easy fix for that.","commit_id":"89a783f42a29f5291147c1956a0b3294c70b69f3"}],"pkg/document/document.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"4047967ae5b13bb8d46de9f2c06350c5393935ae","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"// NewDocument is a convenience method to construct a new Document"},{"line_number":58,"context_line":"func NewDocument(r *resource.Resource) (Document, error) {"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"\tvar doc Document \u003d \u0026DocumentFactory{}"},{"line_number":61,"context_line":"\terr :\u003d doc.SetKustomizeResource(r)"},{"line_number":62,"context_line":"\treturn doc, err"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":4,"id":"3fa7e38b_760c4394","line":62,"range":{"start_line":59,"start_character":0,"end_line":62,"end_character":16},"updated":"2019-10-02 18:28:01.000000000","message":"As is, this function can\u0027t return an error. Remove the returned error here and simply return the new object\n\nreturn \u0026DocumentFactory{Resource: r}\n\nunless there\u0027s some sort of future proofing I\u0027m missing here?","commit_id":"dfc3b1fede287afc4b0adc72e57f81d7536b2372"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"a9bc6a47a5a2fc2f6793dc4ba5527f97c209265a","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"// NewDocument is a convenience method to construct a new Document"},{"line_number":58,"context_line":"func NewDocument(r *resource.Resource) (Document, error) {"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"\tvar doc Document \u003d \u0026DocumentFactory{}"},{"line_number":61,"context_line":"\terr :\u003d doc.SetKustomizeResource(r)"},{"line_number":62,"context_line":"\treturn doc, err"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":4,"id":"3fa7e38b_b15e45e7","line":62,"range":{"start_line":59,"start_character":0,"end_line":62,"end_character":16},"in_reply_to":"3fa7e38b_760c4394","updated":"2019-10-02 18:44:01.000000000","message":"There is some futureproofing.  Perhaps I will update the comment to reflect that.  In the future, its entirely possible we massage the document before returning a Document interface, or sanity check it for Airship specific purposes, or ...","commit_id":"dfc3b1fede287afc4b0adc72e57f81d7536b2372"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"eae835c9b5904e198cc159c19dda5aeb7f7df969","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"// NewDocument is a convenience method to construct a new Document"},{"line_number":58,"context_line":"func NewDocument(r *resource.Resource) (Document, error) {"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"\tvar doc Document \u003d \u0026DocumentFactory{}"},{"line_number":61,"context_line":"\terr :\u003d doc.SetKustomizeResource(r)"},{"line_number":62,"context_line":"\treturn doc, err"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":4,"id":"3fa7e38b_4cd89a7e","line":62,"range":{"start_line":59,"start_character":0,"end_line":62,"end_character":16},"in_reply_to":"3fa7e38b_b15e45e7","updated":"2019-10-02 22:21:02.000000000","message":"sounds good to me","commit_id":"dfc3b1fede287afc4b0adc72e57f81d7536b2372"}],"pkg/document/document_test.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"4047967ae5b13bb8d46de9f2c06350c5393935ae","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\t\tt.Fatalf(\"Building Bundle Failed: %v\", err)"},{"line_number":27,"context_line":"\t}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"\trequire :\u003d assert.New(t)"},{"line_number":30,"context_line":"\tassert :\u003d assert.New(t)"},{"line_number":31,"context_line":"\trequire.NotNil(bundle)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-go","patch_set":4,"id":"3fa7e38b_965f7f71","line":29,"updated":"2019-10-02 18:28:01.000000000","message":"require","commit_id":"dfc3b1fede287afc4b0adc72e57f81d7536b2372"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"a9bc6a47a5a2fc2f6793dc4ba5527f97c209265a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\t\tt.Fatalf(\"Building Bundle Failed: %v\", err)"},{"line_number":27,"context_line":"\t}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"\trequire :\u003d assert.New(t)"},{"line_number":30,"context_line":"\tassert :\u003d assert.New(t)"},{"line_number":31,"context_line":"\trequire.NotNil(bundle)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-go","patch_set":4,"id":"3fa7e38b_1169598a","line":29,"in_reply_to":"3fa7e38b_965f7f71","updated":"2019-10-02 18:44:01.000000000","message":"Done","commit_id":"dfc3b1fede287afc4b0adc72e57f81d7536b2372"}],"testutil/testdatafs.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"4047967ae5b13bb8d46de9f2c06350c5393935ae","unresolved":false,"context_lines":[{"line_number":8,"context_line":"\t\"sigs.k8s.io/kustomize/v3/pkg/fs\""},{"line_number":9,"context_line":")"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"// SetupTestFs helps set up a fake file system with the fixtures above"},{"line_number":12,"context_line":"func SetupTestFs(t *testing.T, fixtureDir string) (fs.FileSystem, error) {"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\tx :\u003d fs.MakeFakeFS()"}],"source_content_type":"text/x-go","patch_set":4,"id":"3fa7e38b_7626836b","line":11,"range":{"start_line":11,"start_character":47,"end_line":11,"end_character":70},"updated":"2019-10-02 18:28:01.000000000","message":"looks like a copy paste error - could you change this comment be more generic?","commit_id":"dfc3b1fede287afc4b0adc72e57f81d7536b2372"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"a9bc6a47a5a2fc2f6793dc4ba5527f97c209265a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"\t\"sigs.k8s.io/kustomize/v3/pkg/fs\""},{"line_number":9,"context_line":")"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"// SetupTestFs helps set up a fake file system with the fixtures above"},{"line_number":12,"context_line":"func SetupTestFs(t *testing.T, fixtureDir string) (fs.FileSystem, error) {"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\tx :\u003d fs.MakeFakeFS()"}],"source_content_type":"text/x-go","patch_set":4,"id":"3fa7e38b_d13181a4","line":11,"range":{"start_line":11,"start_character":47,"end_line":11,"end_character":70},"in_reply_to":"3fa7e38b_7626836b","updated":"2019-10-02 18:44:01.000000000","message":"Done","commit_id":"dfc3b1fede287afc4b0adc72e57f81d7536b2372"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"4047967ae5b13bb8d46de9f2c06350c5393935ae","unresolved":false,"context_lines":[{"line_number":9,"context_line":")"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"// SetupTestFs helps set up a fake file system with the fixtures above"},{"line_number":12,"context_line":"func SetupTestFs(t *testing.T, fixtureDir string) (fs.FileSystem, error) {"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\tx :\u003d fs.MakeFakeFS()"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-go","patch_set":4,"id":"3fa7e38b_965d3feb","line":12,"range":{"start_line":12,"start_character":64,"end_line":12,"end_character":71},"updated":"2019-10-02 18:28:01.000000000","message":"Don\u0027t let this function return errors - if something goes wrong here, we need to t.Fatal","commit_id":"dfc3b1fede287afc4b0adc72e57f81d7536b2372"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"a9bc6a47a5a2fc2f6793dc4ba5527f97c209265a","unresolved":false,"context_lines":[{"line_number":9,"context_line":")"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"// SetupTestFs helps set up a fake file system with the fixtures above"},{"line_number":12,"context_line":"func SetupTestFs(t *testing.T, fixtureDir string) (fs.FileSystem, error) {"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\tx :\u003d fs.MakeFakeFS()"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-go","patch_set":4,"id":"3fa7e38b_71268d6b","line":12,"range":{"start_line":12,"start_character":64,"end_line":12,"end_character":71},"in_reply_to":"3fa7e38b_965d3feb","updated":"2019-10-02 18:44:01.000000000","message":"Done","commit_id":"dfc3b1fede287afc4b0adc72e57f81d7536b2372"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"4047967ae5b13bb8d46de9f2c06350c5393935ae","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\t\t}"},{"line_number":27,"context_line":"\t\t// nolint: errcheck"},{"line_number":28,"context_line":"\t\tx.WriteFile(filepath.Join(\"/\", file.Name()), fileBytes)"},{"line_number":29,"context_line":"\t\tt.Logf(\"Writing %s\\n\", filePath)"},{"line_number":30,"context_line":"\t}"},{"line_number":31,"context_line":"\treturn x, nil"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-go","patch_set":4,"id":"3fa7e38b_b6d15b32","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":34},"updated":"2019-10-02 18:28:01.000000000","message":"I don\u0027t think I like this - it\u0027s going to create a lot of cruft in the output while testing","commit_id":"dfc3b1fede287afc4b0adc72e57f81d7536b2372"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"d9a67608d6f1f54154645b060549d126633c5c2e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\t\t}"},{"line_number":27,"context_line":"\t\t// nolint: errcheck"},{"line_number":28,"context_line":"\t\tx.WriteFile(filepath.Join(\"/\", file.Name()), fileBytes)"},{"line_number":29,"context_line":"\t\tt.Logf(\"Writing %s\\n\", filePath)"},{"line_number":30,"context_line":"\t}"},{"line_number":31,"context_line":"\treturn x, nil"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-go","patch_set":4,"id":"3fa7e38b_913c62c0","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":34},"in_reply_to":"3fa7e38b_b6d15b32","updated":"2019-10-03 02:29:07.000000000","message":"Agreed — Left behind from debugging.  Good catch. I will remove.","commit_id":"dfc3b1fede287afc4b0adc72e57f81d7536b2372"}]}