)]}'
{"Makefile":[{"author":{"_account_id":30797,"name":"kanwar saad bin liaqat","email":"kanwar.sbl@gmail.com","username":"ekanwli"},"change_message_id":"c0a7666b2eccfc869103277eefc11b9d3154479a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"\tmkdir -p $(TOOLBINDIR)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"$(LINTER): $(TOOLBINDIR)"},{"line_number":93,"context_line":"\tcurl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./$(TOOLBINDIR) v1.21.0"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":".PHONY: update-golden"},{"line_number":96,"context_line":"update-golden: delete-golden"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa7e38b_d6c5b03e","line":93,"range":{"start_line":93,"start_character":85,"end_line":93,"end_character":86},"updated":"2019-10-24 07:38:05.000000000","message":"maybe split this line into two.","commit_id":"7f327dcd7ddb59740df47ef73aefbbb8222d1352"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"33f67b7fc1fdbca5651523b1ba94b3dd560f627c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"\tmkdir -p $(TOOLBINDIR)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"$(LINTER): $(TOOLBINDIR)"},{"line_number":93,"context_line":"\tcurl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./$(TOOLBINDIR) v1.21.0"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":".PHONY: update-golden"},{"line_number":96,"context_line":"update-golden: delete-golden"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa7e38b_bbe30905","line":93,"range":{"start_line":93,"start_character":85,"end_line":93,"end_character":86},"in_reply_to":"3fa7e38b_d6c5b03e","updated":"2019-10-28 14:27:26.000000000","message":"I moved the offending line into a script and parameterized its arguments to shorten it up","commit_id":"7f327dcd7ddb59740df47ef73aefbbb8222d1352"}],"tools/install_linter":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"6a601ef9076ea762a6c77577b8fe3f10439add40","unresolved":false,"context_lines":[{"line_number":4,"context_line":"download_url\u003dhttps://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh"},{"line_number":5,"context_line":"version\u003dv1.21.0"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if ! curl -sfL \"$download_url\" | sh -s -- -b \"$tools_bin_dir/bin\" \"$version\"; then"},{"line_number":8,"context_line":"  printf \"Something went wrong while installing golangci-lint\\n\""},{"line_number":9,"context_line":"  exit 1"},{"line_number":10,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_325c0c4a","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":2},"updated":"2019-10-29 11:06:39.000000000","message":"we can put \u0027set -xeu\u0027 at the beginning of the script and we do not need to check exit code explicitly","commit_id":"463786a1cacc6510cf2e8a2ab380460b93bd7bb8"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"cafa01be878fc04a116774a7b69ec2a513d7e71d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"download_url\u003dhttps://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh"},{"line_number":5,"context_line":"version\u003dv1.21.0"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if ! curl -sfL \"$download_url\" | sh -s -- -b \"$tools_bin_dir/bin\" \"$version\"; then"},{"line_number":8,"context_line":"  printf \"Something went wrong while installing golangci-lint\\n\""},{"line_number":9,"context_line":"  exit 1"},{"line_number":10,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_55040fc6","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":2},"in_reply_to":"3fa7e38b_325c0c4a","updated":"2019-10-29 14:56:50.000000000","message":"I do\u0027t see how `set -e` helps here...\n\nThe script at `download_url` can potentially fail but not provide any output, which makes debugging difficult. The purpose of this script is to provide that output","commit_id":"463786a1cacc6510cf2e8a2ab380460b93bd7bb8"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"83cf75b4df90422eeb44c710a9bb237a21b9dfb3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"download_url\u003dhttps://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh"},{"line_number":5,"context_line":"version\u003dv1.21.0"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if ! curl -sfL \"$download_url\" | sh -s -- -b \"$tools_bin_dir/bin\" \"$version\"; then"},{"line_number":8,"context_line":"  printf \"Something went wrong while installing golangci-lint\\n\""},{"line_number":9,"context_line":"  exit 1"},{"line_number":10,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_54ae432e","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":2},"in_reply_to":"3fa7e38b_55040fc6","updated":"2019-10-30 10:53:59.000000000","message":"Fair enough. That being said we may still want to have \u0027set -x\u0027","commit_id":"463786a1cacc6510cf2e8a2ab380460b93bd7bb8"}]}