)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"f00351166018ead0ad7a809a4c102943da852e55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3fa7e38b_79c86f73","updated":"2019-10-24 08:56:25.000000000","message":"Commit message seems to be not relevant.","commit_id":"dad90a512756da16b55d60b44e2f5259f484b950"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"442ef3129955fc3e38c52f79c7f652060beb089f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added role install-vbmc"},{"line_number":10,"context_line":"Added job to check pipeline"},{"line_number":11,"context_line":"Corrected roles for yaml lint errors"},{"line_number":12,"context_line":"Change-Id: I65b3558f1209e4735a039ad68c1ac7a9af1f1b1b"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I65b3558f1209e4735a039ad68c1ac7a9af1f1b1b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_f070bb74","line":11,"updated":"2019-10-28 15:42:04.000000000","message":"I don\u0027t think this line is necessary - this seems to be a change in a specific PS, not something that was changed in the commit","commit_id":"0cfc1fc138a67eae6b4307bfe0055c459f06f465"},{"author":{"_account_id":30885,"name":"Deepak","email":"deepak.jadiya@dell.com","username":"dddpak"},"change_message_id":"ae93448827f5c9b388c00d790c0c2264b2696d0c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added role install-vbmc"},{"line_number":10,"context_line":"Added job to check pipeline"},{"line_number":11,"context_line":"Corrected roles for yaml lint errors"},{"line_number":12,"context_line":"Change-Id: I65b3558f1209e4735a039ad68c1ac7a9af1f1b1b"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I65b3558f1209e4735a039ad68c1ac7a9af1f1b1b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_1f4d493a","line":11,"in_reply_to":"3fa7e38b_f070bb74","updated":"2019-10-30 09:31:36.000000000","message":"Done","commit_id":"0cfc1fc138a67eae6b4307bfe0055c459f06f465"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"442ef3129955fc3e38c52f79c7f652060beb089f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added role install-vbmc"},{"line_number":10,"context_line":"Added job to check pipeline"},{"line_number":11,"context_line":"Corrected roles for yaml lint errors"},{"line_number":12,"context_line":"Change-Id: I65b3558f1209e4735a039ad68c1ac7a9af1f1b1b"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I65b3558f1209e4735a039ad68c1ac7a9af1f1b1b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_7065abb4","line":12,"updated":"2019-10-28 15:42:04.000000000","message":"This line needs to be deleted","commit_id":"0cfc1fc138a67eae6b4307bfe0055c459f06f465"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"b8f7218e33fd27aa98e5c91e8173b1856f119bb7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     dddpak \u003cdeepak.jadiya@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-10-30 12:12:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"AIR-61 - gate test added in zuul for vbmc"},{"line_number":8,"context_line":"Added role install-vbmc, pipeline"},{"line_number":9,"context_line":"Change-Id: I65b3558f1209e4735a039ad68c1ac7a9af1f1b1b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_45668fef","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":41},"updated":"2019-10-30 13:35:32.000000000","message":"1. add empty line after commit subject\n2. it\u0027s recommended to use Present Tense for commit message subject","commit_id":"825dd5f68242c4941bb883cb5f2b59d0abafee1e"},{"author":{"_account_id":7321,"name":"Prakash Ramchandran","email":"pramchan@yahoo.com","username":"pramchan"},"change_message_id":"9e873de471959836d4118d8c656de5c6061a8aa8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     dddpak \u003cdeepak.jadiya@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-10-30 12:12:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"AIR-61 - gate test added in zuul for vbmc"},{"line_number":8,"context_line":"Added role install-vbmc, pipeline"},{"line_number":9,"context_line":"Change-Id: I65b3558f1209e4735a039ad68c1ac7a9af1f1b1b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_bcc75945","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":41},"in_reply_to":"3fa7e38b_45668fef","updated":"2020-02-12 17:42:51.000000000","message":"Done","commit_id":"825dd5f68242c4941bb883cb5f2b59d0abafee1e"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"b8f7218e33fd27aa98e5c91e8173b1856f119bb7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"AIR-61 - gate test added in zuul for vbmc"},{"line_number":8,"context_line":"Added role install-vbmc, pipeline"},{"line_number":9,"context_line":"Change-Id: I65b3558f1209e4735a039ad68c1ac7a9af1f1b1b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_a59ae3c1","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":52},"updated":"2019-10-30 13:35:32.000000000","message":"Add empty line before Change-Id","commit_id":"825dd5f68242c4941bb883cb5f2b59d0abafee1e"},{"author":{"_account_id":7321,"name":"Prakash Ramchandran","email":"pramchan@yahoo.com","username":"pramchan"},"change_message_id":"9e873de471959836d4118d8c656de5c6061a8aa8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"AIR-61 - gate test added in zuul for vbmc"},{"line_number":8,"context_line":"Added role install-vbmc, pipeline"},{"line_number":9,"context_line":"Change-Id: I65b3558f1209e4735a039ad68c1ac7a9af1f1b1b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_5cc2e535","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":52},"in_reply_to":"3fa7e38b_a59ae3c1","updated":"2020-02-12 17:42:51.000000000","message":"Done","commit_id":"825dd5f68242c4941bb883cb5f2b59d0abafee1e"}],"playbooks/airship-airshipctl-deploy-vbmc.yaml":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"cb17cfa82b875ed01794cb5370ade734a75d0e07","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":12,"context_line":"# limitations under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- hosts: primary"},{"line_number":15,"context_line":"  roles:"},{"line_number":16,"context_line":"    - install-vbmc"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_b419b788","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":18},"updated":"2019-10-30 11:04:23.000000000","message":"Why do we need a role here ?","commit_id":"97c51c6d0e6d6ccdb972deaec4edac6a533bf1ba"},{"author":{"_account_id":30885,"name":"Deepak","email":"deepak.jadiya@dell.com","username":"dddpak"},"change_message_id":"0c1d34c22aba404254236390973f828ae4d1d24b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":12,"context_line":"# limitations under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- hosts: primary"},{"line_number":15,"context_line":"  roles:"},{"line_number":16,"context_line":"    - install-vbmc"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_e7c0e32d","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":18},"in_reply_to":"3fa7e38b_b419b788","updated":"2019-10-31 04:00:51.000000000","message":"\u003e Why do we need a role here ?\n\nMy PatchSet 1, received comment to add role.\nWithout role, back-end Ubuntu VM, I suppose was not getting created for testing to happen in check pipeline","commit_id":"97c51c6d0e6d6ccdb972deaec4edac6a533bf1ba"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"1ff65a62179710920da9e6c71910c364483e3afe","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":12,"context_line":"# limitations under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- hosts: primary"},{"line_number":15,"context_line":"  roles:"},{"line_number":16,"context_line":"    - install-vbmc"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_26410f0b","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":18},"in_reply_to":"3fa7e38b_e7c0e32d","updated":"2019-10-31 09:11:39.000000000","message":"You misread comment from Roman. You have assigned role to host in PS1 but there was no a definition of this role.\n\nWhat I\u0027m proposing: \n1. We do not need to define explicit role for vbmc \n2. We can use pre-run option for job (e.g. airship-airshipctl-lint-unit). Pre-run is a playbook which is executed before actual job and it\u0027s purpose to prepare node for tests (e.g. install sushy-tools in our case)\n\nTherefore we do not need to crate specific role for vbmc we just need to install test prerequisites before gate execution","commit_id":"97c51c6d0e6d6ccdb972deaec4edac6a533bf1ba"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"ad598bb001c024151d0e0d1c176ea312e6e2718e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"                  set -xe"},{"line_number":23,"context_line":"                  apt update -qq -y"},{"line_number":24,"context_line":"                  apt install -qq -y git python3-setuptools qemu qemu-kvm libvirt-bin virtinst qemu-utils ovmf"},{"line_number":25,"context_line":"                  apt install qq -y python3-requests nginx libvirt-daemon virt-manager "},{"line_number":26,"context_line":"                  apt -qq -y install python3-pip"},{"line_number":27,"context_line":"                  pip3 install flask"},{"line_number":28,"context_line":"                  apt install -qq -y python3-libvirt python-libvirt"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_927a1d75","line":25,"updated":"2019-11-08 04:55:14.000000000","message":"trailing whitespaces","commit_id":"b78e468610a4d935a15a43d763a1d5206ca9bac4"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"ad598bb001c024151d0e0d1c176ea312e6e2718e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                  apt -qq -y install python3-pip"},{"line_number":27,"context_line":"                  pip3 install flask"},{"line_number":28,"context_line":"                  apt install -qq -y python3-libvirt python-libvirt"},{"line_number":29,"context_line":"                  git clone https://opendev.org/openstack/sushy-tools.git"},{"line_number":30,"context_line":"                  cd sushy-tools/"},{"line_number":31,"context_line":"                  python3 setup.py build"},{"line_number":32,"context_line":"                  python3 setup.py install"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_32b9e914","line":29,"range":{"start_line":29,"start_character":18,"end_line":29,"end_character":73},"updated":"2019-11-08 04:55:14.000000000","message":"pip install git+https://...","commit_id":"b78e468610a4d935a15a43d763a1d5206ca9bac4"},{"author":{"_account_id":30885,"name":"Deepak","email":"deepak.jadiya@dell.com","username":"dddpak"},"change_message_id":"3a411de37e5793c9fe2f3b4e66a83c3b9d5d2e66","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                  apt -qq -y install python3-pip"},{"line_number":27,"context_line":"                  pip3 install flask"},{"line_number":28,"context_line":"                  apt install -qq -y python3-libvirt python-libvirt"},{"line_number":29,"context_line":"                  git clone https://opendev.org/openstack/sushy-tools.git"},{"line_number":30,"context_line":"                  cd sushy-tools/"},{"line_number":31,"context_line":"                  python3 setup.py build"},{"line_number":32,"context_line":"                  python3 setup.py install"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_e1a7f3bb","line":29,"range":{"start_line":29,"start_character":18,"end_line":29,"end_character":73},"in_reply_to":"3fa7e38b_32b9e914","updated":"2019-11-15 14:55:36.000000000","message":"\u003e pip install git+https://...\n\nJohn williams already clarified, why he wants to use git clone earlier.","commit_id":"b78e468610a4d935a15a43d763a1d5206ca9bac4"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"ad598bb001c024151d0e0d1c176ea312e6e2718e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"          become_user: root"},{"line_number":41,"context_line":"          shell: |-"},{"line_number":42,"context_line":"                  set -xe"},{"line_number":43,"context_line":"                  tmpfile\u003d$(mktemp /tmp/sushy-domain.XXXXXX)"},{"line_number":44,"context_line":"                  virt-install \\"},{"line_number":45,"context_line":"                     --name vbmc-node \\"},{"line_number":46,"context_line":"                     --ram 1024 \\"},{"line_number":47,"context_line":"                     --boot uefi \\"},{"line_number":48,"context_line":"                     --disk size\u003d1 \\"},{"line_number":49,"context_line":"                     --vcpus 2 \\"},{"line_number":50,"context_line":"                     --os-type linux \\"},{"line_number":51,"context_line":"                     --os-variant fedora28 \\"},{"line_number":52,"context_line":"                     --graphics vnc \\"},{"line_number":53,"context_line":"                     --print-xml \u003e $tmpfile"},{"line_number":54,"context_line":"                  virsh define --file $tmpfile"},{"line_number":55,"context_line":"                  rm $tmpfile"},{"line_number":56,"context_line":"          args:"},{"line_number":57,"context_line":"              executable: /bin/bash"},{"line_number":58,"context_line":"    - name: Obtain vbmc-node ip address "}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_f2d3515e","line":55,"range":{"start_line":43,"start_character":0,"end_line":55,"end_character":29},"updated":"2019-11-08 04:55:14.000000000","message":"lets put it to bash script somewhere to allow developer perform the same operations without having ansible","commit_id":"b78e468610a4d935a15a43d763a1d5206ca9bac4"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"558dbaf55130cf6787004cfeb53203b5347667e4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"          become_user: root"},{"line_number":41,"context_line":"          shell: |-"},{"line_number":42,"context_line":"                  set -xe"},{"line_number":43,"context_line":"                  tmpfile\u003d$(mktemp /tmp/sushy-domain.XXXXXX)"},{"line_number":44,"context_line":"                  virt-install \\"},{"line_number":45,"context_line":"                     --name vbmc-node \\"},{"line_number":46,"context_line":"                     --ram 1024 \\"},{"line_number":47,"context_line":"                     --boot uefi \\"},{"line_number":48,"context_line":"                     --disk size\u003d1 \\"},{"line_number":49,"context_line":"                     --vcpus 2 \\"},{"line_number":50,"context_line":"                     --os-type linux \\"},{"line_number":51,"context_line":"                     --os-variant fedora28 \\"},{"line_number":52,"context_line":"                     --graphics vnc \\"},{"line_number":53,"context_line":"                     --print-xml \u003e $tmpfile"},{"line_number":54,"context_line":"                  virsh define --file $tmpfile"},{"line_number":55,"context_line":"                  rm $tmpfile"},{"line_number":56,"context_line":"          args:"},{"line_number":57,"context_line":"              executable: /bin/bash"},{"line_number":58,"context_line":"    - name: Obtain vbmc-node ip address "}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_08b5a032","line":55,"range":{"start_line":43,"start_character":0,"end_line":55,"end_character":29},"in_reply_to":"3fa7e38b_f2d3515e","updated":"2019-11-08 08:54:42.000000000","message":"I would be against this change, and prefer to have everything in ansible, and not in \u0027shell\u0027 directive. There are jinja templates anyway, which would need to be processed by Ansible. Logging in shell code is worse than in ansible aoutput processed by zuul, and there are other reasons to use only ansible.","commit_id":"b78e468610a4d935a15a43d763a1d5206ca9bac4"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"ad598bb001c024151d0e0d1c176ea312e6e2718e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                  rm $tmpfile"},{"line_number":56,"context_line":"          args:"},{"line_number":57,"context_line":"              executable: /bin/bash"},{"line_number":58,"context_line":"    - name: Obtain vbmc-node ip address "},{"line_number":59,"context_line":"      block:"},{"line_number":60,"context_line":"        - name: \"Obtain vbmc node ip address\""},{"line_number":61,"context_line":"          when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_b27f1965","line":58,"range":{"start_line":58,"start_character":39,"end_line":58,"end_character":40},"updated":"2019-11-08 04:55:14.000000000","message":"ditto","commit_id":"b78e468610a4d935a15a43d763a1d5206ca9bac4"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"ad598bb001c024151d0e0d1c176ea312e6e2718e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"          register: vbmc_node_ip"},{"line_number":68,"context_line":"          args:"},{"line_number":69,"context_line":"              executable: /bin/bash"},{"line_number":70,"context_line":"          - copy: "},{"line_number":71,"context_line":"              content: \"{{ vbmc_node_ip }}\" "},{"line_number":72,"context_line":"              dest: ../vars/emulatorvars.yaml"},{"line_number":73,"context_line":"              follow: no"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_5294a58c","line":70,"range":{"start_line":70,"start_character":17,"end_line":70,"end_character":18},"updated":"2019-11-08 04:55:14.000000000","message":"ditto","commit_id":"b78e468610a4d935a15a43d763a1d5206ca9bac4"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"ad598bb001c024151d0e0d1c176ea312e6e2718e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"          args:"},{"line_number":69,"context_line":"              executable: /bin/bash"},{"line_number":70,"context_line":"          - copy: "},{"line_number":71,"context_line":"              content: \"{{ vbmc_node_ip }}\" "},{"line_number":72,"context_line":"              dest: ../vars/emulatorvars.yaml"},{"line_number":73,"context_line":"              follow: no"},{"line_number":74,"context_line":"    - name: Download redfish tools and Copy redfish emulator configuration"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_7291a19a","line":71,"range":{"start_line":71,"start_character":43,"end_line":71,"end_character":44},"updated":"2019-11-08 04:55:14.000000000","message":"ditto","commit_id":"b78e468610a4d935a15a43d763a1d5206ca9bac4"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"ad598bb001c024151d0e0d1c176ea312e6e2718e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                  cp /tmp/redfishd.service /etc/systemd/system"},{"line_number":109,"context_line":"                  systemctl start redfishd"},{"line_number":110,"context_line":"                  systemctl status redfishd"},{"line_number":111,"context_line":"                  systemctl enable redfishd "},{"line_number":112,"context_line":"          args:"},{"line_number":113,"context_line":"              executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_128e2d79","line":111,"range":{"start_line":111,"start_character":43,"end_line":111,"end_character":44},"updated":"2019-11-08 04:55:14.000000000","message":"ditto","commit_id":"b78e468610a4d935a15a43d763a1d5206ca9bac4"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"6fec92e279efe6ac062c2595f34b582cd89e3326","unresolved":false,"context_lines":[{"line_number":18,"context_line":"          when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":19,"context_line":"          become: true"},{"line_number":20,"context_line":"          become_user: root"},{"line_number":21,"context_line":"          shell: |-"},{"line_number":22,"context_line":"                  set -xe"},{"line_number":23,"context_line":"                  apt update -qq -y"},{"line_number":24,"context_line":"                  apt install -qq -y git python3-setuptools qemu qemu-kvm libvirt-bin virtinst qemu-utils ovmf"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"3fa7e38b_5ba57202","line":21,"updated":"2019-11-13 14:28:50.000000000","message":"So keep in mind Deepak, when we said it would be useful for the playbooks to call out to shell scripts similar to what the openstack-helm gets do - what was meant here is self-contained shell scripts separate from the ansible job itself.  The value was that these scripts could then serve two purposes: developer environment setup (not every developers knows how to run ansible but they know how to run shell scripts), and the gates could also use them.  This embedding of shell in ansible is the worst of both worlds.","commit_id":"eaf6e500fc1acb18828db3413bf1ae2f918ec5f5"},{"author":{"_account_id":30885,"name":"Deepak","email":"deepak.jadiya@dell.com","username":"dddpak"},"change_message_id":"3a411de37e5793c9fe2f3b4e66a83c3b9d5d2e66","unresolved":false,"context_lines":[{"line_number":18,"context_line":"          when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":19,"context_line":"          become: true"},{"line_number":20,"context_line":"          become_user: root"},{"line_number":21,"context_line":"          shell: |-"},{"line_number":22,"context_line":"                  set -xe"},{"line_number":23,"context_line":"                  apt update -qq -y"},{"line_number":24,"context_line":"                  apt install -qq -y git python3-setuptools qemu qemu-kvm libvirt-bin virtinst qemu-utils ovmf"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"3fa7e38b_3edae44a","line":21,"in_reply_to":"3fa7e38b_5ba57202","updated":"2019-11-15 14:55:36.000000000","message":"\u003e So keep in mind Deepak, when we said it would be useful for the\n \u003e playbooks to call out to shell scripts similar to what the\n \u003e openstack-helm gets do - what was meant here is self-contained\n \u003e shell scripts separate from the ansible job itself.  The value was\n \u003e that these scripts could then serve two purposes: developer\n \u003e environment setup (not every developers knows how to run ansible\n \u003e but they know how to run shell scripts), and the gates could also\n \u003e use them.  This embedding of shell in ansible is the worst of both\n \u003e worlds.\n\nI get that, building on reusable module instead of shell, would be longer to get it working.","commit_id":"eaf6e500fc1acb18828db3413bf1ae2f918ec5f5"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3c1bdbd8b35cfdbff8a818020dedd688b5c82853","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":99,"id":"3fa7e38b_1f821f53","updated":"2020-01-07 15:22:30.000000000","message":"i don\u0027t see vbmc used here, would it not make sense to update to redfish/sushi?","commit_id":"a5eeda6932cb38991c726956a5d5fd9b08b3711c"},{"author":{"_account_id":31089,"name":"John Williams","email":"jtwill98@yahoo.com","username":"jtwill98"},"change_message_id":"26d07bdfed1df9593238ab2f341593362a09fbcc","unresolved":false,"context_lines":[{"line_number":53,"context_line":"              chdir: /home/zuul"},{"line_number":54,"context_line":"              executable: /bin/bash"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        - name: \"Git clone sushy-tools\""},{"line_number":57,"context_line":"          command: git clone https://github.com/dddpak2018/redfish_tools.git"},{"line_number":58,"context_line":"          args:"},{"line_number":59,"context_line":"              chdir: /home/zuul"}],"source_content_type":"text/x-yaml","patch_set":127,"id":"3fa7e38b_676b01ee","line":56,"updated":"2020-02-04 21:35:43.000000000","message":"Rename this to git clone redfish tools","commit_id":"914d117660201194a1f91bebee2d208a7cdf8f48"}],"playbooks/airship-airshipctl-sushy-check.yaml":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"1e281ce3dd0e5384778fc8bae8d5d1192a6410d0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                  cd sushy-tools"},{"line_number":24,"context_line":"                  apt install python3-pip"},{"line_number":25,"context_line":"                  pip3 install oslotest"},{"line_number":26,"context_line":"                  python3 -m unittest tests/unit/emulator/test_memoize.py"},{"line_number":27,"context_line":"          args:"},{"line_number":28,"context_line":"              executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_5e605ca5","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":73},"updated":"2019-11-05 13:12:35.000000000","message":"why are we running unit tests for sushy tool?","commit_id":"1df1d3d53bfe7ee48d3ee8031325981177fb93f0"},{"author":{"_account_id":30885,"name":"Deepak","email":"deepak.jadiya@dell.com","username":"dddpak"},"change_message_id":"3a411de37e5793c9fe2f3b4e66a83c3b9d5d2e66","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                  cd sushy-tools"},{"line_number":24,"context_line":"                  apt install python3-pip"},{"line_number":25,"context_line":"                  pip3 install oslotest"},{"line_number":26,"context_line":"                  python3 -m unittest tests/unit/emulator/test_memoize.py"},{"line_number":27,"context_line":"          args:"},{"line_number":28,"context_line":"              executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_6a4d5398","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":73},"in_reply_to":"3fa7e38b_5e605ca5","updated":"2019-11-15 14:55:36.000000000","message":"\u003e why are we running unit tests for sushy tool?\n\nredfish api is not yet up, that is why.","commit_id":"1df1d3d53bfe7ee48d3ee8031325981177fb93f0"}],"roles/install-vbmc/tasks/main.yaml":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"5630215b8576146541999f6d789506d0dcae2c48","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":"# #"},{"line_number":4,"context_line":"# # Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# # you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"# # You may obtain a copy of the License at"},{"line_number":7,"context_line":"# #"},{"line_number":8,"context_line":"# #     http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":"# #"},{"line_number":10,"context_line":"# # Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"# # distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":12,"context_line":"# # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"# # See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# # limitations under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"- block:"},{"line_number":17,"context_line":"  - name: \"Install sushy tools\""},{"line_number":18,"context_line":"    when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_bf9a325f","line":15,"range":{"start_line":1,"start_character":0,"end_line":15,"end_character":1},"updated":"2019-10-25 07:06:27.000000000","message":"Format copyright header in a proper way\n- remove empty line at the beginning\n- leave only one sharp sigh at the beginning of the line","commit_id":"0cfc1fc138a67eae6b4307bfe0055c459f06f465"},{"author":{"_account_id":30885,"name":"Deepak","email":"deepak.jadiya@dell.com","username":"dddpak"},"change_message_id":"ae93448827f5c9b388c00d790c0c2264b2696d0c","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":"# #"},{"line_number":4,"context_line":"# # Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# # you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"# # You may obtain a copy of the License at"},{"line_number":7,"context_line":"# #"},{"line_number":8,"context_line":"# #     http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":"# #"},{"line_number":10,"context_line":"# # Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"# # distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":12,"context_line":"# # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"# # See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# # limitations under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"- block:"},{"line_number":17,"context_line":"  - name: \"Install sushy tools\""},{"line_number":18,"context_line":"    when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_bf3675b3","line":15,"range":{"start_line":1,"start_character":0,"end_line":15,"end_character":1},"in_reply_to":"3fa7e38b_bf9a325f","updated":"2019-10-30 09:31:36.000000000","message":"Done","commit_id":"0cfc1fc138a67eae6b4307bfe0055c459f06f465"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"5630215b8576146541999f6d789506d0dcae2c48","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    shell: |-"},{"line_number":22,"context_line":"            set -xe"},{"line_number":23,"context_line":"            apt-get install -y git-core"},{"line_number":24,"context_line":"            git clone https://opendev.org/openstack/sushy-tools.git"},{"line_number":25,"context_line":"            cd sushy-tools/"},{"line_number":26,"context_line":"            python3 setup.py build"},{"line_number":27,"context_line":"            python3 setup.py install"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_3fbf22ab","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":67},"updated":"2019-10-25 07:06:27.000000000","message":"In this case we are goiing to use master. I guess we should stick to the particular version of sushy tool and use \u0027pip install\u0027 instead of git clone","commit_id":"0cfc1fc138a67eae6b4307bfe0055c459f06f465"},{"author":{"_account_id":30885,"name":"Deepak","email":"deepak.jadiya@dell.com","username":"dddpak"},"change_message_id":"0c1d34c22aba404254236390973f828ae4d1d24b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    shell: |-"},{"line_number":22,"context_line":"            set -xe"},{"line_number":23,"context_line":"            apt-get install -y git-core"},{"line_number":24,"context_line":"            git clone https://opendev.org/openstack/sushy-tools.git"},{"line_number":25,"context_line":"            cd sushy-tools/"},{"line_number":26,"context_line":"            python3 setup.py build"},{"line_number":27,"context_line":"            python3 setup.py install"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_b11309b8","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":67},"in_reply_to":"3fa7e38b_3fbf22ab","updated":"2019-10-31 04:00:51.000000000","message":"\u003e In this case we are goiing to use master. I guess we should stick\n \u003e to the particular version of sushy tool and use \u0027pip install\u0027\n \u003e instead of git clone\n\nWill correct to pip, as we do more exhaustive test.\nFor now intent was to get something working on spun-up back-end Ubuntu VM, along the lines of JT williams documentation.","commit_id":"0cfc1fc138a67eae6b4307bfe0055c459f06f465"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"65a0f82d4e8f6b9d8be403e9ce58949d1fc184eb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    shell: |-"},{"line_number":22,"context_line":"            set -xe"},{"line_number":23,"context_line":"            apt-get install -y git-core"},{"line_number":24,"context_line":"            git clone https://opendev.org/openstack/sushy-tools.git"},{"line_number":25,"context_line":"            cd sushy-tools/"},{"line_number":26,"context_line":"            python3 setup.py build"},{"line_number":27,"context_line":"            python3 setup.py install"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_32e6f7b1","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":67},"in_reply_to":"3fa7e38b_8e3faa23","updated":"2019-11-05 08:03:36.000000000","message":"Can we stick to particular commit or version that satisfies all requirements ?\nmore over we can replase all this code pip install git+https://opendev.org/openstack/sushy-tools.git","commit_id":"0cfc1fc138a67eae6b4307bfe0055c459f06f465"},{"author":{"_account_id":31089,"name":"John Williams","email":"jtwill98@yahoo.com","username":"jtwill98"},"change_message_id":"fc50931fd08111b40644eec8b1987c9fe600e7a6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    shell: |-"},{"line_number":22,"context_line":"            set -xe"},{"line_number":23,"context_line":"            apt-get install -y git-core"},{"line_number":24,"context_line":"            git clone https://opendev.org/openstack/sushy-tools.git"},{"line_number":25,"context_line":"            cd sushy-tools/"},{"line_number":26,"context_line":"            python3 setup.py build"},{"line_number":27,"context_line":"            python3 setup.py install"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_8e3faa23","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":67},"in_reply_to":"3fa7e38b_b11309b8","updated":"2019-11-01 13:36:24.000000000","message":"The reason we went with the git clone from master method is the pip install method didn\u0027t have the Uefi boot support.  Talking with the ironic team and Ilya who supports sushy-tools, the redfish emulator, it was recommended we clone the code from master.","commit_id":"0cfc1fc138a67eae6b4307bfe0055c459f06f465"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"cb17cfa82b875ed01794cb5370ade734a75d0e07","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":2,"context_line":"# #"},{"line_number":3,"context_line":"# # Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# # you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# # You may obtain a copy of the License at"},{"line_number":6,"context_line":"# #"},{"line_number":7,"context_line":"# #     http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":8,"context_line":"# #"},{"line_number":9,"context_line":"# # Unless required by applicable law or agreed to in writing, software"},{"line_number":10,"context_line":"# # distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":11,"context_line":"# # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":12,"context_line":"# # See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# # limitations under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"- block:"},{"line_number":16,"context_line":"  - name: \"Install sushy tools\""},{"line_number":17,"context_line":"    when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_540ac325","line":14,"range":{"start_line":1,"start_character":0,"end_line":14,"end_character":1},"updated":"2019-10-30 11:04:23.000000000","message":"It was not done.\nSee an example of copyright header here https://opendev.org/airship/airshipctl/src/branch/master/playbooks/airship-airshipctl-functional-existing-k8s.yaml","commit_id":"97c51c6d0e6d6ccdb972deaec4edac6a533bf1ba"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"cb17cfa82b875ed01794cb5370ade734a75d0e07","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":2,"context_line":"# #"},{"line_number":3,"context_line":"# # Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# # you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# # You may obtain a copy of the License at"},{"line_number":6,"context_line":"# #"},{"line_number":7,"context_line":"# #     http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":8,"context_line":"# #"},{"line_number":9,"context_line":"# # Unless required by applicable law or agreed to in writing, software"},{"line_number":10,"context_line":"# # distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":11,"context_line":"# # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":12,"context_line":"# # See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# # limitations under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"- block:"},{"line_number":16,"context_line":"  - name: \"Install sushy tools\""},{"line_number":17,"context_line":"    when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_f402cf0b","line":14,"range":{"start_line":1,"start_character":0,"end_line":14,"end_character":1},"updated":"2019-10-30 11:04:23.000000000","message":"It was not fixed.\nSee an example of copyright header here https://opendev.org/airship/airshipctl/src/branch/master/playbooks/airship-airshipctl-functional-existing-k8s.yaml","commit_id":"97c51c6d0e6d6ccdb972deaec4edac6a533bf1ba"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"cb17cfa82b875ed01794cb5370ade734a75d0e07","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    shell: |-"},{"line_number":21,"context_line":"            set -xe"},{"line_number":22,"context_line":"            apt-get install -y git-core"},{"line_number":23,"context_line":"            git clone https://opendev.org/openstack/sushy-tools.git"},{"line_number":24,"context_line":"            cd sushy-tools/"},{"line_number":25,"context_line":"            python3 setup.py build"},{"line_number":26,"context_line":"            python3 setup.py install"},{"line_number":27,"context_line":"    args:"},{"line_number":28,"context_line":"        executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_943b5be8","line":26,"range":{"start_line":23,"start_character":0,"end_line":26,"end_character":36},"updated":"2019-10-30 11:04:23.000000000","message":"use pip install to stick to the version instead of \u0027master\u0027","commit_id":"97c51c6d0e6d6ccdb972deaec4edac6a533bf1ba"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"b8f7218e33fd27aa98e5c91e8173b1856f119bb7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"## Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":2,"context_line":"## you may not use this file except in compliance with the License."},{"line_number":3,"context_line":"## You may obtain a copy of the License at"},{"line_number":4,"context_line":"##"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_45c20f87","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":2},"updated":"2019-10-30 13:35:32.000000000","message":"There can be the only one sharp/pound sign/hash sign  (\u0027#\u0027) at the beginning of each line.","commit_id":"825dd5f68242c4941bb883cb5f2b59d0abafee1e"},{"author":{"_account_id":7321,"name":"Prakash Ramchandran","email":"pramchan@yahoo.com","username":"pramchan"},"change_message_id":"9e873de471959836d4118d8c656de5c6061a8aa8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"## Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":2,"context_line":"## you may not use this file except in compliance with the License."},{"line_number":3,"context_line":"## You may obtain a copy of the License at"},{"line_number":4,"context_line":"##"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_dcaed57f","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":2},"in_reply_to":"3fa7e38b_45c20f87","updated":"2020-02-12 17:42:51.000000000","message":"Done","commit_id":"825dd5f68242c4941bb883cb5f2b59d0abafee1e"}],"templates/emulate.conf.j2":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"ad598bb001c024151d0e0d1c176ea312e6e2718e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# sushy emulator configuration file build on top of Flask application"},{"line_number":2,"context_line":"# configuration infrastructure: http://flask.pocoo.org/docs/config/"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Listen on all local IP interfaces"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3fa7e38b_325d6915","line":1,"updated":"2019-11-08 04:55:14.000000000","message":"Can we put this into playbooks dir to avoid confusion since it\u0027s not a templates for airshipctl?","commit_id":"b78e468610a4d935a15a43d763a1d5206ca9bac4"}],"templates/redfishd.service.j2":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"ad598bb001c024151d0e0d1c176ea312e6e2718e","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"#  This file is part of susyh-emulator (redfish)."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3fa7e38b_92a1bdfa","line":1,"updated":"2019-11-08 04:55:14.000000000","message":"ditto","commit_id":"b78e468610a4d935a15a43d763a1d5206ca9bac4"}],"vars/emulatorvars.yaml":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"ad598bb001c024151d0e0d1c176ea312e6e2718e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"vbmc_node_ip: 10.10.10.10"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_d280954c","line":1,"updated":"2019-11-08 04:55:14.000000000","message":"lets put it to playbooks dir","commit_id":"b78e468610a4d935a15a43d763a1d5206ca9bac4"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"5630215b8576146541999f6d789506d0dcae2c48","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        secret: airship-airshipctl-airshipit-github-secret"},{"line_number":34,"context_line":"        pass-to-parent: true"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- job:"},{"line_number":37,"context_line":"    name: airship-airshipctl-infra-vbmc"},{"line_number":38,"context_line":"    run: playbooks/airship-airshipctl-deploy-vbmc.yaml"},{"line_number":39,"context_line":"    nodeset: airship-airshipctl-single-node"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_9ffe5669","line":39,"range":{"start_line":36,"start_character":0,"end_line":39,"end_character":43},"updated":"2019-10-25 07:06:27.000000000","message":"do we really need separate role for vbmc installation?\nwe can use pre-run playbook to install sushy tool","commit_id":"0cfc1fc138a67eae6b4307bfe0055c459f06f465"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"b8f7218e33fd27aa98e5c91e8173b1856f119bb7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    name: airship-airshipctl-infra-vbmc"},{"line_number":38,"context_line":"    run: playbooks/airship-airshipctl-deploy-vbmc.yaml"},{"line_number":39,"context_line":"    nodeset: airship-airshipctl-single-node"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_254a7326","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":0},"updated":"2019-10-30 13:35:32.000000000","message":"Remove blank lines at the end of the file","commit_id":"825dd5f68242c4941bb883cb5f2b59d0abafee1e"},{"author":{"_account_id":7321,"name":"Prakash Ramchandran","email":"pramchan@yahoo.com","username":"pramchan"},"change_message_id":"9e873de471959836d4118d8c656de5c6061a8aa8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    name: airship-airshipctl-infra-vbmc"},{"line_number":38,"context_line":"    run: playbooks/airship-airshipctl-deploy-vbmc.yaml"},{"line_number":39,"context_line":"    nodeset: airship-airshipctl-single-node"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_dce335d7","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":0},"in_reply_to":"3fa7e38b_254a7326","updated":"2020-02-12 17:42:51.000000000","message":"Done","commit_id":"825dd5f68242c4941bb883cb5f2b59d0abafee1e"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"1ff65a62179710920da9e6c71910c364483e3afe","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    name: airship-airshipctl-infra-vbmc"},{"line_number":38,"context_line":"    run: playbooks/airship-airshipctl-deploy-vbmc.yaml"},{"line_number":39,"context_line":"    nodeset: airship-airshipctl-single-node"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_4629ab87","line":40,"updated":"2019-10-31 09:11:39.000000000","message":"remove blank line","commit_id":"be5a17b0d234c82e9fbee2368b1b58a5293e49f4"},{"author":{"_account_id":30885,"name":"Deepak","email":"deepak.jadiya@dell.com","username":"dddpak"},"change_message_id":"8ca0a23b9d8e5bbc53f2e719f908198ac86b32b0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    name: airship-airshipctl-infra-vbmc"},{"line_number":38,"context_line":"    run: playbooks/airship-airshipctl-deploy-vbmc.yaml"},{"line_number":39,"context_line":"    nodeset: airship-airshipctl-single-node"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_a6ebbfa1","line":40,"in_reply_to":"3fa7e38b_4629ab87","updated":"2019-11-05 11:36:53.000000000","message":"\u003e remove blank line\n\nThe build fails with lint errors, with no explanation in logs, after removing last blank line.","commit_id":"be5a17b0d234c82e9fbee2368b1b58a5293e49f4"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"5174ac36e05eec8ae50032d9d5746fcc106f3d52","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- job:"},{"line_number":37,"context_line":"    name: airship-airshipctl-infra-vbmc"},{"line_number":38,"context_line":"    run: playbooks/airship-airshipctl-deploy-vbmc.yaml"},{"line_number":39,"context_line":"    nodeset: airship-airshipctl-single-node"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_78ff9401","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":7},"updated":"2019-11-01 10:48:08.000000000","message":"this should be pre-run. run suppose to be a test execution","commit_id":"6062963da0f5790b7f7e00f7df932db84700e4e0"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"65a0f82d4e8f6b9d8be403e9ce58949d1fc184eb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"- job:"},{"line_number":37,"context_line":"    name: airship-airshipctl-infra-vbmc"},{"line_number":38,"context_line":"    pre-run: playbooks/airship-airshipctl-deploy-vbmc.yaml"},{"line_number":39,"context_line":"    run: playbooks/airship-airshipctl-deploy-vbmc.yaml"},{"line_number":40,"context_line":"    nodeset: airship-airshipctl-single-node"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa7e38b_92980b1b","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":54},"updated":"2019-11-05 08:03:36.000000000","message":"why this used tvise ? I guess there should be a playbook that executes tests","commit_id":"32c54c203e57b01cbdb35755a02acee1e382884d"}],"zuul.d/projects.yaml":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"1ff65a62179710920da9e6c71910c364483e3afe","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    post:"},{"line_number":25,"context_line":"      jobs:"},{"line_number":26,"context_line":"        - airship-airshipctl-upload-git-mirror"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_660947db","line":27,"updated":"2019-10-31 09:11:39.000000000","message":"remove blank line","commit_id":"be5a17b0d234c82e9fbee2368b1b58a5293e49f4"}]}