)]}'
{"pkg/config/config.go":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"94fd4079b731eb1fa3c696ab754fb17ed97b8820","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"// reconcileClusters synchronizes the airshipconfig file with the kubeconfig file."},{"line_number":109,"context_line":"//"},{"line_number":110,"context_line":"// It iterates over the clusters listed in the kubeconfig. If any cluster in"},{"line_number":111,"context_line":"// the kubeconfig does not meet the \u003cname\u003e_\u003ctype\u003e convention, the name is"},{"line_number":112,"context_line":"// first changed to the airship default."},{"line_number":113,"context_line":"//"}],"source_content_type":"text/x-go","patch_set":2,"id":"3fa7e38b_f17304b3","line":110,"range":{"start_line":110,"start_character":3,"end_line":110,"end_character":57},"updated":"2019-11-14 20:13:42.000000000","message":"We can iterate over airship clusters instead of kubeConfig clusters. It actually depends on what we considering a source of truth.\n\nBut iterating  over c.Clusters will allow to remove clusters that are not present on kubeConfig in the same loop and we do not need separate functions for this","commit_id":"871bd8c70324dc50df6b45e29db0b1c5c677e1f6"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"1c315973b77636c55d0317994f8626d101c77e1b","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"// reconcileClusters synchronizes the airshipconfig file with the kubeconfig file."},{"line_number":109,"context_line":"//"},{"line_number":110,"context_line":"// It iterates over the clusters listed in the kubeconfig. If any cluster in"},{"line_number":111,"context_line":"// the kubeconfig does not meet the \u003cname\u003e_\u003ctype\u003e convention, the name is"},{"line_number":112,"context_line":"// first changed to the airship default."},{"line_number":113,"context_line":"//"}],"source_content_type":"text/x-go","patch_set":2,"id":"3fa7e38b_7784dab1","line":110,"range":{"start_line":110,"start_character":3,"end_line":110,"end_character":57},"in_reply_to":"3fa7e38b_b75b3284","updated":"2019-11-15 15:39:03.000000000","message":"Which means kubeconfig is the source of truth essentially. Fair enough then.","commit_id":"871bd8c70324dc50df6b45e29db0b1c5c677e1f6"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"7358272e1a00b742a8156d5945e573871ad7f413","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"// reconcileClusters synchronizes the airshipconfig file with the kubeconfig file."},{"line_number":109,"context_line":"//"},{"line_number":110,"context_line":"// It iterates over the clusters listed in the kubeconfig. If any cluster in"},{"line_number":111,"context_line":"// the kubeconfig does not meet the \u003cname\u003e_\u003ctype\u003e convention, the name is"},{"line_number":112,"context_line":"// first changed to the airship default."},{"line_number":113,"context_line":"//"}],"source_content_type":"text/x-go","patch_set":2,"id":"3fa7e38b_b75b3284","line":110,"range":{"start_line":110,"start_character":3,"end_line":110,"end_character":57},"in_reply_to":"3fa7e38b_f17304b3","updated":"2019-11-15 15:35:41.000000000","message":"If we iterate over c.Cluster rather than the kubeconfig clusters, we may miss some clusters that are listed in the kubeconfig.\n\nIn theory, this function should create the property that the airshipconfig clusters can be reproduced from the kubeconfig, and vice versa. In order to do that, it is necessary to iterate over both sets","commit_id":"871bd8c70324dc50df6b45e29db0b1c5c677e1f6"}]}