)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22259,"name":"Nishant Kumar","email":"nishant.e.kumar@att.com","username":"nishant.e.kumar"},"change_message_id":"859d998d03453a44a5e54d4a103236422a116813","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dmitry Ukov \u003cdukov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-12-04 20:49:12 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add render sub-command stub"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Render command filters documents (e.g. byte kind and annotation) and"},{"line_number":10,"context_line":"prints them to user-defined output in a form of multi-document YAML"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_3f74c5cf","line":7,"updated":"2019-12-09 23:17:02.000000000","message":"Is there a Story number or spec this is trying to implement which has more detailed information on this feature? it would help new reviewers get a more clear understanding of what\u0027s being done.\n\nIf there is no US linked to it then i would like to see more details on the commit message answering few things below:\n\n1. what is the need for this command?\n2. what exact filters are being introduced as part of this\n   PS?\n3. can we add documentation about this feature? or is that a \n   TODO?\n4. The main function is not implemented, can we specify the    \n   scope of this PS? is it just trying to setup an initial\n   framework which would be followed by further \n   implementation work?","commit_id":"139f58fc88e3573f7ab696d4c10179b4f9e625af"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"d2d385a74cc450d8c3135e0a9c730d615f092875","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dmitry Ukov \u003cdukov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-12-04 20:49:12 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add render sub-command stub"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Render command filters documents (e.g. byte kind and annotation) and"},{"line_number":10,"context_line":"prints them to user-defined output in a form of multi-document YAML"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_51dabce5","line":7,"in_reply_to":"3fa7e38b_3f74c5cf","updated":"2019-12-11 11:10:10.000000000","message":"Rephrased commit message. There is no user story for this command it was discussed on YAML design call. Particular implementation of render command will be uploaded in upcoming CRs","commit_id":"139f58fc88e3573f7ab696d4c10179b4f9e625af"},{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"f397960094897bbff563d1537c031887b8f72e5e","unresolved":false,"context_lines":[{"line_number":16,"context_line":" * kind"},{"line_number":17,"context_line":" * filter"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Related: #16"},{"line_number":20,"context_line":"Change-Id: I7efb0a478e1070efd1791ab10d7c3946c8c28630"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"3fa7e38b_2c846cb1","line":19,"updated":"2020-02-14 15:37:40.000000000","message":"In the future, please also include this in the commit summary line as a bracketed tag like \"[#16] Add render sub-command frame\". I think it\u0027s easier at a glance to identify the issue relation that way.","commit_id":"5656e3973ca4cbcb1ff41de0b3fc961ce78bf657"}],"cmd/document/render.go":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"80d1c75efdda19c78f9893391019f923f2cf16c8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\tGroupVersion []string"},{"line_number":19,"context_line":"\t// Kind filter documents by document kind"},{"line_number":20,"context_line":"\tKind []string"},{"line_number":21,"context_line":"\t// RawFilter contains logical expression ot filter documents"},{"line_number":22,"context_line":"\tRawFilter string"},{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-go","patch_set":5,"id":"3fa7e38b_8862fb40","line":21,"range":{"start_line":21,"start_character":42,"end_line":21,"end_character":44},"updated":"2020-01-31 19:33:26.000000000","message":"nit: to","commit_id":"3379163efe5ad3e9401716d9a71d4a9856f7750d"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"80d1c75efdda19c78f9893391019f923f2cf16c8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\tflags :\u003d cmd.Flags()"},{"line_number":28,"context_line":"\tflags.StringArrayVarP(\u0026s.Label, \"label\", \"l\", []string{\"\"}, \"Filter documents by Labels\")"},{"line_number":29,"context_line":"\tflags.StringArrayVarP(\u0026s.Annotation, \"annotation\", \"a\", []string{\"\"}, \"Filter documents by Annotations\")"},{"line_number":30,"context_line":"\tflags.StringArrayVarP(\u0026s.GroupVersion, \"apiversion\", \"g\", []string{\"\"}, \"Filter documents by API version\")"},{"line_number":31,"context_line":"\tflags.StringArrayVarP(\u0026s.Kind, \"kind\", \"k\", []string{\"\"}, \"Filter documents by Kinds\")"},{"line_number":32,"context_line":"\tflags.StringVarP(\u0026s.RawFilter, \"filter\", \"f\", \"\", \"Logical expression for document filtering\")"},{"line_number":33,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":5,"id":"3fa7e38b_e85a8f83","line":30,"range":{"start_line":30,"start_character":26,"end_line":30,"end_character":52},"updated":"2020-01-31 19:33:26.000000000","message":"mixing groupversion and apiversion makes it harder to read code.  please be consistent.","commit_id":"3379163efe5ad3e9401716d9a71d4a9856f7750d"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"8ea3f424646d7a6007a230b1193f3f034e9b322c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\tflags.StringArrayVarP(\u0026settings.Annotation, \"annotation\", \"a\", nil, \"Filter documents by Annotations\")"},{"line_number":16,"context_line":"\tflags.StringArrayVarP(\u0026settings.GroupVersion, \"apiversion\", \"g\", nil, \"Filter documents by API version\")"},{"line_number":17,"context_line":"\tflags.StringArrayVarP(\u0026settings.Kind, \"kind\", \"k\", nil, \"Filter documents by Kinds\")"},{"line_number":18,"context_line":"\tflags.StringVarP(\u0026settings.RawFilter, \"filter\", \"f\", \"\", \"Logical expression for document filtering\")"},{"line_number":19,"context_line":"}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"// NewRenderCommand create a new command for document rendering"}],"source_content_type":"text/x-go","patch_set":9,"id":"3fa7e38b_ab686d21","line":18,"range":{"start_line":18,"start_character":59,"end_line":18,"end_character":101},"updated":"2020-02-12 14:30:48.000000000","message":"Is this a regex? What fields can be used to filter documents?","commit_id":"052d7965cd1cb518038d2cbe5eb50d844ca3b562"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"33987e83b1423167117fa412ead13cdbc75dfaa0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\tflags.StringArrayVarP(\u0026settings.Annotation, \"annotation\", \"a\", nil, \"Filter documents by Annotations\")"},{"line_number":16,"context_line":"\tflags.StringArrayVarP(\u0026settings.GroupVersion, \"apiversion\", \"g\", nil, \"Filter documents by API version\")"},{"line_number":17,"context_line":"\tflags.StringArrayVarP(\u0026settings.Kind, \"kind\", \"k\", nil, \"Filter documents by Kinds\")"},{"line_number":18,"context_line":"\tflags.StringVarP(\u0026settings.RawFilter, \"filter\", \"f\", \"\", \"Logical expression for document filtering\")"},{"line_number":19,"context_line":"}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"// NewRenderCommand create a new command for document rendering"}],"source_content_type":"text/x-go","patch_set":9,"id":"3fa7e38b_a6ede623","line":18,"range":{"start_line":18,"start_character":59,"end_line":18,"end_character":101},"in_reply_to":"3fa7e38b_a2e16099","updated":"2020-02-13 19:43:13.000000000","message":"\u003e It\u0027s going to be a logical expression that helps you to filter\n \u003e documents out. Added more examples here https://review.opendev.org/#/c/698658/15\n \u003e since this CR is only a frame\n\nSounds good to me.","commit_id":"052d7965cd1cb518038d2cbe5eb50d844ca3b562"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"1d0a9d7d6d8692ef76a14b1409782f1d2864829d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\tflags.StringArrayVarP(\u0026settings.Annotation, \"annotation\", \"a\", nil, \"Filter documents by Annotations\")"},{"line_number":16,"context_line":"\tflags.StringArrayVarP(\u0026settings.GroupVersion, \"apiversion\", \"g\", nil, \"Filter documents by API version\")"},{"line_number":17,"context_line":"\tflags.StringArrayVarP(\u0026settings.Kind, \"kind\", \"k\", nil, \"Filter documents by Kinds\")"},{"line_number":18,"context_line":"\tflags.StringVarP(\u0026settings.RawFilter, \"filter\", \"f\", \"\", \"Logical expression for document filtering\")"},{"line_number":19,"context_line":"}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"// NewRenderCommand create a new command for document rendering"}],"source_content_type":"text/x-go","patch_set":9,"id":"3fa7e38b_a2e16099","line":18,"range":{"start_line":18,"start_character":59,"end_line":18,"end_character":101},"in_reply_to":"3fa7e38b_ab686d21","updated":"2020-02-13 09:10:50.000000000","message":"It\u0027s going to be a logical expression that helps you to filter documents out. Added more examples here https://review.opendev.org/#/c/698658/15\nsince this CR is only a frame","commit_id":"052d7965cd1cb518038d2cbe5eb50d844ca3b562"},{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"f397960094897bbff563d1537c031887b8f72e5e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"// InitFlags add flags for document render sub-command"},{"line_number":12,"context_line":"func initRenderFlags(settings *render.Settings, cmd *cobra.Command) {"},{"line_number":13,"context_line":"\tflags :\u003d cmd.Flags()"},{"line_number":14,"context_line":"\tflags.StringArrayVarP(\u0026settings.Label, \"label\", \"l\", nil, \"Filter documents by Labels\")"},{"line_number":15,"context_line":"\tflags.StringArrayVarP(\u0026settings.Annotation, \"annotation\", \"a\", nil, \"Filter documents by Annotations\")"},{"line_number":16,"context_line":"\tflags.StringArrayVarP(\u0026settings.GroupVersion, \"apiversion\", \"g\", nil, \"Filter documents by API version\")"},{"line_number":17,"context_line":"\tflags.StringArrayVarP(\u0026settings.Kind, \"kind\", \"k\", nil, \"Filter documents by Kinds\")"}],"source_content_type":"text/x-go","patch_set":14,"id":"3fa7e38b_eca2d43f","line":14,"range":{"start_line":14,"start_character":60,"end_line":14,"end_character":61},"updated":"2020-02-14 15:37:40.000000000","message":"nit: We need to figure out our official convention on flag help messages. It seems like for most of them so far we have used lowercase.","commit_id":"5656e3973ca4cbcb1ff41de0b3fc961ce78bf657"}],"cmd/document/testdata/TestDocumentGoldenOutput/document-render-with-help.golden":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"80d1c75efdda19c78f9893391019f923f2cf16c8","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Flags:"},{"line_number":7,"context_line":"  -a, --annotation stringArray   Filter documents by Annotations"},{"line_number":8,"context_line":"  -g, --apiversion stringArray   Filter documents by API version"},{"line_number":9,"context_line":"  -f, --filter string            Logical expression for document filtering"},{"line_number":10,"context_line":"  -h, --help                     help for render"},{"line_number":11,"context_line":"  -k, --kind stringArray         Filter documents by Kinds"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3fa7e38b_08604b34","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":18},"updated":"2020-01-31 19:33:26.000000000","message":"ditto","commit_id":"3379163efe5ad3e9401716d9a71d4a9856f7750d"}],"pkg/document/cmds_render.go":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"8ea3f424646d7a6007a230b1193f3f034e9b322c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"// Settings for document rendering"},{"line_number":8,"context_line":"type RenderSettings struct {"},{"line_number":9,"context_line":"\t*environment.AirshipCTLSettings"},{"line_number":10,"context_line":"\t// Label filter documents by label string"},{"line_number":11,"context_line":"\tLabel []string"},{"line_number":12,"context_line":"\t// Annotation filter documents by annotation string"}],"source_content_type":"text/x-go","patch_set":9,"id":"3fa7e38b_f64e486b","line":9,"range":{"start_line":9,"start_character":1,"end_line":9,"end_character":32},"updated":"2020-02-12 14:30:48.000000000","message":"missing field name?\n\nWould expect this to look like:\n\n  settings *environment.AirshipCTLSettings","commit_id":"052d7965cd1cb518038d2cbe5eb50d844ca3b562"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"1d0a9d7d6d8692ef76a14b1409782f1d2864829d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"// Settings for document rendering"},{"line_number":8,"context_line":"type RenderSettings struct {"},{"line_number":9,"context_line":"\t*environment.AirshipCTLSettings"},{"line_number":10,"context_line":"\t// Label filter documents by label string"},{"line_number":11,"context_line":"\tLabel []string"},{"line_number":12,"context_line":"\t// Annotation filter documents by annotation string"}],"source_content_type":"text/x-go","patch_set":9,"id":"3fa7e38b_e290b8f5","line":9,"range":{"start_line":9,"start_character":1,"end_line":9,"end_character":32},"in_reply_to":"3fa7e38b_f64e486b","updated":"2020-02-13 09:10:50.000000000","message":"No. It\u0027s so called \u0027Embedding\u0027 which helps to extend structures in Go (i.e. some form of inheritance). See details here https://golang.org/doc/effective_go.html#embedding","commit_id":"052d7965cd1cb518038d2cbe5eb50d844ca3b562"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"8ea3f424646d7a6007a230b1193f3f034e9b322c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\tGroupVersion []string"},{"line_number":16,"context_line":"\t// Kind filter documents by document kind"},{"line_number":17,"context_line":"\tKind []string"},{"line_number":18,"context_line":"\t// RawFilter contains logical expression ot filter documents"},{"line_number":19,"context_line":"\tRawFilter string"},{"line_number":20,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":9,"id":"3fa7e38b_8b69f123","line":18,"range":{"start_line":18,"start_character":41,"end_line":18,"end_character":44},"updated":"2020-02-12 14:30:48.000000000","message":"to","commit_id":"052d7965cd1cb518038d2cbe5eb50d844ca3b562"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"1d0a9d7d6d8692ef76a14b1409782f1d2864829d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\tGroupVersion []string"},{"line_number":16,"context_line":"\t// Kind filter documents by document kind"},{"line_number":17,"context_line":"\tKind []string"},{"line_number":18,"context_line":"\t// RawFilter contains logical expression ot filter documents"},{"line_number":19,"context_line":"\tRawFilter string"},{"line_number":20,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":9,"id":"3fa7e38b_0294f4e5","line":18,"range":{"start_line":18,"start_character":41,"end_line":18,"end_character":44},"in_reply_to":"3fa7e38b_8b69f123","updated":"2020-02-13 09:10:50.000000000","message":"Done","commit_id":"052d7965cd1cb518038d2cbe5eb50d844ca3b562"}]}