)]}'
{"roles/airshipctl-publish-images/tasks/dependencies.yaml":[{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"5c39bf937d5619efa94835857461f5706e74da3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"3fa7e38b_c186a5b8","updated":"2020-02-17 19:11:24.000000000","message":"Why in new file? I don\u0027t see it being used in other yamls.","commit_id":"6b1df08dbdf60e06ee23a0e35e2bfb3b99c2311f"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"e061a243fc031cc70f33eb572e1728b6d94022d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"3fa7e38b_2438e79c","in_reply_to":"3fa7e38b_c186a5b8","updated":"2020-02-17 19:44:46.000000000","message":"\u003e Why in new file? I don\u0027t see it being used in other yamls.\n\nJust for separation of concerns. I moved it back to main.yaml since desired.","commit_id":"6b1df08dbdf60e06ee23a0e35e2bfb3b99c2311f"}],"roles/airshipctl-publish-images/tasks/main.yaml":[{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"2b4606bf267e5f97deee24126e0d0f3c0b7867a5","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- name: List Docker Images"},{"line_number":25,"context_line":"  shell: docker image ls"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Push Image"},{"line_number":28,"context_line":"  block:"},{"line_number":29,"context_line":"    - name: docker_login"},{"line_number":30,"context_line":"      username: \"{{ image-repo-credentials.username }}\""},{"line_number":31,"context_line":"      password: \"{{ image-repo-credentials.password }}\""},{"line_number":32,"context_line":"      registry_url: \"{{ image_repo }}\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    - name: Push Image with Latest Tag"},{"line_number":35,"context_line":"      shell: \"docker push {{ image }}:latest\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa7e38b_3fbd7eb1","line":32,"range":{"start_line":27,"start_character":0,"end_line":32,"end_character":38},"updated":"2020-02-13 17:00:22.000000000","message":"just in case, i would  `no_log: True` here","commit_id":"37badb3f28e6c05b64f49a2a39335500db481c22"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"3a5bafb3a5d273e720692a53c944b70a974fbcfd","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- name: List Docker Images"},{"line_number":25,"context_line":"  shell: docker image ls"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Push Image"},{"line_number":28,"context_line":"  block:"},{"line_number":29,"context_line":"    - name: docker_login"},{"line_number":30,"context_line":"      username: \"{{ image-repo-credentials.username }}\""},{"line_number":31,"context_line":"      password: \"{{ image-repo-credentials.password }}\""},{"line_number":32,"context_line":"      registry_url: \"{{ image_repo }}\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    - name: Push Image with Latest Tag"},{"line_number":35,"context_line":"      shell: \"docker push {{ image }}:latest\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa7e38b_a66ac6b0","line":32,"range":{"start_line":27,"start_character":0,"end_line":32,"end_character":38},"in_reply_to":"3fa7e38b_3fbd7eb1","updated":"2020-02-13 19:38:06.000000000","message":"\u003e just in case, i would  `no_log: True` here\n\nDone.","commit_id":"37badb3f28e6c05b64f49a2a39335500db481c22"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"6de1f9ebcdcb571bc2a77d5101b40fb652a65901","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Push Image"},{"line_number":30,"context_line":"  block:"},{"line_number":31,"context_line":"    - name: docker_login"},{"line_number":32,"context_line":"      username: \"{{ image-repo-credentials.username }}\""},{"line_number":33,"context_line":"      password: \"{{ image-repo-credentials.password }}\""},{"line_number":34,"context_line":"      registry_url: \"{{ image_repo }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_471f3a0a","line":31,"range":{"start_line":31,"start_character":6,"end_line":31,"end_character":24},"updated":"2020-02-15 10:38:05.000000000","message":"Something is wrong here. docker_login is a module, not a name.","commit_id":"81f3970f22803f9265548cfd4af11afc72cf22f6"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"d6437cd8dd61a30416abdc39d36a0b98d59bd545","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Push Image"},{"line_number":30,"context_line":"  block:"},{"line_number":31,"context_line":"    - name: docker_login"},{"line_number":32,"context_line":"      username: \"{{ image-repo-credentials.username }}\""},{"line_number":33,"context_line":"      password: \"{{ image-repo-credentials.password }}\""},{"line_number":34,"context_line":"      registry_url: \"{{ image_repo }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_f3061a1a","line":31,"range":{"start_line":31,"start_character":6,"end_line":31,"end_character":24},"in_reply_to":"3fa7e38b_471f3a0a","updated":"2020-02-17 15:23:07.000000000","message":"\u003e Something is wrong here. docker_login is a module, not a name.\n\nFixed.","commit_id":"81f3970f22803f9265548cfd4af11afc72cf22f6"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"6de1f9ebcdcb571bc2a77d5101b40fb652a65901","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      username: \"{{ image-repo-credentials.username }}\""},{"line_number":33,"context_line":"      password: \"{{ image-repo-credentials.password }}\""},{"line_number":34,"context_line":"      registry_url: \"{{ image_repo }}\""},{"line_number":35,"context_line":"      no_log: true"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    - name: Push Image with Latest Tag"},{"line_number":38,"context_line":"      shell: \"docker push {{ image }}:latest\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_67227655","line":35,"range":{"start_line":35,"start_character":6,"end_line":35,"end_character":18},"updated":"2020-02-15 10:38:05.000000000","message":"Not needed.","commit_id":"81f3970f22803f9265548cfd4af11afc72cf22f6"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"d6437cd8dd61a30416abdc39d36a0b98d59bd545","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      username: \"{{ image-repo-credentials.username }}\""},{"line_number":33,"context_line":"      password: \"{{ image-repo-credentials.password }}\""},{"line_number":34,"context_line":"      registry_url: \"{{ image_repo }}\""},{"line_number":35,"context_line":"      no_log: true"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    - name: Push Image with Latest Tag"},{"line_number":38,"context_line":"      shell: \"docker push {{ image }}:latest\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_9313265b","line":35,"range":{"start_line":35,"start_character":6,"end_line":35,"end_character":18},"in_reply_to":"3fa7e38b_67227655","updated":"2020-02-17 15:23:07.000000000","message":"\u003e Not needed.\n\nRemoved.","commit_id":"81f3970f22803f9265548cfd4af11afc72cf22f6"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7dca40d7f1d53a2b23e2022999d8fbc1913f0a04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3fa7e38b_955ea376","updated":"2020-02-18 00:07:08.000000000","message":"is there a reason we are not consistent between using shell commands and ansible modules? it would be good to settle on a consistent approach.","commit_id":"a2096ed841030a86f891026cfe4d3a174281650c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"3c5f09bfe206d88e723c6f96ef2a92bce4f745f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3fa7e38b_2987370d","in_reply_to":"3fa7e38b_955ea376","updated":"2020-02-19 17:36:30.000000000","message":"\u003e is there a reason we are not consistent between using shell\n \u003e commands and ansible modules? it would be good to settle on a\n \u003e consistent approach.\n\nSwitched to shell.","commit_id":"a2096ed841030a86f891026cfe4d3a174281650c"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"ea82bcb5ca2f9e37a5d4559d21fcc814c2469c8a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Install python-docker Module"},{"line_number":14,"context_line":"  shell: |"},{"line_number":15,"context_line":"    apt-get install --no-install-recommends -y \\"},{"line_number":16,"context_line":"        python-docker \\"},{"line_number":17,"context_line":"        python-requests"},{"line_number":18,"context_line":"  when: ansible_distribution \u003d\u003d \u0027Debian\u0027 or ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Tag Image"},{"line_number":21,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3fa7e38b_eb0a6c76","line":18,"range":{"start_line":13,"start_character":0,"end_line":18,"end_character":76},"updated":"2020-02-20 07:02:29.000000000","message":"why do not use the same approach as here\nhttps://github.com/airshipit/armada/blob/master/tools/gate/playbooks/docker-image-build.yaml#L71-L79","commit_id":"08dc5a1ce25738d4fc27b5ba7b4e6bc3523337f6"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"abd2b45dc908808c51d916b98fd14176e87d48f4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Install python-docker Module"},{"line_number":14,"context_line":"  shell: |"},{"line_number":15,"context_line":"    apt-get install --no-install-recommends -y \\"},{"line_number":16,"context_line":"        python-docker \\"},{"line_number":17,"context_line":"        python-requests"},{"line_number":18,"context_line":"  when: ansible_distribution \u003d\u003d \u0027Debian\u0027 or ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Tag Image"},{"line_number":21,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3fa7e38b_cccd3cba","line":18,"range":{"start_line":13,"start_character":0,"end_line":18,"end_character":76},"in_reply_to":"3fa7e38b_eb0a6c76","updated":"2020-02-20 19:06:23.000000000","message":"\u003e why do not use the same approach as here\n \u003e https://github.com/airshipit/armada/blob/master/tools/gate/playbooks/docker-image-build.yaml#L71-L79\n\nAnother core requested that I pick a consistent approach in this playbook. We decided on shell in IRC. \n\nCould we merge as-is for now and standardize this later?","commit_id":"08dc5a1ce25738d4fc27b5ba7b4e6bc3523337f6"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"fb40aeebab6b917175e46dfe2aea657a7fe56f41","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Install python-docker Module"},{"line_number":14,"context_line":"  shell: |"},{"line_number":15,"context_line":"    apt-get install --no-install-recommends -y \\"},{"line_number":16,"context_line":"        python-docker \\"},{"line_number":17,"context_line":"        python-requests"},{"line_number":18,"context_line":"  when: ansible_distribution \u003d\u003d \u0027Debian\u0027 or ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Tag Image"},{"line_number":21,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1fa4df85_350a4e26","line":18,"range":{"start_line":13,"start_character":0,"end_line":18,"end_character":76},"in_reply_to":"3fa7e38b_eb0a6c76","updated":"2020-02-24 17:07:25.000000000","message":"\u003e why do not use the same approach as here\n \u003e https://github.com/airshipit/armada/blob/master/tools/gate/playbooks/docker-image-build.yaml#L71-L79\n\nDone.","commit_id":"08dc5a1ce25738d4fc27b5ba7b4e6bc3523337f6"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"ea82bcb5ca2f9e37a5d4559d21fcc814c2469c8a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- name: Push Image"},{"line_number":37,"context_line":"  block:"},{"line_number":38,"context_line":"    - name: Login to Image Registry"},{"line_number":39,"context_line":"      shell: |"},{"line_number":40,"context_line":"        docker login -u \"{{ airshipctl-image-repo-credentials.username }}\" \\"},{"line_number":41,"context_line":"                     -p \"{{ airshipctl-image-repo-credentials.password }}\" \\"},{"line_number":42,"context_line":"                        \"{{ image_repo }}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    - name: Push Image with Latest Tag"},{"line_number":45,"context_line":"      shell: \"docker push {{ image }}:latest\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3fa7e38b_ab72344a","line":42,"range":{"start_line":38,"start_character":0,"end_line":42,"end_character":42},"updated":"2020-02-20 07:02:29.000000000","message":"maybe I missed this part but why do we use shell instead of ansible module?","commit_id":"08dc5a1ce25738d4fc27b5ba7b4e6bc3523337f6"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"fb40aeebab6b917175e46dfe2aea657a7fe56f41","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- name: Push Image"},{"line_number":37,"context_line":"  block:"},{"line_number":38,"context_line":"    - name: Login to Image Registry"},{"line_number":39,"context_line":"      shell: |"},{"line_number":40,"context_line":"        docker login -u \"{{ airshipctl-image-repo-credentials.username }}\" \\"},{"line_number":41,"context_line":"                     -p \"{{ airshipctl-image-repo-credentials.password }}\" \\"},{"line_number":42,"context_line":"                        \"{{ image_repo }}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    - name: Push Image with Latest Tag"},{"line_number":45,"context_line":"      shell: \"docker push {{ image }}:latest\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1fa4df85_f503560e","line":42,"range":{"start_line":38,"start_character":0,"end_line":42,"end_character":42},"in_reply_to":"3fa7e38b_ab72344a","updated":"2020-02-24 17:07:25.000000000","message":"\u003e maybe I missed this part but why do we use shell instead of ansible\n \u003e module?\n\nDone.","commit_id":"08dc5a1ce25738d4fc27b5ba7b4e6bc3523337f6"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"abd2b45dc908808c51d916b98fd14176e87d48f4","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- name: Push Image"},{"line_number":37,"context_line":"  block:"},{"line_number":38,"context_line":"    - name: Login to Image Registry"},{"line_number":39,"context_line":"      shell: |"},{"line_number":40,"context_line":"        docker login -u \"{{ airshipctl-image-repo-credentials.username }}\" \\"},{"line_number":41,"context_line":"                     -p \"{{ airshipctl-image-repo-credentials.password }}\" \\"},{"line_number":42,"context_line":"                        \"{{ image_repo }}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    - name: Push Image with Latest Tag"},{"line_number":45,"context_line":"      shell: \"docker push {{ image }}:latest\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3fa7e38b_8cc74498","line":42,"range":{"start_line":38,"start_character":0,"end_line":42,"end_character":42},"in_reply_to":"3fa7e38b_ab72344a","updated":"2020-02-20 19:06:23.000000000","message":"\u003e maybe I missed this part but why do we use shell instead of ansible\n \u003e module?\n\nPlease see above","commit_id":"08dc5a1ce25738d4fc27b5ba7b4e6bc3523337f6"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"ea82bcb5ca2f9e37a5d4559d21fcc814c2469c8a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                     -p \"{{ airshipctl-image-repo-credentials.password }}\" \\"},{"line_number":42,"context_line":"                        \"{{ image_repo }}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    - name: Push Image with Latest Tag"},{"line_number":45,"context_line":"      shell: \"docker push {{ image }}:latest\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: Push Image with Commit Tag"},{"line_number":48,"context_line":"      shell: \"docker push {{ image }}:{{ zuul.newrev }}"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3fa7e38b_eb802cf9","line":48,"range":{"start_line":44,"start_character":0,"end_line":48,"end_character":55},"updated":"2020-02-20 07:02:29.000000000","message":"Move this to Makefile like it\u0027s implemented for all airship projects (e.g. https://github.com/airshipit/armada/blob/master/Makefile#L116)\n\nand executed by \u0027make\u0027 module for ansible (see https://github.com/airshipit/armada/blob/master/tools/gate/playbooks/docker-image-build.yaml#L115)","commit_id":"08dc5a1ce25738d4fc27b5ba7b4e6bc3523337f6"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"fb40aeebab6b917175e46dfe2aea657a7fe56f41","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                     -p \"{{ airshipctl-image-repo-credentials.password }}\" \\"},{"line_number":42,"context_line":"                        \"{{ image_repo }}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    - name: Push Image with Latest Tag"},{"line_number":45,"context_line":"      shell: \"docker push {{ image }}:latest\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: Push Image with Commit Tag"},{"line_number":48,"context_line":"      shell: \"docker push {{ image }}:{{ zuul.newrev }}"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1fa4df85_98fed703","line":48,"range":{"start_line":44,"start_character":0,"end_line":48,"end_character":55},"in_reply_to":"3fa7e38b_426cb39d","updated":"2020-02-24 17:07:25.000000000","message":"\u003e I do agree with Dmitry on this one - if we put image push logic\n \u003e into the Makefile, then it can be reused in this gate and in other\n \u003e derivative use cases (supplying overrides for all the repo / image\n \u003e info)\n\nDone.","commit_id":"08dc5a1ce25738d4fc27b5ba7b4e6bc3523337f6"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"3702dd8375001b37012bacba1eb83d420f0846dd","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                     -p \"{{ airshipctl-image-repo-credentials.password }}\" \\"},{"line_number":42,"context_line":"                        \"{{ image_repo }}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    - name: Push Image with Latest Tag"},{"line_number":45,"context_line":"      shell: \"docker push {{ image }}:latest\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: Push Image with Commit Tag"},{"line_number":48,"context_line":"      shell: \"docker push {{ image }}:{{ zuul.newrev }}"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3fa7e38b_426cb39d","line":48,"range":{"start_line":44,"start_character":0,"end_line":48,"end_character":55},"in_reply_to":"3fa7e38b_4cb94c15","updated":"2020-02-20 21:32:36.000000000","message":"I do agree with Dmitry on this one - if we put image push logic into the Makefile, then it can be reused in this gate and in other derivative use cases (supplying overrides for all the repo / image info)","commit_id":"08dc5a1ce25738d4fc27b5ba7b4e6bc3523337f6"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"abd2b45dc908808c51d916b98fd14176e87d48f4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                     -p \"{{ airshipctl-image-repo-credentials.password }}\" \\"},{"line_number":42,"context_line":"                        \"{{ image_repo }}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    - name: Push Image with Latest Tag"},{"line_number":45,"context_line":"      shell: \"docker push {{ image }}:latest\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: Push Image with Commit Tag"},{"line_number":48,"context_line":"      shell: \"docker push {{ image }}:{{ zuul.newrev }}"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3fa7e38b_4cb94c15","line":48,"range":{"start_line":44,"start_character":0,"end_line":48,"end_character":55},"in_reply_to":"3fa7e38b_eb802cf9","updated":"2020-02-20 19:06:23.000000000","message":"\u003e Move this to Makefile like it\u0027s implemented for all airship\n \u003e projects (e.g. https://github.com/airshipit/armada/blob/master/Makefile#L116)\n \u003e \n \u003e and executed by \u0027make\u0027 module for ansible (see https://github.com/airshipit/armada/blob/master/tools/gate/playbooks/docker-image-build.yaml#L115)\n\nPlease see above","commit_id":"08dc5a1ce25738d4fc27b5ba7b4e6bc3523337f6"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"eadaddd782540cc29de9eb841995d6ad9b768f3c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- name: Install python-docker Module"},{"line_number":14,"context_line":"  apt:"},{"line_number":15,"context_line":"    pkg:"},{"line_number":16,"context_line":"      - python-docker"},{"line_number":17,"context_line":"      - python-requests"},{"line_number":18,"context_line":"    state: present"},{"line_number":19,"context_line":"  when: ansible_distribution \u003d\u003d \u0027Debian\u0027 or ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"1fa4df85_6d279266","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":23},"updated":"2020-02-25 09:55:24.000000000","message":"We have problems with this packages in another repo, docker_login might require python3-requests module. Could you verify, please?","commit_id":"853a2507a16ba5f2029da25cfd788d8198b43cc9"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"475a8b77881e32221efc9b8f2dc401c774e94b9b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- name: Install python-docker Module"},{"line_number":14,"context_line":"  apt:"},{"line_number":15,"context_line":"    pkg:"},{"line_number":16,"context_line":"      - python-docker"},{"line_number":17,"context_line":"      - python-requests"},{"line_number":18,"context_line":"    state: present"},{"line_number":19,"context_line":"  when: ansible_distribution \u003d\u003d \u0027Debian\u0027 or ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"1fa4df85_bbccc489","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":23},"in_reply_to":"1fa4df85_6d279266","updated":"2020-02-26 16:51:03.000000000","message":"\u003e We have problems with this packages in another repo, docker_login\n \u003e might require python3-requests module. Could you verify, please?\n\nUpdated to python3-requests","commit_id":"853a2507a16ba5f2029da25cfd788d8198b43cc9"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8c5716a472517ff8b5eb73a86b7632032a9959aa","unresolved":false,"context_lines":[{"line_number":68,"context_line":"      serve_dir: /srv/iso"},{"line_number":69,"context_line":"      serve_port: 8099"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- job:"},{"line_number":72,"context_line":"    name: airship-airshipctl-publish-image"},{"line_number":73,"context_line":"    parent: airship-airshipctl-build-images.yaml"},{"line_number":74,"context_line":"    post-run: playbooks/airship-airshipctl-publish-images.yaml"},{"line_number":75,"context_line":"    secrets:"},{"line_number":76,"context_line":"      - image-repo-credentials"},{"line_number":77,"context_line":"    vars:"},{"line_number":78,"context_line":"      image: quay.io/airshipit/airshipctl"},{"line_number":79,"context_line":"      image_repo: https://quay.io/api/v1/"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"- secret:"},{"line_number":82,"context_line":"    name: image-repo-credentials"},{"line_number":83,"context_line":"    data:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_adcdda5b","line":80,"range":{"start_line":71,"start_character":2,"end_line":80,"end_character":0},"updated":"2020-02-12 21:57:19.000000000","message":"Job airship-airshipctl-build-images.yaml not defined","commit_id":"6396969ea6329695891e1cdffb8e064306113c0d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d6fa9e14c5a924ae0abaf59c4d4f938169404129","unresolved":false,"context_lines":[{"line_number":68,"context_line":"      serve_dir: /srv/iso"},{"line_number":69,"context_line":"      serve_port: 8099"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- job:"},{"line_number":72,"context_line":"    name: airship-airshipctl-publish-image"},{"line_number":73,"context_line":"    parent: airship-airshipctl-build-image.yaml"},{"line_number":74,"context_line":"    post-run: playbooks/airship-airshipctl-publish-images.yaml"},{"line_number":75,"context_line":"    secrets:"},{"line_number":76,"context_line":"      - image-repo-credentials"},{"line_number":77,"context_line":"    vars:"},{"line_number":78,"context_line":"      image: quay.io/airshipit/airshipctl"},{"line_number":79,"context_line":"      image-repo: https://quay.io/api/v1/"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"- secret:"},{"line_number":82,"context_line":"    name: image-repo-credentials"},{"line_number":83,"context_line":"    data:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_6d1362b8","line":80,"range":{"start_line":71,"start_character":2,"end_line":80,"end_character":0},"updated":"2020-02-12 22:00:41.000000000","message":"Invalid Ansible variable name \u0027image-repo\u0027 for dictionary value @ data[\u0027vars\u0027]","commit_id":"6d5677c780780af12e74c41bcfe4f9721c6ce9dd"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6a7b925fad5417c05e62f10af3e63a9c43d588ef","unresolved":false,"context_lines":[{"line_number":68,"context_line":"      serve_dir: /srv/iso"},{"line_number":69,"context_line":"      serve_port: 8099"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- job:"},{"line_number":72,"context_line":"    name: airship-airshipctl-publish-image"},{"line_number":73,"context_line":"    parent: airship-airshipctl-build-image.yaml"},{"line_number":74,"context_line":"    post-run: playbooks/airship-airshipctl-publish-images.yaml"},{"line_number":75,"context_line":"    secrets:"},{"line_number":76,"context_line":"      - image-repo-credentials"},{"line_number":77,"context_line":"    vars:"},{"line_number":78,"context_line":"      image: quay.io/airshipit/airshipctl"},{"line_number":79,"context_line":"      image_repo: https://quay.io/api/v1/"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"- secret:"},{"line_number":82,"context_line":"    name: image-repo-credentials"},{"line_number":83,"context_line":"    data:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_8d19fed2","line":80,"range":{"start_line":71,"start_character":2,"end_line":80,"end_character":0},"updated":"2020-02-12 22:02:55.000000000","message":"Job airship-airshipctl-build-image.yaml not defined","commit_id":"8b57c0fa4a473f4eabb4d4a27e119ae27c31f6b9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5fb31380aca34178a49160f32bf2c419f6bf350a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"      serve_dir: /srv/iso"},{"line_number":66,"context_line":"      serve_port: 8099"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"- job:"},{"line_number":69,"context_line":"    name: airship-airshipctl-publish-image"},{"line_number":70,"context_line":"    parent: airship-airshipctl-build-image"},{"line_number":71,"context_line":"    post-run: playbooks/airship-airshipctl-publish-images.yaml"},{"line_number":72,"context_line":"    secrets:"},{"line_number":73,"context_line":"      - image-repo-credentials"},{"line_number":74,"context_line":"    vars:"},{"line_number":75,"context_line":"      image: quay.io/airshipit/airshipctl"},{"line_number":76,"context_line":"      image_repo: https://quay.io/api/v1/"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_412847ec","line":76,"range":{"start_line":68,"start_character":2,"end_line":76,"end_character":0},"updated":"2020-02-19 20:41:27.000000000","message":"The secret \"image-repo-credentials\" was not found.","commit_id":"423d663204a151d45d2528a130f75a26954257a6"}],"zuul.d/projects.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d6fa9e14c5a924ae0abaf59c4d4f938169404129","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- project:"},{"line_number":14,"context_line":"    check:"},{"line_number":15,"context_line":"      jobs:"},{"line_number":16,"context_line":"        - airship-airshipctl-lint-unit"},{"line_number":17,"context_line":"        - airship-airshipctl-build-image"},{"line_number":18,"context_line":"        - airship-airshipctl-publish-image #TODO: remove this after testing"},{"line_number":19,"context_line":"        - airship-airshipctl-functional-existing-k8s"},{"line_number":20,"context_line":"        - airship-airshipctl-gate-test"},{"line_number":21,"context_line":"    gate:"},{"line_number":22,"context_line":"      jobs:"},{"line_number":23,"context_line":"        - airship-airshipctl-lint-unit"},{"line_number":24,"context_line":"        - airship-airshipctl-publish-image"},{"line_number":25,"context_line":"        - airship-airshipctl-functional-existing-k8s"},{"line_number":26,"context_line":"        - airship-airshipctl-gate-test"},{"line_number":27,"context_line":"    post:"},{"line_number":28,"context_line":"      jobs:"},{"line_number":29,"context_line":"        - airship-airshipctl-upload-git-mirror"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_4d10e6ab","line":29,"range":{"start_line":13,"start_character":2,"end_line":29,"end_character":0},"updated":"2020-02-12 22:00:41.000000000","message":"Job airship-airshipctl-publish-image not defined","commit_id":"6d5677c780780af12e74c41bcfe4f9721c6ce9dd"}],"zuul.d/secrets.yaml":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"d0ecb5d08d63fd7f8659694a07367e82f2ebe63a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"          595F3m2UtgR6QKN5xbJJmWp7ipihdRvQ1eVl5GCjG7MBi27YvILp4cIWg+MO1I\u003d"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- secret:"},{"line_number":62,"context_line":"    name: image-repo-credentials"},{"line_number":63,"context_line":"    data:"},{"line_number":64,"context_line":"      username: !encrypted/pkcs1-oaep"},{"line_number":65,"context_line":"        - IrKFuv6QJnGT7C/c6a4GCmDLJn0rZ82ivaAd3BjP3QyTegM95gVCOFC4l45NGRLLtzFun"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3fa7e38b_0f591b8c","line":62,"range":{"start_line":62,"start_character":10,"end_line":62,"end_character":32},"updated":"2020-02-19 19:51:23.000000000","message":"nit: might make this more clear to future developers that copy/pasting these creds into a new project will fail because of the per project encryption scheme.  I think a simple change of airshipctl-image-credentials would work.\n\nditto on the zuul role","commit_id":"bd693df7a08c27592378ec6502de392df67226f1"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4aa336a312267247bc097c2e5451e5bc65516a8f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"          595F3m2UtgR6QKN5xbJJmWp7ipihdRvQ1eVl5GCjG7MBi27YvILp4cIWg+MO1I\u003d"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- secret:"},{"line_number":62,"context_line":"    name: image-repo-credentials"},{"line_number":63,"context_line":"    data:"},{"line_number":64,"context_line":"      username: !encrypted/pkcs1-oaep"},{"line_number":65,"context_line":"        - IrKFuv6QJnGT7C/c6a4GCmDLJn0rZ82ivaAd3BjP3QyTegM95gVCOFC4l45NGRLLtzFun"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3fa7e38b_01324f5e","line":62,"range":{"start_line":62,"start_character":10,"end_line":62,"end_character":32},"in_reply_to":"3fa7e38b_0f591b8c","updated":"2020-02-19 20:41:37.000000000","message":"\u003e nit: might make this more clear to future developers that\n \u003e copy/pasting these creds into a new project will fail because of\n \u003e the per project encryption scheme.  I think a simple change of\n \u003e airshipctl-image-credentials would work.\n \u003e \n \u003e ditto on the zuul role\n\nDone.","commit_id":"bd693df7a08c27592378ec6502de392df67226f1"}]}