)]}'
{"pkg/cluster/cluster.go":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"24e9dd45ba0be19cf09f7775d189876f5401bf6f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"// GetClientSet getter for Clientset interface"},{"line_number":35,"context_line":"func (cluster *ClusterImpl) GetClientSet() kubernetes.Interface {"},{"line_number":36,"context_line":"\treturn cluster.Clientset"},{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-go","patch_set":6,"id":"3fa7e38b_d26e2afe","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":40},"updated":"2020-02-21 10:58:25.000000000","message":"\u0027Get\u0027 can be omitted for getters in golang https://golang.org/doc/effective_go.html#Getters","commit_id":"7427d8ddaf731b1fd531b12bf1dc3fca17b24d40"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"cc6f555a148a7d1d6b1fda3eaaa2e5df50ba6de5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"// GetClientSet getter for Clientset interface"},{"line_number":35,"context_line":"func (cluster *ClusterImpl) GetClientSet() kubernetes.Interface {"},{"line_number":36,"context_line":"\treturn cluster.Clientset"},{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-go","patch_set":6,"id":"3fa7e38b_782cf7b0","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":40},"in_reply_to":"3fa7e38b_d26e2afe","updated":"2020-02-21 13:30:15.000000000","message":"Done","commit_id":"7427d8ddaf731b1fd531b12bf1dc3fca17b24d40"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"24e9dd45ba0be19cf09f7775d189876f5401bf6f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"// GetKubectl getter for Kubectl interface"},{"line_number":40,"context_line":"func (cluster *ClusterImpl) GetKubectl() kubectl.Interface {"},{"line_number":41,"context_line":"\treturn cluster.Kubectl"},{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-go","patch_set":6,"id":"3fa7e38b_7247367b","line":40,"range":{"start_line":40,"start_character":28,"end_line":40,"end_character":38},"updated":"2020-02-21 10:58:25.000000000","message":"ditto","commit_id":"7427d8ddaf731b1fd531b12bf1dc3fca17b24d40"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"cc6f555a148a7d1d6b1fda3eaaa2e5df50ba6de5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"// GetKubectl getter for Kubectl interface"},{"line_number":40,"context_line":"func (cluster *ClusterImpl) GetKubectl() kubectl.Interface {"},{"line_number":41,"context_line":"\treturn cluster.Kubectl"},{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-go","patch_set":6,"id":"3fa7e38b_5829fb9f","line":40,"range":{"start_line":40,"start_character":28,"end_line":40,"end_character":38},"in_reply_to":"3fa7e38b_7247367b","updated":"2020-02-21 13:30:15.000000000","message":"Done","commit_id":"7427d8ddaf731b1fd531b12bf1dc3fca17b24d40"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"1fa35fcd8d29c728e5eb5ffdeca73928e2cad2a2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"// all kubernetes core objects with standard operations and kubectl"},{"line_number":21,"context_line":"// interface that is build on to of kubectl libraries and implements"},{"line_number":22,"context_line":"// such kubectl subcommands as kubectl apply (more will be added)"},{"line_number":23,"context_line":"type Cluster interface {"},{"line_number":24,"context_line":"\tClientSet() kubernetes.Interface"},{"line_number":25,"context_line":"\tKubectl() kubectl.Interface"},{"line_number":26,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":10,"id":"1fa4df85_fef9f34c","line":23,"range":{"start_line":23,"start_character":5,"end_line":23,"end_character":12},"updated":"2020-02-24 19:48:08.000000000","message":"Is \"Cluster\" the right name for this interface? Why don\u0027t we follow the pattern from k8s and call this an \"Interface\" and its implementation a \"Client\"\n\nFurther, is this the right package for these types? This probably needs a new \"client\" package","commit_id":"83f40ae3b34d1e035c0ad3a3ab0f897c1460569c"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"e6a28869af9836023cdaa421267da23d2d7eb0a1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"// all kubernetes core objects with standard operations and kubectl"},{"line_number":21,"context_line":"// interface that is build on to of kubectl libraries and implements"},{"line_number":22,"context_line":"// such kubectl subcommands as kubectl apply (more will be added)"},{"line_number":23,"context_line":"type Cluster interface {"},{"line_number":24,"context_line":"\tClientSet() kubernetes.Interface"},{"line_number":25,"context_line":"\tKubectl() kubectl.Interface"},{"line_number":26,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":10,"id":"1fa4df85_a19d9b5a","line":23,"range":{"start_line":23,"start_character":5,"end_line":23,"end_character":12},"in_reply_to":"1fa4df85_fef9f34c","updated":"2020-02-25 03:35:49.000000000","message":"Done","commit_id":"83f40ae3b34d1e035c0ad3a3ab0f897c1460569c"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"c8e3b801b985cb8fb42d047b9d4997c3b81662c8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"// ClusterImpl is implementation of Cluster interface"},{"line_number":29,"context_line":"type ClusterImpl struct {"},{"line_number":30,"context_line":"\tkubectl   kubectl.Interface"},{"line_number":31,"context_line":"\tclientset kubernetes.Interface"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"// ClientSet getter for Clientset interface"}],"source_content_type":"text/x-go","patch_set":10,"id":"1fa4df85_8fc68b16","line":31,"range":{"start_line":31,"start_character":7,"end_line":31,"end_character":10},"updated":"2020-02-24 23:06:17.000000000","message":"Could we just call this \"client\" instead of \"clientset\" -- I don\u0027t think the ClusterImpl object has to be tied to where a client comes from (i.e. that it\u0027s set as current-context in the config), and my first instinct was that a \"clientset\" would be a \"set of clients\".","commit_id":"83f40ae3b34d1e035c0ad3a3ab0f897c1460569c"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"e6a28869af9836023cdaa421267da23d2d7eb0a1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"// ClusterImpl is implementation of Cluster interface"},{"line_number":29,"context_line":"type ClusterImpl struct {"},{"line_number":30,"context_line":"\tkubectl   kubectl.Interface"},{"line_number":31,"context_line":"\tclientset kubernetes.Interface"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"// ClientSet getter for Clientset interface"}],"source_content_type":"text/x-go","patch_set":10,"id":"1fa4df85_41ae27e8","line":31,"range":{"start_line":31,"start_character":7,"end_line":31,"end_character":10},"in_reply_to":"1fa4df85_8fc68b16","updated":"2020-02-25 03:35:49.000000000","message":"In fact this is a client set, kubernetes interface provides a set of clients that you can create, such as pod client, deployment client. I am not 100% if i understood correctly what you mean though","commit_id":"83f40ae3b34d1e035c0ad3a3ab0f897c1460569c"}],"pkg/k8s/client/client.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"f6145fa1358e0691b25b0023a9c7665a94a61ed1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\tbuffDir \u003d \".airship\""},{"line_number":16,"context_line":")"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"// Interface interface provides an abstraction layer to intractions"},{"line_number":19,"context_line":"// with kubernetes clusters by getting Clientset which includes"},{"line_number":20,"context_line":"// all kubernetes core objects with standard operations and kubectl"},{"line_number":21,"context_line":"// interface that is build on to of kubectl libraries and implements"}],"source_content_type":"text/x-go","patch_set":11,"id":"1fa4df85_7c5f3941","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":22},"updated":"2020-02-25 18:09:54.000000000","message":"delete this","commit_id":"7f549e901ac6b5414af472d38c110719fca7db7d"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"f6145fa1358e0691b25b0023a9c7665a94a61ed1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\tbuffDir \u003d \".airship\""},{"line_number":16,"context_line":")"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"// Interface interface provides an abstraction layer to intractions"},{"line_number":19,"context_line":"// with kubernetes clusters by getting Clientset which includes"},{"line_number":20,"context_line":"// all kubernetes core objects with standard operations and kubectl"},{"line_number":21,"context_line":"// interface that is build on to of kubectl libraries and implements"}],"source_content_type":"text/x-go","patch_set":11,"id":"1fa4df85_9c5c754c","line":18,"range":{"start_line":18,"start_character":56,"end_line":18,"end_character":67},"updated":"2020-02-25 18:09:54.000000000","message":"interactions","commit_id":"7f549e901ac6b5414af472d38c110719fca7db7d"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"7c90e1e0a3c44e97e247c3489d5a23788b4131b1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\tbuffDir \u003d \".airship\""},{"line_number":16,"context_line":")"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"// Interface interface provides an abstraction layer to intractions"},{"line_number":19,"context_line":"// with kubernetes clusters by getting Clientset which includes"},{"line_number":20,"context_line":"// all kubernetes core objects with standard operations and kubectl"},{"line_number":21,"context_line":"// interface that is build on to of kubectl libraries and implements"}],"source_content_type":"text/x-go","patch_set":11,"id":"1fa4df85_b074f59a","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":22},"in_reply_to":"1fa4df85_7c5f3941","updated":"2020-02-25 18:24:47.000000000","message":"Done","commit_id":"7f549e901ac6b5414af472d38c110719fca7db7d"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"f6145fa1358e0691b25b0023a9c7665a94a61ed1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"// Interface interface provides an abstraction layer to intractions"},{"line_number":19,"context_line":"// with kubernetes clusters by getting Clientset which includes"},{"line_number":20,"context_line":"// all kubernetes core objects with standard operations and kubectl"},{"line_number":21,"context_line":"// interface that is build on to of kubectl libraries and implements"},{"line_number":22,"context_line":"// such kubectl subcommands as kubectl apply (more will be added)"},{"line_number":23,"context_line":"type Interface interface {"},{"line_number":24,"context_line":"\tClientSet() kubernetes.Interface"}],"source_content_type":"text/x-go","patch_set":11,"id":"1fa4df85_1c364505","line":21,"range":{"start_line":21,"start_character":21,"end_line":21,"end_character":26},"updated":"2020-02-25 18:09:54.000000000","message":"built","commit_id":"7f549e901ac6b5414af472d38c110719fca7db7d"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"f6145fa1358e0691b25b0023a9c7665a94a61ed1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"// Interface interface provides an abstraction layer to intractions"},{"line_number":19,"context_line":"// with kubernetes clusters by getting Clientset which includes"},{"line_number":20,"context_line":"// all kubernetes core objects with standard operations and kubectl"},{"line_number":21,"context_line":"// interface that is build on to of kubectl libraries and implements"},{"line_number":22,"context_line":"// such kubectl subcommands as kubectl apply (more will be added)"},{"line_number":23,"context_line":"type Interface interface {"},{"line_number":24,"context_line":"\tClientSet() kubernetes.Interface"}],"source_content_type":"text/x-go","patch_set":11,"id":"1fa4df85_bc3a91e4","line":21,"range":{"start_line":21,"start_character":30,"end_line":21,"end_character":32},"updated":"2020-02-25 18:09:54.000000000","message":"top","commit_id":"7f549e901ac6b5414af472d38c110719fca7db7d"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"7c90e1e0a3c44e97e247c3489d5a23788b4131b1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"// Interface interface provides an abstraction layer to intractions"},{"line_number":19,"context_line":"// with kubernetes clusters by getting Clientset which includes"},{"line_number":20,"context_line":"// all kubernetes core objects with standard operations and kubectl"},{"line_number":21,"context_line":"// interface that is build on to of kubectl libraries and implements"},{"line_number":22,"context_line":"// such kubectl subcommands as kubectl apply (more will be added)"},{"line_number":23,"context_line":"type Interface interface {"},{"line_number":24,"context_line":"\tClientSet() kubernetes.Interface"}],"source_content_type":"text/x-go","patch_set":11,"id":"1fa4df85_506901bc","line":21,"range":{"start_line":21,"start_character":21,"end_line":21,"end_character":26},"in_reply_to":"1fa4df85_1c364505","updated":"2020-02-25 18:24:47.000000000","message":"Done","commit_id":"7f549e901ac6b5414af472d38c110719fca7db7d"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"f6145fa1358e0691b25b0023a9c7665a94a61ed1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"// ClientSet getter for Clientset interface"},{"line_number":35,"context_line":"func (cluster *Client) ClientSet() kubernetes.Interface {"},{"line_number":36,"context_line":"\treturn cluster.clientset"},{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-go","patch_set":11,"id":"1fa4df85_5c2b5d93","line":35,"range":{"start_line":35,"start_character":6,"end_line":35,"end_character":13},"updated":"2020-02-25 18:09:54.000000000","message":"this probably needs to be renamed. Honestly, \"c\" or \"cl\" should be sufficient","commit_id":"7f549e901ac6b5414af472d38c110719fca7db7d"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"7c90e1e0a3c44e97e247c3489d5a23788b4131b1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"// ClientSet getter for Clientset interface"},{"line_number":35,"context_line":"func (cluster *Client) ClientSet() kubernetes.Interface {"},{"line_number":36,"context_line":"\treturn cluster.clientset"},{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-go","patch_set":11,"id":"1fa4df85_306005cf","line":35,"range":{"start_line":35,"start_character":6,"end_line":35,"end_character":13},"in_reply_to":"1fa4df85_5c2b5d93","updated":"2020-02-25 18:24:47.000000000","message":"Done","commit_id":"7f549e901ac6b5414af472d38c110719fca7db7d"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"f6145fa1358e0691b25b0023a9c7665a94a61ed1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"// Kubectl getter for Kubectl interface"},{"line_number":40,"context_line":"func (cluster *Client) Kubectl() kubectl.Interface {"},{"line_number":41,"context_line":"\treturn cluster.kubectl"},{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-go","patch_set":11,"id":"1fa4df85_fc19e987","line":40,"range":{"start_line":40,"start_character":6,"end_line":40,"end_character":13},"updated":"2020-02-25 18:09:54.000000000","message":"ditto","commit_id":"7f549e901ac6b5414af472d38c110719fca7db7d"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"7c90e1e0a3c44e97e247c3489d5a23788b4131b1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"// Kubectl getter for Kubectl interface"},{"line_number":40,"context_line":"func (cluster *Client) Kubectl() kubectl.Interface {"},{"line_number":41,"context_line":"\treturn cluster.kubectl"},{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-go","patch_set":11,"id":"1fa4df85_106389de","line":40,"range":{"start_line":40,"start_character":6,"end_line":40,"end_character":13},"in_reply_to":"1fa4df85_fc19e987","updated":"2020-02-25 18:24:47.000000000","message":"Done","commit_id":"7f549e901ac6b5414af472d38c110719fca7db7d"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"f6145fa1358e0691b25b0023a9c7665a94a61ed1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"// SetClientset setter for Clientset interface"},{"line_number":61,"context_line":"func (cluster *Client) SetClientset(cs kubernetes.Interface) {"},{"line_number":62,"context_line":"\tcluster.clientset \u003d cs"},{"line_number":63,"context_line":"}"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-go","patch_set":11,"id":"1fa4df85_1c1f256d","line":61,"range":{"start_line":61,"start_character":6,"end_line":61,"end_character":13},"updated":"2020-02-25 18:09:54.000000000","message":"ditto","commit_id":"7f549e901ac6b5414af472d38c110719fca7db7d"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"7c90e1e0a3c44e97e247c3489d5a23788b4131b1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"// SetClientset setter for Clientset interface"},{"line_number":61,"context_line":"func (cluster *Client) SetClientset(cs kubernetes.Interface) {"},{"line_number":62,"context_line":"\tcluster.clientset \u003d cs"},{"line_number":63,"context_line":"}"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-go","patch_set":11,"id":"1fa4df85_308ec578","line":61,"range":{"start_line":61,"start_character":6,"end_line":61,"end_character":13},"in_reply_to":"1fa4df85_1c1f256d","updated":"2020-02-25 18:24:47.000000000","message":"Done","commit_id":"7f549e901ac6b5414af472d38c110719fca7db7d"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"f6145fa1358e0691b25b0023a9c7665a94a61ed1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"// SetKubectl setter for Kubectl interface"},{"line_number":66,"context_line":"func (cluster *Client) SetKubectl(kctl kubectl.Interface) {"},{"line_number":67,"context_line":"\tcluster.kubectl \u003d kctl"},{"line_number":68,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":11,"id":"1fa4df85_bc137166","line":66,"range":{"start_line":66,"start_character":6,"end_line":66,"end_character":13},"updated":"2020-02-25 18:09:54.000000000","message":"ditto","commit_id":"7f549e901ac6b5414af472d38c110719fca7db7d"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"7c90e1e0a3c44e97e247c3489d5a23788b4131b1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"// SetKubectl setter for Kubectl interface"},{"line_number":66,"context_line":"func (cluster *Client) SetKubectl(kctl kubectl.Interface) {"},{"line_number":67,"context_line":"\tcluster.kubectl \u003d kctl"},{"line_number":68,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":11,"id":"1fa4df85_d0e89117","line":66,"range":{"start_line":66,"start_character":6,"end_line":66,"end_character":13},"in_reply_to":"1fa4df85_bc137166","updated":"2020-02-25 18:24:47.000000000","message":"Done","commit_id":"7f549e901ac6b5414af472d38c110719fca7db7d"},{"author":{"_account_id":31248,"name":"Arvinderpal Wander","email":"awander@gmail.com","username":"awander"},"change_message_id":"14d209f804812441aba2e8777aa83c3400f9b9b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1fa4df85_8e566d29","updated":"2020-02-26 15:38:30.000000000","message":"Would we be able to work with schemes beyond the usual K resource types.\n\nThe following pkg is used extensively in the capi projects. It provides a convenient means by which to work with additional schemes (e.g. Cluster, Machine, BareMetalMachine,etc). \n\nsigs.k8s.io/controller-runtime/pkg/client","commit_id":"9afeccb7858834ba1ded950fb48a9dbb0deab029"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"16627a4ab1aa6d52b92d9ce39f9d9d6470030c5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1fa4df85_7b32ccf3","in_reply_to":"1fa4df85_8e566d29","updated":"2020-02-26 16:34:17.000000000","message":"We can extend interface with controller-runtime clients i am sure.","commit_id":"9afeccb7858834ba1ded950fb48a9dbb0deab029"}],"pkg/k8s/kubectl/apply_options.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"1fa35fcd8d29c728e5eb5ffdeca73928e2cad2a2","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"// ApplyOptions is a abstraction layer"},{"line_number":11,"context_line":"// to ApplyOptions of kubectl/apply package"},{"line_number":12,"context_line":"type ApplyOptions struct {"},{"line_number":13,"context_line":"\tApplyOptions *apply.ApplyOptions"},{"line_number":14,"context_line":"}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-go","patch_set":10,"id":"1fa4df85_1e6c0f35","line":12,"range":{"start_line":12,"start_character":5,"end_line":12,"end_character":17},"updated":"2020-02-24 19:48:08.000000000","message":"As is, this struct doesn\u0027t seem very useful - why not just use a *apply.ApplyOptions directly?\n\nIf we\u0027re aiming for future proofing or preventing import bloat, it\u0027d probably be better to embed the *apply.ApplyOptions and add wrapper functions as needed.","commit_id":"83f40ae3b34d1e035c0ad3a3ab0f897c1460569c"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"e6a28869af9836023cdaa421267da23d2d7eb0a1","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"// ApplyOptions is a abstraction layer"},{"line_number":11,"context_line":"// to ApplyOptions of kubectl/apply package"},{"line_number":12,"context_line":"type ApplyOptions struct {"},{"line_number":13,"context_line":"\tApplyOptions *apply.ApplyOptions"},{"line_number":14,"context_line":"}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-go","patch_set":10,"id":"1fa4df85_21b52b32","line":12,"range":{"start_line":12,"start_character":5,"end_line":12,"end_character":17},"in_reply_to":"1fa4df85_1e6c0f35","updated":"2020-02-25 03:35:49.000000000","message":"I don\u0027t think i fully understand what you mean by embed. Do you mean embed them into kubectl struct? there will be more options to come, such as delete options, get options, list options etc. \n\nMy intetion was to provide since point of import for apply options, and some wrappers to allow set such items as dryrun, prune, source file options.","commit_id":"83f40ae3b34d1e035c0ad3a3ab0f897c1460569c"}]}
