)]}'
{"cmd/config/set_context.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"91fb30f674458f5ea93b6934803067aa702eb2d9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\t\t\tif nFlags \u003d\u003d 0 {"},{"line_number":60,"context_line":"\t\t\t\t// Change the current context to the provided context name if no flags are provided"},{"line_number":61,"context_line":"\t\t\t\to.CurrentContext \u003d true"},{"line_number":62,"context_line":"\t\t\t\tfmt.Fprintf(cmd.OutOrStdout(), \"WARNING: Switching contexts using \\\"airshipctl config\"+"},{"line_number":63,"context_line":"\t\t\t\t\t\"set-context [NAME]\\\" is DEPRECATED. Use \\\"airshipctl config use-context [NAME]\\\" instead.\\n\")"},{"line_number":64,"context_line":"\t\t\t}"},{"line_number":65,"context_line":"\t\t\to.Name \u003d args[0]"}],"source_content_type":"text/x-go","patch_set":1,"id":"3fa7e38b_aa268ecb","line":62,"range":{"start_line":62,"start_character":35,"end_line":62,"end_character":90},"updated":"2020-02-21 21:58:04.000000000","message":"Could we change these double quotes to backticks to circumvent the escaping?","commit_id":"6812b4eedc58de68361433b4c4822d924aaf337b"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"91fb30f674458f5ea93b6934803067aa702eb2d9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\t\t\tif nFlags \u003d\u003d 0 {"},{"line_number":60,"context_line":"\t\t\t\t// Change the current context to the provided context name if no flags are provided"},{"line_number":61,"context_line":"\t\t\t\to.CurrentContext \u003d true"},{"line_number":62,"context_line":"\t\t\t\tfmt.Fprintf(cmd.OutOrStdout(), \"WARNING: Switching contexts using \\\"airshipctl config\"+"},{"line_number":63,"context_line":"\t\t\t\t\t\"set-context [NAME]\\\" is DEPRECATED. Use \\\"airshipctl config use-context [NAME]\\\" instead.\\n\")"},{"line_number":64,"context_line":"\t\t\t}"},{"line_number":65,"context_line":"\t\t\to.Name \u003d args[0]"}],"source_content_type":"text/x-go","patch_set":1,"id":"3fa7e38b_ea1c867d","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":15},"updated":"2020-02-21 21:58:04.000000000","message":"Fprintln should suffice here","commit_id":"6812b4eedc58de68361433b4c4822d924aaf337b"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"2cf82292ab3127a2f90aeede24a24f305ab5e3d1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\t\t\tif nFlags \u003d\u003d 0 {"},{"line_number":60,"context_line":"\t\t\t\t// Change the current context to the provided context name if no flags are provided"},{"line_number":61,"context_line":"\t\t\t\to.CurrentContext \u003d true"},{"line_number":62,"context_line":"\t\t\t\tfmt.Fprintf(cmd.OutOrStdout(), \"WARNING: Switching contexts using \\\"airshipctl config\"+"},{"line_number":63,"context_line":"\t\t\t\t\t\"set-context [NAME]\\\" is DEPRECATED. Use \\\"airshipctl config use-context [NAME]\\\" instead.\\n\")"},{"line_number":64,"context_line":"\t\t\t}"},{"line_number":65,"context_line":"\t\t\to.Name \u003d args[0]"}],"source_content_type":"text/x-go","patch_set":1,"id":"3fa7e38b_10d91054","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":15},"in_reply_to":"3fa7e38b_ea1c867d","updated":"2020-02-21 23:00:32.000000000","message":"I removed this whole section, which I believe made these suggestions no longer applicable.","commit_id":"6812b4eedc58de68361433b4c4822d924aaf337b"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"2e661e44b65f90f5a032c09c31aecccabfe84c8e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"\t\tExample: setContextExample,"},{"line_number":56,"context_line":"\t\tArgs:    cobra.ExactArgs(1),"},{"line_number":57,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":58,"context_line":"\t\t\to.Name \u003d args[0]"},{"line_number":59,"context_line":"\t\t\tnFlags :\u003d cmd.Flags().NFlag()"},{"line_number":60,"context_line":"\t\t\tif nFlags \u003d\u003d 0 {"},{"line_number":61,"context_line":"\t\t\t\tfmt.Fprintf(cmd.OutOrStdout(), \"Context %q not modified. No new options provided.\\n\", o.Name)"},{"line_number":62,"context_line":"\t\t\t\treturn nil"},{"line_number":63,"context_line":"\t\t\t}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"\t\t\tmodified, err :\u003d config.RunSetContext(o, rootSettings.Config(), true)"},{"line_number":66,"context_line":"\t\t\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"1fa4df85_005fd741","line":63,"range":{"start_line":58,"start_character":0,"end_line":63,"end_character":4},"updated":"2020-02-24 13:37:40.000000000","message":"suggest using Cobra to enforce min args, or exact args here.  see [0]\n\nhttps://github.com/spf13/cobra#positional-and-custom-arguments","commit_id":"9818d51dc401af71d706e8f8bf845c7dc579bb79"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"52b7455e8d7fbfb0af25a1f04c4c89e96d49c385","unresolved":false,"context_lines":[{"line_number":55,"context_line":"\t\tExample: setContextExample,"},{"line_number":56,"context_line":"\t\tArgs:    cobra.ExactArgs(1),"},{"line_number":57,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":58,"context_line":"\t\t\to.Name \u003d args[0]"},{"line_number":59,"context_line":"\t\t\tnFlags :\u003d cmd.Flags().NFlag()"},{"line_number":60,"context_line":"\t\t\tif nFlags \u003d\u003d 0 {"},{"line_number":61,"context_line":"\t\t\t\tfmt.Fprintf(cmd.OutOrStdout(), \"Context %q not modified. No new options provided.\\n\", o.Name)"},{"line_number":62,"context_line":"\t\t\t\treturn nil"},{"line_number":63,"context_line":"\t\t\t}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"\t\t\tmodified, err :\u003d config.RunSetContext(o, rootSettings.Config(), true)"},{"line_number":66,"context_line":"\t\t\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"1fa4df85_56afd593","line":63,"range":{"start_line":58,"start_character":0,"end_line":63,"end_character":4},"in_reply_to":"1fa4df85_005fd741","updated":"2020-02-24 15:01:29.000000000","message":"Alex: This checks the number of flags as opposed to the number of args.","commit_id":"9818d51dc401af71d706e8f8bf845c7dc579bb79"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"9decd5b28cb31da143da5c58352293bd3ff843fb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"\t\tExample: setContextExample,"},{"line_number":56,"context_line":"\t\tArgs:    cobra.ExactArgs(1),"},{"line_number":57,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":58,"context_line":"\t\t\to.Name \u003d args[0]"},{"line_number":59,"context_line":"\t\t\tnFlags :\u003d cmd.Flags().NFlag()"},{"line_number":60,"context_line":"\t\t\tif nFlags \u003d\u003d 0 {"},{"line_number":61,"context_line":"\t\t\t\tfmt.Fprintf(cmd.OutOrStdout(), \"Context %q not modified. No new options provided.\\n\", o.Name)"},{"line_number":62,"context_line":"\t\t\t\treturn nil"},{"line_number":63,"context_line":"\t\t\t}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"\t\t\tmodified, err :\u003d config.RunSetContext(o, rootSettings.Config(), true)"},{"line_number":66,"context_line":"\t\t\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"1fa4df85_16695d24","line":63,"range":{"start_line":58,"start_character":0,"end_line":63,"end_character":4},"in_reply_to":"1fa4df85_56afd593","updated":"2020-02-24 15:07:56.000000000","message":"My mistake, thanks Ian.","commit_id":"9818d51dc401af71d706e8f8bf845c7dc579bb79"}],"cmd/config/set_context_test.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"91fb30f674458f5ea93b6934803067aa702eb2d9","unresolved":false,"context_lines":[{"line_number":121,"context_line":"\t\tdescription: \"Testing \u0027airshipctl config set-context\u0027 with a new current context\","},{"line_number":122,"context_line":"\t\tgivenConfig: given,"},{"line_number":123,"context_line":"\t\targs:        []string{tname},"},{"line_number":124,"context_line":"\t\texpectedOutput: fmt.Sprintf(\"WARNING: Switching contexts using \\\"airshipctl configset-context [NAME]\\\" is\"+"},{"line_number":125,"context_line":"\t\t\t\" DEPRECATED. Use \\\"airshipctl config use-context [NAME]\\\" instead.\\nContext %q modified.\\n\", tname),"},{"line_number":126,"context_line":"\t\texpectedConfig: expected,"},{"line_number":127,"context_line":"\t}"},{"line_number":128,"context_line":"\ttest.run(t)"}],"source_content_type":"text/x-go","patch_set":1,"id":"3fa7e38b_0a01e208","line":125,"range":{"start_line":124,"start_character":0,"end_line":125,"end_character":104},"updated":"2020-02-21 21:58:04.000000000","message":"same here with backticks","commit_id":"6812b4eedc58de68361433b4c4822d924aaf337b"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"2cf82292ab3127a2f90aeede24a24f305ab5e3d1","unresolved":false,"context_lines":[{"line_number":121,"context_line":"\t\tdescription: \"Testing \u0027airshipctl config set-context\u0027 with a new current context\","},{"line_number":122,"context_line":"\t\tgivenConfig: given,"},{"line_number":123,"context_line":"\t\targs:        []string{tname},"},{"line_number":124,"context_line":"\t\texpectedOutput: fmt.Sprintf(\"WARNING: Switching contexts using \\\"airshipctl configset-context [NAME]\\\" is\"+"},{"line_number":125,"context_line":"\t\t\t\" DEPRECATED. Use \\\"airshipctl config use-context [NAME]\\\" instead.\\nContext %q modified.\\n\", tname),"},{"line_number":126,"context_line":"\t\texpectedConfig: expected,"},{"line_number":127,"context_line":"\t}"},{"line_number":128,"context_line":"\ttest.run(t)"}],"source_content_type":"text/x-go","patch_set":1,"id":"3fa7e38b_b0dfdc37","line":125,"range":{"start_line":124,"start_character":0,"end_line":125,"end_character":104},"in_reply_to":"3fa7e38b_0a01e208","updated":"2020-02-21 23:00:32.000000000","message":"\u003e same here with backticks\n\nSame as previous file.","commit_id":"6812b4eedc58de68361433b4c4822d924aaf337b"}]}