)]}'
{"pkg/remote/remote_direct.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"92ce149c37aa3508c2c4998c1b184d8802139880","unresolved":false,"context_lines":[{"line_number":106,"context_line":"\t\treturn nil, \"\", err"},{"line_number":107,"context_line":"\t}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"\tif remoteConfig :\u003d bootstrapSettings.RemoteDirect; remoteConfig !\u003d nil {"},{"line_number":110,"context_line":"\t\treturn remoteConfig, remoteURL, nil"},{"line_number":111,"context_line":"\t}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"\treturn nil, \"\", config.ErrMissingConfig{What: \"RemoteDirect options not defined in bootstrap config\"}"},{"line_number":114,"context_line":"}"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"// Top level function to execute remote direct based on remote type"}],"source_content_type":"text/x-go","patch_set":1,"id":"1fa4df85_3bc3f4ef","line":113,"range":{"start_line":109,"start_character":0,"end_line":113,"end_character":102},"updated":"2020-02-26 17:08:07.000000000","message":"Could we move this error checking to around line 78? We could get an faster failure","commit_id":"3b3e70490ea6f987b4eebdd9fbff40118bf8978d"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"a047ababa3d5cb16266fd246928f3e295f63fd35","unresolved":false,"context_lines":[{"line_number":106,"context_line":"\t\treturn nil, \"\", err"},{"line_number":107,"context_line":"\t}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"\tif remoteConfig :\u003d bootstrapSettings.RemoteDirect; remoteConfig !\u003d nil {"},{"line_number":110,"context_line":"\t\treturn remoteConfig, remoteURL, nil"},{"line_number":111,"context_line":"\t}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"\treturn nil, \"\", config.ErrMissingConfig{What: \"RemoteDirect options not defined in bootstrap config\"}"},{"line_number":114,"context_line":"}"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"// Top level function to execute remote direct based on remote type"}],"source_content_type":"text/x-go","patch_set":1,"id":"1fa4df85_3119d5d6","line":113,"range":{"start_line":109,"start_character":0,"end_line":113,"end_character":102},"in_reply_to":"1fa4df85_3bc3f4ef","updated":"2020-02-26 18:33:45.000000000","message":"\u003e Could we move this error checking to around line 78? We could get\n \u003e an faster failure\n\nDone.","commit_id":"3b3e70490ea6f987b4eebdd9fbff40118bf8978d"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"8f53b8420e349a88ca6989423f46ebba3658c4a7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"\t\treturn nil, \"\", err"},{"line_number":78,"context_line":"\t}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"\tremoteConfig :\u003d bootstrapSettings.RemoteDirect"},{"line_number":81,"context_line":"\tif remoteConfig \u003d\u003d nil {"},{"line_number":82,"context_line":"\t\treturn nil, \"\", config.ErrMissingConfig{What: \"RemoteDirect options not defined in bootstrap config\"}"},{"line_number":83,"context_line":"\t}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"\t// TODO (dukov) replace with the appropriate function once it\u0027s available"},{"line_number":86,"context_line":"\t// in document module"}],"source_content_type":"text/x-go","patch_set":3,"id":"1fa4df85_cdd69828","line":83,"range":{"start_line":80,"start_character":0,"end_line":83,"end_character":2},"updated":"2020-02-27 15:38:05.000000000","message":"Just nit. We may need to move this somewhere to config module (e.g. under EnsureComplete method) eventually","commit_id":"306d709e12a63b763d8d2b2f8df4e0c81d7d116e"}]}