)]}'
{"pkg/bootstrap/isogen/command.go":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"aacbb2a007b5e07e3c4414ad3eeb19ba81400c01","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"\t// TODO (dukov) replace with the appropriate function once it\u0027s available"},{"line_number":48,"context_line":"\t// in document module"},{"line_number":49,"context_line":"\tdocBundle, err :\u003d document.NewBundle(document.NewDocumentFs(), manifest.TargetPath, \"\")"},{"line_number":50,"context_line":"\tif err !\u003d nil {"},{"line_number":51,"context_line":"\t\treturn err"},{"line_number":52,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":7,"id":"1fa4df85_922190fe","line":49,"range":{"start_line":49,"start_character":19,"end_line":49,"end_character":88},"updated":"2020-02-28 10:29:09.000000000","message":"i\u0027d replace this with something like NewBundle(targetPath). we do not really need separate filesystem object supplied to bundle factory","commit_id":"f062f5d6c31a7f899378ca81f22bc1f5b975199f"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"c616b252325621127bafc163003e0f5d3fed3c68","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"\t// TODO (dukov) replace with the appropriate function once it\u0027s available"},{"line_number":48,"context_line":"\t// in document module"},{"line_number":49,"context_line":"\tdocBundle, err :\u003d document.NewBundle(document.NewDocumentFs(), manifest.TargetPath, \"\")"},{"line_number":50,"context_line":"\tif err !\u003d nil {"},{"line_number":51,"context_line":"\t\treturn err"},{"line_number":52,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":7,"id":"1fa4df85_555a1d2a","line":49,"range":{"start_line":49,"start_character":19,"end_line":49,"end_character":88},"in_reply_to":"1fa4df85_922190fe","updated":"2020-02-28 16:15:20.000000000","message":"i\u0027ll try embedding NewDocumentFs() into newbundle, but i think that we have and will have even more usecases where filesystem will be used outside bundle object","commit_id":"f062f5d6c31a7f899378ca81f22bc1f5b975199f"}],"pkg/document/bundle.go":[{"author":{"_account_id":27046,"name":"Rodolfo Pacheco","email":"jezogwza@gmail.com","username":"jezogwza2723"},"change_message_id":"440c10850f385ffc600705501d90851d5bf81846","unresolved":false,"context_lines":[{"line_number":59,"context_line":"// NewBundle is a convenience function to create a new bundle"},{"line_number":60,"context_line":"// Over time, it will evolve to support allowing more control"},{"line_number":61,"context_line":"// for kustomize plugins"},{"line_number":62,"context_line":"func NewBundle(fSys FileSystem, kustomizePath string, outputPath string) (bundle Bundle, err error) {"},{"line_number":63,"context_line":"\tvar options \u003d KustomizeBuildOptions{"},{"line_number":64,"context_line":"\t\tKustomizationPath: kustomizePath,"},{"line_number":65,"context_line":"\t\tOutputPath:        outputPath,"}],"source_content_type":"text/x-go","patch_set":12,"id":"1fa4df85_075bb186","line":62,"updated":"2020-03-06 16:15:47.000000000","message":"I see that in the call . from isogen, we basically pass a new  document.NewFS or whatever is call. If that is usually the case, why not simple avoid this argument, instantiate it within the NewBundle, and the user can getFs from the bundle if they need to do something with it.","commit_id":"76a280ead07d8b3e6fbb69820f8fe37e9df1a1d5"}],"pkg/document/filesystem.go":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"aacbb2a007b5e07e3c4414ad3eeb19ba81400c01","unresolved":false,"context_lines":[{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"// NewDocumentFs returns an instalce of DocumentFs"},{"line_number":27,"context_line":"func NewDocumentFs() FileSystem {"},{"line_number":28,"context_line":"\treturn \u0026DocumentFs{FileSystem: fs.MakeRealFS()}"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"// TempFile creates file in temporary filesystem, at default os.TempDir"},{"line_number":32,"context_line":"func (dfs DocumentFs) TempFile(tmpDir string, prefix string) (File, error) {"}],"source_content_type":"text/x-go","patch_set":7,"id":"1fa4df85_f239e43e","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":1},"updated":"2020-02-28 10:29:09.000000000","message":"do we really need this function. basically we can hide it MakeRealFS under NewBundle function","commit_id":"f062f5d6c31a7f899378ca81f22bc1f5b975199f"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"c616b252325621127bafc163003e0f5d3fed3c68","unresolved":false,"context_lines":[{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"// NewDocumentFs returns an instalce of DocumentFs"},{"line_number":27,"context_line":"func NewDocumentFs() FileSystem {"},{"line_number":28,"context_line":"\treturn \u0026DocumentFs{FileSystem: fs.MakeRealFS()}"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"// TempFile creates file in temporary filesystem, at default os.TempDir"},{"line_number":32,"context_line":"func (dfs DocumentFs) TempFile(tmpDir string, prefix string) (File, error) {"}],"source_content_type":"text/x-go","patch_set":7,"id":"1fa4df85_153ca5bd","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":1},"in_reply_to":"1fa4df85_f239e43e","updated":"2020-02-28 16:15:20.000000000","message":"We do need this function, it is used in kubectl module, and i imagine that filesystem will have more use in future.\n\nThere is also another filesystem (which is much wider interface, that is used by document.repostiory module), which we can eventually merge into single filesystem instead (maybe), but this indicates that, imho, that we do need filesystem objects available outside the bundle object.","commit_id":"f062f5d6c31a7f899378ca81f22bc1f5b975199f"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"3f8b6a8e0f30aba93310cf0b0ca79c326a2d9df8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\tTempFile(string, string) (File, error)"},{"line_number":19,"context_line":"}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"// DocumentFs is adaptor to TempFile"},{"line_number":22,"context_line":"type DocumentFs struct {"},{"line_number":23,"context_line":"\tfs.FileSystem"},{"line_number":24,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":9,"id":"1fa4df85_9fd966f4","line":21,"range":{"start_line":21,"start_character":17,"end_line":21,"end_character":24},"updated":"2020-03-03 14:10:14.000000000","message":"nit: adapter","commit_id":"5de19a027f1ed6ec6a8ed0cbac129842c96007c0"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"3f8b6a8e0f30aba93310cf0b0ca79c326a2d9df8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\tfs.FileSystem"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"// NewDocumentFs returns an instalce of DocumentFs"},{"line_number":27,"context_line":"func NewDocumentFs() FileSystem {"},{"line_number":28,"context_line":"\treturn \u0026DocumentFs{FileSystem: fs.MakeRealFS()}"},{"line_number":29,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":9,"id":"1fa4df85_3fe2b2a1","line":26,"range":{"start_line":26,"start_character":28,"end_line":26,"end_character":36},"updated":"2020-03-03 14:10:14.000000000","message":"nit: instance","commit_id":"5de19a027f1ed6ec6a8ed0cbac129842c96007c0"}],"testutil/testdatafs.go":[{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"755bbe08920687bee6e95c2e7e62a52bf660b43e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"func SetupTestFs(t *testing.T, fixtureDir string) document.FileSystem {"},{"line_number":21,"context_line":"\tt.Helper()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"\tx :\u003d \u0026document.DocumentFs{FileSystem: fs.MakeFakeFS()}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"\tfiles, err :\u003d ioutil.ReadDir(fixtureDir)"},{"line_number":26,"context_line":"\trequire.NoErrorf(t, err, \"Failed to read fixture directory %s\", fixtureDir)"}],"source_content_type":"text/x-go","patch_set":4,"id":"1fa4df85_6379b52d","line":23,"updated":"2020-02-27 17:50:36.000000000","message":"can we not localize fs.MakeFakeFS too within document?","commit_id":"242c9a1d59dfc4ed4b0cea4757a03f615b60f791"}]}