)]}'
{"Makefile":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4a1ad1f5ada8d2d46a0c05343e2d1bc458921d1a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"delete-golden:"},{"line_number":172,"context_line":"\t@find . -type f -name \"*.golden\" -delete"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"# Used by gates after unit-tests and update-golden targets to ensure no files are deleted."},{"line_number":175,"context_line":".PHONY: check-git-diff"},{"line_number":176,"context_line":"check-git-diff:"},{"line_number":177,"context_line":"\t@./tools/git_diff_check"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1fa4df85_a5d1b025","line":177,"range":{"start_line":174,"start_character":0,"end_line":177,"end_character":24},"updated":"2020-03-03 18:51:36.000000000","message":"Does this need to be in the Makefile? It seems like git diff could be executed from the task itself.","commit_id":"93a53fe83ab900c59b9ce2dffe9ae222cac10193"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"39495d34483b142362362c12b1fdc324549be7db","unresolved":false,"context_lines":[{"line_number":171,"context_line":"delete-golden:"},{"line_number":172,"context_line":"\t@find . -type f -name \"*.golden\" -delete"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"# Used by gates after unit-tests and update-golden targets to ensure no files are deleted."},{"line_number":175,"context_line":".PHONY: check-git-diff"},{"line_number":176,"context_line":"check-git-diff:"},{"line_number":177,"context_line":"\t@./tools/git_diff_check"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1fa4df85_d12b3892","line":177,"range":{"start_line":174,"start_character":0,"end_line":177,"end_character":24},"in_reply_to":"1fa4df85_459c7c0e","updated":"2020-03-04 20:16:21.000000000","message":"Kept the target, but calling it as part of a series of targets in latest patch","commit_id":"93a53fe83ab900c59b9ce2dffe9ae222cac10193"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"1183f0a17784e795647efa77759a7bb14e70fe24","unresolved":false,"context_lines":[{"line_number":171,"context_line":"delete-golden:"},{"line_number":172,"context_line":"\t@find . -type f -name \"*.golden\" -delete"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"# Used by gates after unit-tests and update-golden targets to ensure no files are deleted."},{"line_number":175,"context_line":".PHONY: check-git-diff"},{"line_number":176,"context_line":"check-git-diff:"},{"line_number":177,"context_line":"\t@./tools/git_diff_check"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1fa4df85_459c7c0e","line":177,"range":{"start_line":174,"start_character":0,"end_line":177,"end_character":24},"in_reply_to":"1fa4df85_45f79c60","updated":"2020-03-03 19:20:20.000000000","message":"On a second glance, that might not be feasible though","commit_id":"93a53fe83ab900c59b9ce2dffe9ae222cac10193"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"9f1b6694b833f6102d5bab266e10df4b45dc365b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"delete-golden:"},{"line_number":172,"context_line":"\t@find . -type f -name \"*.golden\" -delete"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"# Used by gates after unit-tests and update-golden targets to ensure no files are deleted."},{"line_number":175,"context_line":".PHONY: check-git-diff"},{"line_number":176,"context_line":"check-git-diff:"},{"line_number":177,"context_line":"\t@./tools/git_diff_check"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1fa4df85_45f79c60","line":177,"range":{"start_line":174,"start_character":0,"end_line":177,"end_character":24},"in_reply_to":"1fa4df85_a5d1b025","updated":"2020-03-03 19:17:58.000000000","message":"Honestly, it would be nice to simply make this the last thing that runs in the `make docker-image-unit-tests` target. This would keep the gate test environment in line with the developer\u0027s environment, while also removing the need for the additional tasks","commit_id":"93a53fe83ab900c59b9ce2dffe9ae222cac10193"}],"playbooks/airship-airshipctl-lint-unit.yaml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4a1ad1f5ada8d2d46a0c05343e2d1bc458921d1a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"            chdir: \"{{ zuul.project.src_dir }}\""},{"line_number":27,"context_line":"            target: docker-image-unit-tests"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    - name: Check for Unusued Unit Tests"},{"line_number":30,"context_line":"      block:"},{"line_number":31,"context_line":"        - name: \"make update-golden\""},{"line_number":32,"context_line":"          make:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1fa4df85_45c31c5e","line":29,"range":{"start_line":29,"start_character":22,"end_line":29,"end_character":40},"updated":"2020-03-03 18:51:36.000000000","message":"nit: It\u0027s not really unused unit tests\u003d; it\u0027s unused test data.","commit_id":"93a53fe83ab900c59b9ce2dffe9ae222cac10193"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"39495d34483b142362362c12b1fdc324549be7db","unresolved":false,"context_lines":[{"line_number":26,"context_line":"            chdir: \"{{ zuul.project.src_dir }}\""},{"line_number":27,"context_line":"            target: docker-image-unit-tests"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    - name: Check for Unusued Unit Tests"},{"line_number":30,"context_line":"      block:"},{"line_number":31,"context_line":"        - name: \"make update-golden\""},{"line_number":32,"context_line":"          make:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1fa4df85_8c004703","line":29,"range":{"start_line":29,"start_character":22,"end_line":29,"end_character":40},"in_reply_to":"1fa4df85_45c31c5e","updated":"2020-03-04 20:16:21.000000000","message":"Removed additional tasks, updated remaining task name in most recent patch to be more descriptive","commit_id":"93a53fe83ab900c59b9ce2dffe9ae222cac10193"}]}