)]}'
{"docs/source/developers.md":[{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"a9bfbb787a7c37fb7251d3a9f164ee70959a2526","unresolved":false,"context_lines":[{"line_number":90,"context_line":"We also typically follow the conventions of `golangci-lint`."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"An important convention in Go is the concept of brief but readable declarations."},{"line_number":93,"context_line":"Packages, functions and variables can be declared with short names such as `Reader`"},{"line_number":94,"context_line":"or `kubeConfig`.  If a variable is to be used multiple times - such as in the case of"},{"line_number":95,"context_line":"a method parameter it is helpful to make it clear what that variable is, for example"},{"line_number":96,"context_line":"`o` is not a good variable, but `kubeOptions` is.  When in doubt, using descriptive"}],"source_content_type":"text/x-markdown","patch_set":2,"id":"1fa4df85_0b8c2a7d","line":93,"range":{"start_line":93,"start_character":19,"end_line":93,"end_character":20},"updated":"2020-03-05 20:50:34.000000000","message":"nit: oxford comma","commit_id":"3245c7d3eccdd8cf03d0531bedc42869618f4980"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"f62c3888d4f4af9acdad135c456a40330b05bad9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"We also typically follow the conventions of `golangci-lint`."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"An important convention in Go is the concept of brief but readable declarations."},{"line_number":93,"context_line":"Packages, functions and variables can be declared with short names such as `Reader`"},{"line_number":94,"context_line":"or `kubeConfig`.  If a variable is to be used multiple times - such as in the case of"},{"line_number":95,"context_line":"a method parameter it is helpful to make it clear what that variable is, for example"},{"line_number":96,"context_line":"`o` is not a good variable, but `kubeOptions` is.  When in doubt, using descriptive"}],"source_content_type":"text/x-markdown","patch_set":2,"id":"1fa4df85_352b7883","line":93,"range":{"start_line":93,"start_character":19,"end_line":93,"end_character":20},"in_reply_to":"1fa4df85_0b8c2a7d","updated":"2020-03-06 13:09:26.000000000","message":"Done","commit_id":"3245c7d3eccdd8cf03d0531bedc42869618f4980"},{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"a9bfbb787a7c37fb7251d3a9f164ee70959a2526","unresolved":false,"context_lines":[{"line_number":92,"context_line":"An important convention in Go is the concept of brief but readable declarations."},{"line_number":93,"context_line":"Packages, functions and variables can be declared with short names such as `Reader`"},{"line_number":94,"context_line":"or `kubeConfig`.  If a variable is to be used multiple times - such as in the case of"},{"line_number":95,"context_line":"a method parameter it is helpful to make it clear what that variable is, for example"},{"line_number":96,"context_line":"`o` is not a good variable, but `kubeOptions` is.  When in doubt, using descriptive"},{"line_number":97,"context_line":"comments around these variables is helpful to maintainers and future developers of"},{"line_number":98,"context_line":"airshipctl."}],"source_content_type":"text/x-markdown","patch_set":2,"id":"1fa4df85_cbeff21b","line":95,"range":{"start_line":95,"start_character":83,"end_line":95,"end_character":84},"updated":"2020-03-05 20:50:34.000000000","message":"nit: add another comma here","commit_id":"3245c7d3eccdd8cf03d0531bedc42869618f4980"},{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"a9bfbb787a7c37fb7251d3a9f164ee70959a2526","unresolved":false,"context_lines":[{"line_number":92,"context_line":"An important convention in Go is the concept of brief but readable declarations."},{"line_number":93,"context_line":"Packages, functions and variables can be declared with short names such as `Reader`"},{"line_number":94,"context_line":"or `kubeConfig`.  If a variable is to be used multiple times - such as in the case of"},{"line_number":95,"context_line":"a method parameter it is helpful to make it clear what that variable is, for example"},{"line_number":96,"context_line":"`o` is not a good variable, but `kubeOptions` is.  When in doubt, using descriptive"},{"line_number":97,"context_line":"comments around these variables is helpful to maintainers and future developers of"},{"line_number":98,"context_line":"airshipctl."}],"source_content_type":"text/x-markdown","patch_set":2,"id":"1fa4df85_8b801a48","line":95,"range":{"start_line":95,"start_character":71,"end_line":95,"end_character":72},"updated":"2020-03-05 20:50:34.000000000","message":"nit: break for a new sentence here?","commit_id":"3245c7d3eccdd8cf03d0531bedc42869618f4980"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"f62c3888d4f4af9acdad135c456a40330b05bad9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"An important convention in Go is the concept of brief but readable declarations."},{"line_number":93,"context_line":"Packages, functions and variables can be declared with short names such as `Reader`"},{"line_number":94,"context_line":"or `kubeConfig`.  If a variable is to be used multiple times - such as in the case of"},{"line_number":95,"context_line":"a method parameter it is helpful to make it clear what that variable is, for example"},{"line_number":96,"context_line":"`o` is not a good variable, but `kubeOptions` is.  When in doubt, using descriptive"},{"line_number":97,"context_line":"comments around these variables is helpful to maintainers and future developers of"},{"line_number":98,"context_line":"airshipctl."}],"source_content_type":"text/x-markdown","patch_set":2,"id":"1fa4df85_552e3492","line":95,"range":{"start_line":95,"start_character":71,"end_line":95,"end_character":72},"in_reply_to":"1fa4df85_8b801a48","updated":"2020-03-06 13:09:26.000000000","message":"Done","commit_id":"3245c7d3eccdd8cf03d0531bedc42869618f4980"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"f62c3888d4f4af9acdad135c456a40330b05bad9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"An important convention in Go is the concept of brief but readable declarations."},{"line_number":93,"context_line":"Packages, functions and variables can be declared with short names such as `Reader`"},{"line_number":94,"context_line":"or `kubeConfig`.  If a variable is to be used multiple times - such as in the case of"},{"line_number":95,"context_line":"a method parameter it is helpful to make it clear what that variable is, for example"},{"line_number":96,"context_line":"`o` is not a good variable, but `kubeOptions` is.  When in doubt, using descriptive"},{"line_number":97,"context_line":"comments around these variables is helpful to maintainers and future developers of"},{"line_number":98,"context_line":"airshipctl."}],"source_content_type":"text/x-markdown","patch_set":2,"id":"1fa4df85_f520809d","line":95,"range":{"start_line":95,"start_character":83,"end_line":95,"end_character":84},"in_reply_to":"1fa4df85_cbeff21b","updated":"2020-03-06 13:09:26.000000000","message":"Done","commit_id":"3245c7d3eccdd8cf03d0531bedc42869618f4980"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"bd882191bd7f769e0a838ba097214dd381e38fad","unresolved":false,"context_lines":[{"line_number":93,"context_line":"Packages, functions and variables can be declared with short names such as `Reader`"},{"line_number":94,"context_line":"or `kubeConfig`.  If a variable is to be used multiple times - such as in the case of"},{"line_number":95,"context_line":"a method parameter it is helpful to make it clear what that variable is, for example"},{"line_number":96,"context_line":"`o` is not a good variable, but `kubeOptions` is.  When in doubt, using descriptive"},{"line_number":97,"context_line":"comments around these variables is helpful to maintainers and future developers of"},{"line_number":98,"context_line":"airshipctl."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":2,"id":"1fa4df85_06998177","line":96,"range":{"start_line":96,"start_character":50,"end_line":96,"end_character":51},"updated":"2020-03-05 22:18:00.000000000","message":"extra space","commit_id":"3245c7d3eccdd8cf03d0531bedc42869618f4980"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"f62c3888d4f4af9acdad135c456a40330b05bad9","unresolved":false,"context_lines":[{"line_number":93,"context_line":"Packages, functions and variables can be declared with short names such as `Reader`"},{"line_number":94,"context_line":"or `kubeConfig`.  If a variable is to be used multiple times - such as in the case of"},{"line_number":95,"context_line":"a method parameter it is helpful to make it clear what that variable is, for example"},{"line_number":96,"context_line":"`o` is not a good variable, but `kubeOptions` is.  When in doubt, using descriptive"},{"line_number":97,"context_line":"comments around these variables is helpful to maintainers and future developers of"},{"line_number":98,"context_line":"airshipctl."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":2,"id":"1fa4df85_15243cae","line":96,"range":{"start_line":96,"start_character":50,"end_line":96,"end_character":51},"in_reply_to":"1fa4df85_06998177","updated":"2020-03-06 13:09:26.000000000","message":"Done","commit_id":"3245c7d3eccdd8cf03d0531bedc42869618f4980"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"7dabb1cb7d86b5384977c3e0371ba5a7dba524ce","unresolved":false,"context_lines":[{"line_number":93,"context_line":"Packages, functions, and variables can be declared with short names such as `Reader`"},{"line_number":94,"context_line":"or `kubeConfig`.  If a variable is to be used multiple times - such as in the case of"},{"line_number":95,"context_line":"a method parameter it is helpful to make it clear what that variable is. For example,"},{"line_number":96,"context_line":"`o` is not a good variable, but `kubeOptions` is. When in doubt, using descriptive"},{"line_number":97,"context_line":"comments around these variables is helpful to maintainers and future developers of"},{"line_number":98,"context_line":"airshipctl."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":7,"id":"1fa4df85_118bc6c2","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":48},"updated":"2020-03-10 13:13:17.000000000","message":"This does not apply to receivers and they are technically variables (of a special king though). https://github.com/golang/go/wiki/CodeReviewComments#receiver-names.\n\nThat being said not 100% sure we should explicitly state it here...","commit_id":"28cc95e2a9a23b55cf3988f23a33d5eea81fe28e"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"336e9672f2ec6edf0de493d34a5d597b23bc9fea","unresolved":false,"context_lines":[{"line_number":93,"context_line":"Packages, functions, and variables can be declared with short names such as `Reader`"},{"line_number":94,"context_line":"or `kubeConfig`.  If a variable is to be used multiple times - such as in the case of"},{"line_number":95,"context_line":"a method parameter it is helpful to make it clear what that variable is. For example,"},{"line_number":96,"context_line":"`o` is not a good variable, but `kubeOptions` is. When in doubt, using descriptive"},{"line_number":97,"context_line":"comments around these variables is helpful to maintainers and future developers of"},{"line_number":98,"context_line":"airshipctl."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":7,"id":"1fa4df85_d2ac3af0","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":48},"in_reply_to":"1fa4df85_118bc6c2","updated":"2020-03-11 12:48:30.000000000","message":"and more over it\u0027s contradicts a bit with https://github.com/golang/go/wiki/CodeReviewComments#variable-names","commit_id":"28cc95e2a9a23b55cf3988f23a33d5eea81fe28e"},{"author":{"_account_id":25731,"name":"Stacey Fletcher","email":"staceylynnfletcher@gmail.com","username":"StaceyFletcher"},"change_message_id":"5e747656d12db70de9d44c5e115b6fd72ebdc83f","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"We also typically follow the conventions of `golangci-lint`."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"An important convention in Go is the concept of brief but readable declarations."},{"line_number":93,"context_line":"Packages, functions, and variables can be declared with short names such as `Reader`"},{"line_number":94,"context_line":"or `kubeConfig`.  If a variable is to be used multiple times - such as in the case of"},{"line_number":95,"context_line":"a method parameter it is helpful to make it clear what that variable is. For example,"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"1fa4df85_05c7e947","line":92,"updated":"2020-03-11 16:24:56.000000000","message":"Agree that this is redundant and you already point to the CodeReviewComments.  If you are following those Go Conventions I wouldn\u0027t try to rewrite the instructions that already exist there.","commit_id":"5ecd4a8383340b14c30c042c0bafaae9338c0d2f"}]}