)]}'
{"pkg/document/selectors.go":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"0c45256da196bcffe819f5409d2d569d177ec7b6","unresolved":false,"context_lines":[{"line_number":96,"context_line":"\treturn selector, nil"},{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"// InintInfraSelector returns selector of all initinfra documents"},{"line_number":100,"context_line":"// currently it is an empty selector"},{"line_number":101,"context_line":"func InintInfraSelector() Selector {"},{"line_number":102,"context_line":"\treturn NewSelector()"},{"line_number":103,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":4,"id":"1fa4df85_35178ff0","line":103,"range":{"start_line":99,"start_character":0,"end_line":103,"end_character":1},"updated":"2020-03-13 13:28:00.000000000","message":"looks like this one returns all documents selector.","commit_id":"dfc6978e382957ad80461f297c5969d88e163bfc"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"8df5600b01da95ae88dfc26a6c42a6d89f8a3b38","unresolved":false,"context_lines":[{"line_number":96,"context_line":"\treturn selector, nil"},{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"// InintInfraSelector returns selector of all initinfra documents"},{"line_number":100,"context_line":"// currently it is an empty selector"},{"line_number":101,"context_line":"func InintInfraSelector() Selector {"},{"line_number":102,"context_line":"\treturn NewSelector()"},{"line_number":103,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":4,"id":"1fa4df85_dcf423d2","line":103,"range":{"start_line":99,"start_character":0,"end_line":103,"end_character":1},"in_reply_to":"1fa4df85_35178ff0","updated":"2020-03-13 15:18:32.000000000","message":"yes, currently it returns all document selector, but i would like to expand this later, when we have deploy-to-k8s label introduced.","commit_id":"dfc6978e382957ad80461f297c5969d88e163bfc"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"2bc7282f07f61670f0caf4b07e5f19fa688b1128","unresolved":false,"context_lines":[{"line_number":75,"context_line":"}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"// EphemeralNetworkDataSelector returns selector to get secret with network data"},{"line_number":78,"context_line":"func EphemeralNetworkDataSelector(bmhDoc Document) (Selector, error) {"},{"line_number":79,"context_line":"\tselector :\u003d NewSelector()"},{"line_number":80,"context_line":"\t// extract the network data document pointer from the bmh document"},{"line_number":81,"context_line":"\tnetConfDocName, err :\u003d bmhDoc.GetString(\"spec.networkData.name\")"}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_7320baf8","line":78,"range":{"start_line":78,"start_character":34,"end_line":78,"end_character":40},"updated":"2020-03-13 20:11:06.000000000","message":"Could you provide further documentation for this parameter?","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"bca65b86fd7db65db4120d7ed55e2969ebe4b56d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"// EphemeralNetworkDataSelector returns selector to get secret with network data"},{"line_number":78,"context_line":"func EphemeralNetworkDataSelector(bmhDoc Document) (Selector, error) {"},{"line_number":79,"context_line":"\tselector :\u003d NewSelector()"},{"line_number":80,"context_line":"\t// extract the network data document pointer from the bmh document"},{"line_number":81,"context_line":"\tnetConfDocName, err :\u003d bmhDoc.GetString(\"spec.networkData.name\")"}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_0e5efde5","line":78,"range":{"start_line":78,"start_character":34,"end_line":78,"end_character":40},"in_reply_to":"1fa4df85_7320baf8","updated":"2020-03-13 21:31:35.000000000","message":"Done","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"2bc7282f07f61670f0caf4b07e5f19fa688b1128","unresolved":false,"context_lines":[{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"// InintInfraSelector returns selector of all initinfra documents"},{"line_number":100,"context_line":"// currently it is an empty selector"},{"line_number":101,"context_line":"func InintInfraSelector() Selector {"},{"line_number":102,"context_line":"\treturn NewSelector()"},{"line_number":103,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_931d36bf","line":100,"range":{"start_line":100,"start_character":3,"end_line":100,"end_character":36},"updated":"2020-03-13 20:11:06.000000000","message":"Perhaps this could use a TODO so that it\u0027s easy to find and implement later","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"bca65b86fd7db65db4120d7ed55e2969ebe4b56d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"// InintInfraSelector returns selector of all initinfra documents"},{"line_number":100,"context_line":"// currently it is an empty selector"},{"line_number":101,"context_line":"func InintInfraSelector() Selector {"},{"line_number":102,"context_line":"\treturn NewSelector()"},{"line_number":103,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_6e6c519c","line":100,"range":{"start_line":100,"start_character":3,"end_line":100,"end_character":36},"in_reply_to":"1fa4df85_931d36bf","updated":"2020-03-13 21:31:35.000000000","message":"Done","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"5eb9fc6d497949972b8d58eee8e054bf9d1f666f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"\treturn s"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"// EphemeralCloudDataSelector returns selector to get BaremetalHost for ephemeral node"},{"line_number":68,"context_line":"func EphemeralCloudDataSelector() Selector {"},{"line_number":69,"context_line":"\treturn NewSelector().ByKind(SecretKind).ByLabel(EphemeralUserDataSelector)"},{"line_number":70,"context_line":"}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"// EphemeralBMHSelector returns selector to get BaremetalHost for ephemeral node"},{"line_number":73,"context_line":"func EphemeralBMHSelector() Selector {"},{"line_number":74,"context_line":"\treturn NewSelector().ByKind(BareMetalHostKind).ByLabel(EphemeralHostSelector)"},{"line_number":75,"context_line":"}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"// EphemeralNetworkDataSelector returns selector to get secret with network data"},{"line_number":78,"context_line":"func EphemeralNetworkDataSelector(bmhDoc Document) (Selector, error) {"},{"line_number":79,"context_line":"\tselector :\u003d NewSelector()"},{"line_number":80,"context_line":"\t// extract the network data document pointer from the bmh document"},{"line_number":81,"context_line":"\tnetConfDocName, err :\u003d bmhDoc.GetString(\"spec.networkData.name\")"},{"line_number":82,"context_line":"\tif err !\u003d nil {"},{"line_number":83,"context_line":"\t\treturn selector, err"},{"line_number":84,"context_line":"\t}"},{"line_number":85,"context_line":"\tnetConfDocNamespace, err :\u003d bmhDoc.GetString(\"spec.networkData.namespace\")"},{"line_number":86,"context_line":"\tif err !\u003d nil {"},{"line_number":87,"context_line":"\t\treturn selector, err"},{"line_number":88,"context_line":"\t}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"\t// try and find these documents in our bundle"},{"line_number":91,"context_line":"\tselector \u003d selector."},{"line_number":92,"context_line":"\t\tByKind(SecretKind)."},{"line_number":93,"context_line":"\t\tByNamespace(netConfDocNamespace)."},{"line_number":94,"context_line":"\t\tByName(netConfDocName)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"\treturn selector, nil"},{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"// InintInfraSelector returns selector of all initinfra documents"},{"line_number":100,"context_line":"// currently it is an empty selector"},{"line_number":101,"context_line":"func InintInfraSelector() Selector {"},{"line_number":102,"context_line":"\treturn NewSelector()"},{"line_number":103,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_8e318def","line":103,"range":{"start_line":67,"start_character":0,"end_line":103,"end_character":1},"updated":"2020-03-13 20:15:07.000000000","message":"Since these are effectively constructors, could we prefix their names with \"New\" to match our other constructors?","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"bca65b86fd7db65db4120d7ed55e2969ebe4b56d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"\treturn s"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"// EphemeralCloudDataSelector returns selector to get BaremetalHost for ephemeral node"},{"line_number":68,"context_line":"func EphemeralCloudDataSelector() Selector {"},{"line_number":69,"context_line":"\treturn NewSelector().ByKind(SecretKind).ByLabel(EphemeralUserDataSelector)"},{"line_number":70,"context_line":"}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"// EphemeralBMHSelector returns selector to get BaremetalHost for ephemeral node"},{"line_number":73,"context_line":"func EphemeralBMHSelector() Selector {"},{"line_number":74,"context_line":"\treturn NewSelector().ByKind(BareMetalHostKind).ByLabel(EphemeralHostSelector)"},{"line_number":75,"context_line":"}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"// EphemeralNetworkDataSelector returns selector to get secret with network data"},{"line_number":78,"context_line":"func EphemeralNetworkDataSelector(bmhDoc Document) (Selector, error) {"},{"line_number":79,"context_line":"\tselector :\u003d NewSelector()"},{"line_number":80,"context_line":"\t// extract the network data document pointer from the bmh document"},{"line_number":81,"context_line":"\tnetConfDocName, err :\u003d bmhDoc.GetString(\"spec.networkData.name\")"},{"line_number":82,"context_line":"\tif err !\u003d nil {"},{"line_number":83,"context_line":"\t\treturn selector, err"},{"line_number":84,"context_line":"\t}"},{"line_number":85,"context_line":"\tnetConfDocNamespace, err :\u003d bmhDoc.GetString(\"spec.networkData.namespace\")"},{"line_number":86,"context_line":"\tif err !\u003d nil {"},{"line_number":87,"context_line":"\t\treturn selector, err"},{"line_number":88,"context_line":"\t}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"\t// try and find these documents in our bundle"},{"line_number":91,"context_line":"\tselector \u003d selector."},{"line_number":92,"context_line":"\t\tByKind(SecretKind)."},{"line_number":93,"context_line":"\t\tByNamespace(netConfDocNamespace)."},{"line_number":94,"context_line":"\t\tByName(netConfDocName)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"\treturn selector, nil"},{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"// InintInfraSelector returns selector of all initinfra documents"},{"line_number":100,"context_line":"// currently it is an empty selector"},{"line_number":101,"context_line":"func InintInfraSelector() Selector {"},{"line_number":102,"context_line":"\treturn NewSelector()"},{"line_number":103,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_8e698d8c","line":103,"range":{"start_line":67,"start_character":0,"end_line":103,"end_character":1},"in_reply_to":"1fa4df85_8e318def","updated":"2020-03-13 21:31:35.000000000","message":"Done","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"}],"pkg/document/selectors_test.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"2bc7282f07f61670f0caf4b07e5f19fa688b1128","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\t\tassert.Len(t, docs, 1)"},{"line_number":26,"context_line":"\t\tbmhDoc :\u003d docs[0]"},{"line_number":27,"context_line":"\t\tselector, err :\u003d document.EphemeralNetworkDataSelector(bmhDoc)"},{"line_number":28,"context_line":"\t\tassert.NoError(t, err)"},{"line_number":29,"context_line":"\t\tassert.NotNil(t, selector)"},{"line_number":30,"context_line":"\t})"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_13ee2688","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":8},"updated":"2020-03-13 20:11:06.000000000","message":"nit: require","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"bca65b86fd7db65db4120d7ed55e2969ebe4b56d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\t\tassert.Len(t, docs, 1)"},{"line_number":26,"context_line":"\t\tbmhDoc :\u003d docs[0]"},{"line_number":27,"context_line":"\t\tselector, err :\u003d document.EphemeralNetworkDataSelector(bmhDoc)"},{"line_number":28,"context_line":"\t\tassert.NoError(t, err)"},{"line_number":29,"context_line":"\t\tassert.NotNil(t, selector)"},{"line_number":30,"context_line":"\t})"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_c23c39c1","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":8},"in_reply_to":"1fa4df85_13ee2688","updated":"2020-03-13 21:31:35.000000000","message":"Done","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"2bc7282f07f61670f0caf4b07e5f19fa688b1128","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\t\tbmhDoc :\u003d docs[0]"},{"line_number":27,"context_line":"\t\tselector, err :\u003d document.EphemeralNetworkDataSelector(bmhDoc)"},{"line_number":28,"context_line":"\t\tassert.NoError(t, err)"},{"line_number":29,"context_line":"\t\tassert.NotNil(t, selector)"},{"line_number":30,"context_line":"\t})"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"\tt.Run(\"TestEphemeralCloudDataSelector\", func(t *testing.T) {"}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_938e96ce","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":28},"updated":"2020-03-13 20:11:06.000000000","message":"This could be improved by making assertions about the returned selector, e.g.\n\nassert.Equal(t, \"validName\", selector.Name)","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"bca65b86fd7db65db4120d7ed55e2969ebe4b56d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\t\tbmhDoc :\u003d docs[0]"},{"line_number":27,"context_line":"\t\tselector, err :\u003d document.EphemeralNetworkDataSelector(bmhDoc)"},{"line_number":28,"context_line":"\t\tassert.NoError(t, err)"},{"line_number":29,"context_line":"\t\tassert.NotNil(t, selector)"},{"line_number":30,"context_line":"\t})"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"\tt.Run(\"TestEphemeralCloudDataSelector\", func(t *testing.T) {"}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_6249c55e","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":28},"in_reply_to":"1fa4df85_938e96ce","updated":"2020-03-13 21:31:35.000000000","message":"Done","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"2bc7282f07f61670f0caf4b07e5f19fa688b1128","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\t\tassert.Len(t, docs, 2)"},{"line_number":49,"context_line":"\t\tbmhDoc :\u003d docs[0]"},{"line_number":50,"context_line":"\t\t_, err \u003d document.EphemeralNetworkDataSelector(bmhDoc)"},{"line_number":51,"context_line":"\t\tassert.Error(t, err)"},{"line_number":52,"context_line":"\t})"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"\tt.Run(\"TestEphemeralNetworkDataSelectorErr\", func(t *testing.T) {"}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_73e3daa5","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":22},"updated":"2020-03-13 20:11:06.000000000","message":"This test would benefit from using assert.EqualError","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"bca65b86fd7db65db4120d7ed55e2969ebe4b56d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\t\tassert.Len(t, docs, 2)"},{"line_number":49,"context_line":"\t\tbmhDoc :\u003d docs[0]"},{"line_number":50,"context_line":"\t\t_, err \u003d document.EphemeralNetworkDataSelector(bmhDoc)"},{"line_number":51,"context_line":"\t\tassert.Error(t, err)"},{"line_number":52,"context_line":"\t})"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"\tt.Run(\"TestEphemeralNetworkDataSelectorErr\", func(t *testing.T) {"}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_22750d99","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":22},"in_reply_to":"1fa4df85_73e3daa5","updated":"2020-03-13 21:31:35.000000000","message":"Done","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"c61500e7d951e7f3fb54e991ebccc3a950b07428","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\t\tassert.Len(t, docs, 2)"},{"line_number":49,"context_line":"\t\tbmhDoc :\u003d docs[0]"},{"line_number":50,"context_line":"\t\t_, err \u003d document.EphemeralNetworkDataSelector(bmhDoc)"},{"line_number":51,"context_line":"\t\tassert.Error(t, err)"},{"line_number":52,"context_line":"\t})"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"\tt.Run(\"TestEphemeralNetworkDataSelectorErr\", func(t *testing.T) {"}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_eee8417d","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":22},"in_reply_to":"1fa4df85_73e3daa5","updated":"2020-03-13 21:13:18.000000000","message":"actually, this may be more effort than it\u0027s worth. disregard this","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"bca65b86fd7db65db4120d7ed55e2969ebe4b56d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\t\tassert.Len(t, docs, 2)"},{"line_number":49,"context_line":"\t\tbmhDoc :\u003d docs[0]"},{"line_number":50,"context_line":"\t\t_, err \u003d document.EphemeralNetworkDataSelector(bmhDoc)"},{"line_number":51,"context_line":"\t\tassert.Error(t, err)"},{"line_number":52,"context_line":"\t})"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"\tt.Run(\"TestEphemeralNetworkDataSelectorErr\", func(t *testing.T) {"}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_e26e15c8","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":22},"in_reply_to":"1fa4df85_eee8417d","updated":"2020-03-13 21:31:35.000000000","message":"Done","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"2bc7282f07f61670f0caf4b07e5f19fa688b1128","unresolved":false,"context_lines":[{"line_number":57,"context_line":"\t\tassert.Len(t, docs, 2)"},{"line_number":58,"context_line":"\t\tbmhDoc :\u003d docs[1]"},{"line_number":59,"context_line":"\t\t_, err \u003d document.EphemeralNetworkDataSelector(bmhDoc)"},{"line_number":60,"context_line":"\t\tassert.Error(t, err)"},{"line_number":61,"context_line":"\t})"},{"line_number":62,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_53f49e5b","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":22},"updated":"2020-03-13 20:11:06.000000000","message":"ditto: EqualError","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"bca65b86fd7db65db4120d7ed55e2969ebe4b56d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"\t\tassert.Len(t, docs, 2)"},{"line_number":58,"context_line":"\t\tbmhDoc :\u003d docs[1]"},{"line_number":59,"context_line":"\t\t_, err \u003d document.EphemeralNetworkDataSelector(bmhDoc)"},{"line_number":60,"context_line":"\t\tassert.Error(t, err)"},{"line_number":61,"context_line":"\t})"},{"line_number":62,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_427a8988","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":22},"in_reply_to":"1fa4df85_53f49e5b","updated":"2020-03-13 21:31:35.000000000","message":"Done","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"}],"pkg/document/testdata/selectors/invalid/baremetal.yaml":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"2bc7282f07f61670f0caf4b07e5f19fa688b1128","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1fa4df85_33300208","updated":"2020-03-13 20:11:06.000000000","message":"It would be nice to see comments in this testdata explaining why these objects are invalid.\n\nFor example: https://github.com/airshipit/airshipctl/blob/master/pkg/bootstrap/cloudinit/testdata/ephemeralduplicate.yaml#L1","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"bca65b86fd7db65db4120d7ed55e2969ebe4b56d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1fa4df85_0e183d7f","in_reply_to":"1fa4df85_33300208","updated":"2020-03-13 21:31:35.000000000","message":"Done","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"}],"pkg/document/testdata/selectors/valid/argo.yaml":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"2bc7282f07f61670f0caf4b07e5f19fa688b1128","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# This is an auto-generated file. DO NOT EDIT"},{"line_number":3,"context_line":"apiVersion: apiextensions.k8s.io/v1beta1"},{"line_number":4,"context_line":"kind: CustomResourceDefinition"},{"line_number":5,"context_line":"metadata:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1fa4df85_d372cee3","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":45},"updated":"2020-03-13 20:11:06.000000000","message":"This file isn\u0027t autogenerated - please remove this comment\n\nActually, it may make sense to refer a reader of this file to its origin: https://raw.githubusercontent.com/argoproj/argo/stable/manifests/install.yaml","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"bca65b86fd7db65db4120d7ed55e2969ebe4b56d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# This is an auto-generated file. DO NOT EDIT"},{"line_number":3,"context_line":"apiVersion: apiextensions.k8s.io/v1beta1"},{"line_number":4,"context_line":"kind: CustomResourceDefinition"},{"line_number":5,"context_line":"metadata:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1fa4df85_2e7899f6","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":45},"in_reply_to":"1fa4df85_d372cee3","updated":"2020-03-13 21:31:35.000000000","message":"Done","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"}],"roles/airshipctl-test-configs/templates/airshipconfig.j2":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"8c82e161437257ae0e1bdc9dc18e34c293d0047f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"kind: Config"},{"line_number":14,"context_line":"manifests:"},{"line_number":15,"context_line":"  dummy_manifest:"},{"line_number":16,"context_line":"    primary-repository-name: primary"},{"line_number":17,"context_line":"    repositories:"},{"line_number":18,"context_line":"      primary:"},{"line_number":19,"context_line":"        checkout:"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1fa4df85_2efe5905","line":16,"range":{"start_line":16,"start_character":22,"end_line":16,"end_character":27},"updated":"2020-03-13 20:11:49.000000000","message":"This is unrelated to the rest of the change. Please separate this into its own patchset","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"bca65b86fd7db65db4120d7ed55e2969ebe4b56d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"kind: Config"},{"line_number":14,"context_line":"manifests:"},{"line_number":15,"context_line":"  dummy_manifest:"},{"line_number":16,"context_line":"    primary-repository-name: primary"},{"line_number":17,"context_line":"    repositories:"},{"line_number":18,"context_line":"      primary:"},{"line_number":19,"context_line":"        checkout:"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1fa4df85_6e2d31a7","line":16,"range":{"start_line":16,"start_character":22,"end_line":16,"end_character":27},"in_reply_to":"1fa4df85_2efe5905","updated":"2020-03-13 21:31:35.000000000","message":"Done","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"}],"testutil/testdatafs.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"2bc7282f07f61670f0caf4b07e5f19fa688b1128","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\tfiles, err :\u003d ioutil.ReadDir(fixtureDir)"},{"line_number":26,"context_line":"\trequire.NoErrorf(t, err, \"Failed to read fixture directory %s\", fixtureDir)"},{"line_number":27,"context_line":"\tfor _, file :\u003d range files {"},{"line_number":28,"context_line":"\t\tif file.IsDir() {"},{"line_number":29,"context_line":"\t\t\tcontinue"},{"line_number":30,"context_line":"\t\t}"},{"line_number":31,"context_line":"\t\tfileName :\u003d file.Name()"},{"line_number":32,"context_line":"\t\tfilePath :\u003d filepath.Join(fixtureDir, fileName)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_f3126a62","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":3},"updated":"2020-03-13 20:11:06.000000000","message":"Why is this needed? if anything, it seems as though we should be recursively stepping into subdirectories","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"bca65b86fd7db65db4120d7ed55e2969ebe4b56d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\tfiles, err :\u003d ioutil.ReadDir(fixtureDir)"},{"line_number":26,"context_line":"\trequire.NoErrorf(t, err, \"Failed to read fixture directory %s\", fixtureDir)"},{"line_number":27,"context_line":"\tfor _, file :\u003d range files {"},{"line_number":28,"context_line":"\t\tif file.IsDir() {"},{"line_number":29,"context_line":"\t\t\tcontinue"},{"line_number":30,"context_line":"\t\t}"},{"line_number":31,"context_line":"\t\tfileName :\u003d file.Name()"},{"line_number":32,"context_line":"\t\tfilePath :\u003d filepath.Join(fixtureDir, fileName)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-go","patch_set":5,"id":"1fa4df85_0e3fddd6","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":3},"in_reply_to":"1fa4df85_f3126a62","updated":"2020-03-13 21:31:35.000000000","message":"Done","commit_id":"3f4b1b8345626f061b816033b82974e3f5197b51"}]}