)]}'
{"pkg/util/configreader_test.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"9e799e961f2d7ca2648c3232de5aa6c9e80215e1","unresolved":false,"context_lines":[{"line_number":8,"context_line":"\t\"opendev.org/airship/airshipctl/pkg/util\""},{"line_number":9,"context_line":")"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"func TestReadYAMLFile(t *testing.T) {"},{"line_number":12,"context_line":"\tassert :\u003d assert.New(t)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\tvar actual map[string]interface{}"}],"source_content_type":"text/x-go","patch_set":2,"id":"1fa4df85_7f958a3f","line":11,"updated":"2020-03-19 16:26:15.000000000","message":"It would be nice to see these tests converted to table tests","commit_id":"04283152142da8a607a0536a7dd275a5a0260e57"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"e3ee24b7593ba06f9f633106b4c7fed207e5c84b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"\t\"opendev.org/airship/airshipctl/pkg/util\""},{"line_number":9,"context_line":")"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"func TestReadYAMLFile(t *testing.T) {"},{"line_number":12,"context_line":"\tassert :\u003d assert.New(t)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\tvar actual map[string]interface{}"}],"source_content_type":"text/x-go","patch_set":2,"id":"1fa4df85_506afd80","line":11,"in_reply_to":"1fa4df85_7f958a3f","updated":"2020-03-19 18:44:19.000000000","message":"\u003e It would be nice to see these tests converted to table tests\n\nUpdated to use table test like structure.","commit_id":"04283152142da8a607a0536a7dd275a5a0260e57"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"9e799e961f2d7ca2648c3232de5aa6c9e80215e1","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\tvar actual map[string]interface{}"},{"line_number":15,"context_line":"\terr :\u003d util.ReadYAMLFile(\"testdata/test.yaml\", \u0026actual)"},{"line_number":16,"context_line":"\tassert.NoError(err, \"Error while reading YAML\")"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\tactualString :\u003d actual[\"testString\"]"},{"line_number":19,"context_line":"\texpectedString :\u003d \"test\""}],"source_content_type":"text/x-go","patch_set":2,"id":"1fa4df85_5fea0ed8","line":16,"range":{"start_line":16,"start_character":1,"end_line":16,"end_character":7},"updated":"2020-03-19 16:26:15.000000000","message":"this should be require","commit_id":"04283152142da8a607a0536a7dd275a5a0260e57"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"e3ee24b7593ba06f9f633106b4c7fed207e5c84b","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\tvar actual map[string]interface{}"},{"line_number":15,"context_line":"\terr :\u003d util.ReadYAMLFile(\"testdata/test.yaml\", \u0026actual)"},{"line_number":16,"context_line":"\tassert.NoError(err, \"Error while reading YAML\")"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\tactualString :\u003d actual[\"testString\"]"},{"line_number":19,"context_line":"\texpectedString :\u003d \"test\""}],"source_content_type":"text/x-go","patch_set":2,"id":"1fa4df85_102fa53f","line":16,"range":{"start_line":16,"start_character":1,"end_line":16,"end_character":7},"in_reply_to":"1fa4df85_5fea0ed8","updated":"2020-03-19 18:44:19.000000000","message":"\u003e this should be require\n\nNow that all moved to table tests. used only assert. I thought we are not relying on the output of the ReadYaml anywhere, so it is ok to fail and continue.","commit_id":"04283152142da8a607a0536a7dd275a5a0260e57"}],"pkg/util/writefiles_test.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"9e799e961f2d7ca2648c3232de5aa6c9e80215e1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"\t\"opendev.org/airship/airshipctl/testutil\""},{"line_number":12,"context_line":")"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"func TestWriteFiles(t *testing.T) {"},{"line_number":15,"context_line":"\ttestDir, cleanup :\u003d testutil.TempDir(t, \"test-dir\")"},{"line_number":16,"context_line":"\tdefer cleanup(t)"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-go","patch_set":2,"id":"1fa4df85_9fa08692","line":14,"updated":"2020-03-19 16:26:15.000000000","message":"These tests would also benefit from being separated into table tests","commit_id":"04283152142da8a607a0536a7dd275a5a0260e57"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"e3ee24b7593ba06f9f633106b4c7fed207e5c84b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"\t\"opendev.org/airship/airshipctl/testutil\""},{"line_number":12,"context_line":")"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"func TestWriteFiles(t *testing.T) {"},{"line_number":15,"context_line":"\ttestDir, cleanup :\u003d testutil.TempDir(t, \"test-dir\")"},{"line_number":16,"context_line":"\tdefer cleanup(t)"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-go","patch_set":2,"id":"1fa4df85_50ed1dee","line":14,"in_reply_to":"1fa4df85_9fa08692","updated":"2020-03-19 18:44:19.000000000","message":"\u003e These tests would also benefit from being separated into table\n \u003e tests\n\nI could not get this into table driven approach, as it has different assert functions for each of the test. I did not find a similar verification to group all tests.","commit_id":"04283152142da8a607a0536a7dd275a5a0260e57"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"9e799e961f2d7ca2648c3232de5aa6c9e80215e1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\t_, err \u003d ioutil.ReadFile(testFile1)"},{"line_number":34,"context_line":"\tassert.NoError(t, err)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"\t// test to fail WriteFiles with NonExitent Dir Path"},{"line_number":37,"context_line":"\ttestFile3 :\u003d filepath.Join(\"NonExistentDir\", \"testFile3\")"},{"line_number":38,"context_line":"\tfls[testFile3] \u003d dummyData"},{"line_number":39,"context_line":"\terr \u003d util.WriteFiles(fls, 0600)"}],"source_content_type":"text/x-go","patch_set":2,"id":"1fa4df85_3f74f235","line":36,"range":{"start_line":36,"start_character":33,"end_line":36,"end_character":43},"updated":"2020-03-19 16:26:15.000000000","message":"NonExistent","commit_id":"04283152142da8a607a0536a7dd275a5a0260e57"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"e3ee24b7593ba06f9f633106b4c7fed207e5c84b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\t_, err \u003d ioutil.ReadFile(testFile1)"},{"line_number":34,"context_line":"\tassert.NoError(t, err)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"\t// test to fail WriteFiles with NonExitent Dir Path"},{"line_number":37,"context_line":"\ttestFile3 :\u003d filepath.Join(\"NonExistentDir\", \"testFile3\")"},{"line_number":38,"context_line":"\tfls[testFile3] \u003d dummyData"},{"line_number":39,"context_line":"\terr \u003d util.WriteFiles(fls, 0600)"}],"source_content_type":"text/x-go","patch_set":2,"id":"1fa4df85_d024ad62","line":36,"range":{"start_line":36,"start_character":33,"end_line":36,"end_character":43},"in_reply_to":"1fa4df85_3f74f235","updated":"2020-03-19 18:44:19.000000000","message":"\u003e NonExistent\n\nCorrected","commit_id":"04283152142da8a607a0536a7dd275a5a0260e57"}]}