)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"a88d8b0d9026e305116be0de4cf4a2a949572505","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change introduces the subcommand `status` to the `airshipctl"},{"line_number":10,"context_line":"cluster` command. The `status` command will iterate over all defined"},{"line_number":11,"context_line":"custom resources in the target path, check their status against the"},{"line_number":12,"context_line":"resources currently in the cluster, and then report results on stdout."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ieaff6b91fd9055f995c5ba8ce79959356a2a8a02"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"df33271e_135daee8","line":11,"range":{"start_line":11,"start_character":17,"end_line":11,"end_character":35},"updated":"2020-03-30 20:35:14.000000000","message":"Have we ruled out iterating over all CRDs actually defined in the kubernetes cluster instead? I wonder if that\u0027s a better source of truth, as various CRDs may have been installed via different kustomize targets. Of course one could create a kustomize target encompassing all others, but that may be error prone relative to just using what\u0027s actually been installed in the cluster.","commit_id":"ed14e9c2ec780cfbc8aa148ef19c8908b4edcd01"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"768f80cc5115937c75bb18bd20c04b6102292bb6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change introduces the subcommand `status` to the `airshipctl"},{"line_number":10,"context_line":"cluster` command. The `status` command will iterate over all defined"},{"line_number":11,"context_line":"custom resources in the target path, check their status against the"},{"line_number":12,"context_line":"resources currently in the cluster, and then report results on stdout."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ieaff6b91fd9055f995c5ba8ce79959356a2a8a02"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"df33271e_db1fc158","line":11,"range":{"start_line":11,"start_character":17,"end_line":11,"end_character":35},"in_reply_to":"df33271e_135daee8","updated":"2020-03-31 15:23:57.000000000","message":"This is a good idea (and would probably result in a cleaner implementation), but I don\u0027t think it belongs in this change since it\u0027s only targeted at the CLI command.\n\nI\u0027ll take a look at a follow-up change which takes this approach.","commit_id":"ed14e9c2ec780cfbc8aa148ef19c8908b4edcd01"}],"cmd/cluster/status.go":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"5933a852c350fd5c083cc12400f50c490eaff9b2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\t\t\t\treturn err"},{"line_number":30,"context_line":"\t\t\t}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"\t\t\tdocBundle, err :\u003d document.NewBundle(document.NewDocumentFs(), manifest.TargetPath, \"\")"},{"line_number":33,"context_line":"\t\t\tif err !\u003d nil {"},{"line_number":34,"context_line":"\t\t\t\treturn err"},{"line_number":35,"context_line":"\t\t\t}"}],"source_content_type":"text/x-go","patch_set":8,"id":"df33271e_459dac08","line":32,"range":{"start_line":32,"start_character":30,"end_line":32,"end_character":39},"updated":"2020-03-30 14:15:24.000000000","message":"I guess documentNewBundleByPath is better in this case","commit_id":"ed14e9c2ec780cfbc8aa148ef19c8908b4edcd01"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"353ea0b74f18b20d83dd7bb198a12b1eba8eb759","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\t\t\t\treturn err"},{"line_number":30,"context_line":"\t\t\t}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"\t\t\tdocBundle, err :\u003d document.NewBundle(document.NewDocumentFs(), manifest.TargetPath, \"\")"},{"line_number":33,"context_line":"\t\t\tif err !\u003d nil {"},{"line_number":34,"context_line":"\t\t\t\treturn err"},{"line_number":35,"context_line":"\t\t\t}"}],"source_content_type":"text/x-go","patch_set":8,"id":"df33271e_79cdf964","line":32,"range":{"start_line":32,"start_character":30,"end_line":32,"end_character":39},"in_reply_to":"df33271e_459dac08","updated":"2020-03-30 16:41:54.000000000","message":"Done","commit_id":"ed14e9c2ec780cfbc8aa148ef19c8908b4edcd01"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"b0717ff38192ea4cf4c4027856932d3909c070c3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"func NewClusterStatusCommand(rootSettings *environment.AirshipCTLSettings, factory client.Factory) *cobra.Command {"},{"line_number":18,"context_line":"\tcmd :\u003d \u0026cobra.Command{"},{"line_number":19,"context_line":"\t\tUse:   \"status\","},{"line_number":20,"context_line":"\t\tShort: \"Get information about a cluster\u0027s status\","},{"line_number":21,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":22,"context_line":"\t\t\tconf :\u003d rootSettings.Config()"},{"line_number":23,"context_line":"\t\t\tif err :\u003d conf.EnsureComplete(); err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":9,"id":"df33271e_de1a266d","line":20,"range":{"start_line":20,"start_character":10,"end_line":20,"end_character":50},"updated":"2020-03-30 19:53:57.000000000","message":"It\u0027s a minor detail, but I don\u0027t think this command is at the point where it can claim to produce a holistic status of a Kubernetes cluster.\n\nI think something like \"Retrieve statuses of deployed cluster components\" is more truthful.","commit_id":"cc38d33694256517ff87c41d6878078fc87bff5b"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"768f80cc5115937c75bb18bd20c04b6102292bb6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"func NewClusterStatusCommand(rootSettings *environment.AirshipCTLSettings, factory client.Factory) *cobra.Command {"},{"line_number":18,"context_line":"\tcmd :\u003d \u0026cobra.Command{"},{"line_number":19,"context_line":"\t\tUse:   \"status\","},{"line_number":20,"context_line":"\t\tShort: \"Get information about a cluster\u0027s status\","},{"line_number":21,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":22,"context_line":"\t\t\tconf :\u003d rootSettings.Config()"},{"line_number":23,"context_line":"\t\t\tif err :\u003d conf.EnsureComplete(); err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":9,"id":"df33271e_9b3899a0","line":20,"range":{"start_line":20,"start_character":10,"end_line":20,"end_character":50},"in_reply_to":"df33271e_de1a266d","updated":"2020-03-31 15:23:57.000000000","message":"Done","commit_id":"cc38d33694256517ff87c41d6878078fc87bff5b"}]}