)]}'
{"pkg/remote/redfish/redfish.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"f30fb889845960a2209a5ee4cadfc33b1f459f51","unresolved":false,"context_lines":[{"line_number":120,"context_line":"\t\t\tInsecureSkipVerify: true, //nolint:gosec"},{"line_number":121,"context_line":"\t\t}"},{"line_number":122,"context_line":"\t}"},{"line_number":123,"context_line":"\tif !useproxy {"},{"line_number":124,"context_line":"\t\t// this will ignore any environmental proxy settings"},{"line_number":125,"context_line":"\t\ttransport.Proxy \u003d nil"},{"line_number":126,"context_line":"\t}"},{"line_number":127,"context_line":"\tcfg.HTTPClient \u003d \u0026http.Client{"},{"line_number":128,"context_line":"\t\tTransport: \u0026transport,"},{"line_number":129,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"df33271e_9e13b55c","line":126,"range":{"start_line":123,"start_character":0,"end_line":126,"end_character":2},"updated":"2020-03-26 22:17:35.000000000","message":"This will have no effect, regardless of the value of `useproxy`, since transport.Proxy will always be nil at this point.","commit_id":"bb2b4e5a6f116766411cbc03ff797df29c85ac42"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"fcdb0aae978e29589c9c1ca2b6d4243dd7c943c6","unresolved":false,"context_lines":[{"line_number":120,"context_line":"\t\t\tInsecureSkipVerify: true, //nolint:gosec"},{"line_number":121,"context_line":"\t\t}"},{"line_number":122,"context_line":"\t}"},{"line_number":123,"context_line":"\tif !useproxy {"},{"line_number":124,"context_line":"\t\t// this will ignore any environmental proxy settings"},{"line_number":125,"context_line":"\t\ttransport.Proxy \u003d nil"},{"line_number":126,"context_line":"\t}"},{"line_number":127,"context_line":"\tcfg.HTTPClient \u003d \u0026http.Client{"},{"line_number":128,"context_line":"\t\tTransport: \u0026transport,"},{"line_number":129,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"df33271e_e12b3d7f","line":126,"range":{"start_line":123,"start_character":0,"end_line":126,"end_character":2},"in_reply_to":"df33271e_3e5d447a","updated":"2020-03-27 08:56:49.000000000","message":"We also can invert logic here and use env variables\n\n\nif useproxy {\n  transport.Proxy \u003d http.ProxyFromEnvironment\n}","commit_id":"bb2b4e5a6f116766411cbc03ff797df29c85ac42"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"d56a28e55706acedc329d39ad5c4144a732360fc","unresolved":false,"context_lines":[{"line_number":120,"context_line":"\t\t\tInsecureSkipVerify: true, //nolint:gosec"},{"line_number":121,"context_line":"\t\t}"},{"line_number":122,"context_line":"\t}"},{"line_number":123,"context_line":"\tif !useproxy {"},{"line_number":124,"context_line":"\t\t// this will ignore any environmental proxy settings"},{"line_number":125,"context_line":"\t\ttransport.Proxy \u003d nil"},{"line_number":126,"context_line":"\t}"},{"line_number":127,"context_line":"\tcfg.HTTPClient \u003d \u0026http.Client{"},{"line_number":128,"context_line":"\t\tTransport: \u0026transport,"},{"line_number":129,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"df33271e_fed64127","line":126,"range":{"start_line":123,"start_character":0,"end_line":126,"end_character":2},"in_reply_to":"df33271e_7eaa31d2","updated":"2020-03-26 22:37:54.000000000","message":"Yes, but it will be nil by default. This should demonstrate what I mean:\n\nhttps://play.golang.org/p/Qkoau12K3P6","commit_id":"bb2b4e5a6f116766411cbc03ff797df29c85ac42"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"1fa1d71017f9bbbbc37b72109a83ebd94cf47531","unresolved":false,"context_lines":[{"line_number":120,"context_line":"\t\t\tInsecureSkipVerify: true, //nolint:gosec"},{"line_number":121,"context_line":"\t\t}"},{"line_number":122,"context_line":"\t}"},{"line_number":123,"context_line":"\tif !useproxy {"},{"line_number":124,"context_line":"\t\t// this will ignore any environmental proxy settings"},{"line_number":125,"context_line":"\t\ttransport.Proxy \u003d nil"},{"line_number":126,"context_line":"\t}"},{"line_number":127,"context_line":"\tcfg.HTTPClient \u003d \u0026http.Client{"},{"line_number":128,"context_line":"\t\tTransport: \u0026transport,"},{"line_number":129,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"df33271e_7eaa31d2","line":126,"range":{"start_line":123,"start_character":0,"end_line":126,"end_character":2},"in_reply_to":"df33271e_9e13b55c","updated":"2020-03-26 22:27:05.000000000","message":"My understanding is that unless it is explicitly set to nil, it evaluate the current environment variables to determine if a proxy should be used.  Explicit nil stops this.","commit_id":"bb2b4e5a6f116766411cbc03ff797df29c85ac42"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"3c433b9301bf234b1226b1ba3110ca6431ba404e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"\t\t\tInsecureSkipVerify: true, //nolint:gosec"},{"line_number":121,"context_line":"\t\t}"},{"line_number":122,"context_line":"\t}"},{"line_number":123,"context_line":"\tif !useproxy {"},{"line_number":124,"context_line":"\t\t// this will ignore any environmental proxy settings"},{"line_number":125,"context_line":"\t\ttransport.Proxy \u003d nil"},{"line_number":126,"context_line":"\t}"},{"line_number":127,"context_line":"\tcfg.HTTPClient \u003d \u0026http.Client{"},{"line_number":128,"context_line":"\t\tTransport: \u0026transport,"},{"line_number":129,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"df33271e_3e5d447a","line":126,"range":{"start_line":123,"start_character":0,"end_line":126,"end_character":2},"in_reply_to":"df33271e_fed64127","updated":"2020-03-27 08:41:21.000000000","message":"Agree with Ian. It\u0027s \u0027nil\u0027 by default and remote direct does not respect proxy settings.","commit_id":"bb2b4e5a6f116766411cbc03ff797df29c85ac42"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"773df197d000af07e8f74cf4964ed72745e9c390","unresolved":false,"context_lines":[{"line_number":118,"context_line":"\t// We clone the default transport to ensure when we customize the transport"},{"line_number":119,"context_line":"\t// that we are providing it sane timeouts and other defaults that we would"},{"line_number":120,"context_line":"\t// normally get when not overriding the transport"},{"line_number":121,"context_line":"\tdefaultTransportCopy :\u003d (http.DefaultTransport.(*http.Transport))"},{"line_number":122,"context_line":"\ttransport :\u003d defaultTransportCopy.Clone()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"\tif insecure {"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_0918ff7e","line":121,"range":{"start_line":121,"start_character":25,"end_line":121,"end_character":26},"updated":"2020-03-27 17:09:32.000000000","message":"nit: unnecessary parens","commit_id":"2e7e6709ca74f5af745851ef8cb94641ca0c4e5e"}]}