)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"74cc7878a01130dd7665f947c159719650fe24ec","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] New CLI to get manifest information"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This ps adds get-manifests option for airshipctl config. get-manifests"},{"line_number":10,"context_line":"prints all the manifests in current config file."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7c677ed491a1d456744d27bf105f21e2b3c4e6aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"df33271e_d49a2260","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":7},"updated":"2020-04-08 19:51:50.000000000","message":"nit: this is a commit, not a patchset","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"8c88c84df2a6ae0162ed28bd1062a3bc9d2867bf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] New CLI to get manifest information"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This ps adds get-manifests option for airshipctl config. get-manifests"},{"line_number":10,"context_line":"prints all the manifests in current config file."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7c677ed491a1d456744d27bf105f21e2b3c4e6aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1f493fa4_472094f8","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":7},"in_reply_to":"df33271e_d49a2260","updated":"2020-05-04 14:18:57.000000000","message":"Done","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"c295da265deca58cc992bf6c3552514024179dc0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sreejith Punnapuzha \u003csreejith.punnapuzha@outlook.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-02 11:03:05 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] New CLI option to get/set manifest"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds get-manifests and set-manifests option for airshipctl"},{"line_number":10,"context_line":"config. get-manifests prints all the manifests in current config file."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1f493fa4_3550200b","line":7,"updated":"2020-05-02 16:18:44.000000000","message":"looks like this Ps covers only get manifest. maybe you can remove the set-manifest from commit message","commit_id":"abd9323d73df141f457f6f21e67f3d66c53af04e"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"1ba54753ee37c82e7dd7d2282c3a80b45cfcbce7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sreejith Punnapuzha \u003csreejith.punnapuzha@outlook.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-02 11:03:05 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] New CLI option to get/set manifest"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds get-manifests and set-manifests option for airshipctl"},{"line_number":10,"context_line":"config. get-manifests prints all the manifests in current config file."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1f493fa4_47e374a5","line":7,"in_reply_to":"1f493fa4_3550200b","updated":"2020-05-04 14:19:39.000000000","message":"Done","commit_id":"abd9323d73df141f457f6f21e67f3d66c53af04e"}],"cmd/config/get_manifest.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"74cc7878a01130dd7665f947c159719650fe24ec","unresolved":false,"context_lines":[{"line_number":26,"context_line":"var ("},{"line_number":27,"context_line":"\tgetManifestsLong \u003d `Display a specific manifest information, or all defined manifests if no name is provided`"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"\tgetManifestsExample \u003d `# List all the users airshipctl knows about"},{"line_number":30,"context_line":"airshipctl config get-manifest"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Display a specific user information"}],"source_content_type":"text/x-go","patch_set":8,"id":"df33271e_74a9967a","line":29,"range":{"start_line":29,"start_character":39,"end_line":29,"end_character":44},"updated":"2020-04-08 19:51:50.000000000","message":"manifests","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"8c88c84df2a6ae0162ed28bd1062a3bc9d2867bf","unresolved":false,"context_lines":[{"line_number":26,"context_line":"var ("},{"line_number":27,"context_line":"\tgetManifestsLong \u003d `Display a specific manifest information, or all defined manifests if no name is provided`"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"\tgetManifestsExample \u003d `# List all the users airshipctl knows about"},{"line_number":30,"context_line":"airshipctl config get-manifest"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Display a specific user information"}],"source_content_type":"text/x-go","patch_set":8,"id":"1f493fa4_271d88bd","line":29,"range":{"start_line":29,"start_character":39,"end_line":29,"end_character":44},"in_reply_to":"df33271e_74a9967a","updated":"2020-05-04 14:18:57.000000000","message":"Done","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"74cc7878a01130dd7665f947c159719650fe24ec","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\tgetManifestsLong \u003d `Display a specific manifest information, or all defined manifests if no name is provided`"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"\tgetManifestsExample \u003d `# List all the users airshipctl knows about"},{"line_number":30,"context_line":"airshipctl config get-manifest"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Display a specific user information"},{"line_number":33,"context_line":"airshipctl config get-manifest e2e`"}],"source_content_type":"text/x-go","patch_set":8,"id":"df33271e_940b7a8c","line":30,"range":{"start_line":30,"start_character":22,"end_line":30,"end_character":30},"updated":"2020-04-08 19:51:50.000000000","message":"manifests","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"8c88c84df2a6ae0162ed28bd1062a3bc9d2867bf","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\tgetManifestsLong \u003d `Display a specific manifest information, or all defined manifests if no name is provided`"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"\tgetManifestsExample \u003d `# List all the users airshipctl knows about"},{"line_number":30,"context_line":"airshipctl config get-manifest"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Display a specific user information"},{"line_number":33,"context_line":"airshipctl config get-manifest e2e`"}],"source_content_type":"text/x-go","patch_set":8,"id":"1f493fa4_87773c09","line":30,"range":{"start_line":30,"start_character":22,"end_line":30,"end_character":30},"in_reply_to":"df33271e_940b7a8c","updated":"2020-05-04 14:18:57.000000000","message":"Done","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"74cc7878a01130dd7665f947c159719650fe24ec","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\tgetManifestsExample \u003d `# List all the users airshipctl knows about"},{"line_number":30,"context_line":"airshipctl config get-manifest"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Display a specific user information"},{"line_number":33,"context_line":"airshipctl config get-manifest e2e`"},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-go","patch_set":8,"id":"df33271e_f4ae467f","line":32,"range":{"start_line":32,"start_character":21,"end_line":32,"end_character":37},"updated":"2020-04-08 19:51:50.000000000","message":"manifest","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"8c88c84df2a6ae0162ed28bd1062a3bc9d2867bf","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\tgetManifestsExample \u003d `# List all the users airshipctl knows about"},{"line_number":30,"context_line":"airshipctl config get-manifest"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Display a specific user information"},{"line_number":33,"context_line":"airshipctl config get-manifest e2e`"},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-go","patch_set":8,"id":"1f493fa4_c78144c6","line":32,"range":{"start_line":32,"start_character":21,"end_line":32,"end_character":37},"in_reply_to":"df33271e_f4ae467f","updated":"2020-05-04 14:18:57.000000000","message":"Done","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"74cc7878a01130dd7665f947c159719650fe24ec","unresolved":false,"context_lines":[{"line_number":30,"context_line":"airshipctl config get-manifest"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Display a specific user information"},{"line_number":33,"context_line":"airshipctl config get-manifest e2e`"},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"// NewCmdConfigGetManifest returns a Command instance for \u0027config -Manifests\u0027 sub command"}],"source_content_type":"text/x-go","patch_set":8,"id":"df33271e_f4fc8673","line":33,"range":{"start_line":33,"start_character":22,"end_line":33,"end_character":30},"updated":"2020-04-08 19:51:50.000000000","message":"manifests","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"74cc7878a01130dd7665f947c159719650fe24ec","unresolved":false,"context_lines":[{"line_number":30,"context_line":"airshipctl config get-manifest"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Display a specific user information"},{"line_number":33,"context_line":"airshipctl config get-manifest e2e`"},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"// NewCmdConfigGetManifest returns a Command instance for \u0027config -Manifests\u0027 sub command"}],"source_content_type":"text/x-go","patch_set":8,"id":"df33271e_14c92a58","line":33,"range":{"start_line":33,"start_character":31,"end_line":33,"end_character":34},"updated":"2020-04-08 19:51:50.000000000","message":"this needs to be updated","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"8c88c84df2a6ae0162ed28bd1062a3bc9d2867bf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"airshipctl config get-manifest"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Display a specific user information"},{"line_number":33,"context_line":"airshipctl config get-manifest e2e`"},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"// NewCmdConfigGetManifest returns a Command instance for \u0027config -Manifests\u0027 sub command"}],"source_content_type":"text/x-go","patch_set":8,"id":"1f493fa4_a786b8da","line":33,"range":{"start_line":33,"start_character":31,"end_line":33,"end_character":34},"in_reply_to":"df33271e_14c92a58","updated":"2020-05-04 14:18:57.000000000","message":"Done","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"8c88c84df2a6ae0162ed28bd1062a3bc9d2867bf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"airshipctl config get-manifest"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Display a specific user information"},{"line_number":33,"context_line":"airshipctl config get-manifest e2e`"},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"// NewCmdConfigGetManifest returns a Command instance for \u0027config -Manifests\u0027 sub command"}],"source_content_type":"text/x-go","patch_set":8,"id":"1f493fa4_076b2c1f","line":33,"range":{"start_line":33,"start_character":22,"end_line":33,"end_character":30},"in_reply_to":"df33271e_f4fc8673","updated":"2020-05-04 14:18:57.000000000","message":"Done","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"74cc7878a01130dd7665f947c159719650fe24ec","unresolved":false,"context_lines":[{"line_number":33,"context_line":"airshipctl config get-manifest e2e`"},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"// NewCmdConfigGetManifest returns a Command instance for \u0027config -Manifests\u0027 sub command"},{"line_number":37,"context_line":"func NewCmdConfigGetManifest(rootSettings *environment.AirshipCTLSettings) *cobra.Command {"},{"line_number":38,"context_line":"\to :\u003d \u0026config.ContextOptions{}"},{"line_number":39,"context_line":"\tcmd :\u003d \u0026cobra.Command{"}],"source_content_type":"text/x-go","patch_set":8,"id":"df33271e_54d452e9","line":36,"range":{"start_line":36,"start_character":59,"end_line":36,"end_character":76},"updated":"2020-04-08 19:51:50.000000000","message":"get-manifests","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"8c88c84df2a6ae0162ed28bd1062a3bc9d2867bf","unresolved":false,"context_lines":[{"line_number":33,"context_line":"airshipctl config get-manifest e2e`"},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"// NewCmdConfigGetManifest returns a Command instance for \u0027config -Manifests\u0027 sub command"},{"line_number":37,"context_line":"func NewCmdConfigGetManifest(rootSettings *environment.AirshipCTLSettings) *cobra.Command {"},{"line_number":38,"context_line":"\to :\u003d \u0026config.ContextOptions{}"},{"line_number":39,"context_line":"\tcmd :\u003d \u0026cobra.Command{"}],"source_content_type":"text/x-go","patch_set":8,"id":"1f493fa4_477534fa","line":36,"range":{"start_line":36,"start_character":59,"end_line":36,"end_character":76},"in_reply_to":"df33271e_54d452e9","updated":"2020-05-04 14:18:57.000000000","message":"Done","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"c295da265deca58cc992bf6c3552514024179dc0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":"Copyright 2014 The Kubernetes Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-go","patch_set":12,"id":"1f493fa4_d53e1cb8","line":1,"updated":"2020-05-02 16:18:44.000000000","message":"Please use the latest format of Apache license header.","commit_id":"abd9323d73df141f457f6f21e67f3d66c53af04e"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"1ba54753ee37c82e7dd7d2282c3a80b45cfcbce7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":"Copyright 2014 The Kubernetes Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-go","patch_set":12,"id":"1f493fa4_27e0e896","line":1,"in_reply_to":"1f493fa4_d53e1cb8","updated":"2020-05-04 14:19:39.000000000","message":"Done","commit_id":"abd9323d73df141f457f6f21e67f3d66c53af04e"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"d53a8127d7a0e8160bdb8ff13788295fda2e98c1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"\t\tExample: getManifestsExample,"},{"line_number":44,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":45,"context_line":"\t\t\tairconfig :\u003d rootSettings.Config"},{"line_number":46,"context_line":"\t\t\tif len(args) \u003d\u003d 1 {"},{"line_number":47,"context_line":"\t\t\t\to.Name \u003d args[0]"},{"line_number":48,"context_line":"\t\t\t}"},{"line_number":49,"context_line":"\t\t\tif o.Name \u003d\u003d \"\" {"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_f40170b1","line":46,"range":{"start_line":46,"start_character":6,"end_line":46,"end_character":20},"updated":"2020-05-05 14:45:14.000000000","message":"An argument validator will validate that the correct number of arguments are passed for you [0] i.e. max 1. Otherwise a user may pass too many.\n\n[0] https://github.com/spf13/cobra#positional-and-custom-arguments","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"855935fdf9504d8d40f55b933bd412fa33f8d936","unresolved":false,"context_lines":[{"line_number":43,"context_line":"\t\tExample: getManifestsExample,"},{"line_number":44,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":45,"context_line":"\t\t\tairconfig :\u003d rootSettings.Config"},{"line_number":46,"context_line":"\t\t\tif len(args) \u003d\u003d 1 {"},{"line_number":47,"context_line":"\t\t\t\to.Name \u003d args[0]"},{"line_number":48,"context_line":"\t\t\t}"},{"line_number":49,"context_line":"\t\t\tif o.Name \u003d\u003d \"\" {"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_3f99da78","line":46,"range":{"start_line":46,"start_character":6,"end_line":46,"end_character":20},"in_reply_to":"1f493fa4_f40170b1","updated":"2020-05-06 15:42:29.000000000","message":"Done","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"d53a8127d7a0e8160bdb8ff13788295fda2e98c1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":45,"context_line":"\t\t\tairconfig :\u003d rootSettings.Config"},{"line_number":46,"context_line":"\t\t\tif len(args) \u003d\u003d 1 {"},{"line_number":47,"context_line":"\t\t\t\to.Name \u003d args[0]"},{"line_number":48,"context_line":"\t\t\t}"},{"line_number":49,"context_line":"\t\t\tif o.Name \u003d\u003d \"\" {"},{"line_number":50,"context_line":"\t\t\t\tmanifests :\u003d airconfig.GetManifests()"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_348e3827","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":10},"updated":"2020-05-05 14:45:14.000000000","message":"Am I missing the value in setting this? It seems like we could just use args[0] throughout if len(args) \u003d\u003d 1.","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"855935fdf9504d8d40f55b933bd412fa33f8d936","unresolved":false,"context_lines":[{"line_number":44,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":45,"context_line":"\t\t\tairconfig :\u003d rootSettings.Config"},{"line_number":46,"context_line":"\t\t\tif len(args) \u003d\u003d 1 {"},{"line_number":47,"context_line":"\t\t\t\to.Name \u003d args[0]"},{"line_number":48,"context_line":"\t\t\t}"},{"line_number":49,"context_line":"\t\t\tif o.Name \u003d\u003d \"\" {"},{"line_number":50,"context_line":"\t\t\t\tmanifests :\u003d airconfig.GetManifests()"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_9f890e28","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":10},"in_reply_to":"1f493fa4_348e3827","updated":"2020-05-06 15:42:29.000000000","message":"Done","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"d53a8127d7a0e8160bdb8ff13788295fda2e98c1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\t\t\tif len(args) \u003d\u003d 1 {"},{"line_number":47,"context_line":"\t\t\t\to.Name \u003d args[0]"},{"line_number":48,"context_line":"\t\t\t}"},{"line_number":49,"context_line":"\t\t\tif o.Name \u003d\u003d \"\" {"},{"line_number":50,"context_line":"\t\t\t\tmanifests :\u003d airconfig.GetManifests()"},{"line_number":51,"context_line":"\t\t\t\tif len(manifests) \u003d\u003d 0 {"},{"line_number":52,"context_line":"\t\t\t\t\tfmt.Fprintln(cmd.OutOrStdout(), \"No Manifest found in the configuration.\")"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_d4a8b478","line":49,"range":{"start_line":49,"start_character":3,"end_line":49,"end_character":12},"updated":"2020-05-05 14:45:14.000000000","message":"With respect to my comment above, couldn\u0027t this just happen in the if statement above?","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"855935fdf9504d8d40f55b933bd412fa33f8d936","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\t\t\tif len(args) \u003d\u003d 1 {"},{"line_number":47,"context_line":"\t\t\t\to.Name \u003d args[0]"},{"line_number":48,"context_line":"\t\t\t}"},{"line_number":49,"context_line":"\t\t\tif o.Name \u003d\u003d \"\" {"},{"line_number":50,"context_line":"\t\t\t\tmanifests :\u003d airconfig.GetManifests()"},{"line_number":51,"context_line":"\t\t\t\tif len(manifests) \u003d\u003d 0 {"},{"line_number":52,"context_line":"\t\t\t\t\tfmt.Fprintln(cmd.OutOrStdout(), \"No Manifest found in the configuration.\")"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_7f8c0235","line":49,"range":{"start_line":49,"start_character":3,"end_line":49,"end_character":12},"in_reply_to":"1f493fa4_d4a8b478","updated":"2020-05-06 15:42:29.000000000","message":"Done","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"dcf1bab978d180a4fa25465955cf61e52ca3e6c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":54,"id":"ff570b3c_85db764d","updated":"2020-06-11 22:02:28.000000000","message":"I\u0027ve inlined some comments here, but it\u0027d be nice if this had a bit more consistency with the other commands in the project. See for example:\n\n  https://github.com/airshipit/airshipctl/blob/master/cmd/config/set_cluster.go","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"f55b1ef65d00998992e923c301fbd47d0e1df702","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":54,"id":"bf51134e_65a61813","in_reply_to":"ff570b3c_85db764d","updated":"2020-06-18 20:33:25.000000000","message":"Done","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"dcf1bab978d180a4fa25465955cf61e52ca3e6c0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\t\"opendev.org/airship/airshipctl/pkg/environment\""},{"line_number":24,"context_line":")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"var ("},{"line_number":27,"context_line":"\tgetManifestsLong \u003d `Display a specific manifest information, or all defined manifests if no name is provided`"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"\tgetManifestsExample \u003d `# List all the manifests airshipctl knows about"}],"source_content_type":"text/x-go","patch_set":54,"id":"ff570b3c_252f0a3f","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":3},"updated":"2020-06-11 22:02:28.000000000","message":"this should be const","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"f55b1ef65d00998992e923c301fbd47d0e1df702","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\t\"opendev.org/airship/airshipctl/pkg/environment\""},{"line_number":24,"context_line":")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"var ("},{"line_number":27,"context_line":"\tgetManifestsLong \u003d `Display a specific manifest information, or all defined manifests if no name is provided`"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"\tgetManifestsExample \u003d `# List all the manifests airshipctl knows about"}],"source_content_type":"text/x-go","patch_set":54,"id":"bf51134e_45a954dd","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":3},"in_reply_to":"ff570b3c_252f0a3f","updated":"2020-06-18 20:33:25.000000000","message":"Done","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"dcf1bab978d180a4fa25465955cf61e52ca3e6c0","unresolved":false,"context_lines":[{"line_number":24,"context_line":")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"var ("},{"line_number":27,"context_line":"\tgetManifestsLong \u003d `Display a specific manifest information, or all defined manifests if no name is provided`"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"\tgetManifestsExample \u003d `# List all the manifests airshipctl knows about"},{"line_number":30,"context_line":"airshipctl config get-manifests"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Display a specific manifest"},{"line_number":33,"context_line":"airshipctl config get-manifest e2e`"},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"// NewGetManifestCommand returns a Command instance for \u0027get-manifests\u0027 sub command"}],"source_content_type":"text/x-go","patch_set":54,"id":"ff570b3c_c51f2e07","line":33,"range":{"start_line":27,"start_character":0,"end_line":33,"end_character":35},"updated":"2020-06-11 22:02:28.000000000","message":"These strings should start and end with newlines for readability","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"f55b1ef65d00998992e923c301fbd47d0e1df702","unresolved":false,"context_lines":[{"line_number":24,"context_line":")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"var ("},{"line_number":27,"context_line":"\tgetManifestsLong \u003d `Display a specific manifest information, or all defined manifests if no name is provided`"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"\tgetManifestsExample \u003d `# List all the manifests airshipctl knows about"},{"line_number":30,"context_line":"airshipctl config get-manifests"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Display a specific manifest"},{"line_number":33,"context_line":"airshipctl config get-manifest e2e`"},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"// NewGetManifestCommand returns a Command instance for \u0027get-manifests\u0027 sub command"}],"source_content_type":"text/x-go","patch_set":54,"id":"bf51134e_85aa4ccf","line":33,"range":{"start_line":27,"start_character":0,"end_line":33,"end_character":35},"in_reply_to":"ff570b3c_c51f2e07","updated":"2020-06-18 20:33:25.000000000","message":"Done","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"dcf1bab978d180a4fa25465955cf61e52ca3e6c0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\tcmd :\u003d \u0026cobra.Command{"},{"line_number":40,"context_line":"\t\tUse:     \"get-manifest NAME\","},{"line_number":41,"context_line":"\t\tShort:   \"Get a manifest entry from the airshipctl config\","},{"line_number":42,"context_line":"\t\tLong:    getManifestsLong,"},{"line_number":43,"context_line":"\t\tExample: getManifestsExample,"},{"line_number":44,"context_line":"\t\tArgs:    cobra.MaximumNArgs(1),"},{"line_number":45,"context_line":"\t\tAliases: []string{\"get-manifests\"},"}],"source_content_type":"text/x-go","patch_set":54,"id":"ff570b3c_45d15e2f","line":42,"range":{"start_line":42,"start_character":11,"end_line":42,"end_character":27},"updated":"2020-06-11 22:02:28.000000000","message":"Once getManifestLong ends with a newline, you\u0027ll need to trim it off here with slicing[1:]","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"f55b1ef65d00998992e923c301fbd47d0e1df702","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\tcmd :\u003d \u0026cobra.Command{"},{"line_number":40,"context_line":"\t\tUse:     \"get-manifest NAME\","},{"line_number":41,"context_line":"\t\tShort:   \"Get a manifest entry from the airshipctl config\","},{"line_number":42,"context_line":"\t\tLong:    getManifestsLong,"},{"line_number":43,"context_line":"\t\tExample: getManifestsExample,"},{"line_number":44,"context_line":"\t\tArgs:    cobra.MaximumNArgs(1),"},{"line_number":45,"context_line":"\t\tAliases: []string{\"get-manifests\"},"}],"source_content_type":"text/x-go","patch_set":54,"id":"bf51134e_e5b9882e","line":42,"range":{"start_line":42,"start_character":11,"end_line":42,"end_character":27},"in_reply_to":"ff570b3c_45d15e2f","updated":"2020-06-18 20:33:25.000000000","message":"Done","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"777551155edd85c58ff2ee760fe467c6cb7886c3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"\t\t\tairconfig :\u003d rootSettings.Config"},{"line_number":53,"context_line":"\t\t\tif len(args) \u003d\u003d 1 {"},{"line_number":54,"context_line":"\t\t\t\to.Name \u003d args[0]"},{"line_number":55,"context_line":"\t\t\t\tmanifest, exists :\u003d airconfig.Manifests[o.Name]"},{"line_number":56,"context_line":"\t\t\t\tif !exists {"},{"line_number":57,"context_line":"\t\t\t\t\treturn config.ErrMissingConfig{"},{"line_number":58,"context_line":"\t\t\t\t\t\tWhat: fmt.Sprintf(\"Manifest with name \u0027%s\u0027\", o.Name),"}],"source_content_type":"text/x-go","patch_set":58,"id":"bf51134e_99460cc0","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":51},"updated":"2020-06-22 14:23:20.000000000","message":"there is GetManifests method introduced by this CR. Should not we use it ?","commit_id":"6126f2f6775aa31fda394964ece7b01bd339ec33"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"5614a2e768b42f88574c5620ef1451c7fa51452b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"\t\t\tairconfig :\u003d rootSettings.Config"},{"line_number":53,"context_line":"\t\t\tif len(args) \u003d\u003d 1 {"},{"line_number":54,"context_line":"\t\t\t\to.Name \u003d args[0]"},{"line_number":55,"context_line":"\t\t\t\tmanifest, exists :\u003d airconfig.Manifests[o.Name]"},{"line_number":56,"context_line":"\t\t\t\tif !exists {"},{"line_number":57,"context_line":"\t\t\t\t\treturn config.ErrMissingConfig{"},{"line_number":58,"context_line":"\t\t\t\t\t\tWhat: fmt.Sprintf(\"Manifest with name \u0027%s\u0027\", o.Name),"}],"source_content_type":"text/x-go","patch_set":58,"id":"bf51134e_bc49feb7","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":51},"in_reply_to":"bf51134e_937a36b7","updated":"2020-06-25 13:49:32.000000000","message":"Fair enough","commit_id":"6126f2f6775aa31fda394964ece7b01bd339ec33"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"c6ccfe72ac1fe9383e92c6166f98130c2f428023","unresolved":false,"context_lines":[{"line_number":52,"context_line":"\t\t\tairconfig :\u003d rootSettings.Config"},{"line_number":53,"context_line":"\t\t\tif len(args) \u003d\u003d 1 {"},{"line_number":54,"context_line":"\t\t\t\to.Name \u003d args[0]"},{"line_number":55,"context_line":"\t\t\t\tmanifest, exists :\u003d airconfig.Manifests[o.Name]"},{"line_number":56,"context_line":"\t\t\t\tif !exists {"},{"line_number":57,"context_line":"\t\t\t\t\treturn config.ErrMissingConfig{"},{"line_number":58,"context_line":"\t\t\t\t\t\tWhat: fmt.Sprintf(\"Manifest with name \u0027%s\u0027\", o.Name),"}],"source_content_type":"text/x-go","patch_set":58,"id":"bf51134e_937a36b7","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":51},"in_reply_to":"bf51134e_99460cc0","updated":"2020-06-24 18:43:06.000000000","message":"we dont have a GetManifest to fetch a specific manifest. if we use GetManifests, we will end up iterating through the list looking for a given manifest name. So this seems to be a better option which is used in all other sub-commands.","commit_id":"6126f2f6775aa31fda394964ece7b01bd339ec33"}],"cmd/config/get_manifest_test.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"74cc7878a01130dd7665f947c159719650fe24ec","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\t\"opendev.org/airship/airshipctl/testutil\""},{"line_number":27,"context_line":")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"const ("},{"line_number":30,"context_line":"\tcommonManifestInfo \u003d \"dummy_manifest_config\""},{"line_number":31,"context_line":"\tmissingManifest    \u003d \"manifestMissing\""},{"line_number":32,"context_line":")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"func TestGetManifestConfigCmd(t *testing.T) {"},{"line_number":35,"context_line":"\tconf :\u003d \u0026config.Config{"}],"source_content_type":"text/x-go","patch_set":8,"id":"df33271e_5470d208","line":32,"range":{"start_line":29,"start_character":0,"end_line":32,"end_character":1},"updated":"2020-04-08 19:51:50.000000000","message":"these don\u0027t need to be constant","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"8c88c84df2a6ae0162ed28bd1062a3bc9d2867bf","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\t\"opendev.org/airship/airshipctl/testutil\""},{"line_number":27,"context_line":")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"const ("},{"line_number":30,"context_line":"\tcommonManifestInfo \u003d \"dummy_manifest_config\""},{"line_number":31,"context_line":"\tmissingManifest    \u003d \"manifestMissing\""},{"line_number":32,"context_line":")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"func TestGetManifestConfigCmd(t *testing.T) {"},{"line_number":35,"context_line":"\tconf :\u003d \u0026config.Config{"}],"source_content_type":"text/x-go","patch_set":8,"id":"1f493fa4_6765d045","line":32,"range":{"start_line":29,"start_character":0,"end_line":32,"end_character":1},"in_reply_to":"df33271e_5470d208","updated":"2020-05-04 14:18:57.000000000","message":"Done","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"74cc7878a01130dd7665f947c159719650fe24ec","unresolved":false,"context_lines":[{"line_number":44,"context_line":"\tcmdTests :\u003d []*testutil.CmdTest{"},{"line_number":45,"context_line":"\t\t{"},{"line_number":46,"context_line":"\t\t\tName:    \"get-manifest\","},{"line_number":47,"context_line":"\t\t\tCmdLine: fmt.Sprintf(\"%s\", commonManifestInfo),"},{"line_number":48,"context_line":"\t\t\tCmd:     cmd.NewCmdConfigGetManifest(settings),"},{"line_number":49,"context_line":"\t\t},"},{"line_number":50,"context_line":"\t\t{"}],"source_content_type":"text/x-go","patch_set":8,"id":"df33271e_346d4e32","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":49},"updated":"2020-04-08 19:51:50.000000000","message":"\"dummy_manifest_config\" is good enough","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"8c88c84df2a6ae0162ed28bd1062a3bc9d2867bf","unresolved":false,"context_lines":[{"line_number":44,"context_line":"\tcmdTests :\u003d []*testutil.CmdTest{"},{"line_number":45,"context_line":"\t\t{"},{"line_number":46,"context_line":"\t\t\tName:    \"get-manifest\","},{"line_number":47,"context_line":"\t\t\tCmdLine: fmt.Sprintf(\"%s\", commonManifestInfo),"},{"line_number":48,"context_line":"\t\t\tCmd:     cmd.NewCmdConfigGetManifest(settings),"},{"line_number":49,"context_line":"\t\t},"},{"line_number":50,"context_line":"\t\t{"}],"source_content_type":"text/x-go","patch_set":8,"id":"1f493fa4_c75ae481","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":49},"in_reply_to":"df33271e_346d4e32","updated":"2020-05-04 14:18:57.000000000","message":"Done","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"74cc7878a01130dd7665f947c159719650fe24ec","unresolved":false,"context_lines":[{"line_number":49,"context_line":"\t\t},"},{"line_number":50,"context_line":"\t\t{"},{"line_number":51,"context_line":"\t\t\tName:    \"missing\","},{"line_number":52,"context_line":"\t\t\tCmdLine: fmt.Sprintf(\"%s\", missingManifest),"},{"line_number":53,"context_line":"\t\t\tCmd:     cmd.NewCmdConfigGetManifest(settings),"},{"line_number":54,"context_line":"\t\t\tError: fmt.Errorf(\"Manifest missingManifest information was not \" +"},{"line_number":55,"context_line":"\t\t\t\t\"found in the configuration.\"),"}],"source_content_type":"text/x-go","patch_set":8,"id":"df33271e_146aca18","line":52,"range":{"start_line":52,"start_character":12,"end_line":52,"end_character":46},"updated":"2020-04-08 19:51:50.000000000","message":"\"manifestMissing\" is good enough","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"8c88c84df2a6ae0162ed28bd1062a3bc9d2867bf","unresolved":false,"context_lines":[{"line_number":49,"context_line":"\t\t},"},{"line_number":50,"context_line":"\t\t{"},{"line_number":51,"context_line":"\t\t\tName:    \"missing\","},{"line_number":52,"context_line":"\t\t\tCmdLine: fmt.Sprintf(\"%s\", missingManifest),"},{"line_number":53,"context_line":"\t\t\tCmd:     cmd.NewCmdConfigGetManifest(settings),"},{"line_number":54,"context_line":"\t\t\tError: fmt.Errorf(\"Manifest missingManifest information was not \" +"},{"line_number":55,"context_line":"\t\t\t\t\"found in the configuration.\"),"}],"source_content_type":"text/x-go","patch_set":8,"id":"1f493fa4_a75fd870","line":52,"range":{"start_line":52,"start_character":12,"end_line":52,"end_character":46},"in_reply_to":"df33271e_146aca18","updated":"2020-05-04 14:18:57.000000000","message":"Done","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"74cc7878a01130dd7665f947c159719650fe24ec","unresolved":false,"context_lines":[{"line_number":64,"context_line":"func TestNoManifestGetManifestCmd(t *testing.T) {"},{"line_number":65,"context_line":"\tsettings :\u003d \u0026environment.AirshipCTLSettings{}"},{"line_number":66,"context_line":"\tsettings.SetConfig(\u0026config.Config{})"},{"line_number":67,"context_line":"\tcmdTest :\u003d \u0026testutil.CmdTest{"},{"line_number":68,"context_line":"\t\tName:    \"no-manifests\","},{"line_number":69,"context_line":"\t\tCmdLine: \"\","},{"line_number":70,"context_line":"\t\tCmd:     cmd.NewCmdConfigGetManifest(settings),"},{"line_number":71,"context_line":"\t}"},{"line_number":72,"context_line":"\ttestutil.RunTest(t, cmdTest)"},{"line_number":73,"context_line":"}"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-go","patch_set":8,"id":"df33271e_d4eb4275","line":71,"range":{"start_line":67,"start_character":13,"end_line":71,"end_character":2},"updated":"2020-04-08 19:51:50.000000000","message":"This should be moved into TestGetManifestConfigCmd","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"8c88c84df2a6ae0162ed28bd1062a3bc9d2867bf","unresolved":false,"context_lines":[{"line_number":64,"context_line":"func TestNoManifestGetManifestCmd(t *testing.T) {"},{"line_number":65,"context_line":"\tsettings :\u003d \u0026environment.AirshipCTLSettings{}"},{"line_number":66,"context_line":"\tsettings.SetConfig(\u0026config.Config{})"},{"line_number":67,"context_line":"\tcmdTest :\u003d \u0026testutil.CmdTest{"},{"line_number":68,"context_line":"\t\tName:    \"no-manifests\","},{"line_number":69,"context_line":"\t\tCmdLine: \"\","},{"line_number":70,"context_line":"\t\tCmd:     cmd.NewCmdConfigGetManifest(settings),"},{"line_number":71,"context_line":"\t}"},{"line_number":72,"context_line":"\ttestutil.RunTest(t, cmdTest)"},{"line_number":73,"context_line":"}"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-go","patch_set":8,"id":"1f493fa4_0754cc53","line":71,"range":{"start_line":67,"start_character":13,"end_line":71,"end_character":2},"in_reply_to":"df33271e_d4eb4275","updated":"2020-05-04 14:18:57.000000000","message":"Done","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"c295da265deca58cc992bf6c3552514024179dc0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"\t}"},{"line_number":61,"context_line":"}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"func TestNoManifestGetManifestCmd(t *testing.T) {"},{"line_number":64,"context_line":"\tsettings :\u003d \u0026environment.AirshipCTLSettings{Config: new(config.Config)}"},{"line_number":65,"context_line":"\tcmdTest :\u003d \u0026testutil.CmdTest{"},{"line_number":66,"context_line":"\t\tName:    \"no-manifests\","}],"source_content_type":"text/x-go","patch_set":12,"id":"1f493fa4_b53b90c6","line":63,"updated":"2020-05-02 16:18:44.000000000","message":"This can also be moved to the previous method which is in table driven test format","commit_id":"abd9323d73df141f457f6f21e67f3d66c53af04e"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"1ba54753ee37c82e7dd7d2282c3a80b45cfcbce7","unresolved":false,"context_lines":[{"line_number":60,"context_line":"\t}"},{"line_number":61,"context_line":"}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"func TestNoManifestGetManifestCmd(t *testing.T) {"},{"line_number":64,"context_line":"\tsettings :\u003d \u0026environment.AirshipCTLSettings{Config: new(config.Config)}"},{"line_number":65,"context_line":"\tcmdTest :\u003d \u0026testutil.CmdTest{"},{"line_number":66,"context_line":"\t\tName:    \"no-manifests\","}],"source_content_type":"text/x-go","patch_set":12,"id":"1f493fa4_87ee1c89","line":63,"in_reply_to":"1f493fa4_b53b90c6","updated":"2020-05-04 14:19:39.000000000","message":"Done","commit_id":"abd9323d73df141f457f6f21e67f3d66c53af04e"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"d53a8127d7a0e8160bdb8ff13788295fda2e98c1","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"\tnoConfigSettings :\u003d \u0026environment.AirshipCTLSettings{Config: new(config.Config)}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"\tcmdTests :\u003d []*testutil.CmdTest{"},{"line_number":39,"context_line":"\t\t{"},{"line_number":40,"context_line":"\t\t\tName:    \"get-manifests\","},{"line_number":41,"context_line":"\t\t\tCmdLine: fmt.Sprintf(\"dummyManifestConfig\"),"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_5713060e","line":38,"range":{"start_line":38,"start_character":1,"end_line":38,"end_character":9},"updated":"2020-05-05 14:45:14.000000000","message":"Nice test cases!","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"f09647ff66b5b0632cc44577c5567b4bbe766b97","unresolved":false,"context_lines":[{"line_number":38,"context_line":"\tcmdTests :\u003d []*testutil.CmdTest{"},{"line_number":39,"context_line":"\t\t{"},{"line_number":40,"context_line":"\t\t\tName:    \"get-manifests\","},{"line_number":41,"context_line":"\t\t\tCmdLine: fmt.Sprintf(\"dummyManifestConfig\"),"},{"line_number":42,"context_line":"\t\t\tCmd:     cmd.NewGetManifestCommand(settings),"},{"line_number":43,"context_line":"\t\t},"},{"line_number":44,"context_line":"\t\t{"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_26628a17","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":24},"updated":"2020-05-05 18:47:14.000000000","message":"why is Sprintf needed here? Just use \"dummyManifestConfig\"","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"855935fdf9504d8d40f55b933bd412fa33f8d936","unresolved":false,"context_lines":[{"line_number":38,"context_line":"\tcmdTests :\u003d []*testutil.CmdTest{"},{"line_number":39,"context_line":"\t\t{"},{"line_number":40,"context_line":"\t\t\tName:    \"get-manifests\","},{"line_number":41,"context_line":"\t\t\tCmdLine: fmt.Sprintf(\"dummyManifestConfig\"),"},{"line_number":42,"context_line":"\t\t\tCmd:     cmd.NewGetManifestCommand(settings),"},{"line_number":43,"context_line":"\t\t},"},{"line_number":44,"context_line":"\t\t{"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_5f77863b","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":24},"in_reply_to":"1f493fa4_26628a17","updated":"2020-05-06 15:42:29.000000000","message":"Done","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"f09647ff66b5b0632cc44577c5567b4bbe766b97","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\t\t},"},{"line_number":49,"context_line":"\t\t{"},{"line_number":50,"context_line":"\t\t\tName:    \"missing\","},{"line_number":51,"context_line":"\t\t\tCmdLine: fmt.Sprintf(\"manifestMissing\"),"},{"line_number":52,"context_line":"\t\t\tCmd:     cmd.NewGetManifestCommand(settings),"},{"line_number":53,"context_line":"\t\t\tError: fmt.Errorf(\"Manifest missingManifest information was not \" +"},{"line_number":54,"context_line":"\t\t\t\t\"found in the configuration.\"),"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_666c9208","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":23},"updated":"2020-05-05 18:47:14.000000000","message":"ditto","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"855935fdf9504d8d40f55b933bd412fa33f8d936","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\t\t},"},{"line_number":49,"context_line":"\t\t{"},{"line_number":50,"context_line":"\t\t\tName:    \"missing\","},{"line_number":51,"context_line":"\t\t\tCmdLine: fmt.Sprintf(\"manifestMissing\"),"},{"line_number":52,"context_line":"\t\t\tCmd:     cmd.NewGetManifestCommand(settings),"},{"line_number":53,"context_line":"\t\t\tError: fmt.Errorf(\"Manifest missingManifest information was not \" +"},{"line_number":54,"context_line":"\t\t\t\t\"found in the configuration.\"),"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_3f727a4a","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":23},"in_reply_to":"1f493fa4_666c9208","updated":"2020-05-06 15:42:29.000000000","message":"Done","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"d53a8127d7a0e8160bdb8ff13788295fda2e98c1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"\t\t\tName:    \"missing\","},{"line_number":51,"context_line":"\t\t\tCmdLine: fmt.Sprintf(\"manifestMissing\"),"},{"line_number":52,"context_line":"\t\t\tCmd:     cmd.NewGetManifestCommand(settings),"},{"line_number":53,"context_line":"\t\t\tError: fmt.Errorf(\"Manifest missingManifest information was not \" +"},{"line_number":54,"context_line":"\t\t\t\t\"found in the configuration.\"),"},{"line_number":55,"context_line":"\t\t},"},{"line_number":56,"context_line":"\t\t{"},{"line_number":57,"context_line":"\t\t\tName:    \"no-manifests\","}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_5404a47b","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":35},"updated":"2020-05-05 14:45:14.000000000","message":"Is this what the error actually looks like? If so, it would be nice to clean that up in this change as well if it doesn\u0027t require a lot of edits.","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"855935fdf9504d8d40f55b933bd412fa33f8d936","unresolved":false,"context_lines":[{"line_number":50,"context_line":"\t\t\tName:    \"missing\","},{"line_number":51,"context_line":"\t\t\tCmdLine: fmt.Sprintf(\"manifestMissing\"),"},{"line_number":52,"context_line":"\t\t\tCmd:     cmd.NewGetManifestCommand(settings),"},{"line_number":53,"context_line":"\t\t\tError: fmt.Errorf(\"Manifest missingManifest information was not \" +"},{"line_number":54,"context_line":"\t\t\t\t\"found in the configuration.\"),"},{"line_number":55,"context_line":"\t\t},"},{"line_number":56,"context_line":"\t\t{"},{"line_number":57,"context_line":"\t\t\tName:    \"no-manifests\","}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_df98b66b","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":35},"in_reply_to":"1f493fa4_5404a47b","updated":"2020-05-06 15:42:29.000000000","message":"Done","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"dcf1bab978d180a4fa25465955cf61e52ca3e6c0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"\t\t\tCmdLine: \"dummyManifestConfig\","},{"line_number":42,"context_line":"\t\t\tCmd:     cmd.NewGetManifestCommand(settings),"},{"line_number":43,"context_line":"\t\t},"},{"line_number":44,"context_line":"\t\t{"},{"line_number":45,"context_line":"\t\t\tName:    \"get-all-manifests\","},{"line_number":46,"context_line":"\t\t\tCmdLine: \"\","},{"line_number":47,"context_line":"\t\t\tCmd:     cmd.NewGetManifestCommand(settings),"},{"line_number":48,"context_line":"\t\t},"},{"line_number":49,"context_line":"\t\t{"},{"line_number":50,"context_line":"\t\t\tName:    \"missing\","},{"line_number":51,"context_line":"\t\t\tCmdLine: \"manifestMissing\","}],"source_content_type":"text/x-go","patch_set":54,"id":"ff570b3c_25a26aae","line":48,"range":{"start_line":44,"start_character":0,"end_line":48,"end_character":4},"updated":"2020-06-11 22:02:28.000000000","message":"since `settings` only has a single manifest, this test doesn\u0027t really tell us much. I suggest adding a second manifest to settings","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"f55b1ef65d00998992e923c301fbd47d0e1df702","unresolved":false,"context_lines":[{"line_number":41,"context_line":"\t\t\tCmdLine: \"dummyManifestConfig\","},{"line_number":42,"context_line":"\t\t\tCmd:     cmd.NewGetManifestCommand(settings),"},{"line_number":43,"context_line":"\t\t},"},{"line_number":44,"context_line":"\t\t{"},{"line_number":45,"context_line":"\t\t\tName:    \"get-all-manifests\","},{"line_number":46,"context_line":"\t\t\tCmdLine: \"\","},{"line_number":47,"context_line":"\t\t\tCmd:     cmd.NewGetManifestCommand(settings),"},{"line_number":48,"context_line":"\t\t},"},{"line_number":49,"context_line":"\t\t{"},{"line_number":50,"context_line":"\t\t\tName:    \"missing\","},{"line_number":51,"context_line":"\t\t\tCmdLine: \"manifestMissing\","}],"source_content_type":"text/x-go","patch_set":54,"id":"bf51134e_c5b44438","line":48,"range":{"start_line":44,"start_character":0,"end_line":48,"end_character":4},"in_reply_to":"ff570b3c_25a26aae","updated":"2020-06-18 20:33:25.000000000","message":"Done","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"}],"cmd/config/set_manifest.go":[{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"2f5cceb6abb9390cbbfac5a732fb0d77fda0e3e4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"\t\tLong:    setManifestsLong[1:],"},{"line_number":66,"context_line":"\t\tExample: setManifestsExample,"},{"line_number":67,"context_line":"\t\tArgs:    cobra.ExactArgs(1),"},{"line_number":68,"context_line":"\t\tAliases: []string{\"set-manifests\"},"},{"line_number":69,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":70,"context_line":"\t\t\to.Name \u003d args[0]"},{"line_number":71,"context_line":"\t\t\tmodified, err :\u003d config.RunSetManifest(o, rootSettings.Config, true)"}],"source_content_type":"text/x-go","patch_set":48,"id":"ff570b3c_612825ee","line":68,"updated":"2020-06-08 14:07:33.000000000","message":"This Alias might mislead. set-manifest is good. if we have set-manifests, user might get confused about if we can set multiple in same command","commit_id":"ee10dc3e6871e454eb7867199c9786735bb73638"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"568bd700b1f23dc416f0d68879025a3dbe6faf39","unresolved":false,"context_lines":[{"line_number":65,"context_line":"\t\tLong:    setManifestsLong[1:],"},{"line_number":66,"context_line":"\t\tExample: setManifestsExample,"},{"line_number":67,"context_line":"\t\tArgs:    cobra.ExactArgs(1),"},{"line_number":68,"context_line":"\t\tAliases: []string{\"set-manifests\"},"},{"line_number":69,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":70,"context_line":"\t\t\to.Name \u003d args[0]"},{"line_number":71,"context_line":"\t\t\tmodified, err :\u003d config.RunSetManifest(o, rootSettings.Config, true)"}],"source_content_type":"text/x-go","patch_set":48,"id":"ff570b3c_048df7d2","line":68,"in_reply_to":"ff570b3c_612825ee","updated":"2020-06-08 14:50:44.000000000","message":"Done","commit_id":"ee10dc3e6871e454eb7867199c9786735bb73638"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"dcf1bab978d180a4fa25465955cf61e52ca3e6c0","unresolved":false,"context_lines":[{"line_number":91,"context_line":"\t\t\u0026o.RepoName,"},{"line_number":92,"context_line":"\t\t\"repo\","},{"line_number":93,"context_line":"\t\t\"\","},{"line_number":94,"context_line":"\t\t\"Repository Name\")"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"\tflags.StringVar("},{"line_number":97,"context_line":"\t\t\u0026o.URL,"}],"source_content_type":"text/x-go","patch_set":54,"id":"ff570b3c_e5e992e3","line":94,"range":{"start_line":94,"start_character":3,"end_line":94,"end_character":18},"updated":"2020-06-11 22:02:28.000000000","message":"This could use more detail. Something like\n\n  \"the name of the repository to associate with this manifest\"\n\nThe same goes for the rest of the flags.","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"f55b1ef65d00998992e923c301fbd47d0e1df702","unresolved":false,"context_lines":[{"line_number":91,"context_line":"\t\t\u0026o.RepoName,"},{"line_number":92,"context_line":"\t\t\"repo\","},{"line_number":93,"context_line":"\t\t\"\","},{"line_number":94,"context_line":"\t\t\"Repository Name\")"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"\tflags.StringVar("},{"line_number":97,"context_line":"\t\t\u0026o.URL,"}],"source_content_type":"text/x-go","patch_set":54,"id":"bf51134e_657f3867","line":94,"range":{"start_line":94,"start_character":3,"end_line":94,"end_character":18},"in_reply_to":"ff570b3c_e5e992e3","updated":"2020-06-18 20:33:25.000000000","message":"Done","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"dcf1bab978d180a4fa25465955cf61e52ca3e6c0","unresolved":false,"context_lines":[{"line_number":97,"context_line":"\t\t\u0026o.URL,"},{"line_number":98,"context_line":"\t\t\"url\","},{"line_number":99,"context_line":"\t\t\"\","},{"line_number":100,"context_line":"\t\t\"Repository URL\")"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"\tflags.StringVar("},{"line_number":103,"context_line":"\t\t\u0026o.Branch,"}],"source_content_type":"text/x-go","patch_set":54,"id":"ff570b3c_25bd4ad7","line":100,"range":{"start_line":100,"start_character":3,"end_line":100,"end_character":13},"updated":"2020-06-11 22:02:28.000000000","message":"Note that flag descriptions should start with a lower case letter to keep consistency with the other commands","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"f55b1ef65d00998992e923c301fbd47d0e1df702","unresolved":false,"context_lines":[{"line_number":97,"context_line":"\t\t\u0026o.URL,"},{"line_number":98,"context_line":"\t\t\"url\","},{"line_number":99,"context_line":"\t\t\"\","},{"line_number":100,"context_line":"\t\t\"Repository URL\")"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"\tflags.StringVar("},{"line_number":103,"context_line":"\t\t\u0026o.Branch,"}],"source_content_type":"text/x-go","patch_set":54,"id":"bf51134e_4582f450","line":100,"range":{"start_line":100,"start_character":3,"end_line":100,"end_character":13},"in_reply_to":"ff570b3c_25bd4ad7","updated":"2020-06-18 20:33:25.000000000","message":"Done","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"}],"cmd/config/testdata/TestConfigGoldenOutput/config-cmd-with-help.golden":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"410f398f1516f408c88b4f18bd425e0ebbbc96f4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  get-cluster     Get cluster information from the airshipctl config"},{"line_number":8,"context_line":"  get-context     Get context information from the airshipctl config"},{"line_number":9,"context_line":"  get-credentials Get user credentials from the airshipctl config"},{"line_number":10,"context_line":"  get-manifests   Get a manifest entry from the airshipctl config"},{"line_number":11,"context_line":"  help            Help about any command"},{"line_number":12,"context_line":"  import          Merge information from a kubernetes config file"},{"line_number":13,"context_line":"  init            Generate initial configuration files for airshipctl"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"1f493fa4_50e1352a","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":15},"updated":"2020-05-06 17:35:01.000000000","message":"Maybe it\u0027s better to use get-manifest like for other cmds?","commit_id":"336149c65064cc9565dee0399216e0a05de5a237"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"571b197eaf924e0692568de4a6cbf04d9daf4397","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  get-cluster     Get cluster information from the airshipctl config"},{"line_number":8,"context_line":"  get-context     Get context information from the airshipctl config"},{"line_number":9,"context_line":"  get-credentials Get user credentials from the airshipctl config"},{"line_number":10,"context_line":"  get-manifests   Get a manifest entry from the airshipctl config"},{"line_number":11,"context_line":"  help            Help about any command"},{"line_number":12,"context_line":"  import          Merge information from a kubernetes config file"},{"line_number":13,"context_line":"  init            Generate initial configuration files for airshipctl"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"1f493fa4_d011c506","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":15},"in_reply_to":"1f493fa4_50e1352a","updated":"2020-05-06 17:40:20.000000000","message":"this was changed from get-manifest to get-manifests as per suggestion, since we can have multiple manifests. some thing similar to get-credentials","commit_id":"336149c65064cc9565dee0399216e0a05de5a237"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"4f63b7daceddae4e553f6a1c1b20f560173cb756","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  get-cluster     Get cluster information from the airshipctl config"},{"line_number":8,"context_line":"  get-context     Get context information from the airshipctl config"},{"line_number":9,"context_line":"  get-credentials Get user credentials from the airshipctl config"},{"line_number":10,"context_line":"  get-manifests   Get a manifest entry from the airshipctl config"},{"line_number":11,"context_line":"  help            Help about any command"},{"line_number":12,"context_line":"  import          Merge information from a kubernetes config file"},{"line_number":13,"context_line":"  init            Generate initial configuration files for airshipctl"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"1f493fa4_f0ffa164","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":15},"in_reply_to":"1f493fa4_d011c506","updated":"2020-05-06 17:52:26.000000000","message":"But in general we have the following approach(for most of the commands): get-cluster without argument provides information about all clusters and get-cluster \u003cname\u003e provides information for only particular one. I think it\u0027s the main path.","commit_id":"336149c65064cc9565dee0399216e0a05de5a237"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"75d6292b6801fd8bd51d9dac1b00cb89d664c6b6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  get-cluster     Get cluster information from the airshipctl config"},{"line_number":8,"context_line":"  get-context     Get context information from the airshipctl config"},{"line_number":9,"context_line":"  get-credentials Get user credentials from the airshipctl config"},{"line_number":10,"context_line":"  get-manifests   Get a manifest entry from the airshipctl config"},{"line_number":11,"context_line":"  help            Help about any command"},{"line_number":12,"context_line":"  import          Merge information from a kubernetes config file"},{"line_number":13,"context_line":"  init            Generate initial configuration files for airshipctl"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"1f493fa4_811c1178","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":15},"in_reply_to":"1f493fa4_f0ffa164","updated":"2020-05-06 20:42:23.000000000","message":"Done","commit_id":"336149c65064cc9565dee0399216e0a05de5a237"}],"pkg/config/cmds.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"74cc7878a01130dd7665f947c159719650fe24ec","unresolved":false,"context_lines":[{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"// RunGetManifest performs the execution of \u0027config get-manifests\u0027 sub command"},{"line_number":114,"context_line":"func RunGetManifest(o *ContextOptions, out io.Writer, airconfig *Config) error {"},{"line_number":115,"context_line":"\tif o.Name \u003d\u003d \"\" {"},{"line_number":116,"context_line":"\t\tgetManifests(out, airconfig)"},{"line_number":117,"context_line":"\t\treturn nil"}],"source_content_type":"text/x-go","patch_set":8,"id":"df33271e_94309a58","line":114,"range":{"start_line":114,"start_character":20,"end_line":114,"end_character":37},"updated":"2020-04-08 19:51:50.000000000","message":"make this a string, and give a more descriptive variable name","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"8c88c84df2a6ae0162ed28bd1062a3bc9d2867bf","unresolved":false,"context_lines":[{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"// RunGetManifest performs the execution of \u0027config get-manifests\u0027 sub command"},{"line_number":114,"context_line":"func RunGetManifest(o *ContextOptions, out io.Writer, airconfig *Config) error {"},{"line_number":115,"context_line":"\tif o.Name \u003d\u003d \"\" {"},{"line_number":116,"context_line":"\t\tgetManifests(out, airconfig)"},{"line_number":117,"context_line":"\t\treturn nil"}],"source_content_type":"text/x-go","patch_set":8,"id":"1f493fa4_e750c061","line":114,"range":{"start_line":114,"start_character":20,"end_line":114,"end_character":37},"in_reply_to":"df33271e_94309a58","updated":"2020-05-04 14:18:57.000000000","message":"Done","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"74cc7878a01130dd7665f947c159719650fe24ec","unresolved":false,"context_lines":[{"line_number":131,"context_line":"func getManifests(out io.Writer, airconfig *Config) {"},{"line_number":132,"context_line":"\tmanifests :\u003d airconfig.GetManifests()"},{"line_number":133,"context_line":"\tif len(manifests) \u003d\u003d 0 {"},{"line_number":134,"context_line":"\t\tfmt.Fprintln(out, \"No Manifest found in the configuration.\")"},{"line_number":135,"context_line":"\t}"},{"line_number":136,"context_line":"\tfor _, manifest :\u003d range manifests {"},{"line_number":137,"context_line":"\t\tfmt.Fprintln(out, manifest)"}],"source_content_type":"text/x-go","patch_set":8,"id":"df33271e_d436a251","line":134,"range":{"start_line":134,"start_character":24,"end_line":134,"end_character":32},"updated":"2020-04-08 19:51:50.000000000","message":"Manifests","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"8c88c84df2a6ae0162ed28bd1062a3bc9d2867bf","unresolved":false,"context_lines":[{"line_number":131,"context_line":"func getManifests(out io.Writer, airconfig *Config) {"},{"line_number":132,"context_line":"\tmanifests :\u003d airconfig.GetManifests()"},{"line_number":133,"context_line":"\tif len(manifests) \u003d\u003d 0 {"},{"line_number":134,"context_line":"\t\tfmt.Fprintln(out, \"No Manifest found in the configuration.\")"},{"line_number":135,"context_line":"\t}"},{"line_number":136,"context_line":"\tfor _, manifest :\u003d range manifests {"},{"line_number":137,"context_line":"\t\tfmt.Fprintln(out, manifest)"}],"source_content_type":"text/x-go","patch_set":8,"id":"1f493fa4_87c57c0d","line":134,"range":{"start_line":134,"start_character":24,"end_line":134,"end_character":32},"in_reply_to":"df33271e_d436a251","updated":"2020-05-04 14:18:57.000000000","message":"Done","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"}],"pkg/config/config.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"74cc7878a01130dd7665f947c159719650fe24ec","unresolved":false,"context_lines":[{"line_number":728,"context_line":"}"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"// Manifest Operations from Config point of view"},{"line_number":731,"context_line":"// Get Manifest"},{"line_number":732,"context_line":"func (c *Config) GetManifest(mName string) (*Manifest, error) {"},{"line_number":733,"context_line":"\tmanifest, exists :\u003d c.Manifests[mName]"},{"line_number":734,"context_line":"\tif !exists {"}],"source_content_type":"text/x-go","patch_set":8,"id":"df33271e_f40ac676","line":731,"range":{"start_line":731,"start_character":3,"end_line":731,"end_character":15},"updated":"2020-04-08 19:51:50.000000000","message":"Documentation begins with the name of the thing being documented and is a complete sentence: [0]\n\n[0] https://github.com/golang/go/wiki/CodeReviewComments#comment-sentences","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"8c88c84df2a6ae0162ed28bd1062a3bc9d2867bf","unresolved":false,"context_lines":[{"line_number":728,"context_line":"}"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"// Manifest Operations from Config point of view"},{"line_number":731,"context_line":"// Get Manifest"},{"line_number":732,"context_line":"func (c *Config) GetManifest(mName string) (*Manifest, error) {"},{"line_number":733,"context_line":"\tmanifest, exists :\u003d c.Manifests[mName]"},{"line_number":734,"context_line":"\tif !exists {"}],"source_content_type":"text/x-go","patch_set":8,"id":"1f493fa4_67caf01a","line":731,"range":{"start_line":731,"start_character":3,"end_line":731,"end_character":15},"in_reply_to":"df33271e_f40ac676","updated":"2020-05-04 14:18:57.000000000","message":"Done","commit_id":"9daab4098a8814fcd553dcecef76addc3245f6de"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"f09647ff66b5b0632cc44577c5567b4bbe766b97","unresolved":false,"context_lines":[{"line_number":784,"context_line":"\treturn bootstrap, nil"},{"line_number":785,"context_line":"}"},{"line_number":786,"context_line":""},{"line_number":787,"context_line":"// GetManifest Operations from Config point of view"},{"line_number":788,"context_line":"func (c *Config) GetManifest(mName string) (*Manifest, error) {"},{"line_number":789,"context_line":"\tmanifest, exists :\u003d c.Manifests[mName]"},{"line_number":790,"context_line":"\tif !exists {"},{"line_number":791,"context_line":"\t\treturn nil, ErrMissingConfig{"},{"line_number":792,"context_line":"\t\t\tWhat: fmt.Sprintf(\"Manifest with name \u0027%s\u0027\", mName),"},{"line_number":793,"context_line":"\t\t}"},{"line_number":794,"context_line":"\t}"},{"line_number":795,"context_line":"\treturn manifest, nil"},{"line_number":796,"context_line":"}"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"// GetManifests returns all of the Manifests associated with the Config sorted by name"},{"line_number":799,"context_line":"func (c *Config) GetManifests() []*Manifest {"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_5a568608","line":796,"range":{"start_line":787,"start_character":0,"end_line":796,"end_character":1},"updated":"2020-05-05 18:47:14.000000000","message":"This function seems like bloat - why wouldn\u0027t a user simply check for existence in their own code? They\u0027re going to need to do it anyway since this function returns an error","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"855935fdf9504d8d40f55b933bd412fa33f8d936","unresolved":false,"context_lines":[{"line_number":784,"context_line":"\treturn bootstrap, nil"},{"line_number":785,"context_line":"}"},{"line_number":786,"context_line":""},{"line_number":787,"context_line":"// GetManifest Operations from Config point of view"},{"line_number":788,"context_line":"func (c *Config) GetManifest(mName string) (*Manifest, error) {"},{"line_number":789,"context_line":"\tmanifest, exists :\u003d c.Manifests[mName]"},{"line_number":790,"context_line":"\tif !exists {"},{"line_number":791,"context_line":"\t\treturn nil, ErrMissingConfig{"},{"line_number":792,"context_line":"\t\t\tWhat: fmt.Sprintf(\"Manifest with name \u0027%s\u0027\", mName),"},{"line_number":793,"context_line":"\t\t}"},{"line_number":794,"context_line":"\t}"},{"line_number":795,"context_line":"\treturn manifest, nil"},{"line_number":796,"context_line":"}"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"// GetManifests returns all of the Manifests associated with the Config sorted by name"},{"line_number":799,"context_line":"func (c *Config) GetManifests() []*Manifest {"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_bf9b2a64","line":796,"range":{"start_line":787,"start_character":0,"end_line":796,"end_character":1},"in_reply_to":"1f493fa4_5a568608","updated":"2020-05-06 15:42:29.000000000","message":"Done","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"d53a8127d7a0e8160bdb8ff13788295fda2e98c1","unresolved":false,"context_lines":[{"line_number":801,"context_line":"\tfor name :\u003d range c.Manifests {"},{"line_number":802,"context_line":"\t\tkeys \u003d append(keys, name)"},{"line_number":803,"context_line":"\t}"},{"line_number":804,"context_line":"\tsort.Strings(keys)"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"\tmanifests :\u003d make([]*Manifest, 0, len(c.Manifests))"},{"line_number":807,"context_line":"\tfor _, name :\u003d range keys {"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_f734d2e0","line":804,"range":{"start_line":804,"start_character":1,"end_line":804,"end_character":19},"updated":"2020-05-05 14:45:14.000000000","message":"You can sort a slice using a comparison function: https://golang.org/pkg/sort/#Slice","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"855935fdf9504d8d40f55b933bd412fa33f8d936","unresolved":false,"context_lines":[{"line_number":801,"context_line":"\tfor name :\u003d range c.Manifests {"},{"line_number":802,"context_line":"\t\tkeys \u003d append(keys, name)"},{"line_number":803,"context_line":"\t}"},{"line_number":804,"context_line":"\tsort.Strings(keys)"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"\tmanifests :\u003d make([]*Manifest, 0, len(c.Manifests))"},{"line_number":807,"context_line":"\tfor _, name :\u003d range keys {"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_9fb74ed9","line":804,"range":{"start_line":804,"start_character":1,"end_line":804,"end_character":19},"in_reply_to":"1f493fa4_f734d2e0","updated":"2020-05-06 15:42:29.000000000","message":"slice sorts the given slice. Datastructure here is not slice its a map, going through the documentation for sorting a map, getting keys, sorting it and iterating it seems better option. please suggest if my understanding is correct","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"dcf1bab978d180a4fa25465955cf61e52ca3e6c0","unresolved":false,"context_lines":[{"line_number":985,"context_line":"\tif theManifest.TargetPath !\u003d \"\" {"},{"line_number":986,"context_line":"\t\tmanifest.TargetPath \u003d theManifest.TargetPath"},{"line_number":987,"context_line":"\t}"},{"line_number":988,"context_line":"\tif theManifest.IsPrimary \u0026\u0026 theManifest.URL \u003d\u003d \"\" \u0026\u0026 (manifest.Repositories[theManifest.RepoName] \u003d\u003d nil) {"},{"line_number":989,"context_line":"\t\treturn ErrRepositoryNotFound{theManifest.RepoName}"},{"line_number":990,"context_line":"\t}"},{"line_number":991,"context_line":"\trepository, exists :\u003d manifest.Repositories[theManifest.RepoName]"},{"line_number":992,"context_line":"\tif !exists {"},{"line_number":993,"context_line":"\t\t_, err :\u003d c.AddRepository(manifest, theManifest)"}],"source_content_type":"text/x-go","patch_set":54,"id":"ff570b3c_e5707243","line":990,"range":{"start_line":988,"start_character":0,"end_line":990,"end_character":2},"updated":"2020-06-11 22:02:28.000000000","message":"I had a really hard time following what exactly is happening in this function. Could you add some comments explaining what this does?","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"f55b1ef65d00998992e923c301fbd47d0e1df702","unresolved":false,"context_lines":[{"line_number":985,"context_line":"\tif theManifest.TargetPath !\u003d \"\" {"},{"line_number":986,"context_line":"\t\tmanifest.TargetPath \u003d theManifest.TargetPath"},{"line_number":987,"context_line":"\t}"},{"line_number":988,"context_line":"\tif theManifest.IsPrimary \u0026\u0026 theManifest.URL \u003d\u003d \"\" \u0026\u0026 (manifest.Repositories[theManifest.RepoName] \u003d\u003d nil) {"},{"line_number":989,"context_line":"\t\treturn ErrRepositoryNotFound{theManifest.RepoName}"},{"line_number":990,"context_line":"\t}"},{"line_number":991,"context_line":"\trepository, exists :\u003d manifest.Repositories[theManifest.RepoName]"},{"line_number":992,"context_line":"\tif !exists {"},{"line_number":993,"context_line":"\t\t_, err :\u003d c.AddRepository(manifest, theManifest)"}],"source_content_type":"text/x-go","patch_set":54,"id":"bf51134e_85936ca3","line":990,"range":{"start_line":988,"start_character":0,"end_line":990,"end_character":2},"in_reply_to":"ff570b3c_e5707243","updated":"2020-06-18 20:33:25.000000000","message":"Done","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"777551155edd85c58ff2ee760fe467c6cb7886c3","unresolved":false,"context_lines":[{"line_number":986,"context_line":"\t}"},{"line_number":987,"context_line":"\t//when setting an existing repository as primary, verify whether the repository exists"},{"line_number":988,"context_line":"\t//and user is also not passing any repository URL"},{"line_number":989,"context_line":"\tif theManifest.IsPrimary \u0026\u0026 theManifest.URL \u003d\u003d \"\" \u0026\u0026 (manifest.Repositories[theManifest.RepoName] \u003d\u003d nil) {"},{"line_number":990,"context_line":"\t\treturn ErrRepositoryNotFound{theManifest.RepoName}"},{"line_number":991,"context_line":"\t}"},{"line_number":992,"context_line":"\trepository, exists :\u003d manifest.Repositories[theManifest.RepoName]"}],"source_content_type":"text/x-go","patch_set":58,"id":"bf51134e_b431555d","line":989,"range":{"start_line":989,"start_character":54,"end_line":989,"end_character":106},"updated":"2020-06-22 14:23:20.000000000","message":"1. we should not allow user to add repos with empty url.\n2. considering #1 we should not care if repo exists since we are going to create it anyway (line 994)\n\nmoreover error blow does not correspond comment lines and overall logic. It says \u0027repo is not found\u0027 but logic says \u0027you are trying to add primary repo with empty URL\u0027\n\ni think adding somehting like \u0027if theManifest.URL \u003d\u003d \"\" { return error }\u0027 at the beginning of this method should simplify function","commit_id":"6126f2f6775aa31fda394964ece7b01bd339ec33"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"c6ccfe72ac1fe9383e92c6166f98130c2f428023","unresolved":false,"context_lines":[{"line_number":986,"context_line":"\t}"},{"line_number":987,"context_line":"\t//when setting an existing repository as primary, verify whether the repository exists"},{"line_number":988,"context_line":"\t//and user is also not passing any repository URL"},{"line_number":989,"context_line":"\tif theManifest.IsPrimary \u0026\u0026 theManifest.URL \u003d\u003d \"\" \u0026\u0026 (manifest.Repositories[theManifest.RepoName] \u003d\u003d nil) {"},{"line_number":990,"context_line":"\t\treturn ErrRepositoryNotFound{theManifest.RepoName}"},{"line_number":991,"context_line":"\t}"},{"line_number":992,"context_line":"\trepository, exists :\u003d manifest.Repositories[theManifest.RepoName]"}],"source_content_type":"text/x-go","patch_set":58,"id":"bf51134e_d3514e38","line":989,"range":{"start_line":989,"start_character":54,"end_line":989,"end_character":106},"in_reply_to":"bf51134e_b431555d","updated":"2020-06-24 18:43:06.000000000","message":"Done","commit_id":"6126f2f6775aa31fda394964ece7b01bd339ec33"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"5614a2e768b42f88574c5620ef1451c7fa51452b","unresolved":false,"context_lines":[{"line_number":986,"context_line":"\t}"},{"line_number":987,"context_line":"\t//when setting an existing repository as primary, verify whether the repository exists"},{"line_number":988,"context_line":"\t//and user is also not passing any repository URL"},{"line_number":989,"context_line":"\tif theManifest.IsPrimary \u0026\u0026 theManifest.URL \u003d\u003d \"\" \u0026\u0026 (manifest.Repositories[theManifest.RepoName] \u003d\u003d nil) {"},{"line_number":990,"context_line":"\t\treturn ErrRepositoryNotFound{theManifest.RepoName}"},{"line_number":991,"context_line":"\t}"},{"line_number":992,"context_line":"\trepository, exists :\u003d manifest.Repositories[theManifest.RepoName]"}],"source_content_type":"text/x-go","patch_set":58,"id":"bf51134e_e20ab01d","line":989,"range":{"start_line":989,"start_character":54,"end_line":989,"end_character":106},"in_reply_to":"bf51134e_d3514e38","updated":"2020-06-25 13:49:32.000000000","message":"I do not see any difference...","commit_id":"6126f2f6775aa31fda394964ece7b01bd339ec33"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"d27ff9885e72da319481e045d8a2f1fd6eadd4fa","unresolved":false,"context_lines":[{"line_number":986,"context_line":"\t}"},{"line_number":987,"context_line":"\t//when setting an existing repository as primary, verify whether the repository exists"},{"line_number":988,"context_line":"\t//and user is also not passing any repository URL"},{"line_number":989,"context_line":"\tif theManifest.IsPrimary \u0026\u0026 theManifest.URL \u003d\u003d \"\" \u0026\u0026 (manifest.Repositories[theManifest.RepoName] \u003d\u003d nil) {"},{"line_number":990,"context_line":"\t\treturn ErrRepositoryNotFound{theManifest.RepoName}"},{"line_number":991,"context_line":"\t}"},{"line_number":992,"context_line":"\trepository, exists :\u003d manifest.Repositories[theManifest.RepoName]"}],"source_content_type":"text/x-go","patch_set":58,"id":"bf51134e_85901e97","line":989,"range":{"start_line":989,"start_character":54,"end_line":989,"end_character":106},"in_reply_to":"bf51134e_e20ab01d","updated":"2020-06-25 14:32:54.000000000","message":"Sorry forgot to point where the changes are done. The condition is added part of set-manifest command initialization itself. in cmd/config/set_manifest.go L73-L75","commit_id":"6126f2f6775aa31fda394964ece7b01bd339ec33"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"777551155edd85c58ff2ee760fe467c6cb7886c3","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"\tif theManifest.Force {"},{"line_number":1033,"context_line":"\t\trepository.CheckoutOptions.ForceCheckout \u003d theManifest.Force"},{"line_number":1034,"context_line":"\t}"},{"line_number":1035,"context_line":"\tpossibleValues :\u003d []string{repository.CheckoutOptions.CommitHash,"},{"line_number":1036,"context_line":"\t\trepository.CheckoutOptions.Branch, repository.CheckoutOptions.Tag}"},{"line_number":1037,"context_line":"\tvar count int"},{"line_number":1038,"context_line":"\tfor _, val :\u003d range possibleValues {"},{"line_number":1039,"context_line":"\t\tif val !\u003d \"\" {"}],"source_content_type":"text/x-go","patch_set":58,"id":"bf51134e_54571959","line":1036,"range":{"start_line":1035,"start_character":19,"end_line":1036,"end_character":68},"updated":"2020-06-22 14:23:20.000000000","message":"use array not slice if list size is known before hand (i.e [3]string{...}","commit_id":"6126f2f6775aa31fda394964ece7b01bd339ec33"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"c6ccfe72ac1fe9383e92c6166f98130c2f428023","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"\tif theManifest.Force {"},{"line_number":1033,"context_line":"\t\trepository.CheckoutOptions.ForceCheckout \u003d theManifest.Force"},{"line_number":1034,"context_line":"\t}"},{"line_number":1035,"context_line":"\tpossibleValues :\u003d []string{repository.CheckoutOptions.CommitHash,"},{"line_number":1036,"context_line":"\t\trepository.CheckoutOptions.Branch, repository.CheckoutOptions.Tag}"},{"line_number":1037,"context_line":"\tvar count int"},{"line_number":1038,"context_line":"\tfor _, val :\u003d range possibleValues {"},{"line_number":1039,"context_line":"\t\tif val !\u003d \"\" {"}],"source_content_type":"text/x-go","patch_set":58,"id":"bf51134e_33452a71","line":1036,"range":{"start_line":1035,"start_character":19,"end_line":1036,"end_character":68},"in_reply_to":"bf51134e_54571959","updated":"2020-06-24 18:43:06.000000000","message":"Done","commit_id":"6126f2f6775aa31fda394964ece7b01bd339ec33"}],"pkg/config/errors.go":[{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"2f5cceb6abb9390cbbfac5a732fb0d77fda0e3e4","unresolved":false,"context_lines":[{"line_number":81,"context_line":"}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"// ErrMissingRepositoryName is returned if repository name is empty"},{"line_number":84,"context_line":"//// when using in set-manifest"},{"line_number":85,"context_line":"type ErrMissingRepositoryName struct {"},{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-go","patch_set":48,"id":"ff570b3c_6181454e","line":84,"updated":"2020-06-08 14:07:33.000000000","message":"//// \u003d\u003e //","commit_id":"ee10dc3e6871e454eb7867199c9786735bb73638"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"568bd700b1f23dc416f0d68879025a3dbe6faf39","unresolved":false,"context_lines":[{"line_number":81,"context_line":"}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"// ErrMissingRepositoryName is returned if repository name is empty"},{"line_number":84,"context_line":"//// when using in set-manifest"},{"line_number":85,"context_line":"type ErrMissingRepositoryName struct {"},{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-go","patch_set":48,"id":"ff570b3c_84baa76b","line":84,"in_reply_to":"ff570b3c_6181454e","updated":"2020-06-08 14:50:44.000000000","message":"Done","commit_id":"ee10dc3e6871e454eb7867199c9786735bb73638"}],"pkg/config/options.go":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"d53a8127d7a0e8160bdb8ff13788295fda2e98c1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"// ManifestOptions holds all configurable options for manifest configuration"},{"line_number":59,"context_line":"type ManifestOptions struct {"},{"line_number":60,"context_line":"\tName        string"},{"line_number":61,"context_line":"\tManifest    string"},{"line_number":62,"context_line":"\tPrimaryRepo string"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_b796ca93","line":59,"range":{"start_line":59,"start_character":5,"end_line":59,"end_character":20},"updated":"2020-05-05 14:45:14.000000000","message":"I didn\u0027t see this used anywhere except for the name field. Can you explain what value this is adding?","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"855935fdf9504d8d40f55b933bd412fa33f8d936","unresolved":false,"context_lines":[{"line_number":56,"context_line":"}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"// ManifestOptions holds all configurable options for manifest configuration"},{"line_number":59,"context_line":"type ManifestOptions struct {"},{"line_number":60,"context_line":"\tName        string"},{"line_number":61,"context_line":"\tManifest    string"},{"line_number":62,"context_line":"\tPrimaryRepo string"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f493fa4_3fc0ba2a","line":59,"range":{"start_line":59,"start_character":5,"end_line":59,"end_character":20},"in_reply_to":"1f493fa4_b796ca93","updated":"2020-05-06 15:42:29.000000000","message":"This is suppose to be used in set-manifest. i have removed everything except Name from this","commit_id":"f7fc721351bada5d85c7c852563f5e269fc616e2"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"2f5cceb6abb9390cbbfac5a732fb0d77fda0e3e4","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"// Validate checks for the possible manifest option values and returns"},{"line_number":174,"context_line":"// Error when invalid value or incompatible choice of values given"},{"line_number":175,"context_line":"func (o *ManifestOptions) Validate() error {"},{"line_number":176,"context_line":"\tif o.Name \u003d\u003d \"\" {"},{"line_number":177,"context_line":"\t\treturn fmt.Errorf(\"you must specify a non-empty Manifest name\")"},{"line_number":178,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":48,"id":"ff570b3c_a1807dc1","line":175,"updated":"2020-06-08 14:07:33.000000000","message":"nit: Can we also add some validation for targetPath. If a user provides non existent path for targetPath, should we raise a error ?","commit_id":"ee10dc3e6871e454eb7867199c9786735bb73638"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"568bd700b1f23dc416f0d68879025a3dbe6faf39","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"// Validate checks for the possible manifest option values and returns"},{"line_number":174,"context_line":"// Error when invalid value or incompatible choice of values given"},{"line_number":175,"context_line":"func (o *ManifestOptions) Validate() error {"},{"line_number":176,"context_line":"\tif o.Name \u003d\u003d \"\" {"},{"line_number":177,"context_line":"\t\treturn fmt.Errorf(\"you must specify a non-empty Manifest name\")"},{"line_number":178,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":48,"id":"ff570b3c_24a91b24","line":175,"in_reply_to":"ff570b3c_a1807dc1","updated":"2020-06-08 14:50:44.000000000","message":"TargetPath is always created if it dont exist. so i think we dont have to verify that","commit_id":"ee10dc3e6871e454eb7867199c9786735bb73638"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"2f5cceb6abb9390cbbfac5a732fb0d77fda0e3e4","unresolved":false,"context_lines":[{"line_number":182,"context_line":"\tif o.IsPrimary \u0026\u0026 o.RepoName \u003d\u003d \"\" {"},{"line_number":183,"context_line":"\t\treturn ErrMissingRepositoryName{}"},{"line_number":184,"context_line":"\t}"},{"line_number":185,"context_line":"\tif !o.IsPrimary \u0026\u0026 o.RepoName !\u003d \"\" \u0026\u0026 o.URL \u003d\u003d \"\" {"},{"line_number":186,"context_line":"\t\treturn ErrMissingRepoURL{}"},{"line_number":187,"context_line":"\t}"},{"line_number":188,"context_line":"\tpossibleValues :\u003d []string{o.CommitHash, o.Branch, o.Tag}"}],"source_content_type":"text/x-go","patch_set":48,"id":"ff570b3c_c1f2d1e3","line":185,"updated":"2020-06-08 14:07:33.000000000","message":"one line of comment on these conditions will improve the readability","commit_id":"ee10dc3e6871e454eb7867199c9786735bb73638"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"568bd700b1f23dc416f0d68879025a3dbe6faf39","unresolved":false,"context_lines":[{"line_number":182,"context_line":"\tif o.IsPrimary \u0026\u0026 o.RepoName \u003d\u003d \"\" {"},{"line_number":183,"context_line":"\t\treturn ErrMissingRepositoryName{}"},{"line_number":184,"context_line":"\t}"},{"line_number":185,"context_line":"\tif !o.IsPrimary \u0026\u0026 o.RepoName !\u003d \"\" \u0026\u0026 o.URL \u003d\u003d \"\" {"},{"line_number":186,"context_line":"\t\treturn ErrMissingRepoURL{}"},{"line_number":187,"context_line":"\t}"},{"line_number":188,"context_line":"\tpossibleValues :\u003d []string{o.CommitHash, o.Branch, o.Tag}"}],"source_content_type":"text/x-go","patch_set":48,"id":"ff570b3c_04a69754","line":185,"in_reply_to":"ff570b3c_c1f2d1e3","updated":"2020-06-08 14:50:44.000000000","message":"Done","commit_id":"ee10dc3e6871e454eb7867199c9786735bb73638"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"2f5cceb6abb9390cbbfac5a732fb0d77fda0e3e4","unresolved":false,"context_lines":[{"line_number":195,"context_line":"\tif count \u003e 1 {"},{"line_number":196,"context_line":"\t\treturn ErrMutuallyExclusiveCheckout{}"},{"line_number":197,"context_line":"\t}"},{"line_number":198,"context_line":"\tif o.RepoName !\u003d \"\" \u0026\u0026 o.URL !\u003d \"\" \u0026\u0026 count \u003d\u003d 0 {"},{"line_number":199,"context_line":"\t\treturn ErrMissingRepoCheckoutOptions{}"},{"line_number":200,"context_line":"\t}"},{"line_number":201,"context_line":"\treturn nil"}],"source_content_type":"text/x-go","patch_set":48,"id":"ff570b3c_01fde9b0","line":198,"updated":"2020-06-08 14:07:33.000000000","message":"ditto for comments","commit_id":"ee10dc3e6871e454eb7867199c9786735bb73638"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"568bd700b1f23dc416f0d68879025a3dbe6faf39","unresolved":false,"context_lines":[{"line_number":195,"context_line":"\tif count \u003e 1 {"},{"line_number":196,"context_line":"\t\treturn ErrMutuallyExclusiveCheckout{}"},{"line_number":197,"context_line":"\t}"},{"line_number":198,"context_line":"\tif o.RepoName !\u003d \"\" \u0026\u0026 o.URL !\u003d \"\" \u0026\u0026 count \u003d\u003d 0 {"},{"line_number":199,"context_line":"\t\treturn ErrMissingRepoCheckoutOptions{}"},{"line_number":200,"context_line":"\t}"},{"line_number":201,"context_line":"\treturn nil"}],"source_content_type":"text/x-go","patch_set":48,"id":"ff570b3c_6460330f","line":198,"in_reply_to":"ff570b3c_01fde9b0","updated":"2020-06-08 14:50:44.000000000","message":"Done","commit_id":"ee10dc3e6871e454eb7867199c9786735bb73638"}],"pkg/config/utils.go":[{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"2f5cceb6abb9390cbbfac5a732fb0d77fda0e3e4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"const ("},{"line_number":24,"context_line":"\t// DefaultTestPrimaryRepo holds default repo name"},{"line_number":25,"context_line":"\tDefaultTestPrimaryRepo \u003d \"primary\""},{"line_number":26,"context_line":"\t// DefaultTargetPath holds default target path"},{"line_number":27,"context_line":"\tDefaultTargetPath \u003d \"/tmp/default\""},{"line_number":28,"context_line":"\t// DefaultSubPath holds default sub path"},{"line_number":29,"context_line":"\tDefaultSubPath \u003d \"manifest/default\""}],"source_content_type":"text/x-go","patch_set":48,"id":"ff570b3c_011689f2","line":26,"updated":"2020-06-08 14:07:33.000000000","message":"nit: I think you don\u0027t have to document each constants. If you can have a generic comment for the constants, that should suppress the lint warning. Good to check, I might be wrong","commit_id":"ee10dc3e6871e454eb7867199c9786735bb73638"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"dcf1bab978d180a4fa25465955cf61e52ca3e6c0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\t\"encoding/base64\""},{"line_number":21,"context_line":")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"const ("},{"line_number":24,"context_line":"\t// DefaultTestPrimaryRepo holds default repo name"},{"line_number":25,"context_line":"\tDefaultTestPrimaryRepo \u003d \"primary\""},{"line_number":26,"context_line":"\t// DefaultTargetPath holds default target path"},{"line_number":27,"context_line":"\tDefaultTargetPath \u003d \"/tmp/default\""},{"line_number":28,"context_line":"\t// DefaultSubPath holds default sub path"},{"line_number":29,"context_line":"\tDefaultSubPath \u003d \"manifest/default\""},{"line_number":30,"context_line":")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"// NewConfig returns a newly initialized Config object"},{"line_number":33,"context_line":"func NewConfig() *Config {"}],"source_content_type":"text/x-go","patch_set":54,"id":"ff570b3c_c5ce0e5a","line":30,"range":{"start_line":23,"start_character":0,"end_line":30,"end_character":1},"updated":"2020-06-11 22:02:28.000000000","message":"Could you move all of these to pkg/config/constants.go?","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"f55b1ef65d00998992e923c301fbd47d0e1df702","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\t\"encoding/base64\""},{"line_number":21,"context_line":")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"const ("},{"line_number":24,"context_line":"\t// DefaultTestPrimaryRepo holds default repo name"},{"line_number":25,"context_line":"\tDefaultTestPrimaryRepo \u003d \"primary\""},{"line_number":26,"context_line":"\t// DefaultTargetPath holds default target path"},{"line_number":27,"context_line":"\tDefaultTargetPath \u003d \"/tmp/default\""},{"line_number":28,"context_line":"\t// DefaultSubPath holds default sub path"},{"line_number":29,"context_line":"\tDefaultSubPath \u003d \"manifest/default\""},{"line_number":30,"context_line":")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"// NewConfig returns a newly initialized Config object"},{"line_number":33,"context_line":"func NewConfig() *Config {"}],"source_content_type":"text/x-go","patch_set":54,"id":"bf51134e_25ea600e","line":30,"range":{"start_line":23,"start_character":0,"end_line":30,"end_character":1},"in_reply_to":"ff570b3c_c5ce0e5a","updated":"2020-06-18 20:33:25.000000000","message":"Done","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"}],"testutil/testconfig.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"dcf1bab978d180a4fa25465955cf61e52ca3e6c0","unresolved":false,"context_lines":[{"line_number":267,"context_line":"// DummyManifestOptions creates ManifestOptions config object"},{"line_number":268,"context_line":"// for unit testing"},{"line_number":269,"context_line":"func DummyManifestOptions() *config.ManifestOptions {"},{"line_number":270,"context_line":"\tmo :\u003d \u0026config.ManifestOptions{}"},{"line_number":271,"context_line":"\tmo.Name \u003d \"dummy_manifest\""},{"line_number":272,"context_line":"\tmo.SubPath \u003d \"manifests/dummy_site\""},{"line_number":273,"context_line":"\tmo.TargetPath \u003d \"/tmp/dummy_site\""},{"line_number":274,"context_line":"\tmo.IsPrimary \u003d true"},{"line_number":275,"context_line":"\tmo.RepoName \u003d \"dummy_repo\""},{"line_number":276,"context_line":"\tmo.URL \u003d \"https://github.com/treasuremap/dummy_site\""},{"line_number":277,"context_line":"\tmo.Branch \u003d \"master\""},{"line_number":278,"context_line":"\tmo.Force \u003d true"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"\treturn mo"},{"line_number":281,"context_line":"}"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"const ("}],"source_content_type":"text/x-go","patch_set":54,"id":"ff570b3c_4504be7e","line":280,"range":{"start_line":270,"start_character":0,"end_line":280,"end_character":10},"updated":"2020-06-11 22:02:28.000000000","message":"clean this up with a struct literal:\n\n\treturn \u0026config.ManifestOptions{\n\t\tName:       \"dummy_manifest\",\n\t\tSubPath:    \"manifests/dummy_site\",\n\t\tTargetPath: \"/tmp/dummy_site\",\n\t\tIsPrimary:  true,\n\t\tRepoName:   \"dummy_repo\",\n\t\tURL:        \"https://github.com/treasuremap/dummy_site\",\n\t\tBranch:     \"master\",\n\t\tForce:      true,\n\t}","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"f55b1ef65d00998992e923c301fbd47d0e1df702","unresolved":false,"context_lines":[{"line_number":267,"context_line":"// DummyManifestOptions creates ManifestOptions config object"},{"line_number":268,"context_line":"// for unit testing"},{"line_number":269,"context_line":"func DummyManifestOptions() *config.ManifestOptions {"},{"line_number":270,"context_line":"\tmo :\u003d \u0026config.ManifestOptions{}"},{"line_number":271,"context_line":"\tmo.Name \u003d \"dummy_manifest\""},{"line_number":272,"context_line":"\tmo.SubPath \u003d \"manifests/dummy_site\""},{"line_number":273,"context_line":"\tmo.TargetPath \u003d \"/tmp/dummy_site\""},{"line_number":274,"context_line":"\tmo.IsPrimary \u003d true"},{"line_number":275,"context_line":"\tmo.RepoName \u003d \"dummy_repo\""},{"line_number":276,"context_line":"\tmo.URL \u003d \"https://github.com/treasuremap/dummy_site\""},{"line_number":277,"context_line":"\tmo.Branch \u003d \"master\""},{"line_number":278,"context_line":"\tmo.Force \u003d true"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"\treturn mo"},{"line_number":281,"context_line":"}"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"const ("}],"source_content_type":"text/x-go","patch_set":54,"id":"bf51134e_65f458f3","line":280,"range":{"start_line":270,"start_character":0,"end_line":280,"end_character":10},"in_reply_to":"ff570b3c_4504be7e","updated":"2020-06-18 20:33:25.000000000","message":"Done","commit_id":"c9bbf5f511af9925bbb0ee39585f1c27ed087ee2"}]}