)]}'
{"pkg/config/config.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"490e93fcf4cb80b3f29abd6e84fa9da46d4865e4","unresolved":false,"context_lines":[{"line_number":520,"context_line":"}"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"// GetContext returns a context instance"},{"line_number":523,"context_line":"// Context Operations from Config point of view"},{"line_number":524,"context_line":"func (c *Config) GetContext(cName string) (*Context, error) {"},{"line_number":525,"context_line":"\tcontext, exists :\u003d c.Contexts[cName]"},{"line_number":526,"context_line":"\tif !exists {"}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_59bb5ec3","line":523,"range":{"start_line":523,"start_character":0,"end_line":523,"end_character":47},"updated":"2020-04-03 22:25:52.000000000","message":"I believe this line was meant to be some sort of divider - it doesn\u0027t seem very useful though, would you mind removing it?","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"f338beb42a90a2b486b9a4691237b6b71f7687a0","unresolved":false,"context_lines":[{"line_number":520,"context_line":"}"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"// GetContext returns a context instance"},{"line_number":523,"context_line":"// Context Operations from Config point of view"},{"line_number":524,"context_line":"func (c *Config) GetContext(cName string) (*Context, error) {"},{"line_number":525,"context_line":"\tcontext, exists :\u003d c.Contexts[cName]"},{"line_number":526,"context_line":"\tif !exists {"}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_d0ee018a","line":523,"range":{"start_line":523,"start_character":0,"end_line":523,"end_character":47},"in_reply_to":"df33271e_59bb5ec3","updated":"2020-04-06 13:56:27.000000000","message":"Done","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"}],"pkg/config/constants.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"490e93fcf4cb80b3f29abd6e84fa9da46d4865e4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\tInitinfra \u003d \"initinfra\""},{"line_number":14,"context_line":")"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"// AllClusterTypes , holds cluster types"},{"line_number":17,"context_line":"var AllClusterTypes \u003d [2]string{Ephemeral, Target}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"// Constants defining default values"}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_d9c64e4a","line":16,"range":{"start_line":16,"start_character":18,"end_line":16,"end_character":20},"updated":"2020-04-03 22:25:52.000000000","message":"remove this","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"f338beb42a90a2b486b9a4691237b6b71f7687a0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\tInitinfra \u003d \"initinfra\""},{"line_number":14,"context_line":")"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"// AllClusterTypes , holds cluster types"},{"line_number":17,"context_line":"var AllClusterTypes \u003d [2]string{Ephemeral, Target}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"// Constants defining default values"}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_10e9897f","line":16,"range":{"start_line":16,"start_character":18,"end_line":16,"end_character":20},"in_reply_to":"df33271e_d9c64e4a","updated":"2020-04-06 13:56:27.000000000","message":"Done","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"}],"pkg/config/errors.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"490e93fcf4cb80b3f29abd6e84fa9da46d4865e4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"\t\"strings\""},{"line_number":6,"context_line":")"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"// Repo errors"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"// ErrMutuallyExclusiveAuthSSHPass is returned when ssh-pass type"},{"line_number":11,"context_line":"// is selected and http-pass, ssh-key or key-pass options are defined"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"// ErrIncompatibleAuthOptions is returned when incompatible AuthType is provided"},{"line_number":14,"context_line":"type ErrIncompatibleAuthOptions struct {"}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_f9ceb259","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":69},"updated":"2020-04-03 22:25:52.000000000","message":"All of this can be removed","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"f338beb42a90a2b486b9a4691237b6b71f7687a0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"\t\"strings\""},{"line_number":6,"context_line":")"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"// Repo errors"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"// ErrMutuallyExclusiveAuthSSHPass is returned when ssh-pass type"},{"line_number":11,"context_line":"// is selected and http-pass, ssh-key or key-pass options are defined"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"// ErrIncompatibleAuthOptions is returned when incompatible AuthType is provided"},{"line_number":14,"context_line":"type ErrIncompatibleAuthOptions struct {"}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_f0ed058c","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":69},"in_reply_to":"df33271e_f9ceb259","updated":"2020-04-06 13:56:27.000000000","message":"Done","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"490e93fcf4cb80b3f29abd6e84fa9da46d4865e4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"// ErrMutuallyExclusiveAuthSSHPass is returned when ssh-pass type"},{"line_number":11,"context_line":"// is selected and http-pass, ssh-key or key-pass options are defined"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"// ErrIncompatibleAuthOptions is returned when incompatible AuthType is provided"},{"line_number":14,"context_line":"type ErrIncompatibleAuthOptions struct {"},{"line_number":15,"context_line":"\tForbiddenOptions []string"},{"line_number":16,"context_line":"\tAuthType         string"}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_39d93a22","line":13,"range":{"start_line":13,"start_character":60,"end_line":13,"end_character":71},"updated":"2020-04-03 22:25:52.000000000","message":"AuthTypes are","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"f338beb42a90a2b486b9a4691237b6b71f7687a0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"// ErrMutuallyExclusiveAuthSSHPass is returned when ssh-pass type"},{"line_number":11,"context_line":"// is selected and http-pass, ssh-key or key-pass options are defined"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"// ErrIncompatibleAuthOptions is returned when incompatible AuthType is provided"},{"line_number":14,"context_line":"type ErrIncompatibleAuthOptions struct {"},{"line_number":15,"context_line":"\tForbiddenOptions []string"},{"line_number":16,"context_line":"\tAuthType         string"}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_5002f13f","line":13,"range":{"start_line":13,"start_character":60,"end_line":13,"end_character":71},"in_reply_to":"df33271e_39d93a22","updated":"2020-04-06 13:56:27.000000000","message":"Done","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"f63744d91b205b9501298ea326ebe34956d00526","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"// Repo errors"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"// ErrMutuallyExclusiveAuthSSHPass is returned when ssh-pass type"},{"line_number":11,"context_line":"// is selected and http-pass, ssh-key or key-pass options are defined"},{"line_number":12,"context_line":"type ErrIncompatibleAuthOptions struct {"},{"line_number":13,"context_line":"\tForbiddenOptions []string"},{"line_number":14,"context_line":"\tAuthType         string"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_8b49e861","side":"PARENT","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":69},"updated":"2020-04-06 14:18:34.000000000","message":"It looks like this one was just separated from the error on L24. Could we move this down there?","commit_id":"b4b792a04fcb050e2844cbf3bc60538f390106cc"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"// Repo errors"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"// ErrMutuallyExclusiveAuthSSHPass is returned when ssh-pass type"},{"line_number":11,"context_line":"// is selected and http-pass, ssh-key or key-pass options are defined"},{"line_number":12,"context_line":"type ErrIncompatibleAuthOptions struct {"},{"line_number":13,"context_line":"\tForbiddenOptions []string"},{"line_number":14,"context_line":"\tAuthType         string"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_65b76c88","side":"PARENT","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":69},"in_reply_to":"df33271e_8b49e861","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"b4b792a04fcb050e2844cbf3bc60538f390106cc"}],"pkg/config/types.go":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"f63744d91b205b9501298ea326ebe34956d00526","unresolved":false,"context_lines":[{"line_number":86,"context_line":"\tBootstrap string `json:\"bootstrap-info\"`"},{"line_number":87,"context_line":"}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"// Modules is generic configuration for modules"},{"line_number":90,"context_line":"// Configuration that the Bootstrap Module would need"},{"line_number":91,"context_line":"// Configuration that the Document Module would need"},{"line_number":92,"context_line":"// Configuration that the Workflows Module would need"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_8bbe08fd","line":89,"range":{"start_line":89,"start_character":11,"end_line":89,"end_character":47},"updated":"2020-04-06 14:18:34.000000000","message":"is a*\n\nor something like\n\n\"Modules encapsulates all module configurations\"","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":86,"context_line":"\tBootstrap string `json:\"bootstrap-info\"`"},{"line_number":87,"context_line":"}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"// Modules is generic configuration for modules"},{"line_number":90,"context_line":"// Configuration that the Bootstrap Module would need"},{"line_number":91,"context_line":"// Configuration that the Document Module would need"},{"line_number":92,"context_line":"// Configuration that the Workflows Module would need"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_45bce868","line":89,"range":{"start_line":89,"start_character":11,"end_line":89,"end_character":47},"in_reply_to":"df33271e_8bbe08fd","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"}],"pkg/document/constants.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"490e93fcf4cb80b3f29abd6e84fa9da46d4865e4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"package document"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"const ("},{"line_number":4,"context_line":"\t// Label Selectors"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"\t// BaseAirshipSelector holds airship URL"},{"line_number":7,"context_line":"\tBaseAirshipSelector       \u003d \"airshipit.org\""}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_792902f1","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":19},"updated":"2020-04-03 22:25:52.000000000","message":"If I\u0027m not mistaken, you should be able to lift this line above the `const (`, and it should fix the linting issues here. That would remove the need for documenting each individual label selector (they\u0027re names should be self-documenting)","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"f338beb42a90a2b486b9a4691237b6b71f7687a0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"package document"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"const ("},{"line_number":4,"context_line":"\t// Label Selectors"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"\t// BaseAirshipSelector holds airship URL"},{"line_number":7,"context_line":"\tBaseAirshipSelector       \u003d \"airshipit.org\""}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_d093a1ff","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":19},"in_reply_to":"df33271e_792902f1","updated":"2020-04-06 13:56:27.000000000","message":"Done","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"490e93fcf4cb80b3f29abd6e84fa9da46d4865e4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\tEphemeralUserDataSelector \u003d BaseAirshipSelector + \"/ephemeral-user-data in (True, true)\""},{"line_number":10,"context_line":"\tInitInfraSelector         \u003d BaseAirshipSelector + \"/phase \u003d initinfra\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\t// Annotation Selectors"},{"line_number":13,"context_line":"\t// Please note that by default every document in the manifest is to be deployed to kubernetes cluster."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\t// DeployToK8sSelector simply checks that deploy-k8s label is not equal to true or True (string)"},{"line_number":16,"context_line":"\tDeployToK8sSelector \u003d \"config.kubernetes.io/local-config notin (True, true)\""},{"line_number":17,"context_line":")"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"// Kinds"},{"line_number":20,"context_line":"const ("}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_5917dea4","line":17,"range":{"start_line":12,"start_character":0,"end_line":17,"end_character":1},"updated":"2020-04-03 22:25:52.000000000","message":"Change this whole section:\n\n  // Annotation Selectors\n  const (\n    // DeployToK8sSelector checks that the deploy-k8s label is not equal to true or True (string)\n    // Please note that by default every document in the manifest is to be deployed to kubernetes cluster.\n    DeployToK8sSelector \u003d \"config.kubernetes.io/local-config notin (True, true)\"\n  )","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"f338beb42a90a2b486b9a4691237b6b71f7687a0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\tEphemeralUserDataSelector \u003d BaseAirshipSelector + \"/ephemeral-user-data in (True, true)\""},{"line_number":10,"context_line":"\tInitInfraSelector         \u003d BaseAirshipSelector + \"/phase \u003d initinfra\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\t// Annotation Selectors"},{"line_number":13,"context_line":"\t// Please note that by default every document in the manifest is to be deployed to kubernetes cluster."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\t// DeployToK8sSelector simply checks that deploy-k8s label is not equal to true or True (string)"},{"line_number":16,"context_line":"\tDeployToK8sSelector \u003d \"config.kubernetes.io/local-config notin (True, true)\""},{"line_number":17,"context_line":")"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"// Kinds"},{"line_number":20,"context_line":"const ("}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_b0989d1b","line":17,"range":{"start_line":12,"start_character":0,"end_line":17,"end_character":1},"in_reply_to":"df33271e_5917dea4","updated":"2020-04-06 13:56:27.000000000","message":"\u003e Change this whole section:\n \u003e \n \u003e // Annotation Selectors\n \u003e const (\n \u003e // DeployToK8sSelector checks that the deploy-k8s label is not\n \u003e equal to true or True (string)\n \u003e // Please note that by default every document in the manifest is to\n \u003e be deployed to kubernetes cluster.\n \u003e DeployToK8sSelector \u003d \"config.kubernetes.io/local-config notin\n \u003e (True, true)\"\n \u003e )\nThanks. it worked","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"38eaa00d730dfcab6df4a8c6e78bc54e1d17b1e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"df33271e_4b26bfb9","updated":"2020-04-06 14:42:40.000000000","message":"I wasn\u0027t particularly clear here with my last comment, sorry.\n\nThe changed section here has constants for label selectors and for annotations selectors. I think we should create a const block for each.\n\n  // Label Selectors\n  const (\n    Put all of the label selectors here\n  )\n\n  // Annotation Selectors\n  const (\n    Put all of the annotations selectors here\n  )","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"df33271e_656c8c08","in_reply_to":"df33271e_4b26bfb9","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"12c98a22dfb03ea399d04e483d75df3a4150baba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"df33271e_d4b43038","in_reply_to":"df33271e_4b26bfb9","updated":"2020-04-06 16:34:40.000000000","message":"Ignore this - the annotation selector will be changed to a label selector in [0]\n\n[0] https://review.opendev.org/#/c/715571","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"df33271e_e5589c57","in_reply_to":"df33271e_d4b43038","updated":"2020-04-06 19:23:57.000000000","message":"\u003e Ignore this - the annotation selector will be changed to a label\n \u003e selector in [0]\n \u003e \n \u003e [0] https://review.opendev.org/#/c/715571\n\nThanks. Removed annotations and just had label and had everything in Label selector","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"f63744d91b205b9501298ea326ebe34956d00526","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"// Annotation Selectors"},{"line_number":4,"context_line":"// Please note that by default every document in the manifest is to be deployed to kubernetes cluster."},{"line_number":5,"context_line":"// DeployToK8sSelector simply checks that deploy-k8s label is not equal to true or True (string)"},{"line_number":6,"context_line":"const ("},{"line_number":7,"context_line":"\tBaseAirshipSelector       \u003d \"airshipit.org\""},{"line_number":8,"context_line":"\tEphemeralHostSelector     \u003d BaseAirshipSelector + \"/ephemeral-node in (True, true)\""}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_ab3aec94","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":96},"updated":"2020-04-06 14:18:34.000000000","message":"Should this not be on L11?","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"// Annotation Selectors"},{"line_number":4,"context_line":"// Please note that by default every document in the manifest is to be deployed to kubernetes cluster."},{"line_number":5,"context_line":"// DeployToK8sSelector simply checks that deploy-k8s label is not equal to true or True (string)"},{"line_number":6,"context_line":"const ("},{"line_number":7,"context_line":"\tBaseAirshipSelector       \u003d \"airshipit.org\""},{"line_number":8,"context_line":"\tEphemeralHostSelector     \u003d BaseAirshipSelector + \"/ephemeral-node in (True, true)\""}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_c555981f","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":96},"in_reply_to":"df33271e_ab3aec94","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"}],"pkg/remote/redfish/utils.go":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"f63744d91b205b9501298ea326ebe34956d00526","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\tRedfishURLSchemeSeparator \u003d \"+\""},{"line_number":30,"context_line":")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"// GetResourceIDFromURL returns resource ID"},{"line_number":33,"context_line":"// Redfish Id ref is a URI which contains resource Id"},{"line_number":34,"context_line":"// as the last part. This function extracts resource"},{"line_number":35,"context_line":"// ID from ID ref"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_ab630cb1","line":32,"range":{"start_line":32,"start_character":3,"end_line":32,"end_character":43},"updated":"2020-04-06 14:18:34.000000000","message":"I think we should extend this to say \"GetResourceIDFromURL\" returns a parsed Redfish resource ID from the Redfish URL.","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\tRedfishURLSchemeSeparator \u003d \"+\""},{"line_number":30,"context_line":")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"// GetResourceIDFromURL returns resource ID"},{"line_number":33,"context_line":"// Redfish Id ref is a URI which contains resource Id"},{"line_number":34,"context_line":"// as the last part. This function extracts resource"},{"line_number":35,"context_line":"// ID from ID ref"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_2530c407","line":32,"range":{"start_line":32,"start_character":3,"end_line":32,"end_character":43},"in_reply_to":"df33271e_ab630cb1","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"f63744d91b205b9501298ea326ebe34956d00526","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\treturn id"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"// IsIDInList Checks whether an ID exists in Redfish IDref collection"},{"line_number":50,"context_line":"func IsIDInList(idRefList []redfishClient.IdRef, id string) bool {"},{"line_number":51,"context_line":"\tfor _, r :\u003d range idRefList {"},{"line_number":52,"context_line":"\t\trID :\u003d GetResourceIDFromURL(r.OdataId)"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_4b49a030","line":49,"range":{"start_line":49,"start_character":14,"end_line":49,"end_character":15},"updated":"2020-04-06 14:18:34.000000000","message":"lowercase","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\treturn id"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"// IsIDInList Checks whether an ID exists in Redfish IDref collection"},{"line_number":50,"context_line":"func IsIDInList(idRefList []redfishClient.IdRef, id string) bool {"},{"line_number":51,"context_line":"\tfor _, r :\u003d range idRefList {"},{"line_number":52,"context_line":"\t\trID :\u003d GetResourceIDFromURL(r.OdataId)"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_0535c0f7","line":49,"range":{"start_line":49,"start_character":14,"end_line":49,"end_character":15},"in_reply_to":"df33271e_4b49a030","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"}],"testutil/testconfig.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"490e93fcf4cb80b3f29abd6e84fa9da46d4865e4","unresolved":false,"context_lines":[{"line_number":72,"context_line":"\treturn c"},{"line_number":73,"context_line":"}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"// DummyCluster , utility function used for tests"},{"line_number":76,"context_line":"func DummyCluster() *config.Cluster {"},{"line_number":77,"context_line":"\tc :\u003d config.NewCluster()"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_597cfeea","line":75,"range":{"start_line":75,"start_character":3,"end_line":75,"end_character":25},"updated":"2020-04-03 22:25:52.000000000","message":"DummyCluster is a utility...","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"f338beb42a90a2b486b9a4691237b6b71f7687a0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"\treturn c"},{"line_number":73,"context_line":"}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"// DummyCluster , utility function used for tests"},{"line_number":76,"context_line":"func DummyCluster() *config.Cluster {"},{"line_number":77,"context_line":"\tc :\u003d config.NewCluster()"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_f0a2254b","line":75,"range":{"start_line":75,"start_character":3,"end_line":75,"end_character":25},"in_reply_to":"df33271e_597cfeea","updated":"2020-04-06 13:56:27.000000000","message":"Done","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"490e93fcf4cb80b3f29abd6e84fa9da46d4865e4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"\treturn m"},{"line_number":98,"context_line":"}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"// DummyRepository , utility function used for tests"},{"line_number":101,"context_line":"func DummyRepository() *config.Repository {"},{"line_number":102,"context_line":"\treturn \u0026config.Repository{"},{"line_number":103,"context_line":"\t\tURLString: \"http://dummy.url.com/manifests.git\","}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_b981cac6","line":100,"updated":"2020-04-03 22:25:52.000000000","message":"ditto: is a utility","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"f338beb42a90a2b486b9a4691237b6b71f7687a0","unresolved":false,"context_lines":[{"line_number":97,"context_line":"\treturn m"},{"line_number":98,"context_line":"}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"// DummyRepository , utility function used for tests"},{"line_number":101,"context_line":"func DummyRepository() *config.Repository {"},{"line_number":102,"context_line":"\treturn \u0026config.Repository{"},{"line_number":103,"context_line":"\t\tURLString: \"http://dummy.url.com/manifests.git\","}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_508791b7","line":100,"in_reply_to":"df33271e_b981cac6","updated":"2020-04-06 13:56:27.000000000","message":"Done","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"490e93fcf4cb80b3f29abd6e84fa9da46d4865e4","unresolved":false,"context_lines":[{"line_number":120,"context_line":"\t}"},{"line_number":121,"context_line":"}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"// DummyRepoCheckout , utility function used for checks"},{"line_number":124,"context_line":"func DummyRepoCheckout() *config.RepoCheckout {"},{"line_number":125,"context_line":"\treturn \u0026config.RepoCheckout{"},{"line_number":126,"context_line":"\t\tTag:           \"v1.0.1\","}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_998686db","line":123,"updated":"2020-04-03 22:25:52.000000000","message":"ditto: is a utility","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"f338beb42a90a2b486b9a4691237b6b71f7687a0","unresolved":false,"context_lines":[{"line_number":120,"context_line":"\t}"},{"line_number":121,"context_line":"}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"// DummyRepoCheckout , utility function used for checks"},{"line_number":124,"context_line":"func DummyRepoCheckout() *config.RepoCheckout {"},{"line_number":125,"context_line":"\treturn \u0026config.RepoCheckout{"},{"line_number":126,"context_line":"\t\tTag:           \"v1.0.1\","}],"source_content_type":"text/x-go","patch_set":2,"id":"df33271e_708e15d1","line":123,"in_reply_to":"df33271e_998686db","updated":"2020-04-06 13:56:27.000000000","message":"Done","commit_id":"abd973400363b155b96b75507d9f8af926cbd95c"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"38eaa00d730dfcab6df4a8c6e78bc54e1d17b1e6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"\treturn conf"},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"// DummyContext , utility function used for tests"},{"line_number":62,"context_line":"func DummyContext() *config.Context {"},{"line_number":63,"context_line":"\tc :\u003d config.NewContext()"},{"line_number":64,"context_line":"\tc.NameInKubeconf \u003d \"dummy_cluster_ephemeral\""}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_ab682bba","line":61,"updated":"2020-04-06 14:42:40.000000000","message":"ditto: add more context as per Drew\u0027s comment","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":58,"context_line":"\treturn conf"},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"// DummyContext , utility function used for tests"},{"line_number":62,"context_line":"func DummyContext() *config.Context {"},{"line_number":63,"context_line":"\tc :\u003d config.NewContext()"},{"line_number":64,"context_line":"\tc.NameInKubeconf \u003d \"dummy_cluster_ephemeral\""}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_a52334be","line":61,"in_reply_to":"df33271e_ab682bba","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"f63744d91b205b9501298ea326ebe34956d00526","unresolved":false,"context_lines":[{"line_number":72,"context_line":"\treturn c"},{"line_number":73,"context_line":"}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"// DummyCluster is a utility"},{"line_number":76,"context_line":"func DummyCluster() *config.Cluster {"},{"line_number":77,"context_line":"\tc :\u003d config.NewCluster()"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_0b279866","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":28},"updated":"2020-04-06 14:18:34.000000000","message":"I didn\u0027t get any more clarity about what this function does from this comment. I\u0027d prefer to have a lint warning over a comment that checks a box. Something more descriptive would be:\n\n\"DummyCluster creates a cluster config object for unit testing.\"","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":72,"context_line":"\treturn c"},{"line_number":73,"context_line":"}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"// DummyCluster is a utility"},{"line_number":76,"context_line":"func DummyCluster() *config.Cluster {"},{"line_number":77,"context_line":"\tc :\u003d config.NewCluster()"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_8520b0b2","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":28},"in_reply_to":"df33271e_0b279866","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"38eaa00d730dfcab6df4a8c6e78bc54e1d17b1e6","unresolved":false,"context_lines":[{"line_number":86,"context_line":"\treturn c"},{"line_number":87,"context_line":"}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"// DummyManifest , utility function used for tests"},{"line_number":90,"context_line":"func DummyManifest() *config.Manifest {"},{"line_number":91,"context_line":"\tm :\u003d config.NewManifest()"},{"line_number":92,"context_line":"\t// Repositories is the map of repository adddressable by a name"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_0b7af786","line":89,"updated":"2020-04-06 14:42:40.000000000","message":"ditto: add more context as per Drew\u0027s comment above","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":86,"context_line":"\treturn c"},{"line_number":87,"context_line":"}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"// DummyManifest , utility function used for tests"},{"line_number":90,"context_line":"func DummyManifest() *config.Manifest {"},{"line_number":91,"context_line":"\tm :\u003d config.NewManifest()"},{"line_number":92,"context_line":"\t// Repositories is the map of repository adddressable by a name"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_e52d3ca9","line":89,"in_reply_to":"df33271e_0b7af786","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"f63744d91b205b9501298ea326ebe34956d00526","unresolved":false,"context_lines":[{"line_number":97,"context_line":"\treturn m"},{"line_number":98,"context_line":"}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"// DummyRepository is a utility"},{"line_number":101,"context_line":"func DummyRepository() *config.Repository {"},{"line_number":102,"context_line":"\treturn \u0026config.Repository{"},{"line_number":103,"context_line":"\t\tURLString: \"http://dummy.url.com/manifests.git\","}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_0bdcb844","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":31},"updated":"2020-04-06 14:18:34.000000000","message":"Same here","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":97,"context_line":"\treturn m"},{"line_number":98,"context_line":"}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"// DummyRepository is a utility"},{"line_number":101,"context_line":"func DummyRepository() *config.Repository {"},{"line_number":102,"context_line":"\treturn \u0026config.Repository{"},{"line_number":103,"context_line":"\t\tURLString: \"http://dummy.url.com/manifests.git\","}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_c52ab88e","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":31},"in_reply_to":"df33271e_0bdcb844","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"38eaa00d730dfcab6df4a8c6e78bc54e1d17b1e6","unresolved":false,"context_lines":[{"line_number":112,"context_line":"\t}"},{"line_number":113,"context_line":"}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"// DummyRepoAuth , utility function used for tests"},{"line_number":116,"context_line":"func DummyRepoAuth() *config.RepoAuth {"},{"line_number":117,"context_line":"\treturn \u0026config.RepoAuth{"},{"line_number":118,"context_line":"\t\tType:    \"ssh-key\","}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_8b6567e4","line":115,"updated":"2020-04-06 14:42:40.000000000","message":"ditto: add more context as per Drew\u0027s comment","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":112,"context_line":"\t}"},{"line_number":113,"context_line":"}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"// DummyRepoAuth , utility function used for tests"},{"line_number":116,"context_line":"func DummyRepoAuth() *config.RepoAuth {"},{"line_number":117,"context_line":"\treturn \u0026config.RepoAuth{"},{"line_number":118,"context_line":"\t\tType:    \"ssh-key\","}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_2519e487","line":115,"in_reply_to":"df33271e_8b6567e4","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"f63744d91b205b9501298ea326ebe34956d00526","unresolved":false,"context_lines":[{"line_number":120,"context_line":"\t}"},{"line_number":121,"context_line":"}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"// DummyRepoCheckout is a utility"},{"line_number":124,"context_line":"func DummyRepoCheckout() *config.RepoCheckout {"},{"line_number":125,"context_line":"\treturn \u0026config.RepoCheckout{"},{"line_number":126,"context_line":"\t\tTag:           \"v1.0.1\","}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_ebe074fd","line":123,"range":{"start_line":123,"start_character":0,"end_line":123,"end_character":33},"updated":"2020-04-06 14:18:34.000000000","message":"Same","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":120,"context_line":"\t}"},{"line_number":121,"context_line":"}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"// DummyRepoCheckout is a utility"},{"line_number":124,"context_line":"func DummyRepoCheckout() *config.RepoCheckout {"},{"line_number":125,"context_line":"\treturn \u0026config.RepoCheckout{"},{"line_number":126,"context_line":"\t\tTag:           \"v1.0.1\","}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_051e606f","line":123,"range":{"start_line":123,"start_character":0,"end_line":123,"end_character":33},"in_reply_to":"df33271e_ebe074fd","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"38eaa00d730dfcab6df4a8c6e78bc54e1d17b1e6","unresolved":false,"context_lines":[{"line_number":128,"context_line":"\t}"},{"line_number":129,"context_line":"}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"// DummyAuthInfo , utility function used for tests"},{"line_number":132,"context_line":"func DummyAuthInfo() *config.AuthInfo {"},{"line_number":133,"context_line":"\ta :\u003d config.NewAuthInfo()"},{"line_number":134,"context_line":"\tauthinfo :\u003d kubeconfig.NewAuthInfo()"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_cb5f6f0c","line":131,"updated":"2020-04-06 14:42:40.000000000","message":"ditto: add more context as per Drew\u0027s comment","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":128,"context_line":"\t}"},{"line_number":129,"context_line":"}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"// DummyAuthInfo , utility function used for tests"},{"line_number":132,"context_line":"func DummyAuthInfo() *config.AuthInfo {"},{"line_number":133,"context_line":"\ta :\u003d config.NewAuthInfo()"},{"line_number":134,"context_line":"\tauthinfo :\u003d kubeconfig.NewAuthInfo()"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_6513ec67","line":131,"in_reply_to":"df33271e_cb5f6f0c","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"38eaa00d730dfcab6df4a8c6e78bc54e1d17b1e6","unresolved":false,"context_lines":[{"line_number":141,"context_line":"\treturn a"},{"line_number":142,"context_line":"}"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"// DummyKubeAuthInfo , utility function used for tests"},{"line_number":145,"context_line":"func DummyKubeAuthInfo() *kubeconfig.AuthInfo {"},{"line_number":146,"context_line":"\tauthinfo :\u003d kubeconfig.NewAuthInfo()"},{"line_number":147,"context_line":"\tauthinfo.Username \u003d \"dummy_username\""}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_2b9a5bc4","line":144,"updated":"2020-04-06 14:42:40.000000000","message":"ditto: add more context as per Drew\u0027s comment","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":141,"context_line":"\treturn a"},{"line_number":142,"context_line":"}"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"// DummyKubeAuthInfo , utility function used for tests"},{"line_number":145,"context_line":"func DummyKubeAuthInfo() *kubeconfig.AuthInfo {"},{"line_number":146,"context_line":"\tauthinfo :\u003d kubeconfig.NewAuthInfo()"},{"line_number":147,"context_line":"\tauthinfo.Username \u003d \"dummy_username\""}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_45186880","line":144,"in_reply_to":"df33271e_2b9a5bc4","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"38eaa00d730dfcab6df4a8c6e78bc54e1d17b1e6","unresolved":false,"context_lines":[{"line_number":152,"context_line":"\treturn authinfo"},{"line_number":153,"context_line":"}"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"// DummyModules , utility function used for tests"},{"line_number":156,"context_line":"func DummyModules() *config.Modules {"},{"line_number":157,"context_line":"\tm :\u003d config.NewModules()"},{"line_number":158,"context_line":"\tm.BootstrapInfo[\"dummy_bootstrap_config\"] \u003d DummyBootstrap()"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_6ba46309","line":155,"updated":"2020-04-06 14:42:40.000000000","message":"ditto: add more context as per Drew\u0027s comment","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":152,"context_line":"\treturn authinfo"},{"line_number":153,"context_line":"}"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"// DummyModules , utility function used for tests"},{"line_number":156,"context_line":"func DummyModules() *config.Modules {"},{"line_number":157,"context_line":"\tm :\u003d config.NewModules()"},{"line_number":158,"context_line":"\tm.BootstrapInfo[\"dummy_bootstrap_config\"] \u003d DummyBootstrap()"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_a50cd442","line":155,"in_reply_to":"df33271e_6ba46309","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"38eaa00d730dfcab6df4a8c6e78bc54e1d17b1e6","unresolved":false,"context_lines":[{"line_number":159,"context_line":"\treturn m"},{"line_number":160,"context_line":"}"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"// DummyClusterPurpose , utility function used for tests"},{"line_number":163,"context_line":"func DummyClusterPurpose() *config.ClusterPurpose {"},{"line_number":164,"context_line":"\tcp :\u003d config.NewClusterPurpose()"},{"line_number":165,"context_line":"\tcp.ClusterTypes[\"ephemeral\"] \u003d DummyCluster()"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_abadcbeb","line":162,"updated":"2020-04-06 14:42:40.000000000","message":"ditto: add more context as per Drew\u0027s comment","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":159,"context_line":"\treturn m"},{"line_number":160,"context_line":"}"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"// DummyClusterPurpose , utility function used for tests"},{"line_number":163,"context_line":"func DummyClusterPurpose() *config.ClusterPurpose {"},{"line_number":164,"context_line":"\tcp :\u003d config.NewClusterPurpose()"},{"line_number":165,"context_line":"\tcp.ClusterTypes[\"ephemeral\"] \u003d DummyCluster()"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_e506dc20","line":162,"in_reply_to":"df33271e_abadcbeb","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"38eaa00d730dfcab6df4a8c6e78bc54e1d17b1e6","unresolved":false,"context_lines":[{"line_number":193,"context_line":"\treturn conf, cleanup"},{"line_number":194,"context_line":"}"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"func DummyClusterOptions() *config.ClusterOptions {"},{"line_number":197,"context_line":"\tco :\u003d \u0026config.ClusterOptions{}"},{"line_number":198,"context_line":"\tco.Name \u003d \"dummy_cluster\""},{"line_number":199,"context_line":"\tco.ClusterType \u003d config.Ephemeral"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_ebb7d339","line":196,"updated":"2020-04-06 14:42:40.000000000","message":"ditto: add more context as per Drew\u0027s comment","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":193,"context_line":"\treturn conf, cleanup"},{"line_number":194,"context_line":"}"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"func DummyClusterOptions() *config.ClusterOptions {"},{"line_number":197,"context_line":"\tco :\u003d \u0026config.ClusterOptions{}"},{"line_number":198,"context_line":"\tco.Name \u003d \"dummy_cluster\""},{"line_number":199,"context_line":"\tco.ClusterType \u003d config.Ephemeral"}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_c503d80e","line":196,"in_reply_to":"df33271e_ebb7d339","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"38eaa00d730dfcab6df4a8c6e78bc54e1d17b1e6","unresolved":false,"context_lines":[{"line_number":205,"context_line":"\treturn co"},{"line_number":206,"context_line":"}"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"func DummyContextOptions() *config.ContextOptions {"},{"line_number":209,"context_line":"\tco :\u003d \u0026config.ContextOptions{}"},{"line_number":210,"context_line":"\tco.Name \u003d \"dummy_context\""},{"line_number":211,"context_line":"\tco.Manifest \u003d \"dummy_manifest\""}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_2b837b58","line":208,"updated":"2020-04-06 14:42:40.000000000","message":"ditto: add more context as per Drew\u0027s comment","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":205,"context_line":"\treturn co"},{"line_number":206,"context_line":"}"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"func DummyContextOptions() *config.ContextOptions {"},{"line_number":209,"context_line":"\tco :\u003d \u0026config.ContextOptions{}"},{"line_number":210,"context_line":"\tco.Name \u003d \"dummy_context\""},{"line_number":211,"context_line":"\tco.Manifest \u003d \"dummy_manifest\""}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_20fef204","line":208,"in_reply_to":"df33271e_2b837b58","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"38eaa00d730dfcab6df4a8c6e78bc54e1d17b1e6","unresolved":false,"context_lines":[{"line_number":216,"context_line":"\treturn co"},{"line_number":217,"context_line":"}"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"func DummyAuthInfoOptions() *config.AuthInfoOptions {"},{"line_number":220,"context_line":"\tauthinfo :\u003d \u0026config.AuthInfoOptions{}"},{"line_number":221,"context_line":"\tauthinfo.Username \u003d \"dummy_username\""},{"line_number":222,"context_line":"\tauthinfo.Password \u003d \"dummy_password\""}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_0b88376f","line":219,"updated":"2020-04-06 14:42:40.000000000","message":"ditto: add more context as per Drew\u0027s comment","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":216,"context_line":"\treturn co"},{"line_number":217,"context_line":"}"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"func DummyAuthInfoOptions() *config.AuthInfoOptions {"},{"line_number":220,"context_line":"\tauthinfo :\u003d \u0026config.AuthInfoOptions{}"},{"line_number":221,"context_line":"\tauthinfo.Username \u003d \"dummy_username\""},{"line_number":222,"context_line":"\tauthinfo.Password \u003d \"dummy_password\""}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_0003ee0e","line":219,"in_reply_to":"df33271e_0b88376f","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"38eaa00d730dfcab6df4a8c6e78bc54e1d17b1e6","unresolved":false,"context_lines":[{"line_number":226,"context_line":"\treturn authinfo"},{"line_number":227,"context_line":"}"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"func DummyBootstrap() *config.Bootstrap {"},{"line_number":230,"context_line":"\tbs :\u003d \u0026config.Bootstrap{}"},{"line_number":231,"context_line":"\tcont :\u003d config.Container{"},{"line_number":232,"context_line":"\t\tVolume:           \"/dummy:dummy\","}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_4b823f51","line":229,"updated":"2020-04-06 14:42:40.000000000","message":"ditto: add more context as per Drew\u0027s comment","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"1f6ca37ded1daecd2ae737a427e79319e53c2c83","unresolved":false,"context_lines":[{"line_number":226,"context_line":"\treturn authinfo"},{"line_number":227,"context_line":"}"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"func DummyBootstrap() *config.Bootstrap {"},{"line_number":230,"context_line":"\tbs :\u003d \u0026config.Bootstrap{}"},{"line_number":231,"context_line":"\tcont :\u003d config.Container{"},{"line_number":232,"context_line":"\t\tVolume:           \"/dummy:dummy\","}],"source_content_type":"text/x-go","patch_set":3,"id":"df33271e_6008fa27","line":229,"in_reply_to":"df33271e_4b823f51","updated":"2020-04-06 19:23:57.000000000","message":"Done","commit_id":"4f023ad0728f6c6eeab459e3509b0afe03bf6bd9"}]}