)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"9a48dcc4326d68f65f04fc8f47794a81dfb84564","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexey Odinokov \u003caodinokov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-04-16 04:13:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Substituting ad-hoc sushy-emulator and apache reverse-proxy with apache with sushy-emulator attached via wsgi"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The current implementation of airship-libvirt-gate is using"},{"line_number":10,"context_line":"sushy-emulator binary to emulate redfish. Sushy-emulator works"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"3f4c43b2_62728be5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":109},"updated":"2020-04-17 11:11:13.000000000","message":"Wrap this line according to commit message subject recommendatios","commit_id":"a471d518ad8ab247475153581e9ec7e21f71b025"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"62a33510063a390b31f7b6ccc597bd0a84146810","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexey Odinokov \u003caodinokov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-04-16 04:13:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Substituting ad-hoc sushy-emulator and apache reverse-proxy with apache with sushy-emulator attached via wsgi"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The current implementation of airship-libvirt-gate is using"},{"line_number":10,"context_line":"sushy-emulator binary to emulate redfish. Sushy-emulator works"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"3f4c43b2_2a0fb589","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":109},"in_reply_to":"3f4c43b2_62728be5","updated":"2020-04-17 16:00:55.000000000","message":"Done","commit_id":"a471d518ad8ab247475153581e9ec7e21f71b025"}],"roles/apache-wsgi-sushy-emulator/defaults/main.yml":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"c3e6cf416e2e5b26bb4be81c495c36ccf9d41d1d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        - \"127.0.0.1\""},{"line_number":17,"context_line":"        - \"::1\""},{"line_number":18,"context_line":"sushy_emulator_frontend_servername: \"localhost\""},{"line_number":19,"context_line":"#sushy_emulator_frontend_http_port: 80"},{"line_number":20,"context_line":"#sushy_emulator_frontend_https_port: 443"},{"line_number":21,"context_line":"#sushy_emulator_frontend_user:"},{"line_number":22,"context_line":"#  - username: \"username\""},{"line_number":23,"context_line":"#    password: \"password\""},{"line_number":24,"context_line":"sushy_emulator_frontend_check: true"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3f4c43b2_1e5fcce2","line":23,"range":{"start_line":19,"start_character":0,"end_line":23,"end_character":25},"updated":"2020-04-15 11:13:37.000000000","message":"remove commented lines","commit_id":"1834274eefb3901e2a99f01766388042be642823"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"73e45624b6cb8cc4ca0eb8350635f043d676e716","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        - \"127.0.0.1\""},{"line_number":17,"context_line":"        - \"::1\""},{"line_number":18,"context_line":"sushy_emulator_frontend_servername: \"localhost\""},{"line_number":19,"context_line":"#sushy_emulator_frontend_http_port: 80"},{"line_number":20,"context_line":"#sushy_emulator_frontend_https_port: 443"},{"line_number":21,"context_line":"#sushy_emulator_frontend_user:"},{"line_number":22,"context_line":"#  - username: \"username\""},{"line_number":23,"context_line":"#    password: \"password\""},{"line_number":24,"context_line":"sushy_emulator_frontend_check: true"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3f4c43b2_3aca916c","line":23,"range":{"start_line":19,"start_character":0,"end_line":23,"end_character":25},"in_reply_to":"3f4c43b2_1e5fcce2","updated":"2020-04-15 14:04:34.000000000","message":"done","commit_id":"1834274eefb3901e2a99f01766388042be642823"}],"roles/apache-wsgi-sushy-emulator/tasks/main.yml":[{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"8b46c50a72e75b32558ee7f138bc7ebde47f0d22","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: redhat | ensuring python3-pip"},{"line_number":14,"context_line":"  when: ansible_distribution \u003d\u003d \u0027CentOS\u0027 or ansible_distribution \u003d\u003d \u0027Red Hat Enterprise Linux\u0027"},{"line_number":15,"context_line":"  fail:"},{"line_number":16,"context_line":"    msg: \"CentoOS or RHEL is not currently supported\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3f4c43b2_782e0ca6","line":13,"range":{"start_line":13,"start_character":2,"end_line":13,"end_character":37},"updated":"2020-04-13 22:08:47.000000000","message":"i think python3-pip message is wrong here","commit_id":"947d9c9b95361fb6180a387e479c26ac0cd5a225"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"c26fd6a43f38b6a39a408624a343b5a6d8eecb8c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: redhat | ensuring python3-pip"},{"line_number":14,"context_line":"  when: ansible_distribution \u003d\u003d \u0027CentOS\u0027 or ansible_distribution \u003d\u003d \u0027Red Hat Enterprise Linux\u0027"},{"line_number":15,"context_line":"  fail:"},{"line_number":16,"context_line":"    msg: \"CentoOS or RHEL is not currently supported\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3f4c43b2_d6bd5d69","line":13,"range":{"start_line":13,"start_character":2,"end_line":13,"end_character":37},"in_reply_to":"3f4c43b2_782e0ca6","updated":"2020-04-14 15:41:48.000000000","message":"done","commit_id":"947d9c9b95361fb6180a387e479c26ac0cd5a225"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"8b46c50a72e75b32558ee7f138bc7ebde47f0d22","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    msg: \"CentoOS or RHEL is not currently supported\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: ubuntu | ensuring python3-pip"},{"line_number":19,"context_line":"  become: true"},{"line_number":20,"context_line":"  when: ansible_distribution \u003d\u003d \u0027Debian\u0027 or ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":21,"context_line":"  apt:"},{"line_number":22,"context_line":"    name:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3f4c43b2_981e786e","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":14},"updated":"2020-04-13 22:08:47.000000000","message":"it is better to group this with block, if we are using become on every state here.","commit_id":"947d9c9b95361fb6180a387e479c26ac0cd5a225"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"c26fd6a43f38b6a39a408624a343b5a6d8eecb8c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    msg: \"CentoOS or RHEL is not currently supported\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: ubuntu | ensuring python3-pip"},{"line_number":19,"context_line":"  become: true"},{"line_number":20,"context_line":"  when: ansible_distribution \u003d\u003d \u0027Debian\u0027 or ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":21,"context_line":"  apt:"},{"line_number":22,"context_line":"    name:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3f4c43b2_b1641bbb","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":14},"in_reply_to":"3f4c43b2_981e786e","updated":"2020-04-14 15:41:48.000000000","message":"done","commit_id":"947d9c9b95361fb6180a387e479c26ac0cd5a225"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"8b46c50a72e75b32558ee7f138bc7ebde47f0d22","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    name: libapache2-mod-wsgi-py3"},{"line_number":38,"context_line":"    state: present"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Enable ssl module"},{"line_number":41,"context_line":"  become: true"},{"line_number":42,"context_line":"  command: a2enmod wsgi"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Generate private key for sushy-emulator"},{"line_number":45,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3f4c43b2_b8309409","line":42,"range":{"start_line":40,"start_character":0,"end_line":42,"end_character":23},"updated":"2020-04-13 22:08:47.000000000","message":"seems like, you are using ansible native modules for everything else, i think we should consider using ansible module for this well: apache2_module\n\nIn addition, i think you have wrong name, since it says ssl module","commit_id":"947d9c9b95361fb6180a387e479c26ac0cd5a225"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"c26fd6a43f38b6a39a408624a343b5a6d8eecb8c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    name: libapache2-mod-wsgi-py3"},{"line_number":38,"context_line":"    state: present"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Enable ssl module"},{"line_number":41,"context_line":"  become: true"},{"line_number":42,"context_line":"  command: a2enmod wsgi"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Generate private key for sushy-emulator"},{"line_number":45,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3f4c43b2_b6f4115d","line":42,"range":{"start_line":40,"start_character":0,"end_line":42,"end_character":23},"in_reply_to":"3f4c43b2_b8309409","updated":"2020-04-14 15:41:48.000000000","message":"I see that the previous block installs and enables wsgi, so this part is even not needed.\nI\u0027ll just remove it :)","commit_id":"947d9c9b95361fb6180a387e479c26ac0cd5a225"}],"roles/apache-wsgi-sushy-emulator/templates/etc/apache2/sites-available/wsgi-sushy-emulator-ssl.conf.j2":[{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"8b46c50a72e75b32558ee7f138bc7ebde47f0d22","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cIfModule mod_ssl.c\u003e"},{"line_number":2,"context_line":"{% if sushy_emulator_frontend_https_port !\u003d 443 %}"},{"line_number":3,"context_line":"  Listen {{ sushy_emulator_frontend_https_port }}"},{"line_number":4,"context_line":"{% endif %}"},{"line_number":5,"context_line":"  \u003cVirtualHost *:{{ sushy_emulator_frontend_https_port }}\u003e"},{"line_number":6,"context_line":"     # Add machine\u0027s IP address (use ifconfig command)"},{"line_number":7,"context_line":"     ServerName {{ sushy_emulator_frontend_servername }}"},{"line_number":8,"context_line":"     # Give an alias to to start your website url with"},{"line_number":9,"context_line":"     WSGIDaemonProcess wsgiapp-sushy-https user\u003dwsgiapp-sushy processes\u003d2 threads\u003d5"},{"line_number":10,"context_line":"     WSGIScriptAlias / /var/www/sushy-emulator/sushy-emulator.wsgi"},{"line_number":11,"context_line":"     \u003cDirectory /var/www/sushy-emulator/\u003e"},{"line_number":12,"context_line":"        # set permissions as per apache2.conf file"},{"line_number":13,"context_line":"\tWSGIProcessGroup wsgiapp-sushy-https"},{"line_number":14,"context_line":"        Options FollowSymLinks"},{"line_number":15,"context_line":"        AllowOverride None"},{"line_number":16,"context_line":"        Require all granted"},{"line_number":17,"context_line":"     \u003c/Directory\u003e"},{"line_number":18,"context_line":"{% if sushy_emulator_username !\u003d \"\" %}"},{"line_number":19,"context_line":"     \u003cLocation /\u003e"},{"line_number":20,"context_line":"        AuthType Basic"},{"line_number":21,"context_line":"        AuthName \"Authentication Required\""},{"line_number":22,"context_line":"        AuthUserFile /etc/apache2/sites-available/sushy-emulator.htpasswd"},{"line_number":23,"context_line":"        Require valid-user"},{"line_number":24,"context_line":"     \u003c/Location\u003e"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":"     SSLEngine on"},{"line_number":27,"context_line":"     SSLCertificateFile    /etc/ssl/certs/ssl-cert-sushy-emulator.pem"},{"line_number":28,"context_line":"     SSLCertificateKeyFile /etc/ssl/private/ssl-cert-sushy-emulator.key"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"     ErrorLog ${APACHE_LOG_DIR}/error.log"},{"line_number":31,"context_line":"     LogLevel warn"},{"line_number":32,"context_line":"     CustomLog ${APACHE_LOG_DIR}/access.log combined"},{"line_number":33,"context_line":"  \u003c/VirtualHost\u003e"},{"line_number":34,"context_line":"\u003c/IfModule\u003e"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"3f4c43b2_58a8701e","line":34,"range":{"start_line":1,"start_character":0,"end_line":34,"end_character":11},"updated":"2020-04-13 22:08:47.000000000","message":"no need to put it into templates/etc/apache2/sites-available/wsgi-sushy-emulator-ssl.conf.j2  in templates, should be in  templates/wsgi-sushy-emulator-ssl.conf.j2","commit_id":"947d9c9b95361fb6180a387e479c26ac0cd5a225"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"c26fd6a43f38b6a39a408624a343b5a6d8eecb8c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cIfModule mod_ssl.c\u003e"},{"line_number":2,"context_line":"{% if sushy_emulator_frontend_https_port !\u003d 443 %}"},{"line_number":3,"context_line":"  Listen {{ sushy_emulator_frontend_https_port }}"},{"line_number":4,"context_line":"{% endif %}"},{"line_number":5,"context_line":"  \u003cVirtualHost *:{{ sushy_emulator_frontend_https_port }}\u003e"},{"line_number":6,"context_line":"     # Add machine\u0027s IP address (use ifconfig command)"},{"line_number":7,"context_line":"     ServerName {{ sushy_emulator_frontend_servername }}"},{"line_number":8,"context_line":"     # Give an alias to to start your website url with"},{"line_number":9,"context_line":"     WSGIDaemonProcess wsgiapp-sushy-https user\u003dwsgiapp-sushy processes\u003d2 threads\u003d5"},{"line_number":10,"context_line":"     WSGIScriptAlias / /var/www/sushy-emulator/sushy-emulator.wsgi"},{"line_number":11,"context_line":"     \u003cDirectory /var/www/sushy-emulator/\u003e"},{"line_number":12,"context_line":"        # set permissions as per apache2.conf file"},{"line_number":13,"context_line":"\tWSGIProcessGroup wsgiapp-sushy-https"},{"line_number":14,"context_line":"        Options FollowSymLinks"},{"line_number":15,"context_line":"        AllowOverride None"},{"line_number":16,"context_line":"        Require all granted"},{"line_number":17,"context_line":"     \u003c/Directory\u003e"},{"line_number":18,"context_line":"{% if sushy_emulator_username !\u003d \"\" %}"},{"line_number":19,"context_line":"     \u003cLocation /\u003e"},{"line_number":20,"context_line":"        AuthType Basic"},{"line_number":21,"context_line":"        AuthName \"Authentication Required\""},{"line_number":22,"context_line":"        AuthUserFile /etc/apache2/sites-available/sushy-emulator.htpasswd"},{"line_number":23,"context_line":"        Require valid-user"},{"line_number":24,"context_line":"     \u003c/Location\u003e"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":"     SSLEngine on"},{"line_number":27,"context_line":"     SSLCertificateFile    /etc/ssl/certs/ssl-cert-sushy-emulator.pem"},{"line_number":28,"context_line":"     SSLCertificateKeyFile /etc/ssl/private/ssl-cert-sushy-emulator.key"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"     ErrorLog ${APACHE_LOG_DIR}/error.log"},{"line_number":31,"context_line":"     LogLevel warn"},{"line_number":32,"context_line":"     CustomLog ${APACHE_LOG_DIR}/access.log combined"},{"line_number":33,"context_line":"  \u003c/VirtualHost\u003e"},{"line_number":34,"context_line":"\u003c/IfModule\u003e"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"3f4c43b2_51731781","line":34,"range":{"start_line":1,"start_character":0,"end_line":34,"end_character":11},"in_reply_to":"3f4c43b2_58a8701e","updated":"2020-04-14 15:41:48.000000000","message":"done","commit_id":"947d9c9b95361fb6180a387e479c26ac0cd5a225"}],"roles/apache-wsgi-sushy-emulator/templates/var/www/sushy-emulator/sushy-emulator.wsgi.j2":[{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"8b46c50a72e75b32558ee7f138bc7ebde47f0d22","unresolved":false,"context_lines":[{"line_number":1,"context_line":"from sushy_tools.emulator.main import app as application"},{"line_number":2,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"3f4c43b2_38b12491","line":1,"updated":"2020-04-13 22:08:47.000000000","message":"no need to put it into templates/var/www... in templates, should be in  templates/sushy-emulator.wsgi.j2","commit_id":"947d9c9b95361fb6180a387e479c26ac0cd5a225"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"c26fd6a43f38b6a39a408624a343b5a6d8eecb8c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"from sushy_tools.emulator.main import app as application"},{"line_number":2,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"3f4c43b2_d10447c9","line":1,"in_reply_to":"3f4c43b2_38b12491","updated":"2020-04-14 15:41:48.000000000","message":"done","commit_id":"947d9c9b95361fb6180a387e479c26ac0cd5a225"}]}