)]}'
{"pkg/remote/errors.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"5a34f7f8ead509400d976eb80dce38af53d1c354","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\te.Message \u003d fmt.Sprintf(format, v...)"},{"line_number":30,"context_line":"\treturn e"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"type ErrUnknownManagementType struct {"},{"line_number":34,"context_line":"\taerror.AirshipError"},{"line_number":35,"context_line":"\tType string"}],"source_content_type":"text/x-go","patch_set":15,"id":"1f493fa4_7147fc79","line":32,"updated":"2020-04-24 14:59:43.000000000","message":"Needs documentation","commit_id":"8552b541f8bdf92fe17ba156317a02d560492c33"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"133bfe8c12b16af9abe0916f78e2cfb6a1e11d73","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\te.Message \u003d fmt.Sprintf(format, v...)"},{"line_number":30,"context_line":"\treturn e"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"type ErrUnknownManagementType struct {"},{"line_number":34,"context_line":"\taerror.AirshipError"},{"line_number":35,"context_line":"\tType string"}],"source_content_type":"text/x-go","patch_set":15,"id":"1f493fa4_0ce135ff","line":32,"in_reply_to":"1f493fa4_7147fc79","updated":"2020-04-24 21:45:37.000000000","message":"Done","commit_id":"8552b541f8bdf92fe17ba156317a02d560492c33"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"5a34f7f8ead509400d976eb80dce38af53d1c354","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\treturn fmt.Sprintf(\"unknown management type: %s\", e.Type)"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"type ErrMissingBootstrapInfoOption struct {"},{"line_number":43,"context_line":"\taerror.AirshipError"},{"line_number":44,"context_line":"\tWhat string"},{"line_number":45,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":15,"id":"1f493fa4_915ba852","line":42,"updated":"2020-04-24 14:59:43.000000000","message":"Needs documentation","commit_id":"8552b541f8bdf92fe17ba156317a02d560492c33"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"133bfe8c12b16af9abe0916f78e2cfb6a1e11d73","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\treturn fmt.Sprintf(\"unknown management type: %s\", e.Type)"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"type ErrMissingBootstrapInfoOption struct {"},{"line_number":43,"context_line":"\taerror.AirshipError"},{"line_number":44,"context_line":"\tWhat string"},{"line_number":45,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":15,"id":"1f493fa4_6ce71914","line":42,"in_reply_to":"1f493fa4_915ba852","updated":"2020-04-24 21:45:37.000000000","message":"Done","commit_id":"8552b541f8bdf92fe17ba156317a02d560492c33"}],"pkg/remote/management.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"5a34f7f8ead509400d976eb80dce38af53d1c354","unresolved":false,"context_lines":[{"line_number":62,"context_line":"\tpassword   string"},{"line_number":63,"context_line":"}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"type HostSelector func(*Manager, config.ManagementConfiguration, document.Bundle) error"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"// ByLabel adds all hosts to a manager whose documents match a supplied label selector."},{"line_number":68,"context_line":"func ByLabel(label string) HostSelector {"}],"source_content_type":"text/x-go","patch_set":15,"id":"1f493fa4_d155301f","line":65,"updated":"2020-04-24 14:59:43.000000000","message":"Needs documentation","commit_id":"8552b541f8bdf92fe17ba156317a02d560492c33"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"133bfe8c12b16af9abe0916f78e2cfb6a1e11d73","unresolved":false,"context_lines":[{"line_number":62,"context_line":"\tpassword   string"},{"line_number":63,"context_line":"}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"type HostSelector func(*Manager, config.ManagementConfiguration, document.Bundle) error"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"// ByLabel adds all hosts to a manager whose documents match a supplied label selector."},{"line_number":68,"context_line":"func ByLabel(label string) HostSelector {"}],"source_content_type":"text/x-go","patch_set":15,"id":"1f493fa4_ccbf4dce","line":65,"in_reply_to":"1f493fa4_d155301f","updated":"2020-04-24 21:45:37.000000000","message":"Done","commit_id":"8552b541f8bdf92fe17ba156317a02d560492c33"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"5a34f7f8ead509400d976eb80dce38af53d1c354","unresolved":false,"context_lines":[{"line_number":135,"context_line":"\t}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"\tmanager :\u003d \u0026Manager{"},{"line_number":138,"context_line":"\t\t*managementCfg,"},{"line_number":139,"context_line":"\t\t[]baremetalHost{},"},{"line_number":140,"context_line":"\t}"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"\t// Each function in hosts modifies the list of hosts for the new manager based on selection criteria provided"}],"source_content_type":"text/x-go","patch_set":15,"id":"1f493fa4_2cea3b0e","line":139,"range":{"start_line":138,"start_character":0,"end_line":139,"end_character":20},"updated":"2020-04-24 14:59:43.000000000","message":"Can we key these fields? We shouldn\u0027t be depending on declaration order for initialization.","commit_id":"8552b541f8bdf92fe17ba156317a02d560492c33"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"133bfe8c12b16af9abe0916f78e2cfb6a1e11d73","unresolved":false,"context_lines":[{"line_number":135,"context_line":"\t}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"\tmanager :\u003d \u0026Manager{"},{"line_number":138,"context_line":"\t\t*managementCfg,"},{"line_number":139,"context_line":"\t\t[]baremetalHost{},"},{"line_number":140,"context_line":"\t}"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"\t// Each function in hosts modifies the list of hosts for the new manager based on selection criteria provided"}],"source_content_type":"text/x-go","patch_set":15,"id":"1f493fa4_6ca3999f","line":139,"range":{"start_line":138,"start_character":0,"end_line":139,"end_character":20},"in_reply_to":"1f493fa4_2cea3b0e","updated":"2020-04-24 21:45:37.000000000","message":"Done","commit_id":"8552b541f8bdf92fe17ba156317a02d560492c33"}],"pkg/remote/management_test.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"5a34f7f8ead509400d976eb80dce38af53d1c354","unresolved":false,"context_lines":[{"line_number":61,"context_line":"\t}"},{"line_number":62,"context_line":"}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"func TestNewManagerEphemeralHost(t *testing.T) {"},{"line_number":65,"context_line":"\tsettings :\u003d initSettings(t, withTestDataPath(\"base\"))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"\t_, err :\u003d NewManager(settings, config.BootstrapPhase, ByLabel(document.EphemeralHostSelector))"}],"source_content_type":"text/x-go","patch_set":15,"id":"1f493fa4_8ce26f00","line":64,"updated":"2020-04-24 14:59:43.000000000","message":"Couldn\u0027t we perform more substantive validation in these tests? e.g. assert that the new manager has an ephemeral host","commit_id":"8552b541f8bdf92fe17ba156317a02d560492c33"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"133bfe8c12b16af9abe0916f78e2cfb6a1e11d73","unresolved":false,"context_lines":[{"line_number":61,"context_line":"\t}"},{"line_number":62,"context_line":"}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"func TestNewManagerEphemeralHost(t *testing.T) {"},{"line_number":65,"context_line":"\tsettings :\u003d initSettings(t, withTestDataPath(\"base\"))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"\t_, err :\u003d NewManager(settings, config.BootstrapPhase, ByLabel(document.EphemeralHostSelector))"}],"source_content_type":"text/x-go","patch_set":15,"id":"1f493fa4_4cd69dc5","line":64,"in_reply_to":"1f493fa4_8ce26f00","updated":"2020-04-24 21:45:37.000000000","message":"\u003e Couldn\u0027t we perform more substantive validation in these tests?\n \u003e e.g. assert that the new manager has an ephemeral host\n\nGood call. Added more assertions to successful selections and added a test for multiple hosts.","commit_id":"8552b541f8bdf92fe17ba156317a02d560492c33"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"71ca00c7da1c1bb14d0cdb0e20ff83a0ac5e5d37","unresolved":false,"context_lines":[{"line_number":65,"context_line":"\tsettings :\u003d initSettings(t, withTestDataPath(\"base\"))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"\tmanager, err :\u003d NewManager(settings, config.BootstrapPhase, ByLabel(document.EphemeralHostSelector))"},{"line_number":68,"context_line":"\tassert.NoError(t, err)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"\tassert.Equal(t, 1, len(manager.Hosts))"},{"line_number":71,"context_line":"\tassert.Equal(t, \"ephemeral\", manager.Hosts[0].NodeID())"},{"line_number":72,"context_line":"}"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-go","patch_set":17,"id":"1f493fa4_2cb68d8b","line":70,"range":{"start_line":68,"start_character":0,"end_line":70,"end_character":39},"updated":"2020-04-27 17:28:43.000000000","message":"these need to be requires, otherwise we might panic on L71, which isn\u0027t a useful failure","commit_id":"d425a6b8dd411b5b1b9c640b88ce66a8dbd19d02"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"bfa8e306ec95c213668d172d91fac2dfda8559bb","unresolved":false,"context_lines":[{"line_number":65,"context_line":"\tsettings :\u003d initSettings(t, withTestDataPath(\"base\"))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"\tmanager, err :\u003d NewManager(settings, config.BootstrapPhase, ByLabel(document.EphemeralHostSelector))"},{"line_number":68,"context_line":"\tassert.NoError(t, err)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"\tassert.Equal(t, 1, len(manager.Hosts))"},{"line_number":71,"context_line":"\tassert.Equal(t, \"ephemeral\", manager.Hosts[0].NodeID())"},{"line_number":72,"context_line":"}"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-go","patch_set":17,"id":"1f493fa4_2c0cb6a3","line":70,"range":{"start_line":68,"start_character":0,"end_line":70,"end_character":39},"in_reply_to":"1f493fa4_2cb68d8b","updated":"2020-04-28 15:24:35.000000000","message":"Done","commit_id":"d425a6b8dd411b5b1b9c640b88ce66a8dbd19d02"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"71ca00c7da1c1bb14d0cdb0e20ff83a0ac5e5d37","unresolved":false,"context_lines":[{"line_number":75,"context_line":"\tsettings :\u003d initSettings(t, withTestDataPath(\"base\"))"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"\tmanager, err :\u003d NewManager(settings, config.BootstrapPhase, ByName(\"master-1\"))"},{"line_number":78,"context_line":"\tassert.NoError(t, err)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"\tassert.Equal(t, 1, len(manager.Hosts))"},{"line_number":81,"context_line":"\tassert.Equal(t, \"node-master-1\", manager.Hosts[0].NodeID())"},{"line_number":82,"context_line":"}"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-go","patch_set":17,"id":"1f493fa4_4cb0398b","line":80,"range":{"start_line":78,"start_character":0,"end_line":80,"end_character":39},"updated":"2020-04-27 17:28:43.000000000","message":"ditto: require","commit_id":"d425a6b8dd411b5b1b9c640b88ce66a8dbd19d02"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"bfa8e306ec95c213668d172d91fac2dfda8559bb","unresolved":false,"context_lines":[{"line_number":75,"context_line":"\tsettings :\u003d initSettings(t, withTestDataPath(\"base\"))"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"\tmanager, err :\u003d NewManager(settings, config.BootstrapPhase, ByName(\"master-1\"))"},{"line_number":78,"context_line":"\tassert.NoError(t, err)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"\tassert.Equal(t, 1, len(manager.Hosts))"},{"line_number":81,"context_line":"\tassert.Equal(t, \"node-master-1\", manager.Hosts[0].NodeID())"},{"line_number":82,"context_line":"}"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-go","patch_set":17,"id":"1f493fa4_8cfd0a70","line":80,"range":{"start_line":78,"start_character":0,"end_line":80,"end_character":39},"in_reply_to":"1f493fa4_4cb0398b","updated":"2020-04-28 15:24:35.000000000","message":"Done","commit_id":"d425a6b8dd411b5b1b9c640b88ce66a8dbd19d02"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"71ca00c7da1c1bb14d0cdb0e20ff83a0ac5e5d37","unresolved":false,"context_lines":[{"line_number":85,"context_line":"\tsettings :\u003d initSettings(t, withTestDataPath(\"base\"))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"\tmanager, err :\u003d NewManager(settings, config.BootstrapPhase, ByLabel(\"airshipit.org/test-node\u003dtrue\"))"},{"line_number":88,"context_line":"\tassert.NoError(t, err)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"\tassert.Equal(t, 2, len(manager.Hosts))"},{"line_number":91,"context_line":"\tassert.Equal(t, \"node-master-1\", manager.Hosts[0].NodeID())"},{"line_number":92,"context_line":"\tassert.Equal(t, \"node-master-2\", manager.Hosts[1].NodeID())"},{"line_number":93,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":17,"id":"1f493fa4_cc69e9f9","line":90,"range":{"start_line":88,"start_character":0,"end_line":90,"end_character":39},"updated":"2020-04-27 17:28:43.000000000","message":"ditto: require","commit_id":"d425a6b8dd411b5b1b9c640b88ce66a8dbd19d02"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"bfa8e306ec95c213668d172d91fac2dfda8559bb","unresolved":false,"context_lines":[{"line_number":85,"context_line":"\tsettings :\u003d initSettings(t, withTestDataPath(\"base\"))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"\tmanager, err :\u003d NewManager(settings, config.BootstrapPhase, ByLabel(\"airshipit.org/test-node\u003dtrue\"))"},{"line_number":88,"context_line":"\tassert.NoError(t, err)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"\tassert.Equal(t, 2, len(manager.Hosts))"},{"line_number":91,"context_line":"\tassert.Equal(t, \"node-master-1\", manager.Hosts[0].NodeID())"},{"line_number":92,"context_line":"\tassert.Equal(t, \"node-master-2\", manager.Hosts[1].NodeID())"},{"line_number":93,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":17,"id":"1f493fa4_6c023e71","line":90,"range":{"start_line":88,"start_character":0,"end_line":90,"end_character":39},"in_reply_to":"1f493fa4_cc69e9f9","updated":"2020-04-28 15:24:35.000000000","message":"Done","commit_id":"d425a6b8dd411b5b1b9c640b88ce66a8dbd19d02"}]}