)]}'
{"pkg/document/plugin/replacement/v1alpha1/errors.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"0ca70d683f590bfb1790d062e9cbe9f4a4ac4b11","unresolved":false,"context_lines":[{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"// ErrPattermSubstring returned in case of issues with sub-string pattern subsitution"},{"line_number":68,"context_line":"type ErrPattermSubstring struct {"},{"line_number":69,"context_line":"\tMsg string"},{"line_number":70,"context_line":"}"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_b44a4824","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":15},"updated":"2020-04-22 15:12:25.000000000","message":"Pattern","commit_id":"f246411eb298c7ed9d56daaf16ca75c65e8270ed"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"2842bb629306043cb2082c077ba6984734a1f8eb","unresolved":false,"context_lines":[{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"// ErrPattermSubstring returned in case of issues with sub-string pattern subsitution"},{"line_number":68,"context_line":"type ErrPattermSubstring struct {"},{"line_number":69,"context_line":"\tMsg string"},{"line_number":70,"context_line":"}"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_0dfafd73","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":15},"in_reply_to":"1f493fa4_b44a4824","updated":"2020-04-23 11:25:10.000000000","message":"Done","commit_id":"f246411eb298c7ed9d56daaf16ca75c65e8270ed"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"59cbf979b910f5dffb2467d3898c8d1e9faf0cf6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\treturn e.Msg"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"// ErrMultipleResources returned if miultiple resources found"},{"line_number":50,"context_line":"type ErrMultipleResources struct {"},{"line_number":51,"context_line":"\tResList []*resource.Resource"},{"line_number":52,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_3d60ab32","line":49,"range":{"start_line":49,"start_character":36,"end_line":49,"end_character":45},"updated":"2020-04-24 12:41:02.000000000","message":"multiple","commit_id":"48af4ae87e1e9daae4e45b493cb150c0c0dc5c1e"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"240275214c88057613888a42f4c75a261d4c15c0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\treturn e.Msg"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"// ErrMultipleResources returned if miultiple resources found"},{"line_number":50,"context_line":"type ErrMultipleResources struct {"},{"line_number":51,"context_line":"\tResList []*resource.Resource"},{"line_number":52,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_63d611c6","line":49,"range":{"start_line":49,"start_character":36,"end_line":49,"end_character":45},"in_reply_to":"1f493fa4_3d60ab32","updated":"2020-04-24 16:11:10.000000000","message":"Done","commit_id":"48af4ae87e1e9daae4e45b493cb150c0c0dc5c1e"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"59cbf979b910f5dffb2467d3898c8d1e9faf0cf6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"func (e ErrResourceNotFound) Error() string {"},{"line_number":64,"context_line":"\treturn fmt.Sprintf(\"failed to find one resource matching from %v\", e.ObjRef)"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"// ErrPatternSubstring returned in case of issues with sub-string pattern subsitution"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_3deeeb87","line":64,"range":{"start_line":64,"start_character":36,"end_line":64,"end_character":39},"updated":"2020-04-24 12:41:02.000000000","message":"the way this error is called leads me to believe this should be rewritten to something like\n\n\"failed to find any matching resources from %v\"\n\nfor context I\u0027m looking at pkg/document/plugin/replacement/v1alpha1/transformer.go on line 139","commit_id":"48af4ae87e1e9daae4e45b493cb150c0c0dc5c1e"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"240275214c88057613888a42f4c75a261d4c15c0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"func (e ErrResourceNotFound) Error() string {"},{"line_number":64,"context_line":"\treturn fmt.Sprintf(\"failed to find one resource matching from %v\", e.ObjRef)"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"// ErrPatternSubstring returned in case of issues with sub-string pattern subsitution"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_23eec987","line":64,"range":{"start_line":64,"start_character":36,"end_line":64,"end_character":39},"in_reply_to":"1f493fa4_3deeeb87","updated":"2020-04-24 16:11:10.000000000","message":"Done. Error message should be clearer now","commit_id":"48af4ae87e1e9daae4e45b493cb150c0c0dc5c1e"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"59cbf979b910f5dffb2467d3898c8d1e9faf0cf6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"\treturn fmt.Sprintf(\"failed to find one resource matching from %v\", e.ObjRef)"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"// ErrPatternSubstring returned in case of issues with sub-string pattern subsitution"},{"line_number":68,"context_line":"type ErrPatternSubstring struct {"},{"line_number":69,"context_line":"\tMsg string"},{"line_number":70,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_7d519362","line":67,"range":{"start_line":67,"start_character":74,"end_line":67,"end_character":85},"updated":"2020-04-24 12:41:02.000000000","message":"substitution","commit_id":"48af4ae87e1e9daae4e45b493cb150c0c0dc5c1e"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"240275214c88057613888a42f4c75a261d4c15c0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"\treturn fmt.Sprintf(\"failed to find one resource matching from %v\", e.ObjRef)"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"// ErrPatternSubstring returned in case of issues with sub-string pattern subsitution"},{"line_number":68,"context_line":"type ErrPatternSubstring struct {"},{"line_number":69,"context_line":"\tMsg string"},{"line_number":70,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_8304fd4b","line":67,"range":{"start_line":67,"start_character":74,"end_line":67,"end_character":85},"in_reply_to":"1f493fa4_7d519362","updated":"2020-04-24 16:11:10.000000000","message":"Done","commit_id":"48af4ae87e1e9daae4e45b493cb150c0c0dc5c1e"}],"pkg/document/plugin/replacement/v1alpha1/transformer.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"0ca70d683f590bfb1790d062e9cbe9f4a4ac4b11","unresolved":false,"context_lines":[{"line_number":80,"context_line":"}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"func (p *plugin) Config("},{"line_number":83,"context_line":"\t_ *resmap.PluginHelpers, c []byte) (err error) {"},{"line_number":84,"context_line":"\tp.Replacements \u003d []types.Replacement{}"},{"line_number":85,"context_line":"\terr \u003d yaml.Unmarshal(c, p)"},{"line_number":86,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_f46330db","line":83,"range":{"start_line":83,"start_character":37,"end_line":83,"end_character":40},"updated":"2020-04-22 15:12:25.000000000","message":"this named parameter doesn\u0027t seem necessary, it just adds stutter","commit_id":"f246411eb298c7ed9d56daaf16ca75c65e8270ed"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"2842bb629306043cb2082c077ba6984734a1f8eb","unresolved":false,"context_lines":[{"line_number":80,"context_line":"}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"func (p *plugin) Config("},{"line_number":83,"context_line":"\t_ *resmap.PluginHelpers, c []byte) (err error) {"},{"line_number":84,"context_line":"\tp.Replacements \u003d []types.Replacement{}"},{"line_number":85,"context_line":"\terr \u003d yaml.Unmarshal(c, p)"},{"line_number":86,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_0dd15dfc","line":83,"range":{"start_line":83,"start_character":37,"end_line":83,"end_character":40},"in_reply_to":"1f493fa4_f46330db","updated":"2020-04-23 11:25:10.000000000","message":"Done","commit_id":"f246411eb298c7ed9d56daaf16ca75c65e8270ed"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"0ca70d683f590bfb1790d062e9cbe9f4a4ac4b11","unresolved":false,"context_lines":[{"line_number":100,"context_line":"\treturn nil"},{"line_number":101,"context_line":"}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"func (p *plugin) Transform(m resmap.ResMap) (err error) {"},{"line_number":104,"context_line":"\tfor _, r :\u003d range p.Replacements {"},{"line_number":105,"context_line":"\t\tvar replacement interface{}"},{"line_number":106,"context_line":"\t\tif r.Source.ObjRef !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_74a56004","line":103,"range":{"start_line":103,"start_character":45,"end_line":103,"end_character":48},"updated":"2020-04-22 15:12:25.000000000","message":"ditto: stutter","commit_id":"f246411eb298c7ed9d56daaf16ca75c65e8270ed"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"329f0fd7291cde55cbb9237947c57da4530232e7","unresolved":false,"context_lines":[{"line_number":100,"context_line":"\treturn nil"},{"line_number":101,"context_line":"}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"func (p *plugin) Transform(m resmap.ResMap) (err error) {"},{"line_number":104,"context_line":"\tfor _, r :\u003d range p.Replacements {"},{"line_number":105,"context_line":"\t\tvar replacement interface{}"},{"line_number":106,"context_line":"\t\tif r.Source.ObjRef !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_b38351a9","line":103,"range":{"start_line":103,"start_character":45,"end_line":103,"end_character":48},"in_reply_to":"1f493fa4_3203d111","updated":"2020-04-24 09:15:07.000000000","message":"Done. Not at problem at all, but it still \u0027stutter\u0027 :)","commit_id":"f246411eb298c7ed9d56daaf16ca75c65e8270ed"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"e6663c80fdb8be0f2f79fa6e431430c5b6bf617f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"\treturn nil"},{"line_number":101,"context_line":"}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"func (p *plugin) Transform(m resmap.ResMap) (err error) {"},{"line_number":104,"context_line":"\tfor _, r :\u003d range p.Replacements {"},{"line_number":105,"context_line":"\t\tvar replacement interface{}"},{"line_number":106,"context_line":"\t\tif r.Source.ObjRef !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_3203d111","line":103,"range":{"start_line":103,"start_character":45,"end_line":103,"end_character":48},"in_reply_to":"1f493fa4_6d090194","updated":"2020-04-23 14:15:00.000000000","message":"\u003e You\u0027d anyway need to define error variable at the beginning of the function.\n\nWhy is declaring it at the beginning a problem? The only reason to name your return values is for documentation purposes.\n\nhttps://github.com/golang/go/wiki/CodeReviewComments#named-result-parameters","commit_id":"f246411eb298c7ed9d56daaf16ca75c65e8270ed"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"2842bb629306043cb2082c077ba6984734a1f8eb","unresolved":false,"context_lines":[{"line_number":100,"context_line":"\treturn nil"},{"line_number":101,"context_line":"}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"func (p *plugin) Transform(m resmap.ResMap) (err error) {"},{"line_number":104,"context_line":"\tfor _, r :\u003d range p.Replacements {"},{"line_number":105,"context_line":"\t\tvar replacement interface{}"},{"line_number":106,"context_line":"\t\tif r.Source.ObjRef !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_6d090194","line":103,"range":{"start_line":103,"start_character":45,"end_line":103,"end_character":48},"in_reply_to":"1f493fa4_74a56004","updated":"2020-04-23 11:25:10.000000000","message":"This is not really possible due to the nature of this method. You\u0027d anyway need to define error variable at the beginning of the function. Otherwise \u0027replacement\u0027 variable cause either undefined or not user error.","commit_id":"f246411eb298c7ed9d56daaf16ca75c65e8270ed"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"0ca70d683f590bfb1790d062e9cbe9f4a4ac4b11","unresolved":false,"context_lines":[{"line_number":158,"context_line":"\treturn nil"},{"line_number":159,"context_line":"}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"func getFirstPathSegment(path string) (field string, key string, value string, array bool) {"},{"line_number":162,"context_line":"\tgroups :\u003d pattern.FindStringSubmatch(path)"},{"line_number":163,"context_line":"\tif len(groups) !\u003d 4 {"},{"line_number":164,"context_line":"\t\treturn path, \"\", \"\", false"}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_d48ef476","line":161,"range":{"start_line":161,"start_character":79,"end_line":161,"end_character":84},"updated":"2020-04-22 15:12:25.000000000","message":"could this be changed to \"isArray\"?","commit_id":"f246411eb298c7ed9d56daaf16ca75c65e8270ed"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"2842bb629306043cb2082c077ba6984734a1f8eb","unresolved":false,"context_lines":[{"line_number":158,"context_line":"\treturn nil"},{"line_number":159,"context_line":"}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"func getFirstPathSegment(path string) (field string, key string, value string, array bool) {"},{"line_number":162,"context_line":"\tgroups :\u003d pattern.FindStringSubmatch(path)"},{"line_number":163,"context_line":"\tif len(groups) !\u003d 4 {"},{"line_number":164,"context_line":"\t\treturn path, \"\", \"\", false"}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_cd00156b","line":161,"range":{"start_line":161,"start_character":79,"end_line":161,"end_character":84},"in_reply_to":"1f493fa4_d48ef476","updated":"2020-04-23 11:25:10.000000000","message":"Done","commit_id":"f246411eb298c7ed9d56daaf16ca75c65e8270ed"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"e6663c80fdb8be0f2f79fa6e431430c5b6bf617f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"\treturn nil"},{"line_number":102,"context_line":"}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"// Transform resources using cofigured replacements"},{"line_number":105,"context_line":"func (p *plugin) Transform(m resmap.ResMap) (err error) {"},{"line_number":106,"context_line":"\tfor _, r :\u003d range p.Replacements {"},{"line_number":107,"context_line":"\t\tvar replacement interface{}"}],"source_content_type":"text/x-go","patch_set":3,"id":"1f493fa4_b5a86bdb","line":104,"range":{"start_line":104,"start_character":29,"end_line":104,"end_character":38},"updated":"2020-04-23 14:15:00.000000000","message":"configured","commit_id":"ef3d46e12457cd1b2814ee5ce61110245c107e92"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"329f0fd7291cde55cbb9237947c57da4530232e7","unresolved":false,"context_lines":[{"line_number":101,"context_line":"\treturn nil"},{"line_number":102,"context_line":"}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"// Transform resources using cofigured replacements"},{"line_number":105,"context_line":"func (p *plugin) Transform(m resmap.ResMap) (err error) {"},{"line_number":106,"context_line":"\tfor _, r :\u003d range p.Replacements {"},{"line_number":107,"context_line":"\t\tvar replacement interface{}"}],"source_content_type":"text/x-go","patch_set":3,"id":"1f493fa4_33c101e6","line":104,"range":{"start_line":104,"start_character":29,"end_line":104,"end_character":38},"in_reply_to":"1f493fa4_b5a86bdb","updated":"2020-04-24 09:15:07.000000000","message":"Done","commit_id":"ef3d46e12457cd1b2814ee5ce61110245c107e92"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"59cbf979b910f5dffb2467d3898c8d1e9faf0cf6","unresolved":false,"context_lines":[{"line_number":136,"context_line":"\t\treturn nil, ErrMultipleResources{ResList: resources}"},{"line_number":137,"context_line":"\t}"},{"line_number":138,"context_line":"\tif len(resources) \u003d\u003d 0 {"},{"line_number":139,"context_line":"\t\treturn nil, ErrResourceNotFound{ObjRef: objRef}"},{"line_number":140,"context_line":"\t}"},{"line_number":141,"context_line":"\tif fieldRef \u003d\u003d \"\" {"},{"line_number":142,"context_line":"\t\tfieldRef \u003d \"metadata.name\""}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_dd81c791","line":139,"range":{"start_line":139,"start_character":34,"end_line":139,"end_character":48},"updated":"2020-04-24 12:41:02.000000000","message":"is just the objref enough to debug?  resources may be missing when an objref exists with a matching GVK and Name but wrong namespace for example","commit_id":"48af4ae87e1e9daae4e45b493cb150c0c0dc5c1e"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"240275214c88057613888a42f4c75a261d4c15c0","unresolved":false,"context_lines":[{"line_number":136,"context_line":"\t\treturn nil, ErrMultipleResources{ResList: resources}"},{"line_number":137,"context_line":"\t}"},{"line_number":138,"context_line":"\tif len(resources) \u003d\u003d 0 {"},{"line_number":139,"context_line":"\t\treturn nil, ErrResourceNotFound{ObjRef: objRef}"},{"line_number":140,"context_line":"\t}"},{"line_number":141,"context_line":"\tif fieldRef \u003d\u003d \"\" {"},{"line_number":142,"context_line":"\t\tfieldRef \u003d \"metadata.name\""}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_63ad7130","line":139,"range":{"start_line":139,"start_character":34,"end_line":139,"end_character":48},"in_reply_to":"1f493fa4_dd81c791","updated":"2020-04-24 16:11:10.000000000","message":"Done. Error method has been reworked","commit_id":"48af4ae87e1e9daae4e45b493cb150c0c0dc5c1e"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"59cbf979b910f5dffb2467d3898c8d1e9faf0cf6","unresolved":false,"context_lines":[{"line_number":250,"context_line":"\t\t\t\t}"},{"line_number":251,"context_line":"\t\t\t\tif actualValue, ok :\u003d typedItem[key]; ok {"},{"line_number":252,"context_line":"\t\t\t\t\tif value \u003d\u003d actualValue {"},{"line_number":253,"context_line":"\t\t\t\t\t\t// TODO (dukov) should not we do \u0027item \u003d replcement\u0027 here?"},{"line_number":254,"context_line":"\t\t\t\t\t\ttypedItem[key] \u003d value"},{"line_number":255,"context_line":"\t\t\t\t\t}"},{"line_number":256,"context_line":"\t\t\t\t}"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_ddfee735","line":253,"range":{"start_line":253,"start_character":47,"end_line":253,"end_character":57},"updated":"2020-04-24 12:41:02.000000000","message":"replacement","commit_id":"48af4ae87e1e9daae4e45b493cb150c0c0dc5c1e"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"240275214c88057613888a42f4c75a261d4c15c0","unresolved":false,"context_lines":[{"line_number":250,"context_line":"\t\t\t\t}"},{"line_number":251,"context_line":"\t\t\t\tif actualValue, ok :\u003d typedItem[key]; ok {"},{"line_number":252,"context_line":"\t\t\t\t\tif value \u003d\u003d actualValue {"},{"line_number":253,"context_line":"\t\t\t\t\t\t// TODO (dukov) should not we do \u0027item \u003d replcement\u0027 here?"},{"line_number":254,"context_line":"\t\t\t\t\t\ttypedItem[key] \u003d value"},{"line_number":255,"context_line":"\t\t\t\t\t}"},{"line_number":256,"context_line":"\t\t\t\t}"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_436e7501","line":253,"range":{"start_line":253,"start_character":47,"end_line":253,"end_character":57},"in_reply_to":"1f493fa4_ddfee735","updated":"2020-04-24 16:11:10.000000000","message":"Done","commit_id":"48af4ae87e1e9daae4e45b493cb150c0c0dc5c1e"}],"pkg/document/plugin/replacement/v1alpha1/transformer_test.go":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"59cbf979b910f5dffb2467d3898c8d1e9faf0cf6","unresolved":false,"context_lines":[{"line_number":542,"context_line":"  containers:"},{"line_number":543,"context_line":"  - name: myapp-container"},{"line_number":544,"context_line":"    image: busybox`,"},{"line_number":545,"context_line":"\t\t\texpectedErr: `\"some string value\" is expected to be not a primitive type`,"},{"line_number":546,"context_line":"\t\t},"},{"line_number":547,"context_line":"\t\t{"},{"line_number":548,"context_line":"\t\t\tcfg: `"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_a0af74e1","line":545,"range":{"start_line":545,"start_character":49,"end_line":545,"end_character":75},"updated":"2020-04-24 12:41:02.000000000","message":"wording on this isn\u0027t super clear - what type is it expected to be?\n\nif only testing the case of primitives here, may want to reword the corresponding error to\n\"some string value\" is not expected be a primitive type","commit_id":"48af4ae87e1e9daae4e45b493cb150c0c0dc5c1e"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"240275214c88057613888a42f4c75a261d4c15c0","unresolved":false,"context_lines":[{"line_number":542,"context_line":"  containers:"},{"line_number":543,"context_line":"  - name: myapp-container"},{"line_number":544,"context_line":"    image: busybox`,"},{"line_number":545,"context_line":"\t\t\texpectedErr: `\"some string value\" is expected to be not a primitive type`,"},{"line_number":546,"context_line":"\t\t},"},{"line_number":547,"context_line":"\t\t{"},{"line_number":548,"context_line":"\t\t\tcfg: `"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_637291e5","line":545,"range":{"start_line":545,"start_character":49,"end_line":545,"end_character":75},"in_reply_to":"1f493fa4_a0af74e1","updated":"2020-04-24 16:11:10.000000000","message":"Done","commit_id":"48af4ae87e1e9daae4e45b493cb150c0c0dc5c1e"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"59cbf979b910f5dffb2467d3898c8d1e9faf0cf6","unresolved":false,"context_lines":[{"line_number":776,"context_line":"  template:"},{"line_number":777,"context_line":"    spec:"},{"line_number":778,"context_line":"      containers:"},{"line_number":779,"context_line":"      - image: nginx:latest"},{"line_number":780,"context_line":"        name: nginx-latest`,"},{"line_number":781,"context_line":"\t\t\texpectedErr: \"pattern TAG not found in target value nginx:latest\","},{"line_number":782,"context_line":"\t\t},"},{"line_number":783,"context_line":"\t}"},{"line_number":784,"context_line":""}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_e0921c9e","line":781,"range":{"start_line":779,"start_character":15,"end_line":781,"end_character":69},"updated":"2020-04-24 12:41:02.000000000","message":"not clear on why this test is expected to fail, the latest tag is used on image","commit_id":"48af4ae87e1e9daae4e45b493cb150c0c0dc5c1e"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"240275214c88057613888a42f4c75a261d4c15c0","unresolved":false,"context_lines":[{"line_number":776,"context_line":"  template:"},{"line_number":777,"context_line":"    spec:"},{"line_number":778,"context_line":"      containers:"},{"line_number":779,"context_line":"      - image: nginx:latest"},{"line_number":780,"context_line":"        name: nginx-latest`,"},{"line_number":781,"context_line":"\t\t\texpectedErr: \"pattern TAG not found in target value nginx:latest\","},{"line_number":782,"context_line":"\t\t},"},{"line_number":783,"context_line":"\t}"},{"line_number":784,"context_line":""}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_034d8d99","line":781,"range":{"start_line":779,"start_character":15,"end_line":781,"end_character":69},"in_reply_to":"1f493fa4_e0921c9e","updated":"2020-04-24 16:11:10.000000000","message":"It\u0027s expecting to have \u0027TAG\u0027 substring in the \u0027image\u0027 field and since this tag is not present error is raised. I\u0027ve tried to make error message a bit clearer.","commit_id":"48af4ae87e1e9daae4e45b493cb150c0c0dc5c1e"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"59cbf979b910f5dffb2467d3898c8d1e9faf0cf6","unresolved":false,"context_lines":[{"line_number":783,"context_line":"\t}"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"\tfor _, tc :\u003d range testCases {"},{"line_number":786,"context_line":"\t\tplugun, err :\u003d replv1alpha1.New(nil, []byte(tc.cfg))"},{"line_number":787,"context_line":"\t\trequire.NoError(t, err)"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"\t\tbuf :\u003d \u0026bytes.Buffer{}"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_a03c94c8","line":786,"range":{"start_line":786,"start_character":2,"end_line":786,"end_character":8},"updated":"2020-04-24 12:41:02.000000000","message":"nit: not modified in this patch but a typo that could be refactored to \"plugin\"","commit_id":"48af4ae87e1e9daae4e45b493cb150c0c0dc5c1e"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"240275214c88057613888a42f4c75a261d4c15c0","unresolved":false,"context_lines":[{"line_number":783,"context_line":"\t}"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"\tfor _, tc :\u003d range testCases {"},{"line_number":786,"context_line":"\t\tplugun, err :\u003d replv1alpha1.New(nil, []byte(tc.cfg))"},{"line_number":787,"context_line":"\t\trequire.NoError(t, err)"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"\t\tbuf :\u003d \u0026bytes.Buffer{}"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_c381e591","line":786,"range":{"start_line":786,"start_character":2,"end_line":786,"end_character":8},"in_reply_to":"1f493fa4_a03c94c8","updated":"2020-04-24 16:11:10.000000000","message":"Done","commit_id":"48af4ae87e1e9daae4e45b493cb150c0c0dc5c1e"}]}