)]}'
{"docs/source/developers.md":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"8119de4fe936681e3190fd8ab68ac35ff946a65a","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"When running the gate scripts in `tools/gate` locally, you will need to add your"},{"line_number":46,"context_line":"proxy information to"},{"line_number":47,"context_line":"`roles/airshipctl-systemwide-executable/defaults/main.yaml`,"},{"line_number":48,"context_line":"`roles/airshipctl-build-ephemeral-iso/defaults/main.yml`,"},{"line_number":49,"context_line":"`roles/docker-install/defaults/main.yaml`,"},{"line_number":50,"context_line":"`roles/install-kubectl/defaults/main.yml`."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Also proxy setting have to be updated on the ephemeral iso user-data section in"},{"line_number":53,"context_line":"below file"}],"source_content_type":"text/x-markdown","patch_set":1,"id":"1f493fa4_eac14ee6","line":50,"range":{"start_line":47,"start_character":0,"end_line":50,"end_character":42},"updated":"2020-04-24 19:10:04.000000000","message":"This is an overwhelming amount of files to change. Maybe instead we could suggest using a variable file?","commit_id":"a8c7096e500551eb5825253601a224d255c30064"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"b7a8447ab6bac70acbe5a9bb867fbb4f63b5dbbf","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"When running the gate scripts in `tools/gate` locally, you will need to add your"},{"line_number":46,"context_line":"proxy information to"},{"line_number":47,"context_line":"`roles/airshipctl-systemwide-executable/defaults/main.yaml`,"},{"line_number":48,"context_line":"`roles/airshipctl-build-ephemeral-iso/defaults/main.yml`,"},{"line_number":49,"context_line":"`roles/docker-install/defaults/main.yaml`,"},{"line_number":50,"context_line":"`roles/install-kubectl/defaults/main.yml`."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Also proxy setting have to be updated on the ephemeral iso user-data section in"},{"line_number":53,"context_line":"below file"}],"source_content_type":"text/x-markdown","patch_set":1,"id":"1f493fa4_1bcdb230","line":50,"range":{"start_line":47,"start_character":0,"end_line":50,"end_character":42},"in_reply_to":"1f493fa4_eac14ee6","updated":"2020-04-28 14:08:45.000000000","message":"Done","commit_id":"a8c7096e500551eb5825253601a224d255c30064"},{"author":{"_account_id":24580,"name":"James Gu","email":"james.gu@microsoft.com","username":"jamesgu"},"change_message_id":"c1060db54d993842496831fb8a87227dddf688c1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"`roles/airshipctl-build-ephemeral-iso/defaults/main.yml`,"},{"line_number":49,"context_line":"`roles/docker-install/defaults/main.yaml`,"},{"line_number":50,"context_line":"`roles/install-kubectl/defaults/main.yml`."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Also proxy setting have to be updated on the ephemeral iso user-data section in"},{"line_number":53,"context_line":"below file"},{"line_number":54,"context_line":"`manifests/function/ephemeral/secret.yaml`."}],"source_content_type":"text/x-markdown","patch_set":1,"id":"1f493fa4_40cf6228","line":51,"updated":"2020-04-27 15:18:20.000000000","message":"agreed. pls see https://review.opendev.org/#/c/723057 for changes to use the var files in local-dev.yaml as a single source.","commit_id":"a8c7096e500551eb5825253601a224d255c30064"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"b7a8447ab6bac70acbe5a9bb867fbb4f63b5dbbf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"`roles/airshipctl-build-ephemeral-iso/defaults/main.yml`,"},{"line_number":49,"context_line":"`roles/docker-install/defaults/main.yaml`,"},{"line_number":50,"context_line":"`roles/install-kubectl/defaults/main.yml`."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Also proxy setting have to be updated on the ephemeral iso user-data section in"},{"line_number":53,"context_line":"below file"},{"line_number":54,"context_line":"`manifests/function/ephemeral/secret.yaml`."}],"source_content_type":"text/x-markdown","patch_set":1,"id":"1f493fa4_bbdbdeea","line":51,"in_reply_to":"1f493fa4_40cf6228","updated":"2020-04-28 14:08:45.000000000","message":"Done","commit_id":"a8c7096e500551eb5825253601a224d255c30064"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"8119de4fe936681e3190fd8ab68ac35ff946a65a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"below file"},{"line_number":54,"context_line":"`manifests/function/ephemeral/secret.yaml`."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Add the below contents in runcmd of above file"},{"line_number":57,"context_line":"```"},{"line_number":58,"context_line":"    - export http_proxy\u003dhttp://username:password@host:port"},{"line_number":59,"context_line":"    - export https_proxy\u003d$http_proxy"}],"source_content_type":"text/x-markdown","patch_set":1,"id":"1f493fa4_6a09be2f","line":56,"range":{"start_line":56,"start_character":33,"end_line":56,"end_character":46},"updated":"2020-04-24 19:10:04.000000000","message":"I struggled to follow this phrasing. Could we just say, \"add the following content to the file `` or something similar?","commit_id":"a8c7096e500551eb5825253601a224d255c30064"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"b7a8447ab6bac70acbe5a9bb867fbb4f63b5dbbf","unresolved":false,"context_lines":[{"line_number":53,"context_line":"below file"},{"line_number":54,"context_line":"`manifests/function/ephemeral/secret.yaml`."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Add the below contents in runcmd of above file"},{"line_number":57,"context_line":"```"},{"line_number":58,"context_line":"    - export http_proxy\u003dhttp://username:password@host:port"},{"line_number":59,"context_line":"    - export https_proxy\u003d$http_proxy"}],"source_content_type":"text/x-markdown","patch_set":1,"id":"1f493fa4_9bd8a2ef","line":56,"range":{"start_line":56,"start_character":33,"end_line":56,"end_character":46},"in_reply_to":"1f493fa4_6a09be2f","updated":"2020-04-28 14:08:45.000000000","message":"Done","commit_id":"a8c7096e500551eb5825253601a224d255c30064"},{"author":{"_account_id":24580,"name":"James Gu","email":"james.gu@microsoft.com","username":"jamesgu"},"change_message_id":"c1060db54d993842496831fb8a87227dddf688c1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        Environment\u003d\"HTTP_PROXY\u003dhttp://username:password@host:port\""},{"line_number":72,"context_line":"        Environment\u003d\"HTTPS_PROXY\u003dhttp://username:password@host:port\""},{"line_number":73,"context_line":"        Environment\u003d\"NO_PROXY\u003d127.0.0.1,localhost,10.23.25.0/24\""},{"line_number":74,"context_line":"```"},{"line_number":75,"context_line":"## Building airshipctl"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"The simplest way to get started is:"}],"source_content_type":"text/x-markdown","patch_set":1,"id":"1f493fa4_80dccae4","line":74,"updated":"2020-04-27 15:18:20.000000000","message":"should get the proxy settings for the single source as well.","commit_id":"a8c7096e500551eb5825253601a224d255c30064"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"b7a8447ab6bac70acbe5a9bb867fbb4f63b5dbbf","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        Environment\u003d\"HTTP_PROXY\u003dhttp://username:password@host:port\""},{"line_number":72,"context_line":"        Environment\u003d\"HTTPS_PROXY\u003dhttp://username:password@host:port\""},{"line_number":73,"context_line":"        Environment\u003d\"NO_PROXY\u003d127.0.0.1,localhost,10.23.25.0/24\""},{"line_number":74,"context_line":"```"},{"line_number":75,"context_line":"## Building airshipctl"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"The simplest way to get started is:"}],"source_content_type":"text/x-markdown","patch_set":1,"id":"1f493fa4_bb047e4b","line":74,"in_reply_to":"1f493fa4_80dccae4","updated":"2020-04-28 14:08:45.000000000","message":"contents for \"manifests/function/ephemeral/secret.yaml\" is part of site defination. so this have to be put in different section","commit_id":"a8c7096e500551eb5825253601a224d255c30064"},{"author":{"_account_id":31089,"name":"John Williams","email":"jtwill98@yahoo.com","username":"jtwill98"},"change_message_id":"c7ac75fddd40bd7e38c3c23d0f172e8501a6d853","unresolved":false,"context_lines":[{"line_number":59,"context_line":"Add the following contents to the file in write_files section"},{"line_number":60,"context_line":"```"},{"line_number":61,"context_line":"    - path: /etc/systemd/system/docker.service.d/http-proxy.conf"},{"line_number":62,"context_line":"      permissions: \u00270664\u0027"},{"line_number":63,"context_line":"      owner: root:root"},{"line_number":64,"context_line":"      content: |"},{"line_number":65,"context_line":"        [Service]"}],"source_content_type":"text/x-markdown","patch_set":2,"id":"1f493fa4_ee2be691","line":62,"range":{"start_line":62,"start_character":24,"end_line":62,"end_character":25},"updated":"2020-04-28 14:46:31.000000000","message":"General comment, it is not good practice to have root files with 664 permissions.","commit_id":"b3b65c35c83fdd267bdd9aca410fff183da0a4a2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"454228332e99087c5e871a0a6f4a1b82ed982d6a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"Add the following contents to the file in write_files section"},{"line_number":60,"context_line":"```"},{"line_number":61,"context_line":"    - path: /etc/systemd/system/docker.service.d/http-proxy.conf"},{"line_number":62,"context_line":"      permissions: \u00270664\u0027"},{"line_number":63,"context_line":"      owner: root:root"},{"line_number":64,"context_line":"      content: |"},{"line_number":65,"context_line":"        [Service]"}],"source_content_type":"text/x-markdown","patch_set":2,"id":"1f493fa4_b1565f5b","line":62,"range":{"start_line":62,"start_character":24,"end_line":62,"end_character":25},"in_reply_to":"1f493fa4_ee2be691","updated":"2020-04-28 14:59:10.000000000","message":"Done","commit_id":"b3b65c35c83fdd267bdd9aca410fff183da0a4a2"},{"author":{"_account_id":31362,"name":"Andrew Schiefelbein","email":"as3525@att.com","username":"aschiefe"},"change_message_id":"a1a929cb00add331d9237a832fad4f24becf0d94","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        [Service]"},{"line_number":66,"context_line":"        Environment\u003d\"HTTP_PROXY\u003dhttp://username:password@host:port\""},{"line_number":67,"context_line":"        Environment\u003d\"HTTPS_PROXY\u003dhttp://username:password@host:port\""},{"line_number":68,"context_line":"        Environment\u003d\"NO_PROXY\u003d127.0.0.1,localhost,10.23.25.0/24\""},{"line_number":69,"context_line":"```"},{"line_number":70,"context_line":"## Building airshipctl"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":2,"id":"1f493fa4_3b1b4e81","line":68,"range":{"start_line":68,"start_character":49,"end_line":68,"end_character":63},"updated":"2020-04-28 14:14:21.000000000","message":"I\u0027m pretty sure that CIDR blocks don\u0027t work in the NO_PROXY statement.  I\u0027ve had luck with localhost,127.0.0.1,.att.com,172.22.0.1,10.23.25.101","commit_id":"b3b65c35c83fdd267bdd9aca410fff183da0a4a2"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"454228332e99087c5e871a0a6f4a1b82ed982d6a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        [Service]"},{"line_number":66,"context_line":"        Environment\u003d\"HTTP_PROXY\u003dhttp://username:password@host:port\""},{"line_number":67,"context_line":"        Environment\u003d\"HTTPS_PROXY\u003dhttp://username:password@host:port\""},{"line_number":68,"context_line":"        Environment\u003d\"NO_PROXY\u003d127.0.0.1,localhost,10.23.25.0/24\""},{"line_number":69,"context_line":"```"},{"line_number":70,"context_line":"## Building airshipctl"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":2,"id":"1f493fa4_7159778c","line":68,"range":{"start_line":68,"start_character":49,"end_line":68,"end_character":63},"in_reply_to":"1f493fa4_3b1b4e81","updated":"2020-04-28 14:59:10.000000000","message":"with docker 19.03 support to subnet was added. if you are using ubuntu 18.04, docker version is 19.03.6-0ubuntu1~18.04.1. it will support NO_PROXY with subnet.","commit_id":"b3b65c35c83fdd267bdd9aca410fff183da0a4a2"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"cf82a17c2ee559096eee07686720872782e729a5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"`playbooks/vars/local-dev.yaml`."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Apart from adding proxy information to playbook, we have to add proxy information"},{"line_number":47,"context_line":"to site defination documents. For ephemeral iso to pull docker images behind"},{"line_number":48,"context_line":"proxy, user-data section for ephemeral iso have to be updated in below file"},{"line_number":49,"context_line":"`manifests/function/ephemeral/secret.yaml`."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":3,"id":"1f493fa4_42d46b20","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":18},"updated":"2020-04-28 16:04:06.000000000","message":"definitions","commit_id":"3c7ba5538bac645e5147259fff81858ed8bb4a37"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"673e4f4d2638eee2448495728cee4510bdaf2f25","unresolved":false,"context_lines":[{"line_number":44,"context_line":"`playbooks/vars/local-dev.yaml`."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Apart from adding proxy information to playbook, we have to add proxy information"},{"line_number":47,"context_line":"to site defination documents. For ephemeral iso to pull docker images behind"},{"line_number":48,"context_line":"proxy, user-data section for ephemeral iso have to be updated in below file"},{"line_number":49,"context_line":"`manifests/function/ephemeral/secret.yaml`."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":3,"id":"1f493fa4_02754332","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":18},"in_reply_to":"1f493fa4_42d46b20","updated":"2020-04-28 16:06:22.000000000","message":"Done","commit_id":"3c7ba5538bac645e5147259fff81858ed8bb4a37"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"cf82a17c2ee559096eee07686720872782e729a5","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Apart from adding proxy information to playbook, we have to add proxy information"},{"line_number":47,"context_line":"to site defination documents. For ephemeral iso to pull docker images behind"},{"line_number":48,"context_line":"proxy, user-data section for ephemeral iso have to be updated in below file"},{"line_number":49,"context_line":"`manifests/function/ephemeral/secret.yaml`."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Add the following contents to the file in runcmd section"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"1f493fa4_62dfe739","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":47},"updated":"2020-04-28 16:04:06.000000000","message":"has","commit_id":"3c7ba5538bac645e5147259fff81858ed8bb4a37"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"cf82a17c2ee559096eee07686720872782e729a5","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Apart from adding proxy information to playbook, we have to add proxy information"},{"line_number":47,"context_line":"to site defination documents. For ephemeral iso to pull docker images behind"},{"line_number":48,"context_line":"proxy, user-data section for ephemeral iso have to be updated in below file"},{"line_number":49,"context_line":"`manifests/function/ephemeral/secret.yaml`."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Add the following contents to the file in runcmd section"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"1f493fa4_02eee3eb","line":48,"range":{"start_line":48,"start_character":62,"end_line":48,"end_character":70},"updated":"2020-04-28 16:04:06.000000000","message":"in the below","commit_id":"3c7ba5538bac645e5147259fff81858ed8bb4a37"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"673e4f4d2638eee2448495728cee4510bdaf2f25","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Apart from adding proxy information to playbook, we have to add proxy information"},{"line_number":47,"context_line":"to site defination documents. For ephemeral iso to pull docker images behind"},{"line_number":48,"context_line":"proxy, user-data section for ephemeral iso have to be updated in below file"},{"line_number":49,"context_line":"`manifests/function/ephemeral/secret.yaml`."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Add the following contents to the file in runcmd section"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"1f493fa4_e2713746","line":48,"range":{"start_line":48,"start_character":62,"end_line":48,"end_character":70},"in_reply_to":"1f493fa4_02eee3eb","updated":"2020-04-28 16:06:22.000000000","message":"Done","commit_id":"3c7ba5538bac645e5147259fff81858ed8bb4a37"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"673e4f4d2638eee2448495728cee4510bdaf2f25","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Apart from adding proxy information to playbook, we have to add proxy information"},{"line_number":47,"context_line":"to site defination documents. For ephemeral iso to pull docker images behind"},{"line_number":48,"context_line":"proxy, user-data section for ephemeral iso have to be updated in below file"},{"line_number":49,"context_line":"`manifests/function/ephemeral/secret.yaml`."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Add the following contents to the file in runcmd section"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"1f493fa4_4290eb43","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":47},"in_reply_to":"1f493fa4_62dfe739","updated":"2020-04-28 16:06:22.000000000","message":"Done","commit_id":"3c7ba5538bac645e5147259fff81858ed8bb4a37"},{"author":{"_account_id":24580,"name":"James Gu","email":"james.gu@microsoft.com","username":"jamesgu"},"change_message_id":"389c23790045760b02415164f200721f396d1784","unresolved":false,"context_lines":[{"line_number":34,"context_line":"```"},{"line_number":35,"context_line":"HTTP_PROXY\u003dhttp://username:password@host:port"},{"line_number":36,"context_line":"HTTPS_PROXY\u003dhttp://username:password@host:port"},{"line_number":37,"context_line":"NO_PROXY\u003d\"localhost,127.0.0.1\""},{"line_number":38,"context_line":"USE_PROXY\u003dtrue"},{"line_number":39,"context_line":"```"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":5,"id":"1f493fa4_8434be94","line":37,"updated":"2020-04-28 17:20:44.000000000","message":"Do we need to remind the user to add ephemeral ip in the NO_PORXY?","commit_id":"7526c22444bb7ae576adeaee4ee48104599bdc65"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"0751970d78187e48ac96e439056ef228b2df8d02","unresolved":false,"context_lines":[{"line_number":34,"context_line":"```"},{"line_number":35,"context_line":"HTTP_PROXY\u003dhttp://username:password@host:port"},{"line_number":36,"context_line":"HTTPS_PROXY\u003dhttp://username:password@host:port"},{"line_number":37,"context_line":"NO_PROXY\u003d\"localhost,127.0.0.1\""},{"line_number":38,"context_line":"USE_PROXY\u003dtrue"},{"line_number":39,"context_line":"```"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":5,"id":"1f493fa4_27dccce2","line":37,"in_reply_to":"1f493fa4_8434be94","updated":"2020-04-28 18:03:07.000000000","message":"we dont need to set ephemeral ip in the NO_PROXY. This configuration is for the roles where the vms are created. ephemeral ip configuration is on site definitions.","commit_id":"7526c22444bb7ae576adeaee4ee48104599bdc65"}]}