)]}'
{"pkg/remote/redfish/utils.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"a56b86f61bc3bd6c1f7614d83b8a6e837e313fc8","unresolved":false,"context_lines":[{"line_number":89,"context_line":"\t\t\t\treturn \"\", ErrUnrecognizedRedfishResponse{Key: \"error.@Message.ExtendedInfo\"}"},{"line_number":90,"context_line":"\t\t\t}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"\t\t\terrorMessage \u003d fmt.Sprintf(\"%s %s\", errorMessage, message)"},{"line_number":93,"context_line":"\t\t}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"\t\treturn errorMessage, nil"}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_c9029f09","line":92,"range":{"start_line":92,"start_character":3,"end_line":92,"end_character":61},"updated":"2020-04-24 20:14:40.000000000","message":"If the error messages don\u0027t have some sort of guaranteed structure (such as always ending in a period), this will result in strange formatting and hard-to-parse errors. We should collect the messages in a []string and strings.Join at the end with a newline or semicolon.","commit_id":"24bb6e9e61556eb43206776afe1da903905615d5"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"f516b8bb27a006a831a3dc8d636a8e636cac4f2f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"\t\t\t\treturn \"\", ErrUnrecognizedRedfishResponse{Key: \"error.@Message.ExtendedInfo\"}"},{"line_number":90,"context_line":"\t\t\t}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"\t\t\terrorMessage \u003d fmt.Sprintf(\"%s %s\", errorMessage, message)"},{"line_number":93,"context_line":"\t\t}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"\t\treturn errorMessage, nil"}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_495b2f53","line":92,"range":{"start_line":92,"start_character":3,"end_line":92,"end_character":61},"in_reply_to":"1f493fa4_c9029f09","updated":"2020-04-24 21:04:34.000000000","message":"\u003e If the error messages don\u0027t have some sort of guaranteed structure\n \u003e (such as always ending in a period), this will result in strange\n \u003e formatting and hard-to-parse errors. We should collect the messages\n \u003e in a []string and strings.Join at the end with a newline or\n \u003e semicolon.\n\nThat\u0027s a good point. I\u0027ve seen that this is platform-specific, so I joined them with a newline.","commit_id":"24bb6e9e61556eb43206776afe1da903905615d5"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"db9a36ada9958b4b127ab5de0fff731508a7261e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"\t\t\t}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"\t\t\tmessage, err :\u003d processExtendedInfo(infoContent)"},{"line_number":92,"context_line":"\t\t\tif err !\u003d nil {"},{"line_number":93,"context_line":"\t\t\t\treturn \"\", ErrUnrecognizedRedfishResponse{Key: \"error.@Message.ExtendedInfo\"}"},{"line_number":94,"context_line":"\t\t\t}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"\t\t\terrorMessage \u003d fmt.Sprintf(\"%s\\n%s\", message, errorMessage)"},{"line_number":97,"context_line":"\t\t}"}],"source_content_type":"text/x-go","patch_set":3,"id":"1f493fa4_65eb9adb","line":94,"range":{"start_line":92,"start_character":0,"end_line":94,"end_character":4},"updated":"2020-04-27 08:50:23.000000000","message":"Should not we put \u0027return \"\", err\u0027 here ?","commit_id":"b6bb71717cff160efe1a9ebf5e026c1e5784b33c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"bc01425377078986225f5c08cec2fc98c57772d1","unresolved":false,"context_lines":[{"line_number":89,"context_line":"\t\t\t}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"\t\t\tmessage, err :\u003d processExtendedInfo(infoContent)"},{"line_number":92,"context_line":"\t\t\tif err !\u003d nil {"},{"line_number":93,"context_line":"\t\t\t\treturn \"\", ErrUnrecognizedRedfishResponse{Key: \"error.@Message.ExtendedInfo\"}"},{"line_number":94,"context_line":"\t\t\t}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"\t\t\terrorMessage \u003d fmt.Sprintf(\"%s\\n%s\", message, errorMessage)"},{"line_number":97,"context_line":"\t\t}"}],"source_content_type":"text/x-go","patch_set":3,"id":"1f493fa4_236b45f1","line":94,"range":{"start_line":92,"start_character":0,"end_line":94,"end_character":4},"in_reply_to":"1f493fa4_65eb9adb","updated":"2020-04-27 13:36:50.000000000","message":"Done","commit_id":"b6bb71717cff160efe1a9ebf5e026c1e5784b33c"}],"pkg/remote/redfish/utils_test.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"a56b86f61bc3bd6c1f7614d83b8a6e837e313fc8","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"func TestDecodeRawErrorEmptyMalformatted(t *testing.T) {"},{"line_number":74,"context_line":"\t_, err :\u003d redfish.DecodeRawError([]byte(redfishHTTPErrMalformatted))"},{"line_number":75,"context_line":"\tassert.NoError(t, err)"},{"line_number":76,"context_line":"}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"func TestDecodeRawErrorDMTF(t *testing.T) {"}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_095e47e5","line":75,"range":{"start_line":75,"start_character":1,"end_line":75,"end_character":23},"updated":"2020-04-24 20:14:40.000000000","message":"I\u0027m not sure I understand why this shouldn\u0027t be an error.","commit_id":"24bb6e9e61556eb43206776afe1da903905615d5"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"f516b8bb27a006a831a3dc8d636a8e636cac4f2f","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"func TestDecodeRawErrorEmptyMalformatted(t *testing.T) {"},{"line_number":74,"context_line":"\t_, err :\u003d redfish.DecodeRawError([]byte(redfishHTTPErrMalformatted))"},{"line_number":75,"context_line":"\tassert.NoError(t, err)"},{"line_number":76,"context_line":"}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"func TestDecodeRawErrorDMTF(t *testing.T) {"}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_89a7f74f","line":75,"range":{"start_line":75,"start_character":1,"end_line":75,"end_character":23},"in_reply_to":"1f493fa4_095e47e5","updated":"2020-04-24 21:04:34.000000000","message":"\u003e I\u0027m not sure I understand why this shouldn\u0027t be an error.\n\nVery nice catch. Because it\u0027s actually not malformatted (list is good, dictionary is bad), and I didn\u0027t realize I didn\u0027t change the assertion when copying/pasting.\n\nI think we should return an error for empty messages though, so I introduced a test for that. This could have made formatting strange down the line if a BMC ever gave us this response.","commit_id":"24bb6e9e61556eb43206776afe1da903905615d5"}]}