)]}'
{"pkg/clusterctl/client/client.go":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"5530e76d9ccfb8ab65c31cfe70510d2f42f0ab0e","unresolved":false,"context_lines":[{"line_number":97,"context_line":"\t\tConfigClient: cconf,"},{"line_number":98,"context_line":"\t}"},{"line_number":99,"context_line":"\t// option config factory"},{"line_number":100,"context_line":"\toсf :\u003d clusterctlclient.InjectConfig(cconf)"},{"line_number":101,"context_line":"\t// option repository factory"},{"line_number":102,"context_line":"\torf :\u003d clusterctlclient.InjectRepositoryFactory(rf.ClientRepositoryFactory())"},{"line_number":103,"context_line":"\t// options cluster client factory"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_a7157c9e","line":100,"range":{"start_line":100,"start_character":1,"end_line":100,"end_character":4},"updated":"2020-04-28 18:05:32.000000000","message":"my IDE is complaining that one of these is cyrillic, can we change this to ASCII please","commit_id":"bb1fff61d8190b9b30367ad5c7bdbb3b63b9ef3a"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"ad4029467a0f79b6ba4a18a1a339dedd26adcdf6","unresolved":false,"context_lines":[{"line_number":97,"context_line":"\t\tConfigClient: cconf,"},{"line_number":98,"context_line":"\t}"},{"line_number":99,"context_line":"\t// option config factory"},{"line_number":100,"context_line":"\toсf :\u003d clusterctlclient.InjectConfig(cconf)"},{"line_number":101,"context_line":"\t// option repository factory"},{"line_number":102,"context_line":"\torf :\u003d clusterctlclient.InjectRepositoryFactory(rf.ClientRepositoryFactory())"},{"line_number":103,"context_line":"\t// options cluster client factory"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_cdcee22b","line":100,"range":{"start_line":100,"start_character":1,"end_line":100,"end_character":4},"in_reply_to":"1f493fa4_a7157c9e","updated":"2020-04-29 00:32:20.000000000","message":"Done","commit_id":"bb1fff61d8190b9b30367ad5c7bdbb3b63b9ef3a"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"e6cc665c9dc99d8644951531269d0bfc74f4e827","unresolved":false,"context_lines":[{"line_number":1,"context_line":"package client"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import ("},{"line_number":4,"context_line":"\t\"github.com/spf13/afero\""}],"source_content_type":"text/x-go","patch_set":15,"id":"1f493fa4_ccd9b622","line":1,"updated":"2020-04-29 14:29:35.000000000","message":"Add license header","commit_id":"bd1bc17601acf974c8cee1ea63e274b6f6b7c158"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"ff21d200cd34afd1d3adb85b917d06be896446c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"package client"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import ("},{"line_number":4,"context_line":"\t\"github.com/spf13/afero\""}],"source_content_type":"text/x-go","patch_set":15,"id":"1f493fa4_623eabb8","line":1,"in_reply_to":"1f493fa4_ccd9b622","updated":"2020-04-29 14:57:37.000000000","message":"Done","commit_id":"bd1bc17601acf974c8cee1ea63e274b6f6b7c158"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"f21a3104eaa9429babee2a0d874ce8a297804530","unresolved":false,"context_lines":[{"line_number":43,"context_line":"\tinitOptions      clusterctlclient.InitOptions"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"// NewClient returns instance of clusterclt client"},{"line_number":47,"context_line":"func NewClient(root string, options *airshipv1.Clusterctl) (Interface, error) {"},{"line_number":48,"context_line":"\tinitOptions :\u003d options.InitOptions"},{"line_number":49,"context_line":"\tcio :\u003d clusterctlclient.InitOptions{"}],"source_content_type":"text/x-go","patch_set":17,"id":"1f493fa4_3137cb4f","line":46,"range":{"start_line":46,"start_character":33,"end_line":46,"end_character":43},"updated":"2020-04-29 18:43:48.000000000","message":"clusterctl","commit_id":"dde5697fa051e55adca20064e26ba0c174e8a8f0"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"f21a3104eaa9429babee2a0d874ce8a297804530","unresolved":false,"context_lines":[{"line_number":76,"context_line":"\t\t\tType: provider.Type,"},{"line_number":77,"context_line":"\t\t\tURL:  provider.URL,"},{"line_number":78,"context_line":"\t\t}"},{"line_number":79,"context_line":"\t\t// this is a workaround as cluserctl validates if URL is empty, eventhou it is not"},{"line_number":80,"context_line":"\t\t// used anywhere outside repository factory which we override"},{"line_number":81,"context_line":"\t\t// TODO (kkalynovskyi) we need to create issue for this in clusterctl, and remove URL"},{"line_number":82,"context_line":"\t\t// validation and move it to be an error during repository interface initialization"}],"source_content_type":"text/x-go","patch_set":17,"id":"1f493fa4_713cb32e","line":79,"range":{"start_line":79,"start_character":66,"end_line":79,"end_character":74},"updated":"2020-04-29 18:43:48.000000000","message":"even though","commit_id":"dde5697fa051e55adca20064e26ba0c174e8a8f0"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"f21a3104eaa9429babee2a0d874ce8a297804530","unresolved":false,"context_lines":[{"line_number":94,"context_line":"\tif err !\u003d nil {"},{"line_number":95,"context_line":"\t\treturn nil, err"},{"line_number":96,"context_line":"\t}"},{"line_number":97,"context_line":"\t// Set filesystem to global viper object, to make sure, that clusterctl config is rad from"},{"line_number":98,"context_line":"\t// memory filesystem instead of real one."},{"line_number":99,"context_line":"\tviper.SetFs(fs)"},{"line_number":100,"context_line":"\treturn clusterctlconfig.New(confFilePath)"}],"source_content_type":"text/x-go","patch_set":17,"id":"1f493fa4_b142bba9","line":97,"range":{"start_line":97,"start_character":83,"end_line":97,"end_character":86},"updated":"2020-04-29 18:43:48.000000000","message":"read","commit_id":"dde5697fa051e55adca20064e26ba0c174e8a8f0"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"2324688322f7be75d21746b259a698bdbb4dab05","unresolved":false,"context_lines":[{"line_number":38,"context_line":"}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"// Client Implements interface to Clusterctl"},{"line_number":41,"context_line":"type Client struct {"},{"line_number":42,"context_line":"\tclusterctlClient clusterctlclient.Client"},{"line_number":43,"context_line":"\tinitOptions      clusterctlclient.InitOptions"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"// NewClient returns instance of clusterctl client"},{"line_number":47,"context_line":"func NewClient(root string, options *airshipv1.Clusterctl) (Interface, error) {"}],"source_content_type":"text/x-go","patch_set":21,"id":"1f493fa4_c3396fa4","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":1},"updated":"2020-04-30 11:01:59.000000000","message":"can we have different name since \u0027stutter\u0027 : client.Client or make it private to avoid stuttering","commit_id":"07c8fc0b7b47b2b23ec84b6c1df4c48b7de7932a"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4698cb0af06bbdc9fe89fa6e5bcb479d3f7a7095","unresolved":false,"context_lines":[{"line_number":38,"context_line":"}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"// Client Implements interface to Clusterctl"},{"line_number":41,"context_line":"type Client struct {"},{"line_number":42,"context_line":"\tclusterctlClient clusterctlclient.Client"},{"line_number":43,"context_line":"\tinitOptions      clusterctlclient.InitOptions"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"// NewClient returns instance of clusterctl client"},{"line_number":47,"context_line":"func NewClient(root string, options *airshipv1.Clusterctl) (Interface, error) {"}],"source_content_type":"text/x-go","patch_set":21,"id":"1f493fa4_154edb36","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":1},"in_reply_to":"1f493fa4_c3396fa4","updated":"2020-04-30 22:15:15.000000000","message":"\u003e can we have different name since \u0027stutter\u0027 : client.Client or make\n \u003e it private to avoid stuttering\n\nAlso, this is supposedly not considered stuttering, but agree that it should probably be private https://github.com/golang/lint/blob/master/testdata/stutter.go","commit_id":"07c8fc0b7b47b2b23ec84b6c1df4c48b7de7932a"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"2324688322f7be75d21746b259a698bdbb4dab05","unresolved":false,"context_lines":[{"line_number":72,"context_line":"// newConfig returns clusterctl config client"},{"line_number":73,"context_line":"func newConfig(options *airshipv1.Clusterctl) (clusterctlconfig.Client, error) {"},{"line_number":74,"context_line":"\tfs :\u003d afero.NewMemMapFs()"},{"line_number":75,"context_line":"\tcctlprovs :\u003d []*cctlprovider{}"},{"line_number":76,"context_line":"\tfor _, provider :\u003d range options.Providers {"},{"line_number":77,"context_line":"\t\tp :\u003d \u0026cctlprovider{"},{"line_number":78,"context_line":"\t\t\tName: provider.Name,"}],"source_content_type":"text/x-go","patch_set":21,"id":"1f493fa4_a367034d","line":75,"range":{"start_line":75,"start_character":16,"end_line":75,"end_character":31},"updated":"2020-04-30 11:01:59.000000000","message":"is there any specific reason to use pointers ?","commit_id":"07c8fc0b7b47b2b23ec84b6c1df4c48b7de7932a"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"2324688322f7be75d21746b259a698bdbb4dab05","unresolved":false,"context_lines":[{"line_number":88,"context_line":"\t\t}"},{"line_number":89,"context_line":"\t\tcctlprovs \u003d append(cctlprovs, p)"},{"line_number":90,"context_line":"\t}"},{"line_number":91,"context_line":"\tcconf :\u003d cctl{Providers: cctlprovs}"},{"line_number":92,"context_line":"\tdata, err :\u003d yaml.Marshal(cconf)"},{"line_number":93,"context_line":"\tif err !\u003d nil {"},{"line_number":94,"context_line":"\t\treturn nil, err"}],"source_content_type":"text/x-go","patch_set":21,"id":"1f493fa4_a319c3d7","line":91,"range":{"start_line":91,"start_character":1,"end_line":91,"end_character":36},"updated":"2020-04-30 11:01:59.000000000","message":"Why do we need to use separate type struct just for marshalling. Why cant we use map ?\n\nlike  ccconf :\u003d map[string][]cctlprov{}\n\nor even more generic...\n\ta[\"providers\"] \u003d []interface{}{\n\t\tmap[string]string{\n\t\t\t\"name\" :\"asd\",\n                       \"url\": \"asdasdasd\",\n\t\t},\n\t}\n\td, err :\u003d yaml.Marshal(a)\n\tif err !\u003d nil {\n\t  fmt.Println(err)\n\t}\n\tfmt.Println(string(d)","commit_id":"07c8fc0b7b47b2b23ec84b6c1df4c48b7de7932a"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"2324688322f7be75d21746b259a698bdbb4dab05","unresolved":false,"context_lines":[{"line_number":122,"context_line":"\treturn clusterctlclient.New(\"\", ocf, orf, occf)"},{"line_number":123,"context_line":"}"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"type cctl struct {"},{"line_number":126,"context_line":"\tProviders []*cctlprovider `yaml:\"providers\"`"},{"line_number":127,"context_line":"}"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"type cctlprovider struct {"},{"line_number":130,"context_line":"\tName string `yaml:\"name\"`"},{"line_number":131,"context_line":"\tURL  string `yaml:\"url\"`"},{"line_number":132,"context_line":"\tType string `yaml:\"type\"`"},{"line_number":133,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":21,"id":"1f493fa4_4306ff53","line":133,"range":{"start_line":125,"start_character":0,"end_line":133,"end_character":1},"updated":"2020-04-30 11:01:59.000000000","message":"do we need these structs somwhere else besides newConfig function. \nIf \u0027no\u0027 we can move their definition inside of it or even replace them with map[string][]map[string]string ore something like this.","commit_id":"07c8fc0b7b47b2b23ec84b6c1df4c48b7de7932a"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"74e1ef7698f43a75084e0513e9cbb9f9d04188bd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"// Client Implements interface to Clusterctl"},{"line_number":43,"context_line":"type Client struct {"},{"line_number":44,"context_line":"\tclusterctlClient clusterctlclient.Client"},{"line_number":45,"context_line":"\tinitOptions      clusterctlclient.InitOptions"},{"line_number":46,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":22,"id":"1f493fa4_faa4fca7","line":43,"range":{"start_line":43,"start_character":5,"end_line":43,"end_character":11},"updated":"2020-04-30 21:35:35.000000000","message":"note: Dmitry\u0027s feedback on PS 22 is still unaddressed here.","commit_id":"b57c1a2d15c4f7508388952e103e909f4f183f5c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"74e1ef7698f43a75084e0513e9cbb9f9d04188bd","unresolved":false,"context_lines":[{"line_number":95,"context_line":"\t\t}"},{"line_number":96,"context_line":"\t\tb \u003d append(b, p)"},{"line_number":97,"context_line":"\t}"},{"line_number":98,"context_line":"\tcconf :\u003d map[string][]map[string]string{"},{"line_number":99,"context_line":"\t\t\"providers\": b,"},{"line_number":100,"context_line":"\t}"},{"line_number":101,"context_line":"\tdata, err :\u003d yaml.Marshal(cconf)"}],"source_content_type":"text/x-go","patch_set":22,"id":"1f493fa4_7adf4c0c","line":98,"range":{"start_line":98,"start_character":10,"end_line":98,"end_character":21},"updated":"2020-04-30 21:35:35.000000000","message":"nit: do we need a string to map if the mapping value is unused? Seems like it could just be simple array.","commit_id":"b57c1a2d15c4f7508388952e103e909f4f183f5c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"400993efdd8631bbddb0d0f0ca2b8e87eb1bbd89","unresolved":false,"context_lines":[{"line_number":95,"context_line":"\t\t}"},{"line_number":96,"context_line":"\t\tb \u003d append(b, p)"},{"line_number":97,"context_line":"\t}"},{"line_number":98,"context_line":"\tcconf :\u003d map[string][]map[string]string{"},{"line_number":99,"context_line":"\t\t\"providers\": b,"},{"line_number":100,"context_line":"\t}"},{"line_number":101,"context_line":"\tdata, err :\u003d yaml.Marshal(cconf)"}],"source_content_type":"text/x-go","patch_set":22,"id":"1f493fa4_da85c0ae","line":98,"range":{"start_line":98,"start_character":10,"end_line":98,"end_character":21},"in_reply_to":"1f493fa4_7adf4c0c","updated":"2020-04-30 21:48:24.000000000","message":"Disregard this, it won\u0027t be possible since the types are hidden","commit_id":"b57c1a2d15c4f7508388952e103e909f4f183f5c"}],"pkg/clusterctl/client/client_test.go":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"5530e76d9ccfb8ab65c31cfe70510d2f42f0ab0e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"\t\t\tname:            \"clusterctl single repo\","},{"line_number":50,"context_line":"\t\t\tpresentProvider: \"kubeadm\","},{"line_number":51,"context_line":"\t\t\tpresentType:     \"BootstrapProvider\","},{"line_number":52,"context_line":"\t\t\texpectedURL:     \"/home/providers/kubeadm/v0.3.5/componenets.yaml\","},{"line_number":53,"context_line":"\t\t\tconf: \u0026airshipv1.Clusterctl{"},{"line_number":54,"context_line":"\t\t\t\tOptions: \u0026airshipv1.Options{"},{"line_number":55,"context_line":"\t\t\t\t\tConfig: \u0026airshipv1.ClusterctlConfig{"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_076b901d","line":52,"range":{"start_line":52,"start_character":52,"end_line":52,"end_character":63},"updated":"2020-04-28 18:05:32.000000000","message":"components","commit_id":"bb1fff61d8190b9b30367ad5c7bdbb3b63b9ef3a"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"ad4029467a0f79b6ba4a18a1a339dedd26adcdf6","unresolved":false,"context_lines":[{"line_number":49,"context_line":"\t\t\tname:            \"clusterctl single repo\","},{"line_number":50,"context_line":"\t\t\tpresentProvider: \"kubeadm\","},{"line_number":51,"context_line":"\t\t\tpresentType:     \"BootstrapProvider\","},{"line_number":52,"context_line":"\t\t\texpectedURL:     \"/home/providers/kubeadm/v0.3.5/componenets.yaml\","},{"line_number":53,"context_line":"\t\t\tconf: \u0026airshipv1.Clusterctl{"},{"line_number":54,"context_line":"\t\t\t\tOptions: \u0026airshipv1.Options{"},{"line_number":55,"context_line":"\t\t\t\t\tConfig: \u0026airshipv1.ClusterctlConfig{"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_8df17a6e","line":52,"range":{"start_line":52,"start_character":52,"end_line":52,"end_character":63},"in_reply_to":"1f493fa4_076b901d","updated":"2020-04-29 00:32:20.000000000","message":"Done","commit_id":"bb1fff61d8190b9b30367ad5c7bdbb3b63b9ef3a"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"5530e76d9ccfb8ab65c31cfe70510d2f42f0ab0e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"\t\t\t\t\t\tProviders: []*airshipv1.Provider{"},{"line_number":57,"context_line":"\t\t\t\t\t\t\t{"},{"line_number":58,"context_line":"\t\t\t\t\t\t\t\tName:                   \"kubeadm\","},{"line_number":59,"context_line":"\t\t\t\t\t\t\t\tURL:                    \"/home/providers/kubeadm/v0.3.5/componenets.yaml\","},{"line_number":60,"context_line":"\t\t\t\t\t\t\t\tType:                   \"BootstrapProvider\","},{"line_number":61,"context_line":"\t\t\t\t\t\t\t\tIsClusterctlRepository: true,"},{"line_number":62,"context_line":"\t\t\t\t\t\t\t},"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_677414ff","line":59,"range":{"start_line":59,"start_character":64,"end_line":59,"end_character":75},"updated":"2020-04-28 18:05:32.000000000","message":"components","commit_id":"bb1fff61d8190b9b30367ad5c7bdbb3b63b9ef3a"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"ad4029467a0f79b6ba4a18a1a339dedd26adcdf6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"\t\t\t\t\t\tProviders: []*airshipv1.Provider{"},{"line_number":57,"context_line":"\t\t\t\t\t\t\t{"},{"line_number":58,"context_line":"\t\t\t\t\t\t\t\tName:                   \"kubeadm\","},{"line_number":59,"context_line":"\t\t\t\t\t\t\t\tURL:                    \"/home/providers/kubeadm/v0.3.5/componenets.yaml\","},{"line_number":60,"context_line":"\t\t\t\t\t\t\t\tType:                   \"BootstrapProvider\","},{"line_number":61,"context_line":"\t\t\t\t\t\t\t\tIsClusterctlRepository: true,"},{"line_number":62,"context_line":"\t\t\t\t\t\t\t},"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_6df6ae65","line":59,"range":{"start_line":59,"start_character":64,"end_line":59,"end_character":75},"in_reply_to":"1f493fa4_677414ff","updated":"2020-04-29 00:32:20.000000000","message":"Done","commit_id":"bb1fff61d8190b9b30367ad5c7bdbb3b63b9ef3a"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"5530e76d9ccfb8ab65c31cfe70510d2f42f0ab0e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"\t\t\t},"},{"line_number":66,"context_line":"\t\t},"},{"line_number":67,"context_line":"\t\t{"},{"line_number":68,"context_line":"\t\t\tname:            \"muptiple repos with airship\","},{"line_number":69,"context_line":"\t\t\tpresentProvider: \"airship-repo\","},{"line_number":70,"context_line":"\t\t\tpresentType:     \"InfrastructureProvider\","},{"line_number":71,"context_line":"\t\t\texpectedURL:     dummyComponentPath,"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_674d34c3","line":68,"range":{"start_line":68,"start_character":21,"end_line":68,"end_character":29},"updated":"2020-04-28 18:05:32.000000000","message":"multiple","commit_id":"bb1fff61d8190b9b30367ad5c7bdbb3b63b9ef3a"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"ad4029467a0f79b6ba4a18a1a339dedd26adcdf6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"\t\t\t},"},{"line_number":66,"context_line":"\t\t},"},{"line_number":67,"context_line":"\t\t{"},{"line_number":68,"context_line":"\t\t\tname:            \"muptiple repos with airship\","},{"line_number":69,"context_line":"\t\t\tpresentProvider: \"airship-repo\","},{"line_number":70,"context_line":"\t\t\tpresentType:     \"InfrastructureProvider\","},{"line_number":71,"context_line":"\t\t\texpectedURL:     dummyComponentPath,"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_adec368f","line":68,"range":{"start_line":68,"start_character":21,"end_line":68,"end_character":29},"in_reply_to":"1f493fa4_674d34c3","updated":"2020-04-29 00:32:20.000000000","message":"Done","commit_id":"bb1fff61d8190b9b30367ad5c7bdbb3b63b9ef3a"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"5530e76d9ccfb8ab65c31cfe70510d2f42f0ab0e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"\t\t\t\t\t\tProviders: []*airshipv1.Provider{"},{"line_number":76,"context_line":"\t\t\t\t\t\t\t{"},{"line_number":77,"context_line":"\t\t\t\t\t\t\t\tName:                   \"airship-repo\","},{"line_number":78,"context_line":"\t\t\t\t\t\t\t\tURL:                    \"/home/providers/my-repo/v0.3.5/componenets.yaml\","},{"line_number":79,"context_line":"\t\t\t\t\t\t\t\tType:                   \"InfrastructureProvider\","},{"line_number":80,"context_line":"\t\t\t\t\t\t\t\tIsClusterctlRepository: false,"},{"line_number":81,"context_line":"\t\t\t\t\t\t\t\tVersions: map[string]string{"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_a763bc41","line":78,"range":{"start_line":78,"start_character":64,"end_line":78,"end_character":75},"updated":"2020-04-28 18:05:32.000000000","message":"components","commit_id":"bb1fff61d8190b9b30367ad5c7bdbb3b63b9ef3a"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"ad4029467a0f79b6ba4a18a1a339dedd26adcdf6","unresolved":false,"context_lines":[{"line_number":75,"context_line":"\t\t\t\t\t\tProviders: []*airshipv1.Provider{"},{"line_number":76,"context_line":"\t\t\t\t\t\t\t{"},{"line_number":77,"context_line":"\t\t\t\t\t\t\t\tName:                   \"airship-repo\","},{"line_number":78,"context_line":"\t\t\t\t\t\t\t\tURL:                    \"/home/providers/my-repo/v0.3.5/componenets.yaml\","},{"line_number":79,"context_line":"\t\t\t\t\t\t\t\tType:                   \"InfrastructureProvider\","},{"line_number":80,"context_line":"\t\t\t\t\t\t\t\tIsClusterctlRepository: false,"},{"line_number":81,"context_line":"\t\t\t\t\t\t\t\tVersions: map[string]string{"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_0d056a46","line":78,"range":{"start_line":78,"start_character":64,"end_line":78,"end_character":75},"in_reply_to":"1f493fa4_a763bc41","updated":"2020-04-29 00:32:20.000000000","message":"Done","commit_id":"bb1fff61d8190b9b30367ad5c7bdbb3b63b9ef3a"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"5530e76d9ccfb8ab65c31cfe70510d2f42f0ab0e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"\t\t\t\t\t\t\t},"},{"line_number":85,"context_line":"\t\t\t\t\t\t\t{"},{"line_number":86,"context_line":"\t\t\t\t\t\t\t\tName:                   \"kubeadm\","},{"line_number":87,"context_line":"\t\t\t\t\t\t\t\tURL:                    \"/home/providers/kubeadm/v0.3.5/componenets.yaml\","},{"line_number":88,"context_line":"\t\t\t\t\t\t\t\tType:                   \"BootstrapProvider\","},{"line_number":89,"context_line":"\t\t\t\t\t\t\t\tIsClusterctlRepository: true,"},{"line_number":90,"context_line":"\t\t\t\t\t\t\t},"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_e759448e","line":87,"range":{"start_line":87,"start_character":64,"end_line":87,"end_character":75},"updated":"2020-04-28 18:05:32.000000000","message":"components","commit_id":"bb1fff61d8190b9b30367ad5c7bdbb3b63b9ef3a"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"ad4029467a0f79b6ba4a18a1a339dedd26adcdf6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"\t\t\t\t\t\t\t},"},{"line_number":85,"context_line":"\t\t\t\t\t\t\t{"},{"line_number":86,"context_line":"\t\t\t\t\t\t\t\tName:                   \"kubeadm\","},{"line_number":87,"context_line":"\t\t\t\t\t\t\t\tURL:                    \"/home/providers/kubeadm/v0.3.5/componenets.yaml\","},{"line_number":88,"context_line":"\t\t\t\t\t\t\t\tType:                   \"BootstrapProvider\","},{"line_number":89,"context_line":"\t\t\t\t\t\t\t\tIsClusterctlRepository: true,"},{"line_number":90,"context_line":"\t\t\t\t\t\t\t},"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_ed011e3a","line":87,"range":{"start_line":87,"start_character":64,"end_line":87,"end_character":75},"in_reply_to":"1f493fa4_e759448e","updated":"2020-04-29 00:32:20.000000000","message":"Done","commit_id":"bb1fff61d8190b9b30367ad5c7bdbb3b63b9ef3a"}],"pkg/clusterctl/client/factory.go":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"5530e76d9ccfb8ab65c31cfe70510d2f42f0ab0e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"\t\to :\u003d repository.InjectRepository(repo)"},{"line_number":64,"context_line":"\t\treturn repository.New(provider, f.ConfigClient, o)"},{"line_number":65,"context_line":"\t}"},{"line_number":66,"context_line":"\t// if repository is clusterctl pass, simply use default clusterct repository interface"},{"line_number":67,"context_line":"\treturn repository.New(provider, f.ConfigClient)"},{"line_number":68,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_87cde032","line":66,"range":{"start_line":66,"start_character":57,"end_line":66,"end_character":66},"updated":"2020-04-28 18:05:32.000000000","message":"clusterctl","commit_id":"bb1fff61d8190b9b30367ad5c7bdbb3b63b9ef3a"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"ad4029467a0f79b6ba4a18a1a339dedd26adcdf6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"\t\to :\u003d repository.InjectRepository(repo)"},{"line_number":64,"context_line":"\t\treturn repository.New(provider, f.ConfigClient, o)"},{"line_number":65,"context_line":"\t}"},{"line_number":66,"context_line":"\t// if repository is clusterctl pass, simply use default clusterct repository interface"},{"line_number":67,"context_line":"\treturn repository.New(provider, f.ConfigClient)"},{"line_number":68,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_4dfbf245","line":66,"range":{"start_line":66,"start_character":57,"end_line":66,"end_character":66},"in_reply_to":"1f493fa4_87cde032","updated":"2020-04-29 00:32:20.000000000","message":"Done","commit_id":"bb1fff61d8190b9b30367ad5c7bdbb3b63b9ef3a"}],"pkg/clusterctl/client/factory_test.go":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"5530e76d9ccfb8ab65c31cfe70510d2f42f0ab0e","unresolved":false,"context_lines":[{"line_number":168,"context_line":"\t}"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"\tpclient :\u003d configClient.Providers()"},{"line_number":171,"context_line":"\tprovider, err :\u003d pclient.Get(\"custom-airship-infra\", clusterctlv1.ProviderType(\"InfrastructureProvider\"))"},{"line_number":172,"context_line":"\trequire.NoError(t, err)"},{"line_number":173,"context_line":"\trepoClient, err :\u003d factory.repoFactory(provider)"},{"line_number":174,"context_line":"\trequire.NoError(t, err)"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_67fb7446","line":171,"range":{"start_line":171,"start_character":54,"end_line":171,"end_character":105},"updated":"2020-04-28 18:05:32.000000000","message":"redundant type conversion, ProviderType is a string, but you\u0027re passing a string to convert to a string.\n\ncan replace with just \"InfrastructureProvider\"","commit_id":"bb1fff61d8190b9b30367ad5c7bdbb3b63b9ef3a"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"5530e76d9ccfb8ab65c31cfe70510d2f42f0ab0e","unresolved":false,"context_lines":[{"line_number":193,"context_line":"\t}"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"\tpclient :\u003d configClient.Providers()"},{"line_number":196,"context_line":"\tprovider, err :\u003d pclient.Get(\"aws\", clusterctlv1.ProviderType(\"InfrastructureProvider\"))"},{"line_number":197,"context_line":"\trequire.NoError(t, err)"},{"line_number":198,"context_line":"\trepoClient, err :\u003d factory.repoFactory(provider)"},{"line_number":199,"context_line":"\trequire.NoError(t, err)"}],"source_content_type":"text/x-go","patch_set":6,"id":"1f493fa4_47f8f847","line":196,"range":{"start_line":196,"start_character":37,"end_line":196,"end_character":88},"updated":"2020-04-28 18:05:32.000000000","message":"ditto","commit_id":"bb1fff61d8190b9b30367ad5c7bdbb3b63b9ef3a"}]}