)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"cc505ffe8059f434ec85dea1497cb5771485d3e5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* Defines catalogue-specific endpoint catalogues \u0026 replacement rules"},{"line_number":32,"context_line":"* Adds a script to set up airshipctl as a kustomize plugin"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Some RFC points - feedback welcome:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* The fluentd endpoint info isn\u0027t copied into the openstack entpoint catalogue,"},{"line_number":37,"context_line":"  instead it\u0027s just replaced from the lma endpoint catalogue directly into"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_4e31d6a2","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":15},"updated":"2020-05-04 03:51:34.000000000","message":"There is one more RFC point from my side:\nhow this model will work with multiple repositories,\nwhen DE will have several sites that are based on different version of treasuremap or NC and NC, treasuremap are located in 3 different git repos (I believe we planned to have this use-case supported).\n\nI think that there will be one more action item because of that: we need to tyr to integrate this model with our document pull command and see how they all work together and maybe adjust the command and/or the model.","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"bb3313851810fef6e99b1acad9131c8116ee4aad","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* Defines catalogue-specific endpoint catalogues \u0026 replacement rules"},{"line_number":32,"context_line":"* Adds a script to set up airshipctl as a kustomize plugin"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Some RFC points - feedback welcome:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* The fluentd endpoint info isn\u0027t copied into the openstack entpoint catalogue,"},{"line_number":37,"context_line":"  instead it\u0027s just replaced from the lma endpoint catalogue directly into"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_302c7b46","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":15},"in_reply_to":"1f493fa4_4e31d6a2","updated":"2020-05-05 20:58:58.000000000","message":"Agree.  To make the modules outlined in this PS useful/reusable, we need to rely on document pull, and the ability of modules in one repo to reliably reference modules in another.","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"8e2185241c0c4dcdc8be6b3389b0827775514d5f","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* The fluentd endpoint info isn\u0027t copied into the openstack entpoint catalogue,"},{"line_number":37,"context_line":"  instead it\u0027s just replaced from the lma endpoint catalogue directly into"},{"line_number":38,"context_line":"  openstack charts. This seems less complex with no badness I can think of."},{"line_number":39,"context_line":"* `reference-cloud` was the best I could come up with for a \"normal cloud"},{"line_number":40,"context_line":"  setup that has openstack and LMA and maybe other things in the future\"."},{"line_number":41,"context_line":"  Any better ideas?"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_819d7e0c","line":38,"range":{"start_line":38,"start_character":20,"end_line":38,"end_character":75},"updated":"2020-05-02 03:38:16.000000000","message":"agree, it\u0027s not necessary to copy all params from lower catalogues to upper all the time. it\u0027s possible to modify any catalogue param even from \u0027site\u0027 level by the following sequence in transformer: set  needed variable in transformer+ call replacement transformers after that.  \nIt\u0027s needed only if there are several lower functions, that must have the same values in their catalog and in that case composite level will define this var and copy it\u0027s value to all necessary catalogs of lower functions in its replacement.","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"bb3313851810fef6e99b1acad9131c8116ee4aad","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* The fluentd endpoint info isn\u0027t copied into the openstack entpoint catalogue,"},{"line_number":37,"context_line":"  instead it\u0027s just replaced from the lma endpoint catalogue directly into"},{"line_number":38,"context_line":"  openstack charts. This seems less complex with no badness I can think of."},{"line_number":39,"context_line":"* `reference-cloud` was the best I could come up with for a \"normal cloud"},{"line_number":40,"context_line":"  setup that has openstack and LMA and maybe other things in the future\"."},{"line_number":41,"context_line":"  Any better ideas?"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_907c6f21","line":38,"range":{"start_line":38,"start_character":20,"end_line":38,"end_character":75},"in_reply_to":"1f493fa4_819d7e0c","updated":"2020-05-05 20:58:58.000000000","message":"Since document patching is performed before transformers are applied, a simple patch to a catalogue at the site-level should get picked up by any \"imported\" transformers, right?","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"001b4f9d567dea9cfa8ff8b71620dc4e5e0a172c","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* The fluentd endpoint info isn\u0027t copied into the openstack entpoint catalogue,"},{"line_number":37,"context_line":"  instead it\u0027s just replaced from the lma endpoint catalogue directly into"},{"line_number":38,"context_line":"  openstack charts. This seems less complex with no badness I can think of."},{"line_number":39,"context_line":"* `reference-cloud` was the best I could come up with for a \"normal cloud"},{"line_number":40,"context_line":"  setup that has openstack and LMA and maybe other things in the future\"."},{"line_number":41,"context_line":"  Any better ideas?"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_74fffc66","line":38,"range":{"start_line":38,"start_character":20,"end_line":38,"end_character":75},"in_reply_to":"1f493fa4_907c6f21","updated":"2020-05-07 04:43:46.000000000","message":"in 2 words - yes. to be more precise - patches are also done by transformers, but external transformes are executed after inbuilt transofrmers. here is more info: https://github.com/kubernetes-sigs/kustomize/blob/master/docs/howItWorks.md","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"8e2185241c0c4dcdc8be6b3389b0827775514d5f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  openstack charts. This seems less complex with no badness I can think of."},{"line_number":39,"context_line":"* `reference-cloud` was the best I could come up with for a \"normal cloud"},{"line_number":40,"context_line":"  setup that has openstack and LMA and maybe other things in the future\"."},{"line_number":41,"context_line":"  Any better ideas?"},{"line_number":42,"context_line":"* There\u0027s no \"/global\"; it seemed to add an extra layer of nesting for minimal"},{"line_number":43,"context_line":"  values.  We good with that?"},{"line_number":44,"context_line":"* Namespaces are left as defaults in functions, and applied in composites."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_c18666bb","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":19},"updated":"2020-05-02 03:38:16.000000000","message":"I think it\u0027s enough as a first example to give an idea how model will look like.","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"8e2185241c0c4dcdc8be6b3389b0827775514d5f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  setup that has openstack and LMA and maybe other things in the future\"."},{"line_number":41,"context_line":"  Any better ideas?"},{"line_number":42,"context_line":"* There\u0027s no \"/global\"; it seemed to add an extra layer of nesting for minimal"},{"line_number":43,"context_line":"  values.  We good with that?"},{"line_number":44,"context_line":"* Namespaces are left as defaults in functions, and applied in composites."},{"line_number":45,"context_line":"* This PS has some per-phase stuff per site.  Is it a reasonable amount?"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_41bc166c","line":43,"range":{"start_line":43,"start_character":10,"end_line":43,"end_character":29},"updated":"2020-05-02 03:38:16.000000000","message":"came to the same result :) didn\u0027t need global -it was empty and I wasn\u0027t sure what we should put there. global seems like a shared \u0027function\u0027 that can be used by everyone. but what should be used by everyone? :)","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"8e2185241c0c4dcdc8be6b3389b0827775514d5f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  Any better ideas?"},{"line_number":42,"context_line":"* There\u0027s no \"/global\"; it seemed to add an extra layer of nesting for minimal"},{"line_number":43,"context_line":"  values.  We good with that?"},{"line_number":44,"context_line":"* Namespaces are left as defaults in functions, and applied in composites."},{"line_number":45,"context_line":"* This PS has some per-phase stuff per site.  Is it a reasonable amount?"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Change-Id: I8a98e79ab40477ffb63fb117034876ab88b328f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_e17ba2bb","line":44,"range":{"start_line":44,"start_character":2,"end_line":44,"end_character":12},"updated":"2020-05-02 03:38:16.000000000","message":"hmm.. really good comment. actually. what will be if one composite uses another one? probably there will be 2 namespaces right? or we probably shouldn\u0027t use composite from composite...\nor create a special layer - \u0027namespace\u0027?\ni think we\u0027re fine for now, because we have a strict correlation between namespace and composite. if needed it\u0027s not a big issue to add one more layer in our module. I think the most difficult things will happen on function level (because it will be component specific) and site level (because of bm nodes and hw profiles and all that staff). Composites will have a pretty big transformer configurations, but pretty simple resource model and it is easy to figure our what to do with it.","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"bb3313851810fef6e99b1acad9131c8116ee4aad","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  Any better ideas?"},{"line_number":42,"context_line":"* There\u0027s no \"/global\"; it seemed to add an extra layer of nesting for minimal"},{"line_number":43,"context_line":"  values.  We good with that?"},{"line_number":44,"context_line":"* Namespaces are left as defaults in functions, and applied in composites."},{"line_number":45,"context_line":"* This PS has some per-phase stuff per site.  Is it a reasonable amount?"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Change-Id: I8a98e79ab40477ffb63fb117034876ab88b328f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_d0ef17e7","line":44,"range":{"start_line":44,"start_character":2,"end_line":44,"end_character":12},"in_reply_to":"1f493fa4_e17ba2bb","updated":"2020-05-05 20:58:58.000000000","message":"Agree, I don\u0027t think we\u0027re backing ourselves into any corner by going this route.  If in the future, composites need to override other composites\u0027 namespaces, it shouldn\u0027t be a problem.","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"8e2185241c0c4dcdc8be6b3389b0827775514d5f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* There\u0027s no \"/global\"; it seemed to add an extra layer of nesting for minimal"},{"line_number":43,"context_line":"  values.  We good with that?"},{"line_number":44,"context_line":"* Namespaces are left as defaults in functions, and applied in composites."},{"line_number":45,"context_line":"* This PS has some per-phase stuff per site.  Is it a reasonable amount?"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Change-Id: I8a98e79ab40477ffb63fb117034876ab88b328f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_81129e61","line":45,"range":{"start_line":45,"start_character":46,"end_line":45,"end_character":72},"updated":"2020-05-02 03:38:16.000000000","message":"if you doubt, that the reviewers understand why you added catalog \u0027phases\u0027 on site and type level + \u0027shared\u0027 on site level, probably we should reference some doc somewhere. But the whose who familiar with the topic will find that it is enough","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"bb3313851810fef6e99b1acad9131c8116ee4aad","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* There\u0027s no \"/global\"; it seemed to add an extra layer of nesting for minimal"},{"line_number":43,"context_line":"  values.  We good with that?"},{"line_number":44,"context_line":"* Namespaces are left as defaults in functions, and applied in composites."},{"line_number":45,"context_line":"* This PS has some per-phase stuff per site.  Is it a reasonable amount?"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Change-Id: I8a98e79ab40477ffb63fb117034876ab88b328f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_30e11b00","line":45,"range":{"start_line":45,"start_character":46,"end_line":45,"end_character":72},"in_reply_to":"1f493fa4_81129e61","updated":"2020-05-05 20:58:58.000000000","message":"Cool, that sounds good to me too.  Documenting \"outcomes\" from these discussions will be a top priority for me; I think the PTG in 1 month would be a good opportunity to walk through them and make sure everyone\u0027s on the same page!","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"aa4e0a833eeca20666a8c22a1d16839317eb3f93","unresolved":false,"context_lines":[{"line_number":38,"context_line":"* `reference-cloud` was the best I could come up with for a \"normal cloud"},{"line_number":39,"context_line":"  setup that has openstack and LMA and maybe other things in the future\"."},{"line_number":40,"context_line":"  Any better ideas?"},{"line_number":41,"context_line":"* There\u0027s no \"/global\"; it seemed to add an extra layer of nesting for minimal"},{"line_number":42,"context_line":"  values.  We good with that?"},{"line_number":43,"context_line":"* Namespaces are left as defaults in functions, and applied in composites."},{"line_number":44,"context_line":"* This PS has some per-phase stuff per site.  Is it a reasonable amount?"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"ff570b3c_82fb9345","line":41,"range":{"start_line":41,"start_character":13,"end_line":41,"end_character":22},"updated":"2020-06-10 03:45:31.000000000","message":"Just a little question:\nI see that now we have globals dir - it contains crds.\nI still don\u0027t think that we need globals, we could create a dir named crd. I\u0027m not sure that crd we have will be really global (means - shared by everyone). Last Friday on PTG it was discussed that we\u0027re going to split Openstack and K8s deployment. Openstack won\u0027t need globals/crd - that\u0027s why that globals won\u0027t be so global :)\n\nAnother example - I know there are plans to deploy k8s in clouds: Openstack, Azure. Baremetal related staff won\u0027t be global for manifests that deploy k8s in clouds.\n\nI\u0027m not sure we have to put crds to globals. We\u0027re going to split the model into modules. if module needs some crd, it will include it, or will include the module that contain that crd.","commit_id":"720bb768b19977090cb737c4010cf98c7c4638f9"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"093bc9db8f0ccaa6c547edff36722dd3baf6ae49","unresolved":false,"context_lines":[{"line_number":38,"context_line":"* `reference-cloud` was the best I could come up with for a \"normal cloud"},{"line_number":39,"context_line":"  setup that has openstack and LMA and maybe other things in the future\"."},{"line_number":40,"context_line":"  Any better ideas?"},{"line_number":41,"context_line":"* There\u0027s no \"/global\"; it seemed to add an extra layer of nesting for minimal"},{"line_number":42,"context_line":"  values.  We good with that?"},{"line_number":43,"context_line":"* Namespaces are left as defaults in functions, and applied in composites."},{"line_number":44,"context_line":"* This PS has some per-phase stuff per site.  Is it a reasonable amount?"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"ff570b3c_908d8fd5","line":41,"range":{"start_line":41,"start_character":13,"end_line":41,"end_character":22},"in_reply_to":"ff570b3c_82fb9345","updated":"2020-06-10 19:47:19.000000000","message":"Whoops, this was accidental -- those are not new crds, those are existing crds from \"manifests\" that I accidentally copied into \"manifests-example\"!  I\u0027ll get rid of them.\n\nI agree, I think CRDs should be encapsulated in functions, in airshipctl, treasuremap, or openstack-helm as appropriate.  I added a topic to the upcoming sig-yaml meeting to sort out what should go where.","commit_id":"720bb768b19977090cb737c4010cf98c7c4638f9"}],"manifests-example/global/crd/baremetal-operator/kustomization.yaml":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"e36cf0b42429b905552284cf198472927f9015a8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"resources:"},{"line_number":2,"context_line":"  - metal3.io_baremetalhosts_crd.yaml"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ff570b3c_8dcbc348","line":1,"updated":"2020-06-10 09:58:03.000000000","message":"are we putting crds to global? what if someone does not want to have these crds deployed to k8s cluster","commit_id":"720bb768b19977090cb737c4010cf98c7c4638f9"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"093bc9db8f0ccaa6c547edff36722dd3baf6ae49","unresolved":false,"context_lines":[{"line_number":1,"context_line":"resources:"},{"line_number":2,"context_line":"  - metal3.io_baremetalhosts_crd.yaml"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ff570b3c_30b6438c","line":1,"in_reply_to":"ff570b3c_8dcbc348","updated":"2020-06-10 19:47:19.000000000","message":"You\u0027re right, this was an accident on my part :)  see my note to Alexey","commit_id":"720bb768b19977090cb737c4010cf98c7c4638f9"}],"manifests-example/site/test-workload/shared/catalogues/site-networking.yaml":[{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"03abc2313cd9d4df64a3eeceef5cb64d0b92267a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: airshipit.org/v1alpha1"},{"line_number":2,"context_line":"kind: VariableCatalogue"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: site-networking-catalogue"},{"line_number":5,"context_line":"  labels:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"bf51134e_596a7f19","line":2,"range":{"start_line":2,"start_character":6,"end_line":2,"end_character":23},"updated":"2020-06-24 20:45:10.000000000","message":"Matt, it may be you want to change api/kind for catalogues:\nthe reason is here [1]. if you change this to ConfigMap you will be able to make it as a model without post-filtering and that will be completely kustomize-compatible\n\n[1]\nhttps://docs.google.com/presentation/d/1gCAIsETGFYjVim0ChEQHmDwTtrJWbcFiBbFGDN7gQXA/edit#slide\u003did.g8a0edd2c65_0_1","commit_id":"b8efeb5e99a88d739339e6e51dc949040a14c9bc"}],"manifests/composite/lma/replacements/prometheus.yaml":[{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"8e2185241c0c4dcdc8be6b3389b0827775514d5f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# These rules inject endpoint information from the `lma-endpoint-catalogue`"},{"line_number":2,"context_line":"# into the lma composite\u0027s prometheus function."},{"line_number":3,"context_line":"apiVersion: airshipit.org/v1alpha1"},{"line_number":4,"context_line":"kind: ReplacementTransformer"},{"line_number":5,"context_line":"metadata:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_a1d51aba","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":47},"updated":"2020-05-02 03:38:16.000000000","message":"Thinking about the name of this file\nprometheus.yaml. if we have only 1 catalogue - that\u0027s ok.\nif for some reason (e.g. very long catalogue), we want to have several catalogues in one composite/funcion, may be put both source and target names into name of transformer config? that would hint what to find where.\nwas thinking about options:\nlma-endpoint-catalogue-to-prometheus.yaml is too long, but\nif we remove \u0027catalogue\u0027 from all names it will be \nlma-endpoint2prometheus.yaml\n\nand if we don\u0027t plan go have several catalogues in one composite, may be the name catalogue.yaml could be enough?\n(analogy - values.yaml in helm plays a very similar role)","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"}],"manifests/site/test-workload/shared/catalogues/site-networking.yaml":[{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"8e2185241c0c4dcdc8be6b3389b0827775514d5f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  name: site-networking-catalogue"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    airshipit.org/deploy: false"},{"line_number":7,"context_line":"spec:"},{"line_number":8,"context_line":"  domain: test-site.com"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_e171e20e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"updated":"2020-05-02 03:38:16.000000000","message":"JFYI: there is a bug in kustomize: if for some reason in future we want to use generator with annotation kustomize.config.k8s.io/behavior: \"merge\" for catalogs, kustomize only merged info specified in \u0027data\u0027. it doesn\u0027t work for spec...\n\nTo avoid this for now we can use \u0027data:\u0027\nor go and fix the bug :)","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"2ba03386b92d5826d6c26f803661126413c9dbb4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  name: site-networking-catalogue"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    airshipit.org/deploy: false"},{"line_number":7,"context_line":"spec:"},{"line_number":8,"context_line":"  domain: test-site.com"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_aacb0d51","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"1f493fa4_e171e20e","updated":"2020-05-12 13:35:05.000000000","message":"Good catch - I think this would be a good thing for us to fix in Kustomize, since we don\u0027t have an immediate need for this functionality.  I think `spec` would be better since it\u0027s the norm, all else equal.  If we find we do need to generate+merge for catalogues, we could change course.  Sound good?","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"49c31967ae19a87cb5e6bbdbb94f01885b25aff3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  name: site-networking-catalogue"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    airshipit.org/deploy: false"},{"line_number":7,"context_line":"spec:"},{"line_number":8,"context_line":"  domain: test-site.com"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_371a16c5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"ff570b3c_5e39baef","updated":"2020-06-09 17:45:04.000000000","message":"I think I\u0027ve changed my mind on this... `data` is really no worse than `spec` in this context anyway, and it may actually make more sense.  If kustomize gives it a privileged position, may as well go with it.","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"7f6e42652ac9e4338f2b263723a63b64244fc4d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  name: site-networking-catalogue"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    airshipit.org/deploy: false"},{"line_number":7,"context_line":"spec:"},{"line_number":8,"context_line":"  domain: test-site.com"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_ee0992dd","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"ff570b3c_aacb0d51","updated":"2020-05-12 16:44:32.000000000","message":"yes. agreed :)","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"82d15ca1b878153563df472db5772e071e451def","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  name: site-networking-catalogue"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    airshipit.org/deploy: false"},{"line_number":7,"context_line":"spec:"},{"line_number":8,"context_line":"  domain: test-site.com"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_5e39baef","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"ff570b3c_ee0992dd","updated":"2020-06-04 04:47:17.000000000","message":"just for the history:\nlooking into [1] I think now it\u0027s more or less clear why it works only with \u0027data\u0027 :)\n\n[1]\nhttps://github.com/kubernetes-sigs/kustomize/blob/master/api/resource/resource.go#L310","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"}],"manifests/type/test-workload/phases/workload/replacements/kustomization.yaml":[{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"57e84ae3a8e12fc41b9fc1e0674dcb5ff72bd11c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: kustomize.config.k8s.io/v1beta1"},{"line_number":2,"context_line":"kind: Kustomization"},{"line_number":3,"context_line":"resources:"},{"line_number":4,"context_line":"  - ../../../../../composite/reference-cloud/replacements"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_152d24a8","line":4,"range":{"start_line":4,"start_character":45,"end_line":4,"end_character":57},"updated":"2020-05-02 20:06:42.000000000","message":"I think \u0027transformers\u0027 is better. we don\u0027t know if we use only replacement transformers in future. and kustomize \u0027terminology\u0027 calls this transformers. I suggest to rename everywhere to keep more \u0027generic\u0027 name.","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"bb3313851810fef6e99b1acad9131c8116ee4aad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: kustomize.config.k8s.io/v1beta1"},{"line_number":2,"context_line":"kind: Kustomization"},{"line_number":3,"context_line":"resources:"},{"line_number":4,"context_line":"  - ../../../../../composite/reference-cloud/replacements"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_70f443d0","line":4,"range":{"start_line":4,"start_character":45,"end_line":4,"end_character":57},"in_reply_to":"1f493fa4_152d24a8","updated":"2020-05-05 20:58:58.000000000","message":"I think it\u0027s a question of:\n\n1) what transformers will we want to \"export\" to be applied at lower levels, vs, taking the simpler approach of applying transformers \"within\" a module?  Replacements have to be exported because they can\u0027t be applied till e.g. site-level data is available.  Can you think of other examples?\n\n2) will we always want to apply the transformer (replacements + etc) at the same time, e.g., at the site level? -- if we do decide to export them, then applying them consistently at site level seems reasonable to me.\n\nIn general I like \"replacements\" better because it IS less generic.  However, if we need to do this kind of thing for multiple transformers then it would probably be more convenient to bundle them into one kustomization.\n\nThe only use case that\u0027s coming to my mind though, might be if we needed to export generators, which may make sense to define in a generic module and then apply at the site.  However generators aren\u0027t transformers :) so we might need to come up with an even more generic name in that case...","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"001b4f9d567dea9cfa8ff8b71620dc4e5e0a172c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: kustomize.config.k8s.io/v1beta1"},{"line_number":2,"context_line":"kind: Kustomization"},{"line_number":3,"context_line":"resources:"},{"line_number":4,"context_line":"  - ../../../../../composite/reference-cloud/replacements"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_f475ccfb","line":4,"range":{"start_line":4,"start_character":45,"end_line":4,"end_character":57},"in_reply_to":"1f493fa4_70f443d0","updated":"2020-05-07 04:43:46.000000000","message":"\u003e1. ... \nI don\u0027t see any that we want to export so far...\nThat\u0027s because we don\u0027t plan to use functions separately - only via site level. And because modules are suppoesed always to follow the same behavior: we have catalog + resources in it. if you want to change resources - you need to change catalog and execute transformers. That behavior is similar to what helm does, with only difference that helm generates resources based on values.yaml, and we transform resources based on catalog.yaml. It is simple, it\u0027s transparent.\n\n\u003e 2 ...\nkustomization/kustomization.yaml will be a bit weird :)\none more option is \u0027transformations\u0027... But.. I don\u0027t really want to push here:\nit\u0027s not a big deal if we keep \u0027replacements\u0027 if you like it and hope that replacements will be the only type of transformers (I\u0027m not 100% sure, because Airship2 should have a pretty long history in future and probably there will be new ideas related to transformers). Again if we keep 1 repo it\u0027s not a big deal. The only concern I think of - that later renaming will be a breaking change when we switch to multi-repostory model. because it will be necessary to simultaneously change all repos. But again -it\u0027s a terminology. for kustomize it doesn\u0027t matter how this catalog is named. it will work whatever we call it :) The only person who won\u0027t be happy if we have more transformers in future and still have \u0027replacements\u0027 as a name will be my internal \u0027perfectionist\u0027 :) .","commit_id":"c2f73716dd0b4123cf5ba8ffc30205f4c262dff0"}],"playbooks/airship-airshipctl-validate-documents.yaml":[{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"732aa1bb0f3b778ee4db6e33f25a5de9d8545283","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        update_cache: yes"},{"line_number":39,"context_line":"        state: present"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    - name: Ensuring kubectl is present"},{"line_number":42,"context_line":"      shell: |"},{"line_number":43,"context_line":"        set -xe;"},{"line_number":44,"context_line":"        ./tools/gate/05_install_kubectl.sh"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ff570b3c_b1d372d5","line":41,"range":{"start_line":41,"start_character":6,"end_line":41,"end_character":11},"updated":"2020-05-27 03:44:56.000000000","message":"generic comment - I\u0027m not sure that tools/gate is a right place for that scripts... that\u0027s because of the initial intention of that directory. Please see the comments below","commit_id":"5a99daf4c3421cbcd2614cd89b46d911747886f7"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"732aa1bb0f3b778ee4db6e33f25a5de9d8545283","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    - name: Ensuring kubectl is present"},{"line_number":42,"context_line":"      shell: |"},{"line_number":43,"context_line":"        set -xe;"},{"line_number":44,"context_line":"        ./tools/gate/05_install_kubectl.sh"},{"line_number":45,"context_line":"      become: yes"},{"line_number":46,"context_line":"      args:"},{"line_number":47,"context_line":"        chdir: \"{{ zuul.project.src_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ff570b3c_1127be14","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":42},"updated":"2020-05-27 03:44:56.000000000","message":"hmm. the original intention of tools/gate/ scripts was to emulate gating behavior on the developer machine. they all call playbooks except 00\n\nnot sure we should call tools/gate from playbooks.. the concern is that typically we call playbooks from tools/gate. \nnow it\u0027s 2 way calls that may be confusing a bit.\nI remember we discussed Pete\u0027s suggestion that we should use bash to emulate work with airship, but I guess it\u0027s not the case here","commit_id":"5a99daf4c3421cbcd2614cd89b46d911747886f7"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"732aa1bb0f3b778ee4db6e33f25a5de9d8545283","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        CLUSTER: \"airship\""},{"line_number":61,"context_line":"      shell: |"},{"line_number":62,"context_line":"        set -xe;"},{"line_number":63,"context_line":"        ./tools/gate/05_start_kind.sh"},{"line_number":64,"context_line":"      args:"},{"line_number":65,"context_line":"        chdir: \"{{ zuul.project.src_dir }}\""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ff570b3c_717b9af3","line":63,"range":{"start_line":63,"start_character":21,"end_line":63,"end_character":37},"updated":"2020-05-27 03:44:56.000000000","message":"probably the same as above","commit_id":"5a99daf4c3421cbcd2614cd89b46d911747886f7"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"732aa1bb0f3b778ee4db6e33f25a5de9d8545283","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        CONTEXT: \"kind-airship\""},{"line_number":71,"context_line":"      shell: |"},{"line_number":72,"context_line":"        set -xe;"},{"line_number":73,"context_line":"        ./tools/gate/22_validate_documents.sh"},{"line_number":74,"context_line":"      args:"},{"line_number":75,"context_line":"        chdir: \"{{ zuul.project.src_dir }}\""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ff570b3c_f14faabb","line":73,"range":{"start_line":73,"start_character":16,"end_line":73,"end_character":20},"updated":"2020-05-27 03:44:56.000000000","message":"maybe, create another folder for what Pete said.. call it: tests \nso tools/gate call playbooks and playbooks call tools/tests ?","commit_id":"5a99daf4c3421cbcd2614cd89b46d911747886f7"}],"zuul.d/projects.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"42d9b391eedae4f6bd2dba395cd03d4bb62b313b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- project:"},{"line_number":14,"context_line":"    vars:"},{"line_number":15,"context_line":"      sphinx_build_dir: docs/build"},{"line_number":16,"context_line":"    check:"},{"line_number":17,"context_line":"      jobs:"},{"line_number":18,"context_line":"        - airship-airshipctl-roles-test:"},{"line_number":19,"context_line":"            files:"},{"line_number":20,"context_line":"              - \"roles/*\""},{"line_number":21,"context_line":"        - openstack-tox-docs"},{"line_number":22,"context_line":"        - airship-airshipctl-lint-unit"},{"line_number":23,"context_line":"        - airship-airshipctl-build-image"},{"line_number":24,"context_line":"        - airship-airshipctl-validate-documents"},{"line_number":25,"context_line":"#        - airship-airshipctl-functional-existing-k8s TODO: Enable this when functional tests exist, and a cluster is up"},{"line_number":26,"context_line":"        - airship-airshipctl-gate-test"},{"line_number":27,"context_line":"        - airship-airshipctl-32GB-gate-test"},{"line_number":28,"context_line":"    gate:"},{"line_number":29,"context_line":"      jobs:"},{"line_number":30,"context_line":"        - openstack-tox-docs"},{"line_number":31,"context_line":"        - airship-airshipctl-lint-unit"},{"line_number":32,"context_line":"        - airship-airshipctl-lint-unit"},{"line_number":33,"context_line":"        - airship-airshipctl-build-image"},{"line_number":34,"context_line":"        - airship-airshipctl-validate-documents"},{"line_number":35,"context_line":"#        - airship-airshipctl-functional-existing-k8s TODO: Enable this when functional tests exist, and a cluster is up"},{"line_number":36,"context_line":"        - airship-airshipctl-gate-test"},{"line_number":37,"context_line":"    post:"},{"line_number":38,"context_line":"      jobs:"},{"line_number":39,"context_line":"        - airship-airshipctl-publish-image"},{"line_number":40,"context_line":"        - airship-airshipctl-upload-git-mirror"},{"line_number":41,"context_line":"    promote:"},{"line_number":42,"context_line":"      jobs:"},{"line_number":43,"context_line":"        - promote-airship-project-docs"},{"line_number":44,"context_line":"        - airship-airshipctl-update-github-issues"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff570b3c_550e4932","line":44,"range":{"start_line":13,"start_character":2,"end_line":44,"end_character":0},"updated":"2020-05-26 18:25:31.000000000","message":"Job airship-airshipctl-validate-documents not defined","commit_id":"280d887cbe3316e2edce93188261ef55473eb8e4"}]}