)]}'
{"cmd/config/get_management_config.go":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"0eefe77b8d0ab9eca2241702cd8741087cf3e161","unresolved":false,"context_lines":[{"line_number":23,"context_line":")"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"// NewGetManagementConfigCommand creates a command that enables printing a management configuration to stdout."},{"line_number":26,"context_line":"func NewGetManagementConfigCommand(rootSettings *environment.AirshipCTLSettings) *cobra.Command {"},{"line_number":27,"context_line":"\tcmd :\u003d \u0026cobra.Command{"},{"line_number":28,"context_line":"\t\tUse:     \"get-management-config [NAME]\","},{"line_number":29,"context_line":"\t\tShort:   \"View a management config in the airshipctl config\","}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_3d339015","line":26,"range":{"start_line":26,"start_character":5,"end_line":26,"end_character":34},"updated":"2020-05-07 13:34:13.000000000","message":"this should be added to docs/source/cli/cli.rst as well","commit_id":"f4e0d3b0b3b4597a80f0529b1ccf9abbb8df2cb1"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"5731a49351805aa25138619b40f866bd6b73d7cb","unresolved":false,"context_lines":[{"line_number":23,"context_line":")"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"// NewGetManagementConfigCommand creates a command that enables printing a management configuration to stdout."},{"line_number":26,"context_line":"func NewGetManagementConfigCommand(rootSettings *environment.AirshipCTLSettings) *cobra.Command {"},{"line_number":27,"context_line":"\tcmd :\u003d \u0026cobra.Command{"},{"line_number":28,"context_line":"\t\tUse:     \"get-management-config [NAME]\","},{"line_number":29,"context_line":"\t\tShort:   \"View a management config in the airshipctl config\","}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_f88c96d8","line":26,"range":{"start_line":26,"start_character":5,"end_line":26,"end_character":34},"in_reply_to":"1f493fa4_3d339015","updated":"2020-05-07 14:01:52.000000000","message":"Done","commit_id":"f4e0d3b0b3b4597a80f0529b1ccf9abbb8df2cb1"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"0eefe77b8d0ab9eca2241702cd8741087cf3e161","unresolved":false,"context_lines":[{"line_number":25,"context_line":"// NewGetManagementConfigCommand creates a command that enables printing a management configuration to stdout."},{"line_number":26,"context_line":"func NewGetManagementConfigCommand(rootSettings *environment.AirshipCTLSettings) *cobra.Command {"},{"line_number":27,"context_line":"\tcmd :\u003d \u0026cobra.Command{"},{"line_number":28,"context_line":"\t\tUse:     \"get-management-config [NAME]\","},{"line_number":29,"context_line":"\t\tShort:   \"View a management config in the airshipctl config\","},{"line_number":30,"context_line":"\t\tArgs:    cobra.MaximumNArgs(1),"},{"line_number":31,"context_line":"\t\tAliases: []string{\"get-management-configs\"},"},{"line_number":32,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":33,"context_line":"\t\t\tif len(args) \u003d\u003d 1 {"}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_58fe6a05","line":30,"range":{"start_line":28,"start_character":2,"end_line":30,"end_character":32},"updated":"2020-05-07 13:34:13.000000000","message":"if this command only supports printing a single management config, then the cobra.MaximumNArgs() should be replaced by cobra.ExactArgs(1), see [0]\n\nthis will allow you to clean up your validations on lines 33-50\n\nIf the intent is to allow you to print all management configs airshipctl knows about, then leaving as MaxArgs is fine but the help should be updated to reflect that intent.\n\nAfter reviewing the rest of the patchset it looks like your intended direction was to support all when no args are present, and a defined config if present.\n\n[0] https://github.com/spf13/cobra#positional-and-custom-arguments","commit_id":"f4e0d3b0b3b4597a80f0529b1ccf9abbb8df2cb1"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"5731a49351805aa25138619b40f866bd6b73d7cb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"// NewGetManagementConfigCommand creates a command that enables printing a management configuration to stdout."},{"line_number":26,"context_line":"func NewGetManagementConfigCommand(rootSettings *environment.AirshipCTLSettings) *cobra.Command {"},{"line_number":27,"context_line":"\tcmd :\u003d \u0026cobra.Command{"},{"line_number":28,"context_line":"\t\tUse:     \"get-management-config [NAME]\","},{"line_number":29,"context_line":"\t\tShort:   \"View a management config in the airshipctl config\","},{"line_number":30,"context_line":"\t\tArgs:    cobra.MaximumNArgs(1),"},{"line_number":31,"context_line":"\t\tAliases: []string{\"get-management-configs\"},"},{"line_number":32,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":33,"context_line":"\t\t\tif len(args) \u003d\u003d 1 {"}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_189222f7","line":30,"range":{"start_line":28,"start_character":2,"end_line":30,"end_character":32},"in_reply_to":"1f493fa4_58fe6a05","updated":"2020-05-07 14:01:52.000000000","message":"\u003e If the intent is to allow you to print all management configs\n \u003e airshipctl knows about, then leaving as MaxArgs is fine but the\n \u003e help should be updated to reflect that intent.\n\nThis is the intention. Done.","commit_id":"f4e0d3b0b3b4597a80f0529b1ccf9abbb8df2cb1"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"03fc5bfc05fb05a212703de0752dcaeab4fae1f8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"\t\t\tif len(args) \u003d\u003d 1 {"},{"line_number":43,"context_line":"\t\t\t\tname :\u003d args[0]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"\t\t\t\tconfig, err :\u003d rootSettings.Config.ManagementConfigurationByName(name)"},{"line_number":46,"context_line":"\t\t\t\tif err !\u003d nil {"},{"line_number":47,"context_line":"\t\t\t\t\treturn err"},{"line_number":48,"context_line":"\t\t\t\t}"}],"source_content_type":"text/x-go","patch_set":3,"id":"1f493fa4_6571f1de","line":45,"range":{"start_line":45,"start_character":39,"end_line":45,"end_character":68},"updated":"2020-05-08 10:04:14.000000000","message":"see my comment for parent CR","commit_id":"de4bf52c527d0dbef60a1570dcb746c4fe96f1fa"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"1de4a7b4233f0f7003c5d1ddae150117ec2c75a9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"\t\t\tif len(args) \u003d\u003d 1 {"},{"line_number":43,"context_line":"\t\t\t\tname :\u003d args[0]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"\t\t\t\tconfig, err :\u003d rootSettings.Config.ManagementConfigurationByName(name)"},{"line_number":46,"context_line":"\t\t\t\tif err !\u003d nil {"},{"line_number":47,"context_line":"\t\t\t\t\treturn err"},{"line_number":48,"context_line":"\t\t\t\t}"}],"source_content_type":"text/x-go","patch_set":3,"id":"1f493fa4_1e6dd303","line":45,"range":{"start_line":45,"start_character":39,"end_line":45,"end_character":68},"in_reply_to":"1f493fa4_6571f1de","updated":"2020-05-08 17:10:22.000000000","message":"Done","commit_id":"de4bf52c527d0dbef60a1570dcb746c4fe96f1fa"}],"cmd/config/get_management_config_test.go":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"0eefe77b8d0ab9eca2241702cd8741087cf3e161","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":"Copyright 2014 The Kubernetes Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_584caa75","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":38},"updated":"2020-05-07 13:34:13.000000000","message":"is this accurate?","commit_id":"f4e0d3b0b3b4597a80f0529b1ccf9abbb8df2cb1"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"5731a49351805aa25138619b40f866bd6b73d7cb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":"Copyright 2014 The Kubernetes Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-go","patch_set":2,"id":"1f493fa4_53276db7","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":38},"in_reply_to":"1f493fa4_584caa75","updated":"2020-05-07 14:01:52.000000000","message":"Done","commit_id":"f4e0d3b0b3b4597a80f0529b1ccf9abbb8df2cb1"}]}