)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"720fb36384f3630c6b02316e3739786a6b2b827d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix default Airshipctl config parameters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Problem description:"},{"line_number":10,"context_line":"Once we execute airshipctl config init, the default config in ~/.airship/config doesn\u0027t contain default values for:"},{"line_number":11,"context_line":"currentContext: ~"},{"line_number":12,"context_line":"clusters:"},{"line_number":13,"context_line":"  default:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_8bdc4875","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":115},"updated":"2020-05-12 16:27:41.000000000","message":"wrap this line to 72 characters","commit_id":"ed87563c5ea9ab5aecf78bed6ab8dbe6490ca852"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"720fb36384f3630c6b02316e3739786a6b2b827d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix default Airshipctl config parameters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Problem description:"},{"line_number":10,"context_line":"Once we execute airshipctl config init, the default config in ~/.airship/config doesn\u0027t contain default values for:"},{"line_number":11,"context_line":"currentContext: ~"},{"line_number":12,"context_line":"clusters:"},{"line_number":13,"context_line":"  default:"},{"line_number":14,"context_line":"    clusterType:"},{"line_number":15,"context_line":"      target:"},{"line_number":16,"context_line":"        bootstrapInfo: ~"},{"line_number":17,"context_line":"        managementConfiguration: ~"},{"line_number":18,"context_line":"This PS set default values for Airshipctl config to use it out from the box."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I57449e678f19ab1c0e2212c38b01ea195f62aa44"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_ab514cdb","line":17,"range":{"start_line":9,"start_character":0,"end_line":17,"end_character":34},"updated":"2020-05-12 16:27:41.000000000","message":"can we have issue link instead of problem description.\ne.g.\nCloses: #github_issue_number\nor\nRelates-To: #github_issue_number","commit_id":"ed87563c5ea9ab5aecf78bed6ab8dbe6490ca852"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"32f1b99bbcd6528e7f3c62473f75101f34ef41ac","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        managementConfiguration: ~"},{"line_number":19,"context_line":"---"},{"line_number":20,"context_line":"This PS set default values for Airshipctl config to use it"},{"line_number":21,"context_line":"out from the box."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"2) The manifest checkout section contains mutually exclusive checkout"},{"line_number":24,"context_line":"parameters by default."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff570b3c_b51c056b","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":8},"updated":"2020-05-12 20:10:36.000000000","message":"of","commit_id":"469d350a0db8a1e7451969e68d06df9cb79d9886"},{"author":{"_account_id":20106,"name":"Alexander Noskov","email":"anoskov@mirantis.com","username":"alexander_noskov"},"change_message_id":"726b42b9c55b1cd16141d38f666c42ee2072c70d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        managementConfiguration: ~"},{"line_number":19,"context_line":"---"},{"line_number":20,"context_line":"This PS set default values for Airshipctl config to use it"},{"line_number":21,"context_line":"out from the box."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"2) The manifest checkout section contains mutually exclusive checkout"},{"line_number":24,"context_line":"parameters by default."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff570b3c_42932afb","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":8},"in_reply_to":"ff570b3c_b51c056b","updated":"2020-05-12 22:10:46.000000000","message":"Done","commit_id":"469d350a0db8a1e7451969e68d06df9cb79d9886"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"32f1b99bbcd6528e7f3c62473f75101f34ef41ac","unresolved":false,"context_lines":[{"line_number":20,"context_line":"This PS set default values for Airshipctl config to use it"},{"line_number":21,"context_line":"out from the box."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"2) The manifest checkout section contains mutually exclusive checkout"},{"line_number":24,"context_line":"parameters by default."},{"line_number":25,"context_line":"---"},{"line_number":26,"context_line":"This PS set only one parameter (branch) by default,commitHash and tag"},{"line_number":27,"context_line":"are empty."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Closes: #233"},{"line_number":30,"context_line":"Closes: #234"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff570b3c_1514d1f4","line":27,"range":{"start_line":23,"start_character":0,"end_line":27,"end_character":10},"updated":"2020-05-12 20:10:36.000000000","message":"Do not see how this CR solves problem of setting all parameters at the same time. It\u0027s just affecting marshal/unmarshal behaviour","commit_id":"469d350a0db8a1e7451969e68d06df9cb79d9886"},{"author":{"_account_id":20106,"name":"Alexander Noskov","email":"anoskov@mirantis.com","username":"alexander_noskov"},"change_message_id":"726b42b9c55b1cd16141d38f666c42ee2072c70d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"This PS set default values for Airshipctl config to use it"},{"line_number":21,"context_line":"out from the box."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"2) The manifest checkout section contains mutually exclusive checkout"},{"line_number":24,"context_line":"parameters by default."},{"line_number":25,"context_line":"---"},{"line_number":26,"context_line":"This PS set only one parameter (branch) by default,commitHash and tag"},{"line_number":27,"context_line":"are empty."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Closes: #233"},{"line_number":30,"context_line":"Closes: #234"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff570b3c_821a627a","line":27,"range":{"start_line":23,"start_character":0,"end_line":27,"end_character":10},"in_reply_to":"ff570b3c_1514d1f4","updated":"2020-05-12 22:10:46.000000000","message":"By default, `airshipctl config init` generates checkout options with predefined values:\n        checkout:\n          branch: master\n          commitHash: master\n          force: false\n          remoteRef: master\n          tag: \"\"\nWhich cause en error during the `airshipctl document pull` execution like described in https://github.com/airshipit/airshipctl/issues/233\nWith these changes, the resulted config looks like: \n        checkout:\n          branch: master\n          commitHash: \"\"\n          force: false\n          tag: \"\"\nand doesn\u0027t require manual modifications.\nBTW: moved this changes to https://review.opendev.org/#/c/727476/","commit_id":"469d350a0db8a1e7451969e68d06df9cb79d9886"}],"pkg/config/config.go":[{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"720fb36384f3630c6b02316e3739786a6b2b827d","unresolved":false,"context_lines":[{"line_number":188,"context_line":"\t\t}"},{"line_number":189,"context_line":"\t\tconfigCluster :\u003d c.Clusters[clusterComplexName.Name].ClusterTypes[clusterComplexName.Type]"},{"line_number":190,"context_line":"\t\tconfigCluster.NameInKubeconf \u003d clusterComplexName.String()"},{"line_number":191,"context_line":"\t\tconfigCluster.Bootstrap \u003d AirshipDefaultContext"},{"line_number":192,"context_line":"\t\tconfigCluster.ManagementConfiguration \u003d AirshipDefaultContext"},{"line_number":193,"context_line":"\t\t// Store the reference to the KubeConfig Cluster in the Airship Config"},{"line_number":194,"context_line":"\t\tconfigCluster.SetKubeCluster(cluster)"}],"source_content_type":"text/x-go","patch_set":2,"id":"ff570b3c_abc66c66","line":191,"range":{"start_line":191,"start_character":28,"end_line":191,"end_character":49},"updated":"2020-05-12 16:27:41.000000000","message":"can we have separate constant for bootstrap since context is specific entity in terms of airshipctl","commit_id":"ed87563c5ea9ab5aecf78bed6ab8dbe6490ca852"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"720fb36384f3630c6b02316e3739786a6b2b827d","unresolved":false,"context_lines":[{"line_number":189,"context_line":"\t\tconfigCluster :\u003d c.Clusters[clusterComplexName.Name].ClusterTypes[clusterComplexName.Type]"},{"line_number":190,"context_line":"\t\tconfigCluster.NameInKubeconf \u003d clusterComplexName.String()"},{"line_number":191,"context_line":"\t\tconfigCluster.Bootstrap \u003d AirshipDefaultContext"},{"line_number":192,"context_line":"\t\tconfigCluster.ManagementConfiguration \u003d AirshipDefaultContext"},{"line_number":193,"context_line":"\t\t// Store the reference to the KubeConfig Cluster in the Airship Config"},{"line_number":194,"context_line":"\t\tconfigCluster.SetKubeCluster(cluster)"},{"line_number":195,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":2,"id":"ff570b3c_eba504b7","line":192,"range":{"start_line":192,"start_character":42,"end_line":192,"end_character":63},"updated":"2020-05-12 16:27:41.000000000","message":"ditto","commit_id":"ed87563c5ea9ab5aecf78bed6ab8dbe6490ca852"}]}