)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"cd4bcea40a18bfa249f89568989acb64da865cc9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check python3-netaddr is installed within sushy-emulator role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently there is no verification whether pyhton netaddr package"},{"line_number":10,"context_line":"is installed on ansible controller. The absence of this package causes"},{"line_number":11,"context_line":"apache-wsgi-sushy-emulator task to fail. This patch adds appropriate"},{"line_number":12,"context_line":"check and install the package if needed."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_f8074381","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":34},"updated":"2020-05-16 04:24:10.000000000","message":"I see that gating is working now without that changes.\nWhat is the purpose of this changes?","commit_id":"309c43e22aa29368c3c4bc7f852552afefdb46d5"}],"roles/apache-wsgi-sushy-emulator/tasks/frontend.yaml":[{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"cd4bcea40a18bfa249f89568989acb64da865cc9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    msg: \"Only Debian|Ubuntu are currently supported\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Ensure python3-netaddr is installed"},{"line_number":20,"context_line":"  package:"},{"line_number":21,"context_line":"    name: python3-netaddr"},{"line_number":22,"context_line":"    state: present"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_78d21302","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":10},"updated":"2020-05-16 04:24:10.000000000","message":"become: true ?","commit_id":"309c43e22aa29368c3c4bc7f852552afefdb46d5"},{"author":{"_account_id":21040,"name":"Alexey","email":"aodinokov@mirantis.com","username":"aodinokov"},"change_message_id":"017833379c0d091b568edeba78f7fe73cba9f3f1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  fail:"},{"line_number":17,"context_line":"    msg: \"Only Debian|Ubuntu are currently supported\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Ensure python3-netaddr is installed"},{"line_number":20,"context_line":"  become: yes"},{"line_number":21,"context_line":"  package:"},{"line_number":22,"context_line":"    name: python3-netaddr"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_fbea9d0c","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":43},"updated":"2020-05-16 06:33:57.000000000","message":"ok.. \u0027become\u0027 helped :)\nIt doesn\u0027t seem a right place for that. because another module also uses ipwrap [1] and if you put it here and disable it later, it will be necessary to add it to the second module.\nBut they both use [2].\nAs we discussed offline, potentially adding this to the module [2] should look better\n\n[1]\nhttps://opendev.org/airship/airshipctl/src/branch/master/roles/apache-file-exchanger/templates/conf.j2\n[2]\nhttps://opendev.org/airship/airshipctl/src/branch/master/roles/apache-server","commit_id":"ef1950497596f1edfddc36a255c3510072693f79"}],"tools/gate/00_setup.sh":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"6160833c9588026662b56462bbe9e2ec22011ae2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"sudo apt -y install software-properties-common python3-pip"},{"line_number":36,"context_line":"sudo apt -y --no-install-recommends install docker.io make"},{"line_number":37,"context_line":"if [[ -z \"${http_proxy}\" ]]; then"},{"line_number":38,"context_line":"  sudo pip3 install ansible netaddr"},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"  sudo pip3 --proxy \"${http_proxy}\" install ansible netaddr"},{"line_number":41,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff570b3c_d4e4aae2","line":38,"updated":"2020-05-18 20:36:11.000000000","message":"It\u0027s a principle that the roles in this repository must be executable on their own. If we install netaddr here, then we will not be able to use the sushy roles without running this script, which may be removed in the future. Could we add this in the ansible itself?","commit_id":"08c7983c89bc073f3bee2854fe021f545a8a67b8"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"8b0953230ca4d8ec746fc50fe4d0046225f2de59","unresolved":false,"context_lines":[{"line_number":35,"context_line":"sudo apt -y install software-properties-common python3-pip"},{"line_number":36,"context_line":"sudo apt -y --no-install-recommends install docker.io make"},{"line_number":37,"context_line":"if [[ -z \"${http_proxy}\" ]]; then"},{"line_number":38,"context_line":"  sudo pip3 install ansible netaddr"},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"  sudo pip3 --proxy \"${http_proxy}\" install ansible netaddr"},{"line_number":41,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff570b3c_97ea340c","line":38,"range":{"start_line":38,"start_character":7,"end_line":38,"end_character":11},"updated":"2020-05-18 21:00:55.000000000","message":"Why do you use pip? Why not apt? Like I have in my abandoned one: https://review.opendev.org/726903","commit_id":"08c7983c89bc073f3bee2854fe021f545a8a67b8"},{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"b7320a58600177a77229b76d6c3a98b3c6b1fc39","unresolved":false,"context_lines":[{"line_number":35,"context_line":"sudo apt -y install software-properties-common python3-pip"},{"line_number":36,"context_line":"sudo apt -y --no-install-recommends install docker.io make"},{"line_number":37,"context_line":"if [[ -z \"${http_proxy}\" ]]; then"},{"line_number":38,"context_line":"  sudo pip3 install ansible netaddr"},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"  sudo pip3 --proxy \"${http_proxy}\" install ansible netaddr"},{"line_number":41,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff570b3c_b72ad828","line":38,"range":{"start_line":38,"start_character":7,"end_line":38,"end_character":11},"in_reply_to":"ff570b3c_97ea340c","updated":"2020-05-18 21:07:59.000000000","message":"It doesn\u0027t matter which way to install, ansible should have an ability to import netaddr package in python code, both options works - pip and apt. From the docs [1]\n\n\"To use this filter in Ansible, you need to install the netaddr Python library on a computer on which you use Ansible (it is not required on remote hosts). It can usually be installed with either your system package manager or using pip\"\n\nSince it\u0027s ansible dependency it will make more sense to add it to the line within ansible installation part.\n\n[1] https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters_ipaddr.html","commit_id":"08c7983c89bc073f3bee2854fe021f545a8a67b8"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"e2d8736c3f88410d07603b4dc911629bd5f162b0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"sudo apt -y install software-properties-common python3-pip"},{"line_number":36,"context_line":"sudo apt -y --no-install-recommends install docker.io make"},{"line_number":37,"context_line":"if [[ -z \"${http_proxy}\" ]]; then"},{"line_number":38,"context_line":"  sudo pip3 install ansible netaddr"},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"  sudo pip3 --proxy \"${http_proxy}\" install ansible netaddr"},{"line_number":41,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff570b3c_f7cd7085","line":38,"range":{"start_line":38,"start_character":7,"end_line":38,"end_character":11},"in_reply_to":"ff570b3c_b72ad828","updated":"2020-05-18 21:11:50.000000000","message":"Ok, I got it. Thanks. One small suggestion: maybe it\u0027s better to use one var to define a list of packages and provide it for apt with/without proxy as a var name to remove duplication.","commit_id":"08c7983c89bc073f3bee2854fe021f545a8a67b8"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"40047f6849a4f3b7ef57c47ebdf92cdb6150e1b7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"sudo apt -y install software-properties-common python3-pip"},{"line_number":36,"context_line":"sudo apt -y --no-install-recommends install docker.io make"},{"line_number":37,"context_line":"if [[ -z \"${http_proxy}\" ]]; then"},{"line_number":38,"context_line":"  sudo pip3 install ansible netaddr"},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"  sudo pip3 --proxy \"${http_proxy}\" install ansible netaddr"},{"line_number":41,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff570b3c_f4256e0a","line":38,"in_reply_to":"ff570b3c_d4e4aae2","updated":"2020-05-18 20:41:02.000000000","message":"This is actually a correct place for this package. Netaddr is required by ansible plugin, which is executed on the ansible controller. Whatever you install in playbooks, is installed on remote host against which role is executed, so for example if we are running role on remote host, and not localhost, adding it in playbook will not help. This should be a prerequisite for ansible installation itself, not the playbook.","commit_id":"08c7983c89bc073f3bee2854fe021f545a8a67b8"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"0ec81119c0e1b81a2b61adcf854c3c112cf5d13c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"sudo apt -y install software-properties-common python3-pip"},{"line_number":36,"context_line":"sudo apt -y --no-install-recommends install docker.io make"},{"line_number":37,"context_line":"if [[ -z \"${http_proxy}\" ]]; then"},{"line_number":38,"context_line":"  sudo pip3 install ansible netaddr"},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"  sudo pip3 --proxy \"${http_proxy}\" install ansible netaddr"},{"line_number":41,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff570b3c_d754ac00","line":38,"in_reply_to":"ff570b3c_f4256e0a","updated":"2020-05-18 20:55:56.000000000","message":"\u003e This is actually a correct place for this package. Netaddr is\n \u003e required by ansible plugin, which is executed on the ansible\n \u003e controller. Whatever you install in playbooks, is installed on\n \u003e remote host against which role is executed, so for example if we\n \u003e are running role on remote host, and not localhost, adding it in\n \u003e playbook will not help. This should be a prerequisite for ansible\n \u003e installation itself, not the playbook.\n\nThanks for the explanation. This makes sense","commit_id":"08c7983c89bc073f3bee2854fe021f545a8a67b8"}]}