)]}'
{"playbooks/airship-airshipctl-validate-documents.yaml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"c281b237253edef5613fc346400d37441c0dbf2a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      become: yes"},{"line_number":26,"context_line":"      when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_release \u003d\u003d \u0027bionic\u0027"},{"line_number":27,"context_line":"      apt_repository:"},{"line_number":28,"context_line":"        repo: ppa:longsleep/golang-backports"},{"line_number":29,"context_line":"        update_cache: no"},{"line_number":30,"context_line":"        state: present"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_46d3de38","line":28,"range":{"start_line":28,"start_character":14,"end_line":28,"end_character":44},"updated":"2020-06-01 21:28:59.000000000","message":"Shouldn\u0027t we prefer the official installation method [0] (by tar) over an untrusted PPA? Ideally, if we only need Go to build airshipctl, we could just extract the binary from the Docker image using the systemwide executable role [1].\n\n[0] https://golang.org/doc/install#install\n[1] https://opendev.org/airship/airshipctl/src/branch/master/roles/airshipctl-systemwide-executable","commit_id":"ef0da2e739ad906e8e95b73a29c9a7cfbf6ec780"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"953ca997d71a2c2b01b36f4568c55caeb77d6ac4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      become: yes"},{"line_number":26,"context_line":"      when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_release \u003d\u003d \u0027bionic\u0027"},{"line_number":27,"context_line":"      apt_repository:"},{"line_number":28,"context_line":"        repo: ppa:longsleep/golang-backports"},{"line_number":29,"context_line":"        update_cache: no"},{"line_number":30,"context_line":"        state: present"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_147f1015","line":28,"range":{"start_line":28,"start_character":14,"end_line":28,"end_character":44},"in_reply_to":"ff570b3c_46d3de38","updated":"2020-06-04 20:42:11.000000000","message":"Yeah, you\u0027re probably right about that","commit_id":"ef0da2e739ad906e8e95b73a29c9a7cfbf6ec780"}],"tools/document/build_kustomize_plugin.sh":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"c281b237253edef5613fc346400d37441c0dbf2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ff570b3c_c6cfee7c","updated":"2020-06-01 21:28:59.000000000","message":"nit: missing Apache 2 license header\n\nSame for the other scripts added.","commit_id":"ef0da2e739ad906e8e95b73a29c9a7cfbf6ec780"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"953ca997d71a2c2b01b36f4568c55caeb77d6ac4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ff570b3c_d4fd986e","in_reply_to":"ff570b3c_c6cfee7c","updated":"2020-06-04 20:42:11.000000000","message":"Done :)","commit_id":"ef0da2e739ad906e8e95b73a29c9a7cfbf6ec780"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"c281b237253edef5613fc346400d37441c0dbf2a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Run this from the airshipctl project root"},{"line_number":4,"context_line":"set -e"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# This script builds a version of kustomize that is able to acces"},{"line_number":7,"context_line":"# the ReplacementTransformer plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":": ${KUSTOMIZE_PLUGIN_HOME:\u003d\"$HOME/.airship/kustomize-plugins\"}"},{"line_number":10,"context_line":": ${AIRSHIP_TAG:\u003d\"dev\"}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ff570b3c_26a6aac2","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":35},"updated":"2020-06-01 21:28:59.000000000","message":"I appreciate this summary! And all of the others.","commit_id":"ef0da2e739ad906e8e95b73a29c9a7cfbf6ec780"}],"tools/validate_docs":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"c281b237253edef5613fc346400d37441c0dbf2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ff570b3c_06744635","updated":"2020-06-01 21:28:59.000000000","message":"Why omit the extension from this script?","commit_id":"ef0da2e739ad906e8e95b73a29c9a7cfbf6ec780"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"953ca997d71a2c2b01b36f4568c55caeb77d6ac4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ff570b3c_949680ef","in_reply_to":"ff570b3c_06744635","updated":"2020-06-04 20:42:11.000000000","message":"Just for consistency with the other scripts under tools/ that are entrypoints for Makefile-driven things","commit_id":"ef0da2e739ad906e8e95b73a29c9a7cfbf6ec780"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"c281b237253edef5613fc346400d37441c0dbf2a","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"for site in $(ls manifests/site); do"},{"line_number":22,"context_line":"    echo -e \"\\nValidating site: ${site}\\n****************\""},{"line_number":23,"context_line":"    ./tools/document/start_kind.sh"},{"line_number":24,"context_line":"    SITE\u003d${site} ./tools/document/validate_site_docs.sh"},{"line_number":25,"context_line":"    ${KIND} delete cluster --name airship"},{"line_number":26,"context_line":"    echo \"Validation of site ${site} is succesful!\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ff570b3c_c67d2e1d","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":34},"updated":"2020-06-01 21:28:59.000000000","message":"Why is it necessary to create a new cluster between dry-runs?","commit_id":"ef0da2e739ad906e8e95b73a29c9a7cfbf6ec780"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"953ca997d71a2c2b01b36f4568c55caeb77d6ac4","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"for site in $(ls manifests/site); do"},{"line_number":22,"context_line":"    echo -e \"\\nValidating site: ${site}\\n****************\""},{"line_number":23,"context_line":"    ./tools/document/start_kind.sh"},{"line_number":24,"context_line":"    SITE\u003d${site} ./tools/document/validate_site_docs.sh"},{"line_number":25,"context_line":"    ${KIND} delete cluster --name airship"},{"line_number":26,"context_line":"    echo \"Validation of site ${site} is succesful!\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ff570b3c_57006aab","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":34},"in_reply_to":"ff570b3c_c67d2e1d","updated":"2020-06-04 20:42:11.000000000","message":"Only to make sure that crd cruft from one site aren\u0027t leaked into the validation of another site.  The crds are actually loaded into the cluster (not dry-runned) to enable dry-running the crs that need them.\n\nI\u0027ll switch to a slightly quicker alternative of just deleting the crds from the cluster.","commit_id":"ef0da2e739ad906e8e95b73a29c9a7cfbf6ec780"}]}