)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"736976d297e84efe869ed4306c1d1ea3d501ed2f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     08c5d6ac (Add python3-setuptools to required packages)"},{"line_number":2,"context_line":"Author:     Sidney Shiba \u003csidney.shiba@ericsson.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2020-06-24 14:54:39 -0500"},{"line_number":4,"context_line":"Commit:     Sidney Shiba \u003csidney.shiba@ericsson.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_521a3816","line":1,"updated":"2020-06-26 13:55:51.000000000","message":"Please follow https://wiki.openstack.org/wiki/GitCommitMessages. Also move all the unnecessary things from commit message to documentation","commit_id":"8b82bab99088c0af3fcdde1fef11227096b5d6ce"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"56de7d6a6640ebd0e34c50676fdaf2cc91ebdf5d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sidney Shiba \u003csidney.shiba@ericsson.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-07-21 11:25:22 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Addressing Review Comments"},{"line_number":8,"context_line":"--------------------------"},{"line_number":9,"context_line":"Created function/k8scontrol-capz folder containing the following target cluster deployment manifests:"},{"line_number":10,"context_line":"- cluster.yaml - manifest for the target cluster definition"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":42,"id":"bf51134e_08677ab9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":26},"updated":"2020-07-22 23:26:05.000000000","message":"The first part of the commit message should look like a short explanation of the problem that was solved by PS.","commit_id":"2397fe1f9d61975b4d654615b856bbbe71e096c4"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"56de7d6a6640ebd0e34c50676fdaf2cc91ebdf5d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Addressing Review Comments"},{"line_number":8,"context_line":"--------------------------"},{"line_number":9,"context_line":"Created function/k8scontrol-capz folder containing the following target cluster deployment manifests:"},{"line_number":10,"context_line":"- cluster.yaml - manifest for the target cluster definition"},{"line_number":11,"context_line":"- controlplane.yaml - manifest for the target cluster control plane node(s) definition"},{"line_number":12,"context_line":"- workers.yaml - manifest for the target cluster worker node(s) definition"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":42,"id":"bf51134e_885b8af4","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":101},"updated":"2020-07-22 23:26:05.000000000","message":"Please, use short lines in commit message.","commit_id":"2397fe1f9d61975b4d654615b856bbbe71e096c4"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"106e3eeb8f6e5bf9354de538236cd7c6e3d6a481","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     f61953bc (Increase timeout for target phase apply initinfra)"},{"line_number":2,"context_line":"Author:     Sidney Shiba \u003csidney.shiba@ericsson.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2020-06-24 14:54:39 -0500"},{"line_number":4,"context_line":"Commit:     Sidney Shiba \u003csidney.shiba@ericsson.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":43,"id":"9f560f44_6edf370c","line":1,"updated":"2020-08-17 12:51:10.000000000","message":"Let\u0027s follow commit message guidelines.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"915de4c4b95582148c2248aef35adc53dbf44212"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"f080ac6dff5cd99304580acadea41cbd4acaa2a4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sidney Shiba \u003csidney.shiba@ericsson.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-08-31 08:36:41 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated nodeset to single node"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updated nodeset to airship-airshipit-single-node as recommended to the"},{"line_number":10,"context_line":"Zuul job airship-airshipit-gate-script-runner-azuretest as this job does"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":47,"id":"9f560f44_15cb434a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":30},"updated":"2020-08-31 15:59:58.000000000","message":"The commit message should reflect the patchset goal and explain details. The current version of the commit message is not relevant to the changes itself.","commit_id":"479efe10b0ec5f04bb6e3fb6e1607b8c4bf2ab43"},{"author":{"_account_id":31968,"name":"Bijaya Sharma","email":"vetbijaya@gmail.com","username":"bijayasharma"},"change_message_id":"c127d5c150fc9eec09d8ef2d1c04ab71c8b150d0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This command runs a Docker container that will be responsible for"},{"line_number":15,"context_line":"creating or deleting an Ephemeral container."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- airshipctl bootstrap ephemeral --comand create, creates an ephemeral"},{"line_number":18,"context_line":"cluster on a Cloud platform by running a docker container, which is"},{"line_number":19,"context_line":"responsible for creating the cluster using proprietary CLI/APIs."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":72,"id":"9f560f44_b814ccea","line":17,"range":{"start_line":17,"start_character":35,"end_line":17,"end_character":41},"updated":"2020-09-18 20:48:16.000000000","message":"typo","commit_id":"662de03804d696a20fa561f6c1fcbe2d5f187a36"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4f491f62d10eb08a99968c22de2530291da2e098","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This command runs a Docker container that will be responsible for"},{"line_number":15,"context_line":"creating or deleting an Ephemeral container."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- airshipctl bootstrap ephemeral --comand create, creates an ephemeral"},{"line_number":18,"context_line":"cluster on a Cloud platform by running a docker container, which is"},{"line_number":19,"context_line":"responsible for creating the cluster using proprietary CLI/APIs."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":72,"id":"9f560f44_182978f1","line":17,"range":{"start_line":17,"start_character":35,"end_line":17,"end_character":41},"in_reply_to":"9f560f44_b814ccea","updated":"2020-09-18 20:59:42.000000000","message":"Done","commit_id":"662de03804d696a20fa561f6c1fcbe2d5f187a36"},{"author":{"_account_id":31968,"name":"Bijaya Sharma","email":"vetbijaya@gmail.com","username":"bijayasharma"},"change_message_id":"c127d5c150fc9eec09d8ef2d1c04ab71c8b150d0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"responsible for creating the cluster using proprietary CLI/APIs."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- airshipctl bootstrap ephemeral --command delete, deletes an ephemeral"},{"line_number":22,"context_line":"cluster on a Cloud platforom by running a docker container, which is"},{"line_number":23,"context_line":"responsible for deleting the cluster using proprietary CLI/APIs."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- airshipctl bootstrap ephemeral --command help, returns (stdout) the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":72,"id":"9f560f44_18ba18e0","line":22,"range":{"start_line":22,"start_character":19,"end_line":22,"end_character":28},"updated":"2020-09-18 20:48:16.000000000","message":"typo","commit_id":"662de03804d696a20fa561f6c1fcbe2d5f187a36"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4f491f62d10eb08a99968c22de2530291da2e098","unresolved":false,"context_lines":[{"line_number":19,"context_line":"responsible for creating the cluster using proprietary CLI/APIs."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- airshipctl bootstrap ephemeral --command delete, deletes an ephemeral"},{"line_number":22,"context_line":"cluster on a Cloud platforom by running a docker container, which is"},{"line_number":23,"context_line":"responsible for deleting the cluster using proprietary CLI/APIs."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- airshipctl bootstrap ephemeral --command help, returns (stdout) the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":72,"id":"9f560f44_f82be4e6","line":22,"range":{"start_line":22,"start_character":19,"end_line":22,"end_character":28},"in_reply_to":"9f560f44_18ba18e0","updated":"2020-09-18 20:59:42.000000000","message":"Done","commit_id":"662de03804d696a20fa561f6c1fcbe2d5f187a36"},{"author":{"_account_id":22755,"name":"Sudeep Batra","email":"sudeep.batra@ericsson.com","username":"esudbat"},"change_message_id":"2f1dbb2b3da2156af3bb49331a8280e90c3dd6bd","unresolved":true,"context_lines":[{"line_number":14,"context_line":"This command runs a Docker container that will be responsible for"},{"line_number":15,"context_line":"creating or deleting an Ephemeral container."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- airshipctl bootstrap ephemeral --comand create, creates an ephemeral"},{"line_number":18,"context_line":"cluster on a Cloud platform by running a docker container, which is"},{"line_number":19,"context_line":"responsible for creating the cluster using proprietary CLI/APIs."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":82,"id":"a7f1dcd3_f0214887","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":48},"updated":"2020-11-24 16:59:01.000000000","message":"There should not be need to specify --comand right ?\nsimply airshipctl bootstrap ephemeral -c (or --create) to create\nand -d (or --delete) to delete respectively.","commit_id":"fcd6f7354bd3b1e0b81b727441cabd078523a8de"}],"cmd/bootstrap/bootstrap.go":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4a9d7b481286ccfafc27166c38ec31d1daaf0d9d","unresolved":false,"context_lines":[{"line_number":27,"context_line":")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"// NewBootstrapCommand creates a command for interacting with phases"},{"line_number":30,"context_line":"func NewBootstrapCommand(factory config.Factory) *cobra.Command {"},{"line_number":31,"context_line":"\tbootstrapRootCmd :\u003d \u0026cobra.Command{"},{"line_number":32,"context_line":"\t\tUse:   \"bootstrap\","},{"line_number":33,"context_line":"\t\tShort: \"Bootstrap K8S cluster\","}],"source_content_type":"text/x-go","patch_set":75,"id":"9f560f44_98e55a0d","line":30,"range":{"start_line":30,"start_character":5,"end_line":30,"end_character":24},"updated":"2020-09-22 17:16:01.000000000","message":"I find the name bootstrap to be a little misleading, only because it\u0027s not specific to public cloud providers. The normal command to create a management cluster, the ephemeral cluster, is\n\n  airshipctl baremetal remotedirect\n\nI think it would make a lot of sense to have this command be named in a manner that makes it parallel to the baremetal one. I would expect to use the bootstrap command in all airshipctl use cases judging by the name.\n\nSome ways we could get around this could be using the root cluster command and adding a subcommand to create a management cluster:\n\n  airshipctl cluster bootstrap --provider\u003dazure\n\nOr, we could also just change the name of this root command:\n\n  airshipctl provider bootstrap azure\n\nIdeas?","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"16022a38ed468a30c63265007e7c264cc100e4ae","unresolved":false,"context_lines":[{"line_number":27,"context_line":")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"// NewBootstrapCommand creates a command for interacting with phases"},{"line_number":30,"context_line":"func NewBootstrapCommand(factory config.Factory) *cobra.Command {"},{"line_number":31,"context_line":"\tbootstrapRootCmd :\u003d \u0026cobra.Command{"},{"line_number":32,"context_line":"\t\tUse:   \"bootstrap\","},{"line_number":33,"context_line":"\t\tShort: \"Bootstrap K8S cluster\","}],"source_content_type":"text/x-go","patch_set":75,"id":"9f560f44_5e3a6e97","line":30,"range":{"start_line":30,"start_character":5,"end_line":30,"end_character":24},"in_reply_to":"9f560f44_67f423d0","updated":"2020-09-23 19:02:29.000000000","message":"\u003e AT\u0026T requested to remove any provider dependency from the command\n \u003e line so it does not require to be updated each time a new provider\n \u003e is supported.\n \u003e \n \u003e Instead, the command relies on the airship config file as well as\n \u003e parameters pointing to docker image and ephemeral/management\n \u003e cluster configuration file. With this approach a new provider can\n \u003e be supported without the need to update this command Go code.\n\nThat\u0027s a good enhancement; however, we can still change the name of this command or utilize the existing, root cluster command while retaining support for listing providers in the config file.","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"dd2be439836ccb79788ee0d5d1fdc14bbae4cff2","unresolved":false,"context_lines":[{"line_number":27,"context_line":")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"// NewBootstrapCommand creates a command for interacting with phases"},{"line_number":30,"context_line":"func NewBootstrapCommand(factory config.Factory) *cobra.Command {"},{"line_number":31,"context_line":"\tbootstrapRootCmd :\u003d \u0026cobra.Command{"},{"line_number":32,"context_line":"\t\tUse:   \"bootstrap\","},{"line_number":33,"context_line":"\t\tShort: \"Bootstrap K8S cluster\","}],"source_content_type":"text/x-go","patch_set":75,"id":"9f560f44_67f423d0","line":30,"range":{"start_line":30,"start_character":5,"end_line":30,"end_character":24},"in_reply_to":"9f560f44_98e55a0d","updated":"2020-09-22 22:00:05.000000000","message":"AT\u0026T requested to remove any provider dependency from the command line so it does not require to be updated each time a new provider is supported.\n\nInstead, the command relies on the airship config file as well as parameters pointing to docker image and ephemeral/management cluster configuration file. With this approach a new provider can be supported without the need to update this command Go code.\n\nIt was also proposed to add support for the baremetal in the future for consistency but was not considered a priority for now.","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9fecf7fde3e253ea834ad09978f07fdd50c7259a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"func NewBootstrapCommand(factory config.Factory) *cobra.Command {"},{"line_number":31,"context_line":"\tbootstrapRootCmd :\u003d \u0026cobra.Command{"},{"line_number":32,"context_line":"\t\tUse:   \"bootstrap\","},{"line_number":33,"context_line":"\t\tShort: \"Bootstrap K8S cluster\","},{"line_number":34,"context_line":"\t\tLong:  clusterLong[1:],"},{"line_number":35,"context_line":"\t}"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-go","patch_set":80,"id":"9f560f44_a3cf0126","line":33,"range":{"start_line":33,"start_character":10,"end_line":33,"end_character":31},"updated":"2020-09-25 21:53:17.000000000","message":"Can we extend this a bit to distinguish that this is only for public cloud management clusters? As advertised, it looks like a command to deploy a general Kubernetes cluster.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"b9ba3008b6e88d419122a05475d3888833945d5a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"func NewBootstrapCommand(factory config.Factory) *cobra.Command {"},{"line_number":31,"context_line":"\tbootstrapRootCmd :\u003d \u0026cobra.Command{"},{"line_number":32,"context_line":"\t\tUse:   \"bootstrap\","},{"line_number":33,"context_line":"\t\tShort: \"Bootstrap K8S cluster\","},{"line_number":34,"context_line":"\t\tLong:  clusterLong[1:],"},{"line_number":35,"context_line":"\t}"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-go","patch_set":80,"id":"9f560f44_d740dca5","line":33,"range":{"start_line":33,"start_character":10,"end_line":33,"end_character":31},"in_reply_to":"9f560f44_a3cf0126","updated":"2020-09-28 15:31:21.000000000","message":"This command is to deploy a Bootstrap/Ephemeral cluster that will be used as Management cluster. It applies to private (e.g., Openstack) and public clouds. As a matter of fact, this approach pushes the responsibility of creating a cluster to the container so it is applicable to any platform. \n\nThe long term objective is to align baremetal to this approach.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"}],"cmd/bootstrap/ephemeral.go":[{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"c0db75befaa23226802df8daefc06fc17efe123e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"func addEphemeralFlags(options *bootstrap.Flags, cmd *cobra.Command) {"},{"line_number":59,"context_line":"\tflags :\u003d cmd.Flags()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"\tflags.StringVarP("},{"line_number":62,"context_line":"\t\t\u0026options.ConfigFile,"},{"line_number":63,"context_line":"\t\t\"config\","},{"line_number":64,"context_line":"\t\t\"\","}],"source_content_type":"text/x-go","patch_set":66,"id":"9f560f44_8484150d","line":61,"range":{"start_line":61,"start_character":1,"end_line":61,"end_character":17},"updated":"2020-09-18 09:00:19.000000000","message":"It\u0027s better to use StringVar instead in case if you don\u0027t have shorthand letter","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"func addEphemeralFlags(options *bootstrap.Flags, cmd *cobra.Command) {"},{"line_number":59,"context_line":"\tflags :\u003d cmd.Flags()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"\tflags.StringVarP("},{"line_number":62,"context_line":"\t\t\u0026options.ConfigFile,"},{"line_number":63,"context_line":"\t\t\"config\","},{"line_number":64,"context_line":"\t\t\"\","}],"source_content_type":"text/x-go","patch_set":66,"id":"9f560f44_0fead90c","line":61,"range":{"start_line":61,"start_character":1,"end_line":61,"end_character":17},"in_reply_to":"9f560f44_8484150d","updated":"2020-09-18 15:02:18.000000000","message":"Done","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"c0db75befaa23226802df8daefc06fc17efe123e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"\t\t\"\","},{"line_number":66,"context_line":"\t\t\"Ephemeral cluster configuration file\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"\tflags.StringVarP("},{"line_number":69,"context_line":"\t\t\u0026options.ContainerID,"},{"line_number":70,"context_line":"\t\t\"container\","},{"line_number":71,"context_line":"\t\t\"\","}],"source_content_type":"text/x-go","patch_set":66,"id":"9f560f44_e47a3123","line":68,"range":{"start_line":68,"start_character":7,"end_line":68,"end_character":17},"updated":"2020-09-18 09:00:19.000000000","message":"ditto","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[{"line_number":65,"context_line":"\t\t\"\","},{"line_number":66,"context_line":"\t\t\"Ephemeral cluster configuration file\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"\tflags.StringVarP("},{"line_number":69,"context_line":"\t\t\u0026options.ContainerID,"},{"line_number":70,"context_line":"\t\t\"container\","},{"line_number":71,"context_line":"\t\t\"\","}],"source_content_type":"text/x-go","patch_set":66,"id":"9f560f44_6ff1d501","line":68,"range":{"start_line":68,"start_character":7,"end_line":68,"end_character":17},"in_reply_to":"9f560f44_e47a3123","updated":"2020-09-18 15:02:18.000000000","message":"Done","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"c0db75befaa23226802df8daefc06fc17efe123e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"\t\t\"\","},{"line_number":73,"context_line":"\t\t\"Bootstrap Container ID\")"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"\tflags.StringVarP("},{"line_number":76,"context_line":"\t\t\u0026options.Image,"},{"line_number":77,"context_line":"\t\t\"image\","},{"line_number":78,"context_line":"\t\t\"\","}],"source_content_type":"text/x-go","patch_set":66,"id":"9f560f44_c4756d35","line":75,"range":{"start_line":75,"start_character":7,"end_line":75,"end_character":17},"updated":"2020-09-18 09:00:19.000000000","message":"ditto","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[{"line_number":72,"context_line":"\t\t\"\","},{"line_number":73,"context_line":"\t\t\"Bootstrap Container ID\")"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"\tflags.StringVarP("},{"line_number":76,"context_line":"\t\t\u0026options.Image,"},{"line_number":77,"context_line":"\t\t\"image\","},{"line_number":78,"context_line":"\t\t\"\","}],"source_content_type":"text/x-go","patch_set":66,"id":"9f560f44_4ff4d1f1","line":75,"range":{"start_line":75,"start_character":7,"end_line":75,"end_character":17},"in_reply_to":"9f560f44_c4756d35","updated":"2020-09-18 15:02:18.000000000","message":"Done","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"6b139e311e119ffb0d5a9db40174f617b6f45d00","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"const ("},{"line_number":25,"context_line":"\tephemeralLong \u003d `"},{"line_number":26,"context_line":"Creates, Deletes or list the attributes expected by an ephemeral Kubernetes cluster on a Cloud provider"},{"line_number":27,"context_line":"`"},{"line_number":28,"context_line":"\tephemeralExample \u003d `"},{"line_number":29,"context_line":"# Creates an ephemeral Kubernetes cluster"}],"source_content_type":"text/x-go","patch_set":73,"id":"9f560f44_50b73222","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":16},"updated":"2020-09-21 22:16:57.000000000","message":"Create, delete, or list\n\nor\n\nCreates, deletes, or lists","commit_id":"02055b399e9be3f94bbb08666b8646692029acb7"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"6b139e311e119ffb0d5a9db40174f617b6f45d00","unresolved":false,"context_lines":[{"line_number":27,"context_line":"`"},{"line_number":28,"context_line":"\tephemeralExample \u003d `"},{"line_number":29,"context_line":"# Creates an ephemeral Kubernetes cluster"},{"line_number":30,"context_line":"airshipctl ephemeral --create"},{"line_number":31,"context_line":"`"},{"line_number":32,"context_line":")"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-go","patch_set":73,"id":"9f560f44_10c13a81","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":21},"updated":"2020-09-21 22:16:57.000000000","message":"I think this would be\n\n  airshipctl bootstrap ephemeral --create","commit_id":"02055b399e9be3f94bbb08666b8646692029acb7"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9fecf7fde3e253ea834ad09978f07fdd50c7259a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":80,"id":"9f560f44_036ced33","updated":"2020-09-25 21:53:17.000000000","message":"My earlier comments were probably buried by subsequent patchsets, so I will re-add them here.\n\nI think we need to either change the name of this command (bootstrap) or drop usage of the word ephemeral in favor of management. The ephemeral cluster means something very specific in airshipctl, and while the word has meaning here, it will be confusing to airshipctl users to have a command:\n\n  airshipctl bootstrap ephemeral\n\nthat is only used for public cloud use cases and not applicable to the baremetal use case even though it also has an ephemeral cluster. Possible replacements include:\n\n  airshipctl provider bootstrap\n  airshipctl cluster provider-bootstrap\n\nThere are probably some better names that also make a clear distinction between the baremetal ephemeral cluster and a public cloud provider\u0027s management cluster.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"b9ba3008b6e88d419122a05475d3888833945d5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":80,"id":"9f560f44_174c149c","in_reply_to":"9f560f44_036ced33","updated":"2020-09-28 15:31:21.000000000","message":"This command is applicable to any platform: private/public cloud and baremetal (planned to align it sometime in the future).\n\nThe rationale of this command was to generalize (from airshipctl command stand point) the creation of a management cluster on any platform, pushing the responsibility of cluster creation to platform dependent Docker container.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9fecf7fde3e253ea834ad09978f07fdd50c7259a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"\t\t\u0026options.ContainerID,"},{"line_number":64,"context_line":"\t\t\"container\","},{"line_number":65,"context_line":"\t\t\"\","},{"line_number":66,"context_line":"\t\t\"Bootstrap Container ID\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"\tflags.StringVar("},{"line_number":69,"context_line":"\t\t\u0026options.Image,"}],"source_content_type":"text/x-go","patch_set":80,"id":"9f560f44_63f20971","line":66,"range":{"start_line":66,"start_character":3,"end_line":66,"end_character":25},"updated":"2020-09-25 21:53:17.000000000","message":"Does this mean airshipctl is looking for a running container?","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"b9ba3008b6e88d419122a05475d3888833945d5a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"\t\t\u0026options.ContainerID,"},{"line_number":64,"context_line":"\t\t\"container\","},{"line_number":65,"context_line":"\t\t\"\","},{"line_number":66,"context_line":"\t\t\"Bootstrap Container ID\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"\tflags.StringVar("},{"line_number":69,"context_line":"\t\t\u0026options.Image,"}],"source_content_type":"text/x-go","patch_set":80,"id":"9f560f44_3ae49d42","line":66,"range":{"start_line":66,"start_character":3,"end_line":66,"end_character":25},"in_reply_to":"9f560f44_63f20971","updated":"2020-09-28 15:31:21.000000000","message":"Yes. airshipctl will run a platform dependent container that will be responsible for deploying a k8s cluster in its corresponding platform, i.e., private/public cloud and long term also support other platforms such as baremetal.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"}],"cmd/bootstrap/testdata/ephemeral/initinfra/kustomization.yaml":[{"author":{"_account_id":22755,"name":"Sudeep Batra","email":"sudeep.batra@ericsson.com","username":"esudbat"},"change_message_id":"2f1dbb2b3da2156af3bb49331a8280e90c3dd6bd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"resources:"},{"line_number":2,"context_line":" - tiller.yaml"}],"source_content_type":"text/x-yaml","patch_set":82,"id":"72f3eb60_ce257abe","line":2,"range":{"start_line":2,"start_character":3,"end_line":2,"end_character":14},"updated":"2020-11-24 16:59:01.000000000","message":"Why do we need tiller anymore ? Isnt it without any support post Nov13,2020 ?\nShouldnt we rely on Helmv3 completely from security and support consideration both ?","commit_id":"fcd6f7354bd3b1e0b81b727441cabd078523a8de"}],"docs/azure/azure-integration.md":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"b39ed2da9cde0df1a042a54f737487b616811479","unresolved":false,"context_lines":[{"line_number":61,"context_line":"CNI is configured. See next step below."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"## Configure CNI on the Target cluster with Calico"},{"line_number":64,"context_line":"Calico will be initialized as part of control plane VM *postKubeadmCommands*, which executes the "},{"line_number":65,"context_line":"*sudo kubectl --kubeconfig /etc/kubernetes/admin.conf apply -f https://raw.githubusercontent.com/kubernetes-sigs/cluster-api-provider-azure/master/templates/addons/calico.yaml* command."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"See snippet of manifest integrating Calico initialization below:"}],"source_content_type":"text/x-markdown","patch_set":41,"id":"bf51134e_bbb52cd3","line":64,"updated":"2020-07-20 19:18:33.000000000","message":"Unfortunately the trailing whitespace is causing the linting gate to fail","commit_id":"c5ca0187d7ae086fab7d6cc2de0c10f0317330fd"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"b39ed2da9cde0df1a042a54f737487b616811479","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        sudo kubectl --kubeconfig /etc/kubernetes/admin.conf apply -f https://raw.githubusercontent.com/kubernetes-sigs/cluster-api-provider-azure/master/templates/addons/calico.yaml"},{"line_number":89,"context_line":"..."},{"line_number":90,"context_line":"    postKubeadmCommands:"},{"line_number":91,"context_line":"      - /calico.sh    "},{"line_number":92,"context_line":"    useExperimentalRetryJoin: true"},{"line_number":93,"context_line":"  replicas: 3"},{"line_number":94,"context_line":"  version: v1.18.2"}],"source_content_type":"text/x-markdown","patch_set":41,"id":"bf51134e_9bbae8bd","line":91,"range":{"start_line":91,"start_character":18,"end_line":91,"end_character":22},"updated":"2020-07-20 19:18:33.000000000","message":"ditto","commit_id":"c5ca0187d7ae086fab7d6cc2de0c10f0317330fd"}],"docs/source/cli/airshipctl_bootstrap_ephemeral.md":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4a9d7b481286ccfafc27166c38ec31d1daaf0d9d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# airshipctl bootstrap ephemeral"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This command creates, deletes an Ephemeral cluster. It also stdout the expected configuration"},{"line_number":4,"context_line":"file for the Ephemeral cluster."}],"source_content_type":"text/x-markdown","patch_set":75,"id":"9f560f44_98a1da98","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":32},"updated":"2020-09-22 17:16:01.000000000","message":"Overloading the term ephemeral can also make this seem like it\u0027s a command to be used during the baremetal flow; that is not what we want to convey.\n\nI would recommend using the term \"management\" in favor of \"ephemeral\" when possible, since that is the term recognized by the community.","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"dd2be439836ccb79788ee0d5d1fdc14bbae4cff2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# airshipctl bootstrap ephemeral"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This command creates, deletes an Ephemeral cluster. It also stdout the expected configuration"},{"line_number":4,"context_line":"file for the Ephemeral cluster."}],"source_content_type":"text/x-markdown","patch_set":75,"id":"9f560f44_67e26303","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":32},"in_reply_to":"9f560f44_98a1da98","updated":"2020-09-22 22:00:05.000000000","message":"The term \"ephemeral\" was reused in this context as the nature of the K8S cluster is ephemeral, i.e., once the Target/Workload cluster is created through the ephemeral/management cluster and the move operation executed, the K8S cluster created by the bootstrap container shall be deleted.","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9fecf7fde3e253ea834ad09978f07fdd50c7259a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# airshipctl bootstrap ephemeral"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This command creates, deletes an Ephemeral cluster. It also stdout the expected configuration"},{"line_number":4,"context_line":"file for the Ephemeral cluster."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"## Synopsis"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":80,"id":"9f560f44_e3fd793b","line":4,"range":{"start_line":3,"start_character":60,"end_line":4,"end_character":31},"updated":"2020-09-25 21:53:17.000000000","message":"prints the expected ephemeral cluster configuration file to stdout.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"b9ba3008b6e88d419122a05475d3888833945d5a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# airshipctl bootstrap ephemeral"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This command creates, deletes an Ephemeral cluster. It also stdout the expected configuration"},{"line_number":4,"context_line":"file for the Ephemeral cluster."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"## Synopsis"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":80,"id":"9f560f44_7a6bb5b8","line":4,"range":{"start_line":3,"start_character":60,"end_line":4,"end_character":31},"in_reply_to":"9f560f44_e3fd793b","updated":"2020-09-28 15:31:21.000000000","message":"Done","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"}],"manifests/function/capz/v0.4.4/default/credentials.yaml":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"56de7d6a6640ebd0e34c50676fdaf2cc91ebdf5d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"type: Opaque"},{"line_number":7,"context_line":"data:"},{"line_number":8,"context_line":"  # Hard-coded base64 values for the Azure subscription data."},{"line_number":9,"context_line":"  # Values have been ofuscated and not viable."},{"line_number":10,"context_line":"  # You need to provide your Azure subscription information"},{"line_number":11,"context_line":"  subscription-id: \"UGxlYXNlLCBwcm92aWRlIHlvdXIgQXp1cmUgc3Vic2NyaXB0aW9uIGlkIGhlcmUK\""},{"line_number":12,"context_line":"  tenant-id: \"UGxlYXNlLCBwcm92aWRlIHlvdXIgQXp1cmUgdGVuYW50IGlkIGhlcmUK\""}],"source_content_type":"text/x-yaml","patch_set":42,"id":"bf51134e_2876be3f","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":30},"updated":"2020-07-22 23:26:05.000000000","message":"typo","commit_id":"2397fe1f9d61975b4d654615b856bbbe71e096c4"}],"manifests/site/az-test-site/target/azure-target/az-target-cluster.yaml":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"b39ed2da9cde0df1a042a54f737487b616811479","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: cluster.x-k8s.io/v1alpha3"},{"line_number":2,"context_line":"kind: Cluster"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: az-target-cluster"},{"line_number":5,"context_line":"  namespace: default"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"bf51134e_3b53dc6e","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":13},"updated":"2020-07-20 19:18:33.000000000","message":"Would it be possible to split out the majority of this file into an airshipctl/manifests/function/k8scontrol-capz funtction, similarly to how there\u0027s a function/k8scontrol for Metal3?\n\nIf you\u0027d prefer to get this merged and then follow on with the function, I\u0027d be open to that too.  Whatever we do, we should probably do the same thing in the Docker and OpenStack provider patchsets.","commit_id":"c5ca0187d7ae086fab7d6cc2de0c10f0317330fd"}],"manifests/site/az-test-site/target/calico/calico.yaml":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"54686d394f11850ba865c82a1ddf36cbfeee5093","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Source: calico/templates/calico-config.yaml"},{"line_number":3,"context_line":"# This ConfigMap is used to configure a self-hosted Calico installation."},{"line_number":4,"context_line":"kind: ConfigMap"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_d3cc878a","line":1,"updated":"2020-06-26 19:54:44.000000000","message":"This is just a standard calico manifest, right?  Or is there something that was changed for the CAPO use case?","commit_id":"8b82bab99088c0af3fcdde1fef11227096b5d6ce"}],"pkg/api/v1alpha1/zz_generated.deepcopy.go":[{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"c0db75befaa23226802df8daefc06fc17efe123e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":3,"context_line":" you may not use this file except in compliance with the License."},{"line_number":4,"context_line":" You may obtain a copy of the License at"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"     https://www.apache.org/licenses/LICENSE-2.0"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":" Unless required by applicable law or agreed to in writing, software"},{"line_number":9,"context_line":" distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":10,"context_line":" WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":11,"context_line":" See the License for the specific language governing permissions and"},{"line_number":12,"context_line":" limitations under the License."},{"line_number":13,"context_line":"*/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"// +build !ignore_autogenerated"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-go","patch_set":66,"id":"9f560f44_e49fd14e","line":13,"range":{"start_line":1,"start_character":0,"end_line":13,"end_character":2},"updated":"2020-09-18 09:00:19.000000000","message":"please don\u0027t edit auto-generated source files.","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":3,"context_line":" you may not use this file except in compliance with the License."},{"line_number":4,"context_line":" You may obtain a copy of the License at"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"     https://www.apache.org/licenses/LICENSE-2.0"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":" Unless required by applicable law or agreed to in writing, software"},{"line_number":9,"context_line":" distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":10,"context_line":" WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":11,"context_line":" See the License for the specific language governing permissions and"},{"line_number":12,"context_line":" limitations under the License."},{"line_number":13,"context_line":"*/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"// +build !ignore_autogenerated"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-go","patch_set":66,"id":"9f560f44_0fd3f960","line":13,"range":{"start_line":1,"start_character":0,"end_line":13,"end_character":2},"in_reply_to":"9f560f44_e49fd14e","updated":"2020-09-18 15:02:18.000000000","message":"I don\u0027t recall editing any of auto-generated source files","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"}],"pkg/bootstrap/constants.go":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"6b139e311e119ffb0d5a9db40174f617b6f45d00","unresolved":false,"context_lines":[{"line_number":15,"context_line":"package bootstrap"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"const ("},{"line_number":18,"context_line":"\t// BootContainerRunning is the Running state of a container"},{"line_number":19,"context_line":"\tBootContainerRunning \u003d \"running\""},{"line_number":20,"context_line":"\t// BootCmdCreate is the string for the command \"create\" Ephemeral cluster"},{"line_number":21,"context_line":"\tBootCmdCreate \u003d \"create\""},{"line_number":22,"context_line":"\t// BootCmdDelete is the string for the command \"delete\" Ephemeral cluster"}],"source_content_type":"text/x-go","patch_set":73,"id":"9f560f44_106f7a92","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":33},"updated":"2020-09-21 22:16:57.000000000","message":"How many different states can there be? I only see one listed, but I would expect that this could also be \"terminated\", \"paused\", etc\n\nThis type of value might be a good iota [0] candidate (enumerations in Go).\n\n[0] https://github.com/golang/go/wiki/Iota","commit_id":"02055b399e9be3f94bbb08666b8646692029acb7"}],"pkg/bootstrap/container.go":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":73,"context_line":"\t}"},{"line_number":74,"context_line":"\tswitch {"},{"line_number":75,"context_line":"\tcase exitCode \u003d\u003d 1:"},{"line_number":76,"context_line":"\t\treturn false, errors.New(\"Container error: Failed to load Ephemeral cluster config file\")"},{"line_number":77,"context_line":"\tcase exitCode \u003d\u003d 2:"},{"line_number":78,"context_line":"\t\treturn false, errors.New(\"Container error: Ephemeral cluster configuration file validation failed\")"},{"line_number":79,"context_line":"\tcase exitCode \u003d\u003d 3:"}],"source_content_type":"text/x-go","patch_set":51,"id":"9f560f44_45c49b92","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":91},"updated":"2020-09-04 17:14:27.000000000","message":"Please, create strongly-typed errors in a separate file named errors.go for this module. The same for all other errors below. If you would prefer to do it in a separate commit, please, add TODO here in this commit to handle this later.","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"dd2be439836ccb79788ee0d5d1fdc14bbae4cff2","unresolved":false,"context_lines":[{"line_number":73,"context_line":"\t}"},{"line_number":74,"context_line":"\tswitch {"},{"line_number":75,"context_line":"\tcase exitCode \u003d\u003d 1:"},{"line_number":76,"context_line":"\t\treturn false, errors.New(\"Container error: Failed to load Ephemeral cluster config file\")"},{"line_number":77,"context_line":"\tcase exitCode \u003d\u003d 2:"},{"line_number":78,"context_line":"\t\treturn false, errors.New(\"Container error: Ephemeral cluster configuration file validation failed\")"},{"line_number":79,"context_line":"\tcase exitCode \u003d\u003d 3:"}],"source_content_type":"text/x-go","patch_set":51,"id":"9f560f44_8775f7ce","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":91},"in_reply_to":"9f560f44_45c49b92","updated":"2020-09-22 22:00:05.000000000","message":"Done","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"},{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"c0db75befaa23226802df8daefc06fc17efe123e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":66,"id":"9f560f44_442b1de9","updated":"2020-09-18 09:00:19.000000000","message":"We already do have docker client interface in pkg/container folder, everything what you have here is pretty similar to already implemented functionality, please reuse/extend current code.","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":66,"id":"9f560f44_6a442375","in_reply_to":"9f560f44_442b1de9","updated":"2020-09-18 15:02:18.000000000","message":"After analyzing the effort to reuse the pkg/container, it will require a complete overhaul of current implementation.\n\nI propose to have this task as TODO (improvement) for a later time.","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"6b139e311e119ffb0d5a9db40174f617b6f45d00","unresolved":false,"context_lines":[{"line_number":118,"context_line":"\treturn status \u003d\u003d BootContainerRunning, nil"},{"line_number":119,"context_line":"}"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"// waitUntilContainerExitsOrTimesout waits until container finishes executing command or times out."},{"line_number":122,"context_line":"func waitUntilContainerExitsOrTimesout(containerName string, cmd string, cli *client.Client,"},{"line_number":123,"context_line":"\tbootContainer container.ContainerCreateCreatedBody) error {"},{"line_number":124,"context_line":"\t// Give 2 seconds before checking if container is still running"}],"source_content_type":"text/x-go","patch_set":73,"id":"9f560f44_330e0332","line":121,"range":{"start_line":121,"start_character":3,"end_line":121,"end_character":36},"updated":"2020-09-21 22:16:57.000000000","message":"We can probably get away with just calling this function wait(). This is good clarity for the godoc, thanks for including it!","commit_id":"02055b399e9be3f94bbb08666b8646692029acb7"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"6b139e311e119ffb0d5a9db40174f617b6f45d00","unresolved":false,"context_lines":[{"line_number":126,"context_line":"\ttime.Sleep(2 * time.Second)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"\t// Wait until container finished executing bootstrap of ephemeral cluster"},{"line_number":129,"context_line":"\tmaxRetries :\u003d 30"},{"line_number":130,"context_line":"\tnbRetries :\u003d maxRetries"},{"line_number":131,"context_line":"\tfor {"},{"line_number":132,"context_line":"\t\tstate, err :\u003d isContainerRunning(cli, bootContainer)"}],"source_content_type":"text/x-go","patch_set":73,"id":"9f560f44_7314fb41","line":129,"range":{"start_line":129,"start_character":1,"end_line":129,"end_character":17},"updated":"2020-09-21 22:16:57.000000000","message":"Should this be customizable?","commit_id":"02055b399e9be3f94bbb08666b8646692029acb7"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4a9d7b481286ccfafc27166c38ec31d1daaf0d9d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\t\"github.com/docker/docker/client\""},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"// TODO: re-implement this code reusing pkg/container package"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"func displayContainerLogs(cli *client.Client, bootContainer container.ContainerCreateCreatedBody) error {"},{"line_number":39,"context_line":"\t// Only catch the last 5 seconds of container logs"}],"source_content_type":"text/x-go","patch_set":75,"id":"9f560f44_bba3f842","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":61},"updated":"2020-09-22 17:16:01.000000000","message":"We have a comprehensive Docker interface that is widely used and tested [0]. Is there anything missing from that interface that is required to run the bootstrap container?\n\nA lot of that functionality has been implemented here separately, and it would introduce a significant amount of technical debt if merged as-is. In order to reduce that debt, we need to leverage that interface wherever possible.\n\n[0] https://opendev.org/airship/airshipctl/src/branch/master/pkg/container/container_docker.go","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"16022a38ed468a30c63265007e7c264cc100e4ae","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\t\"github.com/docker/docker/client\""},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"// TODO: re-implement this code reusing pkg/container package"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"func displayContainerLogs(cli *client.Client, bootContainer container.ContainerCreateCreatedBody) error {"},{"line_number":39,"context_line":"\t// Only catch the last 5 seconds of container logs"}],"source_content_type":"text/x-go","patch_set":75,"id":"9f560f44_1ea476a2","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":61},"in_reply_to":"9f560f44_477e3fe3","updated":"2020-09-23 19:02:29.000000000","message":"\u003e I had same comment from Stas and I have already analyzed the effort\n \u003e and it will be a complete overhaul of the code.\n \u003e \n \u003e Added a TODO comment to redesign this code later using\n \u003e pkg/container.\n\nAirship community contributors cannot accept an overhaul\u0027s worth of technical debt for an additional interface that was added when one was already created months earlier; however, we can work with you to make that happen. For starters, we can separate that into another change and merge both at the same time. Please let us know in Slack if you have questions about usage of the container interface.","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"dd2be439836ccb79788ee0d5d1fdc14bbae4cff2","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\t\"github.com/docker/docker/client\""},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"// TODO: re-implement this code reusing pkg/container package"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"func displayContainerLogs(cli *client.Client, bootContainer container.ContainerCreateCreatedBody) error {"},{"line_number":39,"context_line":"\t// Only catch the last 5 seconds of container logs"}],"source_content_type":"text/x-go","patch_set":75,"id":"9f560f44_477e3fe3","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":61},"in_reply_to":"9f560f44_bba3f842","updated":"2020-09-22 22:00:05.000000000","message":"I had same comment from Stas and I have already analyzed the effort and it will be a complete overhaul of the code.\n\nAdded a TODO comment to redesign this code later using pkg/container.","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9fecf7fde3e253ea834ad09978f07fdd50c7259a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\t\"github.com/docker/docker/client\""},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"// TODO: re-implement this code reusing pkg/container package"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"func displayContainerLogs(cli *client.Client, bootContainer container.ContainerCreateCreatedBody) error {"},{"line_number":39,"context_line":"\t// Only catch the last 5 seconds of container logs"}],"source_content_type":"text/x-go","patch_set":80,"id":"9f560f44_832abde3","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":61},"updated":"2020-09-25 21:53:17.000000000","message":"Thank you for agreeing to do this in a later patch!","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"b9ba3008b6e88d419122a05475d3888833945d5a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\t\"github.com/docker/docker/client\""},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"// TODO: re-implement this code reusing pkg/container package"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"func displayContainerLogs(cli *client.Client, bootContainer container.ContainerCreateCreatedBody) error {"},{"line_number":39,"context_line":"\t// Only catch the last 5 seconds of container logs"}],"source_content_type":"text/x-go","patch_set":80,"id":"9f560f44_fae1852d","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":61},"in_reply_to":"9f560f44_832abde3","updated":"2020-09-28 15:31:21.000000000","message":"You are welcome","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"}],"pkg/bootstrap/ephemeral.go":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\t\"github.com/docker/docker/api/types/container\""},{"line_number":21,"context_line":")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"// Flags is an abstraction used to bootstrap capg"},{"line_number":24,"context_line":"type Flags struct {"},{"line_number":25,"context_line":"\tRootSettings *environment.AirshipCTLSettings"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-go","patch_set":51,"id":"9f560f44_a5077781","line":23,"range":{"start_line":23,"start_character":45,"end_line":23,"end_character":49},"updated":"2020-09-04 17:14:27.000000000","message":"The commit message says this commit is for Azure provider. Why capg is here? If it\u0027s not a typo, and this is really for CAPG, please, create a separate commit for that.","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"},{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"c0db75befaa23226802df8daefc06fc17efe123e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"\t}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"\t// Run the bootstrap container to create K8S cluster"},{"line_number":80,"context_line":"\terr :\u003d RunBootstrapContainer(containerName, config, hostConfig, ephemeralFlags.Command, bootstrapInfo)"},{"line_number":81,"context_line":"\tif err !\u003d nil {"},{"line_number":82,"context_line":"\t\treturn err"},{"line_number":83,"context_line":"\t}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"\treturn nil"},{"line_number":86,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":66,"id":"9f560f44_241f09b8","line":85,"range":{"start_line":80,"start_character":1,"end_line":85,"end_character":11},"updated":"2020-09-18 09:00:19.000000000","message":"return RunBootstrapContainer(...) is enough","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[{"line_number":77,"context_line":"\t}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"\t// Run the bootstrap container to create K8S cluster"},{"line_number":80,"context_line":"\terr :\u003d RunBootstrapContainer(containerName, config, hostConfig, ephemeralFlags.Command, bootstrapInfo)"},{"line_number":81,"context_line":"\tif err !\u003d nil {"},{"line_number":82,"context_line":"\t\treturn err"},{"line_number":83,"context_line":"\t}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"\treturn nil"},{"line_number":86,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":66,"id":"9f560f44_0f38199d","line":85,"range":{"start_line":80,"start_character":1,"end_line":85,"end_character":11},"in_reply_to":"9f560f44_241f09b8","updated":"2020-09-18 15:02:18.000000000","message":"Done","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"}],"pkg/bootstrap/errors.go":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":20,"context_line":"}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"func (e ErrMissingCmdLineFlag) Error() string {"},{"line_number":23,"context_line":"\treturn \"Missing mandatory command line flag\""},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"// ErrNumberOfRetriesExceeded is returned when mandatory flag is missing in the command line"}],"source_content_type":"text/x-go","patch_set":51,"id":"9f560f44_654eff38","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":45},"updated":"2020-09-04 17:14:27.000000000","message":"This should be lower case","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"func (e ErrNumberOfRetriesExceeded) Error() string {"},{"line_number":32,"context_line":"\treturn \"Number of retries execeed\""},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"// ErrContainerConfigFile is returned when mandatory flag is missing in the command line"}],"source_content_type":"text/x-go","patch_set":51,"id":"9f560f44_c55eebe7","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":35},"updated":"2020-09-04 17:14:27.000000000","message":"the same","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":38,"context_line":"}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"func (e ErrContainerConfigFile) Error() string {"},{"line_number":41,"context_line":"\treturn \"Container error: Failed to load Ephemeral cluster config file\""},{"line_number":42,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":51,"id":"9f560f44_055903fd","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":71},"updated":"2020-09-04 17:14:27.000000000","message":"the same","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"},{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"c0db75befaa23226802df8daefc06fc17efe123e","unresolved":false,"context_lines":[{"line_number":105,"context_line":"}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"// ErrContainerUnknowError is returned when error is unknown"},{"line_number":108,"context_line":"type ErrContainerUnknowError struct {"},{"line_number":109,"context_line":"\tWhat string"},{"line_number":110,"context_line":"}"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-go","patch_set":66,"id":"9f560f44_44795df9","line":108,"range":{"start_line":108,"start_character":17,"end_line":108,"end_character":23},"updated":"2020-09-18 09:00:19.000000000","message":"Unknown","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[{"line_number":105,"context_line":"}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"// ErrContainerUnknowError is returned when error is unknown"},{"line_number":108,"context_line":"type ErrContainerUnknowError struct {"},{"line_number":109,"context_line":"\tWhat string"},{"line_number":110,"context_line":"}"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-go","patch_set":66,"id":"9f560f44_ef6b2582","line":108,"range":{"start_line":108,"start_character":17,"end_line":108,"end_character":23},"in_reply_to":"9f560f44_44795df9","updated":"2020-09-18 15:02:18.000000000","message":"Done","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4a9d7b481286ccfafc27166c38ec31d1daaf0d9d","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"package bootstrap"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"// ErrMissingCmdLineFlag is returned when mandatory flag is missing in the command line"},{"line_number":18,"context_line":"type ErrMissingCmdLineFlag struct {"},{"line_number":19,"context_line":"\tWhat string"},{"line_number":20,"context_line":"}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"func (e ErrMissingCmdLineFlag) Error() string {"},{"line_number":23,"context_line":"\treturn \"missing mandatory command line flag\""}],"source_content_type":"text/x-go","patch_set":75,"id":"9f560f44_16fe3b04","line":20,"range":{"start_line":17,"start_character":0,"end_line":20,"end_character":1},"updated":"2020-09-22 17:16:01.000000000","message":"When is this error used? Cobra, our CLI library, has its own error for this.","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"dd2be439836ccb79788ee0d5d1fdc14bbae4cff2","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"package bootstrap"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"// ErrMissingCmdLineFlag is returned when mandatory flag is missing in the command line"},{"line_number":18,"context_line":"type ErrMissingCmdLineFlag struct {"},{"line_number":19,"context_line":"\tWhat string"},{"line_number":20,"context_line":"}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"func (e ErrMissingCmdLineFlag) Error() string {"},{"line_number":23,"context_line":"\treturn \"missing mandatory command line flag\""}],"source_content_type":"text/x-go","patch_set":75,"id":"9f560f44_476bdfb7","line":20,"range":{"start_line":17,"start_character":0,"end_line":20,"end_character":1},"in_reply_to":"9f560f44_16fe3b04","updated":"2020-09-22 22:00:05.000000000","message":"Removed","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4a9d7b481286ccfafc27166c38ec31d1daaf0d9d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\treturn \"missing mandatory command line flag\""},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"// ErrNumberOfRetriesExceeded is returned when mandatory flag is missing in the command line"},{"line_number":27,"context_line":"type ErrNumberOfRetriesExceeded struct {"},{"line_number":28,"context_line":"\tWhat string"},{"line_number":29,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":75,"id":"9f560f44_f602a708","line":26,"range":{"start_line":26,"start_character":32,"end_line":26,"end_character":92},"updated":"2020-09-22 17:16:01.000000000","message":"leftover copy :)","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"dd2be439836ccb79788ee0d5d1fdc14bbae4cff2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\treturn \"missing mandatory command line flag\""},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"// ErrNumberOfRetriesExceeded is returned when mandatory flag is missing in the command line"},{"line_number":27,"context_line":"type ErrNumberOfRetriesExceeded struct {"},{"line_number":28,"context_line":"\tWhat string"},{"line_number":29,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":75,"id":"9f560f44_a7b0fb41","line":26,"range":{"start_line":26,"start_character":32,"end_line":26,"end_character":92},"in_reply_to":"9f560f44_f602a708","updated":"2020-09-22 22:00:05.000000000","message":"Fixed","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4a9d7b481286ccfafc27166c38ec31d1daaf0d9d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\treturn \"number of retries execeed\""},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"// ErrContainerConfigFile is returned when mandatory flag is missing in the command line"},{"line_number":36,"context_line":"type ErrContainerConfigFile struct {"},{"line_number":37,"context_line":"\tWhat string"},{"line_number":38,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":75,"id":"9f560f44_56043314","line":35,"range":{"start_line":35,"start_character":26,"end_line":35,"end_character":88},"updated":"2020-09-22 17:16:01.000000000","message":"this description also seems to be copied and left behind","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"dd2be439836ccb79788ee0d5d1fdc14bbae4cff2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\treturn \"number of retries execeed\""},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"// ErrContainerConfigFile is returned when mandatory flag is missing in the command line"},{"line_number":36,"context_line":"type ErrContainerConfigFile struct {"},{"line_number":37,"context_line":"\tWhat string"},{"line_number":38,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":75,"id":"9f560f44_277eab69","line":35,"range":{"start_line":35,"start_character":26,"end_line":35,"end_character":88},"in_reply_to":"9f560f44_56043314","updated":"2020-09-22 22:00:05.000000000","message":"Fixed","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"432d9eaf9ab5db0528e4e13af92312832b435f57","unresolved":false,"context_lines":[{"line_number":20,"context_line":"}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"func (e ErrNumberOfRetriesExceeded) Error() string {"},{"line_number":23,"context_line":"\treturn \"number of retries execeed\""},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"// ErrContainerConfigFile is returned when container configuration file is mal formed"}],"source_content_type":"text/x-go","patch_set":79,"id":"9f560f44_7503f610","line":23,"range":{"start_line":23,"start_character":27,"end_line":23,"end_character":34},"updated":"2020-09-24 22:16:18.000000000","message":"exceeded","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4e6d7c120fa25141c33af82b048735003227a8bf","unresolved":false,"context_lines":[{"line_number":20,"context_line":"}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"func (e ErrNumberOfRetriesExceeded) Error() string {"},{"line_number":23,"context_line":"\treturn \"number of retries execeed\""},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"// ErrContainerConfigFile is returned when container configuration file is mal formed"}],"source_content_type":"text/x-go","patch_set":79,"id":"9f560f44_9b2a397b","line":23,"range":{"start_line":23,"start_character":27,"end_line":23,"end_character":34},"in_reply_to":"9f560f44_7503f610","updated":"2020-09-24 23:26:35.000000000","message":"Done","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"}],"pkg/config/bootstrap.go":[{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"c0db75befaa23226802df8daefc06fc17efe123e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":66,"id":"9f560f44_9f545c00","updated":"2020-09-18 09:00:19.000000000","message":"We already did have the same file with the same name here and it was removed [1]. All of your functionality seems pretty similar. Are you sure that all of these structures are required in config? I\u0027d suggest to take a look at airshipctl document model and already existing bootstrapInfo.\n\n\n[1] https://review.opendev.org/#/c/730600/42/pkg/config/bootstrap.go","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":66,"id":"9f560f44_efee85eb","in_reply_to":"9f560f44_9f545c00","updated":"2020-09-18 15:02:18.000000000","message":"I was reusing bootstrapInfo but it was removed in the master so the code was updated to cope with this change.","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"c0db75befaa23226802df8daefc06fc17efe123e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":"Copyright 2014 The Kubernetes Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-go","patch_set":66,"id":"9f560f44_a48039c1","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":38},"updated":"2020-09-18 09:00:19.000000000","message":"remove this line please","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":"Copyright 2014 The Kubernetes Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-go","patch_set":66,"id":"9f560f44_cfe901e4","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":38},"in_reply_to":"9f560f44_a48039c1","updated":"2020-09-18 15:02:18.000000000","message":"Done","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"}],"pkg/config/testdata/config-string.yaml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9fecf7fde3e253ea834ad09978f07fdd50c7259a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":80,"id":"9f560f44_03550d50","updated":"2020-09-25 21:53:17.000000000","message":"Similar to the bootstrap command, using a bootstrap section of options that is only applicable to a public cloud use case makes these options seem mandatory for baremetal use cases. I think naming this section cloudProvider would avoid that.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"b9ba3008b6e88d419122a05475d3888833945d5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":80,"id":"9f560f44_7a7f3517","in_reply_to":"9f560f44_03550d50","updated":"2020-09-28 15:31:21.000000000","message":"The \"bootstrap\" element is designed to support private/public cloud as well as any other platform in the future, e.g., baremetal.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"}],"pkg/config/utils.go":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"432d9eaf9ab5db0528e4e13af92312832b435f57","unresolved":false,"context_lines":[{"line_number":84,"context_line":"\treturn \u0026Context{}"},{"line_number":85,"context_line":"}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"// NewBootstrap is a convenience function that returns a new Context"},{"line_number":88,"context_line":"func NewBootstrap() *Bootstrap {"},{"line_number":89,"context_line":"\treturn \u0026Bootstrap{}"},{"line_number":90,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":79,"id":"9f560f44_d0077016","line":87,"range":{"start_line":87,"start_character":61,"end_line":87,"end_character":68},"updated":"2020-09-24 22:16:18.000000000","message":"Bootstrap","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4e6d7c120fa25141c33af82b048735003227a8bf","unresolved":false,"context_lines":[{"line_number":84,"context_line":"\treturn \u0026Context{}"},{"line_number":85,"context_line":"}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"// NewBootstrap is a convenience function that returns a new Context"},{"line_number":88,"context_line":"func NewBootstrap() *Bootstrap {"},{"line_number":89,"context_line":"\treturn \u0026Bootstrap{}"},{"line_number":90,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":79,"id":"9f560f44_fb1d3562","line":87,"range":{"start_line":87,"start_character":61,"end_line":87,"end_character":68},"in_reply_to":"9f560f44_d0077016","updated":"2020-09-24 23:26:35.000000000","message":"Done","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"}],"playbooks/airship-collect-azure-logs.yaml":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"56de7d6a6640ebd0e34c50676fdaf2cc91ebdf5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"bf51134e_48c85220","updated":"2020-07-22 23:26:05.000000000","message":"Where is Azure logs collection here? We already have roles for log collection. Please, re-use it or modify it if need any overrides.","commit_id":"2397fe1f9d61975b4d654615b856bbbe71e096c4"}],"playbooks/airship-collect-bootstrap-logs.yaml":[{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"c0db75befaa23226802df8daefc06fc17efe123e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":66,"id":"9f560f44_a43839ee","line":1,"range":{"start_line":1,"start_character":44,"end_line":1,"end_character":44},"updated":"2020-09-18 09:00:19.000000000","message":"remove this line please","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":66,"id":"9f560f44_4facd19e","line":1,"range":{"start_line":1,"start_character":44,"end_line":1,"end_character":44},"in_reply_to":"9f560f44_a43839ee","updated":"2020-09-18 15:02:18.000000000","message":"Done","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4a9d7b481286ccfafc27166c38ec31d1daaf0d9d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    logs_dir: \"/tmp/logs\""},{"line_number":16,"context_line":"  roles:"},{"line_number":17,"context_line":"    - gather-system-logs"},{"line_number":18,"context_line":"    # - airship-gather-apache-logs"},{"line_number":19,"context_line":"    # - airship-gather-libvirt-logs"},{"line_number":20,"context_line":"    # - airship-gather-runtime-logs"},{"line_number":21,"context_line":"    # - airship-airshipctl-gather-configs"},{"line_number":22,"context_line":"  environment:"},{"line_number":23,"context_line":"    LIBVIRT_DEFAULT_URI: qemu:///system"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":75,"id":"9f560f44_9611ab56","line":21,"range":{"start_line":18,"start_character":0,"end_line":21,"end_character":41},"updated":"2020-09-22 17:16:01.000000000","message":"Why are these commented?","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"dd2be439836ccb79788ee0d5d1fdc14bbae4cff2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    logs_dir: \"/tmp/logs\""},{"line_number":16,"context_line":"  roles:"},{"line_number":17,"context_line":"    - gather-system-logs"},{"line_number":18,"context_line":"    # - airship-gather-apache-logs"},{"line_number":19,"context_line":"    # - airship-gather-libvirt-logs"},{"line_number":20,"context_line":"    # - airship-gather-runtime-logs"},{"line_number":21,"context_line":"    # - airship-airshipctl-gather-configs"},{"line_number":22,"context_line":"  environment:"},{"line_number":23,"context_line":"    LIBVIRT_DEFAULT_URI: qemu:///system"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":75,"id":"9f560f44_83fa0a74","line":21,"range":{"start_line":18,"start_character":0,"end_line":21,"end_character":41},"in_reply_to":"9f560f44_9611ab56","updated":"2020-09-22 22:00:05.000000000","message":"uncommented:\n- airship-gather-runtime-logs\n- airship-airshipctl-gather-configs\n\ndeleted:\n- airship-gather-apache-logs: apache not used\n-  airship-gather-libvirt-logs: virtualization api not used","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4a9d7b481286ccfafc27166c38ec31d1daaf0d9d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  environment:"},{"line_number":23,"context_line":"    LIBVIRT_DEFAULT_URI: qemu:///system"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  # tasks:"},{"line_number":26,"context_line":"  #   - name: save logs for ephemeral cluster"},{"line_number":27,"context_line":"  #     include_role:"},{"line_number":28,"context_line":"  #       name: airship-gather-pod-logs"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"9f560f44_d617a345","line":28,"range":{"start_line":25,"start_character":0,"end_line":28,"end_character":39},"updated":"2020-09-22 17:16:01.000000000","message":"Same question here","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"dd2be439836ccb79788ee0d5d1fdc14bbae4cff2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  environment:"},{"line_number":23,"context_line":"    LIBVIRT_DEFAULT_URI: qemu:///system"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  # tasks:"},{"line_number":26,"context_line":"  #   - name: save logs for ephemeral cluster"},{"line_number":27,"context_line":"  #     include_role:"},{"line_number":28,"context_line":"  #       name: airship-gather-pod-logs"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"9f560f44_63fff665","line":28,"range":{"start_line":25,"start_character":0,"end_line":28,"end_character":39},"in_reply_to":"9f560f44_d617a345","updated":"2020-09-22 22:00:05.000000000","message":"Uncommented","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9fecf7fde3e253ea834ad09978f07fdd50c7259a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    - name: run roles"},{"line_number":28,"context_line":"      include_role:"},{"line_number":29,"context_line":"        name: \"{{ role_name }}\""},{"line_number":30,"context_line":"      with_items: \"{{ log_roles | default(default_log_roles) }}\""},{"line_number":31,"context_line":"      loop_control:"},{"line_number":32,"context_line":"        loop_var: role_name"}],"source_content_type":"text/x-yaml","patch_set":80,"id":"9f560f44_a35a617e","line":30,"range":{"start_line":30,"start_character":22,"end_line":30,"end_character":31},"updated":"2020-09-25 21:53:17.000000000","message":"The list of log roles can be shortened using the \"log_roles\" Zuul variable. That would allow you to utilize the existing log playbook [0] without copying the contents to this one and reduce technical debt.\n\n[0] https://github.com/airshipit/airshipctl/blob/master/playbooks/airship-collect-logs.yaml","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"b9ba3008b6e88d419122a05475d3888833945d5a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    - name: run roles"},{"line_number":28,"context_line":"      include_role:"},{"line_number":29,"context_line":"        name: \"{{ role_name }}\""},{"line_number":30,"context_line":"      with_items: \"{{ log_roles | default(default_log_roles) }}\""},{"line_number":31,"context_line":"      loop_control:"},{"line_number":32,"context_line":"        loop_var: role_name"}],"source_content_type":"text/x-yaml","patch_set":80,"id":"9f560f44_9af1699a","line":30,"range":{"start_line":30,"start_character":22,"end_line":30,"end_character":31},"in_reply_to":"9f560f44_a35a617e","updated":"2020-09-28 15:31:21.000000000","message":"Done","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"}],"roles/airshipctl-azure-test-configs/tasks/generate.yaml":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"56de7d6a6640ebd0e34c50676fdaf2cc91ebdf5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"bf51134e_68c5560a","updated":"2020-07-22 23:26:05.000000000","message":"This role looks like a regular role for config generation, not azure specific.\n\nWe moved to shell scripts for most of the deployment steps. Could you, please, use [1]? Make appropriate changes to support overrides.\n\n[1] https://review.opendev.org/gitweb?p\u003dairship/airshipctl.git;a\u003dblob;f\u003dtools/deployment/22_test_configs.sh;h\u003db86510c486f94b1f40df195ebee8b873409cf1de;hb\u003dHEAD","commit_id":"2397fe1f9d61975b4d654615b856bbbe71e096c4"}],"roles/deploy-kind-cluster/tasks/main.yml":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"56de7d6a6640ebd0e34c50676fdaf2cc91ebdf5d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    kind create cluster --name airship2-kind-api --kubeconfig \"{{ ansible_env.HOME }}/.airship/kubeconfig\""},{"line_number":16,"context_line":"  become: yes"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# - name: verify k8s cluster services are created"},{"line_number":19,"context_line":"#   command: \u003e-"},{"line_number":20,"context_line":"#     timeout 20 kubectl \\"},{"line_number":21,"context_line":"#     --kubeconfig {{ airshipctl_config_dir_default | default(ansible_env.HOME) }}/.airship/kubeconfig \\"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"bf51134e_8836ea50","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":49},"updated":"2020-07-22 23:26:05.000000000","message":"Why do we need commented code?","commit_id":"2397fe1f9d61975b4d654615b856bbbe71e096c4"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"48c1d9eb30fe35852de1ba84f6ffa2ba0a18ffb2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    kind create cluster --name airship2-kind-api --kubeconfig \"{{ ansible_env.HOME }}/.airship/kubeconfig\""},{"line_number":16,"context_line":"  become: yes"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# - name: verify k8s cluster services are created"},{"line_number":19,"context_line":"#   command: \u003e-"},{"line_number":20,"context_line":"#     timeout 20 kubectl \\"},{"line_number":21,"context_line":"#     --kubeconfig {{ airshipctl_config_dir_default | default(ansible_env.HOME) }}/.airship/kubeconfig \\"},{"line_number":22,"context_line":"#     get deploy -n {{ item.namespace }} {{ item.name }}"},{"line_number":23,"context_line":"#   register: deploy_status"},{"line_number":24,"context_line":"#   until: item.name in deploy_status.stdout"},{"line_number":25,"context_line":"#   with_items:"},{"line_number":26,"context_line":"#     - namespace: kube-system"},{"line_number":27,"context_line":"#       name: coredns"},{"line_number":28,"context_line":"#     - namespace: kube-system"},{"line_number":29,"context_line":"#       name: etcd-airship2-kind-api-control-plane"},{"line_number":30,"context_line":"#     - namespace: kube-system"},{"line_number":31,"context_line":"#       name: kindnet"},{"line_number":32,"context_line":"#     - namespace: kube-system"},{"line_number":33,"context_line":"#       name: capi-controller-manager"},{"line_number":34,"context_line":"#     - namespace: kube-system"},{"line_number":35,"context_line":"#       name: capi-kubeadm-bootstrap-controller-manager"},{"line_number":36,"context_line":"#     - namespace: kube-system"},{"line_number":37,"context_line":"#       name: capi-kubeadm-control-plane-controller-manager"},{"line_number":38,"context_line":"#     - namespace: capi-webhook-system"},{"line_number":39,"context_line":"#       name: capz-controller-manager"},{"line_number":40,"context_line":"#     - namespace: capz-system"},{"line_number":41,"context_line":"#       name: capz-controller-manager"},{"line_number":42,"context_line":"#     - namespace: cert-manager"},{"line_number":43,"context_line":"#       name: cert-manager"},{"line_number":44,"context_line":"#     - namespace: cert-manager"},{"line_number":45,"context_line":"#       name: cert-manager-cainjector"},{"line_number":46,"context_line":"#     - namespace: cert-manager"},{"line_number":47,"context_line":"#       name: cert-manager-webhook"},{"line_number":48,"context_line":"#   retries: 50"},{"line_number":49,"context_line":"#   delay: 20"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"9f560f44_e8ecfb93","line":49,"range":{"start_line":18,"start_character":0,"end_line":49,"end_character":13},"updated":"2020-09-15 21:18:43.000000000","message":"remove unused code or use it as an option","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    kind create cluster --name airship2-kind-api --kubeconfig \"{{ ansible_env.HOME }}/.airship/kubeconfig\""},{"line_number":16,"context_line":"  become: yes"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# - name: verify k8s cluster services are created"},{"line_number":19,"context_line":"#   command: \u003e-"},{"line_number":20,"context_line":"#     timeout 20 kubectl \\"},{"line_number":21,"context_line":"#     --kubeconfig {{ airshipctl_config_dir_default | default(ansible_env.HOME) }}/.airship/kubeconfig \\"},{"line_number":22,"context_line":"#     get deploy -n {{ item.namespace }} {{ item.name }}"},{"line_number":23,"context_line":"#   register: deploy_status"},{"line_number":24,"context_line":"#   until: item.name in deploy_status.stdout"},{"line_number":25,"context_line":"#   with_items:"},{"line_number":26,"context_line":"#     - namespace: kube-system"},{"line_number":27,"context_line":"#       name: coredns"},{"line_number":28,"context_line":"#     - namespace: kube-system"},{"line_number":29,"context_line":"#       name: etcd-airship2-kind-api-control-plane"},{"line_number":30,"context_line":"#     - namespace: kube-system"},{"line_number":31,"context_line":"#       name: kindnet"},{"line_number":32,"context_line":"#     - namespace: kube-system"},{"line_number":33,"context_line":"#       name: capi-controller-manager"},{"line_number":34,"context_line":"#     - namespace: kube-system"},{"line_number":35,"context_line":"#       name: capi-kubeadm-bootstrap-controller-manager"},{"line_number":36,"context_line":"#     - namespace: kube-system"},{"line_number":37,"context_line":"#       name: capi-kubeadm-control-plane-controller-manager"},{"line_number":38,"context_line":"#     - namespace: capi-webhook-system"},{"line_number":39,"context_line":"#       name: capz-controller-manager"},{"line_number":40,"context_line":"#     - namespace: capz-system"},{"line_number":41,"context_line":"#       name: capz-controller-manager"},{"line_number":42,"context_line":"#     - namespace: cert-manager"},{"line_number":43,"context_line":"#       name: cert-manager"},{"line_number":44,"context_line":"#     - namespace: cert-manager"},{"line_number":45,"context_line":"#       name: cert-manager-cainjector"},{"line_number":46,"context_line":"#     - namespace: cert-manager"},{"line_number":47,"context_line":"#       name: cert-manager-webhook"},{"line_number":48,"context_line":"#   retries: 50"},{"line_number":49,"context_line":"#   delay: 20"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"9f560f44_2b8a3f19","line":49,"range":{"start_line":18,"start_character":0,"end_line":49,"end_character":13},"in_reply_to":"9f560f44_e8ecfb93","updated":"2020-09-18 15:02:18.000000000","message":"Done","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"}],"roles/install-golang/tasks/main.yml":[{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"c0db75befaa23226802df8daefc06fc17efe123e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: install go language"},{"line_number":14,"context_line":"  shell: |"},{"line_number":15,"context_line":"    curl -sSL https://golang.org/dl/go1.14.4.linux-amd64.tar.gz | tar -zxv -C /usr/local/"},{"line_number":16,"context_line":"    echo \"export PATH\u003d$PATH:/usr/local/go/bin\" \u003e\u003e $HOME/.profile"},{"line_number":17,"context_line":"    export PATH\u003d$PATH:/usr/local/go/bin"},{"line_number":18,"context_line":"  become: yes"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"9f560f44_5f3484ac","line":18,"range":{"start_line":13,"start_character":0,"end_line":18,"end_character":13},"updated":"2020-09-18 09:00:19.000000000","message":"what\u0027s the purpose to explicitly install go via ansible role and via bash script 02...?","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: install go language"},{"line_number":14,"context_line":"  shell: |"},{"line_number":15,"context_line":"    curl -sSL https://golang.org/dl/go1.14.4.linux-amd64.tar.gz | tar -zxv -C /usr/local/"},{"line_number":16,"context_line":"    echo \"export PATH\u003d$PATH:/usr/local/go/bin\" \u003e\u003e $HOME/.profile"},{"line_number":17,"context_line":"    export PATH\u003d$PATH:/usr/local/go/bin"},{"line_number":18,"context_line":"  become: yes"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"9f560f44_8fc42943","line":18,"range":{"start_line":13,"start_character":0,"end_line":18,"end_character":13},"in_reply_to":"9f560f44_5f3484ac","updated":"2020-09-18 15:02:18.000000000","message":"This ansible role was there prior to instructions to move towards shell scripts. I am not focusing on cleaning up somebody else code to avoid any break it might cause.","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0fa7f584ffbe79ee204a87b50b56379ca62e4c7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":69,"id":"9f560f44_c7b6053f","updated":"2020-09-18 18:04:36.000000000","message":"Duplication","commit_id":"bfc4e6e05df63f8eb28b957d21c9f3d0a34c1b5f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"cfb2a3b21a8703f64ffb4148b5a31d6c4de01c2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":69,"id":"9f560f44_c7fba544","in_reply_to":"9f560f44_c7b6053f","updated":"2020-09-18 18:31:46.000000000","message":"Removed it. \nHopefully will not affect someone else.","commit_id":"bfc4e6e05df63f8eb28b957d21c9f3d0a34c1b5f"}],"roles/install-kind/tasks/main.yml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4a9d7b481286ccfafc27166c38ec31d1daaf0d9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"9f560f44_963a4bca","updated":"2020-09-22 17:16:01.000000000","message":"We already have a script for this in airshipctl [0]. Please use the existing one.\n\nNOTE: it would be fine to move it to a more common location\n\n[0] https://github.com/airshipit/airshipctl/blob/master/tools/document/get_kind.sh","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"dd2be439836ccb79788ee0d5d1fdc14bbae4cff2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"9f560f44_872337be","in_reply_to":"9f560f44_963a4bca","updated":"2020-09-22 22:00:05.000000000","message":"Deleted this role as I am not using it and checked that nobody else is using it.","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"}],"testutil/testconfig.go":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"432d9eaf9ab5db0528e4e13af92312832b435f57","unresolved":false,"context_lines":[{"line_number":86,"context_line":"\treturn c"},{"line_number":87,"context_line":"}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"// DummyBootstrap creates a Bootstrap config object for unit testing"},{"line_number":90,"context_line":"func DummyBootstrap() *config.Bootstrap {"},{"line_number":91,"context_line":"\tc :\u003d config.NewBootstrap()"},{"line_number":92,"context_line":"\tcontainer :\u003d \u0026config.BootContainer{}"}],"source_content_type":"text/x-go","patch_set":79,"id":"9f560f44_902a187b","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":68},"updated":"2020-09-24 22:16:18.000000000","message":"The same description as for the function above(DummyConfigBootstrap). Maybe this should be different.","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4e6d7c120fa25141c33af82b048735003227a8bf","unresolved":false,"context_lines":[{"line_number":86,"context_line":"\treturn c"},{"line_number":87,"context_line":"}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"// DummyBootstrap creates a Bootstrap config object for unit testing"},{"line_number":90,"context_line":"func DummyBootstrap() *config.Bootstrap {"},{"line_number":91,"context_line":"\tc :\u003d config.NewBootstrap()"},{"line_number":92,"context_line":"\tcontainer :\u003d \u0026config.BootContainer{}"}],"source_content_type":"text/x-go","patch_set":79,"id":"9f560f44_3b3b2dd1","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":68},"in_reply_to":"9f560f44_902a187b","updated":"2020-09-24 23:26:35.000000000","message":"provided additional information for this comment","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"}],"tools/deployment/azure/00_install_kind.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"56de7d6a6640ebd0e34c50676fdaf2cc91ebdf5d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"echo \"Installing Kind\""},{"line_number":16,"context_line":"curl -sSLo ./kind https://github.com/kubernetes-sigs/kind/releases/download/v0.7.0/kind-$(uname)-amd64"},{"line_number":17,"context_line":"chmod +x ./kind"},{"line_number":18,"context_line":"sudo mv ./kind /usr/local/bin/kind"},{"line_number":19,"context_line":"echo \"Kind Installed\""}],"source_content_type":"text/x-sh","patch_set":42,"id":"bf51134e_a833ee61","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":102},"updated":"2020-07-22 23:26:05.000000000","message":"We already have script for kind in ./tools/document. Let\u0027s make it common and re-use code.","commit_id":"2397fe1f9d61975b4d654615b856bbbe71e096c4"}],"tools/deployment/azure/01_install_kubectl.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"48c1d9eb30fe35852de1ba84f6ffa2ba0a18ffb2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  \"${URL}\"/kubernetes-release/release/\"${KUBE_VERSION}\"/bin/linux/amd64/kubectl"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"sudo -E chmod +x /usr/local/bin/kubectl"},{"line_number":25,"context_line":"#kubectl version"}],"source_content_type":"text/x-sh","patch_set":63,"id":"9f560f44_88f73f5a","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":16},"updated":"2020-09-15 21:18:43.000000000","message":"remove this","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  \"${URL}\"/kubernetes-release/release/\"${KUBE_VERSION}\"/bin/linux/amd64/kubectl"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"sudo -E chmod +x /usr/local/bin/kubectl"},{"line_number":25,"context_line":"#kubectl version"}],"source_content_type":"text/x-sh","patch_set":63,"id":"9f560f44_ab75af35","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":16},"in_reply_to":"9f560f44_88f73f5a","updated":"2020-09-18 15:02:18.000000000","message":"Done","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"}],"tools/deployment/azure/02_install_go.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"48c1d9eb30fe35852de1ba84f6ffa2ba0a18ffb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"9f560f44_888c5fd8","updated":"2020-09-15 21:18:43.000000000","message":"There is a role to install Go lang and this is a script to install Go lang. Please, don\u0027t duplicate. Keep only one and use it.","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0fa7f584ffbe79ee204a87b50b56379ca62e4c7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"9f560f44_c761e5d5","in_reply_to":"9f560f44_4bb5f3cf","updated":"2020-09-18 18:04:36.000000000","message":"I see ansible role in your patchset for installing Go and separate script which does the same thing. Correct me if I\u0027m wrong, but this looks like duplication.","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"9f560f44_4bb5f3cf","in_reply_to":"9f560f44_888c5fd8","updated":"2020-09-18 15:02:18.000000000","message":"I was instructed to move towards developing Zuul shell scripts.\n\nBtw, Ansible Role \"install-golang\" was not created by me so didn\u0027t spend time cleaning up somebody else\u0027s code.","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"}],"tools/deployment/azure/03_install_kustomize_docker.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"URL\u003d\"https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh\""},{"line_number":17,"context_line":"sudo -E curl -s \"$URL\" | bash"},{"line_number":18,"context_line":"sudo -E chmod +x ./kustomize"},{"line_number":19,"context_line":"sudo mv ./kustomize /usr/local/bin/kustomize"}],"source_content_type":"text/x-sh","patch_set":51,"id":"9f560f44_45cadb4e","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":98},"updated":"2020-09-04 17:14:27.000000000","message":"We already have a role to install kustomize. Is it something different?","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"48c1d9eb30fe35852de1ba84f6ffa2ba0a18ffb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"9f560f44_e85fdb4a","updated":"2020-09-15 21:18:43.000000000","message":"What does \u0027docker\u0027 mean in the name 03_install_kustomize_docker.sh ?","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"9f560f44_cbcd835f","in_reply_to":"9f560f44_e85fdb4a","updated":"2020-09-18 15:02:18.000000000","message":"Removed \"_docker\" from filename and updated all dependencies","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"}],"tools/deployment/azure/100_clean_up_resources.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  --config azure-config.yaml \\"},{"line_number":28,"context_line":"  --image $CAPZ_DOCKER_IMAGE"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Deleting Ephemeral cluster resources from Google Cloud"},{"line_number":31,"context_line":"echo \"Deleting Ephemeral Cluster on Google Cloud platform...\""},{"line_number":32,"context_line":"airshipctl bootstrap ephemeral \\"},{"line_number":33,"context_line":"  --command delete \\"},{"line_number":34,"context_line":"  --container gcp-zull-bootstrap \\"},{"line_number":35,"context_line":"  --config gcp-config.yaml \\"},{"line_number":36,"context_line":"  --image $CAPG_DOCKER_IMAGE"}],"source_content_type":"text/x-sh","patch_set":51,"id":"9f560f44_05346349","line":36,"range":{"start_line":30,"start_character":0,"end_line":36,"end_character":28},"updated":"2020-09-04 17:14:27.000000000","message":"This is Azure folder for scripts, so, please remove Google Cloud parts from this one.","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"}],"tools/deployment/azure/11_build_bootstrap_container.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":32,"context_line":"go build -o capz-ephemeral"},{"line_number":33,"context_line":"docker build -t $CAPZ_IMAGE ."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Build the Google Cloud Bootstrap Go application"},{"line_number":36,"context_line":"# And create the Google Cloud Bootstrap Container image"},{"line_number":37,"context_line":"echo \"Building GCP Bootstrap Container ...\""},{"line_number":38,"context_line":"cd ${AIRSHIPCTL_WS}/bootstrap_container/capg"},{"line_number":39,"context_line":"export CAPG_IMAGE_NAME\u003dcapg-bootstrap"},{"line_number":40,"context_line":"export CAPG_IMAGE_TAG\u003dlatest"},{"line_number":41,"context_line":"export CAPG_IMAGE\u003d$DOCKER_REGISTRY/$DOCKER_IMAGE_PREFIX/$CAPG_IMAGE_NAME:$CAPG_IMAGE_TAG"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Build Go app and Docker image for the Google Cloud Bootstrap container"},{"line_number":44,"context_line":"go install ."},{"line_number":45,"context_line":"go build -o capg-ephemeral"},{"line_number":46,"context_line":"docker build -t $CAPG_IMAGE ."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"docker images | grep bootstrap"}],"source_content_type":"text/x-sh","patch_set":51,"id":"9f560f44_a52c9701","line":46,"range":{"start_line":35,"start_character":0,"end_line":46,"end_character":29},"updated":"2020-09-04 17:14:27.000000000","message":"This is Azure folder for scripts, so, please remove Google Cloud parts from this one.","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"}],"tools/deployment/azure/11_build_kind_cluster.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":31,"context_line":"echo \"Waiting $TIMEOUT seconds for Capi Docker Control Plane node to be ready.\""},{"line_number":32,"context_line":"while true; do"},{"line_number":33,"context_line":"    if (kubectl --request-timeout 20s --kubeconfig $KUBECONFIG get nodes capi-azure-control-plane -o jsonpath\u003d\u0027{.status.conditions[?(@.type\u003d\u003d\"Ready\")].status}\u0027 | grep -q True) ; then"},{"line_number":34,"context_line":"        echo -e \"\\nCapi Docker Control Plane Node is ready.\""},{"line_number":35,"context_line":"        kubectl --request-timeout 20s --kubeconfig $KUBECONFIG get nodes"},{"line_number":36,"context_line":"        break"},{"line_number":37,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":51,"id":"9f560f44_453dbb2a","line":34,"range":{"start_line":34,"start_character":19,"end_line":34,"end_character":23},"updated":"2020-09-04 17:14:27.000000000","message":"CAPI","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    else"},{"line_number":38,"context_line":"        now\u003d$(date +%s)"},{"line_number":39,"context_line":"        if [ $now -gt $end ]; then"},{"line_number":40,"context_line":"            echo -e \"\\nCapi Azure Control Plane Node was not ready before TIMEOUT.\""},{"line_number":41,"context_line":"            exit 1"},{"line_number":42,"context_line":"        fi"},{"line_number":43,"context_line":"        echo -n ."}],"source_content_type":"text/x-sh","patch_set":51,"id":"9f560f44_8547d3bc","line":40,"range":{"start_line":40,"start_character":23,"end_line":40,"end_character":27},"updated":"2020-09-04 17:14:27.000000000","message":"CAPI","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"}],"tools/deployment/azure/200_transfer_airshipctl.sh":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"b39ed2da9cde0df1a042a54f737487b616811479","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# This script transfers the local Airship project to the remote machine,"},{"line_number":16,"context_line":"# copies the test/validation script to the remote machine and then executes it."},{"line_number":17,"context_line":"# "},{"line_number":18,"context_line":"# This script is a local test simulating Zuul gates used to test and validate "},{"line_number":19,"context_line":"# the Azure clout integration."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":41,"id":"bf51134e_dbbaa06c","line":17,"range":{"start_line":17,"start_character":1,"end_line":17,"end_character":2},"updated":"2020-07-20 19:18:33.000000000","message":"Trailing whitespace","commit_id":"c5ca0187d7ae086fab7d6cc2de0c10f0317330fd"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"b39ed2da9cde0df1a042a54f737487b616811479","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# This script transfers the local Airship project to the remote machine,"},{"line_number":16,"context_line":"# copies the test/validation script to the remote machine and then executes it."},{"line_number":17,"context_line":"# "},{"line_number":18,"context_line":"# This script is a local test simulating Zuul gates used to test and validate "},{"line_number":19,"context_line":"# the Azure clout integration."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if [ -n \"$3\" ]; then"}],"source_content_type":"text/x-sh","patch_set":41,"id":"bf51134e_fbb5e47f","line":18,"range":{"start_line":18,"start_character":77,"end_line":18,"end_character":78},"updated":"2020-07-20 19:18:33.000000000","message":"Trailing whitespace","commit_id":"c5ca0187d7ae086fab7d6cc2de0c10f0317330fd"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"b39ed2da9cde0df1a042a54f737487b616811479","unresolved":false,"context_lines":[{"line_number":62,"context_line":"scp -r $LOCAL_AIRSHIP_DIR/ $REMOTE_USERNAME@$REMOTE_VM_IP:/home/zuul/src/opendev.org/airship/airshipctl"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"echo \"scp $LOCAL_AIRSHIP_DIR/tools/deployment/azure/201_zuul_local_test.sh $REMOTE_USERNAME@$REMOTE_VM_IP:~\""},{"line_number":65,"context_line":"scp $LOCAL_AIRSHIP_DIR/tools/deployment/azure/201_zuul_local_test.sh $REMOTE_USERNAME@$REMOTE_VM_IP:~"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"echo \"ssh $REMOTE_USERNAME@$REMOTE_VM_IP \u0027bash ~/201_zuul_local_test.sh\u0027\""},{"line_number":68,"context_line":"ssh $REMOTE_USERNAME@$REMOTE_VM_IP \u0027bash ~/201_zuul_local_test.sh\u0027"}],"source_content_type":"text/x-sh","patch_set":41,"id":"bf51134e_db3d80de","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":101},"updated":"2020-07-20 19:18:33.000000000","message":"Why are we copying the project to the Azure VM and running the scripts there, instead of just running them here against the kubernetes API hosted in Azure?  Let me know if I\u0027m misunderstanding something.","commit_id":"c5ca0187d7ae086fab7d6cc2de0c10f0317330fd"}],"tools/deployment/azure/201_zuul_local_test.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"echo \"Azure Subscription ID \u003d $AZURE_SUBSCRIPTION_ID\""},{"line_number":28,"context_line":"echo \"Azure Tenant ID \u003d $AZURE_TENANT_ID\""},{"line_number":29,"context_line":"echo \"Google Cloud Project ID \u003d $GCP_PROJECT\""},{"line_number":30,"context_line":"echo \"Google Cloud Account ID \u003d $GCP_ACCOUNT\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"cd $AIRSHIPCTL_WS"},{"line_number":33,"context_line":"echo \"----- Airship Directory \u003d $AIRSHIPCTL_WS\""}],"source_content_type":"text/x-sh","patch_set":51,"id":"9f560f44_c5126bb4","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":45},"updated":"2020-09-04 17:14:27.000000000","message":"This is Azure folder for scripts, so, please remove Google Cloud parts from this one.","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# docker image options"},{"line_number":36,"context_line":"export DOCKER_REGISTRY\u003d\"quay.io\""},{"line_number":37,"context_line":"export DOCKER_IMAGE_REPO\u003d\"sshiba\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"export CAPZ_IMAGE_NAME\u003d\"capz-bootstrap\""},{"line_number":40,"context_line":"export CAPZ_IMAGE_TAG\u003d\"latest\""}],"source_content_type":"text/x-sh","patch_set":51,"id":"9f560f44_050d838f","line":37,"range":{"start_line":37,"start_character":26,"end_line":37,"end_character":32},"updated":"2020-09-04 17:14:27.000000000","message":"Why do we use personal repo here?","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":40,"context_line":"export CAPZ_IMAGE_TAG\u003d\"latest\""},{"line_number":41,"context_line":"export CAPZ_DOCKER_IMAGE\u003d$DOCKER_REGISTRY/$DOCKER_IMAGE_REPO/$CAPZ_IMAGE_NAME:$CAPZ_IMAGE_TAG"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"export CAPG_IMAGE_NAME\u003d\"capg-bootstrap\""},{"line_number":44,"context_line":"export CAPG_IMAGE_TAG\u003d\"latest\""},{"line_number":45,"context_line":"export CAPG_DOCKER_IMAGE\u003d$DOCKER_REGISTRY/$DOCKER_IMAGE_REPO/$CAPG_IMAGE_NAME:$CAPG_IMAGE_TAG"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Installation of Kubectl"},{"line_number":48,"context_line":"echo \"************************************************************************\""}],"source_content_type":"text/x-sh","patch_set":51,"id":"9f560f44_a515b79d","line":45,"range":{"start_line":43,"start_character":0,"end_line":45,"end_character":93},"updated":"2020-09-04 17:14:27.000000000","message":"This is Azure folder for scripts, so, please remove Google Cloud parts from this one.","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Deploying Ephemeral Cluster using Azure Bootstrap Container"},{"line_number":111,"context_line":"echo \"************************************************************************\""},{"line_number":112,"context_line":"echo \"***** Deploying Ephemeral cluster in Google Cloud with Bootstrap Container ...\""},{"line_number":113,"context_line":"./tools/deployment/azure/41_deploy_gcp_ephemeral_cluster.sh"},{"line_number":114,"context_line":"if [ $? -ne 0 ]; then"},{"line_number":115,"context_line":"    echo \"\u003e\u003e\u003e\u003e\u003e Failed to deploy GCP Ephemeral cluster\""},{"line_number":116,"context_line":"    exit 1"},{"line_number":117,"context_line":"fi"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# Initializing CAPI and CAPZ components for the Managemeng cluster"},{"line_number":120,"context_line":"echo \"************************************************************************\""}],"source_content_type":"text/x-sh","patch_set":51,"id":"9f560f44_e50faf85","line":117,"range":{"start_line":112,"start_character":0,"end_line":117,"end_character":2},"updated":"2020-09-04 17:14:27.000000000","message":"This is Azure folder for scripts, so, please remove Google Cloud parts from this one.","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"48c1d9eb30fe35852de1ba84f6ffa2ba0a18ffb2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"export PATH\u003d$PATH:/usr/local/go/bin/"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Setting Public Cloud Credentials as Environment Variables"},{"line_number":24,"context_line":"echo \"source ~/.profile\""},{"line_number":25,"context_line":"source ~/.profile"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"echo \"Azure Subscription ID \u003d $AZURE_SUBSCRIPTION_ID\""},{"line_number":28,"context_line":"echo \"Azure Tenant ID \u003d $AZURE_TENANT_ID\""}],"source_content_type":"text/x-sh","patch_set":63,"id":"9f560f44_8853bf39","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":17},"updated":"2020-09-15 21:18:43.000000000","message":"Make it configurable. Use HOME or special var.","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"export PATH\u003d$PATH:/usr/local/go/bin/"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Setting Public Cloud Credentials as Environment Variables"},{"line_number":24,"context_line":"echo \"source ~/.profile\""},{"line_number":25,"context_line":"source ~/.profile"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"echo \"Azure Subscription ID \u003d $AZURE_SUBSCRIPTION_ID\""},{"line_number":28,"context_line":"echo \"Azure Tenant ID \u003d $AZURE_TENANT_ID\""}],"source_content_type":"text/x-sh","patch_set":63,"id":"9f560f44_4b033377","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":17},"in_reply_to":"9f560f44_8853bf39","updated":"2020-09-18 15:02:18.000000000","message":"Replace \"~\" by \"$HOME\"","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"}],"tools/deployment/azure/21_systemwide_executable.sh":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"b39ed2da9cde0df1a042a54f737487b616811479","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":12,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -xe"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"export USE_PROXY\u003d${USE_PROXY:-\"false\"}"}],"source_content_type":"text/x-sh","patch_set":41,"id":"bf51134e_7be274a2","line":14,"updated":"2020-07-20 19:18:33.000000000","message":"Is there any difference between this script and the existing 21_systemwide_executable.sh?  If they\u0027re the same, can we just use the other one when testing against Azure, to avoid duplication?","commit_id":"c5ca0187d7ae086fab7d6cc2de0c10f0317330fd"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"29dfdab0913e8f6f5c4df2f1046bde60fde8f4e8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":12,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -xe"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"export USE_PROXY\u003d${USE_PROXY:-\"false\"}"}],"source_content_type":"text/x-sh","patch_set":41,"id":"bf51134e_ad4a04a9","line":14,"in_reply_to":"bf51134e_7be274a2","updated":"2020-07-21 15:11:27.000000000","message":"On second thought, can we make this script simply a symlink back to the existing script?  That seems like the best of both worlds.","commit_id":"c5ca0187d7ae086fab7d6cc2de0c10f0317330fd"}],"tools/deployment/azure/31_create_configs.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"56de7d6a6640ebd0e34c50676fdaf2cc91ebdf5d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"cp -rp ~/.kube/config ~/.airship/kubeconfig"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"echo \"Generate ~/.airship/config\""},{"line_number":52,"context_line":"envsubst \u003c\"${AIRSHIPCTL_WS}/tools/deployment/templates/azure_airshipconfig_template\" \u003e ~/.airship/config"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-sh","patch_set":42,"id":"bf51134e_482cd200","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":104},"updated":"2020-07-22 23:26:05.000000000","message":"Azure specific template can be overridden in main scripts from ./tools directory. Make appropriate changes if it\u0027s not supported. Don\u0027t need new scripts for deployment.","commit_id":"2397fe1f9d61975b4d654615b856bbbe71e096c4"}],"tools/deployment/azure/32_create_bootstrap_configs.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":21,"context_line":"echo \"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\""},{"line_number":22,"context_line":"echo \"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"echo \"Generate ~/.airship/gcp-config.yaml\""},{"line_number":25,"context_line":"envsubst \u003c\"${AIRSHIPCTL_WS}/tools/deployment/templates/gcp_config.yaml\" \u003e $HOME/.airship/gcp-config.yaml"},{"line_number":26,"context_line":"echo \"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\""},{"line_number":27,"context_line":"cat $HOME/.airship/gcp-config.yaml"},{"line_number":28,"context_line":"echo \"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\""},{"line_number":29,"context_line":"echo \"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"echo \"Generate ~/.airship/gcp-credentials.json\""},{"line_number":32,"context_line":"envsubst \u003c\"${AIRSHIPCTL_WS}/tools/deployment/templates/gcp-credentials.json\" \u003e $HOME/.airship/gcp-credentials.json"},{"line_number":33,"context_line":"echo \"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\""},{"line_number":34,"context_line":"cat $HOME/.airship/gcp-credentials.json"},{"line_number":35,"context_line":"echo \"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\""},{"line_number":36,"context_line":"echo \"\""}],"source_content_type":"text/x-sh","patch_set":51,"id":"9f560f44_a57ad7ec","line":36,"range":{"start_line":24,"start_character":0,"end_line":36,"end_character":7},"updated":"2020-09-04 17:14:27.000000000","message":"This is Azure folder for scripts, so, please remove Google Cloud parts from this one.","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"}],"tools/deployment/azure/41_deploy_azure_ephemeral_cluster.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"set -xe"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo \"Deploying Ephemeral Clustere on Azure Cloud platform...\""},{"line_number":19,"context_line":"airshipctl bootstrap ephemeral \\"},{"line_number":20,"context_line":"  --command create \\"},{"line_number":21,"context_line":"  --container azure-zuul-bootstrap \\"}],"source_content_type":"text/x-sh","patch_set":51,"id":"9f560f44_e584cfd5","line":18,"range":{"start_line":18,"start_character":26,"end_line":18,"end_character":34},"updated":"2020-09-04 17:14:27.000000000","message":"typo","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"48c1d9eb30fe35852de1ba84f6ffa2ba0a18ffb2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  --config azure-config.yaml \\"},{"line_number":23,"context_line":"  --image $CAPZ_DOCKER_IMAGE"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Verifying"},{"line_number":26,"context_line":"cp $HOME/.airship/capz.kubeconfig $HOME/.airship/kubeconfig"},{"line_number":27,"context_line":"kubectl --kubeconfig $HOME/.airship/kubeconfig get nodes"}],"source_content_type":"text/x-sh","patch_set":63,"id":"9f560f44_5c16884b","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":11},"updated":"2020-09-15 21:18:43.000000000","message":"Where is the verification process?","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  --config azure-config.yaml \\"},{"line_number":23,"context_line":"  --image $CAPZ_DOCKER_IMAGE"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Verifying"},{"line_number":26,"context_line":"cp $HOME/.airship/capz.kubeconfig $HOME/.airship/kubeconfig"},{"line_number":27,"context_line":"kubectl --kubeconfig $HOME/.airship/kubeconfig get nodes"}],"source_content_type":"text/x-sh","patch_set":63,"id":"9f560f44_2b2b5fea","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":11},"in_reply_to":"9f560f44_5c16884b","updated":"2020-09-18 15:02:18.000000000","message":"Replace the comment to \"Setting the kubeconfig file\"","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"}],"tools/deployment/azure/41_deploy_gcp_ephemeral_cluster.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":51,"id":"9f560f44_2566c756","updated":"2020-09-04 17:14:27.000000000","message":"This is Azure folder for scripts. Why do we need Google cloud script here?","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"48c1d9eb30fe35852de1ba84f6ffa2ba0a18ffb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"9f560f44_9c9ca0c0","updated":"2020-09-15 21:18:43.000000000","message":"I totally disagree with such a way of locating scripts. The directory is about Azure. The common scripts should be placed in a common directory and specific ones - in a specific directory.","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"9f560f44_6b8397cc","in_reply_to":"9f560f44_9c9ca0c0","updated":"2020-09-18 15:02:18.000000000","message":"replace the parent folder name \"azure\" to \"bootstrap\"","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"48c1d9eb30fe35852de1ba84f6ffa2ba0a18ffb2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"gcloud auth activate-service-account $GCP_ACCOUNT --key-file\u003d$HOME/.airship/gcp-credentials.json"},{"line_number":22,"context_line":"gcloud config set project $GCP_PROJECT"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Deploy Ephemeral Cluster on Google cloud"},{"line_number":25,"context_line":"echo \"Deploying Ephemeral Clustere on Google Cloud platform...\""},{"line_number":26,"context_line":"airshipctl bootstrap ephemeral \\"},{"line_number":27,"context_line":"  --command create \\"}],"source_content_type":"text/x-sh","patch_set":63,"id":"9f560f44_fc6cbcd1","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":42},"updated":"2020-09-15 21:18:43.000000000","message":"no need, you have echo with the same message","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"gcloud auth activate-service-account $GCP_ACCOUNT --key-file\u003d$HOME/.airship/gcp-credentials.json"},{"line_number":22,"context_line":"gcloud config set project $GCP_PROJECT"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Deploy Ephemeral Cluster on Google cloud"},{"line_number":25,"context_line":"echo \"Deploying Ephemeral Clustere on Google Cloud platform...\""},{"line_number":26,"context_line":"airshipctl bootstrap ephemeral \\"},{"line_number":27,"context_line":"  --command create \\"}],"source_content_type":"text/x-sh","patch_set":63,"id":"9f560f44_0b749bfd","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":42},"in_reply_to":"9f560f44_fc6cbcd1","updated":"2020-09-18 15:02:18.000000000","message":"Done","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"48c1d9eb30fe35852de1ba84f6ffa2ba0a18ffb2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"gcloud config set project $GCP_PROJECT"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Deploy Ephemeral Cluster on Google cloud"},{"line_number":25,"context_line":"echo \"Deploying Ephemeral Clustere on Google Cloud platform...\""},{"line_number":26,"context_line":"airshipctl bootstrap ephemeral \\"},{"line_number":27,"context_line":"  --command create \\"},{"line_number":28,"context_line":"  --container gcp-zuul-bootstrap \\"}],"source_content_type":"text/x-sh","patch_set":63,"id":"9f560f44_7c470c4e","line":25,"range":{"start_line":25,"start_character":26,"end_line":25,"end_character":34},"updated":"2020-09-15 21:18:43.000000000","message":"typo","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"gcloud config set project $GCP_PROJECT"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Deploy Ephemeral Cluster on Google cloud"},{"line_number":25,"context_line":"echo \"Deploying Ephemeral Clustere on Google Cloud platform...\""},{"line_number":26,"context_line":"airshipctl bootstrap ephemeral \\"},{"line_number":27,"context_line":"  --command create \\"},{"line_number":28,"context_line":"  --container gcp-zuul-bootstrap \\"}],"source_content_type":"text/x-sh","patch_set":63,"id":"9f560f44_4b5fb374","line":25,"range":{"start_line":25,"start_character":26,"end_line":25,"end_character":34},"in_reply_to":"9f560f44_7c470c4e","updated":"2020-09-18 15:02:18.000000000","message":"Done","commit_id":"30dfc7b0680050e84a0e82d0e56e5402953bacfb"}],"tools/deployment/azure/41_initialize_management_cluster.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"56de7d6a6640ebd0e34c50676fdaf2cc91ebdf5d","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"echo \"Initialize Managment Cluster with CAPI and CAPZ Components\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"airshipctl cluster init --debug"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"echo \"Waiting for all pods to come up\""},{"line_number":25,"context_line":"kubectl --kubeconfig $KUBECONFIG wait --for\u003dcondition\u003dready pods --all --timeout\u003d1000s -A"}],"source_content_type":"text/x-sh","patch_set":42,"id":"bf51134e_28f23e9b","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":31},"updated":"2020-07-22 23:26:05.000000000","message":"We already have scripts for deployment in ./tools directory and it looks like duplication. Let\u0027s re-use our code.","commit_id":"2397fe1f9d61975b4d654615b856bbbe71e096c4"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":17,"context_line":"export AIRSHIPCTL_WS\u003d${AIRSHIPCTL_WS:-$PWD}"},{"line_number":18,"context_line":"export KUBECONFIG\u003d${KUBECONFIG:-\"$HOME/.airship/kubeconfig\"}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"echo \"Initialize Managment Cluster with CAPI and CAPZ Components\""},{"line_number":21,"context_line":"airshipctl cluster init --debug"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"echo \"Waiting for all pods to come up\""}],"source_content_type":"text/x-sh","patch_set":51,"id":"9f560f44_857513fd","line":20,"range":{"start_line":20,"start_character":17,"end_line":20,"end_character":26},"updated":"2020-09-04 17:14:27.000000000","message":"typo","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"}],"tools/deployment/azure/README.md":[{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"a1fb69f35be75f1224dfe133b416a18ee09fc45c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Zuul Gate Scripts for Bootstrap Container/Ephemeral Cluster/Azure Target Cluster"},{"line_number":2,"context_line":"This folder container the Zuul Gate Scripts for configuring the tools necessary to"},{"line_number":3,"context_line":"automatically validate the building of Bootstrap Container (Go app + Docker Image),"},{"line_number":4,"context_line":"deployment of Ephemeral Cluster on Azure Cloud and Google Cloud, then using the"},{"line_number":5,"context_line":"Azure Ephemeral Cluster to deploy the Target Cluster on Azure Cloud."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":49,"id":"9f560f44_2710a1a8","line":3,"range":{"start_line":3,"start_character":14,"end_line":3,"end_character":82},"updated":"2020-09-03 16:21:28.000000000","message":"Building of container should be done in airship/images repository, not here. This airship/airshipctl repository should only consume ready made image from quay.io.","commit_id":"638814d171e8ffaf7c9027415f2b0c389a169bf1"}],"tools/deployment/bootstrap/01_install_kubectl.sh":[{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"c0db75befaa23226802df8daefc06fc17efe123e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":66,"id":"9f560f44_df94148f","updated":"2020-09-18 09:00:19.000000000","message":"We already have script with the same functionality in tools/deployment","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":66,"id":"9f560f44_af25ad0c","in_reply_to":"9f560f44_df94148f","updated":"2020-09-18 15:02:18.000000000","message":"Reusing the script shell from deployment/ folder","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"}],"tools/deployment/bootstrap/02_install_go.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0fa7f584ffbe79ee204a87b50b56379ca62e4c7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":69,"id":"9f560f44_a7b15147","updated":"2020-09-18 18:04:36.000000000","message":"Duplication","commit_id":"bfc4e6e05df63f8eb28b957d21c9f3d0a34c1b5f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"cfb2a3b21a8703f64ffb4148b5a31d6c4de01c2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":69,"id":"9f560f44_674e19c3","in_reply_to":"9f560f44_a7b15147","updated":"2020-09-18 18:31:46.000000000","message":"This file is not a duplication. It has been moved under tools/deployment/bootstrap from tools/deployment/azure to address a review comment.","commit_id":"bfc4e6e05df63f8eb28b957d21c9f3d0a34c1b5f"}],"tools/deployment/bootstrap/100_clean_up_resources.sh":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9fecf7fde3e253ea834ad09978f07fdd50c7259a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":80,"id":"9f560f44_a39d410a","updated":"2020-09-25 21:53:17.000000000","message":"Is there a use case where we would want to create/delete clusters using multiple providers at the same time? It could really simplify things if we were able to generalize this script for both providers using environment variables.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"b9ba3008b6e88d419122a05475d3888833945d5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":80,"id":"9f560f44_1a4c399c","in_reply_to":"9f560f44_a39d410a","updated":"2020-09-28 15:31:21.000000000","message":"It could be done for the local test but would create more overhead using environment variables in Zuul job.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9fecf7fde3e253ea834ad09978f07fdd50c7259a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"echo \"Deleting Ephemeral Cluster on Google Cloud platform...\""},{"line_number":28,"context_line":"airshipctl bootstrap ephemeral \\"},{"line_number":29,"context_line":"  --command delete \\"},{"line_number":30,"context_line":"  --container gcp-zull-bootstrap \\"},{"line_number":31,"context_line":"  --config gcp-config.yaml \\"},{"line_number":32,"context_line":"  --image $CAPG_DOCKER_IMAGE"}],"source_content_type":"text/x-sh","patch_set":80,"id":"9f560f44_23f49154","line":30,"range":{"start_line":30,"start_character":14,"end_line":30,"end_character":32},"updated":"2020-09-25 21:53:17.000000000","message":"Where is this container ID coming from?","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"b9ba3008b6e88d419122a05475d3888833945d5a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"echo \"Deleting Ephemeral Cluster on Google Cloud platform...\""},{"line_number":28,"context_line":"airshipctl bootstrap ephemeral \\"},{"line_number":29,"context_line":"  --command delete \\"},{"line_number":30,"context_line":"  --container gcp-zull-bootstrap \\"},{"line_number":31,"context_line":"  --config gcp-config.yaml \\"},{"line_number":32,"context_line":"  --image $CAPG_DOCKER_IMAGE"}],"source_content_type":"text/x-sh","patch_set":80,"id":"9f560f44_7a7e15e4","line":30,"range":{"start_line":30,"start_character":14,"end_line":30,"end_character":32},"in_reply_to":"9f560f44_23f49154","updated":"2020-09-28 15:31:21.000000000","message":"This is an arbitrary name that is chosen by the user. It is the name that will be assigned to the Docker container, instead of letting Docker chose the name.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"}],"tools/deployment/bootstrap/200_configure_test_vm.sh":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9fecf7fde3e253ea834ad09978f07fdd50c7259a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    echo \"--- Local Airship Dir \u003d $2\""},{"line_number":24,"context_line":"    echo \"--- Credentials Script \u003d $3\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    export REMOTE_VM\u003d$1"},{"line_number":27,"context_line":"    export LOCAL_AIRSHIP_DIR\u003d$2"},{"line_number":28,"context_line":"    export CREDENTIALS\u003d$3"},{"line_number":29,"context_line":"else"},{"line_number":30,"context_line":"    echo \"Syntax: 200_configure-remote-vm.sh \u003cRemote VM Username\u003e \u003cRemote VM IP\u003e \u003cLocal Airship Dir\u003e\""},{"line_number":31,"context_line":"    echo \"    \u003cRemote VM Username\u003e: Username@VM_IP to login to the Remote VM\""}],"source_content_type":"text/x-sh","patch_set":80,"id":"9f560f44_238931c6","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":25},"updated":"2020-09-25 21:53:17.000000000","message":"What is the format for these arguments?\n\nnit: we typically parameterize our scripts through env variables rather than positional arguments, as positional arguments can be difficult to follow.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"b9ba3008b6e88d419122a05475d3888833945d5a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    echo \"--- Local Airship Dir \u003d $2\""},{"line_number":24,"context_line":"    echo \"--- Credentials Script \u003d $3\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    export REMOTE_VM\u003d$1"},{"line_number":27,"context_line":"    export LOCAL_AIRSHIP_DIR\u003d$2"},{"line_number":28,"context_line":"    export CREDENTIALS\u003d$3"},{"line_number":29,"context_line":"else"},{"line_number":30,"context_line":"    echo \"Syntax: 200_configure-remote-vm.sh \u003cRemote VM Username\u003e \u003cRemote VM IP\u003e \u003cLocal Airship Dir\u003e\""},{"line_number":31,"context_line":"    echo \"    \u003cRemote VM Username\u003e: Username@VM_IP to login to the Remote VM\""}],"source_content_type":"text/x-sh","patch_set":80,"id":"9f560f44_7da0cff4","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":25},"in_reply_to":"9f560f44_238931c6","updated":"2020-09-28 15:31:21.000000000","message":"The format of these arguments are provided below.\nThe choice of positional arguments instead environment variables was more convenience as it requires only one command, while environment variable would require to set it first then execute the command, e.g., changing VM IP address for new clean test.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"}],"tools/deployment/bootstrap/200_transfer_airshipctl.sh":[{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"c0db75befaa23226802df8daefc06fc17efe123e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":66,"id":"9f560f44_ff4c7840","updated":"2020-09-18 09:00:19.000000000","message":"why the script priority is the same 200?","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"111380c86436bc4741201fba3d101c79127148c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":66,"id":"9f560f44_2f935d02","in_reply_to":"9f560f44_ff4c7840","updated":"2020-09-18 15:02:18.000000000","message":"Renamed:\n- 200_transfer_airshipctl.sh to 201_transfer_airshipctl.sh\n- 201_zuul_local_test.sh to 202_zuul_local_test.sh","commit_id":"23f8748b3496b6260456d34b3ee2dedf647df17c"}],"tools/deployment/bootstrap/202_zuul_local_test.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0fa7f584ffbe79ee204a87b50b56379ca62e4c7d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# It goes through all gates for locally in the remote VM."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo \"----- Using default airship directory\""},{"line_number":19,"context_line":"export AIRSHIPDIR\u003d\"/home/zuul/src/opendev.org/airship/airshipctl\""},{"line_number":20,"context_line":"export AIRSHIPCTL_WS\u003d\"/home/zuul/src/opendev.org/airship/airshipctl\""},{"line_number":21,"context_line":"export PATH\u003d$PATH:/usr/local/go/bin/"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Setting Public Cloud Credentials as Environment Variables"}],"source_content_type":"text/x-sh","patch_set":69,"id":"9f560f44_27dee13d","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":68},"updated":"2020-09-18 18:04:36.000000000","message":"Is it possible to replace hardcoded values by variables? Something like https://zuul-ci.org/docs/zuul/reference/jobs.html#id1","commit_id":"bfc4e6e05df63f8eb28b957d21c9f3d0a34c1b5f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4298abc5874dd98ae8931f1ecc2eaaf39699980d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# It goes through all gates for locally in the remote VM."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo \"----- Using default airship directory\""},{"line_number":19,"context_line":"export AIRSHIPDIR\u003d\"/home/zuul/src/opendev.org/airship/airshipctl\""},{"line_number":20,"context_line":"export AIRSHIPCTL_WS\u003d\"/home/zuul/src/opendev.org/airship/airshipctl\""},{"line_number":21,"context_line":"export PATH\u003d$PATH:/usr/local/go/bin/"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Setting Public Cloud Credentials as Environment Variables"}],"source_content_type":"text/x-sh","patch_set":69,"id":"9f560f44_58077019","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":68},"in_reply_to":"9f560f44_1a85f007","updated":"2020-09-18 20:24:51.000000000","message":"The local test is executed on a brand new VM to simulate Zuul.\nIt is triggered through 200_configure_test_vm.sh, which remotely connects to the test VM (e.g., Azure VM) and invokes 201_transfer_airshipctl.sh, which \"clones\" the airshipctl local repository on the VM. This is when the /home/zuul/src/opendev.org/airship/airshipctl folder is created in the remote test VM. \nOnce, this is completed, the 202_zuul_local_test.sh is invoked.","commit_id":"bfc4e6e05df63f8eb28b957d21c9f3d0a34c1b5f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"cfb2a3b21a8703f64ffb4148b5a31d6c4de01c2e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# It goes through all gates for locally in the remote VM."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo \"----- Using default airship directory\""},{"line_number":19,"context_line":"export AIRSHIPDIR\u003d\"/home/zuul/src/opendev.org/airship/airshipctl\""},{"line_number":20,"context_line":"export AIRSHIPCTL_WS\u003d\"/home/zuul/src/opendev.org/airship/airshipctl\""},{"line_number":21,"context_line":"export PATH\u003d$PATH:/usr/local/go/bin/"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Setting Public Cloud Credentials as Environment Variables"}],"source_content_type":"text/x-sh","patch_set":69,"id":"9f560f44_c71f25b5","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":68},"in_reply_to":"9f560f44_27dee13d","updated":"2020-09-18 18:31:46.000000000","message":"The script 20x_\u003cscript name\u003e.sh are not invoked by Zuul but used for end-to-end local test.\n\nAlso, removed env var \"AIRSHIPDIR\" as it was not used.","commit_id":"bfc4e6e05df63f8eb28b957d21c9f3d0a34c1b5f"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"06828dd71db4a06d80abcc2033194bcba7d80558","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# It goes through all gates for locally in the remote VM."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo \"----- Using default airship directory\""},{"line_number":19,"context_line":"export AIRSHIPDIR\u003d\"/home/zuul/src/opendev.org/airship/airshipctl\""},{"line_number":20,"context_line":"export AIRSHIPCTL_WS\u003d\"/home/zuul/src/opendev.org/airship/airshipctl\""},{"line_number":21,"context_line":"export PATH\u003d$PATH:/usr/local/go/bin/"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Setting Public Cloud Credentials as Environment Variables"}],"source_content_type":"text/x-sh","patch_set":69,"id":"9f560f44_78f194de","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":68},"in_reply_to":"9f560f44_58077019","updated":"2020-09-18 20:39:06.000000000","message":"Thank you for explanation.","commit_id":"bfc4e6e05df63f8eb28b957d21c9f3d0a34c1b5f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"01d35a86d7cc8a829c4826ca74623f9823f5c379","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# It goes through all gates for locally in the remote VM."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo \"----- Using default airship directory\""},{"line_number":19,"context_line":"export AIRSHIPDIR\u003d\"/home/zuul/src/opendev.org/airship/airshipctl\""},{"line_number":20,"context_line":"export AIRSHIPCTL_WS\u003d\"/home/zuul/src/opendev.org/airship/airshipctl\""},{"line_number":21,"context_line":"export PATH\u003d$PATH:/usr/local/go/bin/"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Setting Public Cloud Credentials as Environment Variables"}],"source_content_type":"text/x-sh","patch_set":69,"id":"9f560f44_fad0fc2d","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":68},"in_reply_to":"9f560f44_67061924","updated":"2020-09-18 18:59:03.000000000","message":"As you might have noticed, some scripts are commented out in zuul.d/jobs.yaml as they cannot be invoked by zuul unless exposing public Cloud credentials in Gerrit.\n\nThe script 202_zuul_local_test.sh is used to test the end-to-end sequence of scripts locally simulating the sequence of scripts that should\u0027ve been invoked by zuul.","commit_id":"bfc4e6e05df63f8eb28b957d21c9f3d0a34c1b5f"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0179b46edb7ef2c0fa57a46e76362bc813deb86f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# It goes through all gates for locally in the remote VM."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo \"----- Using default airship directory\""},{"line_number":19,"context_line":"export AIRSHIPDIR\u003d\"/home/zuul/src/opendev.org/airship/airshipctl\""},{"line_number":20,"context_line":"export AIRSHIPCTL_WS\u003d\"/home/zuul/src/opendev.org/airship/airshipctl\""},{"line_number":21,"context_line":"export PATH\u003d$PATH:/usr/local/go/bin/"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Setting Public Cloud Credentials as Environment Variables"}],"source_content_type":"text/x-sh","patch_set":69,"id":"9f560f44_67061924","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":68},"in_reply_to":"9f560f44_c71f25b5","updated":"2020-09-18 18:41:04.000000000","message":"I don\u0027t understand it. If it\u0027s not for zuul why it is using zuul directory and has \u0027zuul\u0027 in the name? If it\u0027s for local testing then it should use local directory provided by user.","commit_id":"bfc4e6e05df63f8eb28b957d21c9f3d0a34c1b5f"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"bd759488c300b340399435655f2c186e9df5aa5e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# It goes through all gates for locally in the remote VM."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo \"----- Using default airship directory\""},{"line_number":19,"context_line":"export AIRSHIPDIR\u003d\"/home/zuul/src/opendev.org/airship/airshipctl\""},{"line_number":20,"context_line":"export AIRSHIPCTL_WS\u003d\"/home/zuul/src/opendev.org/airship/airshipctl\""},{"line_number":21,"context_line":"export PATH\u003d$PATH:/usr/local/go/bin/"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Setting Public Cloud Credentials as Environment Variables"}],"source_content_type":"text/x-sh","patch_set":69,"id":"9f560f44_1a85f007","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":68},"in_reply_to":"9f560f44_fad0fc2d","updated":"2020-09-18 19:01:20.000000000","message":"Who is responsible to create /home/zuul/src/opendev.org/airship/airshipctl ?","commit_id":"bfc4e6e05df63f8eb28b957d21c9f3d0a34c1b5f"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"432d9eaf9ab5db0528e4e13af92312832b435f57","unresolved":false,"context_lines":[{"line_number":43,"context_line":"export CAPG_IMAGE_TAG\u003d\"latest\""},{"line_number":44,"context_line":"export CAPG_DOCKER_IMAGE\u003d$DOCKER_REGISTRY/$DOCKER_IMAGE_REPO/$CAPG_IMAGE_NAME:$CAPG_IMAGE_TAG"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Installation of Kubectl"},{"line_number":47,"context_line":"echo \"************************************************************************\""},{"line_number":48,"context_line":"echo \"***** Installation of Kubectl ...\""},{"line_number":49,"context_line":"./tools/deployment/01_install_kubectl.sh"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_30406c35","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":25},"updated":"2020-09-24 22:16:18.000000000","message":"No need to duplicate messages you already have in echo command below.","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4e6d7c120fa25141c33af82b048735003227a8bf","unresolved":false,"context_lines":[{"line_number":43,"context_line":"export CAPG_IMAGE_TAG\u003d\"latest\""},{"line_number":44,"context_line":"export CAPG_DOCKER_IMAGE\u003d$DOCKER_REGISTRY/$DOCKER_IMAGE_REPO/$CAPG_IMAGE_NAME:$CAPG_IMAGE_TAG"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Installation of Kubectl"},{"line_number":47,"context_line":"echo \"************************************************************************\""},{"line_number":48,"context_line":"echo \"***** Installation of Kubectl ...\""},{"line_number":49,"context_line":"./tools/deployment/01_install_kubectl.sh"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_7b3125ed","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":25},"in_reply_to":"9f560f44_30406c35","updated":"2020-09-24 23:26:35.000000000","message":"Done","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"432d9eaf9ab5db0528e4e13af92312832b435f57","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    exit 1"},{"line_number":53,"context_line":"fi"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Building airshipctl command"},{"line_number":56,"context_line":"echo \"************************************************************************\""},{"line_number":57,"context_line":"echo \"***** Building airshipctl command ...\""},{"line_number":58,"context_line":"./tools/deployment/21_systemwide_executable.sh"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_103ba8c7","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":29},"updated":"2020-09-24 22:16:18.000000000","message":"same","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4e6d7c120fa25141c33af82b048735003227a8bf","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    exit 1"},{"line_number":53,"context_line":"fi"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Building airshipctl command"},{"line_number":56,"context_line":"echo \"************************************************************************\""},{"line_number":57,"context_line":"echo \"***** Building airshipctl command ...\""},{"line_number":58,"context_line":"./tools/deployment/21_systemwide_executable.sh"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_5b2c2192","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":29},"in_reply_to":"9f560f44_103ba8c7","updated":"2020-09-24 23:26:35.000000000","message":"Done","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"432d9eaf9ab5db0528e4e13af92312832b435f57","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    exit 1"},{"line_number":62,"context_line":"fi"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# Creating Airship config file"},{"line_number":65,"context_line":"echo \"************************************************************************\""},{"line_number":66,"context_line":"echo \"***** Creating Airship config file ...\""},{"line_number":67,"context_line":"./tools/deployment/bootstrap/31_create_configs.sh"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_9078588f","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":30},"updated":"2020-09-24 22:16:18.000000000","message":"same","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4e6d7c120fa25141c33af82b048735003227a8bf","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    exit 1"},{"line_number":62,"context_line":"fi"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# Creating Airship config file"},{"line_number":65,"context_line":"echo \"************************************************************************\""},{"line_number":66,"context_line":"echo \"***** Creating Airship config file ...\""},{"line_number":67,"context_line":"./tools/deployment/bootstrap/31_create_configs.sh"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_bb4c5d76","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":30},"in_reply_to":"9f560f44_9078588f","updated":"2020-09-24 23:26:35.000000000","message":"Done","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"432d9eaf9ab5db0528e4e13af92312832b435f57","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    exit 1"},{"line_number":71,"context_line":"fi"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Creating Bootstrap Container config files"},{"line_number":74,"context_line":"echo \"************************************************************************\""},{"line_number":75,"context_line":"echo \"***** Creating Bootstrap Container config files ...\""},{"line_number":76,"context_line":"./tools/deployment/bootstrap/32_create_bootstrap_configs.sh"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_f06b94b5","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":43},"updated":"2020-09-24 22:16:18.000000000","message":"same","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4e6d7c120fa25141c33af82b048735003227a8bf","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    exit 1"},{"line_number":71,"context_line":"fi"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Creating Bootstrap Container config files"},{"line_number":74,"context_line":"echo \"************************************************************************\""},{"line_number":75,"context_line":"echo \"***** Creating Bootstrap Container config files ...\""},{"line_number":76,"context_line":"./tools/deployment/bootstrap/32_create_bootstrap_configs.sh"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_9b4fd968","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":43},"in_reply_to":"9f560f44_f06b94b5","updated":"2020-09-24 23:26:35.000000000","message":"Done","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"432d9eaf9ab5db0528e4e13af92312832b435f57","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    exit 1"},{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# Deploying Ephemeral Cluster using Azure Bootstrap Container"},{"line_number":83,"context_line":"echo \"************************************************************************\""},{"line_number":84,"context_line":"echo \"***** Deploying Ephemeral cluster in Azure with Bootstrap Container ...\""},{"line_number":85,"context_line":"./tools/deployment/bootstrap/41_deploy_azure_ephemeral_cluster.sh"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_30698cbd","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":61},"updated":"2020-09-24 22:16:18.000000000","message":"same","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4e6d7c120fa25141c33af82b048735003227a8bf","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    exit 1"},{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# Deploying Ephemeral Cluster using Azure Bootstrap Container"},{"line_number":83,"context_line":"echo \"************************************************************************\""},{"line_number":84,"context_line":"echo \"***** Deploying Ephemeral cluster in Azure with Bootstrap Container ...\""},{"line_number":85,"context_line":"./tools/deployment/bootstrap/41_deploy_azure_ephemeral_cluster.sh"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_3b404d35","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":61},"in_reply_to":"9f560f44_30698cbd","updated":"2020-09-24 23:26:35.000000000","message":"Done","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"432d9eaf9ab5db0528e4e13af92312832b435f57","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    exit 1"},{"line_number":89,"context_line":"fi"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# Deploying Ephemeral Cluster using Azure Bootstrap Container"},{"line_number":92,"context_line":"echo \"************************************************************************\""},{"line_number":93,"context_line":"echo \"***** Deploying Ephemeral cluster in Google Cloud with Bootstrap Container ...\""},{"line_number":94,"context_line":"./tools/deployment/bootstrap/41_deploy_gcp_ephemeral_cluster.sh"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_106448e4","line":91,"range":{"start_line":91,"start_character":0,"end_line":91,"end_character":61},"updated":"2020-09-24 22:16:18.000000000","message":"same","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4e6d7c120fa25141c33af82b048735003227a8bf","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    exit 1"},{"line_number":89,"context_line":"fi"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# Deploying Ephemeral Cluster using Azure Bootstrap Container"},{"line_number":92,"context_line":"echo \"************************************************************************\""},{"line_number":93,"context_line":"echo \"***** Deploying Ephemeral cluster in Google Cloud with Bootstrap Container ...\""},{"line_number":94,"context_line":"./tools/deployment/bootstrap/41_deploy_gcp_ephemeral_cluster.sh"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_1b3bc9c7","line":91,"range":{"start_line":91,"start_character":0,"end_line":91,"end_character":61},"in_reply_to":"9f560f44_106448e4","updated":"2020-09-24 23:26:35.000000000","message":"Done","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"432d9eaf9ab5db0528e4e13af92312832b435f57","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    exit 1"},{"line_number":98,"context_line":"fi"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# Cleaning up Resources"},{"line_number":101,"context_line":"echo \"************************************************************************\""},{"line_number":102,"context_line":"echo \"***** Cleaning up resources ...\""},{"line_number":103,"context_line":"./tools/deployment/bootstrap/100_clean_up_resources.sh"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_705f840e","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":23},"updated":"2020-09-24 22:16:18.000000000","message":"same","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4e6d7c120fa25141c33af82b048735003227a8bf","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    exit 1"},{"line_number":98,"context_line":"fi"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# Cleaning up Resources"},{"line_number":101,"context_line":"echo \"************************************************************************\""},{"line_number":102,"context_line":"echo \"***** Cleaning up resources ...\""},{"line_number":103,"context_line":"./tools/deployment/bootstrap/100_clean_up_resources.sh"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_5b41c135","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":23},"in_reply_to":"9f560f44_705f840e","updated":"2020-09-24 23:26:35.000000000","message":"Done","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9fecf7fde3e253ea834ad09978f07fdd50c7259a","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# docker image options"},{"line_number":35,"context_line":"export DOCKER_REGISTRY\u003d\"quay.io\""},{"line_number":36,"context_line":"export DOCKER_IMAGE_REPO\u003d\"sshiba\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"export CAPZ_IMAGE_NAME\u003d\"capz-bootstrap\""},{"line_number":39,"context_line":"export CAPZ_IMAGE_TAG\u003d\"latest\""}],"source_content_type":"text/x-sh","patch_set":80,"id":"9f560f44_83bd9d69","line":36,"range":{"start_line":36,"start_character":26,"end_line":36,"end_character":32},"updated":"2020-09-25 21:53:17.000000000","message":"airshipit","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"b9ba3008b6e88d419122a05475d3888833945d5a","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# docker image options"},{"line_number":35,"context_line":"export DOCKER_REGISTRY\u003d\"quay.io\""},{"line_number":36,"context_line":"export DOCKER_IMAGE_REPO\u003d\"sshiba\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"export CAPZ_IMAGE_NAME\u003d\"capz-bootstrap\""},{"line_number":39,"context_line":"export CAPZ_IMAGE_TAG\u003d\"latest\""}],"source_content_type":"text/x-sh","patch_set":80,"id":"9f560f44_1dd2735c","line":36,"range":{"start_line":36,"start_character":26,"end_line":36,"end_character":32},"in_reply_to":"9f560f44_83bd9d69","updated":"2020-09-28 15:31:21.000000000","message":"This needs to stay until the project airship/image for Azure and GCP are merged and images are pushed to airshipit repository.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"}],"tools/deployment/bootstrap/21_systemwide_executable.sh":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4a9d7b481286ccfafc27166c38ec31d1daaf0d9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"9f560f44_763cd7be","updated":"2020-09-22 17:16:01.000000000","message":"If the original script changes, this one probably should too. Please symlink to the existing script rather than copying it in order to reduce technical debt.","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"dd2be439836ccb79788ee0d5d1fdc14bbae4cff2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"9f560f44_432632bc","in_reply_to":"9f560f44_763cd7be","updated":"2020-09-22 22:00:05.000000000","message":"updated to reuse tools/deployment/21_systemwide_executable.sh.\nAlso deleted go and kustomize installation scripts, that were not needed.","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"}],"tools/deployment/bootstrap/31_create_configs.sh":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4a9d7b481286ccfafc27166c38ec31d1daaf0d9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"9f560f44_f6790793","updated":"2020-09-22 17:16:01.000000000","message":"The original script supports parameterization using environment variables. Please invoke the existing script with the new environment variable overrides rather than copying it in order to reduce technical debt.","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"dd2be439836ccb79788ee0d5d1fdc14bbae4cff2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"9f560f44_a392ae9d","in_reply_to":"9f560f44_f6790793","updated":"2020-09-22 22:00:05.000000000","message":"This script has its merit as it uses its own template (azure_airshipconfig_template).\n\nMoreover it requires a dummy kubeconfig because a this stage the management cluster has not been created yet. It is the case for the airshipctl bootstrap command that is responsible for spinning a K8S cluster.","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"432d9eaf9ab5db0528e4e13af92312832b435f57","unresolved":false,"context_lines":[{"line_number":74,"context_line":"      client-certificate-data: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUM4akNDQWRxZ0F3SUJBZ0lJQXhEdzk2RUY4SXN3RFFZSktvWklodmNOQVFFTEJRQXdGVEVUTUJFR0ExVUUKQXhNS2EzVmlaWEp1WlhSbGN6QWVGdzB4T1RBNU1qa3hOekF6TURsYUZ3MHlNREE1TWpneE56QXpNVEphTURReApGekFWQmdOVkJBb1REbk41YzNSbGJUcHRZWE4wWlhKek1Sa3dGd1lEVlFRREV4QnJkV0psY201bGRHVnpMV0ZrCmJXbHVNSUlCSWpBTkJna3Foa2lHOXcwQkFRRUZBQU9DQVE4QU1JSUJDZ0tDQVFFQXV6R0pZdlBaNkRvaTQyMUQKSzhXSmFaQ25OQWQycXo1cC8wNDJvRnpRUGJyQWd6RTJxWVZrek9MOHhBVmVSN1NONXdXb1RXRXlGOEVWN3JyLwo0K0hoSEdpcTVQbXF1SUZ5enpuNi9JWmM4alU5eEVmenZpa2NpckxmVTR2UlhKUXdWd2dBU05sMkFXQUloMmRECmRUcmpCQ2ZpS1dNSHlqMFJiSGFsc0J6T3BnVC9IVHYzR1F6blVRekZLdjJkajVWMU5rUy9ESGp5UlJKK0VMNlEKQlltR3NlZzVQNE5iQzllYnVpcG1NVEFxL0p1bU9vb2QrRmpMMm5acUw2Zkk2ZkJ0RjVPR2xwQ0IxWUo4ZnpDdApHUVFaN0hUSWJkYjJ0cDQzRlZPaHlRYlZjSHFUQTA0UEoxNSswV0F5bVVKVXo4WEE1NDRyL2J2NzRKY0pVUkZoCmFyWmlRd0lEQVFBQm95Y3dKVEFPQmdOVkhROEJBZjhFQkFNQ0JhQXdFd1lEVlIwbEJBd3dDZ1lJS3dZQkJRVUgKQXdJd0RRWUpLb1pJaHZjTkFRRUxCUUFEZ2dFQkFMMmhIUmVibEl2VHJTMFNmUVg1RG9ueVVhNy84aTg1endVWApSd3dqdzFuS0U0NDJKbWZWRGZ5b0hRYUM4Ti9MQkxyUXM0U0lqU1JYdmFHU1dSQnRnT1RRV21Db1laMXdSbjdwCndDTXZQTERJdHNWWm90SEZpUFl2b1lHWFFUSXA3YlROMmg1OEJaaEZ3d25nWUovT04zeG1rd29IN1IxYmVxWEYKWHF1TTluekhESk41VlZub1lQR09yRHMwWlg1RnNxNGtWVU0wVExNQm9qN1ZIRDhmU0E5RjRYNU4yMldsZnNPMAo4aksrRFJDWTAyaHBrYTZQQ0pQS0lNOEJaMUFSMG9ZakZxT0plcXpPTjBqcnpYWHh4S2pHVFVUb1BldVA5dCtCCjJOMVA1TnI4a2oxM0lrend5Q1NZclFVN09ZM3ltZmJobHkrcXZxaFVFa014MlQ1SkpmQT0KLS0tLS1FTkQgQ0VSVElGSUNBVEUtLS0tLQo\u003d"},{"line_number":75,"context_line":"      client-key-data: LS0tLS1CRUdJTiBSU0EgUFJJVkFURSBLRVktLS0tLQpNSUlFcFFJQkFBS0NBUUVBdXpHSll2UFo2RG9pNDIxREs4V0phWkNuTkFkMnF6NXAvMDQyb0Z6UVBickFnekUyCnFZVmt6T0w4eEFWZVI3U041d1dvVFdFeUY4RVY3cnIvNCtIaEhHaXE1UG1xdUlGeXp6bjYvSVpjOGpVOXhFZnoKdmlrY2lyTGZVNHZSWEpRd1Z3Z0FTTmwyQVdBSWgyZERkVHJqQkNmaUtXTUh5ajBSYkhhbHNCek9wZ1QvSFR2MwpHUXpuVVF6Rkt2MmRqNVYxTmtTL0RIanlSUkorRUw2UUJZbUdzZWc1UDROYkM5ZWJ1aXBtTVRBcS9KdW1Pb29kCitGakwyblpxTDZmSTZmQnRGNU9HbHBDQjFZSjhmekN0R1FRWjdIVEliZGIydHA0M0ZWT2h5UWJWY0hxVEEwNFAKSjE1KzBXQXltVUpVejhYQTU0NHIvYnY3NEpjSlVSRmhhclppUXdJREFRQUJBb0lCQVFDU0pycjlaeVpiQ2dqegpSL3VKMFZEWCt2aVF4c01BTUZyUjJsOE1GV3NBeHk1SFA4Vk4xYmc5djN0YUVGYnI1U3hsa3lVMFJRNjNQU25DCm1uM3ZqZ3dVQWlScllnTEl5MGk0UXF5VFBOU1V4cnpTNHRxTFBjM3EvSDBnM2FrNGZ2cSsrS0JBUUlqQnloamUKbnVFc1JpMjRzT3NESlM2UDE5NGlzUC9yNEpIM1M5bFZGbkVuOGxUR2c0M1kvMFZoMXl0cnkvdDljWjR5ZUNpNwpjMHFEaTZZcXJZaFZhSW9RRW1VQjdsbHRFZkZzb3l4VDR6RTE5U3pVbkRoMmxjYTF1TzhqcmI4d2xHTzBoQ2JyClB1R1l2WFFQa3Q0VlNmalhvdGJ3d2lBNFRCVERCRzU1bHp6MmNKeS9zSS8zSHlYbEMxcTdXUmRuQVhhZ1F0VzkKOE9DZGRkb0JBb0dCQU5NcUNtSW94REtyckhZZFRxT1M1ZFN4cVMxL0NUN3ZYZ0pScXBqd2Y4WHA2WHo0KzIvTAozVXFaVDBEL3dGTkZkc1Z4eFYxMnNYMUdwMHFWZVlKRld5OVlCaHVSWGpTZ0ZEWldSY1Z1Y01sNVpPTmJsbmZGCjVKQ0xnNXFMZ1g5VTNSRnJrR3A0R241UDQxamg4TnhKVlhzZG5xWE9xNTFUK1RRT1UzdkpGQjc1QW9HQkFPTHcKalp1cnZtVkZyTHdaVGgvRDNpWll5SVV0ZUljZ2NKLzlzbTh6L0pPRmRIbFd4dGRHUFVzYVd1MnBTNEhvckFtbgpqTm4vSTluUXd3enZ3MWUzVVFPbUhMRjVBczk4VU5hbk5TQ0xNMW1yaXZHRXJ1VHFnTDM1bU41eFZPdTUxQU5JCm4yNkFtODBJT2JDeEtLa0R0ZXJSaFhHd3g5c1pONVJCbG9VRThZNGJBb0dBQ3ZsdVhMZWRxcng5VkE0bDNoNXUKVDJXRVUxYjgxZ1orcmtRc1I1S0lNWEw4cllBTElUNUpHKzFuendyN3BkaEFXZmFWdVV2SDRhamdYT0h6MUs5aQpFODNSVTNGMG9ldUg0V01PY1RwU0prWm0xZUlXcWRiaEVCb1FGdUlWTXRib1BsV0d4ZUhFRHJoOEtreGp4aThSCmdEcUQyajRwY1IzQ0g5QjJ5a0lqQjVFQ2dZRUExc0xXLys2enE1c1lNSm14K1JXZThhTXJmL3pjQnVTSU1LQWgKY0dNK0wwMG9RSHdDaUU4TVNqcVN1ajV3R214YUFuanhMb3ZwSFlRV1VmUEVaUW95UE1YQ2VhRVBLOU4xbk8xMwp0V2lHRytIZkIxaU5PazFCc0lhNFNDbndOM1FRVTFzeXBaeEgxT3hueS9LYmkvYmEvWEZ5VzNqMGFUK2YvVWxrCmJGV1ZVdWtDZ1lFQTBaMmRTTFlmTjV5eFNtYk5xMWVqZXdWd1BjRzQxR2hQclNUZEJxdHFac1doWGE3aDdLTWEKeHdvamh5SXpnTXNyK2tXODdlajhDQ2h0d21sQ1p5QU92QmdOZytncnJ1cEZLM3FOSkpKeU9YREdHckdpbzZmTQp5aXB3Q2tZVGVxRThpZ1J6UkI5QkdFUGY4eVpjMUtwdmZhUDVhM0lRZmxiV0czbGpUemNNZVZjPQotLS0tLUVORCBSU0EgUFJJVkFURSBLRVktLS0tLQo\u003d"},{"line_number":76,"context_line":"\" \u003e $HOME/.airship/kubeconfig"},{"line_number":77,"context_line":"# cp -rp ~/.kube/config ~/.airship/kubeconfig"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"echo \"Generate ~/.airship/config\""},{"line_number":80,"context_line":"envsubst \u003c\"${AIRSHIPCTL_WS}/tools/deployment/templates/azure_airshipconfig_template\" \u003e $HOME/.airship/config"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_505a401d","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":45},"updated":"2020-09-24 22:16:18.000000000","message":"Please, remove unused code.","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4e6d7c120fa25141c33af82b048735003227a8bf","unresolved":false,"context_lines":[{"line_number":74,"context_line":"      client-certificate-data: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUM4akNDQWRxZ0F3SUJBZ0lJQXhEdzk2RUY4SXN3RFFZSktvWklodmNOQVFFTEJRQXdGVEVUTUJFR0ExVUUKQXhNS2EzVmlaWEp1WlhSbGN6QWVGdzB4T1RBNU1qa3hOekF6TURsYUZ3MHlNREE1TWpneE56QXpNVEphTURReApGekFWQmdOVkJBb1REbk41YzNSbGJUcHRZWE4wWlhKek1Sa3dGd1lEVlFRREV4QnJkV0psY201bGRHVnpMV0ZrCmJXbHVNSUlCSWpBTkJna3Foa2lHOXcwQkFRRUZBQU9DQVE4QU1JSUJDZ0tDQVFFQXV6R0pZdlBaNkRvaTQyMUQKSzhXSmFaQ25OQWQycXo1cC8wNDJvRnpRUGJyQWd6RTJxWVZrek9MOHhBVmVSN1NONXdXb1RXRXlGOEVWN3JyLwo0K0hoSEdpcTVQbXF1SUZ5enpuNi9JWmM4alU5eEVmenZpa2NpckxmVTR2UlhKUXdWd2dBU05sMkFXQUloMmRECmRUcmpCQ2ZpS1dNSHlqMFJiSGFsc0J6T3BnVC9IVHYzR1F6blVRekZLdjJkajVWMU5rUy9ESGp5UlJKK0VMNlEKQlltR3NlZzVQNE5iQzllYnVpcG1NVEFxL0p1bU9vb2QrRmpMMm5acUw2Zkk2ZkJ0RjVPR2xwQ0IxWUo4ZnpDdApHUVFaN0hUSWJkYjJ0cDQzRlZPaHlRYlZjSHFUQTA0UEoxNSswV0F5bVVKVXo4WEE1NDRyL2J2NzRKY0pVUkZoCmFyWmlRd0lEQVFBQm95Y3dKVEFPQmdOVkhROEJBZjhFQkFNQ0JhQXdFd1lEVlIwbEJBd3dDZ1lJS3dZQkJRVUgKQXdJd0RRWUpLb1pJaHZjTkFRRUxCUUFEZ2dFQkFMMmhIUmVibEl2VHJTMFNmUVg1RG9ueVVhNy84aTg1endVWApSd3dqdzFuS0U0NDJKbWZWRGZ5b0hRYUM4Ti9MQkxyUXM0U0lqU1JYdmFHU1dSQnRnT1RRV21Db1laMXdSbjdwCndDTXZQTERJdHNWWm90SEZpUFl2b1lHWFFUSXA3YlROMmg1OEJaaEZ3d25nWUovT04zeG1rd29IN1IxYmVxWEYKWHF1TTluekhESk41VlZub1lQR09yRHMwWlg1RnNxNGtWVU0wVExNQm9qN1ZIRDhmU0E5RjRYNU4yMldsZnNPMAo4aksrRFJDWTAyaHBrYTZQQ0pQS0lNOEJaMUFSMG9ZakZxT0plcXpPTjBqcnpYWHh4S2pHVFVUb1BldVA5dCtCCjJOMVA1TnI4a2oxM0lrend5Q1NZclFVN09ZM3ltZmJobHkrcXZxaFVFa014MlQ1SkpmQT0KLS0tLS1FTkQgQ0VSVElGSUNBVEUtLS0tLQo\u003d"},{"line_number":75,"context_line":"      client-key-data: LS0tLS1CRUdJTiBSU0EgUFJJVkFURSBLRVktLS0tLQpNSUlFcFFJQkFBS0NBUUVBdXpHSll2UFo2RG9pNDIxREs4V0phWkNuTkFkMnF6NXAvMDQyb0Z6UVBickFnekUyCnFZVmt6T0w4eEFWZVI3U041d1dvVFdFeUY4RVY3cnIvNCtIaEhHaXE1UG1xdUlGeXp6bjYvSVpjOGpVOXhFZnoKdmlrY2lyTGZVNHZSWEpRd1Z3Z0FTTmwyQVdBSWgyZERkVHJqQkNmaUtXTUh5ajBSYkhhbHNCek9wZ1QvSFR2MwpHUXpuVVF6Rkt2MmRqNVYxTmtTL0RIanlSUkorRUw2UUJZbUdzZWc1UDROYkM5ZWJ1aXBtTVRBcS9KdW1Pb29kCitGakwyblpxTDZmSTZmQnRGNU9HbHBDQjFZSjhmekN0R1FRWjdIVEliZGIydHA0M0ZWT2h5UWJWY0hxVEEwNFAKSjE1KzBXQXltVUpVejhYQTU0NHIvYnY3NEpjSlVSRmhhclppUXdJREFRQUJBb0lCQVFDU0pycjlaeVpiQ2dqegpSL3VKMFZEWCt2aVF4c01BTUZyUjJsOE1GV3NBeHk1SFA4Vk4xYmc5djN0YUVGYnI1U3hsa3lVMFJRNjNQU25DCm1uM3ZqZ3dVQWlScllnTEl5MGk0UXF5VFBOU1V4cnpTNHRxTFBjM3EvSDBnM2FrNGZ2cSsrS0JBUUlqQnloamUKbnVFc1JpMjRzT3NESlM2UDE5NGlzUC9yNEpIM1M5bFZGbkVuOGxUR2c0M1kvMFZoMXl0cnkvdDljWjR5ZUNpNwpjMHFEaTZZcXJZaFZhSW9RRW1VQjdsbHRFZkZzb3l4VDR6RTE5U3pVbkRoMmxjYTF1TzhqcmI4d2xHTzBoQ2JyClB1R1l2WFFQa3Q0VlNmalhvdGJ3d2lBNFRCVERCRzU1bHp6MmNKeS9zSS8zSHlYbEMxcTdXUmRuQVhhZ1F0VzkKOE9DZGRkb0JBb0dCQU5NcUNtSW94REtyckhZZFRxT1M1ZFN4cVMxL0NUN3ZYZ0pScXBqd2Y4WHA2WHo0KzIvTAozVXFaVDBEL3dGTkZkc1Z4eFYxMnNYMUdwMHFWZVlKRld5OVlCaHVSWGpTZ0ZEWldSY1Z1Y01sNVpPTmJsbmZGCjVKQ0xnNXFMZ1g5VTNSRnJrR3A0R241UDQxamg4TnhKVlhzZG5xWE9xNTFUK1RRT1UzdkpGQjc1QW9HQkFPTHcKalp1cnZtVkZyTHdaVGgvRDNpWll5SVV0ZUljZ2NKLzlzbTh6L0pPRmRIbFd4dGRHUFVzYVd1MnBTNEhvckFtbgpqTm4vSTluUXd3enZ3MWUzVVFPbUhMRjVBczk4VU5hbk5TQ0xNMW1yaXZHRXJ1VHFnTDM1bU41eFZPdTUxQU5JCm4yNkFtODBJT2JDeEtLa0R0ZXJSaFhHd3g5c1pONVJCbG9VRThZNGJBb0dBQ3ZsdVhMZWRxcng5VkE0bDNoNXUKVDJXRVUxYjgxZ1orcmtRc1I1S0lNWEw4cllBTElUNUpHKzFuendyN3BkaEFXZmFWdVV2SDRhamdYT0h6MUs5aQpFODNSVTNGMG9ldUg0V01PY1RwU0prWm0xZUlXcWRiaEVCb1FGdUlWTXRib1BsV0d4ZUhFRHJoOEtreGp4aThSCmdEcUQyajRwY1IzQ0g5QjJ5a0lqQjVFQ2dZRUExc0xXLys2enE1c1lNSm14K1JXZThhTXJmL3pjQnVTSU1LQWgKY0dNK0wwMG9RSHdDaUU4TVNqcVN1ajV3R214YUFuanhMb3ZwSFlRV1VmUEVaUW95UE1YQ2VhRVBLOU4xbk8xMwp0V2lHRytIZkIxaU5PazFCc0lhNFNDbndOM1FRVTFzeXBaeEgxT3hueS9LYmkvYmEvWEZ5VzNqMGFUK2YvVWxrCmJGV1ZVdWtDZ1lFQTBaMmRTTFlmTjV5eFNtYk5xMWVqZXdWd1BjRzQxR2hQclNUZEJxdHFac1doWGE3aDdLTWEKeHdvamh5SXpnTXNyK2tXODdlajhDQ2h0d21sQ1p5QU92QmdOZytncnJ1cEZLM3FOSkpKeU9YREdHckdpbzZmTQp5aXB3Q2tZVGVxRThpZ1J6UkI5QkdFUGY4eVpjMUtwdmZhUDVhM0lRZmxiV0czbGpUemNNZVZjPQotLS0tLUVORCBSU0EgUFJJVkFURSBLRVktLS0tLQo\u003d"},{"line_number":76,"context_line":"\" \u003e $HOME/.airship/kubeconfig"},{"line_number":77,"context_line":"# cp -rp ~/.kube/config ~/.airship/kubeconfig"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"echo \"Generate ~/.airship/config\""},{"line_number":80,"context_line":"envsubst \u003c\"${AIRSHIPCTL_WS}/tools/deployment/templates/azure_airshipconfig_template\" \u003e $HOME/.airship/config"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_bb757d9a","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":45},"in_reply_to":"9f560f44_505a401d","updated":"2020-09-24 23:26:35.000000000","message":"Done","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9fecf7fde3e253ea834ad09978f07fdd50c7259a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":80,"id":"9f560f44_63c049e1","updated":"2020-09-25 21:53:17.000000000","message":"Please reuse the existing config script [0] and extend when necessary.\n\n[0] https://github.com/airshipit/airshipctl/blob/master/tools/deployment/22_test_configs.sh","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"b9ba3008b6e88d419122a05475d3888833945d5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":80,"id":"9f560f44_1d60b3a4","in_reply_to":"9f560f44_63c049e1","updated":"2020-09-28 15:31:21.000000000","message":"This config script is very specific to the bootstrap, e.g., kubeconfig file does not exist yet when bootstrap command is invoked to create the management cluster.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"}],"tools/deployment/bootstrap/32_create_bootstrap_configs.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"432d9eaf9ab5db0528e4e13af92312832b435f57","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -xe"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"echo \"Generate ~/.airship/azure-config.yaml\""},{"line_number":18,"context_line":"envsubst \u003c\"${AIRSHIPCTL_WS}/tools/deployment/templates/azure-config.yaml\" \u003e $HOME/.airship/azure-config.yaml"},{"line_number":19,"context_line":"echo \"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\""},{"line_number":20,"context_line":"cat $HOME/.airship/azure-config.yaml"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_50afe0de","line":17,"range":{"start_line":17,"start_character":15,"end_line":17,"end_character":43},"updated":"2020-09-24 22:16:18.000000000","message":"If you really need an exact file path in the logs then make a var for that and use it in all places to eliminate code duplication.\nOr if you don\u0027t need an exact file path then just make one common message echoed in the top of the file to describe the common step here.","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4e6d7c120fa25141c33af82b048735003227a8bf","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -xe"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"echo \"Generate ~/.airship/azure-config.yaml\""},{"line_number":18,"context_line":"envsubst \u003c\"${AIRSHIPCTL_WS}/tools/deployment/templates/azure-config.yaml\" \u003e $HOME/.airship/azure-config.yaml"},{"line_number":19,"context_line":"echo \"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\""},{"line_number":20,"context_line":"cat $HOME/.airship/azure-config.yaml"}],"source_content_type":"text/x-sh","patch_set":79,"id":"9f560f44_7b8da57a","line":17,"range":{"start_line":17,"start_character":15,"end_line":17,"end_character":43},"in_reply_to":"9f560f44_50afe0de","updated":"2020-09-24 23:26:35.000000000","message":"created two environment variables to avoid code duplication","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"}],"tools/deployment/bootstrap/README.md":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4a9d7b481286ccfafc27166c38ec31d1daaf0d9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"9f560f44_169abbc3","updated":"2020-09-22 17:16:01.000000000","message":"Can we move this to our published documentation? Airshipctl users expect to find documentation at docs.airshipit.org/airshipctl. It will be overlooked here.","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"dd2be439836ccb79788ee0d5d1fdc14bbae4cff2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"9f560f44_4303d2be","in_reply_to":"9f560f44_169abbc3","updated":"2020-09-22 22:00:05.000000000","message":"This README.md describe the contents for this folder and use of each script, which can be helpful when trying to understand its purpose and help reviewing the them.","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"432d9eaf9ab5db0528e4e13af92312832b435f57","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Zuul Gate Scripts for Bootstrap Container/Ephemeral Cluster/Azure Target Cluster"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This folder container the Zuul Gate Scripts for configuring the tools necessary to"},{"line_number":4,"context_line":"automatically validate the building of Bootstrap Container (Go app + Docker Image),"},{"line_number":5,"context_line":"deployment of Ephemeral Cluster on Azure Cloud and Google Cloud, then using the"},{"line_number":6,"context_line":"Azure Ephemeral Cluster to deploy the Target Cluster on Azure Cloud."}],"source_content_type":"text/x-gfm","patch_set":79,"id":"9f560f44_90869864","line":3,"range":{"start_line":3,"start_character":12,"end_line":3,"end_character":21},"updated":"2020-09-24 22:16:18.000000000","message":"typo?","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4e6d7c120fa25141c33af82b048735003227a8bf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Zuul Gate Scripts for Bootstrap Container/Ephemeral Cluster/Azure Target Cluster"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This folder container the Zuul Gate Scripts for configuring the tools necessary to"},{"line_number":4,"context_line":"automatically validate the building of Bootstrap Container (Go app + Docker Image),"},{"line_number":5,"context_line":"deployment of Ephemeral Cluster on Azure Cloud and Google Cloud, then using the"},{"line_number":6,"context_line":"Azure Ephemeral Cluster to deploy the Target Cluster on Azure Cloud."}],"source_content_type":"text/x-gfm","patch_set":79,"id":"9f560f44_3bdccd72","line":3,"range":{"start_line":3,"start_character":12,"end_line":3,"end_character":21},"in_reply_to":"9f560f44_90869864","updated":"2020-09-24 23:26:35.000000000","message":"\"contains\" instead of \"container\". Fixed","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"}],"tools/deployment/templates/azure_airshipconfig_template":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"b39ed2da9cde0df1a042a54f737487b616811479","unresolved":false,"context_lines":[{"line_number":41,"context_line":"          tag: \"\""},{"line_number":42,"context_line":"#        url: ${AIRSHIP_CONFIG_PRIMARY_REPO_URL}"},{"line_number":43,"context_line":"#    subPath: ${AIRSHIP_SITE_NAME}"},{"line_number":44,"context_line":"#    targetPath: ${AIRSHIP_CONFIG_MANIFEST_DIRECTORY} "},{"line_number":45,"context_line":"        url: https://review.opendev.org/airship/airshipctl"},{"line_number":46,"context_line":"    subPath: airshipctl/manifests/site/az-test-site"},{"line_number":47,"context_line":"    targetPath: /home/zuul/src/opendev.org/airship"}],"source_content_type":"application/octet-stream","patch_set":41,"id":"bf51134e_9bc94827","line":44,"range":{"start_line":44,"start_character":53,"end_line":44,"end_character":54},"updated":"2020-07-20 19:18:33.000000000","message":"Trailing whitespace","commit_id":"c5ca0187d7ae086fab7d6cc2de0c10f0317330fd"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":34,"context_line":"          commitHash: \"\""},{"line_number":35,"context_line":"          force: false"},{"line_number":36,"context_line":"          tag: \"\""},{"line_number":37,"context_line":"#        url: ${AIRSHIP_CONFIG_PRIMARY_REPO_URL}"},{"line_number":38,"context_line":"#    subPath: ${AIRSHIP_SITE_NAME}"},{"line_number":39,"context_line":"#    targetPath: ${AIRSHIP_CONFIG_MANIFEST_DIRECTORY}"},{"line_number":40,"context_line":"        url: https://review.opendev.org/airship/airshipctl"},{"line_number":41,"context_line":"    subPath: manifests/site/az-test-site"},{"line_number":42,"context_line":"    targetPath: /home/zuul/src/opendev.org/airship/airshipctl"}],"source_content_type":"application/octet-stream","patch_set":51,"id":"9f560f44_6570bf09","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":53},"updated":"2020-09-04 17:14:27.000000000","message":"Why do we need these lines?","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"}],"tools/deployment/templates/gcp-config.yaml":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":51,"id":"9f560f44_e55def79","updated":"2020-09-04 17:14:27.000000000","message":"This commit is about Azure. Why do we need gcp scripts here?","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"}],"tools/deployment/templates/gcp-credentials.json":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":51,"id":"9f560f44_254fe7be","updated":"2020-09-04 17:14:27.000000000","message":"the same","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"56de7d6a6640ebd0e34c50676fdaf2cc91ebdf5d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        - ./tools/deployment/azure/21_systemwide_executable.sh"},{"line_number":96,"context_line":"        - ./tools/deployment/azure/31_create_configs.sh"},{"line_number":97,"context_line":"        - ./tools/deployment/azure/41_initialize_management_cluster.sh"},{"line_number":98,"context_line":"        # - ./tools/deployment/common/51_deploy_workload_cluster.sh"},{"line_number":99,"context_line":"      serve_dir: /srv/iso"},{"line_number":100,"context_line":"      serve_port: 8099"},{"line_number":101,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"bf51134e_a8fe4e68","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":67},"updated":"2020-07-22 23:26:05.000000000","message":"Why do we need this commented line? Please, put TODO with an explanation if still needed.","commit_id":"2397fe1f9d61975b4d654615b856bbbe71e096c4"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"1875385f70c9c0ffd921d27991985c496a397ea1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    pre-run: playbooks/airship-airshipctl-deploy-docker.yaml"},{"line_number":82,"context_line":"    post-run: playbooks/airship-collect-azure-logs.yaml"},{"line_number":83,"context_line":"    run: playbooks/airshipctl-gate-runner.yaml"},{"line_number":84,"context_line":"    nodeset: airship-airshipctl-single-32GB-bionic-node"},{"line_number":85,"context_line":"    vars:"},{"line_number":86,"context_line":"      site_name: azure-test-site"},{"line_number":87,"context_line":"      gate_scripts:"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"9f560f44_407a6d23","line":84,"range":{"start_line":84,"start_character":13,"end_line":84,"end_character":55},"updated":"2020-08-26 07:40:36.000000000","message":"Please, use \u0027airship-airshipctl-single-node\u0027 whenever possible. OpenDev CI unfortunately does not have enough compute resources to let this job run on every single push to Gerrit.\n\nHow much memory does this job consume? Could this job be split into a smaller tasks and be integrated into existing jobs, specifically into \u0027airship-airshipctl-gate-script-runner-test\u0027 job?","commit_id":"915de4c4b95582148c2248aef35adc53dbf44212"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"28f980ddadfb6eaae64d7af8bb32f121e4bd8beb","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    pre-run: playbooks/airship-airshipctl-deploy-docker.yaml"},{"line_number":82,"context_line":"    post-run: playbooks/airship-collect-azure-logs.yaml"},{"line_number":83,"context_line":"    run: playbooks/airshipctl-gate-runner.yaml"},{"line_number":84,"context_line":"    nodeset: airship-airshipctl-single-16GB-bionic-node"},{"line_number":85,"context_line":"    vars:"},{"line_number":86,"context_line":"      site_name: azure-test-site"},{"line_number":87,"context_line":"      gate_scripts:"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"9f560f44_4b038577","line":84,"range":{"start_line":84,"start_character":13,"end_line":84,"end_character":55},"updated":"2020-08-28 06:18:13.000000000","message":"Please, use \u0027airship-airshipctl-single-node\u0027 whenever possible. OpenDev CI unfortunately does not have enough compute resources to let this job run on every single push to Gerrit.\n\nHow much memory does this job consume? Could this job be split into a smaller tasks and be integrated into existing jobs, specifically into \u0027airship-airshipctl-gate-script-runner-test\u0027 job?","commit_id":"d8c1230a13fe0f1e66919e1e88c1e1dce8b64177"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"b83e43742559127ecf30ba83e24a5bc72b710a8d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    pre-run: playbooks/airship-airshipctl-deploy-docker.yaml"},{"line_number":82,"context_line":"    post-run: playbooks/airship-collect-azure-logs.yaml"},{"line_number":83,"context_line":"    run: playbooks/airshipctl-gate-runner.yaml"},{"line_number":84,"context_line":"    nodeset: airship-airshipctl-single-16GB-bionic-node"},{"line_number":85,"context_line":"    vars:"},{"line_number":86,"context_line":"      site_name: azure-test-site"},{"line_number":87,"context_line":"      gate_scripts:"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"9f560f44_47d7da50","line":84,"range":{"start_line":84,"start_character":13,"end_line":84,"end_character":55},"updated":"2020-08-31 10:12:50.000000000","message":"Please, use \u0027airship-airshipctl-single-node\u0027 here. Thank you.\nJob does not consume that much resources.","commit_id":"1c4106ae62abbdb5db609cf8e1c836e3404c6d53"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"0d823ed7a0a6654b6dac9cc4ba4c32c800700b91","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        - ./tools/deployment/azure/03_install_kustomize_docker.sh"},{"line_number":91,"context_line":"        - ./tools/deployment/azure/21_systemwide_executable.sh"},{"line_number":92,"context_line":"        - ./tools/deployment/azure/31_create_configs.sh"},{"line_number":93,"context_line":"        # The following script requires Azure and GCP credentials"},{"line_number":94,"context_line":"        # - ./tools/deployment/azure/41_deploy_azure_ephemeral_cluster.sh"},{"line_number":95,"context_line":"        # - ./tools/deployment/azure/41_deploy_gcp_ephemeral_cluster.sh"},{"line_number":96,"context_line":"        # - ./tools/deployment/azure/41_initialize_management_cluster.sh"},{"line_number":97,"context_line":"        # - ./tools/deployment/common/51_deploy_workload_cluster.sh"},{"line_number":98,"context_line":"        # - ./tools/deployment/azure/100_clean_up_resources.sh"},{"line_number":99,"context_line":"      serve_dir: /srv/iso"},{"line_number":100,"context_line":"      serve_port: 8099"},{"line_number":101,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"9f560f44_25d407bb","line":98,"range":{"start_line":93,"start_character":0,"end_line":98,"end_character":62},"updated":"2020-09-04 17:14:27.000000000","message":"Please, remove commented lines.","commit_id":"d433014c81decdea93aedda42f00f49eac3a13c2"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4a9d7b481286ccfafc27166c38ec31d1daaf0d9d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        - ./tools/deployment/bootstrap/03_install_kustomize.sh"},{"line_number":91,"context_line":"        - ./tools/deployment/bootstrap/21_systemwide_executable.sh"},{"line_number":92,"context_line":"        - ./tools/deployment/bootstrap/31_create_configs.sh"},{"line_number":93,"context_line":"        # The following script requires Azure and GCP credentials"},{"line_number":94,"context_line":"        # - ./tools/deployment/bootstrap/41_deploy_azure_ephemeral_cluster.sh"},{"line_number":95,"context_line":"        # - ./tools/deployment/bootstrap/41_deploy_gcp_ephemeral_cluster.sh"},{"line_number":96,"context_line":"        # - ./tools/deployment/bootstrap/100_clean_up_resources.sh"},{"line_number":97,"context_line":"      serve_dir: /srv/iso"},{"line_number":98,"context_line":"      serve_port: 8099"},{"line_number":99,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"9f560f44_d65e8311","line":96,"range":{"start_line":93,"start_character":0,"end_line":96,"end_character":66},"updated":"2020-09-22 17:16:01.000000000","message":"If these scripts will never be uncommented, this information would be better suited for the documentation. This file should not be consulted for running airshipctl; it is a CI configuration file.","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"dd2be439836ccb79788ee0d5d1fdc14bbae4cff2","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        - ./tools/deployment/bootstrap/03_install_kustomize.sh"},{"line_number":91,"context_line":"        - ./tools/deployment/bootstrap/21_systemwide_executable.sh"},{"line_number":92,"context_line":"        - ./tools/deployment/bootstrap/31_create_configs.sh"},{"line_number":93,"context_line":"        # The following script requires Azure and GCP credentials"},{"line_number":94,"context_line":"        # - ./tools/deployment/bootstrap/41_deploy_azure_ephemeral_cluster.sh"},{"line_number":95,"context_line":"        # - ./tools/deployment/bootstrap/41_deploy_gcp_ephemeral_cluster.sh"},{"line_number":96,"context_line":"        # - ./tools/deployment/bootstrap/100_clean_up_resources.sh"},{"line_number":97,"context_line":"      serve_dir: /srv/iso"},{"line_number":98,"context_line":"      serve_port: 8099"},{"line_number":99,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"9f560f44_83d7aa22","line":96,"range":{"start_line":93,"start_character":0,"end_line":96,"end_character":66},"in_reply_to":"9f560f44_d65e8311","updated":"2020-09-22 22:00:05.000000000","message":"The reason for leaving them commented was to make sure that when support for secrets/credentials are provided by Zuul, they can be uncommented.\n\nAlso it will not be lost in the future.","commit_id":"31cd376e33565b93d3742f13450efd4bdb49772e"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"432d9eaf9ab5db0528e4e13af92312832b435f57","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        - ./tools/deployment/01_install_kubectl.sh"},{"line_number":89,"context_line":"        - ./tools/deployment/21_systemwide_executable.sh"},{"line_number":90,"context_line":"        - ./tools/deployment/bootstrap/31_create_configs.sh"},{"line_number":91,"context_line":"        # The following script requires Azure and GCP credentials"},{"line_number":92,"context_line":"        # - ./tools/deployment/bootstrap/41_deploy_azure_ephemeral_cluster.sh"},{"line_number":93,"context_line":"        # - ./tools/deployment/bootstrap/41_deploy_gcp_ephemeral_cluster.sh"},{"line_number":94,"context_line":"        # - ./tools/deployment/bootstrap/100_clean_up_resources.sh"},{"line_number":95,"context_line":"      serve_dir: /srv/iso"},{"line_number":96,"context_line":"      serve_port: 8099"},{"line_number":97,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":79,"id":"9f560f44_90eb3810","line":94,"range":{"start_line":91,"start_character":8,"end_line":94,"end_character":66},"updated":"2020-09-24 22:16:18.000000000","message":"Please, remove unused code.","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"4e6d7c120fa25141c33af82b048735003227a8bf","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        - ./tools/deployment/01_install_kubectl.sh"},{"line_number":89,"context_line":"        - ./tools/deployment/21_systemwide_executable.sh"},{"line_number":90,"context_line":"        - ./tools/deployment/bootstrap/31_create_configs.sh"},{"line_number":91,"context_line":"        # The following script requires Azure and GCP credentials"},{"line_number":92,"context_line":"        # - ./tools/deployment/bootstrap/41_deploy_azure_ephemeral_cluster.sh"},{"line_number":93,"context_line":"        # - ./tools/deployment/bootstrap/41_deploy_gcp_ephemeral_cluster.sh"},{"line_number":94,"context_line":"        # - ./tools/deployment/bootstrap/100_clean_up_resources.sh"},{"line_number":95,"context_line":"      serve_dir: /srv/iso"},{"line_number":96,"context_line":"      serve_port: 8099"},{"line_number":97,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":79,"id":"9f560f44_3bc5ed8e","line":94,"range":{"start_line":91,"start_character":8,"end_line":94,"end_character":66},"in_reply_to":"9f560f44_90eb3810","updated":"2020-09-24 23:26:35.000000000","message":"To avoid loosing this sequence and have it not forgotten in the future, replaced the comment with a \"TODO\" comment.","commit_id":"0075952c36f2ca7ff2d6264625352179ec6d6b1f"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9fecf7fde3e253ea834ad09978f07fdd50c7259a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        secret: airship_airshipctl_airshipit_github_secret"},{"line_number":75,"context_line":"        pass-to-parent: true"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- job:"},{"line_number":78,"context_line":"    name: airship-airshipctl-gate-script-runner-bootstrap"},{"line_number":79,"context_line":"    attempts: 1"},{"line_number":80,"context_line":"    timeout: 3600"}],"source_content_type":"text/x-yaml","patch_set":80,"id":"9f560f44_c36835f5","line":77,"updated":"2020-09-25 21:53:17.000000000","message":"Will this job be extended? Right now, it\u0027s not performing any airshipctl validation. Since we can use the existing config generation script, 31_create_configs will not be required any longer.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"},{"author":{"_account_id":32089,"name":"Sidney Shiba","email":"sidney.shiba@ericsson.com","username":"esidshi"},"change_message_id":"b9ba3008b6e88d419122a05475d3888833945d5a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        secret: airship_airshipctl_airshipit_github_secret"},{"line_number":75,"context_line":"        pass-to-parent: true"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- job:"},{"line_number":78,"context_line":"    name: airship-airshipctl-gate-script-runner-bootstrap"},{"line_number":79,"context_line":"    attempts: 1"},{"line_number":80,"context_line":"    timeout: 3600"}],"source_content_type":"text/x-yaml","patch_set":80,"id":"9f560f44_5ddd0b40","line":77,"in_reply_to":"9f560f44_c36835f5","updated":"2020-09-28 15:31:21.000000000","message":"This job will be extended to validate the bootstrap commands for creating the GCP and Azure k8s cluster through Zuul when respective platform credentials can be safely accessible by Zuul without exposing them to the community.","commit_id":"193e7841e9d84e3f6a778b98ea93d30e4f8dd971"}],"zuul.d/projects.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1e17a401027607c41a757fe1bc304cc39a495537","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- project:"},{"line_number":14,"context_line":"    vars:"},{"line_number":15,"context_line":"      sphinx_build_dir: docs/build"},{"line_number":16,"context_line":"    check:"},{"line_number":17,"context_line":"      jobs:"},{"line_number":18,"context_line":"        - airship-airshipctl-roles-test:"},{"line_number":19,"context_line":"            files:"},{"line_number":20,"context_line":"              - \"roles/*\""},{"line_number":21,"context_line":"        - openstack-tox-docs"},{"line_number":22,"context_line":"        - airship-airshipctl-lint-unit"},{"line_number":23,"context_line":"        - airship-airshipctl-golint"},{"line_number":24,"context_line":"        - airship-airshipctl-build-image"},{"line_number":25,"context_line":"        - airship-airshipctl-validate-site-docs"},{"line_number":26,"context_line":"#        - airship-airshipctl-functional-existing-k8s TODO: Enable this when functional tests exist, and a cluster is up"},{"line_number":27,"context_line":"        - airship-airshipctl-azure-gate-test"},{"line_number":28,"context_line":"        - airship-airshipctl-gate-test"},{"line_number":29,"context_line":"        - airship-airshipctl-32GB-gate-test"},{"line_number":30,"context_line":"        - airship-airshipctl-gate-script-runner-test"},{"line_number":31,"context_line":"        - airship-airshipctl-32GB-gate-script-runner-test"},{"line_number":32,"context_line":"    gate:"},{"line_number":33,"context_line":"      jobs:"},{"line_number":34,"context_line":"        - openstack-tox-docs"},{"line_number":35,"context_line":"        - airship-airshipctl-lint-unit"},{"line_number":36,"context_line":"        - airship-airshipctl-build-image"},{"line_number":37,"context_line":"        - airship-airshipctl-validate-site-docs"},{"line_number":38,"context_line":"#        - airship-airshipctl-functional-existing-k8s TODO: Enable this when functional tests exist, and a cluster is up"},{"line_number":39,"context_line":"        - airship-airshipctl-azure-gate-test"},{"line_number":40,"context_line":"        - airship-airshipctl-gate-test"},{"line_number":41,"context_line":"    post:"},{"line_number":42,"context_line":"      jobs:"},{"line_number":43,"context_line":"        - airship-airshipctl-publish-image"},{"line_number":44,"context_line":"        - airship-airshipctl-upload-git-mirror"},{"line_number":45,"context_line":"    promote:"},{"line_number":46,"context_line":"      jobs:"},{"line_number":47,"context_line":"        - promote-airship-project-docs"},{"line_number":48,"context_line":"        - airship-airshipctl-update-github-issues"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf51134e_28aa7784","line":48,"range":{"start_line":13,"start_character":2,"end_line":48,"end_character":0},"updated":"2020-07-01 22:32:30.000000000","message":"Job airship-airshipctl-roles-test not defined","commit_id":"a9e099ade188d6cd7f62affd1222622865a303d4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5931320df7684d25f15bea9b8ed1611f94e2ce08","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- project:"},{"line_number":14,"context_line":"    vars:"},{"line_number":15,"context_line":"      sphinx_build_dir: docs/build"},{"line_number":16,"context_line":"    check:"},{"line_number":17,"context_line":"      jobs:"},{"line_number":18,"context_line":"        - airship-airshipctl-roles-test:"},{"line_number":19,"context_line":"            files:"},{"line_number":20,"context_line":"              - \"roles/*\""},{"line_number":21,"context_line":"        # - openstack-tox-docs"},{"line_number":22,"context_line":"        # - airship-airshipctl-lint-unit"},{"line_number":23,"context_line":"        # - airship-airshipctl-golint"},{"line_number":24,"context_line":"        # - airship-airshipctl-build-image"},{"line_number":25,"context_line":"        # - airship-airshipctl-validate-site-docs"},{"line_number":26,"context_line":"#        - airship-airshipctl-functional-existing-k8s TODO: Enable this when functional tests exist, and a cluster is up"},{"line_number":27,"context_line":"        # - airship-airshipctl-azure-gate-test # TO BE REMOVED"},{"line_number":28,"context_line":"        - airship-airshipctl-gate-script-runner-azuretest"},{"line_number":29,"context_line":"        # - airship-airshipctl-gate-test"},{"line_number":30,"context_line":"        # - airship-airshipctl-32GB-gate-test"},{"line_number":31,"context_line":"        # - airship-airshipctl-gate-script-runner-test"},{"line_number":32,"context_line":"        # - airship-airshipctl-32GB-gate-script-runner-test"},{"line_number":33,"context_line":"    gate:"},{"line_number":34,"context_line":"      jobs:"},{"line_number":35,"context_line":"        - openstack-tox-docs"},{"line_number":36,"context_line":"        - airship-airshipctl-lint-unit"},{"line_number":37,"context_line":"        - airship-airshipctl-build-image"},{"line_number":38,"context_line":"        - airship-airshipctl-validate-site-docs"},{"line_number":39,"context_line":"#        - airship-airshipctl-functional-existing-k8s TODO: Enable this when functional tests exist, and a cluster is up"},{"line_number":40,"context_line":"        - airship-airshipctl-azure-gate-test"},{"line_number":41,"context_line":"        - airship-airshipctl-gate-test"},{"line_number":42,"context_line":"    post:"},{"line_number":43,"context_line":"      jobs:"},{"line_number":44,"context_line":"        - airship-airshipctl-publish-image"},{"line_number":45,"context_line":"        - airship-airshipctl-upload-git-mirror"},{"line_number":46,"context_line":"    promote:"},{"line_number":47,"context_line":"      jobs:"},{"line_number":48,"context_line":"        - promote-airship-project-docs"},{"line_number":49,"context_line":"        - airship-airshipctl-update-github-issues"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_e601a008","line":49,"range":{"start_line":13,"start_character":2,"end_line":49,"end_character":0},"updated":"2020-07-06 16:22:02.000000000","message":"Job airship-airshipctl-roles-test not defined","commit_id":"bd8e7f3de9c43a07d3c2669fddbc13a1057b9c24"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"7021792d5ef46cd48efc0075ee9683c86fc703ae","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- project:"},{"line_number":14,"context_line":"    vars:"},{"line_number":15,"context_line":"      sphinx_build_dir: docs/build"},{"line_number":16,"context_line":"    check:"},{"line_number":17,"context_line":"      jobs:"},{"line_number":18,"context_line":"        - airship-airshipctl-roles-test:"},{"line_number":19,"context_line":"            files:"},{"line_number":20,"context_line":"              - \"roles/*\""},{"line_number":21,"context_line":"        # - openstack-tox-docs"},{"line_number":22,"context_line":"        # - airship-airshipctl-lint-unit"},{"line_number":23,"context_line":"        # - airship-airshipctl-golint"},{"line_number":24,"context_line":"        # - airship-airshipctl-build-image"},{"line_number":25,"context_line":"        # - airship-airshipctl-validate-site-docs"},{"line_number":26,"context_line":"#        - airship-airshipctl-functional-existing-k8s TODO: Enable this when functional tests exist, and a cluster is up"},{"line_number":27,"context_line":"        # - airship-airshipctl-azure-gate-test # TO BE REMOVED"},{"line_number":28,"context_line":"        - airship-airshipctl-gate-script-runner-azuretest"},{"line_number":29,"context_line":"        # - airship-airshipctl-gate-test"},{"line_number":30,"context_line":"        # - airship-airshipctl-32GB-gate-test"},{"line_number":31,"context_line":"        # - airship-airshipctl-gate-script-runner-test"},{"line_number":32,"context_line":"        # - airship-airshipctl-32GB-gate-script-runner-test"},{"line_number":33,"context_line":"    gate:"},{"line_number":34,"context_line":"      jobs:"},{"line_number":35,"context_line":"        - openstack-tox-docs"},{"line_number":36,"context_line":"        - airship-airshipctl-lint-unit"},{"line_number":37,"context_line":"        - airship-airshipctl-build-image"},{"line_number":38,"context_line":"        - airship-airshipctl-validate-site-docs"},{"line_number":39,"context_line":"#        - airship-airshipctl-functional-existing-k8s TODO: Enable this when functional tests exist, and a cluster is up"},{"line_number":40,"context_line":"        # - airship-airshipctl-azure-gate-test # TO BE REMOVED"},{"line_number":41,"context_line":"        - airship-airshipctl-gate-script-runner-azuretest"},{"line_number":42,"context_line":"        - airship-airshipctl-gate-test"},{"line_number":43,"context_line":"    post:"},{"line_number":44,"context_line":"      jobs:"},{"line_number":45,"context_line":"        - airship-airshipctl-publish-image"},{"line_number":46,"context_line":"        - airship-airshipctl-upload-git-mirror"},{"line_number":47,"context_line":"    promote:"},{"line_number":48,"context_line":"      jobs:"},{"line_number":49,"context_line":"        - promote-airship-project-docs"},{"line_number":50,"context_line":"        - airship-airshipctl-update-github-issues"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bf51134e_011bde1a","line":50,"range":{"start_line":13,"start_character":2,"end_line":50,"end_character":0},"updated":"2020-07-06 16:37:50.000000000","message":"Job airship-airshipctl-gate-script-runner-azuretest not defined","commit_id":"4ea454c222a5d698d20dfcf7cbe256f8fc82b524"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"571f6493f5f85a7d15c8932222d54f5725600185","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- project:"},{"line_number":14,"context_line":"    vars:"},{"line_number":15,"context_line":"      sphinx_build_dir: docs/build"},{"line_number":16,"context_line":"    check:"},{"line_number":17,"context_line":"      jobs:"},{"line_number":18,"context_line":"        - airship-airshipctl-roles-test:"},{"line_number":19,"context_line":"            files:"},{"line_number":20,"context_line":"              - \"roles/*\""},{"line_number":21,"context_line":"        - openstack-tox-docs"},{"line_number":22,"context_line":"        - airship-airshipctl-lint-unit"},{"line_number":23,"context_line":"        - airship-airshipctl-golint"},{"line_number":24,"context_line":"        - airship-airshipctl-build-image"},{"line_number":25,"context_line":"        - airship-airshipctl-validate-site-docs"},{"line_number":26,"context_line":"#        - airship-airshipctl-functional-existing-k8s TODO: Enable this when functional tests exist, and a cluster is up"},{"line_number":27,"context_line":"        - airship-airshipctl-gate-script-runner"},{"line_number":28,"context_line":"        - airship-airshipctl-gate-script-runner-bootstrap"},{"line_number":29,"context_line":"    gate:"},{"line_number":30,"context_line":"      jobs:"},{"line_number":31,"context_line":"        - openstack-tox-docs"},{"line_number":32,"context_line":"        - airship-airshipctl-lint-unit"},{"line_number":33,"context_line":"        - airship-airshipctl-build-image"},{"line_number":34,"context_line":"        - airship-airshipctl-validate-site-docs"},{"line_number":35,"context_line":"#        - airship-airshipctl-functional-existing-k8s TODO: Enable this when functional tests exist, and a cluster is up"},{"line_number":36,"context_line":"        - airship-airshipctl-gate-script-runner-bootstrap"},{"line_number":37,"context_line":"    post:"},{"line_number":38,"context_line":"      jobs:"},{"line_number":39,"context_line":"        - airship-airshipctl-publish-image"},{"line_number":40,"context_line":"        - airship-airshipctl-upload-git-mirror"},{"line_number":41,"context_line":"    promote:"},{"line_number":42,"context_line":"      jobs:"},{"line_number":43,"context_line":"        - promote-airship-project-docs"},{"line_number":44,"context_line":"        - airship-airshipctl-update-github-issues"}],"source_content_type":"text/x-yaml","patch_set":64,"id":"9f560f44_268f1623","line":44,"range":{"start_line":13,"start_character":2,"end_line":44,"end_character":0},"updated":"2020-09-17 20:30:04.000000000","message":"Job airship-airshipctl-roles-test not defined","commit_id":"52452a18074f8140d037b3261ba5a3dd6c4e20b0"}]}