)]}'
{"manifests/function/hardwareprofile-example/README.md":[{"author":{"_account_id":31643,"name":"Noor Muhammad Malik","email":"noormuhammadmalik95@gmail.com","username":"noor_muhammad_dell"},"change_message_id":"f997e580e613bea4a2de750b79bc6fef087a66ff","unresolved":false,"context_lines":[{"line_number":7,"context_line":"hardware profile functions can be created and consumed."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The `/replacements` kustomization contains a substution rule that injects"},{"line_number":10,"context_line":"the profile into the hostgenerator BMH template.   the `gating` type"},{"line_number":11,"context_line":"and `test-site` kustomization.yamls to see how a hardwareprofile function"},{"line_number":12,"context_line":"can be wired in."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":1,"id":"bf51134e_ef0ae21d","line":12,"range":{"start_line":10,"start_character":50,"end_line":12,"end_character":16},"updated":"2020-07-09 00:40:16.000000000","message":"nit: I\u0027m a bit confused by the language, can this be rephrased?","commit_id":"54c4bb49116a2da2b1ee7a001613beea0bc04d9c"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"7eb08967ac5f562402f6cc573ec8d8ea1f351082","unresolved":false,"context_lines":[{"line_number":7,"context_line":"hardware profile functions can be created and consumed."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The `/replacements` kustomization contains a substution rule that injects"},{"line_number":10,"context_line":"the profile into the hostgenerator BMH template.   the `gating` type"},{"line_number":11,"context_line":"and `test-site` kustomization.yamls to see how a hardwareprofile function"},{"line_number":12,"context_line":"can be wired in."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":1,"id":"bf51134e_b7aa1416","line":12,"range":{"start_line":10,"start_character":50,"end_line":12,"end_character":16},"in_reply_to":"bf51134e_ef0ae21d","updated":"2020-07-23 21:24:44.000000000","message":"Yeah, I botched that one - fixed","commit_id":"54c4bb49116a2da2b1ee7a001613beea0bc04d9c"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"9a3fa1367906ff7a638a88ed1f5ef403ef137adf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"hardware profile functions can be created and consumed."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The `/replacements` kustomization contains a substution rule that injects"},{"line_number":10,"context_line":"the profile into the hostgenerator BMH template.  Please see  the"},{"line_number":11,"context_line":"`manifests/type/gating` type and `manifests/type/test-site`"},{"line_number":12,"context_line":"kustomization.yamls to see how a hardwareprofile function can be wired in."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":3,"id":"9f560f44_389b4066","line":10,"range":{"start_line":10,"start_character":61,"end_line":10,"end_character":62},"updated":"2020-08-06 20:12:36.000000000","message":"nit: extra space","commit_id":"f9d2d4ef27d4d7a2bf67ce05ae4f71d23acee581"}],"manifests/site/test-site/shared/catalogues/hosts.yaml":[{"author":{"_account_id":31643,"name":"Noor Muhammad Malik","email":"noormuhammadmalik95@gmail.com","username":"noor_muhammad_dell"},"change_message_id":"f997e580e613bea4a2de750b79bc6fef087a66ff","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      macAddresses:"},{"line_number":18,"context_line":"        oam: 52:54:00:9b:27:4c"},{"line_number":19,"context_line":"        pxe: 52:54:00:b6:ed:31"},{"line_number":20,"context_line":"      hardwareProfile: default"},{"line_number":21,"context_line":"    node02:"},{"line_number":22,"context_line":"      macAddress: 00:3b:8b:0c:ec:8b"},{"line_number":23,"context_line":"      bmcAddress: redfish+http://10.23.25.2:8000/redfish/v1/Systems/air-target-1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_af2d8a96","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":30},"updated":"2020-07-09 00:40:16.000000000","message":"I know it\u0027s a WIP, just noting that we probably need to define this \u0027default\u0027 profile as another hardware profile in the `replacements\\` directory. The replacement transformer only knows how to replace the \u0027example\u0027 profile. Or am I missing something?","commit_id":"54c4bb49116a2da2b1ee7a001613beea0bc04d9c"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"7eb08967ac5f562402f6cc573ec8d8ea1f351082","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      macAddresses:"},{"line_number":18,"context_line":"        oam: 52:54:00:9b:27:4c"},{"line_number":19,"context_line":"        pxe: 52:54:00:b6:ed:31"},{"line_number":20,"context_line":"      hardwareProfile: default"},{"line_number":21,"context_line":"    node02:"},{"line_number":22,"context_line":"      macAddress: 00:3b:8b:0c:ec:8b"},{"line_number":23,"context_line":"      bmcAddress: redfish+http://10.23.25.2:8000/redfish/v1/Systems/air-target-1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_b72054f9","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":30},"in_reply_to":"bf51134e_af2d8a96","updated":"2020-07-23 21:24:44.000000000","message":"Ah, see line 18 here - the default profile is defined in the host generator function itself.  I\u0027ll add a note to make that more clear.  \n\nhttps://review.opendev.org/#/c/740132/1/manifests/function/hostgenerator-m3/hosttemplate.yaml","commit_id":"54c4bb49116a2da2b1ee7a001613beea0bc04d9c"}]}