)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"8339c6348f21afac0e84c7c774f720c69d56be62","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deploy calico via function."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Deploy Calico to epehemeral and target via function"},{"line_number":10,"context_line":"* Added a new phase to enable phase apply for calico"},{"line_number":11,"context_line":"   \u003d\u003e Could not add calico to the the existing initinfra phase due"},{"line_number":12,"context_line":"      to multiple namespaces."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"9f560f44_72da7117","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":29},"updated":"2020-08-17 20:24:53.000000000","message":"typo","commit_id":"a92742603d14d970f581039bdaed56631904bbe7"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"0e25f793875c9ffb0cb28b3b4be58dfe613a1675","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deploy calico via function."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Deploy Calico to epehemeral and target via function"},{"line_number":10,"context_line":"* Added a new phase to enable phase apply for calico"},{"line_number":11,"context_line":"   \u003d\u003e Could not add calico to the the existing initinfra phase due"},{"line_number":12,"context_line":"      to multiple namespaces."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"9f560f44_ad4cac76","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":29},"in_reply_to":"9f560f44_72da7117","updated":"2020-08-17 20:45:44.000000000","message":"\u003e typo\n\nthanks. corrected","commit_id":"a92742603d14d970f581039bdaed56631904bbe7"}],"manifests/site/test-site/ephemeral/initinfra/kustomization.yaml":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"6980fa370f80f1b0560c32b7c398c95081abc431","unresolved":false,"context_lines":[{"line_number":1,"context_line":"resources:"},{"line_number":2,"context_line":"  - ../../../../composite/controlplane-infra"},{"line_number":3,"context_line":"  - ../../shared/clusterctl"},{"line_number":4,"context_line":"  - ../../../../function/baremetal-operator"},{"line_number":5,"context_line":"patchesStrategicMerge:"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"9f560f44_e9be45ac","line":2,"updated":"2020-08-21 21:23:54.000000000","message":"Although the name `controlplane-infra` makes total sense, it may get a bit confusing, since `controlplane` and `initinfra` are two different phases.  I\u0027m not sure what the best name is; I\u0027m tempted to say: just delete the existing `infra` composite, since it\u0027s not used for anything, and call your composite `infra`.  If nothing else, that fits in well with an `initinfra` phase -- it\u0027s the phase that inits infra.  Any other ideas?\n\nNote: I think it makes sense to do one of two things:\n1. leave baremetal-operator out of the composite, like you have it.  Or,\n2. make another composite, `infra-metal3`, that inherits from `infra` (or whatever we call it) and adds in metal3-specific infra like metal3.\nI don\u0027t have a strong opinion yet, but will think about it.","commit_id":"f55e708ea0ae8fdee831559f2e687f441287b56b"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"70caad78a1f4526be10efafea0669aec7e1497bc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"resources:"},{"line_number":2,"context_line":"  - ../../../../composite/controlplane-infra"},{"line_number":3,"context_line":"  - ../../shared/clusterctl"},{"line_number":4,"context_line":"  - ../../../../function/baremetal-operator"},{"line_number":5,"context_line":"patchesStrategicMerge:"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"9f560f44_a70a8886","line":2,"in_reply_to":"9f560f44_e9be45ac","updated":"2020-08-25 19:51:25.000000000","message":"Updated the exiting infra within composite for calico.","commit_id":"f55e708ea0ae8fdee831559f2e687f441287b56b"}],"tools/deployment/25_deploy_ephemeral_node.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"8339c6348f21afac0e84c7c774f720c69d56be62","unresolved":false,"context_lines":[{"line_number":27,"context_line":"DELAY\u003d60"},{"line_number":28,"context_line":"until [ \"$N\" -ge ${MAX_RETRY} ]"},{"line_number":29,"context_line":"do"},{"line_number":30,"context_line":"  if timeout 20 kubectl --kubeconfig $KUBECONFIG get node; then"},{"line_number":31,"context_line":"      break"},{"line_number":32,"context_line":"  fi"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-sh","patch_set":27,"id":"9f560f44_32275915","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":63},"updated":"2020-08-17 20:24:53.000000000","message":"Could you, please, explain what\u0027s the point to run \"get node\" without processing the output like we did previously in this script?","commit_id":"a92742603d14d970f581039bdaed56631904bbe7"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"0e25f793875c9ffb0cb28b3b4be58dfe613a1675","unresolved":false,"context_lines":[{"line_number":27,"context_line":"DELAY\u003d60"},{"line_number":28,"context_line":"until [ \"$N\" -ge ${MAX_RETRY} ]"},{"line_number":29,"context_line":"do"},{"line_number":30,"context_line":"  if timeout 20 kubectl --kubeconfig $KUBECONFIG get node; then"},{"line_number":31,"context_line":"      break"},{"line_number":32,"context_line":"  fi"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-sh","patch_set":27,"id":"9f560f44_2d125c59","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":63},"in_reply_to":"9f560f44_32275915","updated":"2020-08-17 20:45:44.000000000","message":"Now that we are applying calico function in the later stage ( 26_deploy_metal3_capi_ephemeral_node.sh ), we cannot expect the node to be in ready state until it is applied. So had to change that condition which looks for ready state. \nGet Node is added to just print the node though it is in NotReady state.\n\nNote: Before this PS the calico was applied as part of cloud-init script. so when the node is up, the calico is applied and control pods will also be in running state.","commit_id":"a92742603d14d970f581039bdaed56631904bbe7"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"8339c6348f21afac0e84c7c774f720c69d56be62","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  N\u003d$((N+1))"},{"line_number":35,"context_line":"  echo \"$N: Retrying to reach the apiserver\""},{"line_number":36,"context_line":"  sleep ${DELAY}"},{"line_number":37,"context_line":"done"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"if [ \"$N\" -ge ${MAX_RETRY} ]; then"},{"line_number":40,"context_line":"  echo \"Could not reach the apiserver\""}],"source_content_type":"text/x-sh","patch_set":27,"id":"9f560f44_7276f108","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":4},"updated":"2020-08-17 20:24:53.000000000","message":"Second question: why do we need the change in this script in a commit about calico installation?","commit_id":"a92742603d14d970f581039bdaed56631904bbe7"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"0e25f793875c9ffb0cb28b3b4be58dfe613a1675","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  N\u003d$((N+1))"},{"line_number":35,"context_line":"  echo \"$N: Retrying to reach the apiserver\""},{"line_number":36,"context_line":"  sleep ${DELAY}"},{"line_number":37,"context_line":"done"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"if [ \"$N\" -ge ${MAX_RETRY} ]; then"},{"line_number":40,"context_line":"  echo \"Could not reach the apiserver\""}],"source_content_type":"text/x-sh","patch_set":27,"id":"9f560f44_4d17d046","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":4},"in_reply_to":"9f560f44_7276f108","updated":"2020-08-17 20:45:44.000000000","message":"Explained above","commit_id":"a92742603d14d970f581039bdaed56631904bbe7"}],"tools/deployment/30_deploy_controlplane.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"8339c6348f21afac0e84c7c774f720c69d56be62","unresolved":false,"context_lines":[{"line_number":99,"context_line":"fi"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"echo \"List all pods\""},{"line_number":102,"context_line":"kubectl --kubeconfig /tmp/targetkubeconfig get pods --all-namespaces"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"echo \"Get cluster state\""},{"line_number":105,"context_line":"kubectl --kubeconfig ${HOME}/.airship/kubeconfig get cluster"}],"source_content_type":"text/x-sh","patch_set":27,"id":"9f560f44_b261a93c","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":68},"updated":"2020-08-17 20:24:53.000000000","message":"Why do we need this change in a commit about calico installation?","commit_id":"a92742603d14d970f581039bdaed56631904bbe7"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"0e25f793875c9ffb0cb28b3b4be58dfe613a1675","unresolved":false,"context_lines":[{"line_number":99,"context_line":"fi"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"echo \"List all pods\""},{"line_number":102,"context_line":"kubectl --kubeconfig /tmp/targetkubeconfig get pods --all-namespaces"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"echo \"Get cluster state\""},{"line_number":105,"context_line":"kubectl --kubeconfig ${HOME}/.airship/kubeconfig get cluster"}],"source_content_type":"text/x-sh","patch_set":27,"id":"9f560f44_4d3070e9","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":68},"in_reply_to":"9f560f44_b261a93c","updated":"2020-08-17 20:45:44.000000000","message":"Same as my previous response. We are applying calico at a later stage (31_deploy_initinfra_target_node.sh). So we cannot wait for node to be in ready state at this point","commit_id":"a92742603d14d970f581039bdaed56631904bbe7"}],"tools/deployment/31_deploy_initinfra_target_node.sh":[{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"fc208efa83eda7b332964d8de9f916541a09728b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"airshipctl config set-context target-cluster-admin@target-cluster --manifest dummy_manifest"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"echo \"Deploy calico components to cluster\""},{"line_number":25,"context_line":"airshipctl phase apply networking --wait-timeout 1000s --debug"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"echo \"Waiting for all control pods to come up\""},{"line_number":28,"context_line":"kubectl --kubeconfig $KUBECONFIG wait -n kube-system --for\u003dcondition\u003dReady pods --selector tier\u003dcontrol-plane --timeout\u003d600s"}],"source_content_type":"text/x-sh","patch_set":35,"id":"9f560f44_e28e8a25","line":25,"range":{"start_line":25,"start_character":23,"end_line":25,"end_character":33},"updated":"2020-08-19 20:11:26.000000000","message":"can you wait with this please, there is patch set that was about to be merged, but needs rebasing:\nhttps://review.opendev.org/#/c/746199/\nit should lift the limitation","commit_id":"21122f361c4ebd870c34dad52e663b1f4a45b3a1"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"8b16705a2fd6a01c589be23a4c762a185d812f80","unresolved":false,"context_lines":[{"line_number":22,"context_line":"airshipctl config set-context target-cluster-admin@target-cluster --manifest dummy_manifest"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"echo \"Deploy calico components to cluster\""},{"line_number":25,"context_line":"airshipctl phase apply networking --wait-timeout 1000s --debug"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"echo \"Waiting for all control pods to come up\""},{"line_number":28,"context_line":"kubectl --kubeconfig $KUBECONFIG wait -n kube-system --for\u003dcondition\u003dReady pods --selector tier\u003dcontrol-plane --timeout\u003d600s"}],"source_content_type":"text/x-sh","patch_set":35,"id":"9f560f44_82022e0a","line":25,"range":{"start_line":25,"start_character":23,"end_line":25,"end_character":33},"in_reply_to":"9f560f44_e28e8a25","updated":"2020-08-19 20:47:20.000000000","message":"\u003e can you wait with this please, there is patch set that was about to\n \u003e be merged, but needs rebasing:\n \u003e https://review.opendev.org/#/c/746199/\n \u003e it should lift the limitation\n\nThanks, I see the issue is resolved https://github.com/kubernetes-sigs/cli-utils/pull/212 , I was checking the parent issue in github and thought it is still open https://github.com/kubernetes-sigs/cli-utils/issues/208\n\nSure I will wait for that to be merged and get in existing phase itself.","commit_id":"21122f361c4ebd870c34dad52e663b1f4a45b3a1"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"b518c9b0f726671d9ad1a15e884a9a0aea8e7278","unresolved":false,"context_lines":[{"line_number":27,"context_line":"echo \"Deploy infra to cluster\""},{"line_number":28,"context_line":"airshipctl phase apply initinfra --debug --wait-timeout 1000s"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"echo \"Waiting for all control pods to come up\""},{"line_number":31,"context_line":"kubectl --kubeconfig $KUBECONFIG wait -n kube-system --for\u003dcondition\u003dReady pods --selector tier\u003dcontrol-plane --timeout\u003d600s"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"echo \"List all pods\""},{"line_number":34,"context_line":"kubectl --kubeconfig $KUBECONFIG get pods --all-namespaces"}],"source_content_type":"text/x-sh","patch_set":37,"id":"9f560f44_4af9487e","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":124},"updated":"2020-08-20 02:45:33.000000000","message":"Are you sure we need this? Phase apply should be able to wait without this, can we check before merging?","commit_id":"8933e94d894acc978a14f863ebb24aebadc99bc9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"150889d694ad1afbd8d91cf3b68036bd26205b12","unresolved":false,"context_lines":[{"line_number":27,"context_line":"echo \"Deploy infra to cluster\""},{"line_number":28,"context_line":"airshipctl phase apply initinfra --debug --wait-timeout 1000s"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"echo \"Waiting for all control pods to come up\""},{"line_number":31,"context_line":"kubectl --kubeconfig $KUBECONFIG wait -n kube-system --for\u003dcondition\u003dReady pods --selector tier\u003dcontrol-plane --timeout\u003d600s"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"echo \"List all pods\""},{"line_number":34,"context_line":"kubectl --kubeconfig $KUBECONFIG get pods --all-namespaces"}],"source_content_type":"text/x-sh","patch_set":37,"id":"9f560f44_65fd436d","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":124},"in_reply_to":"9f560f44_4af9487e","updated":"2020-08-21 12:56:50.000000000","message":"Done","commit_id":"8933e94d894acc978a14f863ebb24aebadc99bc9"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"2cd5bc47f48f3ceab05caf375eae61bf7191b7f7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"echo \"Deploy infra to cluster\""},{"line_number":28,"context_line":"airshipctl phase apply initinfra --debug --wait-timeout 1000s"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"echo \"Waiting for all control pods to come up\""},{"line_number":31,"context_line":"kubectl --kubeconfig $KUBECONFIG wait -n kube-system --for\u003dcondition\u003dReady pods --selector tier\u003dcontrol-plane --timeout\u003d600s"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"echo \"List all pods\""},{"line_number":34,"context_line":"kubectl --kubeconfig $KUBECONFIG get pods --all-namespaces"}],"source_content_type":"text/x-sh","patch_set":37,"id":"9f560f44_ea0bf7d1","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":124},"in_reply_to":"9f560f44_4af9487e","updated":"2020-08-20 09:52:17.000000000","message":"I guess it\u0027s not","commit_id":"8933e94d894acc978a14f863ebb24aebadc99bc9"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"150889d694ad1afbd8d91cf3b68036bd26205b12","unresolved":false,"context_lines":[{"line_number":27,"context_line":"echo \"Deploy infra to cluster\""},{"line_number":28,"context_line":"airshipctl phase apply initinfra --debug --wait-timeout 1000s"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"echo \"Waiting for all control pods to come up\""},{"line_number":31,"context_line":"kubectl --kubeconfig $KUBECONFIG wait -n kube-system --for\u003dcondition\u003dReady pods --selector tier\u003dcontrol-plane --timeout\u003d600s"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"echo \"List all pods\""},{"line_number":34,"context_line":"kubectl --kubeconfig $KUBECONFIG get pods --all-namespaces"}],"source_content_type":"text/x-sh","patch_set":37,"id":"9f560f44_4502bf70","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":124},"in_reply_to":"9f560f44_ea0bf7d1","updated":"2020-08-21 12:56:50.000000000","message":"Done","commit_id":"8933e94d894acc978a14f863ebb24aebadc99bc9"}]}