)]}'
{"manifests/function/ephemeral/secret.yaml":[{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"0e2811354f8ec0e249977ea5caaef877da2bfee5","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    bootcmd:"},{"line_number":108,"context_line":"    - mkdir /mnt/ephemeral"},{"line_number":109,"context_line":"    - NEED_MB\u003d16384 # MB of storage needed for ironic images \u0026 bindmounts"},{"line_number":110,"context_line":"    - FREE_MB\u003d$(df -m --output\u003davail / | tail -n 1)"},{"line_number":111,"context_line":"    # Use overlay-backed loopback if there\u0027s enough memory"},{"line_number":112,"context_line":"    - if [ ${FREE_MB} -ge ${NEED_MB} ]; then"},{"line_number":113,"context_line":"    -   mkdir -p /var/lib/images"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_5703dabe","line":110,"range":{"start_line":110,"start_character":19,"end_line":110,"end_character":21},"updated":"2020-09-02 16:18:38.000000000","message":"Just in case there is a long /dev/... line, add -P parameter.","commit_id":"0ac62cf165691fafe04ac126beb738f0685e5b5e"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"e2c7c707bca3a876334246102e2eb012100d5ee4","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    bootcmd:"},{"line_number":108,"context_line":"    - mkdir /mnt/ephemeral"},{"line_number":109,"context_line":"    - NEED_MB\u003d16384 # MB of storage needed for ironic images \u0026 bindmounts"},{"line_number":110,"context_line":"    - FREE_MB\u003d$(df -m --output\u003davail / | tail -n 1)"},{"line_number":111,"context_line":"    # Use overlay-backed loopback if there\u0027s enough memory"},{"line_number":112,"context_line":"    - if [ ${FREE_MB} -ge ${NEED_MB} ]; then"},{"line_number":113,"context_line":"    -   mkdir -p /var/lib/images"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_65cacca1","line":110,"updated":"2020-08-31 23:08:34.000000000","message":"This evaluates / but then creates an image within /var/lib.  It\u0027s (remotely) possible /var is on another disk or partition.  Should evaluate the proper destination.","commit_id":"0ac62cf165691fafe04ac126beb738f0685e5b5e"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"718031264a7e40567ed36b3a257b87ad97dd66cc","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    bootcmd:"},{"line_number":108,"context_line":"    - mkdir /mnt/ephemeral"},{"line_number":109,"context_line":"    - NEED_MB\u003d16384 # MB of storage needed for ironic images \u0026 bindmounts"},{"line_number":110,"context_line":"    - FREE_MB\u003d$(df -m --output\u003davail / | tail -n 1)"},{"line_number":111,"context_line":"    # Use overlay-backed loopback if there\u0027s enough memory"},{"line_number":112,"context_line":"    - if [ ${FREE_MB} -ge ${NEED_MB} ]; then"},{"line_number":113,"context_line":"    -   mkdir -p /var/lib/images"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_a9077218","line":110,"range":{"start_line":110,"start_character":19,"end_line":110,"end_character":21},"in_reply_to":"9f560f44_45604436","updated":"2020-09-03 10:46:40.000000000","message":"Oops. Then no need in it.","commit_id":"0ac62cf165691fafe04ac126beb738f0685e5b5e"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"3b6b691897f50d16f08aa4f2e47789e111564f3d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    bootcmd:"},{"line_number":108,"context_line":"    - mkdir /mnt/ephemeral"},{"line_number":109,"context_line":"    - NEED_MB\u003d16384 # MB of storage needed for ironic images \u0026 bindmounts"},{"line_number":110,"context_line":"    - FREE_MB\u003d$(df -m --output\u003davail / | tail -n 1)"},{"line_number":111,"context_line":"    # Use overlay-backed loopback if there\u0027s enough memory"},{"line_number":112,"context_line":"    - if [ ${FREE_MB} -ge ${NEED_MB} ]; then"},{"line_number":113,"context_line":"    -   mkdir -p /var/lib/images"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_45604436","line":110,"range":{"start_line":110,"start_character":19,"end_line":110,"end_character":21},"in_reply_to":"9f560f44_5703dabe","updated":"2020-09-02 18:46:04.000000000","message":"Actually, looks like -P is mutually exclusive with --output.  Since --output\u003davail will only print the number, is there still a need for -P?","commit_id":"0ac62cf165691fafe04ac126beb738f0685e5b5e"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"aa8543d03491c2b152242d9f862004c51cfb84db","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    bootcmd:"},{"line_number":108,"context_line":"    - mkdir /mnt/ephemeral"},{"line_number":109,"context_line":"    - NEED_MB\u003d16384 # MB of storage needed for ironic images \u0026 bindmounts"},{"line_number":110,"context_line":"    - FREE_MB\u003d$(df -m --output\u003davail / | tail -n 1)"},{"line_number":111,"context_line":"    # Use overlay-backed loopback if there\u0027s enough memory"},{"line_number":112,"context_line":"    - if [ ${FREE_MB} -ge ${NEED_MB} ]; then"},{"line_number":113,"context_line":"    -   mkdir -p /var/lib/images"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_f714aeeb","line":110,"range":{"start_line":110,"start_character":19,"end_line":110,"end_character":21},"in_reply_to":"9f560f44_5703dabe","updated":"2020-09-02 16:28:39.000000000","message":"Good catch - thanks","commit_id":"0ac62cf165691fafe04ac126beb738f0685e5b5e"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"9c7327370da1b1eb49789cce6669986a6052efb4","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    bootcmd:"},{"line_number":108,"context_line":"    - mkdir /mnt/ephemeral"},{"line_number":109,"context_line":"    - NEED_MB\u003d16384 # MB of storage needed for ironic images \u0026 bindmounts"},{"line_number":110,"context_line":"    - FREE_MB\u003d$(df -m --output\u003davail / | tail -n 1)"},{"line_number":111,"context_line":"    # Use overlay-backed loopback if there\u0027s enough memory"},{"line_number":112,"context_line":"    - if [ ${FREE_MB} -ge ${NEED_MB} ]; then"},{"line_number":113,"context_line":"    -   mkdir -p /var/lib/images"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_74e89cb2","line":110,"in_reply_to":"9f560f44_65cacca1","updated":"2020-09-02 16:16:24.000000000","message":"Yes - will do","commit_id":"0ac62cf165691fafe04ac126beb738f0685e5b5e"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"aa8543d03491c2b152242d9f862004c51cfb84db","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    bootcmd:"},{"line_number":108,"context_line":"    - mkdir /mnt/ephemeral"},{"line_number":109,"context_line":"    - NEED_MB\u003d16384 # MB of storage needed for ironic images \u0026 bindmounts"},{"line_number":110,"context_line":"    - FREE_MB\u003d$(df -m --output\u003davail / | tail -n 1)"},{"line_number":111,"context_line":"    # Use overlay-backed loopback if there\u0027s enough memory"},{"line_number":112,"context_line":"    - if [ ${FREE_MB} -ge ${NEED_MB} ]; then"},{"line_number":113,"context_line":"    -   mkdir -p /var/lib/images"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_17ab2275","line":110,"in_reply_to":"9f560f44_74e89cb2","updated":"2020-09-02 16:28:39.000000000","message":"Note, there would still be an assumption in this math that containers (/var/lib) and images (/opt) are sharing the same filesystem, which is true (/) for our current setup.  We could change the ironic image location /var/lib/something to help with this.\n\nAn alternative bit of math that would deal with ironic and containers being on different filesystems would be to simply check whether Total RAM is \u003e\u003d32GB -- this is an equivalent check, since\n\n(Total Free Disk) \u003d (Total RAM * .7) - (Other Stuff on RAM Disk(s))\nOther Stuff on RAM Disk(s) ~\u003d 5.5GB","commit_id":"0ac62cf165691fafe04ac126beb738f0685e5b5e"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"e2c7c707bca3a876334246102e2eb012100d5ee4","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    - mkdir /mnt/ephemeral"},{"line_number":109,"context_line":"    - NEED_MB\u003d16384 # MB of storage needed for ironic images \u0026 bindmounts"},{"line_number":110,"context_line":"    - FREE_MB\u003d$(df -m --output\u003davail / | tail -n 1)"},{"line_number":111,"context_line":"    # Use overlay-backed loopback if there\u0027s enough memory"},{"line_number":112,"context_line":"    - if [ ${FREE_MB} -ge ${NEED_MB} ]; then"},{"line_number":113,"context_line":"    -   mkdir -p /var/lib/images"},{"line_number":114,"context_line":"    -   truncate -s ${NEED_MB}M /var/lib/images/ephemeral.img"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_c5bab808","line":111,"updated":"2020-08-31 23:08:34.000000000","message":"Do we want this rewrite to be inclusive of the case where the available system memory is so large (e.g. in this case, \u003e than NEED_MB) that this isn\u0027t even relevant and you can avoid any kind of local storage binding?\n\nOn a 256/384G system, the available RAM would likely be \u003e than 16384MB making this rather moot.","commit_id":"0ac62cf165691fafe04ac126beb738f0685e5b5e"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"0e2811354f8ec0e249977ea5caaef877da2bfee5","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    - mkdir /mnt/ephemeral"},{"line_number":109,"context_line":"    - NEED_MB\u003d16384 # MB of storage needed for ironic images \u0026 bindmounts"},{"line_number":110,"context_line":"    - FREE_MB\u003d$(df -m --output\u003davail / | tail -n 1)"},{"line_number":111,"context_line":"    # Use overlay-backed loopback if there\u0027s enough memory"},{"line_number":112,"context_line":"    - if [ ${FREE_MB} -ge ${NEED_MB} ]; then"},{"line_number":113,"context_line":"    -   mkdir -p /var/lib/images"},{"line_number":114,"context_line":"    -   truncate -s ${NEED_MB}M /var/lib/images/ephemeral.img"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_7729be35","line":111,"in_reply_to":"9f560f44_a548642e","updated":"2020-09-02 16:18:38.000000000","message":"Agree with Alan here.","commit_id":"0ac62cf165691fafe04ac126beb738f0685e5b5e"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"b88a6219f291d2e5b205cdb65cd356db959d7547","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    - mkdir /mnt/ephemeral"},{"line_number":109,"context_line":"    - NEED_MB\u003d16384 # MB of storage needed for ironic images \u0026 bindmounts"},{"line_number":110,"context_line":"    - FREE_MB\u003d$(df -m --output\u003davail / | tail -n 1)"},{"line_number":111,"context_line":"    # Use overlay-backed loopback if there\u0027s enough memory"},{"line_number":112,"context_line":"    - if [ ${FREE_MB} -ge ${NEED_MB} ]; then"},{"line_number":113,"context_line":"    -   mkdir -p /var/lib/images"},{"line_number":114,"context_line":"    -   truncate -s ${NEED_MB}M /var/lib/images/ephemeral.img"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_a548642e","line":111,"in_reply_to":"9f560f44_c5bab808","updated":"2020-08-31 23:10:35.000000000","message":"Said differently to be more clear, its almost like all of this voodoo is only engaged if you don\u0027t think the available memory is sufficient to support some level of container/image needs, and 16G seems like a reasonable place to draw that line.","commit_id":"0ac62cf165691fafe04ac126beb738f0685e5b5e"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"eb8e31bca7bfc16cb1a5aa57a958555fce0ec532","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    - FREE_MB\u003d$(df -m --output\u003davail / | tail -n 1)"},{"line_number":111,"context_line":"    # Use overlay-backed loopback if there\u0027s enough memory"},{"line_number":112,"context_line":"    - if [ ${FREE_MB} -ge ${NEED_MB} ]; then"},{"line_number":113,"context_line":"    -   mkdir -p /var/lib/images"},{"line_number":114,"context_line":"    -   truncate -s ${NEED_MB}M /var/lib/images/ephemeral.img"},{"line_number":115,"context_line":"    -   mkfs.ext4 /var/lib/images/ephemeral.img"},{"line_number":116,"context_line":"    -   mount /var/lib/images/ephemeral.img /mnt/ephemeral"},{"line_number":117,"context_line":"    # Use vda if provided by a hypervisor"},{"line_number":118,"context_line":"    - elif [ -e /dev/vda ]; then"},{"line_number":119,"context_line":"    -   mkfs.ext4 /dev/vda"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_31291689","line":116,"range":{"start_line":113,"start_character":0,"end_line":116,"end_character":58},"updated":"2020-09-02 14:37:15.000000000","message":"i\u0027d say we should not really care about mount points if we have enough RAM according to condition on L112","commit_id":"0ac62cf165691fafe04ac126beb738f0685e5b5e"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"9c7327370da1b1eb49789cce6669986a6052efb4","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    - FREE_MB\u003d$(df -m --output\u003davail / | tail -n 1)"},{"line_number":111,"context_line":"    # Use overlay-backed loopback if there\u0027s enough memory"},{"line_number":112,"context_line":"    - if [ ${FREE_MB} -ge ${NEED_MB} ]; then"},{"line_number":113,"context_line":"    -   mkdir -p /var/lib/images"},{"line_number":114,"context_line":"    -   truncate -s ${NEED_MB}M /var/lib/images/ephemeral.img"},{"line_number":115,"context_line":"    -   mkfs.ext4 /var/lib/images/ephemeral.img"},{"line_number":116,"context_line":"    -   mount /var/lib/images/ephemeral.img /mnt/ephemeral"},{"line_number":117,"context_line":"    # Use vda if provided by a hypervisor"},{"line_number":118,"context_line":"    - elif [ -e /dev/vda ]; then"},{"line_number":119,"context_line":"    -   mkfs.ext4 /dev/vda"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_f7666ebb","line":116,"range":{"start_line":113,"start_character":0,"end_line":116,"end_character":58},"in_reply_to":"9f560f44_31291689","updated":"2020-09-02 16:16:24.000000000","message":"Yes, thanks, I was overthinking this.  Agree w/ you and Alan.","commit_id":"0ac62cf165691fafe04ac126beb738f0685e5b5e"}]}