)]}'
{"pkg/clusterctl/client/executor.go":[{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"8abea8494060ea967b23decba1d6fb9bfbeeaa60","unresolved":false,"context_lines":[{"line_number":107,"context_line":"\t\treturn"},{"line_number":108,"context_line":"\t}"},{"line_number":109,"context_line":"\tlog.Print(\"command \u0027clusterctl move\u0027 is going to be executed\")"},{"line_number":110,"context_line":"\terr \u003d c.Move(kubeConfigFile, fromContext, kubeConfigFile, c.clusterName, ns)"},{"line_number":111,"context_line":"\tif err !\u003d nil {"},{"line_number":112,"context_line":"\t\tc.handleErr(err, evtCh)"},{"line_number":113,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":3,"id":"9f560f44_c5826b52","line":110,"range":{"start_line":110,"start_character":1,"end_line":110,"end_character":77},"updated":"2020-09-04 16:45:17.000000000","message":"could be done within one line \"err \u003d c.Move(...); if err !\u003d nil {}\"","commit_id":"6399bed670dc663a20d6ded7f489d6ceb6b121e0"},{"author":{"_account_id":7185,"name":"Dmitry Ukov","email":"dukov@mirantis.com","username":"dukov"},"change_message_id":"c51b4fed3571563b8c92d1809906990051c6d629","unresolved":false,"context_lines":[{"line_number":107,"context_line":"\t\treturn"},{"line_number":108,"context_line":"\t}"},{"line_number":109,"context_line":"\tlog.Print(\"command \u0027clusterctl move\u0027 is going to be executed\")"},{"line_number":110,"context_line":"\terr \u003d c.Move(kubeConfigFile, fromContext, kubeConfigFile, c.clusterName, ns)"},{"line_number":111,"context_line":"\tif err !\u003d nil {"},{"line_number":112,"context_line":"\t\tc.handleErr(err, evtCh)"},{"line_number":113,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":3,"id":"9f560f44_b69693ee","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":77},"updated":"2020-09-04 13:19:24.000000000","message":"nit: we should add at least dummy implementation for dry run","commit_id":"6399bed670dc663a20d6ded7f489d6ceb6b121e0"}],"pkg/k8s/kubeconfig/errors.go":[{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"8abea8494060ea967b23decba1d6fb9bfbeeaa60","unresolved":false,"context_lines":[{"line_number":55,"context_line":"// ErrParentContext returned when requested cluster is not defined or doesn\u0027t have a parent"},{"line_number":56,"context_line":"type ErrParentContext struct {"},{"line_number":57,"context_line":"\tChild string"},{"line_number":58,"context_line":"\tMap   *v1alpha1.ClusterMap"},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"func (e ErrParentContext) Error() string {"}],"source_content_type":"text/x-go","patch_set":3,"id":"9f560f44_85beb3fc","line":58,"range":{"start_line":58,"start_character":1,"end_line":58,"end_character":27},"updated":"2020-09-04 16:45:17.000000000","message":"may be it would be better to pass here string which contains necessary information about Map rather than printing pointer via %v","commit_id":"6399bed670dc663a20d6ded7f489d6ceb6b121e0"}],"pkg/k8s/kubeconfig/utils.go":[{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"09a05bd6daf8af47c8579f442dd8f30d4fd8a2f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f560f44_a5de570d","updated":"2020-09-04 17:02:36.000000000","message":"We already have utils.go file at /pkg/k8s/utils/, may be it would be proper way to use it instead of creating new one.","commit_id":"6399bed670dc663a20d6ded7f489d6ceb6b121e0"}],"pkg/k8s/kubeconfig/utils_test.go":[{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"8abea8494060ea967b23decba1d6fb9bfbeeaa60","unresolved":false,"context_lines":[{"line_number":72,"context_line":"\t\tt.Run(tt.name, func(t *testing.T) {"},{"line_number":73,"context_line":"\t\t\tactualContext, err :\u003d kubeconfig.ParentContext(tt.childName, tt.cMap)"},{"line_number":74,"context_line":"\t\t\tif tt.expectErr {"},{"line_number":75,"context_line":"\t\t\t\tassert.Error(t, err)"},{"line_number":76,"context_line":"\t\t\t} else {"},{"line_number":77,"context_line":"\t\t\t\trequire.NoError(t, err)"},{"line_number":78,"context_line":"\t\t\t\tassert.Equal(t, tt.expectedContext, actualContext)"}],"source_content_type":"text/x-go","patch_set":3,"id":"9f560f44_855353e2","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":24},"updated":"2020-09-04 16:45:17.000000000","message":"I would compare with actual error type rather than just fact that error occurred","commit_id":"6399bed670dc663a20d6ded7f489d6ceb6b121e0"}]}