)]}'
{"manifests/function/capg/v0.3.0/manager/manager_image_patch.yaml":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"22c2ee96301bb13d99c7466c95ac021e4fb7cbf8","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    spec:"},{"line_number":9,"context_line":"      containers:"},{"line_number":10,"context_line":"      # Change the value of image field below to your controller image URL"},{"line_number":11,"context_line":"      - image: ${CONTAINER_CAPG_MANAGER}"},{"line_number":12,"context_line":"        name: manager"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7112b459_cef1be09","line":11,"updated":"2020-12-15 21:54:10.000000000","message":"Note that Siraj is planning to migrate CAPI image overriding to a new mechanism which does not require variable substitution.  He made the change for bare metal in the PS below, and plans to follow up with a change for the other providers.  I\u0027ll add him onto this patchset for visibility.\n\nhttps://review.opendev.org/c/airship/airshipctl/+/766228","commit_id":"37f162b268729bf91ad446d3fc3da2b46a0c1a52"}],"manifests/function/clusterctl/clusterctl.yaml":[{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"29e8422d36cf94fbc3da25878e6838ce29aa6d32","unresolved":true,"context_lines":[{"line_number":75,"context_line":"  CONTAINER_CAPZ_AUTH_PROXY: gcr.io/kubebuilder/kube-rbac-proxy:v0.4.1"},{"line_number":76,"context_line":"  CONTAINER_CAPG_MANAGER: gcr.io/k8s-staging-cluster-api-gcp/cluster-api-gcp-controller:master"},{"line_number":77,"context_line":"  CONTAINER_CAPG_AUTH_PROXY: gcr.io/kubebuilder/kube-rbac-proxy:v0.4.1"},{"line_number":78,"context_line":"  GCP_CONTROL_PLANE_MACHINE_TYPE: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":79,"context_line":"  GCP_NODE_MACHINE_TYPE: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":80,"context_line":"  GCP_REGION: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":81,"context_line":"  GCP_NETWORK_NAME: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":82,"context_line":"  GCP_PROJECT: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":83,"context_line":"  GCP_B64ENCODED_CREDENTIALS: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4b4bba58_8a7d6ab1","line":83,"range":{"start_line":78,"start_character":0,"end_line":83,"end_character":60},"updated":"2020-12-16 01:38:22.000000000","message":"are tare you sure that these values belong here, instead of the site level?","commit_id":"28bda4193b383ff4ce3ce47a8d7d0faad1bce718"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"dee04417437bb60d6225e3901ef3ee96c2e239da","unresolved":true,"context_lines":[{"line_number":75,"context_line":"  CONTAINER_CAPZ_AUTH_PROXY: gcr.io/kubebuilder/kube-rbac-proxy:v0.4.1"},{"line_number":76,"context_line":"  CONTAINER_CAPG_MANAGER: gcr.io/k8s-staging-cluster-api-gcp/cluster-api-gcp-controller:master"},{"line_number":77,"context_line":"  CONTAINER_CAPG_AUTH_PROXY: gcr.io/kubebuilder/kube-rbac-proxy:v0.4.1"},{"line_number":78,"context_line":"  GCP_CONTROL_PLANE_MACHINE_TYPE: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":79,"context_line":"  GCP_NODE_MACHINE_TYPE: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":80,"context_line":"  GCP_REGION: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":81,"context_line":"  GCP_NETWORK_NAME: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":82,"context_line":"  GCP_PROJECT: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":83,"context_line":"  GCP_B64ENCODED_CREDENTIALS: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f3840174_333ca35a","line":83,"range":{"start_line":78,"start_character":0,"end_line":83,"end_character":60},"in_reply_to":"3c4e1d3f_59445b10","updated":"2020-12-16 22:47:33.000000000","message":"\u003e Hi Kostyantyn,\n\u003e \n\u003e These values are GCP account and other details that are required at the time of initializing the ephemeral cluster. As per CAPG manifests these are not at site level. \n\u003e \n\u003e Thanks\n\nmy question is why are they here? they are not relevant to any but GCP cluster? shouldn\u0027t these be included at site level? in json patch?","commit_id":"28bda4193b383ff4ce3ce47a8d7d0faad1bce718"},{"author":{"_account_id":32003,"name":"Ratnopam Chakrabarti","email":"ratnopam.chakrabarti@ericsson.com","username":"eratnch"},"change_message_id":"feb1b8ac7c651482d2c86e3b5daa60f9b4d3113f","unresolved":true,"context_lines":[{"line_number":75,"context_line":"  CONTAINER_CAPZ_AUTH_PROXY: gcr.io/kubebuilder/kube-rbac-proxy:v0.4.1"},{"line_number":76,"context_line":"  CONTAINER_CAPG_MANAGER: gcr.io/k8s-staging-cluster-api-gcp/cluster-api-gcp-controller:master"},{"line_number":77,"context_line":"  CONTAINER_CAPG_AUTH_PROXY: gcr.io/kubebuilder/kube-rbac-proxy:v0.4.1"},{"line_number":78,"context_line":"  GCP_CONTROL_PLANE_MACHINE_TYPE: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":79,"context_line":"  GCP_NODE_MACHINE_TYPE: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":80,"context_line":"  GCP_REGION: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":81,"context_line":"  GCP_NETWORK_NAME: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":82,"context_line":"  GCP_PROJECT: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":83,"context_line":"  GCP_B64ENCODED_CREDENTIALS: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3c4e1d3f_59445b10","line":83,"range":{"start_line":78,"start_character":0,"end_line":83,"end_character":60},"in_reply_to":"4b4bba58_8a7d6ab1","updated":"2020-12-16 16:20:59.000000000","message":"Hi Kostyantyn,\n\nThese values are GCP account and other details that are required at the time of initializing the ephemeral cluster. As per CAPG manifests these are not at site level. \n\nThanks","commit_id":"28bda4193b383ff4ce3ce47a8d7d0faad1bce718"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"b5366e365f572725b918a9aa5853e0c6f970a1bc","unresolved":true,"context_lines":[{"line_number":75,"context_line":"  CONTAINER_CAPZ_AUTH_PROXY: gcr.io/kubebuilder/kube-rbac-proxy:v0.4.1"},{"line_number":76,"context_line":"  CONTAINER_CAPG_MANAGER: gcr.io/k8s-staging-cluster-api-gcp/cluster-api-gcp-controller:master"},{"line_number":77,"context_line":"  CONTAINER_CAPG_AUTH_PROXY: gcr.io/kubebuilder/kube-rbac-proxy:v0.4.1"},{"line_number":78,"context_line":"  GCP_CONTROL_PLANE_MACHINE_TYPE: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":79,"context_line":"  GCP_NODE_MACHINE_TYPE: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":80,"context_line":"  GCP_REGION: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":81,"context_line":"  GCP_NETWORK_NAME: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":82,"context_line":"  GCP_PROJECT: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""},{"line_number":83,"context_line":"  GCP_B64ENCODED_CREDENTIALS: \"YmFzZTY0X2VuY29kZWRfdmFsdWU\u003d\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"66e4af59_28d29285","line":83,"range":{"start_line":78,"start_character":0,"end_line":83,"end_character":60},"in_reply_to":"f3840174_333ca35a","updated":"2020-12-17 02:04:12.000000000","message":"I agree that it would be better to patch if possible; but it looks like these values are consumed by the capg provider function itself, which is deployed via clusterctl-init.  Therefore, substitution must be accomplished into that function using clusterctl.yaml.\n\nHowever, it seems really strange for the GCP *provider* to need to know about these managed-cluster-specific values.  I.e. how I\u0027d expect it to work:  the GCP provider ought to be able to deploy into *any* GCP_REGION, with different values specified in different k8scontrol definition(s).  I just want to confirm, is this Secret (manager-bootstrap-credentials) required during clusterctl-init, or could it be deployed in a later phase (like k8scontrol)?\n\nIf I\u0027m missing something please let me know!","commit_id":"28bda4193b383ff4ce3ce47a8d7d0faad1bce718"}]}