)]}'
{"cmd/plan/status.go":[{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"fbb63f70a622e4215dcfe3782ecff2128c7b696f","unresolved":true,"context_lines":[{"line_number":40,"context_line":"\t\tLong:    statusLong,"},{"line_number":41,"context_line":"\t\tExample: statusExample,"},{"line_number":42,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":43,"context_line":"\t\t\ts.Options.PlanID.Name \u003d args[0]"},{"line_number":44,"context_line":"\t\t\treturn s.RunE()"},{"line_number":45,"context_line":"\t\t},"},{"line_number":46,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":8,"id":"fa117448_e532cbff","line":43,"range":{"start_line":43,"start_character":28,"end_line":43,"end_character":34},"updated":"2021-03-24 02:27:40.000000000","message":"this will panic if u dont add \"Args:    cobra.ExactArgs(1)\"","commit_id":"96c587fbf70bb8b3c824502940754bb2b4d21b75"},{"author":{"_account_id":30504,"name":"Niharika Bhavaraju","email":"niha.twinkle@gmail.com","username":"niharikab"},"change_message_id":"f1e70e7571940d24dfb9cbcb41b32f0fafcc738a","unresolved":true,"context_lines":[{"line_number":40,"context_line":"\t\tLong:    statusLong,"},{"line_number":41,"context_line":"\t\tExample: statusExample,"},{"line_number":42,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":43,"context_line":"\t\t\ts.Options.PlanID.Name \u003d args[0]"},{"line_number":44,"context_line":"\t\t\treturn s.RunE()"},{"line_number":45,"context_line":"\t\t},"},{"line_number":46,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":8,"id":"2c29cb62_6d136498","line":43,"range":{"start_line":43,"start_character":28,"end_line":43,"end_character":34},"in_reply_to":"fa117448_e532cbff","updated":"2021-03-25 14:51:24.000000000","message":"done, thanks","commit_id":"96c587fbf70bb8b3c824502940754bb2b4d21b75"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"8d0879411811134cb967a7e1a385cd8f51586f30","unresolved":true,"context_lines":[{"line_number":40,"context_line":"\t\tLong:    statusLong,"},{"line_number":41,"context_line":"\t\tExample: statusExample,"},{"line_number":42,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":43,"context_line":"\t\t\ts.Options.PlanID.Name \u003d args[0]"},{"line_number":44,"context_line":"\t\t\treturn s.RunE()"},{"line_number":45,"context_line":"\t\t},"},{"line_number":46,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":12,"id":"e9665241_3ded283c","line":43,"range":{"start_line":43,"start_character":27,"end_line":43,"end_character":34},"updated":"2021-04-02 06:39:49.000000000","message":"this will panic if no args are passed","commit_id":"555c72d14391f38b8b9efda2ccab0dff99498a8d"},{"author":{"_account_id":30504,"name":"Niharika Bhavaraju","email":"niha.twinkle@gmail.com","username":"niharikab"},"change_message_id":"63d7024762964eb0b087447a8a0385fc8862f6aa","unresolved":true,"context_lines":[{"line_number":40,"context_line":"\t\tLong:    statusLong,"},{"line_number":41,"context_line":"\t\tExample: statusExample,"},{"line_number":42,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":43,"context_line":"\t\t\ts.Options.PlanID.Name \u003d args[0]"},{"line_number":44,"context_line":"\t\t\treturn s.RunE()"},{"line_number":45,"context_line":"\t\t},"},{"line_number":46,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":12,"id":"2414b907_f756b085","line":43,"range":{"start_line":43,"start_character":27,"end_line":43,"end_character":34},"in_reply_to":"e9665241_3ded283c","updated":"2021-04-06 19:20:31.000000000","message":"done","commit_id":"555c72d14391f38b8b9efda2ccab0dff99498a8d"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"8d0879411811134cb967a7e1a385cd8f51586f30","unresolved":true,"context_lines":[{"line_number":40,"context_line":"\t\tLong:    statusLong,"},{"line_number":41,"context_line":"\t\tExample: statusExample,"},{"line_number":42,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":43,"context_line":"\t\t\ts.Options.PlanID.Name \u003d args[0]"},{"line_number":44,"context_line":"\t\t\treturn s.RunE()"},{"line_number":45,"context_line":"\t\t},"},{"line_number":46,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":13,"id":"79a247c6_d6179d41","line":43,"range":{"start_line":43,"start_character":27,"end_line":43,"end_character":34},"updated":"2021-04-02 06:39:49.000000000","message":"this is going to cause panic, if no args are passed to cli.","commit_id":"b2aba38da046a9a6310a4598a97d8588c456ab6f"},{"author":{"_account_id":30504,"name":"Niharika Bhavaraju","email":"niha.twinkle@gmail.com","username":"niharikab"},"change_message_id":"63d7024762964eb0b087447a8a0385fc8862f6aa","unresolved":true,"context_lines":[{"line_number":40,"context_line":"\t\tLong:    statusLong,"},{"line_number":41,"context_line":"\t\tExample: statusExample,"},{"line_number":42,"context_line":"\t\tRunE: func(cmd *cobra.Command, args []string) error {"},{"line_number":43,"context_line":"\t\t\ts.Options.PlanID.Name \u003d args[0]"},{"line_number":44,"context_line":"\t\t\treturn s.RunE()"},{"line_number":45,"context_line":"\t\t},"},{"line_number":46,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":13,"id":"a872b2d8_90783f92","line":43,"range":{"start_line":43,"start_character":27,"end_line":43,"end_character":34},"in_reply_to":"79a247c6_d6179d41","updated":"2021-04-06 19:20:31.000000000","message":"done","commit_id":"b2aba38da046a9a6310a4598a97d8588c456ab6f"}],"pkg/phase/command.go":[{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"fbb63f70a622e4215dcfe3782ecff2128c7b696f","unresolved":true,"context_lines":[{"line_number":310,"context_line":"// PlanStatusFlags plan status command"},{"line_number":311,"context_line":"type PlanStatusFlags struct {"},{"line_number":312,"context_line":"\tPlanID   ifc.ID"},{"line_number":313,"context_line":"\tTimeout  time.Duration"},{"line_number":314,"context_line":"\tProgress bool"},{"line_number":315,"context_line":"\tWriter   io.Writer"},{"line_number":316,"context_line":"}"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"// PlanStatusCommand plan status command"}],"source_content_type":"text/x-go","patch_set":8,"id":"7998d67b_7575d068","line":315,"range":{"start_line":313,"start_character":0,"end_line":315,"end_character":19},"updated":"2021-03-24 02:27:40.000000000","message":"lets add these fields when they are going to be used","commit_id":"96c587fbf70bb8b3c824502940754bb2b4d21b75"},{"author":{"_account_id":30504,"name":"Niharika Bhavaraju","email":"niha.twinkle@gmail.com","username":"niharikab"},"change_message_id":"f1e70e7571940d24dfb9cbcb41b32f0fafcc738a","unresolved":true,"context_lines":[{"line_number":310,"context_line":"// PlanStatusFlags plan status command"},{"line_number":311,"context_line":"type PlanStatusFlags struct {"},{"line_number":312,"context_line":"\tPlanID   ifc.ID"},{"line_number":313,"context_line":"\tTimeout  time.Duration"},{"line_number":314,"context_line":"\tProgress bool"},{"line_number":315,"context_line":"\tWriter   io.Writer"},{"line_number":316,"context_line":"}"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"// PlanStatusCommand plan status command"}],"source_content_type":"text/x-go","patch_set":8,"id":"e9ca42f5_c0d3ae02","line":315,"range":{"start_line":313,"start_character":0,"end_line":315,"end_character":19},"in_reply_to":"7998d67b_7575d068","updated":"2021-03-25 14:51:24.000000000","message":"done, thanks for the review","commit_id":"96c587fbf70bb8b3c824502940754bb2b4d21b75"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"8d0879411811134cb967a7e1a385cd8f51586f30","unresolved":true,"context_lines":[{"line_number":403,"context_line":"\tif err !\u003d nil {"},{"line_number":404,"context_line":"\t\treturn err"},{"line_number":405,"context_line":"\t}"},{"line_number":406,"context_line":"\tfor _, p :\u003d range plan.Phases {"},{"line_number":407,"context_line":"\t\tphaseID.Name \u003d p.Name"},{"line_number":408,"context_line":"\t\tphase, err \u003d NewClient(helper).PhaseByID(ps.Options.PlanID)"},{"line_number":409,"context_line":"\t\tif err !\u003d nil {"},{"line_number":410,"context_line":"\t\t\treturn err"},{"line_number":411,"context_line":"\t\t}"},{"line_number":412,"context_line":"\t\t_, err :\u003d phase.Status()"},{"line_number":413,"context_line":"\t\treturn err"},{"line_number":414,"context_line":"\t}"},{"line_number":415,"context_line":"\treturn nil"},{"line_number":416,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":13,"id":"b78faacb_917c548f","line":414,"range":{"start_line":406,"start_character":0,"end_line":414,"end_character":2},"updated":"2021-04-02 06:39:49.000000000","message":"lets add Status() method to ifc.plan interface instead. Can you add separate patchset for this.\nStatus() method should accept options as well. For start, let the options be empty struct:\n\nStatus(StatusOptions)\n\ntype StatusOptions struct {}","commit_id":"b2aba38da046a9a6310a4598a97d8588c456ab6f"},{"author":{"_account_id":30504,"name":"Niharika Bhavaraju","email":"niha.twinkle@gmail.com","username":"niharikab"},"change_message_id":"63d7024762964eb0b087447a8a0385fc8862f6aa","unresolved":true,"context_lines":[{"line_number":403,"context_line":"\tif err !\u003d nil {"},{"line_number":404,"context_line":"\t\treturn err"},{"line_number":405,"context_line":"\t}"},{"line_number":406,"context_line":"\tfor _, p :\u003d range plan.Phases {"},{"line_number":407,"context_line":"\t\tphaseID.Name \u003d p.Name"},{"line_number":408,"context_line":"\t\tphase, err \u003d NewClient(helper).PhaseByID(ps.Options.PlanID)"},{"line_number":409,"context_line":"\t\tif err !\u003d nil {"},{"line_number":410,"context_line":"\t\t\treturn err"},{"line_number":411,"context_line":"\t\t}"},{"line_number":412,"context_line":"\t\t_, err :\u003d phase.Status()"},{"line_number":413,"context_line":"\t\treturn err"},{"line_number":414,"context_line":"\t}"},{"line_number":415,"context_line":"\treturn nil"},{"line_number":416,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":13,"id":"6a758ee9_282dfb70","line":414,"range":{"start_line":406,"start_character":0,"end_line":414,"end_character":2},"in_reply_to":"b78faacb_917c548f","updated":"2021-04-06 19:20:31.000000000","message":"done,thanks for the review. Created the ps https://review.opendev.org/c/airship/airshipctl/+/784936  to add Status() in ifc.Plan interface.","commit_id":"b2aba38da046a9a6310a4598a97d8588c456ab6f"}],"pkg/phase/helper_test.go":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"5fccb7c754683054a2e99b5f40b394f4a9d4ea73","unresolved":true,"context_lines":[{"line_number":177,"context_line":"\t\t\t}"},{"line_number":178,"context_line":"\t\t\trequire.NoError(t, err)"},{"line_number":179,"context_line":"\t\t\trequire.NotNil(t, helper)"},{"line_number":180,"context_line":"\t\t\tvar id ifc.ID"},{"line_number":181,"context_line":"\t\t\tid.Name \u003d \"phasePlan\""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"\t\t\tactualPlan, actualErr :\u003d helper.Plan(ifc.ID{Name: testPlanName})"},{"line_number":184,"context_line":"\t\t\tif tt.errContains !\u003d \"\" {"}],"source_content_type":"text/x-go","patch_set":51,"id":"47db6d68_433d5db4","line":181,"range":{"start_line":180,"start_character":0,"end_line":181,"end_character":24},"updated":"2021-08-11 22:39:54.000000000","message":"This doesn\u0027t appear to be used anywhere, please delete it","commit_id":"61a76295dd3b82188fc53d4256edde6ffbe2d02a"},{"author":{"_account_id":31968,"name":"Bijaya Sharma","email":"vetbijaya@gmail.com","username":"bijayasharma"},"change_message_id":"c57008111374d339bdfd510043fdc0f01496b926","unresolved":false,"context_lines":[{"line_number":177,"context_line":"\t\t\t}"},{"line_number":178,"context_line":"\t\t\trequire.NoError(t, err)"},{"line_number":179,"context_line":"\t\t\trequire.NotNil(t, helper)"},{"line_number":180,"context_line":"\t\t\tvar id ifc.ID"},{"line_number":181,"context_line":"\t\t\tid.Name \u003d \"phasePlan\""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"\t\t\tactualPlan, actualErr :\u003d helper.Plan(ifc.ID{Name: testPlanName})"},{"line_number":184,"context_line":"\t\t\tif tt.errContains !\u003d \"\" {"}],"source_content_type":"text/x-go","patch_set":51,"id":"8745f461_933b07f6","line":181,"range":{"start_line":180,"start_character":0,"end_line":181,"end_character":24},"in_reply_to":"47db6d68_433d5db4","updated":"2021-08-17 12:29:23.000000000","message":"Done","commit_id":"61a76295dd3b82188fc53d4256edde6ffbe2d02a"}]}