)]}'
{"manifests/function/airshipctl-base-catalogues/env-vars-template.yaml":[{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"398bd8661f301461c442071a6ab725d05478c6ec","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  annotations:"},{"line_number":8,"context_line":"    config.kubernetes.io/function: |-"},{"line_number":9,"context_line":"      container:"},{"line_number":10,"context_line":"        image: quay.io/airshipit/templater:latest"},{"line_number":11,"context_line":"        envs:"},{"line_number":12,"context_line":"          - HTTP_PROXY"},{"line_number":13,"context_line":"          - HTTPS_PROXY"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"ee688114_8bd9fce0","line":10,"updated":"2021-06-03 19:03:03.000000000","message":"May I know why we are moving from the tag \"localhost\" to \"quay.io/airshipit\" ? \nthe files in this PS is updated to use quay.io, how about other manifests where we still have localhost tag for plugins ?","commit_id":"687db4a1211a39381880696984d4402a62a6527f"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"f157ec9ffb7f18a5191f12d944b20bb9b0fe227a","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  annotations:"},{"line_number":8,"context_line":"    config.kubernetes.io/function: |-"},{"line_number":9,"context_line":"      container:"},{"line_number":10,"context_line":"        image: quay.io/airshipit/templater:latest"},{"line_number":11,"context_line":"        envs:"},{"line_number":12,"context_line":"          - HTTP_PROXY"},{"line_number":13,"context_line":"          - HTTPS_PROXY"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"78cd78e3_bdc9296b","line":10,"in_reply_to":"25eadaa3_f98d41a4","updated":"2021-06-04 15:17:28.000000000","message":"Oops, yeah good catch Siraj.  It was recently decided that the appropriate tag of upstream krm function images from quay will be cached on the host running airshipctl as \"localhost/templater\" prior to running kustomize.  So I believe localhost/templater is correct.","commit_id":"687db4a1211a39381880696984d4402a62a6527f"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"37f371a7981c11c46115c9e8640c5f3b6542e269","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  annotations:"},{"line_number":8,"context_line":"    config.kubernetes.io/function: |-"},{"line_number":9,"context_line":"      container:"},{"line_number":10,"context_line":"        image: quay.io/airshipit/templater:latest"},{"line_number":11,"context_line":"        envs:"},{"line_number":12,"context_line":"          - HTTP_PROXY"},{"line_number":13,"context_line":"          - HTTPS_PROXY"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"25eadaa3_f98d41a4","line":10,"in_reply_to":"aac028df_0a2d2d43","updated":"2021-06-04 14:20:39.000000000","message":"Thanks for the reply. Could you please take a look at this logic\nhttps://github.com/airshipit/airshipctl/blob/master/tools/deployment/21_systemwide_executable.sh#L39\n\nfrom my understanding this specific change in this PS is not required. Because we are using latest tag to pull and update the docker image tag to localhost/\u003cfn_name\u003e in the 21 script. I may be wrong, it is better to double check.","commit_id":"687db4a1211a39381880696984d4402a62a6527f"},{"author":{"_account_id":32090,"name":"Graham Steffaniak","email":"graham.steffaniak@att.com","username":"gs909v"},"change_message_id":"fd396481145cd23ffdc715f0b84e8426df155c0d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  annotations:"},{"line_number":8,"context_line":"    config.kubernetes.io/function: |-"},{"line_number":9,"context_line":"      container:"},{"line_number":10,"context_line":"        image: quay.io/airshipit/templater:latest"},{"line_number":11,"context_line":"        envs:"},{"line_number":12,"context_line":"          - HTTP_PROXY"},{"line_number":13,"context_line":"          - HTTPS_PROXY"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"aac028df_0a2d2d43","line":10,"in_reply_to":"ee688114_8bd9fce0","updated":"2021-06-03 21:22:47.000000000","message":"my understanding is that localhost images get tagged as quay.io during deployment. I was using localhost because the previous version was :v2 instead of :latest. The main branch now has quay.io images, so this change is just a result of rebasing onto main. both localhost and quay image should be the same.","commit_id":"687db4a1211a39381880696984d4402a62a6527f"}],"manifests/function/ephemeral/replacements/stringData-encode.yaml":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"b6a11e7b79f58f45454e0a163cf7475d9ce1c903","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    objref:"},{"line_number":25,"context_line":"      kind: Secret"},{"line_number":26,"context_line":"      name: ephemeral-bmc-secret"},{"line_number":27,"context_line":"    fieldref: stringData.replacement"},{"line_number":28,"context_line":"  target:"},{"line_number":29,"context_line":"    objref:"},{"line_number":30,"context_line":"      name: ephemeral-bmc-secret"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3685f0f6_2f42bd61","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":36},"updated":"2021-03-16 17:09:44.000000000","message":"Replacing a null from this field is a little bit of a hack.  Can we try taking this replacement out entirely, adding another transformer of `kind: PatchStrategicMergeTransformer`, and have it $delete the `stringData` key after the ReplacmentTransformer copies (and encodes) it?","commit_id":"984ba351570e6419f082a2e5f1e05844eecccbed"},{"author":{"_account_id":32090,"name":"Graham Steffaniak","email":"graham.steffaniak@att.com","username":"gs909v"},"change_message_id":"3c368b6d9e14910f39dae397bf91ca5f9351001d","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    objref:"},{"line_number":25,"context_line":"      kind: Secret"},{"line_number":26,"context_line":"      name: ephemeral-bmc-secret"},{"line_number":27,"context_line":"    fieldref: stringData.replacement"},{"line_number":28,"context_line":"  target:"},{"line_number":29,"context_line":"    objref:"},{"line_number":30,"context_line":"      name: ephemeral-bmc-secret"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4b853d9f_80f7f7db","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":36},"in_reply_to":"3685f0f6_2f42bd61","updated":"2021-03-22 21:08:59.000000000","message":"Ack","commit_id":"984ba351570e6419f082a2e5f1e05844eecccbed"},{"author":{"_account_id":28690,"name":"Sirajudeen","email":"sirajudeen.yasin@gmail.com","username":"siraj.yasin"},"change_message_id":"dea1524193e35ef627891e94dff28a42cc6510b1","unresolved":true,"context_lines":[{"line_number":6,"context_line":"  annotations:"},{"line_number":7,"context_line":"    config.kubernetes.io/function: |-"},{"line_number":8,"context_line":"      container:"},{"line_number":9,"context_line":"        image: quay.io/airshipit/replacement-transformer:latest"},{"line_number":10,"context_line":"replacements:"},{"line_number":11,"context_line":"# converts and moves stringData to data field"},{"line_number":12,"context_line":"- source:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"f5364b22_481a8171","line":9,"updated":"2021-06-07 14:11:08.000000000","message":"sorry one more, should we change the plugin url to localhost/replacement-transformer","commit_id":"6cefb15d952826e879db1bfa58bed6aca9950586"},{"author":{"_account_id":32090,"name":"Graham Steffaniak","email":"graham.steffaniak@att.com","username":"gs909v"},"change_message_id":"8edfc6a403a3601a2c8400cbcd4d48c653765df1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  annotations:"},{"line_number":7,"context_line":"    config.kubernetes.io/function: |-"},{"line_number":8,"context_line":"      container:"},{"line_number":9,"context_line":"        image: quay.io/airshipit/replacement-transformer:latest"},{"line_number":10,"context_line":"replacements:"},{"line_number":11,"context_line":"# converts and moves stringData to data field"},{"line_number":12,"context_line":"- source:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"a2115ffa_2eec852f","line":9,"in_reply_to":"f5364b22_481a8171","updated":"2021-06-07 15:56:50.000000000","message":"Done","commit_id":"6cefb15d952826e879db1bfa58bed6aca9950586"}]}