)]}'
{"tools/airship-in-a-pod/Makefile":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"d1937e39e4accd16e4c31b882e69778c58df5755","unresolved":true,"context_lines":[{"line_number":35,"context_line":"endif"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"test: build ## Test airship-in-a-pod"},{"line_number":38,"context_line":"\tkubectl delete -f airship-in-a-pod.yaml || true"},{"line_number":39,"context_line":"\tkubectl create -f airship-in-a-pod.yaml"}],"source_content_type":"application/octet-stream","patch_set":55,"id":"7e9fad24_e003fa3a","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":40},"updated":"2021-06-14 15:40:08.000000000","message":"These need to be updated to point at the new location","commit_id":"73c3d28154a5ef603c91258ad1659f75f3c0b2ee"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"9f6829e5fff0eb8d19f7b4fe0476b9791531d209","unresolved":false,"context_lines":[{"line_number":35,"context_line":"endif"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"test: build ## Test airship-in-a-pod"},{"line_number":38,"context_line":"\tkubectl delete -f airship-in-a-pod.yaml || true"},{"line_number":39,"context_line":"\tkubectl create -f airship-in-a-pod.yaml"}],"source_content_type":"application/octet-stream","patch_set":55,"id":"52df1903_775ea3c4","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":40},"in_reply_to":"7e9fad24_e003fa3a","updated":"2021-06-15 17:58:27.000000000","message":"Update with kustomize commands.","commit_id":"73c3d28154a5ef603c91258ad1659f75f3c0b2ee"}],"tools/airship-in-a-pod/README.md":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"04b567d4c4e3b1896a15218a06669230fb09f090","unresolved":true,"context_lines":[{"line_number":34,"context_line":"```"},{"line_number":35,"context_line":"sudo -E mkdir /opt/.airship"},{"line_number":36,"context_line":"```"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"### Environment variable setup"},{"line_number":39,"context_line":"```"},{"line_number":40,"context_line":"export SOPS_PGP_FP\u003d\"FBC7B9E2A4F9289AC0C1D4843D16CEE4A27381B4\""},{"line_number":41,"context_line":"export SOPS_IMPORT_PGP\u003d\"$(curl -fsSL  https://raw.githubusercontent.com/mozilla/sops/master/pgp/sops_functional_tests_key.asc)\""},{"line_number":42,"context_line":"```"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"If you are within a proxy environment. Ensure that the following environment"},{"line_number":45,"context_line":"variables are defined. And NO_PROXY has the IP address which minikube uses."}],"source_content_type":"text/x-gfm","patch_set":28,"id":"17e5bf8c_6802f738","line":42,"range":{"start_line":37,"start_character":0,"end_line":42,"end_character":3},"updated":"2021-04-09 18:30:57.000000000","message":"This isn\u0027t necessary - it\u0027s handled within the container","commit_id":"2cf3ba7b3aae7d5532fd0db8a229f4bc8fc30566"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"474cf531658c1c23203376a43846caa37902da4c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"```"},{"line_number":35,"context_line":"sudo -E mkdir /opt/.airship"},{"line_number":36,"context_line":"```"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"### Environment variable setup"},{"line_number":39,"context_line":"```"},{"line_number":40,"context_line":"export SOPS_PGP_FP\u003d\"FBC7B9E2A4F9289AC0C1D4843D16CEE4A27381B4\""},{"line_number":41,"context_line":"export SOPS_IMPORT_PGP\u003d\"$(curl -fsSL  https://raw.githubusercontent.com/mozilla/sops/master/pgp/sops_functional_tests_key.asc)\""},{"line_number":42,"context_line":"```"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"If you are within a proxy environment. Ensure that the following environment"},{"line_number":45,"context_line":"variables are defined. And NO_PROXY has the IP address which minikube uses."}],"source_content_type":"text/x-gfm","patch_set":28,"id":"5f8c78a9_bd62c0fc","line":42,"range":{"start_line":37,"start_character":0,"end_line":42,"end_character":3},"in_reply_to":"17e5bf8c_6802f738","updated":"2021-04-12 18:42:13.000000000","message":"I tried using it for having the SOP related env ready when user logs into the \ncontainer. It does not seem to work.\n\nRemoved it.","commit_id":"2cf3ba7b3aae7d5532fd0db8a229f4bc8fc30566"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"010faea75229487209d5e91fc2bd38ffb2fb7cee","unresolved":true,"context_lines":[{"line_number":7,"context_line":"* `artifact-setup`: This container builds the airshipctl binary and makes it"},{"line_number":8,"context_line":"  available to the other containers. Also based on the configuration provided"},{"line_number":9,"context_line":"  in the pod manifest, the respective git repository will be downloaded"},{"line_number":10,"context_line":"  and made ready."},{"line_number":11,"context_line":"* `infra-builder`: This container creates the various virtual networks and"},{"line_number":12,"context_line":"  machines required for an Airship deployment"},{"line_number":13,"context_line":"* `runner`: The runner container is the \"meat\" of the pod, and executes the"}],"source_content_type":"text/x-gfm","patch_set":37,"id":"8e724039_73147f3a","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":16},"updated":"2021-04-21 15:14:07.000000000","message":"\"made ready\" for what and how","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"6fe1722d717c4f7727486db80f276a4a788e670e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"* `artifact-setup`: This container builds the airshipctl binary and makes it"},{"line_number":8,"context_line":"  available to the other containers. Also based on the configuration provided"},{"line_number":9,"context_line":"  in the pod manifest, the respective git repository will be downloaded"},{"line_number":10,"context_line":"  and made ready."},{"line_number":11,"context_line":"* `infra-builder`: This container creates the various virtual networks and"},{"line_number":12,"context_line":"  machines required for an Airship deployment"},{"line_number":13,"context_line":"* `runner`: The runner container is the \"meat\" of the pod, and executes the"}],"source_content_type":"text/x-gfm","patch_set":37,"id":"ea6a678c_cbaaed97","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":16},"in_reply_to":"8e724039_73147f3a","updated":"2021-04-22 08:28:14.000000000","message":"Done","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"010faea75229487209d5e91fc2bd38ffb2fb7cee","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"In order to deploy Airship in a Pod for development, you must first have a"},{"line_number":27,"context_line":"working Kubernetes cluster. This guide assumes that a developer will deploy"},{"line_number":28,"context_line":"using [minikube](https://minikube.sigs.k8s.io/docs/start/):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"### Setup shared directory"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":37,"id":"7410b841_a77787eb","line":28,"range":{"start_line":28,"start_character":58,"end_line":28,"end_character":59},"updated":"2021-04-21 15:14:07.000000000","message":"change to a period \u0027.\u0027","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"6fe1722d717c4f7727486db80f276a4a788e670e","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"In order to deploy Airship in a Pod for development, you must first have a"},{"line_number":27,"context_line":"working Kubernetes cluster. This guide assumes that a developer will deploy"},{"line_number":28,"context_line":"using [minikube](https://minikube.sigs.k8s.io/docs/start/):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"### Setup shared directory"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":37,"id":"fe9baf15_c3662e1a","line":28,"range":{"start_line":28,"start_character":58,"end_line":28,"end_character":59},"in_reply_to":"7410b841_a77787eb","updated":"2021-04-22 08:28:14.000000000","message":"Done","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"010faea75229487209d5e91fc2bd38ffb2fb7cee","unresolved":true,"context_lines":[{"line_number":68,"context_line":"### Pod configuration for airshipctl"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Within the examples/airshipctl directory setup the patchset.yaml"},{"line_number":72,"context_line":"file to reflect the airshipctl info as required."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":37,"id":"6f30aec5_132653f8","line":71,"range":{"start_line":71,"start_character":41,"end_line":71,"end_character":64},"updated":"2021-04-21 15:14:07.000000000","message":"Setup -- does the file have to be created or it exists and has to be edited?","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"010faea75229487209d5e91fc2bd38ffb2fb7cee","unresolved":true,"context_lines":[{"line_number":68,"context_line":"### Pod configuration for airshipctl"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Within the examples/airshipctl directory setup the patchset.yaml"},{"line_number":72,"context_line":"file to reflect the airshipctl info as required."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":37,"id":"c50bd265_b3855f75","line":71,"range":{"start_line":71,"start_character":11,"end_line":71,"end_character":30},"updated":"2021-04-21 15:14:07.000000000","message":"need the path to be specified","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"6fe1722d717c4f7727486db80f276a4a788e670e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"### Pod configuration for airshipctl"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Within the examples/airshipctl directory setup the patchset.yaml"},{"line_number":72,"context_line":"file to reflect the airshipctl info as required."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":37,"id":"15202cbe_7002facc","line":71,"range":{"start_line":71,"start_character":41,"end_line":71,"end_character":64},"in_reply_to":"6f30aec5_132653f8","updated":"2021-04-22 08:28:14.000000000","message":"Done","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"6fe1722d717c4f7727486db80f276a4a788e670e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"### Pod configuration for airshipctl"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Within the examples/airshipctl directory setup the patchset.yaml"},{"line_number":72,"context_line":"file to reflect the airshipctl info as required."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":37,"id":"92d1aba0_2f46c623","line":71,"range":{"start_line":71,"start_character":11,"end_line":71,"end_character":30},"in_reply_to":"c50bd265_b3855f75","updated":"2021-04-22 08:28:14.000000000","message":"Done","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"010faea75229487209d5e91fc2bd38ffb2fb7cee","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Within the examples/airshipctl directory setup the patchset.yaml"},{"line_number":72,"context_line":"file to reflect the airshipctl info as required."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"```"}],"source_content_type":"text/x-gfm","patch_set":37,"id":"bfbe7eaf_26485ca5","line":72,"range":{"start_line":72,"start_character":31,"end_line":72,"end_character":47},"updated":"2021-04-21 15:14:07.000000000","message":"where does one find that information or are these steps defined","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"6fe1722d717c4f7727486db80f276a4a788e670e","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Within the examples/airshipctl directory setup the patchset.yaml"},{"line_number":72,"context_line":"file to reflect the airshipctl info as required."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"```"}],"source_content_type":"text/x-gfm","patch_set":37,"id":"2c196adc_191da2b8","line":72,"range":{"start_line":72,"start_character":31,"end_line":72,"end_character":47},"in_reply_to":"bfbe7eaf_26485ca5","updated":"2021-04-22 08:28:14.000000000","message":"I have updated the line.","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"010faea75229487209d5e91fc2bd38ffb2fb7cee","unresolved":true,"context_lines":[{"line_number":82,"context_line":"### Pod configuration for treasuremap"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"For treasuremap related manifests, use the patchset.yaml from"},{"line_number":85,"context_line":"examples/treasuremap and  update the following to reflect"},{"line_number":86,"context_line":"the treasuremap  info  as required."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"```"}],"source_content_type":"text/x-gfm","patch_set":37,"id":"3d733127_60e0e2cc","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":20},"updated":"2021-04-21 15:14:07.000000000","message":"please specify the path","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"6fe1722d717c4f7727486db80f276a4a788e670e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"### Pod configuration for treasuremap"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"For treasuremap related manifests, use the patchset.yaml from"},{"line_number":85,"context_line":"examples/treasuremap and  update the following to reflect"},{"line_number":86,"context_line":"the treasuremap  info  as required."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"```"}],"source_content_type":"text/x-gfm","patch_set":37,"id":"8717e585_f9bdcf4a","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":20},"in_reply_to":"3d733127_60e0e2cc","updated":"2021-04-22 08:28:14.000000000","message":"Done","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"010faea75229487209d5e91fc2bd38ffb2fb7cee","unresolved":true,"context_lines":[{"line_number":88,"context_line":"```"},{"line_number":89,"context_line":"- op: replace"},{"line_number":90,"context_line":"  path: \"/spec/containers/4/env/4/value\""},{"line_number":91,"context_line":"  value: \u003cbranch reference\u003e"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- op: replace"},{"line_number":94,"context_line":"  path: \"/spec/containers/4/env/6/value\""}],"source_content_type":"text/x-gfm","patch_set":37,"id":"ed1a7403_7b352ce5","line":91,"range":{"start_line":91,"start_character":10,"end_line":91,"end_character":26},"updated":"2021-04-21 15:14:07.000000000","message":"can you specify what is this or maybe examples of what this maybe","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"6fe1722d717c4f7727486db80f276a4a788e670e","unresolved":false,"context_lines":[{"line_number":88,"context_line":"```"},{"line_number":89,"context_line":"- op: replace"},{"line_number":90,"context_line":"  path: \"/spec/containers/4/env/4/value\""},{"line_number":91,"context_line":"  value: \u003cbranch reference\u003e"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- op: replace"},{"line_number":94,"context_line":"  path: \"/spec/containers/4/env/6/value\""}],"source_content_type":"text/x-gfm","patch_set":37,"id":"94d628f4_f18db668","line":91,"range":{"start_line":91,"start_character":10,"end_line":91,"end_character":26},"in_reply_to":"ed1a7403_7b352ce5","updated":"2021-04-22 08:28:14.000000000","message":"I have put a note of reference of the examples directory too.","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"010faea75229487209d5e91fc2bd38ffb2fb7cee","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- op: replace"},{"line_number":94,"context_line":"  path: \"/spec/containers/4/env/6/value\""},{"line_number":95,"context_line":"  value: \u003cairschipctl_ref\u003e"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"```"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":37,"id":"a39b6368_bbaec6e7","line":95,"range":{"start_line":95,"start_character":10,"end_line":95,"end_character":25},"updated":"2021-04-21 15:14:07.000000000","message":"same comment as that for \u003cbranch_ref\u003e","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"6fe1722d717c4f7727486db80f276a4a788e670e","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- op: replace"},{"line_number":94,"context_line":"  path: \"/spec/containers/4/env/6/value\""},{"line_number":95,"context_line":"  value: \u003cairschipctl_ref\u003e"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"```"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":37,"id":"299437de_932c8998","line":95,"range":{"start_line":95,"start_character":10,"end_line":95,"end_character":25},"in_reply_to":"a39b6368_bbaec6e7","updated":"2021-04-22 08:28:14.000000000","message":"Done","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"010faea75229487209d5e91fc2bd38ffb2fb7cee","unresolved":true,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"```"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Once patchset.yaml of the required module is ready, run the following"},{"line_number":100,"context_line":"command against the running minikube cluster"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"```"}],"source_content_type":"text/x-gfm","patch_set":37,"id":"f88a33ca_23750973","line":99,"range":{"start_line":99,"start_character":26,"end_line":99,"end_character":41},"updated":"2021-04-21 15:14:07.000000000","message":"what does \"required module\" refer to","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"6fe1722d717c4f7727486db80f276a4a788e670e","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"```"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Once patchset.yaml of the required module is ready, run the following"},{"line_number":100,"context_line":"command against the running minikube cluster"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"```"}],"source_content_type":"text/x-gfm","patch_set":37,"id":"730c910e_a31fff2c","line":99,"range":{"start_line":99,"start_character":26,"end_line":99,"end_character":41},"in_reply_to":"f88a33ca_23750973","updated":"2021-04-22 08:28:14.000000000","message":"Added additional info.","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"010faea75229487209d5e91fc2bd38ffb2fb7cee","unresolved":true,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"### Inspect Cluster"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Once Airship is fully installed with a target cluster (air-target-1 and air-worker-1 nodes)"},{"line_number":132,"context_line":"installed and running, the cluster could be monitored using the following steps."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"#### Log into the runner container"}],"source_content_type":"text/x-gfm","patch_set":37,"id":"241c222f_dafd9952","line":131,"range":{"start_line":131,"start_character":5,"end_line":131,"end_character":13},"updated":"2021-04-21 15:14:07.000000000","message":"should this be Airship-in-a-Pod?","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"6fe1722d717c4f7727486db80f276a4a788e670e","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"### Inspect Cluster"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Once Airship is fully installed with a target cluster (air-target-1 and air-worker-1 nodes)"},{"line_number":132,"context_line":"installed and running, the cluster could be monitored using the following steps."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"#### Log into the runner container"}],"source_content_type":"text/x-gfm","patch_set":37,"id":"4a950bfc_dffe8c96","line":131,"range":{"start_line":131,"start_character":5,"end_line":131,"end_character":13},"in_reply_to":"241c222f_dafd9952","updated":"2021-04-22 08:28:14.000000000","message":"Done","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"010faea75229487209d5e91fc2bd38ffb2fb7cee","unresolved":true,"context_lines":[{"line_number":149,"context_line":"within kubectl as below."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"```"},{"line_number":152,"context_line":"kubectl --kubeconfig /root/.airship/kubeconfig --context target-cluster get po -A\u0027"},{"line_number":153,"context_line":"```"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":37,"id":"e349f30e_def24b42","line":152,"range":{"start_line":152,"start_character":76,"end_line":152,"end_character":78},"updated":"2021-04-21 15:14:07.000000000","message":"Typo? pods","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"6fe1722d717c4f7727486db80f276a4a788e670e","unresolved":false,"context_lines":[{"line_number":149,"context_line":"within kubectl as below."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"```"},{"line_number":152,"context_line":"kubectl --kubeconfig /root/.airship/kubeconfig --context target-cluster get po -A\u0027"},{"line_number":153,"context_line":"```"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":37,"id":"26214164_4d171fe0","line":152,"range":{"start_line":152,"start_character":76,"end_line":152,"end_character":78},"in_reply_to":"e349f30e_def24b42","updated":"2021-04-22 08:28:14.000000000","message":"\"po\" too works fine. I have made it pods now.","commit_id":"df5be016a3065cee5c6a47f56b114bc64f95c380"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"9cdfd6ad26fc7cdd67159e5474660a1dd358400b","unresolved":true,"context_lines":[{"line_number":32,"context_line":"Setup the following directory with appropriate r+w permissions."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"```"},{"line_number":35,"context_line":"sudo -E mkdir /opt/.airship"},{"line_number":36,"context_line":"```"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"### Environment variable setup"}],"source_content_type":"text/x-gfm","patch_set":41,"id":"a7e99f59_e959a707","line":35,"range":{"start_line":35,"start_character":5,"end_line":35,"end_character":7},"updated":"2021-05-12 03:18:07.000000000","message":"Is it needed?","commit_id":"3d834f3c26cd273da86080590e3b949a6e99532e"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"7a4a5d06b5032a73b02ff6216699c40f3583b53f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Setup the following directory with appropriate r+w permissions."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"```"},{"line_number":35,"context_line":"sudo -E mkdir /opt/.airship"},{"line_number":36,"context_line":"```"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"### Environment variable setup"}],"source_content_type":"text/x-gfm","patch_set":41,"id":"d2a073b9_9c78ffa1","line":35,"range":{"start_line":35,"start_character":5,"end_line":35,"end_character":7},"in_reply_to":"a7e99f59_e959a707","updated":"2021-05-13 13:49:28.000000000","message":"-E removed.","commit_id":"3d834f3c26cd273da86080590e3b949a6e99532e"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"9cdfd6ad26fc7cdd67159e5474660a1dd358400b","unresolved":true,"context_lines":[{"line_number":41,"context_line":"variables are defined. And NO_PROXY has the IP address which minikube uses."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"```"},{"line_number":44,"context_line":"export HTTPS_PROXY\u003d\u003chttps proxy ip:port\u003e"},{"line_number":45,"context_line":"export HTTP_PROXY\u003d\u003chttp proxy ip:port\u003e"},{"line_number":46,"context_line":"export https_proxy\u003d\u003chttps proxy ip:port\u003e"},{"line_number":47,"context_line":"export http_proxy\u003d\u003chttp proxy ip:port\u003e"},{"line_number":48,"context_line":"export no_proxy\u003dlocalhost,10.1.1.44"},{"line_number":49,"context_line":"export NO_PROXY\u003dlocalhost,10.1.1.44"},{"line_number":50,"context_line":"export USE_PROXY\u003dtrue"},{"line_number":51,"context_line":"export use_proxy\u003dtrue"},{"line_number":52,"context_line":"```"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"#### To start minikube"}],"source_content_type":"text/x-gfm","patch_set":41,"id":"ddc38c61_b28c02bf","line":51,"range":{"start_line":44,"start_character":0,"end_line":51,"end_character":21},"updated":"2021-05-12 03:18:07.000000000","message":"You can add username/password for the proxy like it is mentioned here: https://docs.airshipit.org/airshipctl/developers.html#proxy-setup","commit_id":"3d834f3c26cd273da86080590e3b949a6e99532e"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"7a4a5d06b5032a73b02ff6216699c40f3583b53f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"variables are defined. And NO_PROXY has the IP address which minikube uses."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"```"},{"line_number":44,"context_line":"export HTTPS_PROXY\u003d\u003chttps proxy ip:port\u003e"},{"line_number":45,"context_line":"export HTTP_PROXY\u003d\u003chttp proxy ip:port\u003e"},{"line_number":46,"context_line":"export https_proxy\u003d\u003chttps proxy ip:port\u003e"},{"line_number":47,"context_line":"export http_proxy\u003d\u003chttp proxy ip:port\u003e"},{"line_number":48,"context_line":"export no_proxy\u003dlocalhost,10.1.1.44"},{"line_number":49,"context_line":"export NO_PROXY\u003dlocalhost,10.1.1.44"},{"line_number":50,"context_line":"export USE_PROXY\u003dtrue"},{"line_number":51,"context_line":"export use_proxy\u003dtrue"},{"line_number":52,"context_line":"```"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"#### To start minikube"}],"source_content_type":"text/x-gfm","patch_set":41,"id":"81b37155_cf5b7f33","line":51,"range":{"start_line":44,"start_character":0,"end_line":51,"end_character":21},"in_reply_to":"ddc38c61_b28c02bf","updated":"2021-05-13 13:49:28.000000000","message":"Done","commit_id":"3d834f3c26cd273da86080590e3b949a6e99532e"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"4e84cb3bb5c9c3b23fd0b291809b8b8084130bb4","unresolved":true,"context_lines":[{"line_number":50,"context_line":"export https_proxy\u003dhttp://username:password@host:port"},{"line_number":51,"context_line":"export no_proxy\u003d\"localhost,127.0.0.1,10.23.0.0/16,10.96.0.0/12,10.1.1.44\""},{"line_number":52,"context_line":"export proxy\u003dhttp://username:password@host:port"},{"line_number":53,"context_line":"export use_proxy\u003dtrue"},{"line_number":54,"context_line":"```"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"#### To start minikube"}],"source_content_type":"text/x-gfm","patch_set":43,"id":"ca087bb9_f5a967e9","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":21},"updated":"2021-05-25 20:37:46.000000000","message":"The USE_PROXY variable is one of ours, so this lower-case version isn\u0027t needed","commit_id":"9dd89ed1309b6f8149620b1428424ee28a9c7011"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"5ba7dcb149507f4970177c69fa271185e4100886","unresolved":false,"context_lines":[{"line_number":50,"context_line":"export https_proxy\u003dhttp://username:password@host:port"},{"line_number":51,"context_line":"export no_proxy\u003d\"localhost,127.0.0.1,10.23.0.0/16,10.96.0.0/12,10.1.1.44\""},{"line_number":52,"context_line":"export proxy\u003dhttp://username:password@host:port"},{"line_number":53,"context_line":"export use_proxy\u003dtrue"},{"line_number":54,"context_line":"```"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"#### To start minikube"}],"source_content_type":"text/x-gfm","patch_set":43,"id":"4fade96a_d6181aa4","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":21},"in_reply_to":"ca087bb9_f5a967e9","updated":"2021-05-26 11:18:54.000000000","message":"Done","commit_id":"9dd89ed1309b6f8149620b1428424ee28a9c7011"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"4e84cb3bb5c9c3b23fd0b291809b8b8084130bb4","unresolved":true,"context_lines":[{"line_number":70,"context_line":"### Pod configuration for airshipctl"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Within the examples/airshipctl directory,update the existing patchset.yaml"},{"line_number":74,"context_line":"file to reflect the airshipctl branch reference as required."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"filepath : airshipctl/tools/airship-in-a-pod/examples/airshipctl/patchset.yaml"}],"source_content_type":"text/x-gfm","patch_set":43,"id":"240422fd_d3dcb127","line":73,"range":{"start_line":73,"start_character":31,"end_line":73,"end_character":47},"updated":"2021-05-25 20:37:46.000000000","message":"missing space","commit_id":"9dd89ed1309b6f8149620b1428424ee28a9c7011"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"5ba7dcb149507f4970177c69fa271185e4100886","unresolved":false,"context_lines":[{"line_number":70,"context_line":"### Pod configuration for airshipctl"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Within the examples/airshipctl directory,update the existing patchset.yaml"},{"line_number":74,"context_line":"file to reflect the airshipctl branch reference as required."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"filepath : airshipctl/tools/airship-in-a-pod/examples/airshipctl/patchset.yaml"}],"source_content_type":"text/x-gfm","patch_set":43,"id":"0dea757f_9f13c2bf","line":73,"range":{"start_line":73,"start_character":31,"end_line":73,"end_character":47},"in_reply_to":"240422fd_d3dcb127","updated":"2021-05-26 11:18:54.000000000","message":"Done","commit_id":"9dd89ed1309b6f8149620b1428424ee28a9c7011"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"4e84cb3bb5c9c3b23fd0b291809b8b8084130bb4","unresolved":true,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"- op: replace"},{"line_number":101,"context_line":"  path: \"/spec/containers/4/env/6/value\""},{"line_number":102,"context_line":"  value: \u003cairschipctl_ref\u003e"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"```"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":43,"id":"fe7f706b_4b232791","line":102,"range":{"start_line":102,"start_character":14,"end_line":102,"end_character":15},"updated":"2021-05-25 20:37:46.000000000","message":"spelling","commit_id":"9dd89ed1309b6f8149620b1428424ee28a9c7011"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"5ba7dcb149507f4970177c69fa271185e4100886","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"- op: replace"},{"line_number":101,"context_line":"  path: \"/spec/containers/4/env/6/value\""},{"line_number":102,"context_line":"  value: \u003cairschipctl_ref\u003e"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"```"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":43,"id":"a6b339cc_0ad9ca3e","line":102,"range":{"start_line":102,"start_character":14,"end_line":102,"end_character":15},"in_reply_to":"fe7f706b_4b232791","updated":"2021-05-26 11:18:54.000000000","message":"Done","commit_id":"9dd89ed1309b6f8149620b1428424ee28a9c7011"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"4e84cb3bb5c9c3b23fd0b291809b8b8084130bb4","unresolved":true,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Airship-in-a-pod produces the following outputs:"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"* The airshipctl/and other related repo and associated binary used with the deployment"},{"line_number":167,"context_line":"* A tarball containing the generated ephemeral ISO, as well as the"},{"line_number":168,"context_line":"  configuration used during generation."},{"line_number":169,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":43,"id":"2f9fa057_af4fa254","line":166,"range":{"start_line":166,"start_character":2,"end_line":166,"end_character":86},"updated":"2021-05-25 20:37:46.000000000","message":"suggest rewording:\n\nThe airshipctl repo, manifest repo, and airshipctl binary used with the deployment","commit_id":"9dd89ed1309b6f8149620b1428424ee28a9c7011"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"5ba7dcb149507f4970177c69fa271185e4100886","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Airship-in-a-pod produces the following outputs:"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"* The airshipctl/and other related repo and associated binary used with the deployment"},{"line_number":167,"context_line":"* A tarball containing the generated ephemeral ISO, as well as the"},{"line_number":168,"context_line":"  configuration used during generation."},{"line_number":169,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":43,"id":"0cb10beb_e9e70ee2","line":166,"range":{"start_line":166,"start_character":2,"end_line":166,"end_character":86},"in_reply_to":"2f9fa057_af4fa254","updated":"2021-05-26 11:18:54.000000000","message":"Done","commit_id":"9dd89ed1309b6f8149620b1428424ee28a9c7011"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"032bde263d6214b6bc1920c4bb0b5f63c84dfb83","unresolved":true,"context_lines":[{"line_number":37,"context_line":"#### Deploy the Pod"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"```"},{"line_number":40,"context_line":"kubectl apply -f airship-in-a-pod.yaml"},{"line_number":41,"context_line":"```"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"#### View Pod Logs"}],"source_content_type":"text/x-gfm","patch_set":56,"id":"9a7fe146_6128725f","side":"PARENT","line":40,"range":{"start_line":40,"start_character":17,"end_line":40,"end_character":38},"updated":"2021-06-15 20:00:54.000000000","message":"Should the path be changed to airship-in-a-pod/examples/base/airship-in-a-pod.yaml?","commit_id":"6aa3d1121f67dd17f149bc8b8409b9a2f83216c8"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"b94b8f0029d627d685dde5bbd9241931ab136348","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#### Deploy the Pod"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"```"},{"line_number":40,"context_line":"kubectl apply -f airship-in-a-pod.yaml"},{"line_number":41,"context_line":"```"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"#### View Pod Logs"}],"source_content_type":"text/x-gfm","patch_set":56,"id":"c4c58f77_f36d3fb0","side":"PARENT","line":40,"range":{"start_line":40,"start_character":17,"end_line":40,"end_character":38},"in_reply_to":"9a7fe146_6128725f","updated":"2021-06-16 08:17:51.000000000","message":"No. Now i have introduced kustomize manifest for each module (airshipctl/treasuremap). This should be now \u0027kustomize build . | kubectl apply -f -\u0027 as in the latest update.","commit_id":"6aa3d1121f67dd17f149bc8b8409b9a2f83216c8"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"8571bcb15c6bc4d91380342def90fe92da2f2de0","unresolved":true,"context_lines":[{"line_number":57,"context_line":"Within the environment with appropriate env variables set, run the following command."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"```"},{"line_number":60,"context_line":"sudo -E minikube start --driver\u003dnone"},{"line_number":61,"context_line":"```"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"## Usage"}],"source_content_type":"text/x-gfm","patch_set":56,"id":"747ea759_ac632462","line":60,"range":{"start_line":60,"start_character":32,"end_line":60,"end_character":36},"updated":"2021-06-15 18:30:16.000000000","message":"Need to define other values if not native Linux","commit_id":"764c9094a3829f82eda6d83a7e53854c62c3b7fa"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"b94b8f0029d627d685dde5bbd9241931ab136348","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Within the environment with appropriate env variables set, run the following command."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"```"},{"line_number":60,"context_line":"sudo -E minikube start --driver\u003dnone"},{"line_number":61,"context_line":"```"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"## Usage"}],"source_content_type":"text/x-gfm","patch_set":56,"id":"7aa985af_1899a3b5","line":60,"range":{"start_line":60,"start_character":32,"end_line":60,"end_character":36},"in_reply_to":"747ea759_ac632462","updated":"2021-06-16 08:17:51.000000000","message":"The current scope of my PS is Linux. There are PS being worked by Ian Howell to cover\nKind and VM, i think the changes will be made by the corresponding PS.","commit_id":"764c9094a3829f82eda6d83a7e53854c62c3b7fa"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"8571bcb15c6bc4d91380342def90fe92da2f2de0","unresolved":true,"context_lines":[{"line_number":63,"context_line":"## Usage"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Since Airship in a Pod is just a pod definition, deploying and using it is as"},{"line_number":66,"context_line":"simple as deploying and using any Kubernetes pod using kustomize tool."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"### Pod configuration for airshipctl"}],"source_content_type":"text/x-gfm","patch_set":56,"id":"ee0ad353_28592e1d","line":66,"range":{"start_line":66,"start_character":49,"end_line":66,"end_character":55},"updated":"2021-06-15 18:30:16.000000000","message":"Typo: using the","commit_id":"764c9094a3829f82eda6d83a7e53854c62c3b7fa"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"b94b8f0029d627d685dde5bbd9241931ab136348","unresolved":false,"context_lines":[{"line_number":63,"context_line":"## Usage"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Since Airship in a Pod is just a pod definition, deploying and using it is as"},{"line_number":66,"context_line":"simple as deploying and using any Kubernetes pod using kustomize tool."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"### Pod configuration for airshipctl"}],"source_content_type":"text/x-gfm","patch_set":56,"id":"a212c7c2_4248e811","line":66,"range":{"start_line":66,"start_character":49,"end_line":66,"end_character":55},"in_reply_to":"ee0ad353_28592e1d","updated":"2021-06-16 08:17:51.000000000","message":"Done","commit_id":"764c9094a3829f82eda6d83a7e53854c62c3b7fa"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"8571bcb15c6bc4d91380342def90fe92da2f2de0","unresolved":true,"context_lines":[{"line_number":69,"context_line":"### Pod configuration for airshipctl"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Within the examples/airshipctl directory, update the existing patchset.yaml"},{"line_number":73,"context_line":"file to reflect the airshipctl branch reference as required."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"filepath : airshipctl/tools/airship-in-a-pod/examples/airshipctl/patchset.yaml"}],"source_content_type":"text/x-gfm","patch_set":56,"id":"862a8884_a3a08f57","line":72,"range":{"start_line":72,"start_character":11,"end_line":72,"end_character":30},"updated":"2021-06-15 18:30:16.000000000","message":"No such directory","commit_id":"764c9094a3829f82eda6d83a7e53854c62c3b7fa"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"b94b8f0029d627d685dde5bbd9241931ab136348","unresolved":false,"context_lines":[{"line_number":69,"context_line":"### Pod configuration for airshipctl"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Within the examples/airshipctl directory, update the existing patchset.yaml"},{"line_number":73,"context_line":"file to reflect the airshipctl branch reference as required."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"filepath : airshipctl/tools/airship-in-a-pod/examples/airshipctl/patchset.yaml"}],"source_content_type":"text/x-gfm","patch_set":56,"id":"aa46a4dc_f5eb99c3","line":72,"range":{"start_line":72,"start_character":11,"end_line":72,"end_character":30},"in_reply_to":"862a8884_a3a08f57","updated":"2021-06-16 08:17:51.000000000","message":"It was introduced sometime back. The latest PS has the following.\n\nekuamaj@as12-32:~/go/src/opendev.org/airship/airshipctl/tools/airship-in-a-pod/examples$ tree\n.\n├── airshipctl\n│   ├── kustomization.yaml\n│   └── patchset.yaml\n├── base\n│   ├── airship-in-a-pod.yaml\n│   └── kustomization.yaml\n└── treasuremap\n    ├── kustomization.yaml\n    └── patchset.yaml","commit_id":"764c9094a3829f82eda6d83a7e53854c62c3b7fa"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"8571bcb15c6bc4d91380342def90fe92da2f2de0","unresolved":true,"context_lines":[{"line_number":72,"context_line":"Within the examples/airshipctl directory, update the existing patchset.yaml"},{"line_number":73,"context_line":"file to reflect the airshipctl branch reference as required."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"filepath : airshipctl/tools/airship-in-a-pod/examples/airshipctl/patchset.yaml"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"```"}],"source_content_type":"text/x-gfm","patch_set":56,"id":"0e2a0968_7745f52c","line":75,"range":{"start_line":75,"start_character":11,"end_line":75,"end_character":78},"updated":"2021-06-15 18:30:16.000000000","message":"No such directory","commit_id":"764c9094a3829f82eda6d83a7e53854c62c3b7fa"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"b94b8f0029d627d685dde5bbd9241931ab136348","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Within the examples/airshipctl directory, update the existing patchset.yaml"},{"line_number":73,"context_line":"file to reflect the airshipctl branch reference as required."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"filepath : airshipctl/tools/airship-in-a-pod/examples/airshipctl/patchset.yaml"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"```"}],"source_content_type":"text/x-gfm","patch_set":56,"id":"fca269ca_a64b9475","line":75,"range":{"start_line":75,"start_character":11,"end_line":75,"end_character":78},"in_reply_to":"0e2a0968_7745f52c","updated":"2021-06-16 08:17:51.000000000","message":"It was introduced sometime back. The latest PS has the following.\n\nekuamaj@as12-32:~/go/src/opendev.org/airship/airshipctl/tools/airship-in-a-pod/examples$ tree\n.\n├── airshipctl\n│   ├── kustomization.yaml\n│   └── patchset.yaml\n├── base\n│   ├── airship-in-a-pod.yaml\n│   └── kustomization.yaml\n└── treasuremap\n    ├── kustomization.yaml\n    └── patchset.yaml","commit_id":"764c9094a3829f82eda6d83a7e53854c62c3b7fa"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"8571bcb15c6bc4d91380342def90fe92da2f2de0","unresolved":true,"context_lines":[{"line_number":107,"context_line":"#### Deploy the Pod"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Once patchset.yaml for either airshipctl/treasuremap is ready, run the following"},{"line_number":110,"context_line":"command against the running minikube cluster from the respective directory"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"For example to run AIAP with treasuremap manifests, run the following commands."},{"line_number":113,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":56,"id":"df8816e2_f2cf9336","line":110,"range":{"start_line":110,"start_character":54,"end_line":110,"end_character":65},"updated":"2021-06-15 18:30:16.000000000","message":"Respective -- directory from where minikube was started or the airshipctl/treasuremap","commit_id":"764c9094a3829f82eda6d83a7e53854c62c3b7fa"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"b94b8f0029d627d685dde5bbd9241931ab136348","unresolved":false,"context_lines":[{"line_number":107,"context_line":"#### Deploy the Pod"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Once patchset.yaml for either airshipctl/treasuremap is ready, run the following"},{"line_number":110,"context_line":"command against the running minikube cluster from the respective directory"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"For example to run AIAP with treasuremap manifests, run the following commands."},{"line_number":113,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":56,"id":"c64ec6d3_0f431d1c","line":110,"range":{"start_line":110,"start_character":54,"end_line":110,"end_character":65},"in_reply_to":"df8816e2_f2cf9336","updated":"2021-06-16 08:17:51.000000000","message":"rephrased.","commit_id":"764c9094a3829f82eda6d83a7e53854c62c3b7fa"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"35d7a876f27a3e8af2062c495aab6031dbea1180","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"## Prerequisites"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"In order to deploy Airship in a Pod for development, you must first have a"},{"line_number":27,"context_line":"working Kubernetes cluster. This guide assumes that a developer will deploy"},{"line_number":28,"context_line":"using [minikube](https://minikube.sigs.k8s.io/docs/start/)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"### Setup shared directory"}],"source_content_type":"text/x-gfm","patch_set":59,"id":"706b77de_71c4dc7d","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":27},"updated":"2021-06-21 17:55:49.000000000","message":"For me, this part was a little unclear. I read it as I needed a running minikube k8s cluster before running any of the subsequent steps, so I ran `minikube start` only to later see on line 60 that it says to run `sudo -E minikube start --driver\u003dnone` - so I had to stop my minikube cluster and re-run it as stated on line 60. I think an earlier mention of starting minikube with the driver set as none would be better.","commit_id":"bb948abc76778bfd913def9f349bc61bdbf35a73"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"a93432e666a1a2cada174a48ec0159bd50716f0b","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"## Prerequisites"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"In order to deploy Airship in a Pod for development, you must first have a"},{"line_number":27,"context_line":"working Kubernetes cluster. This guide assumes that a developer will deploy"},{"line_number":28,"context_line":"using [minikube](https://minikube.sigs.k8s.io/docs/start/)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"### Setup shared directory"}],"source_content_type":"text/x-gfm","patch_set":59,"id":"dffcb05b_3f85897c","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":27},"in_reply_to":"706b77de_71c4dc7d","updated":"2021-06-22 02:57:39.000000000","message":"I have removed the pre-req as it had stayed by oversigth. Thanks for the comment.","commit_id":"bb948abc76778bfd913def9f349bc61bdbf35a73"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"4d83e1597a76c70a586efd11363494641d2fd928","unresolved":true,"context_lines":[{"line_number":5,"context_line":"consists of the following \"Task\" containers:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"* `artifact-setup`: This container builds the airshipctl binary and makes it"},{"line_number":8,"context_line":"  available to the other containers. Also based on the configuration provided"},{"line_number":9,"context_line":"  in the pod manifest, airshipctl/treasuremap(based on the usecase) git repositories"},{"line_number":10,"context_line":"  will be downloaded and the required commit will be checked out."},{"line_number":11,"context_line":"* `infra-builder`: This container creates the various virtual networks and"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"8b306405_bec574eb","line":8,"range":{"start_line":8,"start_character":37,"end_line":8,"end_character":41},"updated":"2021-06-23 16:07:13.000000000","message":"Typo missing comma after \"Also\"","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"428772bdbc9514d1b372b923a28ef33775c602cc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"consists of the following \"Task\" containers:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"* `artifact-setup`: This container builds the airshipctl binary and makes it"},{"line_number":8,"context_line":"  available to the other containers. Also based on the configuration provided"},{"line_number":9,"context_line":"  in the pod manifest, airshipctl/treasuremap(based on the usecase) git repositories"},{"line_number":10,"context_line":"  will be downloaded and the required commit will be checked out."},{"line_number":11,"context_line":"* `infra-builder`: This container creates the various virtual networks and"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"c832fa6f_f720f8ca","line":8,"range":{"start_line":8,"start_character":37,"end_line":8,"end_character":41},"in_reply_to":"8b306405_bec574eb","updated":"2021-06-23 17:45:37.000000000","message":"Done","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"4d83e1597a76c70a586efd11363494641d2fd928","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"* `artifact-setup`: This container builds the airshipctl binary and makes it"},{"line_number":8,"context_line":"  available to the other containers. Also based on the configuration provided"},{"line_number":9,"context_line":"  in the pod manifest, airshipctl/treasuremap(based on the usecase) git repositories"},{"line_number":10,"context_line":"  will be downloaded and the required commit will be checked out."},{"line_number":11,"context_line":"* `infra-builder`: This container creates the various virtual networks and"},{"line_number":12,"context_line":"  machines required for an Airship deployment"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"ff9ab207_bebd91be","line":9,"range":{"start_line":9,"start_character":9,"end_line":9,"end_character":21},"updated":"2021-06-23 16:07:13.000000000","message":"where is this manifest located?","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"428772bdbc9514d1b372b923a28ef33775c602cc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"* `artifact-setup`: This container builds the airshipctl binary and makes it"},{"line_number":8,"context_line":"  available to the other containers. Also based on the configuration provided"},{"line_number":9,"context_line":"  in the pod manifest, airshipctl/treasuremap(based on the usecase) git repositories"},{"line_number":10,"context_line":"  will be downloaded and the required commit will be checked out."},{"line_number":11,"context_line":"* `infra-builder`: This container creates the various virtual networks and"},{"line_number":12,"context_line":"  machines required for an Airship deployment"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"542b365d_2c28d45a","line":9,"range":{"start_line":9,"start_character":9,"end_line":9,"end_character":21},"in_reply_to":"ff9ab207_bebd91be","updated":"2021-06-23 17:45:37.000000000","message":"The manifest could be anyplace from where kustomize build could be run. The examples directory is just for reference.","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"4d83e1597a76c70a586efd11363494641d2fd928","unresolved":true,"context_lines":[{"line_number":7,"context_line":"* `artifact-setup`: This container builds the airshipctl binary and makes it"},{"line_number":8,"context_line":"  available to the other containers. Also based on the configuration provided"},{"line_number":9,"context_line":"  in the pod manifest, airshipctl/treasuremap(based on the usecase) git repositories"},{"line_number":10,"context_line":"  will be downloaded and the required commit will be checked out."},{"line_number":11,"context_line":"* `infra-builder`: This container creates the various virtual networks and"},{"line_number":12,"context_line":"  machines required for an Airship deployment"},{"line_number":13,"context_line":"* `runner`: The runner container is the \"meat\" of the pod, and executes the"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"f51c4490_cf024a9c","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":44},"updated":"2021-06-23 16:07:13.000000000","message":"What is the \"required commit\"?","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"f21048994810a57071ae66ad67ddd58dcd9adb35","unresolved":false,"context_lines":[{"line_number":7,"context_line":"* `artifact-setup`: This container builds the airshipctl binary and makes it"},{"line_number":8,"context_line":"  available to the other containers. Also based on the configuration provided"},{"line_number":9,"context_line":"  in the pod manifest, airshipctl/treasuremap(based on the usecase) git repositories"},{"line_number":10,"context_line":"  will be downloaded and the required commit will be checked out."},{"line_number":11,"context_line":"* `infra-builder`: This container creates the various virtual networks and"},{"line_number":12,"context_line":"  machines required for an Airship deployment"},{"line_number":13,"context_line":"* `runner`: The runner container is the \"meat\" of the pod, and executes the"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"c605063e_09294d3c","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":44},"in_reply_to":"39134062_d3f378da","updated":"2021-06-23 19:00:08.000000000","message":"Done. Rephrased the sentence to include it.","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"c148673ee5de332f22873c7c6d722bbf2da597c3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"* `artifact-setup`: This container builds the airshipctl binary and makes it"},{"line_number":8,"context_line":"  available to the other containers. Also based on the configuration provided"},{"line_number":9,"context_line":"  in the pod manifest, airshipctl/treasuremap(based on the usecase) git repositories"},{"line_number":10,"context_line":"  will be downloaded and the required commit will be checked out."},{"line_number":11,"context_line":"* `infra-builder`: This container creates the various virtual networks and"},{"line_number":12,"context_line":"  machines required for an Airship deployment"},{"line_number":13,"context_line":"* `runner`: The runner container is the \"meat\" of the pod, and executes the"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"39134062_d3f378da","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":44},"in_reply_to":"b07c4802_e36c7eb3","updated":"2021-06-23 18:10:27.000000000","message":"Manoj, Thanks. Can you state this.","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"428772bdbc9514d1b372b923a28ef33775c602cc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"* `artifact-setup`: This container builds the airshipctl binary and makes it"},{"line_number":8,"context_line":"  available to the other containers. Also based on the configuration provided"},{"line_number":9,"context_line":"  in the pod manifest, airshipctl/treasuremap(based on the usecase) git repositories"},{"line_number":10,"context_line":"  will be downloaded and the required commit will be checked out."},{"line_number":11,"context_line":"* `infra-builder`: This container creates the various virtual networks and"},{"line_number":12,"context_line":"  machines required for an Airship deployment"},{"line_number":13,"context_line":"* `runner`: The runner container is the \"meat\" of the pod, and executes the"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"b07c4802_e36c7eb3","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":44},"in_reply_to":"f51c4490_cf024a9c","updated":"2021-06-23 17:45:37.000000000","message":"The tag or commit id for which the manifests need to run against.","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"4d83e1597a76c70a586efd11363494641d2fd928","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"### Setup shared directory"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Setup the following directory with appropriate r+w permissions."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"```"},{"line_number":29,"context_line":"sudo mkdir /opt/.airship"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"5b3fe847_cab3c1c2","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":6},"updated":"2021-06-23 16:07:13.000000000","message":"Create?","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"428772bdbc9514d1b372b923a28ef33775c602cc","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"### Setup shared directory"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Setup the following directory with appropriate r+w permissions."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"```"},{"line_number":29,"context_line":"sudo mkdir /opt/.airship"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"4e21720f_028f1c78","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":6},"in_reply_to":"5b3fe847_cab3c1c2","updated":"2021-06-23 17:45:37.000000000","message":"Done","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"4d83e1597a76c70a586efd11363494641d2fd928","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"### Environment variable setup"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"If you are within a proxy environment. Ensure that the following environment"},{"line_number":35,"context_line":"variables are defined. And NO_PROXY has the IP address which minikube uses."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"```"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"2e329bad_0806234b","line":34,"range":{"start_line":34,"start_character":37,"end_line":34,"end_character":45},"updated":"2021-06-23 16:07:13.000000000","message":"\", ensure\"","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"428772bdbc9514d1b372b923a28ef33775c602cc","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"### Environment variable setup"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"If you are within a proxy environment. Ensure that the following environment"},{"line_number":35,"context_line":"variables are defined. And NO_PROXY has the IP address which minikube uses."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"```"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"efb63a07_7198cce1","line":34,"range":{"start_line":34,"start_character":37,"end_line":34,"end_character":45},"in_reply_to":"2e329bad_0806234b","updated":"2021-06-23 17:45:37.000000000","message":"Done","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"4d83e1597a76c70a586efd11363494641d2fd928","unresolved":true,"context_lines":[{"line_number":32,"context_line":"### Environment variable setup"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"If you are within a proxy environment. Ensure that the following environment"},{"line_number":35,"context_line":"variables are defined. And NO_PROXY has the IP address which minikube uses."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"```"},{"line_number":38,"context_line":"export HTTP_PROXY\u003dhttp://username:password@host:port"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"4d8b487b_8e03b3d8","line":35,"range":{"start_line":35,"start_character":21,"end_line":35,"end_character":26},"updated":"2021-06-23 16:07:13.000000000","message":"\", and\"","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"4d83e1597a76c70a586efd11363494641d2fd928","unresolved":true,"context_lines":[{"line_number":32,"context_line":"### Environment variable setup"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"If you are within a proxy environment. Ensure that the following environment"},{"line_number":35,"context_line":"variables are defined. And NO_PROXY has the IP address which minikube uses."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"```"},{"line_number":38,"context_line":"export HTTP_PROXY\u003dhttp://username:password@host:port"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"6cf1bbc8_31b757fd","line":35,"range":{"start_line":35,"start_character":44,"end_line":35,"end_character":74},"updated":"2021-06-23 16:07:13.000000000","message":"Can we add a link to help as to where someone would find the minikube IP","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"4d83e1597a76c70a586efd11363494641d2fd928","unresolved":true,"context_lines":[{"line_number":32,"context_line":"### Environment variable setup"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"If you are within a proxy environment. Ensure that the following environment"},{"line_number":35,"context_line":"variables are defined. And NO_PROXY has the IP address which minikube uses."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"```"},{"line_number":38,"context_line":"export HTTP_PROXY\u003dhttp://username:password@host:port"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"da56c7e4_6cc273f3","line":35,"range":{"start_line":35,"start_character":27,"end_line":35,"end_character":40},"updated":"2021-06-23 16:07:13.000000000","message":"should this be that \"NO_PROXY and no_proxy include\"","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"428772bdbc9514d1b372b923a28ef33775c602cc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"### Environment variable setup"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"If you are within a proxy environment. Ensure that the following environment"},{"line_number":35,"context_line":"variables are defined. And NO_PROXY has the IP address which minikube uses."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"```"},{"line_number":38,"context_line":"export HTTP_PROXY\u003dhttp://username:password@host:port"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"efb8ab70_2844f8fc","line":35,"range":{"start_line":35,"start_character":21,"end_line":35,"end_character":26},"in_reply_to":"4d8b487b_8e03b3d8","updated":"2021-06-23 17:45:37.000000000","message":"Done","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"c148673ee5de332f22873c7c6d722bbf2da597c3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"### Environment variable setup"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"If you are within a proxy environment. Ensure that the following environment"},{"line_number":35,"context_line":"variables are defined. And NO_PROXY has the IP address which minikube uses."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"```"},{"line_number":38,"context_line":"export HTTP_PROXY\u003dhttp://username:password@host:port"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"c38f0cc8_68ae8405","line":35,"range":{"start_line":35,"start_character":27,"end_line":35,"end_character":40},"in_reply_to":"4e30c4b0_e6367c0b","updated":"2021-06-23 18:10:27.000000000","message":"Manoj, don\u0027t see the comment.","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"428772bdbc9514d1b372b923a28ef33775c602cc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"### Environment variable setup"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"If you are within a proxy environment. Ensure that the following environment"},{"line_number":35,"context_line":"variables are defined. And NO_PROXY has the IP address which minikube uses."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"```"},{"line_number":38,"context_line":"export HTTP_PROXY\u003dhttp://username:password@host:port"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"e91fc985_bd7e8755","line":35,"range":{"start_line":35,"start_character":44,"end_line":35,"end_character":74},"in_reply_to":"6cf1bbc8_31b757fd","updated":"2021-06-23 17:45:37.000000000","message":"Done","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"f21048994810a57071ae66ad67ddd58dcd9adb35","unresolved":false,"context_lines":[{"line_number":32,"context_line":"### Environment variable setup"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"If you are within a proxy environment. Ensure that the following environment"},{"line_number":35,"context_line":"variables are defined. And NO_PROXY has the IP address which minikube uses."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"```"},{"line_number":38,"context_line":"export HTTP_PROXY\u003dhttp://username:password@host:port"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"f60bc837_cb743b69","line":35,"range":{"start_line":35,"start_character":27,"end_line":35,"end_character":40},"in_reply_to":"c38f0cc8_68ae8405","updated":"2021-06-23 19:00:08.000000000","message":"https://review.opendev.org/c/airship/airshipctl/+/783533/41/tools/airship-in-a-pod/README.md#51\n\nHemanth Reddy wanted it to be aligned with the proxy setting in the airshipctl README.md. Hence i had changed.","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"428772bdbc9514d1b372b923a28ef33775c602cc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"### Environment variable setup"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"If you are within a proxy environment. Ensure that the following environment"},{"line_number":35,"context_line":"variables are defined. And NO_PROXY has the IP address which minikube uses."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"```"},{"line_number":38,"context_line":"export HTTP_PROXY\u003dhttp://username:password@host:port"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"4e30c4b0_e6367c0b","line":35,"range":{"start_line":35,"start_character":27,"end_line":35,"end_character":40},"in_reply_to":"da56c7e4_6cc273f3","updated":"2021-06-23 17:45:37.000000000","message":"There was a comment earlier that no_proxy is not needed.","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"4d83e1597a76c70a586efd11363494641d2fd928","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"#### To start minikube"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Within the environment with appropriate env variables set, run the following command."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"```"},{"line_number":54,"context_line":"sudo -E minikube start --driver\u003dnone"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"8b6a38e7_272b7ae1","line":51,"range":{"start_line":51,"start_character":11,"end_line":51,"end_character":23},"updated":"2021-06-23 16:07:13.000000000","message":"which \"environment\"\nI think it needs a comma after \"environment\"","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"428772bdbc9514d1b372b923a28ef33775c602cc","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"#### To start minikube"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Within the environment with appropriate env variables set, run the following command."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"```"},{"line_number":54,"context_line":"sudo -E minikube start --driver\u003dnone"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"44227621_e35b8235","line":51,"range":{"start_line":51,"start_character":11,"end_line":51,"end_character":23},"in_reply_to":"8b6a38e7_272b7ae1","updated":"2021-06-23 17:45:37.000000000","message":"Done","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"4d83e1597a76c70a586efd11363494641d2fd928","unresolved":true,"context_lines":[{"line_number":59,"context_line":"## Usage"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Since Airship in a Pod is just a pod definition, deploying and using it is as"},{"line_number":62,"context_line":"simple as deploying and using any Kubernetes pod using the kustomize tool."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"### Pod configuration for airshipctl"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"93023bbd_9a44ba88","line":62,"range":{"start_line":62,"start_character":49,"end_line":62,"end_character":55},"updated":"2021-06-23 16:07:13.000000000","message":"to avoid two \"using\" so close together it may be better to change this to \"with\"","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"428772bdbc9514d1b372b923a28ef33775c602cc","unresolved":false,"context_lines":[{"line_number":59,"context_line":"## Usage"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Since Airship in a Pod is just a pod definition, deploying and using it is as"},{"line_number":62,"context_line":"simple as deploying and using any Kubernetes pod using the kustomize tool."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"### Pod configuration for airshipctl"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"47c4b967_019ba0f2","line":62,"range":{"start_line":62,"start_character":49,"end_line":62,"end_character":55},"in_reply_to":"93023bbd_9a44ba88","updated":"2021-06-23 17:45:37.000000000","message":"Done","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"4d83e1597a76c70a586efd11363494641d2fd928","unresolved":true,"context_lines":[{"line_number":62,"context_line":"simple as deploying and using any Kubernetes pod using the kustomize tool."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"### Pod configuration for airshipctl"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Within the examples/airshipctl directory, update the existing patchset.yaml"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"286a20dd_4060afd7","line":65,"updated":"2021-06-23 16:07:13.000000000","message":"I think there are two options \"airshipctl\" or \"treasuremap\". Some text needs to be included prior to this section to indicate that and also how  to make a choice.","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"428772bdbc9514d1b372b923a28ef33775c602cc","unresolved":false,"context_lines":[{"line_number":62,"context_line":"simple as deploying and using any Kubernetes pod using the kustomize tool."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"### Pod configuration for airshipctl"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Within the examples/airshipctl directory, update the existing patchset.yaml"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"845df671_b692253c","line":65,"in_reply_to":"286a20dd_4060afd7","updated":"2021-06-23 17:45:37.000000000","message":"Added a section with Pod configuration. The option of choosing is just driven by user reqt.","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"4d83e1597a76c70a586efd11363494641d2fd928","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Within the examples/airshipctl directory, update the existing patchset.yaml"},{"line_number":69,"context_line":"file to reflect the airshipctl branch reference as required."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"filepath : airshipctl/tools/airship-in-a-pod/examples/airshipctl/patchset.yaml"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":62,"id":"196f5f59_fbe0d281","line":69,"range":{"start_line":69,"start_character":20,"end_line":69,"end_character":47},"updated":"2021-06-23 16:07:13.000000000","message":"This is document is intended for users who are likely to be unfamiliar with airship. Where would the user get this? The pathchset.yaml has multiple entries. Do all entries need to be modified or only the one listed below?","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"428772bdbc9514d1b372b923a28ef33775c602cc","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Within the examples/airshipctl directory, update the existing patchset.yaml"},{"line_number":69,"context_line":"file to reflect the airshipctl branch reference as required."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"filepath : airshipctl/tools/airship-in-a-pod/examples/airshipctl/patchset.yaml"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":62,"id":"6a14a3cf_bad13a23","line":69,"range":{"start_line":69,"start_character":20,"end_line":69,"end_character":47},"in_reply_to":"196f5f59_fbe0d281","updated":"2021-06-23 17:45:37.000000000","message":"Added links for airshipctl and treasuremap. \nAll the entries need to be updated.","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"4d83e1597a76c70a586efd11363494641d2fd928","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"For treasuremap related manifests, use the patchset.yaml from"},{"line_number":84,"context_line":"examples/treasuremap and  update the following to reflect"},{"line_number":85,"context_line":"the treasuremap branch reference and the pinned airshipctl reference"},{"line_number":86,"context_line":"as required."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"filepath : airshipctl/tools/airship-in-a-pod/examples/treasuremap/patchset.yaml"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"de611e8a_3e27fba7","line":85,"range":{"start_line":85,"start_character":41,"end_line":85,"end_character":68},"updated":"2021-06-23 16:07:13.000000000","message":"what is that? where would a user find this?\nAre only the two entries mentioned below need to be modified? If yes, please indicate.","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"c148673ee5de332f22873c7c6d722bbf2da597c3","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"For treasuremap related manifests, use the patchset.yaml from"},{"line_number":84,"context_line":"examples/treasuremap and  update the following to reflect"},{"line_number":85,"context_line":"the treasuremap branch reference and the pinned airshipctl reference"},{"line_number":86,"context_line":"as required."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"filepath : airshipctl/tools/airship-in-a-pod/examples/treasuremap/patchset.yaml"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"bda00767_03a803bc","line":85,"range":{"start_line":85,"start_character":41,"end_line":85,"end_character":68},"in_reply_to":"9a99a140_7862852d","updated":"2021-06-23 18:10:27.000000000","message":"How will someone not immersed in AS 2 know weher to get the info?","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"f21048994810a57071ae66ad67ddd58dcd9adb35","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"For treasuremap related manifests, use the patchset.yaml from"},{"line_number":84,"context_line":"examples/treasuremap and  update the following to reflect"},{"line_number":85,"context_line":"the treasuremap branch reference and the pinned airshipctl reference"},{"line_number":86,"context_line":"as required."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"filepath : airshipctl/tools/airship-in-a-pod/examples/treasuremap/patchset.yaml"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"4f1496e4_1f552951","line":85,"range":{"start_line":85,"start_character":41,"end_line":85,"end_character":68},"in_reply_to":"bda00767_03a803bc","updated":"2021-06-23 19:00:08.000000000","message":"Done. Added info on how to retrieve it.","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"428772bdbc9514d1b372b923a28ef33775c602cc","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"For treasuremap related manifests, use the patchset.yaml from"},{"line_number":84,"context_line":"examples/treasuremap and  update the following to reflect"},{"line_number":85,"context_line":"the treasuremap branch reference and the pinned airshipctl reference"},{"line_number":86,"context_line":"as required."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"filepath : airshipctl/tools/airship-in-a-pod/examples/treasuremap/patchset.yaml"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"9a99a140_7862852d","line":85,"range":{"start_line":85,"start_character":41,"end_line":85,"end_character":68},"in_reply_to":"de611e8a_3e27fba7","updated":"2021-06-23 17:45:37.000000000","message":"This is the version of airshipctl which will work fine with treasuremap. Currently the option is used in the zuul jobs. Later possibly it will be derived from release docs (i assume)","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"4d83e1597a76c70a586efd11363494641d2fd928","unresolved":true,"context_lines":[{"line_number":105,"context_line":"Once patchset.yaml for either airshipctl/treasuremap is ready, run the following"},{"line_number":106,"context_line":"command against the running minikube cluster as shown below."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"For example to run AIAP with treasuremap manifests, run the following commands."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"```"},{"line_number":111,"context_line":"cd tools/airship-in-a-pod/examples/treasuremap"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"806db17c_2394d9ad","line":108,"range":{"start_line":108,"start_character":29,"end_line":108,"end_character":50},"updated":"2021-06-23 16:07:13.000000000","message":"both treasuremap and airshipctl commands should be provided. For example,\n\ncd tools/airship-in-a-pod/examples/{either airshipctl or treasuremap}\n\nor within each of the sections specify a variable and use that variable within the cd command","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"428772bdbc9514d1b372b923a28ef33775c602cc","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Once patchset.yaml for either airshipctl/treasuremap is ready, run the following"},{"line_number":106,"context_line":"command against the running minikube cluster as shown below."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"For example to run AIAP with treasuremap manifests, run the following commands."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"```"},{"line_number":111,"context_line":"cd tools/airship-in-a-pod/examples/treasuremap"}],"source_content_type":"text/x-gfm","patch_set":62,"id":"eaed5771_22fa0ade","line":108,"range":{"start_line":108,"start_character":29,"end_line":108,"end_character":50},"in_reply_to":"806db17c_2394d9ad","updated":"2021-06-23 17:45:37.000000000","message":"Done","commit_id":"80f39f8b8dcf430d8621f4544406e9c6f289be31"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"89b9ec5472719c18290f6a953c5673528696f6a4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":64,"id":"d5ca44f5_fc27a8e5","updated":"2021-06-23 19:27:30.000000000","message":"Does nested virtualization have to be enabled? I ran into issues when I did not have it enabled, so maybe worth mentioning here as a prerequisite -if it is indeed needed.","commit_id":"30405c750e28ae5ec55eeb9eb568ee29a750f351"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"cf1e5b66c906ac43511263440a8474db5d140e92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":64,"id":"f8508f2c_10630eca","in_reply_to":"d5ca44f5_fc27a8e5","updated":"2021-06-23 19:45:53.000000000","message":"Thanks for the comment. I have added the same.","commit_id":"30405c750e28ae5ec55eeb9eb568ee29a750f351"}],"tools/airship-in-a-pod/airship-in-a-pod.yaml":[{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"d84120bed1b15e5b47ff2c37f6fb12a190051f23","unresolved":true,"context_lines":[{"line_number":332,"context_line":"        medium: \"Memory\""},{"line_number":333,"context_line":"    - name: airship-config"},{"line_number":334,"context_line":"      hostPath:"},{"line_number":335,"context_line":"        path: /root/.airship"},{"line_number":336,"context_line":"    - name: run"},{"line_number":337,"context_line":"      emptyDir:"},{"line_number":338,"context_line":"        medium: \"Memory\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"e5687dc7_21761809","line":335,"range":{"start_line":335,"start_character":14,"end_line":335,"end_character":28},"updated":"2021-04-06 20:07:28.000000000","message":"Can you try to specify some other shared directory? I dont think root is the best here.","commit_id":"9e8d62ba1c45b4d6735c864f9d4c191781157095"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"d9d56b3fa46811d75d0dc64873b1074d92ccf7ea","unresolved":true,"context_lines":[{"line_number":332,"context_line":"        medium: \"Memory\""},{"line_number":333,"context_line":"    - name: airship-config"},{"line_number":334,"context_line":"      hostPath:"},{"line_number":335,"context_line":"        path: /root/.airship"},{"line_number":336,"context_line":"    - name: run"},{"line_number":337,"context_line":"      emptyDir:"},{"line_number":338,"context_line":"        medium: \"Memory\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"4bd3baf4_32460f0e","line":335,"range":{"start_line":335,"start_character":14,"end_line":335,"end_character":28},"updated":"2021-04-07 03:48:44.000000000","message":"please try to change it to something more secure :)","commit_id":"64f206c40469926d9c22be514dda485876038020"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"3dd30438191e48cd42d9fce873a648d4575f1b08","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        medium: \"Memory\""},{"line_number":333,"context_line":"    - name: airship-config"},{"line_number":334,"context_line":"      hostPath:"},{"line_number":335,"context_line":"        path: /root/.airship"},{"line_number":336,"context_line":"    - name: run"},{"line_number":337,"context_line":"      emptyDir:"},{"line_number":338,"context_line":"        medium: \"Memory\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"cfa6c9d3_b1604cd4","line":335,"range":{"start_line":335,"start_character":14,"end_line":335,"end_character":28},"in_reply_to":"4bd3baf4_32460f0e","updated":"2021-04-08 09:59:31.000000000","message":"Changed to /opt/.airship","commit_id":"64f206c40469926d9c22be514dda485876038020"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"04b567d4c4e3b1896a15218a06669230fb09f090","unresolved":true,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"  - name: artifact-setup"},{"line_number":186,"context_line":"    image: quay.io/airshipit/aiap-artifact-setup:latest"},{"line_number":187,"context_line":"    imagePullPolicy: Never"},{"line_number":188,"context_line":"    command:"},{"line_number":189,"context_line":"      - bash"},{"line_number":190,"context_line":"      - -cex"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"0f399583_7eabb594","line":187,"range":{"start_line":187,"start_character":4,"end_line":187,"end_character":26},"updated":"2021-04-09 18:30:57.000000000","message":"This shouldn\u0027t be here. We want an AIAP deployment to be as easy as \"kubectl apply -f airship-in-a-pod.yaml\" with as little overhead as possible.","commit_id":"2cf3ba7b3aae7d5532fd0db8a229f4bc8fc30566"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"474cf531658c1c23203376a43846caa37902da4c","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"  - name: artifact-setup"},{"line_number":186,"context_line":"    image: quay.io/airshipit/aiap-artifact-setup:latest"},{"line_number":187,"context_line":"    imagePullPolicy: Never"},{"line_number":188,"context_line":"    command:"},{"line_number":189,"context_line":"      - bash"},{"line_number":190,"context_line":"      - -cex"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"2062afae_56bb19ba","line":187,"range":{"start_line":187,"start_character":4,"end_line":187,"end_character":26},"in_reply_to":"0f399583_7eabb594","updated":"2021-04-12 18:42:13.000000000","message":"Removed now. I will need the image to be pushed to quay.io/airship.","commit_id":"2cf3ba7b3aae7d5532fd0db8a229f4bc8fc30566"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"d213a5a0a207e02bacdda68fb302a8d331c6964e","unresolved":true,"context_lines":[{"line_number":206,"context_line":"        value: /opt/aiap-artifacts"},{"line_number":207,"context_line":"      - name: REPO_URL"},{"line_number":208,"context_line":"        value: https://review.opendev.org/airship/airshipctl"},{"line_number":209,"context_line":"      - name: REPO_REF"},{"line_number":210,"context_line":"        value: master"},{"line_number":211,"context_line":"      - name: REPO_NAME"},{"line_number":212,"context_line":"        value: airshipctl"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"cc1973e6_8b40df51","line":209,"range":{"start_line":209,"start_character":14,"end_line":209,"end_character":22},"updated":"2021-04-14 16:15:33.000000000","message":"The Treasuremap deployment scripts pin to airshipctl manifests using this environment variable (normally set by zuul):\nhttps://github.com/airshipit/treasuremap/blob/v2/zuul.d/projects.yaml#L17\n\nWithout that pin, I think AIAP-treasuremap will fail whenever the treasuremap manifests are incompatible with master airshipctl manifests (which happens pretty frequently).  I\u0027m wondering whether we need something like these env vars:\n\nAIRSHIPCTL_REF (exported to the deployment scripts too)\nMANIFEST_REPO_REF (which might be optional or ignored if MANIFEST_REPO\u003dairshipctl)\nMANIFEST_REPO (which might be airshipctl)\n\nAIRSHIPCTL_REF could also be used to build the binary, which would solve the issue I mentioned on a different file.","commit_id":"2cf3ba7b3aae7d5532fd0db8a229f4bc8fc30566"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"6fe1722d717c4f7727486db80f276a4a788e670e","unresolved":true,"context_lines":[{"line_number":206,"context_line":"        value: /opt/aiap-artifacts"},{"line_number":207,"context_line":"      - name: REPO_URL"},{"line_number":208,"context_line":"        value: https://review.opendev.org/airship/airshipctl"},{"line_number":209,"context_line":"      - name: REPO_REF"},{"line_number":210,"context_line":"        value: master"},{"line_number":211,"context_line":"      - name: REPO_NAME"},{"line_number":212,"context_line":"        value: airshipctl"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"d63e1225_9c2d7093","line":209,"range":{"start_line":209,"start_character":14,"end_line":209,"end_character":22},"in_reply_to":"cc1973e6_8b40df51","updated":"2021-04-22 08:28:14.000000000","message":"I have added AIRSHIPCTL_REF as an additional env variable. The current env names have \nbeen changed to MANIFEST_REPO..\nAlso i am using AIRSHIPCTL_REF for generating the airshipctl binary now.","commit_id":"2cf3ba7b3aae7d5532fd0db8a229f4bc8fc30566"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"04b567d4c4e3b1896a15218a06669230fb09f090","unresolved":true,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"  - name: runner"},{"line_number":269,"context_line":"    image: quay.io/airshipit/aiap-runner:latest"},{"line_number":270,"context_line":"    imagePullPolicy: Never"},{"line_number":271,"context_line":"    command:"},{"line_number":272,"context_line":"      - bash"},{"line_number":273,"context_line":"      - -cex"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"04337f92_4234ffee","line":270,"range":{"start_line":270,"start_character":4,"end_line":270,"end_character":26},"updated":"2021-04-09 18:30:57.000000000","message":"same as above","commit_id":"2cf3ba7b3aae7d5532fd0db8a229f4bc8fc30566"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"474cf531658c1c23203376a43846caa37902da4c","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"  - name: runner"},{"line_number":269,"context_line":"    image: quay.io/airshipit/aiap-runner:latest"},{"line_number":270,"context_line":"    imagePullPolicy: Never"},{"line_number":271,"context_line":"    command:"},{"line_number":272,"context_line":"      - bash"},{"line_number":273,"context_line":"      - -cex"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"81923e8a_8d891d2c","line":270,"range":{"start_line":270,"start_character":4,"end_line":270,"end_character":26},"in_reply_to":"04337f92_4234ffee","updated":"2021-04-12 18:42:13.000000000","message":"Done","commit_id":"2cf3ba7b3aae7d5532fd0db8a229f4bc8fc30566"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"f7d8dcab68ac9b6306ff6f99257a3b9c4b043b25","unresolved":true,"context_lines":[{"line_number":330,"context_line":"    - name: tmp"},{"line_number":331,"context_line":"      emptyDir:"},{"line_number":332,"context_line":"        medium: \"Memory\""},{"line_number":333,"context_line":"    - name: airship-config"},{"line_number":334,"context_line":"      hostPath:"},{"line_number":335,"context_line":"        path: /opt/.airship"},{"line_number":336,"context_line":"    - name: run"},{"line_number":337,"context_line":"      emptyDir:"},{"line_number":338,"context_line":"        medium: \"Memory\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"e2771a52_bbbaeed1","line":335,"range":{"start_line":333,"start_character":0,"end_line":335,"end_character":27},"updated":"2021-04-09 18:14:53.000000000","message":"this looks better, but i would suggest in the next patchset to even try emptyDir , so that we won\u0027t care at all which directory is used.","commit_id":"2cf3ba7b3aae7d5532fd0db8a229f4bc8fc30566"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"474cf531658c1c23203376a43846caa37902da4c","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    - name: tmp"},{"line_number":331,"context_line":"      emptyDir:"},{"line_number":332,"context_line":"        medium: \"Memory\""},{"line_number":333,"context_line":"    - name: airship-config"},{"line_number":334,"context_line":"      hostPath:"},{"line_number":335,"context_line":"        path: /opt/.airship"},{"line_number":336,"context_line":"    - name: run"},{"line_number":337,"context_line":"      emptyDir:"},{"line_number":338,"context_line":"        medium: \"Memory\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"8d42f1c0_ddaeca1d","line":335,"range":{"start_line":333,"start_character":0,"end_line":335,"end_character":27},"in_reply_to":"4bb82e59_cc230b89","updated":"2021-04-12 18:42:13.000000000","message":"Added emtpyDir and it worked fine.","commit_id":"2cf3ba7b3aae7d5532fd0db8a229f4bc8fc30566"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"04b567d4c4e3b1896a15218a06669230fb09f090","unresolved":true,"context_lines":[{"line_number":330,"context_line":"    - name: tmp"},{"line_number":331,"context_line":"      emptyDir:"},{"line_number":332,"context_line":"        medium: \"Memory\""},{"line_number":333,"context_line":"    - name: airship-config"},{"line_number":334,"context_line":"      hostPath:"},{"line_number":335,"context_line":"        path: /opt/.airship"},{"line_number":336,"context_line":"    - name: run"},{"line_number":337,"context_line":"      emptyDir:"},{"line_number":338,"context_line":"        medium: \"Memory\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"4bb82e59_cc230b89","line":335,"range":{"start_line":333,"start_character":0,"end_line":335,"end_character":27},"in_reply_to":"e2771a52_bbbaeed1","updated":"2021-04-09 18:30:57.000000000","message":"+1","commit_id":"2cf3ba7b3aae7d5532fd0db8a229f4bc8fc30566"}],"tools/airship-in-a-pod/artifact-setup/Dockerfile":[{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"9cdfd6ad26fc7cdd67159e5474660a1dd358400b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"FROM ianhowell/base:latest"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"SHELL [\"bash\", \"-exc\"]"},{"line_number":4,"context_line":"ENV DEBIAN_FRONTEND noninteractive"}],"source_content_type":"text/x-dockerfile","patch_set":41,"id":"04d81f1d_e043d15b","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":26},"updated":"2021-05-12 03:18:07.000000000","message":"Anything special with this image?","commit_id":"3d834f3c26cd273da86080590e3b949a6e99532e"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"7a4a5d06b5032a73b02ff6216699c40f3583b53f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM ianhowell/base:latest"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"SHELL [\"bash\", \"-exc\"]"},{"line_number":4,"context_line":"ENV DEBIAN_FRONTEND noninteractive"}],"source_content_type":"text/x-dockerfile","patch_set":41,"id":"04e14b12_6d3255f4","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":26},"in_reply_to":"04d81f1d_e043d15b","updated":"2021-05-13 13:49:28.000000000","message":"This being changed in a new PS https://review.opendev.org/c/airship/airshipctl/+/784797","commit_id":"3d834f3c26cd273da86080590e3b949a6e99532e"}],"tools/airship-in-a-pod/artifact-setup/assets/entrypoint.sh":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"04b567d4c4e3b1896a15218a06669230fb09f090","unresolved":true,"context_lines":[{"line_number":38,"context_line":"  printf \"Waiting 30 seconds for the libvirt, sushy, and docker services to be ready\\n\""},{"line_number":39,"context_line":"  sleep 30"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  cloneRepo $REPO_NAME $REPO_URL $REPO_REF"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if [ $REPO_NAME !\u003d  \"airshipctl\" ]"},{"line_number":44,"context_line":"  then"},{"line_number":45,"context_line":"\t  cloneRepo airshipctl https://review.opendev.org/airship/airshipctl master"},{"line_number":46,"context_line":"  fi"},{"line_number":47,"context_line":"  cd $ARTIFACTS_DIR/$REPO_NAME"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  ./tools/deployment/21_systemwide_executable.sh"}],"source_content_type":"text/x-sh","patch_set":28,"id":"e6821de9_a91cb02d","line":46,"range":{"start_line":41,"start_character":0,"end_line":46,"end_character":4},"updated":"2021-04-09 18:30:57.000000000","message":"What if a developer wants to test non-master airshipctl against a custom site? I think we still need the AIRSHIPCTL_REPO and AIRSHIPCTL_REF variables","commit_id":"2cf3ba7b3aae7d5532fd0db8a229f4bc8fc30566"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"474cf531658c1c23203376a43846caa37902da4c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  printf \"Waiting 30 seconds for the libvirt, sushy, and docker services to be ready\\n\""},{"line_number":39,"context_line":"  sleep 30"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  cloneRepo $REPO_NAME $REPO_URL $REPO_REF"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if [ $REPO_NAME !\u003d  \"airshipctl\" ]"},{"line_number":44,"context_line":"  then"},{"line_number":45,"context_line":"\t  cloneRepo airshipctl https://review.opendev.org/airship/airshipctl master"},{"line_number":46,"context_line":"  fi"},{"line_number":47,"context_line":"  cd $ARTIFACTS_DIR/$REPO_NAME"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  ./tools/deployment/21_systemwide_executable.sh"}],"source_content_type":"text/x-sh","patch_set":28,"id":"79feea3a_c0cb435c","line":46,"range":{"start_line":41,"start_character":0,"end_line":46,"end_character":4},"in_reply_to":"e6821de9_a91cb02d","updated":"2021-04-12 18:42:13.000000000","message":"In case of airshipctl, the REPO_URL/REPO_REF could be used as required(airshipctl or treasuremap). The REPO_REF could list the non-master branch.","commit_id":"2cf3ba7b3aae7d5532fd0db8a229f4bc8fc30566"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"d213a5a0a207e02bacdda68fb302a8d331c6964e","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if [ $REPO_NAME !\u003d  \"airshipctl\" ]"},{"line_number":44,"context_line":"  then"},{"line_number":45,"context_line":"\t  cloneRepo airshipctl https://review.opendev.org/airship/airshipctl master"},{"line_number":46,"context_line":"  fi"},{"line_number":47,"context_line":"  cd $ARTIFACTS_DIR/$REPO_NAME"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-sh","patch_set":30,"id":"5ad41196_656e9711","line":45,"range":{"start_line":45,"start_character":24,"end_line":45,"end_character":76},"updated":"2021-04-14 16:15:33.000000000","message":"This master branch airshipctl is only used for building the airshipctl binary, right?  And `airshipctl document pull` grabs whatever version of the manifests should be deployed?\n\nIt\u0027s possible that the new airshipctl binary might be incompatible with the old manifests.  I wonder whether we should add another environment variable, e.g. \"AIRSHIPCTL_BIN_REPO_REF\"?  I\u0027d be ok adding that in a follow-on patchset too, but I think it might be wise to add it before we hit an issue rather than after.","commit_id":"c9f14714508bbe1830028a59d39e81ff071a361f"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"6fe1722d717c4f7727486db80f276a4a788e670e","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if [ $REPO_NAME !\u003d  \"airshipctl\" ]"},{"line_number":44,"context_line":"  then"},{"line_number":45,"context_line":"\t  cloneRepo airshipctl https://review.opendev.org/airship/airshipctl master"},{"line_number":46,"context_line":"  fi"},{"line_number":47,"context_line":"  cd $ARTIFACTS_DIR/$REPO_NAME"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-sh","patch_set":30,"id":"0618f7a5_f933784d","line":45,"range":{"start_line":45,"start_character":24,"end_line":45,"end_character":76},"in_reply_to":"5ad41196_656e9711","updated":"2021-04-22 08:28:14.000000000","message":"Will AIRSHIPCTL_REF not be enough. A pinned version of airshipctl is \nsupposed to have the right airshipctl version. i have gone ahead with \nAIRSHPICTL_REF for now. Do let me know if you differ.","commit_id":"c9f14714508bbe1830028a59d39e81ff071a361f"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"9cdfd6ad26fc7cdd67159e5474660a1dd358400b","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  cloneRepo $MANIFEST_REPO_NAME $MANIFEST_REPO_URL $MANIFEST_REPO_REF"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if [ $MANIFEST_REPO_NAME !\u003d  \"airshipctl\" ]"},{"line_number":44,"context_line":"  then"},{"line_number":45,"context_line":"\t  cloneRepo airshipctl https://review.opendev.org/airship/airshipctl $AIRSHIPCTL_REF"},{"line_number":46,"context_line":"  fi"}],"source_content_type":"text/x-sh","patch_set":41,"id":"1464f50f_1f773e06","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":6},"updated":"2021-05-12 03:18:07.000000000","message":"Just to keep it consistent with L33. No need to make another PS just for this reason.","commit_id":"3d834f3c26cd273da86080590e3b949a6e99532e"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"7a4a5d06b5032a73b02ff6216699c40f3583b53f","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  cloneRepo $MANIFEST_REPO_NAME $MANIFEST_REPO_URL $MANIFEST_REPO_REF"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if [ $MANIFEST_REPO_NAME !\u003d  \"airshipctl\" ]"},{"line_number":44,"context_line":"  then"},{"line_number":45,"context_line":"\t  cloneRepo airshipctl https://review.opendev.org/airship/airshipctl $AIRSHIPCTL_REF"},{"line_number":46,"context_line":"  fi"}],"source_content_type":"text/x-sh","patch_set":41,"id":"628afb90_8165ba84","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":6},"in_reply_to":"1464f50f_1f773e06","updated":"2021-05-13 13:49:28.000000000","message":"Done","commit_id":"3d834f3c26cd273da86080590e3b949a6e99532e"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"7dfc7457411f8c84a1b63eb3538cdb5a1a7ac425","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  cloneRepo $MANIFEST_REPO_NAME $MANIFEST_REPO_URL $MANIFEST_REPO_REF"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if [[ $MANIFEST_REPO_NAME !\u003d  \"airshipctl\" ]]"},{"line_number":44,"context_line":"  then"},{"line_number":45,"context_line":"\t  cloneRepo airshipctl https://github.com/airshipit/airshipctl $AIRSHIPCTL_REF"},{"line_number":46,"context_line":"  fi"}],"source_content_type":"text/x-sh","patch_set":56,"id":"0946739a_b27fafde","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":4},"updated":"2021-06-15 18:56:25.000000000","message":"Wouldn\u0027t it be better to perform this test and necessary clone within the cloneRepo function?","commit_id":"764c9094a3829f82eda6d83a7e53854c62c3b7fa"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"b94b8f0029d627d685dde5bbd9241931ab136348","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  cloneRepo $MANIFEST_REPO_NAME $MANIFEST_REPO_URL $MANIFEST_REPO_REF"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if [[ $MANIFEST_REPO_NAME !\u003d  \"airshipctl\" ]]"},{"line_number":44,"context_line":"  then"},{"line_number":45,"context_line":"\t  cloneRepo airshipctl https://github.com/airshipit/airshipctl $AIRSHIPCTL_REF"},{"line_number":46,"context_line":"  fi"}],"source_content_type":"text/x-sh","patch_set":56,"id":"8134da80_d1e68992","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":4},"in_reply_to":"0946739a_b27fafde","updated":"2021-06-16 08:17:51.000000000","message":"I think keep the cloneRepo clear of specfic modules is good as AIAP will need to support multi-tentant and other new type of sites.","commit_id":"764c9094a3829f82eda6d83a7e53854c62c3b7fa"},{"author":{"_account_id":33264,"name":"Pankaj Goyal","email":"pgoyal@att.com","username":"pgoyal"},"change_message_id":"7dfc7457411f8c84a1b63eb3538cdb5a1a7ac425","unresolved":true,"context_lines":[{"line_number":50,"context_line":"  then"},{"line_number":51,"context_line":"    ./tools/deployment/21_systemwide_executable.sh"},{"line_number":52,"context_line":"  else"},{"line_number":53,"context_line":"    ./tools/deployment/airship-core/21_systemwide_executable.sh"},{"line_number":54,"context_line":"  fi"},{"line_number":55,"context_line":"  mkdir -p bin"},{"line_number":56,"context_line":"  cp \"$(which airshipctl)\" bin"}],"source_content_type":"text/x-sh","patch_set":56,"id":"4856e405_54b245be","line":53,"range":{"start_line":53,"start_character":4,"end_line":53,"end_character":35},"updated":"2021-06-15 18:56:25.000000000","message":"No such directory","commit_id":"764c9094a3829f82eda6d83a7e53854c62c3b7fa"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"b94b8f0029d627d685dde5bbd9241931ab136348","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  then"},{"line_number":51,"context_line":"    ./tools/deployment/21_systemwide_executable.sh"},{"line_number":52,"context_line":"  else"},{"line_number":53,"context_line":"    ./tools/deployment/airship-core/21_systemwide_executable.sh"},{"line_number":54,"context_line":"  fi"},{"line_number":55,"context_line":"  mkdir -p bin"},{"line_number":56,"context_line":"  cp \"$(which airshipctl)\" bin"}],"source_content_type":"text/x-sh","patch_set":56,"id":"7fbd8b23_7372e4e0","line":53,"range":{"start_line":53,"start_character":4,"end_line":53,"end_character":35},"in_reply_to":"4856e405_54b245be","updated":"2021-06-16 08:17:51.000000000","message":"The new PS for phase plan run (https://review.opendev.org/c/airship/treasuremap/+/795564) has introduced the airship-core directory now.","commit_id":"764c9094a3829f82eda6d83a7e53854c62c3b7fa"},{"author":{"_account_id":32090,"name":"Graham Steffaniak","email":"graham.steffaniak@att.com","username":"gs909v"},"change_message_id":"2f274c7c93f9379c97234eab64fb8673b6e86ddc","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"function cloneRepo(){"},{"line_number":19,"context_line":"  repo_name\u003d$1"},{"line_number":20,"context_line":"  repo_url\u003d$2"},{"line_number":21,"context_line":"  repo_ref\u003d$3"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  repo_dir\u003d\"$ARTIFACTS_DIR/$repo_name\""},{"line_number":24,"context_line":"  mkdir -p \"$repo_dir\""}],"source_content_type":"text/x-sh","patch_set":65,"id":"680889ca_9f2c2ddb","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":13},"updated":"2021-06-24 17:51:10.000000000","message":"We should include get-opts with help prompt for multi-parameter execution. Using unidentifiable arguments will probably cause some confusion.","commit_id":"1394dab555fc6a5394a98616f74314e0fdd77667"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"12cffc81c48766db0d8797f9cc46f29a0a9f2518","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"function cloneRepo(){"},{"line_number":19,"context_line":"  repo_name\u003d$1"},{"line_number":20,"context_line":"  repo_url\u003d$2"},{"line_number":21,"context_line":"  repo_ref\u003d$3"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  repo_dir\u003d\"$ARTIFACTS_DIR/$repo_name\""},{"line_number":24,"context_line":"  mkdir -p \"$repo_dir\""}],"source_content_type":"text/x-sh","patch_set":65,"id":"f5bde7b9_92bea4d5","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":13},"in_reply_to":"680889ca_9f2c2ddb","updated":"2021-06-25 03:12:54.000000000","message":"get-opts could be an overkill for this as there is no user execution from command line. Also i could not see any usage of get-opts in the airship repo in such scenario.","commit_id":"1394dab555fc6a5394a98616f74314e0fdd77667"},{"author":{"_account_id":32090,"name":"Graham Steffaniak","email":"graham.steffaniak@att.com","username":"gs909v"},"change_message_id":"2f274c7c93f9379c97234eab64fb8673b6e86ddc","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  cloneRepo $MANIFEST_REPO_NAME $MANIFEST_REPO_URL $MANIFEST_REPO_REF"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if [[ $MANIFEST_REPO_NAME !\u003d  \"airshipctl\" ]]"},{"line_number":44,"context_line":"  then"},{"line_number":45,"context_line":"\t  cloneRepo airshipctl https://github.com/airshipit/airshipctl $AIRSHIPCTL_REF"},{"line_number":46,"context_line":"  fi"}],"source_content_type":"text/x-sh","patch_set":65,"id":"8bdfd690_45ca4aee","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":27},"updated":"2021-06-24 17:51:10.000000000","message":"Can we double quote or fail execution before this on empty string (options not passed)","commit_id":"1394dab555fc6a5394a98616f74314e0fdd77667"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"12cffc81c48766db0d8797f9cc46f29a0a9f2518","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  cloneRepo $MANIFEST_REPO_NAME $MANIFEST_REPO_URL $MANIFEST_REPO_REF"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if [[ $MANIFEST_REPO_NAME !\u003d  \"airshipctl\" ]]"},{"line_number":44,"context_line":"  then"},{"line_number":45,"context_line":"\t  cloneRepo airshipctl https://github.com/airshipit/airshipctl $AIRSHIPCTL_REF"},{"line_number":46,"context_line":"  fi"}],"source_content_type":"text/x-sh","patch_set":65,"id":"04ed2588_e8522229","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":27},"in_reply_to":"8bdfd690_45ca4aee","updated":"2021-06-25 03:12:54.000000000","message":"Done","commit_id":"1394dab555fc6a5394a98616f74314e0fdd77667"}],"tools/airship-in-a-pod/examples/airship-in-a-pod-treasuremap.yaml":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"04b567d4c4e3b1896a15218a06669230fb09f090","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  containers:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  - name: libvirt"},{"line_number":23,"context_line":"    image: ianhowell/libvirt:latest"},{"line_number":24,"context_line":"    tty: true"},{"line_number":25,"context_line":"    securityContext:"},{"line_number":26,"context_line":"      privileged: true"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"18d5116f_4aac0eaa","line":23,"range":{"start_line":23,"start_character":11,"end_line":23,"end_character":35},"updated":"2021-04-09 18:30:57.000000000","message":"this needs to be the new image:\n\nquay.io/airshipit/libvirt:aiap-v1","commit_id":"2cf3ba7b3aae7d5532fd0db8a229f4bc8fc30566"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"474cf531658c1c23203376a43846caa37902da4c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  containers:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  - name: libvirt"},{"line_number":23,"context_line":"    image: ianhowell/libvirt:latest"},{"line_number":24,"context_line":"    tty: true"},{"line_number":25,"context_line":"    securityContext:"},{"line_number":26,"context_line":"      privileged: true"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"0287fed2_b382bf3a","line":23,"range":{"start_line":23,"start_character":11,"end_line":23,"end_character":35},"in_reply_to":"18d5116f_4aac0eaa","updated":"2021-04-12 18:42:13.000000000","message":"Updated.","commit_id":"2cf3ba7b3aae7d5532fd0db8a229f4bc8fc30566"}],"tools/airship-in-a-pod/examples/base/airship-in-a-pod.yaml":[{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"4e84cb3bb5c9c3b23fd0b291809b8b8084130bb4","unresolved":true,"context_lines":[{"line_number":180,"context_line":"      - name: srv"},{"line_number":181,"context_line":"        mountPath: /srv/"},{"line_number":182,"context_line":"      - name: airship-config"},{"line_number":183,"context_line":"        mountPath: /root/.airship"},{"line_number":184,"context_line":"  - name: artifact-setup"},{"line_number":185,"context_line":"    image: quay.io/airshipit/aiap-artifact-setup:latest"},{"line_number":186,"context_line":"    command:"},{"line_number":187,"context_line":"      - bash"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"ca5b29ed_6496b3f0","line":184,"range":{"start_line":183,"start_character":0,"end_line":184,"end_character":24},"updated":"2021-05-25 20:37:46.000000000","message":"Just a nit, but could we keep the empty line here? It\u0027s nice for easily jumping between containers via \u0027{\u0027 and \u0027}\u0027 in vim","commit_id":"9dd89ed1309b6f8149620b1428424ee28a9c7011"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"5ba7dcb149507f4970177c69fa271185e4100886","unresolved":false,"context_lines":[{"line_number":180,"context_line":"      - name: srv"},{"line_number":181,"context_line":"        mountPath: /srv/"},{"line_number":182,"context_line":"      - name: airship-config"},{"line_number":183,"context_line":"        mountPath: /root/.airship"},{"line_number":184,"context_line":"  - name: artifact-setup"},{"line_number":185,"context_line":"    image: quay.io/airshipit/aiap-artifact-setup:latest"},{"line_number":186,"context_line":"    command:"},{"line_number":187,"context_line":"      - bash"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"c83c14ef_9c767ff2","line":184,"range":{"start_line":183,"start_character":0,"end_line":184,"end_character":24},"in_reply_to":"ca5b29ed_6496b3f0","updated":"2021-05-26 11:18:54.000000000","message":"Done","commit_id":"9dd89ed1309b6f8149620b1428424ee28a9c7011"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"35d7a876f27a3e8af2062c495aab6031dbea1180","unresolved":true,"context_lines":[{"line_number":188,"context_line":"        mountPath: /var/run/libvirt"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"  - name: artifact-setup"},{"line_number":191,"context_line":"    image: quay.io/airshipit/aiap-artifact-setup:latest"},{"line_number":192,"context_line":"    command:"},{"line_number":193,"context_line":"      - bash"},{"line_number":194,"context_line":"      - -cex"}],"source_content_type":"text/x-yaml","patch_set":59,"id":"c6b884ee_c0a73db3","line":191,"range":{"start_line":191,"start_character":11,"end_line":191,"end_character":55},"updated":"2021-06-21 17:55:49.000000000","message":"I don\u0027t see this image in quay:\n\nhttps://quay.io/organization/airshipit","commit_id":"bb948abc76778bfd913def9f349bc61bdbf35a73"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"a93432e666a1a2cada174a48ec0159bd50716f0b","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        mountPath: /var/run/libvirt"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"  - name: artifact-setup"},{"line_number":191,"context_line":"    image: quay.io/airshipit/aiap-artifact-setup:latest"},{"line_number":192,"context_line":"    command:"},{"line_number":193,"context_line":"      - bash"},{"line_number":194,"context_line":"      - -cex"}],"source_content_type":"text/x-yaml","patch_set":59,"id":"8d83bde6_b94b38f8","line":191,"range":{"start_line":191,"start_character":11,"end_line":191,"end_character":55},"in_reply_to":"c6b884ee_c0a73db3","updated":"2021-06-22 02:57:39.000000000","message":"It will be added once this PS is merged based by zuul gate.","commit_id":"bb948abc76778bfd913def9f349bc61bdbf35a73"}],"tools/airship-in-a-pod/runner/assets/entrypoint.sh":[{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"9b0392823488fc83a441a685ef44d02f650dca9f","unresolved":true,"context_lines":[{"line_number":72,"context_line":"./tools/deployment/33_cluster_move_target_node.sh"},{"line_number":73,"context_line":"./tools/deployment/35_deploy_worker_node.sh"},{"line_number":74,"context_line":"./tools/deployment/36_deploy_workload.sh"},{"line_number":75,"context_line":"./tools/deployment/37_verify_hwcc_profiles.sh"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"/signal_complete runner"}],"source_content_type":"text/x-sh","patch_set":41,"id":"9e868b4d_164bcff6","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":45},"updated":"2021-05-12 15:06:13.000000000","message":"I see it is being removed from Zuul gates. Is it needed?","commit_id":"3d834f3c26cd273da86080590e3b949a6e99532e"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"7a4a5d06b5032a73b02ff6216699c40f3583b53f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"./tools/deployment/33_cluster_move_target_node.sh"},{"line_number":73,"context_line":"./tools/deployment/35_deploy_worker_node.sh"},{"line_number":74,"context_line":"./tools/deployment/36_deploy_workload.sh"},{"line_number":75,"context_line":"./tools/deployment/37_verify_hwcc_profiles.sh"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"/signal_complete runner"}],"source_content_type":"text/x-sh","patch_set":41,"id":"da85de1e_2956c363","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":45},"in_reply_to":"9e868b4d_164bcff6","updated":"2021-05-13 13:49:28.000000000","message":"Removed it.","commit_id":"3d834f3c26cd273da86080590e3b949a6e99532e"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"4e84cb3bb5c9c3b23fd0b291809b8b8084130bb4","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -ex"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Wait until artifact-setup  and libvirt infrastructure has been built"},{"line_number":18,"context_line":"/wait_for artifact-setup"},{"line_number":19,"context_line":"/wait_for infra-builder"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":43,"id":"b368cc09_88318f7b","line":17,"range":{"start_line":17,"start_character":28,"end_line":17,"end_character":29},"updated":"2021-05-25 20:37:46.000000000","message":"nit: extra space","commit_id":"9dd89ed1309b6f8149620b1428424ee28a9c7011"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"5ba7dcb149507f4970177c69fa271185e4100886","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -ex"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Wait until artifact-setup  and libvirt infrastructure has been built"},{"line_number":18,"context_line":"/wait_for artifact-setup"},{"line_number":19,"context_line":"/wait_for infra-builder"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":43,"id":"2709a58a_60975226","line":17,"range":{"start_line":17,"start_character":28,"end_line":17,"end_character":29},"in_reply_to":"b368cc09_88318f7b","updated":"2021-05-26 11:18:54.000000000","message":"Done","commit_id":"9dd89ed1309b6f8149620b1428424ee28a9c7011"},{"author":{"_account_id":28869,"name":"Ian Howell","email":"ian.howell0@gmail.com","username":"ian"},"change_message_id":"4e84cb3bb5c9c3b23fd0b291809b8b8084130bb4","unresolved":true,"context_lines":[{"line_number":39,"context_line":"cd /opt/$MANIFEST_REPO_NAME"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"SOPS_PGP_FP\u003d\"FBC7B9E2A4F9289AC0C1D4843D16CEE4A27381B4\""},{"line_number":42,"context_line":"echo \u0027export SOPS_IMPORT_PGP\u003d\"$(curl -fsSL  https://raw.githubusercontent.com/mozilla/sops/master/pgp/sops_functional_tests_key.asc)\"\u0027 \u003e\u003e ~/.profile"},{"line_number":43,"context_line":"echo \"export SOPS_PGP_FP\u003d${SOPS_PGP_FP}\" \u003e\u003e ~/.profile"},{"line_number":44,"context_line":"source ~/.profile"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"export AIRSHIP_CONFIG_MANIFEST_DIRECTORY\u003d\"/tmp/airship\""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-sh","patch_set":43,"id":"e8ce2776_5cd1b866","line":44,"range":{"start_line":42,"start_character":0,"end_line":44,"end_character":17},"updated":"2021-05-25 20:37:46.000000000","message":"this is a really good idea, but will this run the curl command every time a new shell is opened? It might be better to run curl once, then dump the contents into the .profile:\n\n  curl -fsSL -o /tmp/key.asc https://raw.githubusercontent.com/mozilla/sops/master/pgp/sops_functional_tests_key.asc\n  echo -n \"export SOPS_PGP_FP\u003d\" \u003e\u003e ~/.profile\n  echo \"$(cat /tmp/key.asc) \u003e\u003e ~/.profile","commit_id":"9dd89ed1309b6f8149620b1428424ee28a9c7011"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"5ba7dcb149507f4970177c69fa271185e4100886","unresolved":false,"context_lines":[{"line_number":39,"context_line":"cd /opt/$MANIFEST_REPO_NAME"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"SOPS_PGP_FP\u003d\"FBC7B9E2A4F9289AC0C1D4843D16CEE4A27381B4\""},{"line_number":42,"context_line":"echo \u0027export SOPS_IMPORT_PGP\u003d\"$(curl -fsSL  https://raw.githubusercontent.com/mozilla/sops/master/pgp/sops_functional_tests_key.asc)\"\u0027 \u003e\u003e ~/.profile"},{"line_number":43,"context_line":"echo \"export SOPS_PGP_FP\u003d${SOPS_PGP_FP}\" \u003e\u003e ~/.profile"},{"line_number":44,"context_line":"source ~/.profile"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"export AIRSHIP_CONFIG_MANIFEST_DIRECTORY\u003d\"/tmp/airship\""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-sh","patch_set":43,"id":"e76eb8f3_b18512ce","line":44,"range":{"start_line":42,"start_character":0,"end_line":44,"end_character":17},"in_reply_to":"e8ce2776_5cd1b866","updated":"2021-05-26 11:18:54.000000000","message":"Done","commit_id":"9dd89ed1309b6f8149620b1428424ee28a9c7011"},{"author":{"_account_id":32090,"name":"Graham Steffaniak","email":"graham.steffaniak@att.com","username":"gs909v"},"change_message_id":"2f274c7c93f9379c97234eab64fb8673b6e86ddc","unresolved":true,"context_lines":[{"line_number":27,"context_line":"kustomize_download_url\u003d\"https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize/${kustomize_version}/kustomize_${kustomize_version}_linux_amd64.tar.gz\""},{"line_number":28,"context_line":"curl -sSL \"$kustomize_download_url\" | tar -C /tmp -xzf -"},{"line_number":29,"context_line":"install /tmp/kustomize /usr/local/bin"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"cp \"$ARTIFACTS_DIR/$MANIFEST_REPO_NAME/bin/airshipctl\" /usr/local/bin/airshipctl"},{"line_number":32,"context_line":"if [ $MANIFEST_REPO_NAME !\u003d \"airshipctl\" ]"},{"line_number":33,"context_line":"then"},{"line_number":34,"context_line":"        export AIRSHIP_CONFIG_PHASE_REPO_URL\u003d\"https://opendev.org/airship/treasuremap\""},{"line_number":35,"context_line":"\tcp -r $ARTIFACTS_DIR/airshipctl/ /opt/airshipctl"},{"line_number":36,"context_line":"fi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"cp  -r $ARTIFACTS_DIR/$MANIFEST_REPO_NAME/ /opt/$MANIFEST_REPO_NAME"},{"line_number":39,"context_line":"cd /opt/$MANIFEST_REPO_NAME"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"SOPS_PGP_FP\u003d\"FBC7B9E2A4F9289AC0C1D4843D16CEE4A27381B4\""},{"line_number":42,"context_line":"curl -fsSL -o /tmp/key.asc https://raw.githubusercontent.com/mozilla/sops/master/pgp/sops_functional_tests_key.asc"},{"line_number":43,"context_line":"echo \u0027export SOPS_IMPORT_PGP\u003d\"$(cat /tmp/key.asc)\"\u0027 \u003e\u003e ~/.profile"}],"source_content_type":"text/x-sh","patch_set":65,"id":"e8ebb34d_b72f0dc0","line":40,"range":{"start_line":30,"start_character":0,"end_line":40,"end_character":0},"updated":"2021-06-24 17:51:10.000000000","message":"Good updates and additions, but remember to keep string + variable contexts double quoted.","commit_id":"1394dab555fc6a5394a98616f74314e0fdd77667"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"12cffc81c48766db0d8797f9cc46f29a0a9f2518","unresolved":false,"context_lines":[{"line_number":27,"context_line":"kustomize_download_url\u003d\"https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize/${kustomize_version}/kustomize_${kustomize_version}_linux_amd64.tar.gz\""},{"line_number":28,"context_line":"curl -sSL \"$kustomize_download_url\" | tar -C /tmp -xzf -"},{"line_number":29,"context_line":"install /tmp/kustomize /usr/local/bin"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"cp \"$ARTIFACTS_DIR/$MANIFEST_REPO_NAME/bin/airshipctl\" /usr/local/bin/airshipctl"},{"line_number":32,"context_line":"if [ $MANIFEST_REPO_NAME !\u003d \"airshipctl\" ]"},{"line_number":33,"context_line":"then"},{"line_number":34,"context_line":"        export AIRSHIP_CONFIG_PHASE_REPO_URL\u003d\"https://opendev.org/airship/treasuremap\""},{"line_number":35,"context_line":"\tcp -r $ARTIFACTS_DIR/airshipctl/ /opt/airshipctl"},{"line_number":36,"context_line":"fi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"cp  -r $ARTIFACTS_DIR/$MANIFEST_REPO_NAME/ /opt/$MANIFEST_REPO_NAME"},{"line_number":39,"context_line":"cd /opt/$MANIFEST_REPO_NAME"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"SOPS_PGP_FP\u003d\"FBC7B9E2A4F9289AC0C1D4843D16CEE4A27381B4\""},{"line_number":42,"context_line":"curl -fsSL -o /tmp/key.asc https://raw.githubusercontent.com/mozilla/sops/master/pgp/sops_functional_tests_key.asc"},{"line_number":43,"context_line":"echo \u0027export SOPS_IMPORT_PGP\u003d\"$(cat /tmp/key.asc)\"\u0027 \u003e\u003e ~/.profile"}],"source_content_type":"text/x-sh","patch_set":65,"id":"8085279d_4e952756","line":40,"range":{"start_line":30,"start_character":0,"end_line":40,"end_character":0},"in_reply_to":"e8ebb34d_b72f0dc0","updated":"2021-06-25 03:12:54.000000000","message":"Done","commit_id":"1394dab555fc6a5394a98616f74314e0fdd77667"},{"author":{"_account_id":32090,"name":"Graham Steffaniak","email":"graham.steffaniak@att.com","username":"gs909v"},"change_message_id":"2f274c7c93f9379c97234eab64fb8673b6e86ddc","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# By default, don\u0027t build airshipctl - use the binary from the shared volume instead"},{"line_number":50,"context_line":"# ./tools/deployment/21_systemwide_executable.sh"},{"line_number":51,"context_line":"if [ $MANIFEST_REPO_NAME \u003d\u003d \"airshipctl\" ]"},{"line_number":52,"context_line":"then"},{"line_number":53,"context_line":"  ./tools/deployment/22_test_configs.sh"},{"line_number":54,"context_line":"  ./tools/deployment/23_pull_documents.sh"},{"line_number":55,"context_line":"  ./tools/deployment/23_generate_secrets.sh"},{"line_number":56,"context_line":"else"},{"line_number":57,"context_line":"  ./tools/deployment/airship-core/22_test_configs.sh"},{"line_number":58,"context_line":"  ./tools/deployment/airship-core/23_pull_documents.sh"},{"line_number":59,"context_line":"  ./tools/deployment/airship-core/23_generate_secrets.sh"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"fi"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"sed -i -e \u0027s#bmcAddress: redfish+http://\\([0-9]\\+\\.[0-9]\\+\\.[0-9]\\+\\.[0-9]\\+\\):8000#bmcAddress: redfish+https://10.23.25.1:8443#\u0027 /tmp/airship/$MANIFEST_REPO_NAME/manifests/site/test-site/target/catalogues/hosts.yaml"},{"line_number":64,"context_line":"sed -i -e \u0027s#root#username#\u0027 /tmp/airship/$MANIFEST_REPO_NAME/manifests/site/test-site/target/catalogues/hosts.yaml"},{"line_number":65,"context_line":"sed -i -e \u0027s#r00tme#password#\u0027 /tmp/airship/$MANIFEST_REPO_NAME/manifests/site/test-site/target/catalogues/hosts.yaml"},{"line_number":66,"context_line":"sed -i -e \u0027s#disableCertificateVerification: false#disableCertificateVerification: true#\u0027 /tmp/airship/$MANIFEST_REPO_NAME/manifests/site/test-site/target/catalogues/hosts.yaml"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"if [[ \"$USE_CACHED_ISO\" \u003d \"true\" ]]; then"},{"line_number":69,"context_line":"  mkdir -p /srv/images"},{"line_number":70,"context_line":"  tar -xzf \"$CACHE_DIR/iso.tar.gz\" --directory /srv/images"},{"line_number":71,"context_line":"else"},{"line_number":72,"context_line":"  if [ $MANIFEST_REPO_NAME \u003d\u003d \"airshipctl\" ]"},{"line_number":73,"context_line":"  then"},{"line_number":74,"context_line":"     ./tools/deployment/24_build_images.sh"},{"line_number":75,"context_line":"  else"},{"line_number":76,"context_line":"     ./tools/deployment/airship-core/24_build_images.sh"},{"line_number":77,"context_line":"  fi"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  tar -czf \"$ARTIFACTS_DIR/iso.tar.gz\" --directory\u003d/srv/images ."},{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"if [ $MANIFEST_REPO_NAME \u003d\u003d \"airshipctl\" ]"},{"line_number":83,"context_line":"then"},{"line_number":84,"context_line":"  ./tools/deployment/25_deploy_gating.sh"},{"line_number":85,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":65,"id":"cf94d706_8ab13cad","line":82,"range":{"start_line":51,"start_character":0,"end_line":82,"end_character":42},"updated":"2021-06-24 17:51:10.000000000","message":"double quotes. similar to how ian had \"$USE_CACHED_ISO\" double quoted.","commit_id":"1394dab555fc6a5394a98616f74314e0fdd77667"},{"author":{"_account_id":31514,"name":"Manoj","display_name":"Manoj Alva","email":"manojkumar.alva@gmail.com","username":"manojkva"},"change_message_id":"12cffc81c48766db0d8797f9cc46f29a0a9f2518","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# By default, don\u0027t build airshipctl - use the binary from the shared volume instead"},{"line_number":50,"context_line":"# ./tools/deployment/21_systemwide_executable.sh"},{"line_number":51,"context_line":"if [ $MANIFEST_REPO_NAME \u003d\u003d \"airshipctl\" ]"},{"line_number":52,"context_line":"then"},{"line_number":53,"context_line":"  ./tools/deployment/22_test_configs.sh"},{"line_number":54,"context_line":"  ./tools/deployment/23_pull_documents.sh"},{"line_number":55,"context_line":"  ./tools/deployment/23_generate_secrets.sh"},{"line_number":56,"context_line":"else"},{"line_number":57,"context_line":"  ./tools/deployment/airship-core/22_test_configs.sh"},{"line_number":58,"context_line":"  ./tools/deployment/airship-core/23_pull_documents.sh"},{"line_number":59,"context_line":"  ./tools/deployment/airship-core/23_generate_secrets.sh"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"fi"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"sed -i -e \u0027s#bmcAddress: redfish+http://\\([0-9]\\+\\.[0-9]\\+\\.[0-9]\\+\\.[0-9]\\+\\):8000#bmcAddress: redfish+https://10.23.25.1:8443#\u0027 /tmp/airship/$MANIFEST_REPO_NAME/manifests/site/test-site/target/catalogues/hosts.yaml"},{"line_number":64,"context_line":"sed -i -e \u0027s#root#username#\u0027 /tmp/airship/$MANIFEST_REPO_NAME/manifests/site/test-site/target/catalogues/hosts.yaml"},{"line_number":65,"context_line":"sed -i -e \u0027s#r00tme#password#\u0027 /tmp/airship/$MANIFEST_REPO_NAME/manifests/site/test-site/target/catalogues/hosts.yaml"},{"line_number":66,"context_line":"sed -i -e \u0027s#disableCertificateVerification: false#disableCertificateVerification: true#\u0027 /tmp/airship/$MANIFEST_REPO_NAME/manifests/site/test-site/target/catalogues/hosts.yaml"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"if [[ \"$USE_CACHED_ISO\" \u003d \"true\" ]]; then"},{"line_number":69,"context_line":"  mkdir -p /srv/images"},{"line_number":70,"context_line":"  tar -xzf \"$CACHE_DIR/iso.tar.gz\" --directory /srv/images"},{"line_number":71,"context_line":"else"},{"line_number":72,"context_line":"  if [ $MANIFEST_REPO_NAME \u003d\u003d \"airshipctl\" ]"},{"line_number":73,"context_line":"  then"},{"line_number":74,"context_line":"     ./tools/deployment/24_build_images.sh"},{"line_number":75,"context_line":"  else"},{"line_number":76,"context_line":"     ./tools/deployment/airship-core/24_build_images.sh"},{"line_number":77,"context_line":"  fi"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  tar -czf \"$ARTIFACTS_DIR/iso.tar.gz\" --directory\u003d/srv/images ."},{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"if [ $MANIFEST_REPO_NAME \u003d\u003d \"airshipctl\" ]"},{"line_number":83,"context_line":"then"},{"line_number":84,"context_line":"  ./tools/deployment/25_deploy_gating.sh"},{"line_number":85,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":65,"id":"e47a4d7d_b398157d","line":82,"range":{"start_line":51,"start_character":0,"end_line":82,"end_character":42},"in_reply_to":"cf94d706_8ab13cad","updated":"2021-06-25 03:12:54.000000000","message":"Done","commit_id":"1394dab555fc6a5394a98616f74314e0fdd77667"}]}