)]}'
{"pkg/api/v1alpha1/templater_plugin_types.go":[{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"4a55cda0422e1dc516869ebb960cb290cdb51b70","unresolved":true,"context_lines":[{"line_number":33,"context_line":"\tTemplate string `json:\"template,omitempty\"`"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"// NOTE map[string]interface is not supported by controller gen"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"// DeepCopyInto is copying the receiver, writing into out. in must be non-nil."},{"line_number":39,"context_line":"func (in *Templater) DeepCopyInto(out *Templater) {"}],"source_content_type":"text/x-go","patch_set":4,"id":"5fb0a7f2_56ce8e19","side":"PARENT","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":63},"updated":"2021-06-25 16:37:07.000000000","message":"should the below function move to the zz_generated... file now that we are no longer using an unsupported type?","commit_id":"8d882fcc8532af394a7e5558238d886f15abd709"},{"author":{"_account_id":28777,"name":"Matthew Fuller","email":"matfuller@microsoft.com","username":"mfuller"},"change_message_id":"f97b63732fae93c562c2d0705b8025c1da4a513f","unresolved":true,"context_lines":[{"line_number":33,"context_line":"\tTemplate string `json:\"template,omitempty\"`"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"// NOTE map[string]interface is not supported by controller gen"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"// DeepCopyInto is copying the receiver, writing into out. in must be non-nil."},{"line_number":39,"context_line":"func (in *Templater) DeepCopyInto(out *Templater) {"}],"source_content_type":"text/x-go","patch_set":4,"id":"36b74424_63fdf861","side":"PARENT","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":63},"in_reply_to":"5fb0a7f2_56ce8e19","updated":"2021-06-25 17:05:22.000000000","message":"good idea, I\u0027ve deleted it here and regenerated the zz_generated file.","commit_id":"8d882fcc8532af394a7e5558238d886f15abd709"}],"pkg/document/plugin/templater/templater.go":[{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"6fbb5d4ea0b261572f64f239ee5ed8e2d131f975","unresolved":true,"context_lines":[{"line_number":72,"context_line":"\t\treturn nil, err"},{"line_number":73,"context_line":"\t}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"\tvaluesMap :\u003d map[string]interface{}{}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"\tif t.Values !\u003d nil {"},{"line_number":78,"context_line":"\t\tif err \u003d json.Unmarshal(t.Values.Raw, \u0026valuesMap); err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":6,"id":"4ecf2095_42b91067","line":75,"range":{"start_line":75,"start_character":14,"end_line":75,"end_character":38},"updated":"2021-06-25 18:09:37.000000000","message":"The CR input allows arbitrary json, which is not necessarily assignable to the map type being used here. I think we should align the allowed types in both locations via one of:\n\n1. Use `map[string]*v1.JSON` in the CRD, keep `map[string]interface{}` here\n2. Keep `*v1.JSON` in the CRD, use `interface{}` here","commit_id":"dab92f80ff5e7a8169cdfec64e9ebbbdd63a8df5"},{"author":{"_account_id":28777,"name":"Matthew Fuller","email":"matfuller@microsoft.com","username":"mfuller"},"change_message_id":"d25e4a73b69a5131d0811508309c3553c2f2475c","unresolved":true,"context_lines":[{"line_number":72,"context_line":"\t\treturn nil, err"},{"line_number":73,"context_line":"\t}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"\tvaluesMap :\u003d map[string]interface{}{}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"\tif t.Values !\u003d nil {"},{"line_number":78,"context_line":"\t\tif err \u003d json.Unmarshal(t.Values.Raw, \u0026valuesMap); err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":6,"id":"457e2cc4_f0a2bc55","line":75,"range":{"start_line":75,"start_character":14,"end_line":75,"end_character":38},"in_reply_to":"4ecf2095_42b91067","updated":"2021-06-25 19:01:14.000000000","message":"Done","commit_id":"dab92f80ff5e7a8169cdfec64e9ebbbdd63a8df5"}]}