)]}'
{"armada/conf/default.py":[{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"28a46745f5e3a407e2ebe5a2751f5fc11dc346fc","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        help\u003dutils.fmt(\u0027Namespace for the Tiller pod.\u0027)),"},{"line_number":72,"context_line":"    cfg.StrOpt("},{"line_number":73,"context_line":"        \u0027tiller_host\u0027,"},{"line_number":74,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":75,"context_line":"        help\u003dutils.fmt(\u0027IP for the Tiller pod.\u0027)),"},{"line_number":76,"context_line":"    cfg.IntOpt("},{"line_number":77,"context_line":"        \u0027tiller_port\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_547d107d","line":74,"range":{"start_line":74,"start_character":17,"end_line":74,"end_character":26},"updated":"2019-01-28 14:05:36.000000000","message":"I would leave the default as null so we can continue to default to finding the ip from looking up the tiller pod, since that is useful and backward compatible. This default could be set in the values.yaml though in the other patchset which moves tiller inside the armada pod.","commit_id":"a3ad31bf73fc5a7a8b5daf3a4dfaf7cf507b051f"},{"author":{"_account_id":22259,"name":"Nishant Kumar","email":"nishant.e.kumar@att.com","username":"nishant.e.kumar"},"change_message_id":"7cd24603bf68182c7efe4f8f5e5be207d3af9a85","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        help\u003dutils.fmt(\u0027Namespace for the Tiller pod.\u0027)),"},{"line_number":72,"context_line":"    cfg.StrOpt("},{"line_number":73,"context_line":"        \u0027tiller_host\u0027,"},{"line_number":74,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":75,"context_line":"        help\u003dutils.fmt(\u0027IP for the Tiller pod.\u0027)),"},{"line_number":76,"context_line":"    cfg.IntOpt("},{"line_number":77,"context_line":"        \u0027tiller_port\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_9a439faf","line":74,"range":{"start_line":74,"start_character":17,"end_line":74,"end_character":26},"in_reply_to":"9fdfeff1_547d107d","updated":"2019-01-28 15:51:22.000000000","message":"ok thanks sean, I think that makes sense.","commit_id":"a3ad31bf73fc5a7a8b5daf3a4dfaf7cf507b051f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9d90421a3555a5cd03f375ca411d5803f493cc20","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \u0027tiller_namespace\u0027,"},{"line_number":70,"context_line":"        default\u003d\u0027kube-system\u0027,"},{"line_number":71,"context_line":"        help\u003dutils.fmt(\u0027Namespace for the Tiller pod.\u0027)),"},{"line_number":72,"context_line":"    cfg.StrOpt("},{"line_number":73,"context_line":"        \u0027tiller_host\u0027, default\u003dNone, help\u003dutils.fmt(\u0027IP for the Tiller pod.\u0027)),"},{"line_number":74,"context_line":"    cfg.IntOpt("},{"line_number":75,"context_line":"        \u0027tiller_port\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_8b1e52b8","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":14},"updated":"2019-03-07 18:12:03.000000000","message":"there is a special ip type in oslo_config","commit_id":"77e501e640acd57727482ffd118164cf537dfe9a"},{"author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"change_message_id":"0302373d77a575856b57eaa01f5e43d0dd10f301","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \u0027tiller_namespace\u0027,"},{"line_number":70,"context_line":"        default\u003d\u0027kube-system\u0027,"},{"line_number":71,"context_line":"        help\u003dutils.fmt(\u0027Namespace for the Tiller pod.\u0027)),"},{"line_number":72,"context_line":"    cfg.StrOpt("},{"line_number":73,"context_line":"        \u0027tiller_host\u0027, default\u003dNone, help\u003dutils.fmt(\u0027IP for the Tiller pod.\u0027)),"},{"line_number":74,"context_line":"    cfg.IntOpt("},{"line_number":75,"context_line":"        \u0027tiller_port\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_e05a5a28","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":14},"in_reply_to":"5fc1f717_8b1e52b8","updated":"2019-03-11 16:54:16.000000000","message":"I believe this should also work with a hostname, so limiting it to an oslo_config IP would not be ideal","commit_id":"77e501e640acd57727482ffd118164cf537dfe9a"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"ba63eb299639967b94dd5ade99dc929ed5c6a4cd","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        default\u003d\u0027kube-system\u0027,"},{"line_number":71,"context_line":"        help\u003dutils.fmt(\u0027Namespace for the Tiller pod.\u0027)),"},{"line_number":72,"context_line":"    cfg.StrOpt("},{"line_number":73,"context_line":"        \u0027tiller_host\u0027, default\u003dNone, help\u003dutils.fmt(\u0027IP for the Tiller pod.\u0027)),"},{"line_number":74,"context_line":"    cfg.IntOpt("},{"line_number":75,"context_line":"        \u0027tiller_port\u0027,"},{"line_number":76,"context_line":"        default\u003d44134,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5fc1f717_c0995e6e","line":73,"range":{"start_line":73,"start_character":53,"end_line":73,"end_character":55},"updated":"2019-03-11 17:12:46.000000000","message":"technically it can be a host name as well right?","commit_id":"1cca296b54ef7ce0fd0ce7fd9f5ad4c61489b208"},{"author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"change_message_id":"657871af0991f18b6598a22739fc4f627d2ff147","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        default\u003d\u0027kube-system\u0027,"},{"line_number":71,"context_line":"        help\u003dutils.fmt(\u0027Namespace for the Tiller pod.\u0027)),"},{"line_number":72,"context_line":"    cfg.StrOpt("},{"line_number":73,"context_line":"        \u0027tiller_host\u0027, default\u003dNone, help\u003dutils.fmt(\u0027IP for the Tiller pod.\u0027)),"},{"line_number":74,"context_line":"    cfg.IntOpt("},{"line_number":75,"context_line":"        \u0027tiller_port\u0027,"},{"line_number":76,"context_line":"        default\u003d44134,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5fc1f717_ab70b3a6","line":73,"range":{"start_line":73,"start_character":53,"end_line":73,"end_character":55},"in_reply_to":"5fc1f717_c0995e6e","updated":"2019-03-11 17:43:25.000000000","message":"Done","commit_id":"1cca296b54ef7ce0fd0ce7fd9f5ad4c61489b208"}],"armada/tests/unit/handlers/test_tiller.py":[{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"8206e2d4555dfbf2d3cc49e96906e9103050f150","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    @mock.patch(\u0027armada.handlers.tiller.grpc\u0027, autospec\u003dTrue)"},{"line_number":103,"context_line":"    def test_get_tiller_ip_with_mocked_pod(self, mock_grpc, mock_k8s,"},{"line_number":104,"context_line":"                                           mock_pod):"},{"line_number":105,"context_line":"        status \u003d mock.Mock(pod_ip\u003d\u0027127.0.0.1\u0027)"},{"line_number":106,"context_line":"        mock_pod.return_value.status \u003d status"},{"line_number":107,"context_line":"        tiller_obj \u003d tiller.Tiller()"},{"line_number":108,"context_line":"        self.assertEqual(\u0027127.0.0.1\u0027, tiller_obj._get_tiller_ip())"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @mock.patch.object(tiller.Tiller, \u0027_get_tiller_ip\u0027, autospec\u003dTrue)"},{"line_number":111,"context_line":"    @mock.patch(\u0027armada.handlers.tiller.K8s\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_fdd2055c","line":108,"range":{"start_line":105,"start_character":0,"end_line":108,"end_character":66},"updated":"2019-03-11 16:19:18.000000000","message":"I\u0027m not understanding how this test change proves the changes function correctly.","commit_id":"3aa40dd57dc3e0108b42fe4742663b6ea9293b7d"},{"author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"change_message_id":"4b09a2e50e7acf387901efe6f51e171359c95a3c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    @mock.patch(\u0027armada.handlers.tiller.grpc\u0027, autospec\u003dTrue)"},{"line_number":103,"context_line":"    def test_get_tiller_ip_with_mocked_pod(self, mock_grpc, mock_k8s,"},{"line_number":104,"context_line":"                                           mock_pod):"},{"line_number":105,"context_line":"        status \u003d mock.Mock(pod_ip\u003d\u0027127.0.0.1\u0027)"},{"line_number":106,"context_line":"        mock_pod.return_value.status \u003d status"},{"line_number":107,"context_line":"        tiller_obj \u003d tiller.Tiller()"},{"line_number":108,"context_line":"        self.assertEqual(\u0027127.0.0.1\u0027, tiller_obj._get_tiller_ip())"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @mock.patch.object(tiller.Tiller, \u0027_get_tiller_ip\u0027, autospec\u003dTrue)"},{"line_number":111,"context_line":"    @mock.patch(\u0027armada.handlers.tiller.K8s\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_dde069fd","line":108,"range":{"start_line":105,"start_character":0,"end_line":108,"end_character":66},"in_reply_to":"5fc1f717_fdd2055c","updated":"2019-03-11 16:46:13.000000000","message":"Hmm, I think this is actually unnecessary now and was just a residual change from before the default was set to None that went unnoticed because the test still passes. Thanks for the catch.","commit_id":"3aa40dd57dc3e0108b42fe4742663b6ea9293b7d"}]}