)]}'
{"test-requirements.txt":[{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"c52f3c67b7285737c11d8f0ad9feb02306e129e0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"flake8\u003e\u003d3.3.0"},{"line_number":14,"context_line":"mock"},{"line_number":15,"context_line":"responses\u003e\u003d0.8.1"},{"line_number":16,"context_line":"yapf\u003d\u003d0.27.0"},{"line_number":17,"context_line":"flake8-import-order\u003d\u003d0.18.1"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"grpcio-tools\u003d\u003d1.16.0"}],"source_content_type":"text/plain","patch_set":2,"id":"7faddb67_ca2ace2a","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":27},"updated":"2019-07-29 20:57:42.000000000","message":"we should use \u003e\u003d here too","commit_id":"4f18855720c1cb860eec11942572a5dff6da82c4"},{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"bf16bb1a39887b2d5eae8c5ab25aafaa5374f7bd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"flake8\u003e\u003d3.3.0"},{"line_number":14,"context_line":"mock"},{"line_number":15,"context_line":"responses\u003e\u003d0.8.1"},{"line_number":16,"context_line":"yapf\u003d\u003d0.27.0"},{"line_number":17,"context_line":"flake8-import-order\u003d\u003d0.18.1"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"grpcio-tools\u003d\u003d1.16.0"}],"source_content_type":"text/plain","patch_set":2,"id":"7faddb67_c7cdd130","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":27},"in_reply_to":"7faddb67_6b3f1125","updated":"2019-07-30 21:14:59.000000000","message":"That\u0027s understandable I suppose. Perhaps we can at least do ~\u003d though to get bug fixes if they get released","commit_id":"4f18855720c1cb860eec11942572a5dff6da82c4"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"018ab84e75baaf29925d6e25f9930d76a26ab690","unresolved":false,"context_lines":[{"line_number":13,"context_line":"flake8\u003e\u003d3.3.0"},{"line_number":14,"context_line":"mock"},{"line_number":15,"context_line":"responses\u003e\u003d0.8.1"},{"line_number":16,"context_line":"yapf\u003d\u003d0.27.0"},{"line_number":17,"context_line":"flake8-import-order\u003d\u003d0.18.1"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"grpcio-tools\u003d\u003d1.16.0"}],"source_content_type":"text/plain","patch_set":2,"id":"7faddb67_ffd96a55","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":27},"in_reply_to":"7faddb67_6b3f1125","updated":"2019-07-31 15:19:52.000000000","message":"The problem with adding a new non-voting gate is that because it\u0027s non voting it leads to complacency.  It will require contributors to be vigilant with watching patches to fail this new non-voting gate.\n\nIn any case it\u0027s outside the scope of this patchset, but something we could bring up on Tuesday (06-Aug) team meeting.  Checking for outdated packages in general could be useful rather than checking for just yapf/flake8-import-order.","commit_id":"4f18855720c1cb860eec11942572a5dff6da82c4"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"018ab84e75baaf29925d6e25f9930d76a26ab690","unresolved":false,"context_lines":[{"line_number":13,"context_line":"flake8\u003e\u003d3.3.0"},{"line_number":14,"context_line":"mock"},{"line_number":15,"context_line":"responses\u003e\u003d0.8.1"},{"line_number":16,"context_line":"yapf\u003d\u003d0.27.0"},{"line_number":17,"context_line":"flake8-import-order\u003d\u003d0.18.1"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"grpcio-tools\u003d\u003d1.16.0"}],"source_content_type":"text/plain","patch_set":2,"id":"7faddb67_1fb806e3","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":27},"in_reply_to":"7faddb67_c7cdd130","updated":"2019-07-31 15:19:52.000000000","message":"Going to keep pinned for now, across all projects I implement this change into.  Over time with your pipfile work I think this can be streamlined.","commit_id":"4f18855720c1cb860eec11942572a5dff6da82c4"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"018ab84e75baaf29925d6e25f9930d76a26ab690","unresolved":false,"context_lines":[{"line_number":13,"context_line":"flake8\u003e\u003d3.3.0"},{"line_number":14,"context_line":"mock"},{"line_number":15,"context_line":"responses\u003e\u003d0.8.1"},{"line_number":16,"context_line":"yapf\u003d\u003d0.27.0"},{"line_number":17,"context_line":"flake8-import-order\u003d\u003d0.18.1"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"grpcio-tools\u003d\u003d1.16.0"}],"source_content_type":"text/plain","patch_set":2,"id":"7faddb67_7fffbaaa","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":27},"in_reply_to":"7faddb67_ca2ace2a","updated":"2019-07-31 15:19:52.000000000","message":"I\u0027d prefer to keep pinned.","commit_id":"4f18855720c1cb860eec11942572a5dff6da82c4"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"521e1e5ff9e392e3343c36a087777e5a016cdc0a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"flake8\u003e\u003d3.3.0"},{"line_number":14,"context_line":"mock"},{"line_number":15,"context_line":"responses\u003e\u003d0.8.1"},{"line_number":16,"context_line":"yapf\u003d\u003d0.27.0"},{"line_number":17,"context_line":"flake8-import-order\u003d\u003d0.18.1"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"grpcio-tools\u003d\u003d1.16.0"}],"source_content_type":"text/plain","patch_set":2,"id":"7faddb67_6b3f1125","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":27},"in_reply_to":"7faddb67_ca2ace2a","updated":"2019-07-30 15:49:28.000000000","message":"We used to have this, and it meant that gates broke each time a new version of yapf was released. If this is done across all projects, then all gates will be broken until re-formatting against the new yapf version can be done/merged. Being on the latest version of yapf immediately doesn\u0027t seem worth all that pain. So intentional planned upgrades of yapf (and likely flake8-import-order) seems preferable. Perhaps adding a non-voting gate which checks whether these and possibly other deps are up to date could inform when updates are needed, though that may be overkill.","commit_id":"4f18855720c1cb860eec11942572a5dff6da82c4"}],"tox.ini":[{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"c52f3c67b7285737c11d8f0ad9feb02306e129e0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    coverage xml -o cover/coverage.xml"},{"line_number":95,"context_line":"    coverage report"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"[testenv:yapf]"},{"line_number":98,"context_line":"basepython \u003d python3"},{"line_number":99,"context_line":"deps \u003d {[testenv]deps}"},{"line_number":100,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7faddb67_2a0282b5","line":97,"range":{"start_line":97,"start_character":9,"end_line":97,"end_character":13},"updated":"2019-07-29 20:57:42.000000000","message":"should we make this fmt to match other projects?","commit_id":"4f18855720c1cb860eec11942572a5dff6da82c4"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"521e1e5ff9e392e3343c36a087777e5a016cdc0a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    coverage xml -o cover/coverage.xml"},{"line_number":95,"context_line":"    coverage report"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"[testenv:yapf]"},{"line_number":98,"context_line":"basepython \u003d python3"},{"line_number":99,"context_line":"deps \u003d {[testenv]deps}"},{"line_number":100,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7faddb67_cb0f2586","line":97,"range":{"start_line":97,"start_character":9,"end_line":97,"end_character":13},"in_reply_to":"7faddb67_2a0282b5","updated":"2019-07-30 15:49:28.000000000","message":"++","commit_id":"4f18855720c1cb860eec11942572a5dff6da82c4"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"018ab84e75baaf29925d6e25f9930d76a26ab690","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    coverage xml -o cover/coverage.xml"},{"line_number":95,"context_line":"    coverage report"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"[testenv:yapf]"},{"line_number":98,"context_line":"basepython \u003d python3"},{"line_number":99,"context_line":"deps \u003d {[testenv]deps}"},{"line_number":100,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7faddb67_ff0baad1","line":97,"range":{"start_line":97,"start_character":9,"end_line":97,"end_character":13},"in_reply_to":"7faddb67_2a0282b5","updated":"2019-07-31 15:19:52.000000000","message":"Done","commit_id":"4f18855720c1cb860eec11942572a5dff6da82c4"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"018ab84e75baaf29925d6e25f9930d76a26ab690","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    coverage xml -o cover/coverage.xml"},{"line_number":95,"context_line":"    coverage report"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"[testenv:yapf]"},{"line_number":98,"context_line":"basepython \u003d python3"},{"line_number":99,"context_line":"deps \u003d {[testenv]deps}"},{"line_number":100,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7faddb67_1f11e604","line":97,"range":{"start_line":97,"start_character":9,"end_line":97,"end_character":13},"in_reply_to":"7faddb67_cb0f2586","updated":"2019-07-31 15:19:52.000000000","message":"Done","commit_id":"4f18855720c1cb860eec11942572a5dff6da82c4"}]}