)]}'
{"armada/handlers/chartbuilder.py":[{"author":{"_account_id":26449,"name":"Scott Hussey","email":"sthussey@att.com","username":"sh8121"},"change_message_id":"3cf3b9b11bffebb15eae3f9e484c09dc396d942f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                builder \u003d ChartBuilder.from_chart(chart_dep)"},{"line_number":53,"context_line":"                dependency_builders.append(builder)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        return cls(name, source_directory, dependency_builders)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def __init__(self, name, source_directory, dependency_builders\u003dNone):"},{"line_number":58,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_a6d97056","line":55,"range":{"start_line":55,"start_character":43,"end_line":55,"end_character":62},"updated":"2019-08-20 15:38:51.000000000","message":"nit: probably should use a kwarg","commit_id":"f502f33e9f2b02100be016662538b79c17781179"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"49f83f4b00a6ae123c55c636b4bfa9706eec44fb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                builder \u003d ChartBuilder.from_chart(chart_dep)"},{"line_number":53,"context_line":"                dependency_builders.append(builder)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        return cls(name, source_directory, dependency_builders)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def __init__(self, name, source_directory, dependency_builders\u003dNone):"},{"line_number":58,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_a93700e3","line":55,"range":{"start_line":55,"start_character":43,"end_line":55,"end_character":62},"in_reply_to":"7faddb67_a6d97056","updated":"2019-08-20 17:31:37.000000000","message":"\u003e nit: probably should use a kwarg\n\nAgreed, this would be nice to have.","commit_id":"f502f33e9f2b02100be016662538b79c17781179"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"b3dad4d2c11843bf8abac02eb5a6289458517f47","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                builder \u003d ChartBuilder.from_chart(chart_dep)"},{"line_number":53,"context_line":"                dependency_builders.append(builder)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        return cls(name, source_directory, dependency_builders)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def __init__(self, name, source_directory, dependency_builders\u003dNone):"},{"line_number":58,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_a23cf5be","line":55,"range":{"start_line":55,"start_character":43,"end_line":55,"end_character":62},"in_reply_to":"7faddb67_a93700e3","updated":"2019-08-20 19:18:35.000000000","message":"it\u0027s no longer optional as I added a `from_source` constructor for that case.","commit_id":"f502f33e9f2b02100be016662538b79c17781179"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"49f83f4b00a6ae123c55c636b4bfa9706eec44fb","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        return self._helm_chart"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def _get_helm_chart(self):"},{"line_number":261,"context_line":"        dependencies \u003d []"},{"line_number":262,"context_line":"        for dep_builder in self.dependency_builders:"},{"line_number":263,"context_line":"            LOG.info("}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_89748469","line":260,"range":{"start_line":260,"start_character":4,"end_line":260,"end_character":30},"updated":"2019-08-20 17:31:37.000000000","message":"I\u0027ll defer to your judgement here, but I\u0027d like to propose another way of doing this.\n\nThe idea of keeping track of \"dependency builders\" that are decided up front seems against the flow. I think it\u0027d be easier to make that decision down here (like it was before) and split into two different methods:\n\n1) Build chart dependencies using the \"Armada way\" i.e. chart documents\n2) Build chart dependencies using the \"Helm way\" i.e. charts dir\n\nIn the future, if we add support for .tgz or requirements files, I think it\u0027d be easier to expand on then the current implementation.\n\nWith that being said, I\u0027m okay with this approach should you decide to stick with it.","commit_id":"f502f33e9f2b02100be016662538b79c17781179"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"b3dad4d2c11843bf8abac02eb5a6289458517f47","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        return self._helm_chart"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def _get_helm_chart(self):"},{"line_number":261,"context_line":"        dependencies \u003d []"},{"line_number":262,"context_line":"        for dep_builder in self.dependency_builders:"},{"line_number":263,"context_line":"            LOG.info("}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_a92060b1","line":260,"range":{"start_line":260,"start_character":4,"end_line":260,"end_character":30},"in_reply_to":"7faddb67_89748469","updated":"2019-08-20 19:18:35.000000000","message":"Not sure I understand. The change made here should make things more configurable, not less, via dependency injection of `dependency_builders` (lol, referring to different \"dependency\"s there). So essentially the default way is now the \"Helm way\", but you can override that with the \"Armada way\" if you want by injecting dependency builders into the ChartBuilder. This way, ChartBuilder requires no knowledge of the \"Armada way\". I added a separate constructor for the \"helm way\" as well now just to make it fully externalized.\n\nThe .tgz support is just a matter of extracting .tgz\u0027s in `charts`, when they exist. Helm CLI does this in memory, Armada will need to extract into a persistent directory, including tying into the chart caching that is in place.\n\nThe requirements files don\u0027t factor in, as they a build-time concept used by `helm dep up` to populate the `charts` directory.","commit_id":"f502f33e9f2b02100be016662538b79c17781179"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"88fc240adbd48af532f9d596184c65c77967bd40","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        return self._helm_chart"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def _get_helm_chart(self):"},{"line_number":261,"context_line":"        dependencies \u003d []"},{"line_number":262,"context_line":"        for dep_builder in self.dependency_builders:"},{"line_number":263,"context_line":"            LOG.info("}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_3874aa67","line":260,"range":{"start_line":260,"start_character":4,"end_line":260,"end_character":30},"in_reply_to":"7faddb67_a92060b1","updated":"2019-08-21 13:49:00.000000000","message":"\u003e The requirements files don\u0027t factor in, as they a build-time\n \u003e concept used by `helm dep up` to populate the `charts` directory.\n\nI didn\u0027t realize they were separate; thanks for the explanation.","commit_id":"f502f33e9f2b02100be016662538b79c17781179"}],"doc/source/operations/documents/v1/document-authoring.rst":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"49f83f4b00a6ae123c55c636b4bfa9706eec44fb","unresolved":false,"context_lines":[{"line_number":134,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"},{"line_number":135,"context_line":"| source          | object   | provide a path to a ``git repo``, ``local dir``, or ``tarball url`` chart             |"},{"line_number":136,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"},{"line_number":137,"context_line":"| dependencies    | object   | (optional) reference any chart dependencies before install.                           |"},{"line_number":138,"context_line":"|                 |          | Defaults to using the standard `Builtin Chart Dependencies`_ as the Helm CLI does.    |"},{"line_number":139,"context_line":"|                 |          | NOTE: Dependencies stored as \".tgz\" archives are not yet supported.                   |"},{"line_number":140,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_361e0f70","line":137,"range":{"start_line":137,"start_character":42,"end_line":137,"end_character":90},"updated":"2019-08-20 17:31:37.000000000","message":"Can you elaborate on what this means? In practice, it means that this key will point to other Armada chart documents to reference dependencies or look for dependencies in the source directory if this key is unused.","commit_id":"f502f33e9f2b02100be016662538b79c17781179"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"b3dad4d2c11843bf8abac02eb5a6289458517f47","unresolved":false,"context_lines":[{"line_number":134,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"},{"line_number":135,"context_line":"| source          | object   | provide a path to a ``git repo``, ``local dir``, or ``tarball url`` chart             |"},{"line_number":136,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"},{"line_number":137,"context_line":"| dependencies    | object   | (optional) reference any chart dependencies before install.                           |"},{"line_number":138,"context_line":"|                 |          | Defaults to using the standard `Builtin Chart Dependencies`_ as the Helm CLI does.    |"},{"line_number":139,"context_line":"|                 |          | NOTE: Dependencies stored as \".tgz\" archives are not yet supported.                   |"},{"line_number":140,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_e7e67fe7","line":137,"range":{"start_line":137,"start_character":42,"end_line":137,"end_character":90},"in_reply_to":"7faddb67_361e0f70","updated":"2019-08-20 19:18:35.000000000","message":"this was leftover, reworked this whole section","commit_id":"f502f33e9f2b02100be016662538b79c17781179"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"49f83f4b00a6ae123c55c636b4bfa9706eec44fb","unresolved":false,"context_lines":[{"line_number":135,"context_line":"| source          | object   | provide a path to a ``git repo``, ``local dir``, or ``tarball url`` chart             |"},{"line_number":136,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"},{"line_number":137,"context_line":"| dependencies    | object   | (optional) reference any chart dependencies before install.                           |"},{"line_number":138,"context_line":"|                 |          | Defaults to using the standard `Builtin Chart Dependencies`_ as the Helm CLI does.    |"},{"line_number":139,"context_line":"|                 |          | NOTE: Dependencies stored as \".tgz\" archives are not yet supported.                   |"},{"line_number":140,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"},{"line_number":141,"context_line":"| timeout         | int      | time (in seconds) allotted for chart to deploy when \u0027wait\u0027 flag is set (DEPRECATED)   |"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_a96f0090","line":138,"range":{"start_line":138,"start_character":92,"end_line":138,"end_character":113},"updated":"2019-08-20 17:31:37.000000000","message":"This implies that you can also use a requirements.yaml file. Can we specify that you cannot?","commit_id":"f502f33e9f2b02100be016662538b79c17781179"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"b3dad4d2c11843bf8abac02eb5a6289458517f47","unresolved":false,"context_lines":[{"line_number":135,"context_line":"| source          | object   | provide a path to a ``git repo``, ``local dir``, or ``tarball url`` chart             |"},{"line_number":136,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"},{"line_number":137,"context_line":"| dependencies    | object   | (optional) reference any chart dependencies before install.                           |"},{"line_number":138,"context_line":"|                 |          | Defaults to using the standard `Builtin Chart Dependencies`_ as the Helm CLI does.    |"},{"line_number":139,"context_line":"|                 |          | NOTE: Dependencies stored as \".tgz\" archives are not yet supported.                   |"},{"line_number":140,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"},{"line_number":141,"context_line":"| timeout         | int      | time (in seconds) allotted for chart to deploy when \u0027wait\u0027 flag is set (DEPRECATED)   |"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_07de3b10","line":138,"range":{"start_line":138,"start_character":92,"end_line":138,"end_character":113},"in_reply_to":"7faddb67_a96f0090","updated":"2019-08-20 19:18:35.000000000","message":"Removed reference to Helm CLI, as it is unnecessary.","commit_id":"f502f33e9f2b02100be016662538b79c17781179"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"88fc240adbd48af532f9d596184c65c77967bd40","unresolved":false,"context_lines":[{"line_number":135,"context_line":"| source          | object   | provide a path to a ``git repo``, ``local dir``, or ``tarball url`` chart             |"},{"line_number":136,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"},{"line_number":137,"context_line":"| dependencies    | object   | (optional) Override the `builtin chart dependencies`_ with a list of Chart documents  |"},{"line_number":138,"context_line":"|                 |          | to install use as dependencies instead.                                               |"},{"line_number":139,"context_line":"|                 |          | NOTE: Builtin \".tgz\" dependencies are not yet supported.                              |"},{"line_number":140,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"},{"line_number":141,"context_line":"| timeout         | int      | time (in seconds) allotted for chart to deploy when \u0027wait\u0027 flag is set (DEPRECATED)   |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7faddb67_d8879660","line":138,"range":{"start_line":138,"start_character":34,"end_line":138,"end_character":45},"updated":"2019-08-21 13:49:00.000000000","message":"Think \"and\" is missing here.","commit_id":"d72c0795fbe3242c2194a58f04a65926002a946e"}],"doc/source/operations/documents/v2/document-authoring.rst":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"49f83f4b00a6ae123c55c636b4bfa9706eec44fb","unresolved":false,"context_lines":[{"line_number":121,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"},{"line_number":122,"context_line":"| source          | object   | provide a path to a ``git repo``, ``local dir``, or ``tarball url`` chart             |"},{"line_number":123,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"},{"line_number":124,"context_line":"| dependencies    | object   | (optional) reference any chart dependencies before install.                           |"},{"line_number":125,"context_line":"|                 |          | Defaults to using the standard `Builtin Chart Dependencies`_ as the Helm CLI does.    |"},{"line_number":126,"context_line":"|                 |          | NOTE: Dependencies stored as \".tgz\" archives are not yet supported.                   |"},{"line_number":127,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_b620bfb1","line":124,"range":{"start_line":124,"start_character":42,"end_line":124,"end_character":90},"updated":"2019-08-20 17:31:37.000000000","message":"Same here.","commit_id":"f502f33e9f2b02100be016662538b79c17781179"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"49f83f4b00a6ae123c55c636b4bfa9706eec44fb","unresolved":false,"context_lines":[{"line_number":122,"context_line":"| source          | object   | provide a path to a ``git repo``, ``local dir``, or ``tarball url`` chart             |"},{"line_number":123,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"},{"line_number":124,"context_line":"| dependencies    | object   | (optional) reference any chart dependencies before install.                           |"},{"line_number":125,"context_line":"|                 |          | Defaults to using the standard `Builtin Chart Dependencies`_ as the Helm CLI does.    |"},{"line_number":126,"context_line":"|                 |          | NOTE: Dependencies stored as \".tgz\" archives are not yet supported.                   |"},{"line_number":127,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_090654cf","line":125,"range":{"start_line":125,"start_character":91,"end_line":125,"end_character":113},"updated":"2019-08-20 17:31:37.000000000","message":"Same here.","commit_id":"f502f33e9f2b02100be016662538b79c17781179"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"88fc240adbd48af532f9d596184c65c77967bd40","unresolved":false,"context_lines":[{"line_number":122,"context_line":"| source          | object   | provide a path to a ``git repo``, ``local dir``, or ``tarball url`` chart             |"},{"line_number":123,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"},{"line_number":124,"context_line":"| dependencies    | object   | (optional) Override the `builtin chart dependencies`_ with a list of Chart documents  |"},{"line_number":125,"context_line":"|                 |          | to install use as dependencies instead.                                               |"},{"line_number":126,"context_line":"|                 |          | NOTE: Builtin \".tgz\" dependencies are not yet supported.                              |"},{"line_number":127,"context_line":"+-----------------+----------+---------------------------------------------------------------------------------------+"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7faddb67_78c8e2a6","line":125,"range":{"start_line":125,"start_character":34,"end_line":125,"end_character":45},"updated":"2019-08-21 13:49:00.000000000","message":"Same here.","commit_id":"d72c0795fbe3242c2194a58f04a65926002a946e"}]}