)]}'
{"armada/handlers/chartbuilder.py":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"85aeb2e1d868e58401d9eb6453288f612e2e9bf7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from oslo_log import log as logging"},{"line_number":25,"context_line":"import yaml"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from armada.exceptions import chartbuilder_exceptions"},{"line_number":28,"context_line":"from armada.handlers.schema import get_schema_info"},{"line_number":29,"context_line":"from armada import const"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_3a51840f","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":24},"updated":"2019-09-11 12:55:49.000000000","message":"nit: import order, see [0]\n[0] https://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"7fa13e9d5fe296b10f4f8614bead6b27de6d41e2"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"d36c3cc13ed3e7d556006bfe8ab8ffc26ead2385","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from oslo_log import log as logging"},{"line_number":25,"context_line":"import yaml"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from armada.exceptions import chartbuilder_exceptions"},{"line_number":28,"context_line":"from armada.handlers.schema import get_schema_info"},{"line_number":29,"context_line":"from armada import const"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_d6a4e9bb","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":24},"in_reply_to":"3fa7e38b_bfd6194f","updated":"2019-09-19 19:39:20.000000000","message":"Done","commit_id":"7fa13e9d5fe296b10f4f8614bead6b27de6d41e2"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"373833afd6ae85e3d08576ef41ddeb73dec75da8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from oslo_log import log as logging"},{"line_number":25,"context_line":"import yaml"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from armada.exceptions import chartbuilder_exceptions"},{"line_number":28,"context_line":"from armada.handlers.schema import get_schema_info"},{"line_number":29,"context_line":"from armada import const"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_bfd6194f","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":24},"in_reply_to":"5faad753_02d3f661","updated":"2019-09-17 12:38:26.000000000","message":"We added an import check to Pegleg to conform with these rules.  From that check it would be\n\nfrom armada import const\nfrom armada.exceptions import chartbuilder_exceptions\nfrom armada.handlers.schema import get_schema_info\n\nsince these get interpreted as\narmada.const\narmada.exceptions.chartbuilder_exceptions\narmada.handlers.schema.get_schema_info","commit_id":"7fa13e9d5fe296b10f4f8614bead6b27de6d41e2"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"ffe91f06de6c9940acea5ec1fe31ec94dc85f780","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from oslo_log import log as logging"},{"line_number":25,"context_line":"import yaml"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from armada.exceptions import chartbuilder_exceptions"},{"line_number":28,"context_line":"from armada.handlers.schema import get_schema_info"},{"line_number":29,"context_line":"from armada import const"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_02d3f661","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":24},"in_reply_to":"5faad753_3a51840f","updated":"2019-09-11 18:07:20.000000000","message":"as far as I can tell this matches the import order. it mentions \"full module path\", but that could be interpreted as either `armada` or `armada.const` for the last import here, and considering it says \"human alphabetic order\", that makes me interpret it as `armada`, and also the \"real world example\" seems to suggest this ordering is correct, though it\u0027s not 100% clear.","commit_id":"7fa13e9d5fe296b10f4f8614bead6b27de6d41e2"}]}