)]}'
{"armada/cli/apply_chart.py":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9dff843ee4bd87b586f04397893c6b1c773b94b2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 The Armada Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_b888e56b","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2020-01-22 17:10:11.000000000","message":"Was this copied from another file verbatim? It is 2020, happy new year :)","commit_id":"c820d252ece472b416a3136e8c55cfe61b4694e6"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"aab14902671127d239432b8ff863296b3df1d1db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 The Armada Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_39cb8573","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"in_reply_to":"3fa7e38b_b888e56b","updated":"2020-01-23 21:18:21.000000000","message":"Done","commit_id":"c820d252ece472b416a3136e8c55cfe61b4694e6"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9dff843ee4bd87b586f04397893c6b1c773b94b2","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@click.group()"},{"line_number":34,"context_line":"def apply_chart():"},{"line_number":35,"context_line":"    \"\"\" Apply manifest to cluster"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    \"\"\""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_38eab50c","line":35,"range":{"start_line":35,"start_character":14,"end_line":35,"end_character":22},"updated":"2020-01-22 17:10:11.000000000","message":"Does this apply a whole manifest or a single chart?","commit_id":"c820d252ece472b416a3136e8c55cfe61b4694e6"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"aab14902671127d239432b8ff863296b3df1d1db","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@click.group()"},{"line_number":34,"context_line":"def apply_chart():"},{"line_number":35,"context_line":"    \"\"\" Apply manifest to cluster"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    \"\"\""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_f9c08d4d","line":35,"range":{"start_line":35,"start_character":14,"end_line":35,"end_character":22},"in_reply_to":"3fa7e38b_38eab50c","updated":"2020-01-23 21:18:21.000000000","message":"Done","commit_id":"c820d252ece472b416a3136e8c55cfe61b4694e6"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9dff843ee4bd87b586f04397893c6b1c773b94b2","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"@apply_chart.command(name\u003d\u0027apply_chart\u0027, help\u003dDESC, short_help\u003dSHORT_DESC)"},{"line_number":50,"context_line":"@click.argument(\u0027locations\u0027, nargs\u003d-1)"},{"line_number":51,"context_line":"@click.option(\u0027--release-prefix\u0027, help\u003d\"Release prefix to use.\", required\u003dTrue)"},{"line_number":52,"context_line":"@click.option("},{"line_number":53,"context_line":"    \u0027--disable-update-post\u0027,"},{"line_number":54,"context_line":"    help\u003d\"Disable post-update Tiller operations.\","}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_18bed9ff","line":51,"range":{"start_line":51,"start_character":40,"end_line":51,"end_character":62},"updated":"2020-01-22 17:10:11.000000000","message":"This might be non-obvious when using the CLI mode, since one may not be reading the authoring documentation.\n\nCould we make this a bit more descriptive? Something like, \"Prefix prepended to chart release name.\"","commit_id":"c820d252ece472b416a3136e8c55cfe61b4694e6"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"aab14902671127d239432b8ff863296b3df1d1db","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"@apply_chart.command(name\u003d\u0027apply_chart\u0027, help\u003dDESC, short_help\u003dSHORT_DESC)"},{"line_number":50,"context_line":"@click.argument(\u0027locations\u0027, nargs\u003d-1)"},{"line_number":51,"context_line":"@click.option(\u0027--release-prefix\u0027, help\u003d\"Release prefix to use.\", required\u003dTrue)"},{"line_number":52,"context_line":"@click.option("},{"line_number":53,"context_line":"    \u0027--disable-update-post\u0027,"},{"line_number":54,"context_line":"    help\u003d\"Disable post-update Tiller operations.\","}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_19bec9cd","line":51,"range":{"start_line":51,"start_character":40,"end_line":51,"end_character":62},"in_reply_to":"3fa7e38b_18bed9ff","updated":"2020-01-23 21:18:21.000000000","message":"Done","commit_id":"c820d252ece472b416a3136e8c55cfe61b4694e6"}],"armada/handlers/chart_download.py":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9dff843ee4bd87b586f04397893c6b1c773b94b2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 The Armada Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_d8f601d6","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2020-01-22 17:10:11.000000000","message":"2020?","commit_id":"c820d252ece472b416a3136e8c55cfe61b4694e6"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"aab14902671127d239432b8ff863296b3df1d1db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 The Armada Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_b99c5570","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"in_reply_to":"3fa7e38b_d8f601d6","updated":"2020-01-23 21:18:21.000000000","message":"Done","commit_id":"c820d252ece472b416a3136e8c55cfe61b4694e6"}],"armada/handlers/manifest.py":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9dff843ee4bd87b586f04397893c6b1c773b94b2","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _get_target_doc(self, sch, documents, target, target_arg_name):"},{"line_number":60,"context_line":"        \"\"\"Validates there is exactly one document of a given schema and"},{"line_number":61,"context_line":"        optionally ame and returns it."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        :param sch: Schema which corresponds to `documents`."},{"line_number":64,"context_line":"        :param documents: Documents which correspond to `sch`."}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_98bc09dc","line":61,"range":{"start_line":61,"start_character":19,"end_line":61,"end_character":22},"updated":"2020-01-22 17:10:11.000000000","message":"name","commit_id":"c820d252ece472b416a3136e8c55cfe61b4694e6"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9dff843ee4bd87b586f04397893c6b1c773b94b2","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        if len(candidates) \u003e 1:"},{"line_number":80,"context_line":"            error \u003d ("},{"line_number":81,"context_line":"                \u0027Multiple {} are not supported. Ensure that the `{}` option is\u0027"},{"line_number":82,"context_line":"                \u0027set to specify the target one\u0027).format(sch, target_arg_name)"},{"line_number":83,"context_line":"            LOG.error(error)"},{"line_number":84,"context_line":"            raise exceptions.ManifestException(details\u003derror)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_b8954540","line":81,"updated":"2020-01-22 17:10:11.000000000","message":"I think you\u0027ll need an \u0027s\u0027 here.\n\nmanifest(s)\nchart(s)\ngroup(s)","commit_id":"c820d252ece472b416a3136e8c55cfe61b4694e6"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9dff843ee4bd87b586f04397893c6b1c773b94b2","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            group document with the specified name is not found"},{"line_number":212,"context_line":"        \"\"\""},{"line_number":213,"context_line":"        for group in self.groups:"},{"line_number":214,"context_line":"            if group.get(\u0027metadata\u0027, {}).get(\u0027name\u0027) \u003d\u003d name:"},{"line_number":215,"context_line":"                return group"},{"line_number":216,"context_line":"        raise exceptions.BuildChartGroupException("},{"line_number":217,"context_line":"            details\u003d\u0027Could not find {} named \"{}\"\u0027.format("},{"line_number":218,"context_line":"                schema.TYPE_CHARTGROUP, name))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_580a1178","line":215,"range":{"start_line":214,"start_character":12,"end_line":215,"end_character":28},"updated":"2020-01-22 17:10:11.000000000","message":"We shouldn\u0027t have multiple ChartGroups with the same name, right? If these rules are used for validation, then I suspect that this would not raise an error if there were two ChartGroups with the same name. As an operator, that\u0027s something that should be known ahead of time. Otherwise, you may have unexpected results at deployment time (i.e. one of your chart groups never gets deployed).","commit_id":"c820d252ece472b416a3136e8c55cfe61b4694e6"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"aab14902671127d239432b8ff863296b3df1d1db","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            group document with the specified name is not found"},{"line_number":212,"context_line":"        \"\"\""},{"line_number":213,"context_line":"        for group in self.groups:"},{"line_number":214,"context_line":"            if group.get(\u0027metadata\u0027, {}).get(\u0027name\u0027) \u003d\u003d name:"},{"line_number":215,"context_line":"                return group"},{"line_number":216,"context_line":"        raise exceptions.BuildChartGroupException("},{"line_number":217,"context_line":"            details\u003d\u0027Could not find {} named \"{}\"\u0027.format("},{"line_number":218,"context_line":"                schema.TYPE_CHARTGROUP, name))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_a763e018","line":215,"range":{"start_line":214,"start_character":12,"end_line":215,"end_character":28},"in_reply_to":"3fa7e38b_580a1178","updated":"2020-01-23 21:18:21.000000000","message":"Deckhand already validates a unique identifier (schema+name) for each document. For Airship 2 we\u0027ll be moving to CRs, so kubernetes in that case will validate a unique identifier for the CR.","commit_id":"c820d252ece472b416a3136e8c55cfe61b4694e6"}]}
