)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"0a6eacbd4c2c996de54858e0353d90cc3ddba69e","unresolved":true,"context_lines":[{"line_number":10,"context_line":"API if the resource was not found. However, some resources, like"},{"line_number":11,"context_line":"jobs, are \"volatile\" they may disappear after some minutes. The armada"},{"line_number":12,"context_line":"may send a DELETE request to the Kubernetes API after the job finished"},{"line_number":13,"context_line":"its lifecycle. In this situation the job will not be found in the cluster"},{"line_number":14,"context_line":"and the armada will break some application reapply due to this behavior."},{"line_number":15,"context_line":"Therefore, a possible solution may be check, at least for the job resource"},{"line_number":16,"context_line":"type, whether the response returned from the Kubernetes API is 404, if it"},{"line_number":17,"context_line":"is then just log the API response error reason and continue trying to delete"},{"line_number":18,"context_line":"the remaining jobs in the list, otherwise we raise the exception."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Signed-off-by: Iago Estrela \u003cIagoFilipe.EstrelaBarros@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"45b211a4_3aaf3e76","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":76},"updated":"2021-10-25 19:38:43.000000000","message":"Refer to the following guidelines:\nhttps://confluence.wrs.com/display/TITANIUM/Commit+Message+Guidelines","commit_id":"e17776a0f4567f2a59708698b9c540ab839593ef"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"9442d6055fb988daa78d76f18af9a040fc0a1a40","unresolved":true,"context_lines":[{"line_number":10,"context_line":"API if the resource was not found. However, some resources, like"},{"line_number":11,"context_line":"jobs, are \"volatile\" they may disappear after some minutes. The armada"},{"line_number":12,"context_line":"may send a DELETE request to the Kubernetes API after the job finished"},{"line_number":13,"context_line":"its lifecycle. In this situation the job will not be found in the cluster"},{"line_number":14,"context_line":"and the armada will break some application reapply due to this behavior."},{"line_number":15,"context_line":"Therefore, a possible solution may be check, at least for the job resource"},{"line_number":16,"context_line":"type, whether the response returned from the Kubernetes API is 404, if it"},{"line_number":17,"context_line":"is then just log the API response error reason and continue trying to delete"},{"line_number":18,"context_line":"the remaining jobs in the list, otherwise we raise the exception."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Signed-off-by: Iago Estrela \u003cIagoFilipe.EstrelaBarros@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"740dba0b_d73d4d88","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":76},"updated":"2021-10-20 20:47:04.000000000","message":"nit: these broken lines could be fixed to improve readability","commit_id":"e17776a0f4567f2a59708698b9c540ab839593ef"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"43f7ae652c10dbe3618a5ff8548b8656834cac07","unresolved":false,"context_lines":[{"line_number":10,"context_line":"API if the resource was not found. However, some resources, like"},{"line_number":11,"context_line":"jobs, are \"volatile\" they may disappear after some minutes. The armada"},{"line_number":12,"context_line":"may send a DELETE request to the Kubernetes API after the job finished"},{"line_number":13,"context_line":"its lifecycle. In this situation the job will not be found in the cluster"},{"line_number":14,"context_line":"and the armada will break some application reapply due to this behavior."},{"line_number":15,"context_line":"Therefore, a possible solution may be check, at least for the job resource"},{"line_number":16,"context_line":"type, whether the response returned from the Kubernetes API is 404, if it"},{"line_number":17,"context_line":"is then just log the API response error reason and continue trying to delete"},{"line_number":18,"context_line":"the remaining jobs in the list, otherwise we raise the exception."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Signed-off-by: Iago Estrela \u003cIagoFilipe.EstrelaBarros@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3bc1f008_ebff72b9","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":76},"in_reply_to":"47d15155_caf27ed0","updated":"2021-11-09 16:40:39.000000000","message":"Done","commit_id":"e17776a0f4567f2a59708698b9c540ab839593ef"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"7f5d7041c64fb12363377a2573e26af4fc9fb2ff","unresolved":true,"context_lines":[{"line_number":10,"context_line":"API if the resource was not found. However, some resources, like"},{"line_number":11,"context_line":"jobs, are \"volatile\" they may disappear after some minutes. The armada"},{"line_number":12,"context_line":"may send a DELETE request to the Kubernetes API after the job finished"},{"line_number":13,"context_line":"its lifecycle. In this situation the job will not be found in the cluster"},{"line_number":14,"context_line":"and the armada will break some application reapply due to this behavior."},{"line_number":15,"context_line":"Therefore, a possible solution may be check, at least for the job resource"},{"line_number":16,"context_line":"type, whether the response returned from the Kubernetes API is 404, if it"},{"line_number":17,"context_line":"is then just log the API response error reason and continue trying to delete"},{"line_number":18,"context_line":"the remaining jobs in the list, otherwise we raise the exception."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Signed-off-by: Iago Estrela \u003cIagoFilipe.EstrelaBarros@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"47d15155_caf27ed0","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":76},"in_reply_to":"740dba0b_d73d4d88","updated":"2021-10-26 16:46:35.000000000","message":"They should be fixed.  Such lines must not go past 80 chars.","commit_id":"e17776a0f4567f2a59708698b9c540ab839593ef"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"7f5d7041c64fb12363377a2573e26af4fc9fb2ff","unresolved":true,"context_lines":[{"line_number":16,"context_line":"type, whether the response returned from the Kubernetes API is 404, if it"},{"line_number":17,"context_line":"is then just log the API response error reason and continue trying to delete"},{"line_number":18,"context_line":"the remaining jobs in the list, otherwise we raise the exception."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Signed-off-by: Iago Estrela \u003cIagoFilipe.EstrelaBarros@windriver.com\u003e"},{"line_number":21,"context_line":"Change-Id: I12ee8cef869e4443920d7f2e1899556e8940a977"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1c67d704_d1c0d1d5","line":19,"updated":"2021-10-26 16:46:35.000000000","message":"This commit must reference a bug report or a story/task.","commit_id":"e17776a0f4567f2a59708698b9c540ab839593ef"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"43f7ae652c10dbe3618a5ff8548b8656834cac07","unresolved":false,"context_lines":[{"line_number":16,"context_line":"type, whether the response returned from the Kubernetes API is 404, if it"},{"line_number":17,"context_line":"is then just log the API response error reason and continue trying to delete"},{"line_number":18,"context_line":"the remaining jobs in the list, otherwise we raise the exception."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Signed-off-by: Iago Estrela \u003cIagoFilipe.EstrelaBarros@windriver.com\u003e"},{"line_number":21,"context_line":"Change-Id: I12ee8cef869e4443920d7f2e1899556e8940a977"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"25583ccb_4cff3590","line":19,"in_reply_to":"1c67d704_d1c0d1d5","updated":"2021-11-09 16:40:39.000000000","message":"Done","commit_id":"e17776a0f4567f2a59708698b9c540ab839593ef"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"8c47108084ba4a20b1dea6e61d8586758d0c0c5d","unresolved":true,"context_lines":[{"line_number":18,"context_line":"error reason and continue trying to delete the remaining jobs in the"},{"line_number":19,"context_line":"list, otherwise we raise the exception."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Launchpad: https://bugs.launchpad.net/starlingx/+bug/1948850"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Signed-off-by: Iago Estrela \u003cIagoFilipe.EstrelaBarros@windriver.com\u003e"},{"line_number":24,"context_line":"Change-Id: I12ee8cef869e4443920d7f2e1899556e8940a977"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"07aa7e7d_8a0cb517","line":21,"updated":"2021-10-26 20:25:29.000000000","message":"This should be:\nCloses-Bug: 1948850\n\nor\nPartial-Bug: 1948850\nif more than one commit is required to close it.  The final commit which closes it off should have the Closes-Bug in it.  These tags cause automatic actions to occur to the database.  See how the tools automatically change those tags into clickable links?","commit_id":"97d780601b5bb8d9abdc1ab54b605ee6ca1bc7bd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"f49468cd46ee3178cb39528219b75e41540b6ac8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3527106a_5de342bd","updated":"2021-10-22 21:34:07.000000000","message":"LGTM","commit_id":"e17776a0f4567f2a59708698b9c540ab839593ef"},{"author":{"_account_id":32618,"name":"Daniel de Oliveira Pereira","display_name":"Daniel Pereira","email":"Daniel.Pereira@windriver.com","username":"danielpereira01"},"change_message_id":"0c530d8869970ac493dda5ae294b90da0eeabfa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de76a0f1_a1ef7419","updated":"2021-10-21 18:03:36.000000000","message":"LGTM.","commit_id":"e17776a0f4567f2a59708698b9c540ab839593ef"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"7f5d7041c64fb12363377a2573e26af4fc9fb2ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9b990ae4_1f2dfa22","updated":"2021-10-26 16:46:35.000000000","message":"Proper housekeeping.","commit_id":"e17776a0f4567f2a59708698b9c540ab839593ef"},{"author":{"_account_id":32618,"name":"Daniel de Oliveira Pereira","display_name":"Daniel Pereira","email":"Daniel.Pereira@windriver.com","username":"danielpereira01"},"change_message_id":"78fd467c0e37e6576e967a6792f2e4f8bbaf1abd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"18b6ff03_29ae6500","updated":"2021-10-27 16:49:24.000000000","message":"LGTM","commit_id":"ddbdd7256c20f138737f6cbd772312f7a19f58b8"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"154308c01d3efcb9bc0b8dddd0a787bed148e69c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"68f8dc0f_3e591e64","updated":"2021-11-08 14:07:08.000000000","message":"Note to reviewers that this targets the helm2 branch which was created on request of starlingx which has not yet moved to helm 3.","commit_id":"ddbdd7256c20f138737f6cbd772312f7a19f58b8"}],"armada/handlers/tiller.py":[{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"0a6eacbd4c2c996de54858e0353d90cc3ddba69e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 The Armada Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"d74080ee_50147f44","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2021-10-25 19:38:43.000000000","message":"2021","commit_id":"e17776a0f4567f2a59708698b9c540ab839593ef"}]}
