)]}'
{"tools/gate/playbooks/airskiff-deploy.yaml":[{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"fc4b7164804d84672ebaf0bd42abcc7b15fc5e4d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      args:"},{"line_number":31,"context_line":"        chdir: \"{{ zuul.projects[\u0027opendev.org/airship/treasuremap\u0027].src_dir }}\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - name: Setup Apparmor"},{"line_number":34,"context_line":"      shell: |"},{"line_number":35,"context_line":"        ./tools/deployment/airskiff/developer/015-setup-apparmor.sh"},{"line_number":36,"context_line":"      args:"},{"line_number":37,"context_line":"        chdir: \"{{ zuul.projects[\u0027opendev.org/airship/treasuremap\u0027].src_dir }}\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    - name: Deploy Kubernetes with Minikube"},{"line_number":40,"context_line":"      shell: |"},{"line_number":41,"context_line":"        ./tools/deployment/airskiff/developer/010-deploy-k8s.sh"},{"line_number":42,"context_line":"      args:"},{"line_number":43,"context_line":"        chdir: \"{{ zuul.projects[\u0027opendev.org/airship/treasuremap\u0027].src_dir }}\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    - name: Setup OpenStack Client"},{"line_number":46,"context_line":"      shell: |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_1291a945","line":43,"range":{"start_line":33,"start_character":0,"end_line":43,"end_character":79},"updated":"2020-02-12 20:55:22.000000000","message":"Shouldn\u0027t these be run in an order that matches the script prefix numbering? i.e., 010 should run before 015 - otherwise the script prefix should be updated to be lower than 010?","commit_id":"33f58ecef74ad15b67642bd9fc05ce87e525d656"},{"author":{"_account_id":29144,"name":"PRATEEK REDDY DODDA","email":"prateek.reddy.dodda@att.com","username":"pd2839"},"change_message_id":"797e0a0e459e92d114ff15c486317d1e3e093c9b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      args:"},{"line_number":31,"context_line":"        chdir: \"{{ zuul.projects[\u0027opendev.org/airship/treasuremap\u0027].src_dir }}\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - name: Setup Apparmor"},{"line_number":34,"context_line":"      shell: |"},{"line_number":35,"context_line":"        ./tools/deployment/airskiff/developer/015-setup-apparmor.sh"},{"line_number":36,"context_line":"      args:"},{"line_number":37,"context_line":"        chdir: \"{{ zuul.projects[\u0027opendev.org/airship/treasuremap\u0027].src_dir }}\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    - name: Deploy Kubernetes with Minikube"},{"line_number":40,"context_line":"      shell: |"},{"line_number":41,"context_line":"        ./tools/deployment/airskiff/developer/010-deploy-k8s.sh"},{"line_number":42,"context_line":"      args:"},{"line_number":43,"context_line":"        chdir: \"{{ zuul.projects[\u0027opendev.org/airship/treasuremap\u0027].src_dir }}\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    - name: Setup OpenStack Client"},{"line_number":46,"context_line":"      shell: |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_b214559a","line":43,"range":{"start_line":33,"start_character":0,"end_line":43,"end_character":79},"in_reply_to":"3fa7e38b_1291a945","updated":"2020-02-12 21:06:08.000000000","message":"Thanks Craig for reviewing. Apparmor changes aren\u0027t applying if we run after deploying k8s.","commit_id":"33f58ecef74ad15b67642bd9fc05ce87e525d656"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"db2ae382500714115ee70004c2c1865442b19ae0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      args:"},{"line_number":31,"context_line":"        chdir: \"{{ zuul.projects[\u0027opendev.org/airship/treasuremap\u0027].src_dir }}\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - name: Setup Apparmor"},{"line_number":34,"context_line":"      shell: |"},{"line_number":35,"context_line":"        ./tools/deployment/airskiff/developer/015-setup-apparmor.sh"},{"line_number":36,"context_line":"      args:"},{"line_number":37,"context_line":"        chdir: \"{{ zuul.projects[\u0027opendev.org/airship/treasuremap\u0027].src_dir }}\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    - name: Deploy Kubernetes with Minikube"},{"line_number":40,"context_line":"      shell: |"},{"line_number":41,"context_line":"        ./tools/deployment/airskiff/developer/010-deploy-k8s.sh"},{"line_number":42,"context_line":"      args:"},{"line_number":43,"context_line":"        chdir: \"{{ zuul.projects[\u0027opendev.org/airship/treasuremap\u0027].src_dir }}\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    - name: Setup OpenStack Client"},{"line_number":46,"context_line":"      shell: |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_f27f2db9","line":43,"range":{"start_line":33,"start_character":0,"end_line":43,"end_character":79},"in_reply_to":"3fa7e38b_b214559a","updated":"2020-02-12 21:14:08.000000000","message":"apparmor setup script shoudl be renamed then. Otherwise, anyone who takes this upstream code will think from this numbering that 015 script runs after 010 script. Rename 015-setup-apparmor.sh to something like 009-setup-apparmor.sh","commit_id":"33f58ecef74ad15b67642bd9fc05ce87e525d656"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"6a93a52861e9d71217489da72ea9aa584b446598","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - name: Setup Apparmor"},{"line_number":34,"context_line":"      shell: |"},{"line_number":35,"context_line":"        ./tools/deployment/airskiff/developer/009-setup-apparmor.sh"},{"line_number":36,"context_line":"      args:"},{"line_number":37,"context_line":"        chdir: \"{{ zuul.projects[\u0027opendev.org/airship/treasuremap\u0027].src_dir }}\""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_52488188","line":35,"range":{"start_line":35,"start_character":46,"end_line":35,"end_character":67},"updated":"2020-02-12 21:18:27.000000000","message":"You\u0027ll also need to rename this file in the repo to match. Right now this file doesn\u0027t exist in the repo.","commit_id":"d351cba993fc8e75e8baf6ee45b8ee4dad77d0b7"},{"author":{"_account_id":29144,"name":"PRATEEK REDDY DODDA","email":"prateek.reddy.dodda@att.com","username":"pd2839"},"change_message_id":"42ba8d3a7b09dfed68f217edbf13164f6a359ff0","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - name: Setup Apparmor"},{"line_number":34,"context_line":"      shell: |"},{"line_number":35,"context_line":"        ./tools/deployment/airskiff/developer/009-setup-apparmor.sh"},{"line_number":36,"context_line":"      args:"},{"line_number":37,"context_line":"        chdir: \"{{ zuul.projects[\u0027opendev.org/airship/treasuremap\u0027].src_dir }}\""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_f21bad80","line":35,"range":{"start_line":35,"start_character":46,"end_line":35,"end_character":67},"in_reply_to":"3fa7e38b_52488188","updated":"2020-02-12 21:20:26.000000000","message":"sure Craig. Working on that","commit_id":"d351cba993fc8e75e8baf6ee45b8ee4dad77d0b7"}]}