)]}'
{"Makefile":[{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"d894adb5423ff0d507789e48e82d8d1f6652cb62","unresolved":false,"context_lines":[{"line_number":42,"context_line":"build_docs:"},{"line_number":43,"context_line":"\ttox -e docs"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":".PHONY: clean"},{"line_number":46,"context_line":"clean:"},{"line_number":47,"context_line":"\trm -rf doc/build"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# testing checks"},{"line_number":50,"context_line":".PHONY: tests"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7faddb67_9fb8c12a","line":47,"range":{"start_line":45,"start_character":0,"end_line":47,"end_character":17},"updated":"2019-07-09 16:40:55.000000000","message":"isn\u0027t this redunant since it\u0027s already handled by tox -e docs","commit_id":"a190abaebef1a23979193966d2bbf63fc5bd907e"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"7b31d6d7c9099b1e3e3fa1b1856d303909ca80fb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"build_docs:"},{"line_number":43,"context_line":"\ttox -e docs"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":".PHONY: clean"},{"line_number":46,"context_line":"clean:"},{"line_number":47,"context_line":"\trm -rf doc/build"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# testing checks"},{"line_number":50,"context_line":".PHONY: tests"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7faddb67_411b3880","line":47,"range":{"start_line":45,"start_character":0,"end_line":47,"end_character":17},"in_reply_to":"7faddb67_9fb8c12a","updated":"2019-07-10 16:58:53.000000000","message":"Probably. But I got used to run `make clean` in other Airship components to clean up things after build attempt.","commit_id":"a190abaebef1a23979193966d2bbf63fc5bd907e"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"d894adb5423ff0d507789e48e82d8d1f6652cb62","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# testing checks"},{"line_number":50,"context_line":".PHONY: tests"},{"line_number":51,"context_line":"tests: check-tox"},{"line_number":52,"context_line":"\ttox"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7faddb67_7f9e25b9","line":52,"range":{"start_line":52,"start_character":1,"end_line":52,"end_character":4},"updated":"2019-07-09 16:40:55.000000000","message":"since the default envlist in tox.ini is now \"docs\", shouldn\u0027t this now be:\n\ntox -e testenv","commit_id":"a190abaebef1a23979193966d2bbf63fc5bd907e"},{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"5eb279b5b50660f9e72349e1c2bb61a22682de7a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# testing checks"},{"line_number":50,"context_line":".PHONY: tests"},{"line_number":51,"context_line":"tests: check-tox"},{"line_number":52,"context_line":"\ttox"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7faddb67_79314cec","line":52,"range":{"start_line":52,"start_character":1,"end_line":52,"end_character":4},"in_reply_to":"7faddb67_6c350bf7","updated":"2019-07-10 17:54:03.000000000","message":"Running just `tox` will run every job in envlist. This is correct as is.","commit_id":"a190abaebef1a23979193966d2bbf63fc5bd907e"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"7b31d6d7c9099b1e3e3fa1b1856d303909ca80fb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# testing checks"},{"line_number":50,"context_line":".PHONY: tests"},{"line_number":51,"context_line":"tests: check-tox"},{"line_number":52,"context_line":"\ttox"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7faddb67_6c350bf7","line":52,"range":{"start_line":52,"start_character":1,"end_line":52,"end_character":4},"in_reply_to":"7faddb67_7f9e25b9","updated":"2019-07-10 16:58:53.000000000","message":"No, it will drop error `ERROR: unknown environment \u0027testenv\u0027`.","commit_id":"a190abaebef1a23979193966d2bbf63fc5bd907e"}],"doc/requirements.txt":[{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"5eb279b5b50660f9e72349e1c2bb61a22682de7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7faddb67_599250a0","updated":"2019-07-10 17:54:03.000000000","message":"Missing sphinx\u003e2.1.0","commit_id":"65089c2b3116f05ec1ea435365a5ad7c4f19c6af"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"ad1c9ae7d2a13abca007b72e4e6ae7bfbdee8869","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7faddb67_da5f0370","in_reply_to":"7faddb67_599250a0","updated":"2019-07-11 12:25:01.000000000","message":"Why? By default it would be the latest version, which is currently 2.1.2 (RTD prefers 2.x over 3.x).","commit_id":"65089c2b3116f05ec1ea435365a5ad7c4f19c6af"},{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"a981cce448946fe98d0bb019ae5c547c8a1143b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7faddb67_6c688486","in_reply_to":"7faddb67_71eb7fdb","updated":"2019-07-12 14:45:07.000000000","message":"That\u0027s more for full applications, pip freeze is a little overkill for this as we shouldn\u0027t need hard pegs for doc builds. I would rather have more detail though than less. I\u0027ll approve it and let others voice their opinions","commit_id":"65089c2b3116f05ec1ea435365a5ad7c4f19c6af"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"2ba632e1849751fc99c022c36809b450ff185b87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7faddb67_71eb7fdb","in_reply_to":"7faddb67_76b05544","updated":"2019-07-12 13:59:39.000000000","message":"Done. Updated requirements.txt file with requirements from `pip freeze`, as it is recommended in documentation [0] and best practices (multiple sources).\n\n[0] https://pip.pypa.io/en/latest/user_guide/#requirements-files","commit_id":"65089c2b3116f05ec1ea435365a5ad7c4f19c6af"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"37e945f417129ba6d5d7eba166ebffa2b0444341","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7faddb67_eb8b011c","in_reply_to":"7faddb67_96a2bcfb","updated":"2019-07-12 08:28:19.000000000","message":"Why should it be explicitly defined? Build works, docs are being built, sphinx version which is used during the build is 2.1.2 by default.","commit_id":"65089c2b3116f05ec1ea435365a5ad7c4f19c6af"},{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"c1d1419be5cc20c906b6d67c3c12a657364fade3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7faddb67_96a2bcfb","in_reply_to":"7faddb67_da5f0370","updated":"2019-07-11 20:34:19.000000000","message":"No I mean you literally don\u0027t have it defined here in the requirements. Other projects have just been doing a peg of sphinx\u003e2.1.0 because of the bug in 2.1.0. You can leave it unpegged, but it still should be defined.","commit_id":"65089c2b3116f05ec1ea435365a5ad7c4f19c6af"},{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"da4b2fef436bc6c54e1c14b50b668db4ce5523c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7faddb67_76b05544","in_reply_to":"7faddb67_eb8b011c","updated":"2019-07-12 12:59:48.000000000","message":"Because it\u0027s a requirement for the docs to be built. It should still be noted even if it\u0027s installed by sphinx_rtd_theme. It\u0027s a best practice. Explicitly including it makes sure that Sphinx installs every time on any environment we run this job on. It\u0027s also done this way in almost every other project. Consistency is important too.","commit_id":"65089c2b3116f05ec1ea435365a5ad7c4f19c6af"}],"doc/source/conf.py":[{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"5eb279b5b50660f9e72349e1c2bb61a22682de7a","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# The theme to use for HTML and HTML Help pages.  See the documentation for"},{"line_number":110,"context_line":"# a list of builtin themes."},{"line_number":111,"context_line":"import sphinx_rtd_theme"},{"line_number":112,"context_line":"html_theme \u003d \u0027sphinx_rtd_theme\u0027"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# Theme options are theme-specific and customize the look and feel of a theme"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_d9f3a009","line":111,"updated":"2019-07-10 17:54:03.000000000","message":"Put this with the other imports in accordance with PEP-8 style","commit_id":"65089c2b3116f05ec1ea435365a5ad7c4f19c6af"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"ad1c9ae7d2a13abca007b72e4e6ae7bfbdee8869","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# The theme to use for HTML and HTML Help pages.  See the documentation for"},{"line_number":110,"context_line":"# a list of builtin themes."},{"line_number":111,"context_line":"import sphinx_rtd_theme"},{"line_number":112,"context_line":"html_theme \u003d \u0027sphinx_rtd_theme\u0027"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# Theme options are theme-specific and customize the look and feel of a theme"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_7adb6fec","line":111,"in_reply_to":"7faddb67_d9f3a009","updated":"2019-07-11 12:25:01.000000000","message":"Done","commit_id":"65089c2b3116f05ec1ea435365a5ad7c4f19c6af"}],"doc/source/index.rst":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"30a9299b6e84dbb0692e087164b61027a727196a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"   You can adapt this file completely to your liking, but it should at least"},{"line_number":4,"context_line":"   contain the root `toctree` directive."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Welcome to Airship Project\u0027s documentation!"},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Contents:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7faddb67_bca6eb52","line":6,"updated":"2019-07-09 16:37:35.000000000","message":"nit: can we please update to \"Welcome to Airship documentation\" ?\n\nI tried to see what the norm was for open source projects, and I think the above is reasonable\n\nhttps://www.google.com/search?client\u003dubuntu\u0026hs\u003dqXb\u0026channel\u003dfs\u0026ei\u003dBsIkXfTjAo_5tAbsh5qABw\u0026q\u003d%22welcome+to%22+documentation+%22open+source%22\u0026oq\u003d%22welcome+to%22+documentation+%22open+source%22\u0026gs_l\u003dpsy-ab.3..33i22i29i30l6.9500.15681..15920...0.0..0.100.2933.39j1......0....1..gws-wiz.......0i71j0i67j0i131j0j0i22i30j0i22i10i30.0R7gxiYCNHg\n\nhttps://docs.openstack.org/stein/","commit_id":"a190abaebef1a23979193966d2bbf63fc5bd907e"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"7b31d6d7c9099b1e3e3fa1b1856d303909ca80fb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"   You can adapt this file completely to your liking, but it should at least"},{"line_number":4,"context_line":"   contain the root `toctree` directive."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Welcome to Airship Project\u0027s documentation!"},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Contents:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7faddb67_e15b4451","line":6,"in_reply_to":"7faddb67_bca6eb52","updated":"2019-07-10 16:58:53.000000000","message":"Done","commit_id":"a190abaebef1a23979193966d2bbf63fc5bd907e"}],"tox.ini":[{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"9d5e041f558124000f187ca7528a072b33669e8e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"skipsdist \u003d True"},{"line_number":3,"context_line":"envlist \u003d py35"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[testenv]"},{"line_number":6,"context_line":"passenv\u003dHTTP_PROXY HTTPS_PROXY http_proxy https_proxy NO_PROXY no_proxy"}],"source_content_type":"text/x-properties","patch_set":2,"id":"9fb8cfa7_f3b649f9","line":3,"updated":"2019-06-28 20:58:37.000000000","message":"Shouldn\u0027t this just be `docs`?","commit_id":"0318e29dfae82faa4dd8399e4f8e70c286b17f58"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"c0232965491f72adbce8a965a5bacf64e00dd2b8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"skipsdist \u003d True"},{"line_number":3,"context_line":"envlist \u003d py35"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[testenv]"},{"line_number":6,"context_line":"passenv\u003dHTTP_PROXY HTTPS_PROXY http_proxy https_proxy NO_PROXY no_proxy"}],"source_content_type":"text/x-properties","patch_set":2,"id":"9fb8cfa7_cab00843","line":3,"in_reply_to":"9fb8cfa7_812c4002","updated":"2019-07-02 10:33:55.000000000","message":"We use `make docs` to build docs in Airship. But yes, that\u0027s would be good to be a default here. Thanks!","commit_id":"0318e29dfae82faa4dd8399e4f8e70c286b17f58"},{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"d4df9ec471726c5166ea0d34a04d1a6d2844e34f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"skipsdist \u003d True"},{"line_number":3,"context_line":"envlist \u003d py35"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[testenv]"},{"line_number":6,"context_line":"passenv\u003dHTTP_PROXY HTTPS_PROXY http_proxy https_proxy NO_PROXY no_proxy"}],"source_content_type":"text/x-properties","patch_set":2,"id":"9fb8cfa7_812c4002","line":3,"in_reply_to":"9fb8cfa7_8ada2748","updated":"2019-07-01 21:28:41.000000000","message":"I mean if you run `tox` here, it won\u0027t generate the docs. It would just run testenv with py35, which wouldn\u0027t execute anything. I suspect you would actually want to run testenv:docs by default so the envlist should be docs instead of py35","commit_id":"0318e29dfae82faa4dd8399e4f8e70c286b17f58"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"66ce189a4cd0b3fa72d03f6a4cac078b9c5b67f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"skipsdist \u003d True"},{"line_number":3,"context_line":"envlist \u003d py35"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[testenv]"},{"line_number":6,"context_line":"passenv\u003dHTTP_PROXY HTTPS_PROXY http_proxy https_proxy NO_PROXY no_proxy"}],"source_content_type":"text/x-properties","patch_set":2,"id":"9fb8cfa7_8ada2748","line":3,"in_reply_to":"9fb8cfa7_f3b649f9","updated":"2019-07-01 06:21:57.000000000","message":"No. [tox] section is obligatory here.","commit_id":"0318e29dfae82faa4dd8399e4f8e70c286b17f58"}]}