)]}'
{"charts/shipyard/templates/bin/_airflow-rabbit-auxiliary-configuration.sh.tpl":[{"author":{"_account_id":26365,"name":"Bryan Strassner","email":"strassner.bryan@gmail.com","username":"bryan-strassner"},"change_message_id":"0dbc4d8d2226be49d3b72fba9a70326652ffc998","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017 The Openstack-Helm Authors."}],"source_content_type":"text/x-smarty","patch_set":9,"id":"3f79a3b5_180bcc2c","line":1,"updated":"2018-11-12 16:54:10.000000000","message":"This appears to be a copy (with some stuff removed) of https://github.com/openstack/openstack-helm-infra/blob/b6fc24b9960bc6de29aa70c7d5b7725319046160/helm-toolkit/templates/scripts/_rabbit-init.sh.tpl  \n\nIs the additional stuff there (e.g.: managment of user and vhost) the reason we can\u0027t just reference that template? We already have dependencies on Helm Toolkit, and if we can reuse this, I think it would be good- if not, then this is what we have to do (or negotiate some conditionals into Helm Toolkit)","commit_id":"379ef8733476f7b5750f323af043b6c831b99850"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2f0cc2443134084a7fea33a1f3bc4ff825f199f8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017 The Openstack-Helm Authors."}],"source_content_type":"text/x-smarty","patch_set":9,"id":"3f79a3b5_533285c1","line":1,"in_reply_to":"3f79a3b5_180bcc2c","updated":"2018-11-12 17:12:26.000000000","message":"yup as it appears to me we either have to copypaste parts of it here or add conditionals into toolkit script. This is just a faster way to get this in without having to depend on changes in another component, but surely I can add conditionals as well.","commit_id":"379ef8733476f7b5750f323af043b6c831b99850"},{"author":{"_account_id":26449,"name":"Scott Hussey","email":"sthussey@att.com","username":"sh8121"},"change_message_id":"1faa5c5ce7cfb7d0a3433e0355d5d074b5f9a4d7","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"set -ex"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Extract connection details"},{"line_number":19,"context_line":"RABBIT_HOSTNAME\u003d$(echo \"${RABBITMQ_ADMIN_CONNECTION}\" | \\"},{"line_number":20,"context_line":"  awk -F\u0027[@]\u0027 \u0027{print $2}\u0027 | \\"},{"line_number":21,"context_line":"  awk -F\u0027[:/]\u0027 \u0027{print $1}\u0027)"},{"line_number":22,"context_line":"RABBIT_PORT\u003d$(echo \"${RABBITMQ_ADMIN_CONNECTION}\" | \\"},{"line_number":23,"context_line":"  awk -F\u0027[@]\u0027 \u0027{print $2}\u0027 | \\"},{"line_number":24,"context_line":"  awk -F\u0027[:/]\u0027 \u0027{print $2}\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Extract Admin User creadential"},{"line_number":27,"context_line":"RABBITMQ_ADMIN_USERNAME\u003d$(echo \"${RABBITMQ_ADMIN_CONNECTION}\" | \\"},{"line_number":28,"context_line":"  awk -F\u0027[@]\u0027 \u0027{print $1}\u0027 | \\"},{"line_number":29,"context_line":"  awk -F\u0027[//:]\u0027 \u0027{print $4}\u0027)"},{"line_number":30,"context_line":"RABBITMQ_ADMIN_PASSWORD\u003d$(echo \"${RABBITMQ_ADMIN_CONNECTION}\" | \\"},{"line_number":31,"context_line":"  awk -F\u0027[@]\u0027 \u0027{print $1}\u0027 | \\"},{"line_number":32,"context_line":"  awk -F\u0027[//:]\u0027 \u0027{print $5}\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"function rabbitmqadmin_cli () {"},{"line_number":35,"context_line":"  rabbitmqadmin \\"}],"source_content_type":"text/x-smarty","patch_set":9,"id":"3f79a3b5_e74c61ca","line":32,"range":{"start_line":18,"start_character":0,"end_line":32,"end_character":29},"updated":"2018-11-12 17:12:40.000000000","message":"Why not just render all of these variables from the chart configuration?","commit_id":"379ef8733476f7b5750f323af043b6c831b99850"},{"author":{"_account_id":26449,"name":"Scott Hussey","email":"sthussey@att.com","username":"sh8121"},"change_message_id":"956c82c60743cec9ef0216c05694104be037c203","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"set -ex"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Extract connection details"},{"line_number":19,"context_line":"RABBIT_HOSTNAME\u003d$(echo \"${RABBITMQ_ADMIN_CONNECTION}\" | \\"},{"line_number":20,"context_line":"  awk -F\u0027[@]\u0027 \u0027{print $2}\u0027 | \\"},{"line_number":21,"context_line":"  awk -F\u0027[:/]\u0027 \u0027{print $1}\u0027)"},{"line_number":22,"context_line":"RABBIT_PORT\u003d$(echo \"${RABBITMQ_ADMIN_CONNECTION}\" | \\"},{"line_number":23,"context_line":"  awk -F\u0027[@]\u0027 \u0027{print $2}\u0027 | \\"},{"line_number":24,"context_line":"  awk -F\u0027[:/]\u0027 \u0027{print $2}\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Extract Admin User creadential"},{"line_number":27,"context_line":"RABBITMQ_ADMIN_USERNAME\u003d$(echo \"${RABBITMQ_ADMIN_CONNECTION}\" | \\"},{"line_number":28,"context_line":"  awk -F\u0027[@]\u0027 \u0027{print $1}\u0027 | \\"},{"line_number":29,"context_line":"  awk -F\u0027[//:]\u0027 \u0027{print $4}\u0027)"},{"line_number":30,"context_line":"RABBITMQ_ADMIN_PASSWORD\u003d$(echo \"${RABBITMQ_ADMIN_CONNECTION}\" | \\"},{"line_number":31,"context_line":"  awk -F\u0027[@]\u0027 \u0027{print $1}\u0027 | \\"},{"line_number":32,"context_line":"  awk -F\u0027[//:]\u0027 \u0027{print $5}\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"function rabbitmqadmin_cli () {"},{"line_number":35,"context_line":"  rabbitmqadmin \\"}],"source_content_type":"text/x-smarty","patch_set":9,"id":"3f79a3b5_d4ce7157","line":32,"range":{"start_line":18,"start_character":0,"end_line":32,"end_character":29},"in_reply_to":"3f79a3b5_b3b759d1","updated":"2018-11-13 15:56:40.000000000","message":"Right, I was my talking about pulling pieces of it out. Rather than running these awk statements, you could just use the chart template to directly plug in values. However what you have is fine because then it does protect the data a bit by using a Kubernetes secret. So this comment can be ignored.","commit_id":"379ef8733476f7b5750f323af043b6c831b99850"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7b2e478b4f75dca201044f9b1082471c2431fc7d","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"set -ex"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Extract connection details"},{"line_number":19,"context_line":"RABBIT_HOSTNAME\u003d$(echo \"${RABBITMQ_ADMIN_CONNECTION}\" | \\"},{"line_number":20,"context_line":"  awk -F\u0027[@]\u0027 \u0027{print $2}\u0027 | \\"},{"line_number":21,"context_line":"  awk -F\u0027[:/]\u0027 \u0027{print $1}\u0027)"},{"line_number":22,"context_line":"RABBIT_PORT\u003d$(echo \"${RABBITMQ_ADMIN_CONNECTION}\" | \\"},{"line_number":23,"context_line":"  awk -F\u0027[@]\u0027 \u0027{print $2}\u0027 | \\"},{"line_number":24,"context_line":"  awk -F\u0027[:/]\u0027 \u0027{print $2}\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Extract Admin User creadential"},{"line_number":27,"context_line":"RABBITMQ_ADMIN_USERNAME\u003d$(echo \"${RABBITMQ_ADMIN_CONNECTION}\" | \\"},{"line_number":28,"context_line":"  awk -F\u0027[@]\u0027 \u0027{print $1}\u0027 | \\"},{"line_number":29,"context_line":"  awk -F\u0027[//:]\u0027 \u0027{print $4}\u0027)"},{"line_number":30,"context_line":"RABBITMQ_ADMIN_PASSWORD\u003d$(echo \"${RABBITMQ_ADMIN_CONNECTION}\" | \\"},{"line_number":31,"context_line":"  awk -F\u0027[@]\u0027 \u0027{print $1}\u0027 | \\"},{"line_number":32,"context_line":"  awk -F\u0027[//:]\u0027 \u0027{print $5}\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"function rabbitmqadmin_cli () {"},{"line_number":35,"context_line":"  rabbitmqadmin \\"}],"source_content_type":"text/x-smarty","patch_set":9,"id":"3f79a3b5_b3b759d1","line":32,"range":{"start_line":18,"start_character":0,"end_line":32,"end_character":29},"in_reply_to":"3f79a3b5_e74c61ca","updated":"2018-11-12 17:35:13.000000000","message":"this conforms to how transport_url is provided to openstack services https://github.com/openstack/oslo.messaging/blob/0410bcbf543a589f19eb145c2cc34852e24d2e5e/doc/source/admin/AMQP1.0.rst#transport-url-enable","commit_id":"379ef8733476f7b5750f323af043b6c831b99850"}],"charts/shipyard/templates/job-airflow-rabbit-auxiliary-configuration.yaml":[{"author":{"_account_id":26365,"name":"Bryan Strassner","email":"strassner.bryan@gmail.com","username":"bryan-strassner"},"change_message_id":"0dbc4d8d2226be49d3b72fba9a70326652ffc998","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_b32759af","line":1,"updated":"2018-11-12 16:54:10.000000000","message":"Same question on this vs. https://github.com/openstack/openstack-helm-infra/blob/master/helm-toolkit/templates/manifests/_job-rabbit-init.yaml.tpl","commit_id":"379ef8733476f7b5750f323af043b6c831b99850"}],"charts/shipyard/templates/job-rabbit-init.yaml":[{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"aedfd22ae6366c58551e0eb588f24f6bf7322ec4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3f79a3b5_98c25955","line":2,"range":{"start_line":2,"start_character":10,"end_line":2,"end_character":14},"updated":"2018-12-12 22:30:01.000000000","message":"2018","commit_id":"62de758215e18070c22c43e5bb096c6fe3e1df80"}],"charts/shipyard/templates/secret-rabbitmq.yaml":[{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"aedfd22ae6366c58551e0eb588f24f6bf7322ec4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3f79a3b5_f896ed50","line":2,"range":{"start_line":2,"start_character":10,"end_line":2,"end_character":14},"updated":"2018-12-12 22:30:01.000000000","message":"2018","commit_id":"62de758215e18070c22c43e5bb096c6fe3e1df80"}],"charts/shipyard/templates/secret-user-rabbitmq.yaml":[{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"aedfd22ae6366c58551e0eb588f24f6bf7322ec4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3f79a3b5_189c096e","line":2,"updated":"2018-12-12 22:30:01.000000000","message":"2018","commit_id":"62de758215e18070c22c43e5bb096c6fe3e1df80"}],"charts/shipyard/values.yaml":[{"author":{"_account_id":26449,"name":"Scott Hussey","email":"sthussey@att.com","username":"sh8121"},"change_message_id":"1faa5c5ce7cfb7d0a3433e0355d5d074b5f9a4d7","unresolved":false,"context_lines":[{"line_number":83,"context_line":"      port: 8793"},{"line_number":84,"context_line":"      enable_node_port: false"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"dependencies:"},{"line_number":87,"context_line":"  static:"},{"line_number":88,"context_line":"    shipyard_db_init:"},{"line_number":89,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_8719edd2","line":86,"updated":"2018-11-12 17:12:40.000000000","message":"Wouldn\u0027t the new job have a dependency on rabbit being there?","commit_id":"379ef8733476f7b5750f323af043b6c831b99850"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7b2e478b4f75dca201044f9b1082471c2431fc7d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"      port: 8793"},{"line_number":84,"context_line":"      enable_node_port: false"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"dependencies:"},{"line_number":87,"context_line":"  static:"},{"line_number":88,"context_line":"    shipyard_db_init:"},{"line_number":89,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_93ea5d9e","line":86,"in_reply_to":"3f79a3b5_8719edd2","updated":"2018-11-12 17:35:13.000000000","message":"Well, I guess so, I\u0027m just not sure where to put it. Airflow was dependent on rabbit even before this patch, but the dependency is not stated anywhere here","commit_id":"379ef8733476f7b5750f323af043b6c831b99850"},{"author":{"_account_id":26449,"name":"Scott Hussey","email":"sthussey@att.com","username":"sh8121"},"change_message_id":"956c82c60743cec9ef0216c05694104be037c203","unresolved":false,"context_lines":[{"line_number":83,"context_line":"      port: 8793"},{"line_number":84,"context_line":"      enable_node_port: false"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"dependencies:"},{"line_number":87,"context_line":"  static:"},{"line_number":88,"context_line":"    shipyard_db_init:"},{"line_number":89,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_e585f954","line":86,"in_reply_to":"3f79a3b5_93ea5d9e","updated":"2018-11-13 15:56:40.000000000","message":"Check L155 showing airflow_server dependent on the oslo_messaging service. I would expect a similar dependency for this new job.","commit_id":"379ef8733476f7b5750f323af043b6c831b99850"},{"author":{"_account_id":26449,"name":"Scott Hussey","email":"sthussey@att.com","username":"sh8121"},"change_message_id":"956c82c60743cec9ef0216c05694104be037c203","unresolved":false,"context_lines":[{"line_number":345,"context_line":"    admin: shipyard-keystone-admin"},{"line_number":346,"context_line":"    shipyard: shipyard-keystone-user"},{"line_number":347,"context_line":"  oslo_messaging:"},{"line_number":348,"context_line":"    admin: keystone-rabbitmq-admin"},{"line_number":349,"context_line":"  postgresql_shipyard_db:"},{"line_number":350,"context_line":"    admin: shipyard-db-admin"},{"line_number":351,"context_line":"    user: shipyard-db-user"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_c5123dff","line":348,"updated":"2018-11-13 15:56:40.000000000","message":"You need to create a shipyard secret here, you cannot rely on the Keystone secret having been created.","commit_id":"379ef8733476f7b5750f323af043b6c831b99850"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2db5a7671fd576a094de9339570922f7e425db58","unresolved":false,"context_lines":[{"line_number":345,"context_line":"    admin: shipyard-keystone-admin"},{"line_number":346,"context_line":"    shipyard: shipyard-keystone-user"},{"line_number":347,"context_line":"  oslo_messaging:"},{"line_number":348,"context_line":"    admin: keystone-rabbitmq-admin"},{"line_number":349,"context_line":"  postgresql_shipyard_db:"},{"line_number":350,"context_line":"    admin: shipyard-db-admin"},{"line_number":351,"context_line":"    user: shipyard-db-user"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_8658cc89","line":348,"in_reply_to":"3f79a3b5_c5123dff","updated":"2018-11-13 17:24:04.000000000","message":"yeah good point, will change, thanks!","commit_id":"379ef8733476f7b5750f323af043b6c831b99850"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d23324a2ff11698b9fcefc80754c600529cb50cf","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    admin: shipyard-keystone-admin"},{"line_number":350,"context_line":"    shipyard: shipyard-keystone-user"},{"line_number":351,"context_line":"  oslo_messaging:"},{"line_number":352,"context_line":"    admin: keystone-rabbitmq-admin"},{"line_number":353,"context_line":"  postgresql_shipyard_db:"},{"line_number":354,"context_line":"    admin: shipyard-db-admin"},{"line_number":355,"context_line":"    user: shipyard-db-user"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f79a3b5_da3785dc","line":352,"updated":"2018-11-13 00:09:17.000000000","message":"I don\u0027t add user credentials here so that the job does not try to setup a rabbit user","commit_id":"34f613a01fe319a0f9fc36c1259b42525fb352fe"},{"author":{"_account_id":26365,"name":"Bryan Strassner","email":"strassner.bryan@gmail.com","username":"bryan-strassner"},"change_message_id":"050b983404865fda32b52915341d28a4ab31eb80","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    admin: shipyard-keystone-admin"},{"line_number":350,"context_line":"    shipyard: shipyard-keystone-user"},{"line_number":351,"context_line":"  oslo_messaging:"},{"line_number":352,"context_line":"    admin: keystone-rabbitmq-admin"},{"line_number":353,"context_line":"  postgresql_shipyard_db:"},{"line_number":354,"context_line":"    admin: shipyard-db-admin"},{"line_number":355,"context_line":"    user: shipyard-db-user"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f79a3b5_ea10684f","line":352,"in_reply_to":"3f79a3b5_7d5c2bef","updated":"2018-11-13 15:06:47.000000000","message":"Airflow -\u003e Celery is creating the user, we just need the auxiliary commands to make it replicate queues.","commit_id":"34f613a01fe319a0f9fc36c1259b42525fb352fe"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"353eaeb9aac77ab8d3a4cfbee170d88a38d08147","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    admin: shipyard-keystone-admin"},{"line_number":350,"context_line":"    shipyard: shipyard-keystone-user"},{"line_number":351,"context_line":"  oslo_messaging:"},{"line_number":352,"context_line":"    admin: keystone-rabbitmq-admin"},{"line_number":353,"context_line":"  postgresql_shipyard_db:"},{"line_number":354,"context_line":"    admin: shipyard-db-admin"},{"line_number":355,"context_line":"    user: shipyard-db-user"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f79a3b5_7d5c2bef","line":352,"in_reply_to":"3f79a3b5_da3785dc","updated":"2018-11-13 02:54:24.000000000","message":"Why don\u0027t we want a rabbit user here?","commit_id":"34f613a01fe319a0f9fc36c1259b42525fb352fe"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b12730a1a6156b30139bad4a8fcfad2d8ef53e6b","unresolved":false,"context_lines":[{"line_number":326,"context_line":"      user:"},{"line_number":327,"context_line":"        username: rabbitmq"},{"line_number":328,"context_line":"        password: password"},{"line_number":329,"context_line":"      admin:"},{"line_number":330,"context_line":"        username: rabbitmq"},{"line_number":331,"context_line":"        password: password"},{"line_number":332,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_0c493d2e","line":329,"updated":"2018-11-13 19:10:01.000000000","message":"I wonder whether we need to do this or just use \n\"user\" as looking at bottle it is admin as well","commit_id":"2e12add35845408e99ae93d788a8160dd589eff6"},{"author":{"_account_id":26449,"name":"Scott Hussey","email":"sthussey@att.com","username":"sh8121"},"change_message_id":"690b217ef25d58dce85ef80015338ea0b97b93f4","unresolved":false,"context_lines":[{"line_number":326,"context_line":"      user:"},{"line_number":327,"context_line":"        username: rabbitmq"},{"line_number":328,"context_line":"        password: password"},{"line_number":329,"context_line":"      admin:"},{"line_number":330,"context_line":"        username: rabbitmq"},{"line_number":331,"context_line":"        password: password"},{"line_number":332,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_cc0105b7","line":329,"in_reply_to":"3f79a3b5_0c493d2e","updated":"2018-11-13 19:13:31.000000000","message":"You need both. I\u0027m not sure why the user portion uses \u0027rabbitmq\u0027 as well, I\u0027d expect a application-specific user there.\n\nYou also need an additional secret template in the chart to create a Kubernetes secret similar to [0].\n\n[0] https://github.com/openstack/openstack-helm/blob/master/keystone/templates/secret-rabbitmq.yaml","commit_id":"2e12add35845408e99ae93d788a8160dd589eff6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"734c2b06e89b8cae56714f7d8160a22e78453c33","unresolved":false,"context_lines":[{"line_number":326,"context_line":"      user:"},{"line_number":327,"context_line":"        username: rabbitmq"},{"line_number":328,"context_line":"        password: password"},{"line_number":329,"context_line":"      admin:"},{"line_number":330,"context_line":"        username: rabbitmq"},{"line_number":331,"context_line":"        password: password"},{"line_number":332,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_ac25a960","line":329,"in_reply_to":"3f79a3b5_cc0105b7","updated":"2018-11-13 19:15:13.000000000","message":"yah it\u0027s already here :)","commit_id":"2e12add35845408e99ae93d788a8160dd589eff6"},{"author":{"_account_id":26449,"name":"Scott Hussey","email":"sthussey@att.com","username":"sh8121"},"change_message_id":"04ab66c01e9e6b8f0b61082f3a355d3838613df5","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  static:"},{"line_number":88,"context_line":"    shipyard_db_init:"},{"line_number":89,"context_line":"      jobs:"},{"line_number":90,"context_line":"        - airflow-rabbit-init"},{"line_number":91,"context_line":"        - airflow-db-init"},{"line_number":92,"context_line":"        - airflow-db-sync"},{"line_number":93,"context_line":"      services:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f79a3b5_d1329feb","line":90,"updated":"2018-12-17 19:06:48.000000000","message":"Is it actually the case that RabbitMQ config is required before building the shipyard database?","commit_id":"7329e1eef68c8c259a0132d0d7f7fa46bc721cc4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b5a33497d41192b7a7dd5329e67bfaa97330eae7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  static:"},{"line_number":88,"context_line":"    shipyard_db_init:"},{"line_number":89,"context_line":"      jobs:"},{"line_number":90,"context_line":"        - airflow-rabbit-init"},{"line_number":91,"context_line":"        - airflow-db-init"},{"line_number":92,"context_line":"        - airflow-db-sync"},{"line_number":93,"context_line":"      services:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f79a3b5_113b379a","line":90,"in_reply_to":"3f79a3b5_d1329feb","updated":"2018-12-17 19:29:20.000000000","message":"not really, I was just a bit confused with the dependencies listed here. I see airflow_server lists airflow-db-init and db-sync in the dependencies, but then shipyard itself does not list airflow_server as a dependency for anything. I guess this is tracked as services coming up in kubernetes (airflow_folwer and airflow_web) so should be indeed safe to drop","commit_id":"7329e1eef68c8c259a0132d0d7f7fa46bc721cc4"},{"author":{"_account_id":26449,"name":"Scott Hussey","email":"sthussey@att.com","username":"sh8121"},"change_message_id":"04ab66c01e9e6b8f0b61082f3a355d3838613df5","unresolved":false,"context_lines":[{"line_number":113,"context_line":"          endpoint: internal"},{"line_number":114,"context_line":"    airflow_db_sync:"},{"line_number":115,"context_line":"      jobs:"},{"line_number":116,"context_line":"        - airflow-rabbit-init"},{"line_number":117,"context_line":"        - airflow-db-init"},{"line_number":118,"context_line":"      services:"},{"line_number":119,"context_line":"        - service: postgresql_airflow_db"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f79a3b5_5170cfa6","line":116,"updated":"2018-12-17 19:06:48.000000000","message":"Same question here.","commit_id":"7329e1eef68c8c259a0132d0d7f7fa46bc721cc4"}]}