)]}'
{"doc/source/_static/shipyard.conf.sample":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"d1e18ad9ec307fca3221fc3582ca03bf25d479a6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"# From shipyard_api"},{"line_number":91,"context_line":"#"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# The name of the deployment configuration document thatShipyard expects and"},{"line_number":94,"context_line":"# validates (string value)"},{"line_number":95,"context_line":"#deployment_configuration_name \u003d deployment-configuration"},{"line_number":96,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"ffb9cba7_90ea7f0c","line":93,"updated":"2019-05-02 01:02:53.000000000","message":"space","commit_id":"04ad9424abba1267f2ccbf95e92109459c73b268"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"0a7857517f0fec115c881acd2f83fa9fc9ddaf96","unresolved":false,"context_lines":[{"line_number":90,"context_line":"# From shipyard_api"},{"line_number":91,"context_line":"#"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# The name of the deployment-configuration document thatShipyard expects and"},{"line_number":94,"context_line":"# validates (string value)"},{"line_number":95,"context_line":"#deployment_configuration_name \u003d deployment-configuration"},{"line_number":96,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"dfbec78f_89c8d974","line":93,"range":{"start_line":93,"start_character":52,"end_line":93,"end_character":64},"updated":"2019-05-02 15:26:27.000000000","message":"that Shipyard","commit_id":"ec9582ae18a426664ee3aec24fef7f0026b3ad5a"}],"doc/source/sampleconf.rst":[{"author":{"_account_id":22259,"name":"Nishant Kumar","email":"nishant.e.kumar@att.com","username":"nishant.e.kumar"},"change_message_id":"65b046ac3bbdb14b2b9c6a4ca7c0941e1479dd6b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"    See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"    limitations under the License."},{"line_number":15,"context_line":".. _sample-configuration:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Sample Configuration File"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dfbec78f_27bc44db","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":25},"updated":"2019-05-06 18:42:33.000000000","message":"Question: what is the usage for this?","commit_id":"222b074cb193cf409ae64b7d81293b5c449a4d93"},{"author":{"_account_id":30106,"name":"Matt Carter","email":"matt.coach.carter@gmail.com","username":"MattCarter"},"change_message_id":"134e79035647f91119ed98e3b01a3ac991b6ec9e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"    See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"    limitations under the License."},{"line_number":15,"context_line":".. _sample-configuration:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Sample Configuration File"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dfbec78f_ba2b5d80","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":25},"in_reply_to":"dfbec78f_27bc44db","updated":"2019-05-07 15:02:00.000000000","message":"That allows this page to be linked-to from other pages.\nFor an example see my updates in:\nhttps://review.opendev.org/#/c/656394/4/doc/source/site-definition-documents.rst","commit_id":"222b074cb193cf409ae64b7d81293b5c449a4d93"}],"doc/source/site-definition-documents.rst":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"d1e18ad9ec307fca3221fc3582ca03bf25d479a6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"A `sample deployment-configuration`_ shows a completely specified example."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Note that the name and schema Shipyard expects the deployment configuration"},{"line_number":41,"context_line":"document to have is conifgurable via the document_info section in the"},{"line_number":42,"context_line":":ref:`Shipyard configuration \u003csample-configuration\u003e`, but should be left"},{"line_number":43,"context_line":"defaulted in most cases."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ffb9cba7_30db937c","line":41,"range":{"start_line":41,"start_character":20,"end_line":41,"end_character":32},"updated":"2019-05-02 01:02:53.000000000","message":"configurable","commit_id":"04ad9424abba1267f2ccbf95e92109459c73b268"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9ae258f1f3e6859c3ad34e72f2b8e1523c7dd81d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"A `sample deployment-configuration`_ shows a completely specified example."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Note that the name and schema Shipyard expects the deployment configuration"},{"line_number":41,"context_line":"document to have is conifgurable via the document_info section in the"},{"line_number":42,"context_line":":ref:`Shipyard configuration \u003csample-configuration\u003e`, but should be left"},{"line_number":43,"context_line":"defaulted in most cases."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dfbec78f_bc692bbf","line":41,"range":{"start_line":41,"start_character":20,"end_line":41,"end_character":32},"updated":"2019-05-06 16:41:42.000000000","message":"configurable","commit_id":"222b074cb193cf409ae64b7d81293b5c449a4d93"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"9ae258f1f3e6859c3ad34e72f2b8e1523c7dd81d","unresolved":false,"context_lines":[{"line_number":185,"context_line":"   the group a success."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Note that the schema Shipyard expects the deployment strategy document to have"},{"line_number":188,"context_line":"is conifgurable via the document_info section in the"},{"line_number":189,"context_line":":ref:`Shipyard configuration \u003csample-configuration\u003e`, but should be left"},{"line_number":190,"context_line":"defaulted in most cases."},{"line_number":191,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dfbec78f_7c63b3dd","line":188,"range":{"start_line":188,"start_character":3,"end_line":188,"end_character":15},"updated":"2019-05-06 16:41:42.000000000","message":"configurable","commit_id":"222b074cb193cf409ae64b7d81293b5c449a4d93"}],"src/bin/shipyard_airflow/etc/shipyard/shipyard.conf.sample":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"d1e18ad9ec307fca3221fc3582ca03bf25d479a6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"# From shipyard_api"},{"line_number":91,"context_line":"#"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# The name of the deployment configuration document thatShipyard expects and"},{"line_number":94,"context_line":"# validates (string value)"},{"line_number":95,"context_line":"#deployment_configuration_name \u003d deployment-configuration"},{"line_number":96,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"ffb9cba7_d0e31733","line":93,"updated":"2019-05-02 01:02:53.000000000","message":"space","commit_id":"04ad9424abba1267f2ccbf95e92109459c73b268"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"0a7857517f0fec115c881acd2f83fa9fc9ddaf96","unresolved":false,"context_lines":[{"line_number":90,"context_line":"# From shipyard_api"},{"line_number":91,"context_line":"#"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# The name of the deployment-configuration document thatShipyard expects and"},{"line_number":94,"context_line":"# validates (string value)"},{"line_number":95,"context_line":"#deployment_configuration_name \u003d deployment-configuration"},{"line_number":96,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"dfbec78f_c993315c","line":93,"range":{"start_line":93,"start_character":52,"end_line":93,"end_character":64},"updated":"2019-05-02 15:26:27.000000000","message":"that Shipyard","commit_id":"ec9582ae18a426664ee3aec24fef7f0026b3ad5a"}],"src/bin/shipyard_airflow/shipyard_airflow/conf/config.py":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"d1e18ad9ec307fca3221fc3582ca03bf25d479a6","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            cfg.StrOpt("},{"line_number":295,"context_line":"                \u0027deployment_configuration_name\u0027,"},{"line_number":296,"context_line":"                default\u003d\u0027deployment-configuration\u0027,"},{"line_number":297,"context_line":"                help\u003d(\u0027The name of the deployment configuration document that\u0027"},{"line_number":298,"context_line":"                      \u0027Shipyard expects and validates\u0027)"},{"line_number":299,"context_line":"            ),"},{"line_number":300,"context_line":"            cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_b0d8e37a","line":297,"updated":"2019-05-02 01:02:53.000000000","message":"space","commit_id":"04ad9424abba1267f2ccbf95e92109459c73b268"}],"src/bin/shipyard_airflow/shipyard_airflow/control/validators/validate_deployment_action.py":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"d1e18ad9ec307fca3221fc3582ca03bf25d479a6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":"import logging"},{"line_number":15,"context_line":"from oslo_config import cfg"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import falcon"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_f0b97b14","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":27},"updated":"2019-05-02 01:02:53.000000000","message":"not a stdlib.  update import order, see https://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"04ad9424abba1267f2ccbf95e92109459c73b268"}],"src/bin/shipyard_airflow/shipyard_airflow/control/validators/validate_deployment_configuration.py":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"d1e18ad9ec307fca3221fc3582ca03bf25d479a6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"is performed by Deckhand on Shipyard\u0027s behalf."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"import logging"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from shipyard_airflow.common.document_validators.document_validator import ("},{"line_number":23,"context_line":"    DocumentValidator"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_b03d4390","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":27},"updated":"2019-05-02 01:02:53.000000000","message":"not a stdlib, update import order.  see https://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"04ad9424abba1267f2ccbf95e92109459c73b268"}],"src/bin/shipyard_airflow/shipyard_airflow/control/validators/validate_deployment_strategy.py":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"d1e18ad9ec307fca3221fc3582ca03bf25d479a6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"is performed by Deckhand on Shipyard\u0027s behalf."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"import logging"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from shipyard_airflow.common.deployment_group.deployment_group_manager import ("},{"line_number":23,"context_line":"    DeploymentGroupManager"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_104c4f40","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":27},"updated":"2019-05-02 01:02:53.000000000","message":"not a stdlib, update import order.  see https://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"04ad9424abba1267f2ccbf95e92109459c73b268"}],"src/bin/shipyard_airflow/shipyard_airflow/plugins/deployment_configuration_operator.py":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"d1e18ad9ec307fca3221fc3582ca03bf25d479a6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"retrieved into a dictionary"},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"import logging"},{"line_number":20,"context_line":"import configparser"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from airflow.exceptions import AirflowException"},{"line_number":23,"context_line":"from airflow.models import BaseOperator"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_9006ffcd","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":19},"updated":"2019-05-02 01:02:53.000000000","message":"alphabetical import order, see https://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"04ad9424abba1267f2ccbf95e92109459c73b268"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"d1e18ad9ec307fca3221fc3582ca03bf25d479a6","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.action_info \u003d {}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _read_config(self):"},{"line_number":100,"context_line":"        \"\"\"Read in and parse the shipyard config"},{"line_number":101,"context_line":"        \"\"\""},{"line_number":102,"context_line":"        self.config \u003d configparser.ConfigParser()"},{"line_number":103,"context_line":"        self.config.read(self.shipyard_conf)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_d051d7da","line":101,"range":{"start_line":100,"start_character":0,"end_line":101,"end_character":11},"updated":"2019-05-02 01:02:53.000000000","message":"combine docstring into single line, see line 106 as example","commit_id":"04ad9424abba1267f2ccbf95e92109459c73b268"},{"author":{"_account_id":26365,"name":"Bryan Strassner","email":"strassner.bryan@gmail.com","username":"bryan-strassner"},"change_message_id":"d9e2236ee54cf54cc6f5a5f69c7bab742ef74a7c","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def get_doc(self, revision_id):"},{"line_number":136,"context_line":"        \"\"\"Get the DeploymentConfiguration document dictionary from Deckhand\"\"\""},{"line_number":137,"context_line":"        LOG.info((\"Attempting to retrieve {}, {} from Deckhand\").format("},{"line_number":138,"context_line":"            self.config.get(DOCUMENT_INFO, \u0027deployment_configuration_schema\u0027),"},{"line_number":139,"context_line":"            self.config.get(DOCUMENT_INFO, \u0027deployment_configuration_name\u0027)))"},{"line_number":140,"context_line":"        filters \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_29452d18","line":137,"range":{"start_line":137,"start_character":17,"end_line":137,"end_character":18},"updated":"2019-05-02 15:23:52.000000000","message":"This parenthesis pair seems extraneous","commit_id":"ec9582ae18a426664ee3aec24fef7f0026b3ad5a"},{"author":{"_account_id":26365,"name":"Bryan Strassner","email":"strassner.bryan@gmail.com","username":"bryan-strassner"},"change_message_id":"d9e2236ee54cf54cc6f5a5f69c7bab742ef74a7c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def get_doc(self, revision_id):"},{"line_number":136,"context_line":"        \"\"\"Get the DeploymentConfiguration document dictionary from Deckhand\"\"\""},{"line_number":137,"context_line":"        LOG.info((\"Attempting to retrieve {}, {} from Deckhand\").format("},{"line_number":138,"context_line":"            self.config.get(DOCUMENT_INFO, \u0027deployment_configuration_schema\u0027),"},{"line_number":139,"context_line":"            self.config.get(DOCUMENT_INFO, \u0027deployment_configuration_name\u0027)))"},{"line_number":140,"context_line":"        filters \u003d {"},{"line_number":141,"context_line":"            \"schema\": self.config.get(DOCUMENT_INFO,"},{"line_number":142,"context_line":"                                      \u0027deployment_configuration_schema\u0027),"},{"line_number":143,"context_line":"            \"metadata.name\": self.config.get(DOCUMENT_INFO,"},{"line_number":144,"context_line":"                                             \u0027deployment_configuration_name\u0027)"},{"line_number":145,"context_line":"        }"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        # Create additional headers dict to pass context marker"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_e96f1590","line":144,"range":{"start_line":138,"start_character":0,"end_line":144,"end_character":77},"updated":"2019-05-02 15:23:52.000000000","message":"Nit: since you retrieve these twice, why not resolve it to a local var to minimize the number of string repetitions","commit_id":"ec9582ae18a426664ee3aec24fef7f0026b3ad5a"}],"src/bin/shipyard_airflow/shipyard_airflow/plugins/drydock_nodes.py":[{"author":{"_account_id":26365,"name":"Bryan Strassner","email":"strassner.bryan@gmail.com","username":"bryan-strassner"},"change_message_id":"d9e2236ee54cf54cc6f5a5f69c7bab742ef74a7c","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                # if there is a deployment strategy specified, use it"},{"line_number":291,"context_line":"                strategy \u003d self.get_unique_doc("},{"line_number":292,"context_line":"                    name\u003dstrat_name,"},{"line_number":293,"context_line":"                    schema\u003dself.config.get(DOCUMENT_INFO,"},{"line_number":294,"context_line":"                                           \u0027deployment_strategy_schema\u0027)"},{"line_number":295,"context_line":"                )"},{"line_number":296,"context_line":"            else:"},{"line_number":297,"context_line":"                # The default behavior is to deploy all nodes, and fail if"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_c9e5710c","line":294,"range":{"start_line":293,"start_character":0,"end_line":294,"end_character":72},"updated":"2019-05-02 15:23:52.000000000","message":"Nit: we could further use fallback\u003d\"shipyard/DeploymentStrategy/v1\" in the case that the value is missing from the config.","commit_id":"ec9582ae18a426664ee3aec24fef7f0026b3ad5a"}],"src/bin/shipyard_airflow/shipyard_airflow/plugins/ucp_base_operator.py":[{"author":{"_account_id":26365,"name":"Bryan Strassner","email":"strassner.bryan@gmail.com","username":"bryan-strassner"},"change_message_id":"8a5d21849ae5ca3ad89b9d2b5ef5bd4c3590dd94","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.doc_utils \u003d _get_document_util(self.shipyard_conf)"},{"line_number":112,"context_line":"        self.endpoints \u003d service_endpoint.ServiceEndpoints(self.shipyard_conf)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # Read and parse shiyard.conf"},{"line_number":115,"context_line":"        self.config \u003d configparser.ConfigParser()"},{"line_number":116,"context_line":"        self.config.read(self.shipyard_conf)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        # Execute Airship base function"},{"line_number":119,"context_line":"        self.ucp_base(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_fe6ab77e","line":116,"range":{"start_line":114,"start_character":0,"end_line":116,"end_character":44},"updated":"2019-05-01 14:32:03.000000000","message":"Either... all the conf use needs to use the existing pattern, or all of it needs to move to use oslo conf in the plugins.\n\nIf oslo conf is where it\u0027s going, I\u0027d expect to see a follow-on change to refactor all of the self.shipyard_conf usage to oslo conf.\n\nOn the other hand, is there a good reason to introduce oslo conf at this point, or instead use the existing methods of configparser as is done throughout the plugins?","commit_id":"7f36e1b33ee95076ed8c5f4a098e76fa2dcac0e0"},{"author":{"_account_id":30106,"name":"Matt Carter","email":"matt.coach.carter@gmail.com","username":"MattCarter"},"change_message_id":"6dd5d68e21659cecfeac4ac8993b98ed690bc4c4","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.doc_utils \u003d _get_document_util(self.shipyard_conf)"},{"line_number":112,"context_line":"        self.endpoints \u003d service_endpoint.ServiceEndpoints(self.shipyard_conf)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # Read and parse shiyard.conf"},{"line_number":115,"context_line":"        self.config \u003d configparser.ConfigParser()"},{"line_number":116,"context_line":"        self.config.read(self.shipyard_conf)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        # Execute Airship base function"},{"line_number":119,"context_line":"        self.ucp_base(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_79b3410b","line":116,"range":{"start_line":114,"start_character":0,"end_line":116,"end_character":44},"in_reply_to":"ffb9cba7_fe6ab77e","updated":"2019-05-01 15:12:50.000000000","message":"I didn\u0027t fully appreciate/notice how the configs worked in the plugins until I looked at this comment.\nI have no special affinity towards oslo config, I will refactor to use the existing config structure in the plugins. I think that makes the most sense.","commit_id":"7f36e1b33ee95076ed8c5f4a098e76fa2dcac0e0"},{"author":{"_account_id":26365,"name":"Bryan Strassner","email":"strassner.bryan@gmail.com","username":"bryan-strassner"},"change_message_id":"d9e2236ee54cf54cc6f5a5f69c7bab742ef74a7c","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        if revision_id is None:"},{"line_number":254,"context_line":"            revision_id \u003d self.revision_id"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        LOG.info(\"Retrieve {}, {} from Deckhand\".format(schema, name))"},{"line_number":257,"context_line":"        try:"},{"line_number":258,"context_line":"            return self.doc_utils.get_unique_doc(revision_id\u003drevision_id,"},{"line_number":259,"context_line":"                                                 name\u003dname,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_29ba0dde","line":256,"range":{"start_line":256,"start_character":6,"end_line":256,"end_character":70},"updated":"2019-05-02 15:23:52.000000000","message":"Good, this was just wrong before.","commit_id":"ec9582ae18a426664ee3aec24fef7f0026b3ad5a"}],"src/bin/shipyard_airflow/tests/unit/plugins/test_deployment_configuration_operator.py":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"d1e18ad9ec307fca3221fc3582ca03bf25d479a6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":"from unittest import mock"},{"line_number":15,"context_line":"from configparser import ConfigParser"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import pytest"},{"line_number":18,"context_line":"import yaml"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_b066a3c0","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":37},"updated":"2019-05-02 01:02:53.000000000","message":"alphabetical import order, see https://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"04ad9424abba1267f2ccbf95e92109459c73b268"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"d1e18ad9ec307fca3221fc3582ca03bf25d479a6","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    :returns: A fake configuration object"},{"line_number":65,"context_line":"    :rtype: ConfigParser"},{"line_number":66,"context_line":"    \"\"\""},{"line_number":67,"context_line":"    cfg \u003d ConfigParser()"},{"line_number":68,"context_line":"    cfg.add_section(DOCUMENT_INFO)"},{"line_number":69,"context_line":"    cfg.set(DOCUMENT_INFO, \u0027deployment_configuration_name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_10752f64","line":66,"updated":"2019-05-02 01:02:53.000000000","message":"space between docstring and method body","commit_id":"04ad9424abba1267f2ccbf95e92109459c73b268"}]}