)]}'
{"src/bin/shipyard_airflow/shipyard_airflow/control/action/action.py":[{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"1589f4c5405df00763b9bd6f9fcbb2a64df98b5c","unresolved":false,"context_lines":[{"line_number":714,"context_line":"        :rtype: str"},{"line_number":715,"context_line":"        \"\"\""},{"line_number":716,"context_line":"        return Action.LIFECYCLE_RESULT_MAPPING.get(str(self.lifecycle).lower(),"},{"line_number":717,"context_line":"                                                   \u0027unknown\u0027).lower()"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    def _make_deckhand_doc_url(self):"},{"line_number":720,"context_line":"        \"\"\"Create and return a full URL to this action\u0027s revision in Deckhand"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_17f63791","line":717,"range":{"start_line":717,"start_character":61,"end_line":717,"end_character":69},"updated":"2019-05-03 14:53:51.000000000","message":"This seems redundant","commit_id":"1f9b6454400e024475865e94044a740b89ab16ba"},{"author":{"_account_id":30106,"name":"Matt Carter","email":"matt.coach.carter@gmail.com","username":"MattCarter"},"change_message_id":"9b1166281ea91485df5c855da5e7b24383b320dd","unresolved":false,"context_lines":[{"line_number":714,"context_line":"        :rtype: str"},{"line_number":715,"context_line":"        \"\"\""},{"line_number":716,"context_line":"        return Action.LIFECYCLE_RESULT_MAPPING.get(str(self.lifecycle).lower(),"},{"line_number":717,"context_line":"                                                   \u0027unknown\u0027).lower()"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    def _make_deckhand_doc_url(self):"},{"line_number":720,"context_line":"        \"\"\"Create and return a full URL to this action\u0027s revision in Deckhand"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_46b5daed","line":717,"range":{"start_line":717,"start_character":61,"end_line":717,"end_character":69},"in_reply_to":"dfbec78f_17f63791","updated":"2019-05-03 19:35:16.000000000","message":"The first lower() call is on the key being passed to get(), the second lower() call is on the return value of get() itself. This line is a bit dense, and splitting it up into multiple lines does make it look strange with the two lower() calls like that.","commit_id":"1f9b6454400e024475865e94044a740b89ab16ba"},{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"50406954e1ee1aec5db8013f4384f0379f3fd766","unresolved":false,"context_lines":[{"line_number":714,"context_line":"        :rtype: str"},{"line_number":715,"context_line":"        \"\"\""},{"line_number":716,"context_line":"        return Action.LIFECYCLE_RESULT_MAPPING.get(str(self.lifecycle).lower(),"},{"line_number":717,"context_line":"                                                   \u0027unknown\u0027).lower()"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    def _make_deckhand_doc_url(self):"},{"line_number":720,"context_line":"        \"\"\"Create and return a full URL to this action\u0027s revision in Deckhand"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_e6c16e30","line":717,"range":{"start_line":717,"start_character":61,"end_line":717,"end_character":69},"in_reply_to":"dfbec78f_46b5daed","updated":"2019-05-03 19:43:28.000000000","message":"Unless I\u0027m mistaken, the second lower() won\u0027t ever have an effect if the dict has no values that aren\u0027t lowercase. If it is necessary though, maybe splitting it up would be for the best for readability","commit_id":"1f9b6454400e024475865e94044a740b89ab16ba"},{"author":{"_account_id":30106,"name":"Matt Carter","email":"matt.coach.carter@gmail.com","username":"MattCarter"},"change_message_id":"bcc7f2b28a471c128eb213d4af912be18f75f203","unresolved":false,"context_lines":[{"line_number":714,"context_line":"        :rtype: str"},{"line_number":715,"context_line":"        \"\"\""},{"line_number":716,"context_line":"        return Action.LIFECYCLE_RESULT_MAPPING.get(str(self.lifecycle).lower(),"},{"line_number":717,"context_line":"                                                   \u0027unknown\u0027).lower()"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    def _make_deckhand_doc_url(self):"},{"line_number":720,"context_line":"        \"\"\"Create and return a full URL to this action\u0027s revision in Deckhand"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_9e667629","line":717,"range":{"start_line":717,"start_character":61,"end_line":717,"end_character":69},"in_reply_to":"dfbec78f_e6c16e30","updated":"2019-05-08 20:01:58.000000000","message":"You\u0027re right, it\u0027s not completely necessary as of today. The idea behind it was just that I always wanted the return value coming out of the function to be lowercase. I\u0027m going to split it up into multiple lines, I think it will be more readable that way and make a bit more sense.","commit_id":"1f9b6454400e024475865e94044a740b89ab16ba"},{"author":{"_account_id":22259,"name":"Nishant Kumar","email":"nishant.e.kumar@att.com","username":"nishant.e.kumar"},"change_message_id":"3421cb6ddadfa376fb26bad95002a029877671e0","unresolved":false,"context_lines":[{"line_number":735,"context_line":"        self.determine_lifecycle()"},{"line_number":736,"context_line":"        return {"},{"line_number":737,"context_line":"            \u0027status\u0027: str(self.lifecycle).lower(),"},{"line_number":738,"context_line":"            \u0027results\u0027: self._get_deployment_status_result(),"},{"line_number":739,"context_line":"            \u0027context\u0027: self.context_marker,"},{"line_number":740,"context_line":"            \u0027action\u0027: self.id,"},{"line_number":741,"context_line":"            \u0027document_url\u0027: self._make_deckhand_doc_url(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_be4a5a52","line":738,"range":{"start_line":738,"start_character":12,"end_line":738,"end_character":59},"updated":"2019-05-08 19:16:54.000000000","message":"why do we need the additonal \u0027results\u0027 key when we already have the \u0027status\u0027 mapped in here? \n\nI can\u0027t think of any additional benefit for eg. status \u0027failed\u0027 will be same as \u0027results\u0027 failed as per this implementation which appears to be redundant.","commit_id":"1f9b6454400e024475865e94044a740b89ab16ba"},{"author":{"_account_id":30106,"name":"Matt Carter","email":"matt.coach.carter@gmail.com","username":"MattCarter"},"change_message_id":"bcc7f2b28a471c128eb213d4af912be18f75f203","unresolved":false,"context_lines":[{"line_number":735,"context_line":"        self.determine_lifecycle()"},{"line_number":736,"context_line":"        return {"},{"line_number":737,"context_line":"            \u0027status\u0027: str(self.lifecycle).lower(),"},{"line_number":738,"context_line":"            \u0027results\u0027: self._get_deployment_status_result(),"},{"line_number":739,"context_line":"            \u0027context\u0027: self.context_marker,"},{"line_number":740,"context_line":"            \u0027action\u0027: self.id,"},{"line_number":741,"context_line":"            \u0027document_url\u0027: self._make_deckhand_doc_url(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_fe88d2c6","line":738,"range":{"start_line":738,"start_character":12,"end_line":738,"end_character":59},"in_reply_to":"dfbec78f_be4a5a52","updated":"2019-05-08 20:01:58.000000000","message":"Status was meant to be some measure of progress regardless of outcome, vs results which was meant to be a measure outcome.\nLooking through this again, however, you\u0027re correct. They could both be failed. I\u0027ll update this.","commit_id":"1f9b6454400e024475865e94044a740b89ab16ba"},{"author":{"_account_id":22259,"name":"Nishant Kumar","email":"nishant.e.kumar@att.com","username":"nishant.e.kumar"},"change_message_id":"3421cb6ddadfa376fb26bad95002a029877671e0","unresolved":false,"context_lines":[{"line_number":738,"context_line":"            \u0027results\u0027: self._get_deployment_status_result(),"},{"line_number":739,"context_line":"            \u0027context\u0027: self.context_marker,"},{"line_number":740,"context_line":"            \u0027action\u0027: self.id,"},{"line_number":741,"context_line":"            \u0027document_url\u0027: self._make_deckhand_doc_url(),"},{"line_number":742,"context_line":"            \u0027user\u0027: self.user,"},{"line_number":743,"context_line":"            \u0027date\u0027: self.timestamp"},{"line_number":744,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_7e3702b2","line":741,"range":{"start_line":741,"start_character":28,"end_line":741,"end_character":57},"updated":"2019-05-08 19:16:54.000000000","message":"can this [0] function be reused here?\n\n[0] https://github.com/openstack/airship-shipyard/blob/6d01f3f07bd031b9ceae463e0020f3688441de5e/src/bin/shipyard_airflow/shipyard_airflow/control/helpers/design_reference_helper.py#L39","commit_id":"1f9b6454400e024475865e94044a740b89ab16ba"},{"author":{"_account_id":30106,"name":"Matt Carter","email":"matt.coach.carter@gmail.com","username":"MattCarter"},"change_message_id":"bcc7f2b28a471c128eb213d4af912be18f75f203","unresolved":false,"context_lines":[{"line_number":738,"context_line":"            \u0027results\u0027: self._get_deployment_status_result(),"},{"line_number":739,"context_line":"            \u0027context\u0027: self.context_marker,"},{"line_number":740,"context_line":"            \u0027action\u0027: self.id,"},{"line_number":741,"context_line":"            \u0027document_url\u0027: self._make_deckhand_doc_url(),"},{"line_number":742,"context_line":"            \u0027user\u0027: self.user,"},{"line_number":743,"context_line":"            \u0027date\u0027: self.timestamp"},{"line_number":744,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_213c0bbe","line":741,"range":{"start_line":741,"start_character":28,"end_line":741,"end_character":57},"in_reply_to":"dfbec78f_7e3702b2","updated":"2019-05-08 20:01:58.000000000","message":"I believe so. Good find.","commit_id":"1f9b6454400e024475865e94044a740b89ab16ba"},{"author":{"_account_id":22259,"name":"Nishant Kumar","email":"nishant.e.kumar@att.com","username":"nishant.e.kumar"},"change_message_id":"dd8a0d50decea1860fcc03f69f477025081da8fa","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        \u0027NONE\u0027: \u0027Pending\u0027,"},{"line_number":169,"context_line":"        \u0027PAUSED\u0027: \u0027Paused\u0027"},{"line_number":170,"context_line":"    }"},{"line_number":171,"context_line":"    # Mapping of lifecycle to result (for deployment-status)"},{"line_number":172,"context_line":"    LIFECYCLE_RESULT_MAPPING \u003d {"},{"line_number":173,"context_line":"        \u0027failed\u0027: \u0027failed\u0027,"},{"line_number":174,"context_line":"        \u0027processing\u0027: \u0027pending\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_368e852e","line":171,"range":{"start_line":171,"start_character":53,"end_line":171,"end_character":59},"updated":"2019-05-09 15:44:28.000000000","message":"result","commit_id":"eff10dab47faff969b2366cc8dacf327ca122069"},{"author":{"_account_id":30106,"name":"Matt Carter","email":"matt.coach.carter@gmail.com","username":"MattCarter"},"change_message_id":"4e815e6049c02867aaf71fae520b2196ea1db500","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        \u0027NONE\u0027: \u0027Pending\u0027,"},{"line_number":169,"context_line":"        \u0027PAUSED\u0027: \u0027Paused\u0027"},{"line_number":170,"context_line":"    }"},{"line_number":171,"context_line":"    # Mapping of lifecycle to result (for deployment-status)"},{"line_number":172,"context_line":"    LIFECYCLE_RESULT_MAPPING \u003d {"},{"line_number":173,"context_line":"        \u0027failed\u0027: \u0027failed\u0027,"},{"line_number":174,"context_line":"        \u0027processing\u0027: \u0027pending\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_0f77a0a2","line":171,"range":{"start_line":171,"start_character":53,"end_line":171,"end_character":59},"in_reply_to":"dfbec78f_368e852e","updated":"2019-05-09 16:04:22.000000000","message":"When referencing deployment-status here I was referencing the document, not the status field. I will update this comment to make it more clear.","commit_id":"eff10dab47faff969b2366cc8dacf327ca122069"},{"author":{"_account_id":22259,"name":"Nishant Kumar","email":"nishant.e.kumar@att.com","username":"nishant.e.kumar"},"change_message_id":"dd8a0d50decea1860fcc03f69f477025081da8fa","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        \u0027PAUSED\u0027: \u0027Paused\u0027"},{"line_number":170,"context_line":"    }"},{"line_number":171,"context_line":"    # Mapping of lifecycle to result (for deployment-status)"},{"line_number":172,"context_line":"    LIFECYCLE_RESULT_MAPPING \u003d {"},{"line_number":173,"context_line":"        \u0027failed\u0027: \u0027failed\u0027,"},{"line_number":174,"context_line":"        \u0027processing\u0027: \u0027pending\u0027,"},{"line_number":175,"context_line":"        \u0027pending\u0027: \u0027pending\u0027,"},{"line_number":176,"context_line":"        \u0027complete\u0027: \u0027successful\u0027,"},{"line_number":177,"context_line":"        \u0027paused\u0027: \u0027pending\u0027"},{"line_number":178,"context_line":"    }"},{"line_number":179,"context_line":"    # Mapping of lifecycle to status (for deployment-status)"},{"line_number":180,"context_line":"    LIFECYCLE_STATUS_MAPPING \u003d {"},{"line_number":181,"context_line":"        \u0027failed\u0027: \u0027completed\u0027,"},{"line_number":182,"context_line":"        \u0027processing\u0027: \u0027running\u0027,"},{"line_number":183,"context_line":"        \u0027pending\u0027: \u0027pending\u0027,"},{"line_number":184,"context_line":"        \u0027complete\u0027: \u0027completed\u0027,"},{"line_number":185,"context_line":"        \u0027paused\u0027: \u0027paused\u0027"},{"line_number":186,"context_line":"    }"},{"line_number":187,"context_line":"    # Just so we are consistent:"},{"line_number":188,"context_line":"    EXECUTION_DATETIME_STR_FORMAT \u003d \u0027%Y-%m-%dT%H:%M:%S\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_56777903","line":185,"range":{"start_line":172,"start_character":0,"end_line":185,"end_character":26},"updated":"2019-05-09 15:44:28.000000000","message":"I am confused with the intention here. We already have a way of checking the status in line 157 so why do we have a kind of duplication in line 180.\n\nIs the intention here to track the \"status\" or the \"result\"? If it\u0027s just \"status\" then we can reuse definition from Line 157. if it\u0027s result then we can remove the definiton at line 180.\n\nAlso if we are interested in knowing the final result of the deployment then it has to be either \"success\" or \"failed\" and not \"pending\". For eg- If the deployment status is still \"pending\" even after the specified timeout period then result should indicate as \"failed\".","commit_id":"eff10dab47faff969b2366cc8dacf327ca122069"},{"author":{"_account_id":30106,"name":"Matt Carter","email":"matt.coach.carter@gmail.com","username":"MattCarter"},"change_message_id":"4e815e6049c02867aaf71fae520b2196ea1db500","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        \u0027PAUSED\u0027: \u0027Paused\u0027"},{"line_number":170,"context_line":"    }"},{"line_number":171,"context_line":"    # Mapping of lifecycle to result (for deployment-status)"},{"line_number":172,"context_line":"    LIFECYCLE_RESULT_MAPPING \u003d {"},{"line_number":173,"context_line":"        \u0027failed\u0027: \u0027failed\u0027,"},{"line_number":174,"context_line":"        \u0027processing\u0027: \u0027pending\u0027,"},{"line_number":175,"context_line":"        \u0027pending\u0027: \u0027pending\u0027,"},{"line_number":176,"context_line":"        \u0027complete\u0027: \u0027successful\u0027,"},{"line_number":177,"context_line":"        \u0027paused\u0027: \u0027pending\u0027"},{"line_number":178,"context_line":"    }"},{"line_number":179,"context_line":"    # Mapping of lifecycle to status (for deployment-status)"},{"line_number":180,"context_line":"    LIFECYCLE_STATUS_MAPPING \u003d {"},{"line_number":181,"context_line":"        \u0027failed\u0027: \u0027completed\u0027,"},{"line_number":182,"context_line":"        \u0027processing\u0027: \u0027running\u0027,"},{"line_number":183,"context_line":"        \u0027pending\u0027: \u0027pending\u0027,"},{"line_number":184,"context_line":"        \u0027complete\u0027: \u0027completed\u0027,"},{"line_number":185,"context_line":"        \u0027paused\u0027: \u0027paused\u0027"},{"line_number":186,"context_line":"    }"},{"line_number":187,"context_line":"    # Just so we are consistent:"},{"line_number":188,"context_line":"    EXECUTION_DATETIME_STR_FORMAT \u003d \u0027%Y-%m-%dT%H:%M:%S\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_2f32a4a8","line":185,"range":{"start_line":172,"start_character":0,"end_line":185,"end_character":26},"in_reply_to":"dfbec78f_56777903","updated":"2019-05-09 16:04:22.000000000","message":"The intention here was to provide a simple mapping from the lifecycle of the action to the desired \"status\" field data in the deployment-status document.\n\nI would expect a timed-out action to have a status of \"completed\" and a result of \"failed\"","commit_id":"eff10dab47faff969b2366cc8dacf327ca122069"},{"author":{"_account_id":22259,"name":"Nishant Kumar","email":"nishant.e.kumar@att.com","username":"nishant.e.kumar"},"change_message_id":"dd8a0d50decea1860fcc03f69f477025081da8fa","unresolved":false,"context_lines":[{"line_number":727,"context_line":"                                                     \u0027unknown\u0027)"},{"line_number":728,"context_line":"        return result.lower()"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"    def _get_deployment_status_status(self):"},{"line_number":731,"context_line":"        \"\"\"Convert the action\u0027s lifecycle to a status string"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        :returns: A string denoting the status of the action"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_76ecfdf2","line":730,"range":{"start_line":730,"start_character":24,"end_line":730,"end_character":37},"updated":"2019-05-09 15:44:28.000000000","message":"This looks confusing","commit_id":"eff10dab47faff969b2366cc8dacf327ca122069"},{"author":{"_account_id":30106,"name":"Matt Carter","email":"matt.coach.carter@gmail.com","username":"MattCarter"},"change_message_id":"4e815e6049c02867aaf71fae520b2196ea1db500","unresolved":false,"context_lines":[{"line_number":727,"context_line":"                                                     \u0027unknown\u0027)"},{"line_number":728,"context_line":"        return result.lower()"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"    def _get_deployment_status_status(self):"},{"line_number":731,"context_line":"        \"\"\"Convert the action\u0027s lifecycle to a status string"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        :returns: A string denoting the status of the action"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_cf70a8a8","line":730,"range":{"start_line":730,"start_character":24,"end_line":730,"end_character":37},"in_reply_to":"dfbec78f_76ecfdf2","updated":"2019-05-09 16:04:22.000000000","message":"Agreed, I will update these function names to make a little more sense.","commit_id":"eff10dab47faff969b2366cc8dacf327ca122069"},{"author":{"_account_id":22259,"name":"Nishant Kumar","email":"nishant.e.kumar@att.com","username":"nishant.e.kumar"},"change_message_id":"dd8a0d50decea1860fcc03f69f477025081da8fa","unresolved":false,"context_lines":[{"line_number":744,"context_line":"        deckhand revision associated with this action"},{"line_number":745,"context_line":"        :rtype: str"},{"line_number":746,"context_line":"        \"\"\""},{"line_number":747,"context_line":"        helper \u003d DesignRefHelper()"},{"line_number":748,"context_line":"        return helper.get_design_reference_href(self.committed_rev_id)"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"    def get_deployment_status(self):"},{"line_number":751,"context_line":"        \"\"\"Create and return a collection of deployment-status data"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_f6e0edfc","line":748,"range":{"start_line":747,"start_character":0,"end_line":748,"end_character":70},"updated":"2019-05-09 15:44:28.000000000","message":"This could be -  \n\"DesignRefHelper().get_design_reference_href(self.committed_rev_id)\"\n\nCould possibly remove this function and use it directly on line 762.","commit_id":"eff10dab47faff969b2366cc8dacf327ca122069"},{"author":{"_account_id":30106,"name":"Matt Carter","email":"matt.coach.carter@gmail.com","username":"MattCarter"},"change_message_id":"4e815e6049c02867aaf71fae520b2196ea1db500","unresolved":false,"context_lines":[{"line_number":744,"context_line":"        deckhand revision associated with this action"},{"line_number":745,"context_line":"        :rtype: str"},{"line_number":746,"context_line":"        \"\"\""},{"line_number":747,"context_line":"        helper \u003d DesignRefHelper()"},{"line_number":748,"context_line":"        return helper.get_design_reference_href(self.committed_rev_id)"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"    def get_deployment_status(self):"},{"line_number":751,"context_line":"        \"\"\"Create and return a collection of deployment-status data"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_cfa50806","line":748,"range":{"start_line":747,"start_character":0,"end_line":748,"end_character":70},"in_reply_to":"dfbec78f_f6e0edfc","updated":"2019-05-09 16:04:22.000000000","message":"For me it\u0027s just personal preference to put a thin wrapper around using DesignRefHelper in order to generate the URL. I was also worried that putting this all on one line would look a little too dense, but I\u0027m cool with knocking it down to one line if that isn\u0027t an issue.","commit_id":"eff10dab47faff969b2366cc8dacf327ca122069"},{"author":{"_account_id":22259,"name":"Nishant Kumar","email":"nishant.e.kumar@att.com","username":"nishant.e.kumar"},"change_message_id":"dd8a0d50decea1860fcc03f69f477025081da8fa","unresolved":false,"context_lines":[{"line_number":755,"context_line":"        \"\"\""},{"line_number":756,"context_line":"        self.determine_lifecycle()"},{"line_number":757,"context_line":"        return {"},{"line_number":758,"context_line":"            \u0027status\u0027: self._get_deployment_status_status(),"},{"line_number":759,"context_line":"            \u0027results\u0027: self._get_deployment_status_result(),"},{"line_number":760,"context_line":"            \u0027context\u0027: self.context_marker,"},{"line_number":761,"context_line":"            \u0027action\u0027: self.id,"},{"line_number":762,"context_line":"            \u0027document_url\u0027: self._make_deckhand_doc_url(),"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_d9ab9a86","line":759,"range":{"start_line":758,"start_character":12,"end_line":759,"end_character":60},"updated":"2019-05-09 15:44:28.000000000","message":"Do we still need both the \"status\" and \"result\"? If yes then i guess status \"document/data\" needs to be seperate than the \"result\" data.\nFor eg- In this implementation, if the status is \"processing\" then result is \"pending\" which could be confusing as result should indicate the final output of the deployment ie, either \"success\" or \"failure\"","commit_id":"eff10dab47faff969b2366cc8dacf327ca122069"},{"author":{"_account_id":30106,"name":"Matt Carter","email":"matt.coach.carter@gmail.com","username":"MattCarter"},"change_message_id":"4e815e6049c02867aaf71fae520b2196ea1db500","unresolved":false,"context_lines":[{"line_number":755,"context_line":"        \"\"\""},{"line_number":756,"context_line":"        self.determine_lifecycle()"},{"line_number":757,"context_line":"        return {"},{"line_number":758,"context_line":"            \u0027status\u0027: self._get_deployment_status_status(),"},{"line_number":759,"context_line":"            \u0027results\u0027: self._get_deployment_status_result(),"},{"line_number":760,"context_line":"            \u0027context\u0027: self.context_marker,"},{"line_number":761,"context_line":"            \u0027action\u0027: self.id,"},{"line_number":762,"context_line":"            \u0027document_url\u0027: self._make_deckhand_doc_url(),"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_2f3b849c","line":759,"range":{"start_line":758,"start_character":12,"end_line":759,"end_character":60},"in_reply_to":"dfbec78f_d9ab9a86","updated":"2019-05-09 16:04:22.000000000","message":"I\u0027m not sure I 100% understood what you meant by \"i guess status \u0027document/data\u0027 needs to be seperate than the \u0027result\u0027 data.\"\n\nIt is desired that status and result are separate fields.\nThe idea behind status being \"whether or not the SY action was completed or in-progress\"\nThe idea behind result being \"whether or not the SY action was successful\"\nThat being said, I\u0027m open to what the potential values of status and result should be. I chose things that made sense to me, but that doesn\u0027t mean it makes sense to everyone.","commit_id":"eff10dab47faff969b2366cc8dacf327ca122069"}]}